Re: [libvirt] make docs fails on EL5

2011-11-16 Thread Daniel Berteaud
Le mercredi 16 novembre 2011 à 11:57 +0800, Osier Yang a écrit : 于 2011年11月16日 11:12, shu ming 写道: It seems tit is he same issue as the thread below, the docs can not be generated in some Linux distros. It may be caused by the incompatibility of document tools in these distros.

[libvirt] [PATCH] fix a bug in remoteSerializeTypedParameters

2011-11-16 Thread Hu Tao
This is a fatal typo believed to be very likely to happen when using both i and j at the same time for indexing. --- daemon/remote.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 857835e..97c9538 100644 --- a/daemon/remote.c +++

Re: [libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput

2011-11-16 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 08:32:30PM +0100, Marc-André Lureau wrote: The bus argument could be an enum too (xen (paravirtualized), ps2 and usb) I've just changed this. Christophe pgpVICztbG0IW.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

[libvirt] libvirt support on QNX

2011-11-16 Thread Chandrashekhar Jamadarkhani (cjamadar)
Hi, I'm planning to use libvirt in a remote machine which is running on QNX RTOS. Whether libvirt is ported to QNX, if not any problems in porting libvirt lib to QNX ? Appreciate your help on this. Thanks, Chandrashekhar -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput

2011-11-16 Thread Christophe Fergeau
On Tue, Nov 15, 2011 at 07:32:49PM +0100, Marc-André Lureau wrote: On Tue, Nov 15, 2011 at 7:25 PM, Christophe Fergeau cferg...@redhat.com wrote: What are you referring to? GVirConfigGraphicsSpice and GVirConfigInterface? yes, all the classes that are nodes under devices I dropped the

Re: [libvirt] compile fail on FreeBSD

2011-11-16 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 03:24:11PM -0700, Eric Blake wrote: On 11/15/2011 04:08 AM, Daniel P. Berrange wrote: On Fri, Nov 11, 2011 at 05:31:14PM -0700, Eric Blake wrote: This failure on FreeBSD 8.2 popped up this week, and I suspect Dan's virnetdev refactoring, but haven't had time to

Re: [libvirt] [PATCH v3] Add support for systemd init service

2011-11-16 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 04:02:23PM -0700, Eric Blake wrote: On 11/15/2011 04:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Followup to https://www.redhat.com/archives/libvir-list/2011-November/msg00580.html This patch adds support for a systemd

Re: [libvirt] [PATCH v5 4/4] qemu/rbd: improve rbd device specification

2011-11-16 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 05:05:27PM -0700, Eric Blake wrote: On 10/31/2011 07:29 PM, Josh Durgin wrote: From: Sage Weil s...@newdream.net +if (sec) { +char *base64 = NULL; + +secret = (char *)conn-secretDriver-getValue(sec, secret_size, 0, +

Re: [libvirt] [PATCH V1 1/9] Add support for VLAN filtering

2011-11-16 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 05:46:21PM -0700, Eric Blake wrote: On 10/26/2011 09:11 AM, Stefan Berger wrote: Apologies for delaying so long on reviewing this. This patch adds support for filtering of VLAN (802.1Q) traffic to the parser and makes us of the ebtables support for VLAN filtering.

Re: [libvirt] [PATCH] util : fix compile error on fedora14 Add src/util/virnetdevbandwidth.h, src/util/virnetdevveth.h, src/util/virnetdevvportprofile.h to private symbols.

2011-11-16 Thread Daniel P. Berrange
On Wed, Nov 16, 2011 at 09:36:06AM +0800, ta...@linux.vnet.ibm.com wrote: From: Eli Qiao ta...@linux.vnet.ibm.com Signed-off-by: Eli Qiao ta...@linux.vnet.ibm.com --- src/libvirt_private.syms | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH] Fix build with polkit0

2011-11-16 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 03:39:28PM -0700, Jim Fehlig wrote: I missed adding libvirt_driver_remote.la to libvirtd_LDADD in commit b8adfcc6, which didn't cause a problem in 0.9.6 but results in this build error in 0.9.7 libvirtd-remote.o: In function `remoteDispatchAuthPolkit':

Re: [libvirt] libvirt support on QNX

2011-11-16 Thread Daniel P. Berrange
On Wed, Nov 16, 2011 at 03:32:19PM +0530, Chandrashekhar Jamadarkhani (cjamadar) wrote: Hi, I'm planning to use libvirt in a remote machine which is running on QNX RTOS. Whether libvirt is ported to QNX, if not any problems in porting libvirt lib to QNX ? AFAIK, no one has ever said

Re: [libvirt] libvirt support on QNX

2011-11-16 Thread Chandrashekhar Jamadarkhani (cjamadar)
Hi Daniel, Thanks Daniel for the info. I was talking only about porting libvirt RPC client driver to qnx for starting/monitoring VMs running on remote RHEL based host. Let me try porting the libvirt RPC client driver to QNX. Thanks, Chandrashekhar -Original Message- From: Daniel P.

Re: [libvirt] [PATCH V1 1/9] Add support for VLAN filtering

2011-11-16 Thread Stefan Berger
On 11/15/2011 07:46 PM, Eric Blake wrote: On 10/26/2011 09:11 AM, Stefan Berger wrote: Apologies for delaying so long on reviewing this. This patch adds support for filtering of VLAN (802.1Q) traffic to the parser and makes us of the ebtables support for VLAN filtering. This code now enables

Re: [libvirt] [PATCH] Fix tip of git

2011-11-16 Thread Stefan Berger
On 11/15/2011 04:41 PM, Eric Blake wrote: On 11/15/2011 12:40 PM, Stefan Berger wrote: I get these type of compilation errors: In file included from util/virnetdevvportprofile.c:25:0: util/virnetdevvportprofile.h:49:13: error: expected specifier-qualifier-list before 'uint8_t'

[libvirt] [PATCH] Add support for systemd init service

2011-11-16 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com This patch adds support for a systemd init service for libvirtd and libvirt-guests. The libvirtd.service is *not* written to use socket activation, since we want libvirtd to start on boot so it can do guest auto-start. The libvirt-guests.service is

Re: [libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput

2011-11-16 Thread Marc-André Lureau
On Wed, Nov 16, 2011 at 11:04 AM, Christophe Fergeau cferg...@redhat.com wrote: I dropped the Device from GraphicsSpice because the name was getting really long (not a great reason for doing this). I used the GVirConfigInterface name because there was already such a file in git, so I reused it.

Re: [libvirt] [libvirt-glib 2/3] Add some basic information to README

2011-11-16 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 08:12:28PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- README | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/README b/README index e69de29..866ec53 100644 ---

Re: [libvirt] [libvirt-glib 3/3] Release 0.0.1

2011-11-16 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 08:12:29PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- NEWS |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index e69de29..015fab8 100644 --- a/NEWS +++ b/NEWS @@ -0,0 +1,5 @@

Re: [libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput

2011-11-16 Thread Christophe Fergeau
On Wed, Nov 16, 2011 at 01:25:43PM +0100, Marc-André Lureau wrote: I am afraid if we drop the Device prefix, we may confuse it with host devices http://libvirt.org/formatnetwork.html. In this case this would be ConfigInterfaceNetwork vs ConfigNetwork. Christophe pgp7RkzT4BtTv.pgp

Re: [libvirt] [libvirt PATCHv5 1/2] add DHCP snooping

2011-11-16 Thread Stefan Berger
On 11/10/2011 03:28 PM, David L Stevens wrote: This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevensdlstev...@us.ibm.com --- docs/formatnwfilter.html.in | 17 + examples/xml/nwfilter/no-ip-spoofing.xml |5 + src/Makefile.am

[libvirt] [PATCH] qemu: Copy console definition from serial

2011-11-16 Thread Michal Privoznik
Now, when we support multiple consoles per domain, the vm-def-console[0] can still remain an alias for vm-def-serial[0]; However, we need to copy it's source definition as well otherwise we'll regress on virDomainOpenConsole. --- src/conf/domain_conf.c | 72

Re: [libvirt] [libvirt PATCHv5 2/2] add leasefile support

2011-11-16 Thread Stefan Berger
On 11/10/2011 03:28 PM, David L Stevens wrote: This patch adds support for saving DHCP snooping leases to an on-disk file and restoring saved leases that are still active on restart. Signed-off-by: David L Stevensdlstev...@us.ibm.com --- src/nwfilter/nwfilter_dhcpsnoop.c | 270

[libvirt] ANNOUNCE: libvirt-glib release 0.0.1

2011-11-16 Thread Daniel P. Berrange
I am pleased to announce the first release of the libvirt-glib package, version 0.0.1 is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key ID: 15104FDF Daniel P. Berrange berra...@redhat.com Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86

[libvirt] [PATCH v5] Add support for systemd init service

2011-11-16 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com This patch adds support for a systemd init service for libvirtd and libvirt-guests. The libvirtd.service is *not* written to use socket activation, since we want libvirtd to start on boot so it can do guest auto-start. The libvirt-guests.service is

[libvirt] RPM spec file patch

2011-11-16 Thread Chris Picton
Hi Please accept the following patch to the rpm spec file. It allows me to enable specific options (like openvz) at the build comand line, even if they have been disabled by OS feature selection. eg for an openvz build on centos 6 rpmbuild -bb \ --define 'rhel 6' \ --without dtrace \

Re: [libvirt] [PATCH] qemu: Copy console definition from serial

2011-11-16 Thread Dave Allan
I haven't code reviewed it, but it fixes serial console on my system, so ack to the functionality. Dave On Wed, Nov 16, 2011 at 02:14:52PM +0100, Michal Privoznik wrote: Now, when we support multiple consoles per domain, the vm-def-console[0] can still remain an alias for vm-def-serial[0];

Re: [libvirt] [PATCH v5 4/4] qemu/rbd: improve rbd device specification

2011-11-16 Thread Eric Blake
On 11/15/2011 06:37 PM, Josh Durgin wrote: The command line that we pass to qemu gets logged. But what happens if the secret was marked as ephemeral - could we be violating the premise of not exposing passwords to too broad an audience? Or are we already safe in that the log entries created

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume

2011-11-16 Thread Eric Blake
On 11/15/2011 08:20 PM, Dave Allan wrote: After working on this some more, I think that identifying problematic file systems, like devtmpfs, is too tricky to be portable. But I think we can meet halfway - right now, the libvirt code blindly generates a filename if one was not provided,

Re: [libvirt] [PATCH] fix a bug in remoteSerializeTypedParameters

2011-11-16 Thread Eric Blake
On 11/16/2011 01:38 AM, Hu Tao wrote: This is a fatal typo believed to be very likely to happen when using both i and j at the same time for indexing. Yep, and thanks for catching it. --- daemon/remote.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] Fix build with polkit0

2011-11-16 Thread Jim Fehlig
Daniel P. Berrange wrote: On Tue, Nov 15, 2011 at 03:39:28PM -0700, Jim Fehlig wrote: I missed adding libvirt_driver_remote.la to libvirtd_LDADD in commit b8adfcc6, which didn't cause a problem in 0.9.6 but results in this build error in 0.9.7 libvirtd-remote.o: In function

[libvirt] [PATCH] virsh: add iface-bridge and iface-unbridge commands

2011-11-16 Thread Laine Stump
One of the top questions by libvirt users is how to create a host bridge device so that guests can be directly on the physical network. There are several example documents that explain how to do this manually, but following them often results in confusion and failure. virt-manager does a good job

[libvirt] [PATCH] Bug Fix: Do not release network actual device in qemuBuildCommandLine on error

2011-11-16 Thread Roopa Prabhu
From: Roopa Prabhu ropra...@cisco.com For direct attach devices, in qemuBuildCommandLine, we seem to be freeing actual device on error path (with networkReleaseActualDevice). But the actual device is not deleted. qemuProcessStop eventually deletes the direct attach device and releases actual

[libvirt] [PATCH 0/2] Fix build with polkit0

2011-11-16 Thread Jim Fehlig
Commit 0f590c62 was not the proper fix for polkit0 build issue. This series reverts 0f590c62 and adds virNetServerGetDBusConn() to libvirt_private.syms Jim Fehlig (2): Revert commit 0f590c62 Fix build with polkit0 daemon/Makefile.am |4 src/libvirt_private.syms |1 + 2

[libvirt] [PATCH 1/2] Revert commit 0f590c62

2011-11-16 Thread Jim Fehlig
As noted by Daniel Berrange [1], the proper fix for the older PolicyKit build issue is to add virNetServerGetDBusConn to libvirt_private.syms. Revert unnecessary changes to daemon/Makefile.am [1] https://www.redhat.com/archives/libvir-list/2011-November/msg00852.html --- daemon/Makefile.am |

[libvirt] [PATCH 2/2] Fix build with polkit0

2011-11-16 Thread Jim Fehlig
I missed adding virNetServerGetDBusConn() to libvirtd_private.syms in commit b8adfcc6, which didn't cause a problem in 0.9.6 but results in this build error in 0.9.7 libvirtd-remote.o: In function `remoteDispatchAuthPolkit': remote.c:(.text+0x188dd): undefined reference to

Re: [libvirt] [PATCH] virsh: add iface-bridge and iface-unbridge commands

2011-11-16 Thread Eric Blake
On 11/16/2011 11:04 AM, Laine Stump wrote: One of the top questions by libvirt users is how to create a host bridge device so that guests can be directly on the physical network. There are several example documents that explain how to do this manually, but following them often results in

[libvirt] Libvirt block live migration with OpenStack Diablo

2011-11-16 Thread Doude
Hi all, I use OpenStack Diablo release 2011.3-0ubuntu6.2 on ubuntu 11.10 with libvirt 0.9.2-4ubuntu15.1 I try to block migrate a VM from one host to another one. OpenStack uses the 'migrateToURI' method from libvirt python library. But this call fails. Libvirt log : - Source host: 18:27:30.475:

Re: [libvirt] [PATCH 0/2] Fix build with polkit0

2011-11-16 Thread Eric Blake
On 11/16/2011 11:46 AM, Jim Fehlig wrote: Commit 0f590c62 was not the proper fix for polkit0 build issue. This series reverts 0f590c62 and adds virNetServerGetDBusConn() to libvirt_private.syms Jim Fehlig (2): Revert commit 0f590c62 Fix build with polkit0 ACK series, and sorry for my

Re: [libvirt] [PATCH] virsh: add iface-bridge and iface-unbridge commands

2011-11-16 Thread Laine Stump
On 11/16/2011 01:50 PM, Eric Blake wrote: I'll live up to my well-earned reputation :), and request that you don't push this without first squashing in docs (but to soften the blow, here's my first cut at something you can squash in). ACK with above nits fixed and man page docs added. I

Re: [libvirt] [PATCH 0/2] Fix build with polkit0

2011-11-16 Thread Jim Fehlig
Eric Blake wrote: On 11/16/2011 11:46 AM, Jim Fehlig wrote: Commit 0f590c62 was not the proper fix for polkit0 build issue. This series reverts 0f590c62 and adds virNetServerGetDBusConn() to libvirt_private.syms Jim Fehlig (2): Revert commit 0f590c62 Fix build with polkit0

Re: [libvirt] RPM spec file patch

2011-11-16 Thread Eric Blake
On 11/15/2011 11:42 PM, Chris Picton wrote: Hi Please accept the following patch to the rpm spec file. It allows me to enable specific options (like openvz) at the build comand line, even if they have been disabled by OS feature selection. eg for an openvz build on centos 6 rpmbuild

Re: [libvirt] [PATCH] Add support for systemd init service

2011-11-16 Thread Eric Blake
On 11/16/2011 05:01 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This patch adds support for a systemd init service for libvirtd and libvirt-guests. The libvirtd.service is *not* written to use socket activation, since we want libvirtd to start on boot so it

Re: [libvirt] [PATCH v5] Add support for systemd init service

2011-11-16 Thread Eric Blake
On 11/16/2011 07:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This patch adds support for a systemd init service for libvirtd and libvirt-guests. The libvirtd.service is *not* written to use socket activation, since we want libvirtd to start on boot so it

Re: [libvirt] [PATCH] qemu: Copy console definition from serial

2011-11-16 Thread Eric Blake
On 11/16/2011 06:14 AM, Michal Privoznik wrote: Now, when we support multiple consoles per domain, the vm-def-console[0] can still remain an alias for vm-def-serial[0]; However, we need to copy it's source definition as well otherwise we'll regress on virDomainOpenConsole. ---

Re: [libvirt] [PATCH v5] Add support for systemd init service

2011-11-16 Thread Laine Stump
On 11/16/2011 09:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com This patch adds support for a systemd init service for libvirtd and libvirt-guests. The libvirtd.service is *not* written to use socket activation, since we want libvirtd to start on boot so it can do

Re: [libvirt] [PATCH V4 01/10] Extend virHashTable with function to get hash tables keys

2011-11-16 Thread Eric Blake
On 10/26/2011 05:36 AM, Stefan Berger wrote: Add a function to the virHashTable for getting an array of the hash table's keys and have the keys (optionally) sorted. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/libvirt_private.syms |3 + src/util/hash.c |

Re: [libvirt] [PATCH V4 02/10] Introduce an internal priority for chains

2011-11-16 Thread Eric Blake
On 10/26/2011 05:36 AM, Stefan Berger wrote: For better handling of the sorting of chains introduce an internally used priority. Use a lookup table to store the priorities. For now their actual values do not matter just that the values cause the chains to be properly sorted through changes in

Re: [libvirt] [PATCH V4 03/10] Make filter creation in root table more flexible

2011-11-16 Thread Eric Blake
On 10/26/2011 05:36 AM, Stefan Berger wrote: Use the previously introduced chain priorities to sort the chains for access from an interface's 'root' table and have them created in the proper order. This gets rid of a lot of code that was previously creating the chains in a more hardcoded way.

Re: [libvirt] [PATCH V4 01/10] Extend virHashTable with function to get hash tables keys

2011-11-16 Thread Stefan Berger
On 11/16/2011 07:32 PM, Eric Blake wrote: On 10/26/2011 05:36 AM, Stefan Berger wrote: Add a function to the virHashTable for getting an array of the hash table's keys and have the keys (optionally) sorted. Signed-off-by: Stefan Bergerstef...@linux.vnet.ibm.com --- src/libvirt_private.syms

Re: [libvirt] RPM spec file patch

2011-11-16 Thread Chris Picton
On Wed, 2011-11-16 at 15:31 -0700, Eric Blake wrote: On 11/15/2011 11:42 PM, Chris Picton wrote: Hi Please accept the following patch to the rpm spec file. Thanks for the report. However, I'm not yet quite convinced that your proposed patch is the best approach. I'll explain,

[libvirt] New feature for libvirt

2011-11-16 Thread Amit Tewari
Hi, I wanted to suggest a new feature development in libvirt network filter. Currently in libvirt network filter there is no support for ip aliasing, but we want to add this feature so that libvirt learns multiple ip address for a virtual machine. With this feature we will be able to get