Re: [libvirt] virt-viewer, requirement question

2011-11-21 Thread Daniel P. Berrange
On Fri, Nov 18, 2011 at 03:38:07PM -0800, Jason Helfman wrote: I see that this was moved to vncconnection.h, however I don't see this patch in there. Is this patch still relevant to the code? http://osdir.com/ml/gtk-vnc-list/2009-11/msg00029.html Thanks, Jason This has already been

Re: [libvirt] [virt-tools-list] [osinfo PATCH 1/8] Add #include string.h for strcmp

2011-11-21 Thread Daniel P. Berrange
On Fri, Nov 18, 2011 at 11:26:21AM -0700, Eric Blake wrote: [adding virt-tools-list] On 11/18/2011 11:04 AM, Christophe Fergeau wrote: --- tools/osinfo-detect.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/osinfo-detect.c b/tools/osinfo-detect.c

[libvirt] [PATCH] Fix build on Mingw32 wrt export of virNetServerGetDBusConn

2011-11-21 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Mingw32 complains if you request export of a symbol which does not in fact exist. * src/libvirt_bridge.syms, src/libvirt_macvtap.syms: Delete obsolete files * src/libvirt_private.syms: Remove virNetServerGetDBusConn * src/libvirt_dbus.syms: Add

Re: [libvirt] [PATCH] Bug Fix: Do not release network actual device in qemuBuildCommandLine on error

2011-11-21 Thread Stefan Berger
On 11/16/2011 09:34 PM, Roopa Prabhu wrote: From: Roopa Prabhuropra...@cisco.com For direct attach devices, in qemuBuildCommandLine, we seem to be freeing actual device on error path (with networkReleaseActualDevice). But the actual device is not deleted. qemuProcessStop eventually deletes the

[libvirt] [TCK] [PATCH] nwfilter: Add '-n' flag to iptables command where missing

2011-11-21 Thread Stefan Berger
Add the -n flag to the iptables command where it is missing to avoid delays due to name resolution. --- scripts/nwfilter/nwfilterxml2fwallout/all-test.fwall |9 + scripts/nwfilter/nwfilterxml2fwallout/target-test.fwall |8

[libvirt] [TCK][PATCH] add more test cases

2011-11-21 Thread Stefan Berger
This patch adds a couple more test cases (especially for IPv6 configurations) to the network test 100. Again make sure that some of the parameters from tck-testnet's XML have made it into command line parameters of dnsmasq. --- scripts/networks/networkxml2hostout/tck-testnet-3.dat | 49

[libvirt] [TCK][PATCH] nwfilter: Add test cases for vlan and stp filtering

2011-11-21 Thread Stefan Berger
Add test cases for VLAN and (upcoming) STP. --- scripts/nwfilter/nwfilterxml2fwallout/stp-test.fwall | 14 + scripts/nwfilter/nwfilterxml2fwallout/vlan-test.fwall | 15 ++ scripts/nwfilter/nwfilterxml2xmlin/stp-test.xml | 26 ++

[libvirt] [TCK] [PATCH] networks: Fix some errors in test 100

2011-11-21 Thread Stefan Berger
Network test 100 when run via sh ./networkApplyTest.sh --tap-test --verbose --wait currently exhibits some problems. This patch fixes them. I now only looking for dnsmasq to be running with some of the parameters from tck-testnet having gone into its command line arguments. ---

Re: [libvirt] [TCK] [PATCH] nwfilter: Add '-n' flag to iptables command where missing

2011-11-21 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:20:28AM -0500, Stefan Berger wrote: Add the -n flag to the iptables command where it is missing to avoid delays due to name resolution. --- scripts/nwfilter/nwfilterxml2fwallout/all-test.fwall |9 +

Re: [libvirt] [TCK][PATCH] add more test cases

2011-11-21 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:40:14AM -0500, Stefan Berger wrote: This patch adds a couple more test cases (especially for IPv6 configurations) to the network test 100. Again make sure that some of the parameters from tck-testnet's XML have made it into command line parameters of dnsmasq. ---

Re: [libvirt] [TCK][PATCH] nwfilter: Add test cases for vlan and stp filtering

2011-11-21 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:43:49AM -0500, Stefan Berger wrote: Add test cases for VLAN and (upcoming) STP. --- scripts/nwfilter/nwfilterxml2fwallout/stp-test.fwall | 14 + scripts/nwfilter/nwfilterxml2fwallout/vlan-test.fwall | 15 ++

Re: [libvirt] [TCK] [PATCH] networks: Fix some errors in test 100

2011-11-21 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:26:18AM -0500, Stefan Berger wrote: Network test 100 when run via sh ./networkApplyTest.sh --tap-test --verbose --wait currently exhibits some problems. This patch fixes them. I now only looking for dnsmasq to be running with some of the parameters from

[libvirt] [PATCH 2/2] nwfilter: use shell variable to invoke 'ip(6)tables' command

2011-11-21 Thread Stefan Berger
Introduce a shell variable 'IBT' to invoke the ip(6)tables command. Tested with libvirt-tck. --- src/nwfilter/nwfilter_ebiptables_driver.c | 313 ++ 1 file changed, 155 insertions(+), 158 deletions(-) Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c

[libvirt] [PATCH 1/2] nwfilter: use shell variable to invoke 'ebtables' command

2011-11-21 Thread Stefan Berger
Introduce a shell variable 'EBT' to invoke the ebtables command. Hard-code the used ebtables table to '-t nat'. Tested with libvirt-tck. --- src/nwfilter/nwfilter_ebiptables_driver.c | 170 +- 1 file changed, 97 insertions(+), 73 deletions(-) Index:

[libvirt] problem with nwfilter and ip6tables

2011-11-21 Thread Reinier Schoof
Hi, I'm investigating using the nwfilter-functionality of libvirt to give my clients the possibility to block ports of their VPSes. The same mechanism allows me to restrict the outgoing traffic a VPS is generating. In the end, I want to restrict MAC, IPv4 and IPv6 traffic, while the client

Re: [libvirt] [PATCH] qemu: Copy console definition from serial

2011-11-21 Thread Michal Privoznik
On 17.11.2011 00:33, Eric Blake wrote: On 11/16/2011 06:14 AM, Michal Privoznik wrote: Now, when we support multiple consoles per domain, the vm-def-console[0] can still remain an alias for vm-def-serial[0]; However, we need to copy it's source definition as well otherwise we'll regress on

Re: [libvirt] [TCK][PATCH] add more test cases

2011-11-21 Thread Stefan Berger
On 11/21/2011 08:21 AM, Daniel P. Berrange wrote: On Mon, Nov 21, 2011 at 07:40:14AM -0500, Stefan Berger wrote: This patch adds a couple more test cases (especially for IPv6 configurations) to the network test 100. Again make sure that some of the parameters from tck-testnet's XML have made it

Re: [libvirt] [TCK] [PATCH] nwfilter: Add '-n' flag to iptables command where missing

2011-11-21 Thread Stefan Berger
On 11/21/2011 08:18 AM, Daniel P. Berrange wrote: On Mon, Nov 21, 2011 at 07:20:28AM -0500, Stefan Berger wrote: Add the -n flag to the iptables command where it is missing to avoid delays due to name resolution. --- scripts/nwfilter/nwfilterxml2fwallout/all-test.fwall |9 +

Re: [libvirt] [TCK] [PATCH] networks: Fix some errors in test 100

2011-11-21 Thread Stefan Berger
On 11/21/2011 08:19 AM, Daniel P. Berrange wrote: On Mon, Nov 21, 2011 at 07:26:18AM -0500, Stefan Berger wrote: Network test 100 when run via sh ./networkApplyTest.sh --tap-test --verbose --wait currently exhibits some problems. This patch fixes them. I now only looking for dnsmasq to be

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume

2011-11-21 Thread shu ming
On 2011-11-21 9:51, MATSUDA, Daiki wrote: Sorry, I confirmed the snapshot file is not wrong. I moved the snapshot file created under /dev as /dev/VG1/abc.xx to other place and fixed the config file re-writed by libvirt to use moved snapshot file abc.xx. So, the domain starts with no

Re: [libvirt] problem with nwfilter and ip6tables

2011-11-21 Thread Stefan Berger
On 11/21/2011 08:46 AM, Reinier Schoof wrote: Hi, I'm investigating using the nwfilter-functionality of libvirt to give my clients the possibility to block ports of their VPSes. The same mechanism allows me to restrict the outgoing traffic a VPS is generating. In the end, I want to restrict

Re: [libvirt] problem with nwfilter and ip6tables

2011-11-21 Thread Reinier Schoof
Hi Stefan, thanks for your quick response Op 21-11-2011 15:21, Stefan Berger schreef: On 11/21/2011 08:46 AM, Reinier Schoof wrote: Hi, I'm investigating using the nwfilter-functionality of libvirt to give my clients the possibility to block ports of their VPSes. The same mechanism allows me

Re: [libvirt] [PATCH] qemu: Copy console definition from serial

2011-11-21 Thread Dave Allan
On Mon, Nov 21, 2011 at 02:52:21PM +0100, Michal Privoznik wrote: On 17.11.2011 00:33, Eric Blake wrote: On 11/16/2011 06:14 AM, Michal Privoznik wrote: Now, when we support multiple consoles per domain, the vm-def-console[0] can still remain an alias for vm-def-serial[0]; However, we

Re: [libvirt] [PATCH] Fix build on Mingw32 wrt export of virNetServerGetDBusConn

2011-11-21 Thread Eric Blake
On 11/21/2011 04:47 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Mingw32 complains if you request export of a symbol which does not in fact exist. * src/libvirt_bridge.syms, src/libvirt_macvtap.syms: Delete obsolete files * src/libvirt_private.syms: Remove

Re: [libvirt] problem with nwfilter and ip6tables

2011-11-21 Thread Stefan Berger
On 11/21/2011 08:46 AM, Reinier Schoof wrote: Going back to the original email: Hi, I'm investigating using the nwfilter-functionality of libvirt to give my clients the possibility to block ports of their VPSes. The same mechanism allows me to restrict the outgoing traffic a VPS is

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Marc-André Lureau
Hi Hi Agreed with the comments from teuf + On Fri, Nov 18, 2011 at 8:24 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: +void gvir_connection_redefine_domain(GVirConnection *conn, +                                     GVirDomain *domain, +                                    

Re: [libvirt] [libvirt-glib 11/37] Implement gvir_config_os_set_os_type

2011-11-21 Thread Christophe Fergeau
Hey, On Tue, Nov 15, 2011 at 03:33:45PM +0100, Marc-André Lureau wrote: However, thinking a bit more about it, genum_get_nick() shouldn't warn if given a value that has no associated nick, because enums shouldn't be limited to their associated name, and those value would be perfectly valid,

[libvirt] libvirt-gconfig patches

2011-11-21 Thread Christophe Fergeau
Hi, This is the 2nd version of my libvirt-gconfig patches. I think I have addressed all of the issues that were raised (or told why I didn't address them). If I missed anything, just let me know. Some of the patches have been split/merged after the review so the series look a bit different from

[libvirt] [libvirt-gconfig PATCHv2 03/32] Make some GVirConfigObject helpers private

2011-11-21 Thread Christophe Fergeau
At this point, I'm not sure how/if the library user should be able to directly manipulate the XML data wrapped by a GVirConfigObject. It's preferrable to hide this API from the user until we have a clearer idea how to expose it. --- libvirt-gconfig/Makefile.am |3 +-

[libvirt] [libvirt-gconfig PATCHv2 10/32] Add gvir_config_genum_get_nick helper

2011-11-21 Thread Christophe Fergeau
We will often need to convert from an enum to its string representation, add an helper for that to avoid duplicating that code. -- v2: moved before gvir_config_clock_set_offset implementation since it needs it --- libvirt-gconfig/libvirt-gconfig-helpers-private.h |1 +

[libvirt] [libvirt-gconfig PATCHv2 01/32] Remove unneeded blank line in *_class_init

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-capabilities.c|1 - libvirt-gconfig/libvirt-gconfig-domain-snapshot.c |1 - libvirt-gconfig/libvirt-gconfig-interface.c |1 - libvirt-gconfig/libvirt-gconfig-network-filter.c |1 - libvirt-gconfig/libvirt-gconfig-network.c |

[libvirt] [libvirt-gconfig PATCHv2 08/32] Add gvir_config_domain_set_clock

2011-11-21 Thread Christophe Fergeau
The implementation is likely to need to be completed later. We might want to store pointers from GVirConfigDomain to the associated GVirConfigClock, from GVirConfigClock to the GVirConfigDomain that contains it. Since I'm not sure yet if they will be needed, I chose to keep the implementation

[libvirt] [libvirt-gconfig PATCHv2 07/32] Add some GVirConfigClock setters

2011-11-21 Thread Christophe Fergeau
-- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-clock.c | 38 +++ libvirt-gconfig/libvirt-gconfig-clock.h |5 libvirt-gconfig/libvirt-gconfig.sym |2 + 3 files changed, 45 insertions(+), 0 deletions(-)

[libvirt] [libvirt-gconfig PATCHv2 02/32] Remove unused prototype for gvir_config_object_parse

2011-11-21 Thread Christophe Fergeau
There is no corresponding implementation so no need to keep this prototype. --- libvirt-gconfig/libvirt-gconfig-object.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-object.h b/libvirt-gconfig/libvirt-gconfig-object.h index

[libvirt] [libvirt-gconfig PATCHv2 11/32] Implement gvir_config_clock_set_offset

2011-11-21 Thread Christophe Fergeau
-- v2: use gvir_config_genum_get_nick helper since it's now added before this commit use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-clock.c | 17 + libvirt-gconfig/libvirt-gconfig-clock.h |8

[libvirt] [libvirt-gconfig PATCHv2 06/32] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am |4 ++ libvirt-gconfig/libvirt-gconfig-clock.c | 81 +++ libvirt-gconfig/libvirt-gconfig-clock.h | 68 ++ libvirt-gconfig/libvirt-gconfig-timer.c | 81 +++

[libvirt] [libvirt-gconfig PATCHv2 13/32] Add gobject boilerplate for GVirConfigOs

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-os.c | 79 ++ libvirt-gconfig/libvirt-gconfig-os.h | 67 libvirt-gconfig/libvirt-gconfig.h|3 +- libvirt-gconfig/libvirt-gconfig.sym |4

[libvirt] [libvirt-gconfig PATCHv2 05/32] Use new helpers to simplify gvir_config_domain_set_features

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain.c | 17 +++-- libvirt-gconfig/libvirt-gconfig-domain.h |1 - 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c b/libvirt-gconfig/libvirt-gconfig-domain.c index d971a95..5db6bc4

[libvirt] [libvirt-gconfig PATCHv2 15/32] Implement gvir_config_domain_set_os

2011-11-21 Thread Christophe Fergeau
-- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-domain.c | 12 libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ libvirt-gconfig/libvirt-gconfig.h|4 +++- libvirt-gconfig/libvirt-gconfig.sym |1 + 4 files

[libvirt] [libvirt-gconfig PATCHv2 09/32] Use glib-mkenums to register enums with glib

2011-11-21 Thread Christophe Fergeau
We don't currently have any enum in our API, but we will need some. This commit adds the generation of libvirt-gconfig-enum-types.[ch] using glib-mkenums. These files will register the various enums that will get added to libvirt-gconfig header files with glib. -- v2: move

[libvirt] [libvirt-gconfig PATCHv2 19/32] Add gobject boilerplate for GVirConfigDeviceDisk

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-device-disk.c | 81 + libvirt-gconfig/libvirt-gconfig-device-disk.h | 68 + libvirt-gconfig/libvirt-gconfig.h |1 +

[libvirt] [libvirt-gconfig PATCHv2 14/32] Add some GVirConfigOs setters

2011-11-21 Thread Christophe Fergeau
-- v2: merged several related commits use safer g_strcmp0 for string comparison use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-os.c | 138 ++ libvirt-gconfig/libvirt-gconfig-os.h | 27 +++

[libvirt] [libvirt-gconfig PATCHv2 17/32] Add GVirConfigDomain::vcpu

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain.c | 29 libvirt-gconfig/libvirt-gconfig-domain.h |3 ++ libvirt-gconfig/libvirt-gconfig.sym|2 + libvirt-gconfig/tests/test-domain-create.c |1 + 4 files changed, 35 insertions(+), 0 deletions(-)

[libvirt] [libvirt-gconfig PATCHv2 22/32] Add gvir_config_object_add_child

2011-11-21 Thread Christophe Fergeau
It's similar to gvir_config_object_replace_child except that if the current node already has a child with the correct name, it returns the existing child instead of replacing it. -- v2: instead of adding an argument to gvir_config_object_new_child, split the function in 2 separate ones,

[libvirt] [libvirt-gconfig PATCHv2 21/32] Add gvir_config_domain_set_devices

2011-11-21 Thread Christophe Fergeau
-- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-domain.c | 23 +++ libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ libvirt-gconfig/libvirt-gconfig.sym |3 ++- 3 files changed, 27 insertions(+), 1 deletions(-)

[libvirt] [libvirt-gconfig PATCHv2 16/32] Add test for GVirConfigOs

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index a5c5b99..8abca00 100644 ---

[libvirt] [libvirt-gconfig PATCHv2 18/32] Add gobject boilerplate for GVirConfigDevice

2011-11-21 Thread Christophe Fergeau
This is an abstract type which will be used as a base class for all objects stored in the devices section of a domain. --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-device.c | 61 libvirt-gconfig/libvirt-gconfig-device.h |

[libvirt] [libvirt-gconfig PATCHv2 32/32] Add GVirConfigDeviceVideo

2011-11-21 Thread Christophe Fergeau
-- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/Makefile.am|2 + libvirt-gconfig/libvirt-gconfig-device-video.c | 133 libvirt-gconfig/libvirt-gconfig-device-video.h | 82 +++

[libvirt] [libvirt-gconfig PATCHv2 25/32] GVirConfigInterface derives from GVirConfigDevice

2011-11-21 Thread Christophe Fergeau
This base class is mainly useful as a generic type when we manipulate list of devices regardless of their actual type. --- libvirt-gconfig/libvirt-gconfig-interface.c |2 +- libvirt-gconfig/libvirt-gconfig-interface.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[libvirt] [libvirt-gconfig PATCHv2 04/32] Add gvir_config_object_replace_child helper

2011-11-21 Thread Christophe Fergeau
This allows us to factor the code to add an XML node to a config object. -- v2: use g_return_if_fail to test function args for sanity replace object --- libvirt-gconfig/libvirt-gconfig-object-private.h |5 + libvirt-gconfig/libvirt-gconfig-object.c | 105 +++---

[libvirt] [libvirt-gconfig PATCHv2 12/32] Create clock object in domain creation test

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index a719ed2..a5c5b99 100644 --- a/libvirt-gconfig/tests/test-domain-create.c +++

[libvirt] [libvirt-gconfig PATCHv2 30/32] Add GObject boilerplate for GVirConfigDeviceGraphics

2011-11-21 Thread Christophe Fergeau
This is an abstract type which will be used as a base class for the various type of graphics devices (spice, vnc, ...) --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-device-graphics.c | 61

[libvirt] [libvirt-gconfig PATCHv2 20/32] Add various GVirConfigDeviceDisk setters

2011-11-21 Thread Christophe Fergeau
-- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-device-disk.c | 50 + libvirt-gconfig/libvirt-gconfig-device-disk.h | 25 libvirt-gconfig/libvirt-gconfig.sym |6 +++ 3 files changed, 81

[libvirt] [libvirt-gconfig PATCHv2 29/32] Add GVirConfigDeviceInput

2011-11-21 Thread Christophe Fergeau
-- v2: use enum for input bus type use g_return_if_fail to test function args for sanity --- libvirt-gconfig/Makefile.am|2 + libvirt-gconfig/libvirt-gconfig-device-input.c | 113 libvirt-gconfig/libvirt-gconfig-device-input.h | 82

[libvirt] [libvirt-gconfig PATCHv2 27/32] Add gvir_config_interface_network_set_source

2011-11-21 Thread Christophe Fergeau
--- .../libvirt-gconfig-interface-network.c| 13 + .../libvirt-gconfig-interface-network.h|3 +++ libvirt-gconfig/libvirt-gconfig.sym|1 + 3 files changed, 17 insertions(+), 0 deletions(-) diff --git

[libvirt] [libvirt-gconfig PATCHv2 23/32] More GVirConfigDeviceDisk setters

2011-11-21 Thread Christophe Fergeau
-- v2: fix gvir_config_device_disk_set_source use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-device-disk.c | 78 - libvirt-gconfig/libvirt-gconfig-device-disk.h | 10 +++ libvirt-gconfig/libvirt-gconfig.sym |

[libvirt] [libvirt-gconfig PATCHv2 31/32] Add basic GVirConfigDeviceGraphicsSpice

2011-11-21 Thread Christophe Fergeau
Only the (non-TLS) port can be set on it -- v2: rename to GVirConfigDeviceGraphicsSpice fix node creation (missing type attribute) derive GVirConfigDeviceGraphicsSpice from GVirConfigDeviceGraphics use g_return_if_fail to test function args for sanity --- libvirt-gconfig/Makefile.am

[libvirt] [libvirt-gconfig PATCHv2 24/32] Add test for adding a disk device

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index af960a9..db22eb5 100644 ---

[libvirt] [libvirt-gconfig PATCHv2 26/32] Add GVirConfigInterfaceNetwork

2011-11-21 Thread Christophe Fergeau
Make GVirConfigInterface an abstract base class, and move the actual code in subclasses. This will make handling of the various types of network interfaces more understandable and more logical with respect to the corresponding XML. -- v2: use g_return_if_fail to test function args for sanity ---

[libvirt] [libvirt-gconfig PATCHv2 28/32] Add network to creation test

2011-11-21 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index db22eb5..fa949f7 100644 --- a/libvirt-gconfig/tests/test-domain-create.c

[libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-domain.c | 48 ++ libvirt-gobject/libvirt-gobject-domain.h |3 ++ libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 52 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Marc-André Lureau
Hi On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: +    g_return_val_if_fail(error == NULL || *error == NULL, FALSE); This is wrong, it should be error != NULL *error == NULL. +    if (virDomainDefineXML(conn, xml) == NULL) { +        if (error != NULL) +  

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Zeeshan Ali (Khattak)
On Mon, Nov 21, 2011 at 9:27 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: Hi On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: +    g_return_val_if_fail(error == NULL || *error == NULL, FALSE); This is wrong, it should be error != NULL *error ==

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Marc-André Lureau
On Mon, Nov 21, 2011 at 8:45 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Sorry, i don't get it. Verify how? By doing what I proposed bellow, reading libvirt code, ask on libvirt list/maintainers, test etc.. I would really prefer we add a runtime check that verifiy the handle is the

[libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-domain.c | 63 ++ libvirt-gobject/libvirt-gobject-domain.h |3 + libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 67 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Zeeshan Ali (Khattak)
On Mon, Nov 21, 2011 at 9:58 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: On Mon, Nov 21, 2011 at 8:45 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Sorry, i don't get it. Verify how? By doing what I proposed bellow, reading libvirt code, ask on libvirt list/maintainers,

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Marc-André Lureau
On Mon, Nov 21, 2011 at 9:02 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: +    g_return_val_if_fail(err == NULL || *err == NULL, FALSE); this needs update, as I wrote before. +    xml = gvir_config_object_to_xml(GVIR_CONFIG_OBJECT(conf)); hmm, don't we need to free xml? +    

[libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-domain.c | 65 ++ libvirt-gobject/libvirt-gobject-domain.h |3 + libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 69 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH 1/2] nwfilter: use shell variable to invoke 'ebtables' command

2011-11-21 Thread Eric Blake
On 11/21/2011 06:27 AM, Stefan Berger wrote: Introduce a shell variable 'EBT' to invoke the ebtables command. Hard-code the used ebtables table to '-t nat'. Tested with libvirt-tck. @@ -2967,11 +2964,11 @@ _ebtablesRemoveSubChains(virBufferPtr bu char rootchain[MAX_CHAINNAME_LENGTH];

Re: [libvirt] [PATCH 2/2] nwfilter: use shell variable to invoke 'ip(6)tables' command

2011-11-21 Thread Eric Blake
On 11/21/2011 06:28 AM, Stefan Berger wrote: Introduce a shell variable 'IBT' to invoke the ip(6)tables command. Tested with libvirt-tck. --- src/nwfilter/nwfilter_ebiptables_driver.c | 313 ++ 1 file changed, 155 insertions(+), 158 deletions(-) Index:

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Zeeshan Ali (Khattak)
On Mon, Nov 21, 2011 at 10:12 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: On Mon, Nov 21, 2011 at 9:02 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: +    g_return_val_if_fail(err == NULL || *err == NULL, FALSE); As I explained on IRC, it is justified AFAICT. Either you

[libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-domain.c | 68 ++ libvirt-gobject/libvirt-gobject-domain.h |3 + libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 72 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Marc-André Lureau
On Mon, Nov 21, 2011 at 10:09 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: As I explained on IRC, it is justified AFAICT. Either you pass a 'NULL' as the error arg or you pass an uninitialized place-holder for error. right, sorry for the confusion -- Marc-André Lureau --

Re: [libvirt] [PATCH] Bug Fix: Do not release network actual device in qemuBuildCommandLine on error

2011-11-21 Thread Eric Blake
That's a long subject line; I shortened it to: qemu: don't release network actual device twice On 11/16/2011 07:34 PM, Roopa Prabhu wrote: From: Roopa Prabhu ropra...@cisco.com For direct attach devices, in qemuBuildCommandLine, we seem to be freeing actual device on error path (with

Re: [libvirt] [PATCHv3] conf: don't modify cpu set string during parsing

2011-11-21 Thread Eric Blake
On 11/18/2011 09:41 PM, Bharata B Rao wrote: On Fri, Nov 18, 2011 at 11:31:12AM -0700, Eric Blake wrote: None of the callers cared if str was updated to point to the next byte after the parsed cpuset; simplifying this results in quite a few code simplifications. Additionally,

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-21 Thread Marc-André Lureau
ack On Mon, Nov 21, 2011 at 10:10 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org ---  libvirt-gobject/libvirt-gobject-domain.c |   68 ++  libvirt-gobject/libvirt-gobject-domain.h |    3 +  

Re: [libvirt] [PATCH V1 4/9] Add a mac chain

2011-11-21 Thread Eric Blake
On 10/26/2011 09:12 AM, Stefan Berger wrote: With hunks borrowed from one of David Steven's previous patches, we now add the capability of having a 'mac' chain which is useful to filter for multiple valid MAC addresses. Signed-off-by: David L Stevens dlstev...@us.ibm.com Signed-off-by:

Re: [libvirt] [PATCH V1 5/9] Add support for STP filtering

2011-11-21 Thread Eric Blake
On 10/26/2011 09:12 AM, Stefan Berger wrote: This patch adds support for filtering of STP (spanning tree protocol) traffic to the parser and makes us of the ebtables support for STP filtering. This code now enables the filtering of traffic in chains with prefix 'stp'. Signed-off-by: Stefan

Re: [libvirt] [PATCH V1 6/9] Add test cases for STP traffic filtering

2011-11-21 Thread Eric Blake
On 10/26/2011 09:12 AM, Stefan Berger wrote: This patch adds a few test cases for the XML parsing of STP filtering nodes. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- tests/nwfilterxml2xmlin/stp-test.xml | 26 ++

Re: [libvirt] [PATCH V1 8/9] [RFC] New filters to handle multiple IP addresses

2011-11-21 Thread Eric Blake
On 10/26/2011 09:12 AM, Stefan Berger wrote: With new filters borrowed from David Steven's submission: A set of new filters to handle multiple IP addresses and MAC addresses per interface. The alternative would be to replace some of the existing ones with these here. On IRC, you mentioned

Re: [libvirt] [PATCH V1 7/9] Add documentation for STP filtering support

2011-11-21 Thread Eric Blake
On 10/26/2011 09:12 AM, Stefan Berger wrote: Add documentation for the STP filtering support. Describe the XML attributes that are supported. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- docs/formatnwfilter.html.in | 142 1

Re: [libvirt] [PATCH V1 9/9] Improve error reporting of failures to apply filtering rules

2011-11-21 Thread Eric Blake
On 10/26/2011 09:12 AM, Stefan Berger wrote: Display the executed command and failure message if a command failed to execute. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/nwfilter/nwfilter_ebiptables_driver.c | 82 ++ 1 file changed, 50

Re: [libvirt] Bug 754974 - connection with xen+ssh vm's are missing with list (virsh)

2011-11-21 Thread Eric Blake
On 11/18/2011 07:25 AM, Robin van Leeuwen wrote: Hi I posted the above mentioned bug to Bugzilla and one reply said to mention it on libvir-list@redhat.com as well. So here it is: https://bugzilla.redhat.com/show_bug.cgi?id=754974 Is mentioning it in this list too, (when it involves

Re: [libvirt] [PATCH] virsh: add iface-bridge and iface-unbridge commands

2011-11-21 Thread Eric Blake
On 11/18/2011 12:25 AM, Kashyap Chamarthy wrote: On 11/17/2011 02:35 AM, Laine Stump wrote: On 11/16/2011 01:50 PM, Eric Blake wrote: I'll live up to my well-earned reputation :), and request that you don't push this without first squashing in docs (but to soften the blow, here's my first

Re: [libvirt] [RFC PATCH v2 1/4] PowerPC : Use Sysfs to gather host topology

2011-11-21 Thread Eric Blake
On 11/14/2011 07:46 AM, Prerna Saxena wrote: From 9084802bdf7a2c10d6a913cb7dde001ab6ab3543 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Oct 2011 05:45:30 -0700 Subject: [PATCH 1/4] Use sysfs to gather host topology, in place of /proc/cpuinfo Are we sure

Re: [libvirt] [PATCH 0/8 v5] Summary on block IO throttle

2011-11-21 Thread Eric Blake
On 11/15/2011 02:02 AM, Lei Li wrote: Changes since V3 - Use virTypedParameterPtr instead of specific struct in libvirt pulic API. - Relevant changes to remote driver, qemu driver, python support and virsh. Hmm, you didn't summarize changes since v4. Sorry for not noticing the v5 a bit

Re: [libvirt] [PATCH RESEND v5] Export KVM Host Power Management capabilities

2011-11-21 Thread Eric Blake
On 11/13/2011 10:29 PM, Srivatsa S. Bhat wrote: On 11/09/2011 04:38 PM, Srivatsa S. Bhat wrote: This patch exports KVM Host Power Management capabilities as XML so that higher-level systems management software can make use of these features available in the host. Changelog: - This

Re: [libvirt] [PATCH v3 0/2] API to invoke S3/S4 on a host and also resume from within libvirt

2011-11-21 Thread Eric Blake
On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: (This patch is positioned to go in after the patch that exports the host power management capabilities as XML, posted in [4]) I'm now reviewing that patch along with this series; if we need another revision, it may be easiest to merge the three

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-21 Thread Eric Blake
On 11/15/2011 03:33 PM, Eric Blake wrote: On 11/15/2011 12:22 AM, Hu Tao wrote: On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. +/*

Re: [libvirt] [PATCH v3 1/2] Implement the asynchronous suspend and RTC wakeup

2011-11-21 Thread Eric Blake
On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: Add the core functions that implement the functionality of the API. Suspend is done by using an asynchronous mechanism so that we can return the status to the caller successfully before the host gets suspended. This asynchronous operation is

[libvirt] [libvirt-glib] Release 0.0.2

2011-11-21 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- NEWS | 20 configure.ac |3 +-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index a0cbb60..b7b11a9 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,23 @@ +0.0.2 - Nov 22, 2011

[libvirt] storage: pool definition discarded by pool-create failure

2011-11-21 Thread lvroyce
1.how to reproduce: (1)just use LVM disk,leave libvirt create vg (2)xml: pool type='logical' namepic_pool2/name source device path='/dev/sdb1'/ device path='/dev/sdb2'/ /source target path/dev/pic_pool2/path /target /pool (3)steps: a.start libvirtd,copy xml b.virsh pool-define

[libvirt] storage:lvm pool creation fails because of vg not built

2011-11-21 Thread lvroyce
1.how to reproduce the reproduce steps just as http://www.redhat.com/archives/libvir-list/2011-November/msg01151.html 2.analyse: since create = define + start so pool-create can't work for the vg pre-built condition, shall we change create = define + build + start(if vg does not exist) and

[libvirt] [PATCH] Give correct error message when configure a wrong URI aliase.

2011-11-21 Thread taget
From: Eli Qiao ta...@linux.vnet.ibm.com Signed-off-by: Eli Qiao ta...@linux.vnet.ibm.com When configure the URI aliase like this in 'libvirt.conf': uri_aliases = [ jj#j=qemu+ssh://root@127.0.0.1/system, sleet=qemu+ssh://r...@sleet.cloud.example.com/system, ] virsh -c jj#j It will show this

[libvirt] [PATCH] Give correct error message when configure a wrong URI aliase.

2011-11-21 Thread taget
From: Eli Qiao ta...@linux.vnet.ibm.com Signed-off-by: Eli Qiao ta...@linux.vnet.ibm.com When configure the URI aliase like this in 'libvirt.conf': uri_aliases = [ jj#j=qemu+ssh://root@127.0.0.1/system, sleet=qemu+ssh://r...@sleet.cloud.example.com/system, ] virsh -c jj#j It will show this

Re: [libvirt] [PATCH RESEND v5] Export KVM Host Power Management capabilities

2011-11-21 Thread Daniel Veillard
On Wed, Nov 09, 2011 at 04:38:02PM +0530, Srivatsa S. Bhat wrote: This patch exports KVM Host Power Management capabilities as XML so that higher-level systems management software can make use of these features available in the host. The script pm-is-supported (from pm-utils package) is run

Re: [libvirt] storage: pool definition discarded by pool-create failure

2011-11-21 Thread Osier Yang
On 2011年11月22日 10:38, lvroyce wrote: 1.how to reproduce: (1)just use LVM disk,leave libvirt create vg (2)xml: pool type='logical' namepic_pool2/name source device path='/dev/sdb1'/ device path='/dev/sdb2'/ /source target path/dev/pic_pool2/path /target /pool (3)steps: a.start libvirtd,copy xml

Re: [libvirt] storage: pool definition discarded by pool-create failure

2011-11-21 Thread Osier Yang
On 2011年11月22日 10:38, lvroyce wrote: 1.how to reproduce: (1)just use LVM disk,leave libvirt create vg (2)xml: pool type='logical' namepic_pool2/name source device path='/dev/sdb1'/ device path='/dev/sdb2'/ /source target path/dev/pic_pool2/path /target /pool (3)steps: a.start libvirtd,copy xml

Re: [libvirt] storage:lvm pool creation fails because of vg not built

2011-11-21 Thread Osier Yang
On 2011年11月22日 10:45, lvroyce wrote: 1.how to reproduce the reproduce steps just as http://www.redhat.com/archives/libvir-list/2011-November/msg01151.html 2.analyse: since create = define + start so pool-create can't work for the vg pre-built condition, shall we change create = define + build

Re: [libvirt] [PATCH v3 0/2] API to invoke S3/S4 on a host and also resume from within libvirt

2011-11-21 Thread Daniel Veillard
On Mon, Nov 21, 2011 at 05:26:55PM -0700, Eric Blake wrote: On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: (This patch is positioned to go in after the patch that exports the host power management capabilities as XML, posted in [4]) I'm now reviewing that patch along with this series; if

  1   2   >