Re: [libvirt] [PATCH 2/1] API: prefer 'disk' over 'block' or 'path'

2011-11-22 Thread Daniel Veillard
On Tue, Nov 22, 2011 at 05:21:44PM -0700, Eric Blake wrote: > Given that we can now handle the target's disk shorthand, in addition > to an absolute path to the file or block device used on the host, > the term 'disk' fits a bit better as the parameter name than 'path'. > > * include/libvirt/libvi

Re: [libvirt] [PATCH] blockstats: support lookup by path in blockstats

2011-11-22 Thread Daniel Veillard
On Tue, Nov 22, 2011 at 04:42:33PM -0700, Eric Blake wrote: > Commit 89b6284f made it possible to pass either a source name or > the target device to most API demanding a disk designation, but > forgot to update the documentation. It also failed to update > virDomainBlockStats to take both forms.

Re: [libvirt] [PATCH 6/8] Docs: Add description and validation for blkdeviotune

2011-11-22 Thread Eric Blake
On 11/15/2011 02:02 AM, Lei Li wrote: > Signed-off-by: Lei Li > Signed-off-by: Zhi Yong Wu > --- > docs/formatdomain.html.in | 31 +++ > docs/schemas/domaincommon.rng | 24 > 2 files changed, 55 insertions(+), 0 deletions(-) I plan to

Re: [libvirt] [PATCH 0/8 v5] Summary on block IO throttle

2011-11-22 Thread Zhi Yong Wu
On Wed, Nov 23, 2011 at 12:27 PM, Eric Blake wrote: > On 11/15/2011 02:02 AM, Lei Li wrote: >> Changes since V3 >>  - Use virTypedParameterPtr instead of specific struct in libvirt pulic API. >>  - Relevant changes to remote driver, qemu driver, python support and virsh. >> >> To help add QEMU I/O

Re: [libvirt] [PATCH 0/8 v5] Summary on block IO throttle

2011-11-22 Thread Zhi Yong Wu
On Wed, Nov 23, 2011 at 12:27 PM, Eric Blake wrote: > On 11/15/2011 02:02 AM, Lei Li wrote: >> Changes since V3 >>  - Use virTypedParameterPtr instead of specific struct in libvirt pulic API. >>  - Relevant changes to remote driver, qemu driver, python support and virsh. >> >> To help add QEMU I/O

Re: [libvirt] [PATCH 4/8] Support block I/O throtte in XML

2011-11-22 Thread Eric Blake
subject line: s/throtte/throttle/ On 11/15/2011 02:02 AM, Lei Li wrote: > Enable block I/O throttle for per-disk in XML. > > Signed-off-by: Lei Li > Signed-off-by: Zhi Yong Wu > --- > src/conf/domain_conf.c | 101 +- > src/conf/domain_conf.h | 1

Re: [libvirt] [PATCH 0/8 v5] Summary on block IO throttle

2011-11-22 Thread Eric Blake
On 11/15/2011 02:02 AM, Lei Li wrote: > Changes since V3 > - Use virTypedParameterPtr instead of specific struct in libvirt pulic API. > - Relevant changes to remote driver, qemu driver, python support and virsh. > > To help add QEMU I/O throttling support to libvirt, we plan to complete > it wi

Re: [libvirt] [PATCH] redefine pool after pool creation failure

2011-11-22 Thread Osier Yang
On 2011?11?23? 11:09, Wen Ruo Lv wrote: Redefine pool after pool creation failure,give out err msg for non-exsisted vg when starting pool. ref: http://www.redhat.com/archives/libvir-list/2011-November/msg01152.html http://www.redhat.com/archives/libvir-list/2011-November/msg01152.html src/stora

Re: [libvirt] [PATCH 3/8] Implement virDomain{Set, Get}BlockIoTune for the qemu driver

2011-11-22 Thread Eric Blake
On 11/15/2011 02:02 AM, Lei Li wrote: > Implement the block I/O throttle setting and getting support to qemu > driver. > > Signed-off-by: Lei Li > Signed-off-by: Zhi Yong Wu > --- > src/qemu/qemu_driver.c | 342 > ++ > src/qemu/qemu_monitor.c

Re: [libvirt] [PATCH 2/8] Add virDomain{Set, Get}BlockIoTune support to the remote driver

2011-11-22 Thread Eric Blake
On 11/15/2011 02:02 AM, Lei Li wrote: > Support Block I/O Throttle setting and query to remote driver. > > Signed-off-by: Lei Li > Signed-off-by: Zhi Yong Wu > --- > daemon/remote.c | 109 > ++ > src/remote/remote_driver.c | 96

[libvirt] [PATCH] redefine pool after pool creation failure

2011-11-22 Thread Wen Ruo Lv
Redefine pool after pool creation failure,give out err msg for non-exsisted vg when starting pool. ref: http://www.redhat.com/archives/libvir-list/2011-November/msg01152.html http://www.redhat.com/archives/libvir-list/2011-November/msg01152.html src/storage/storage_backend_logical.c:just give out

Re: [libvirt] [PATCH] Give correct error message when configure a wrong URI aliase.

2011-11-22 Thread Eli Qiao
于 2011年11月23日 06:28, Eric Blake 写道: > On 11/22/2011 02:36 AM, Daniel P. Berrange wrote: >> On Tue, Nov 22, 2011 at 11:27:04AM +0800, ta...@linux.vnet.ibm.com wrote: >>> From: Eli Qiao >>> >>> Signed-off-by: Eli Qiao >>> >>> When configure the URI aliase like this in 'libvirt.conf': >>> >>> uri_

Re: [libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-22 Thread Eric Blake
On 11/15/2011 02:02 AM, Lei Li wrote: > This patch add new pulic API virDomainSetBlockIoTune and > virDomainGetBlockIoTune. > > Signed-off-by: Lei Li > Signed-off-by: Zhi Yong Wu > --- > include/libvirt/libvirt.h.in | 63 +++ > src/driver.h | 20 ++ > src

[libvirt] [PATCH 2/1] API: prefer 'disk' over 'block' or 'path'

2011-11-22 Thread Eric Blake
Given that we can now handle the target's disk shorthand, in addition to an absolute path to the file or block device used on the host, the term 'disk' fits a bit better as the parameter name than 'path'. * include/libvirt/libvirt.h.in: Update some parameter names. * src/libvirt.c (virDomainBlockS

[libvirt] [PATCH] blockstats: support lookup by path in blockstats

2011-11-22 Thread Eric Blake
Commit 89b6284f made it possible to pass either a source name or the target device to most API demanding a disk designation, but forgot to update the documentation. It also failed to update virDomainBlockStats to take both forms. This patch fixes both the documentation and the remaining function.

Re: [libvirt] [PATCH v2] nwfilter: Enable detection of multiple IP addresses

2011-11-22 Thread Eric Blake
On 11/22/2011 04:07 PM, Stefan Berger wrote: > In preparation of DHCP Snooping and the detection of multiple IP > addresses per interface: > > The hash table that is used to collect the detected IP address of an > interface can so far only handle one IP address per interface. With > this patch we

[libvirt] [PATCH v2] nwfilter: Enable detection of multiple IP addresses

2011-11-22 Thread Stefan Berger
In preparation of DHCP Snooping and the detection of multiple IP addresses per interface: The hash table that is used to collect the detected IP address of an interface can so far only handle one IP address per interface. With this patch we extend this to allow it to handle a list of IP addresses.

Re: [libvirt] nwfilter: Enable detection of multiple IP addresses

2011-11-22 Thread Stefan Berger
On 11/22/2011 05:23 PM, Eric Blake wrote: On 11/22/2011 03:08 PM, Stefan Berger wrote: In preparation of DHCP Snooping and the detection of multiple IP addresses per interface: The hash table that is used to collect the detected IP address of an interface can so far only handle one IP address p

Re: [libvirt] [PATCH] Give correct error message when configure a wrong URI aliase.

2011-11-22 Thread Eric Blake
On 11/22/2011 02:36 AM, Daniel P. Berrange wrote: > On Tue, Nov 22, 2011 at 11:27:04AM +0800, ta...@linux.vnet.ibm.com wrote: >> From: Eli Qiao >> >> Signed-off-by: Eli Qiao >> >> When configure the URI aliase like this in 'libvirt.conf': >> >> uri_aliases = [ >> "jj#j=qemu+ssh://root@127.0.0.1

Re: [libvirt] nwfilter: Enable detection of multiple IP addresses

2011-11-22 Thread Eric Blake
On 11/22/2011 03:08 PM, Stefan Berger wrote: > In preparation of DHCP Snooping and the detection of multiple IP > addresses per interface: > > The hash table that is used to collect the detected IP address of an > interface can so far only handle one IP address per interface. With > this patch we

[libvirt] nwfilter: Enable detection of multiple IP addresses

2011-11-22 Thread Stefan Berger
In preparation of DHCP Snooping and the detection of multiple IP addresses per interface: The hash table that is used to collect the detected IP address of an interface can so far only handle one IP address per interface. With this patch we extend this to allow it to handle a list of IP addresses.

[libvirt] 'savevm/loadvm' monitor command sequence losing mouse state across a VM restore

2011-11-22 Thread Vincent Passaro
All eblake on #virt requested that I ask the question here before posting on bugzilla, so I wanted to check if anyone has seen this issue. I create a vm snapshot (with F16) using virsh snapshot-create I then restore the vm with virsh snapshot-restore After the restore succeeds I loose the abili

Re: [libvirt] [PATCH] nwfilter: Pass additional parameter into applyDHCPOnly function

2011-11-22 Thread Eric Blake
On 11/22/2011 01:47 PM, Stefan Berger wrote: > In preparation for the DHCP Snooping code: > Pass an additional parameter into the applyDHCPOnly function > of the 'techdriver'. > > --- > src/conf/nwfilter_conf.h |3 ++- > src/nwfilter/nwfilter_ebiptables_driver.c | 13 ++

[libvirt] [PATCH] nwfilter: Pass additional parameter into applyDHCPOnly function

2011-11-22 Thread Stefan Berger
In preparation for the DHCP Snooping code: Pass an additional parameter into the applyDHCPOnly function of the 'techdriver'. --- src/conf/nwfilter_conf.h |3 ++- src/nwfilter/nwfilter_ebiptables_driver.c | 13 ++--- src/nwfilter/nwfilter_learnipaddr.c |2

Re: [libvirt] [PATCH V2 5/5] Improve error reporting of failures to apply filtering rules

2011-11-22 Thread Stefan Berger
On 11/22/2011 02:58 PM, Eric Blake wrote: On 11/22/2011 08:51 AM, Stefan Berger wrote: Display the executed command and failure message if a command failed to execute. Signed-off-by: Stefan Berger --- v2: - addressing Eric Blake's comments Regarding my v1 complaint about i18n issues, poorl

Re: [libvirt] [PATCH v2 2/2] nwfilter: use shell variable to invoke 'ip(6)tables' command

2011-11-22 Thread Stefan Berger
On 11/22/2011 03:06 PM, Eric Blake wrote: On 11/22/2011 09:08 AM, Stefan Berger wrote: Introduce a shell variable 'IBT' to invoke the ip(6)tables command. Tested with libvirt-tck. --- v2: - rebased --- src/nwfilter/nwfilter_ebiptables_driver.c | 313 ++ 1 fi

Re: [libvirt] [PATCH v4] virsh: Increase device-detach intelligence

2011-11-22 Thread Eric Blake
On 11/22/2011 03:26 AM, Michal Privoznik wrote: > From: Michal Prívozník > > Up to now users have to give a full XML description on input when > device-detaching. If they omitted something it lead to unclear > error messages (like generated MAC wasn't found, etc.). > With this patch users can spe

Re: [libvirt] [PATCH v2 2/2] nwfilter: use shell variable to invoke 'ip(6)tables' command

2011-11-22 Thread Eric Blake
On 11/22/2011 09:08 AM, Stefan Berger wrote: > Introduce a shell variable 'IBT' to invoke the ip(6)tables command. > > Tested with libvirt-tck. > > --- > v2: > - rebased > > --- > src/nwfilter/nwfilter_ebiptables_driver.c | 313 > ++ > 1 file changed, 155 insertio

Re: [libvirt] [PATCH v2 1/2] nwfilter: use shell variable to invoke 'ebtables' command

2011-11-22 Thread Eric Blake
On 11/22/2011 09:08 AM, Stefan Berger wrote: > Introduce a shell variable 'EBT' to invoke the ebtables command. > Hard-code the used ebtables table to '-t nat'. > > Tested with libvirt-tck. > > --- > v2: > - rebased > > --- > src/nwfilter/nwfilter_ebiptables_driver.c | 170 >

Re: [libvirt] [PATCH V2 5/5] Improve error reporting of failures to apply filtering rules

2011-11-22 Thread Eric Blake
On 11/22/2011 08:51 AM, Stefan Berger wrote: > Display the executed command and failure message if a command failed to > execute. > > Signed-off-by: Stefan Berger > > --- > > v2: > - addressing Eric Blake's comments Regarding my v1 complaint about i18n issues, poorly translated error messages

Re: [libvirt] [PATCH V2 3/5] Add test cases for STP traffic filtering

2011-11-22 Thread Eric Blake
On 11/22/2011 08:51 AM, Stefan Berger wrote: > This patch adds a few test cases for the XML parsing of STP filtering nodes. > > Signed-off-by: Stefan Berger > > --- > tests/nwfilterxml2xmlin/stp-test.xml | 26 ++ > tests/nwfilterxml2xmlout/stp-test.xml | 12

Re: [libvirt] [PATCH V2 4/5] Add documentation for STP filtering support

2011-11-22 Thread Eric Blake
On 11/22/2011 08:51 AM, Stefan Berger wrote: > Add documentation for the STP filtering support. Describe the XML attributes > that are supported. > > Signed-off-by: Stefan Berger > > --- > docs/formatnwfilter.html.in | 142 > > 1 file changed, 142

Re: [libvirt] [PATCH V2 1/5] Add a mac chain

2011-11-22 Thread Stefan Berger
On 11/22/2011 01:47 PM, Eric Blake wrote: On 11/22/2011 08:51 AM, Stefan Berger wrote: With hunks borrowed from one of David Steven's previous patches, we now add the capability of having a 'mac' chain which is useful to filter for multiple valid MAC addresses. Signed-off-by: David L Stevens Si

Re: [libvirt] [PATCH 1/4] rpc: Pass the buck only to the first available thread

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:32:31PM +0100, Jiri Denemark wrote: > --- > src/rpc/virnetclient.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c > index deeeaad..b518abd 100644 > --- a/src/rpc/virnetclient.c > +++ b/src/r

Re: [libvirt] [PATCH 3/4] rpc: Fix handling of non-blocking calls that could not be sent

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:32:33PM +0100, Jiri Denemark wrote: > When virNetClientIOEventLoop is called for a non-blocking call and not > even a single byte can be sent from this call without blocking, we > properly reported that to the caller which properly frees the call. But > we never removed t

Re: [libvirt] [PATCH V2 2/5] Add support for STP filtering

2011-11-22 Thread Eric Blake
On 11/22/2011 08:51 AM, Stefan Berger wrote: > This patch adds support for filtering of STP (spanning tree protocol) traffic > to the parser and makes us of the ebtables support for STP filtering. This > code > now enables the filtering of traffic in chains with prefix 'stp'. > > Signed-off-by: S

Re: [libvirt] [PATCH 2/4] rpc: Fix a typo in virNetClientSendNonBlock documentation

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:32:32PM +0100, Jiri Denemark wrote: > --- > src/rpc/virnetclient.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c > index b518abd..0effceb 100644 > --- a/src/rpc/virnetclient.c > +++ b/src/r

Re: [libvirt] [PATCH 4/4] rpc: Add some debug messages to virNetClient

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:32:34PM +0100, Jiri Denemark wrote: > --- > src/rpc/virnetclient.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c > index c99e87c..025d270 100644 > --- a/src/rpc/virnetclient.c > +++ b/src

Re: [libvirt] [PATCH V2 1/5] Add a mac chain

2011-11-22 Thread Eric Blake
On 11/22/2011 08:51 AM, Stefan Berger wrote: > With hunks borrowed from one of David Steven's previous patches, we now > add the capability of having a 'mac' chain which is useful to filter > for multiple valid MAC addresses. > > Signed-off-by: David L Stevens > Signed-off-by: Stefan Berger > >

Re: [libvirt] [PATCH v3 2/2] Make the API public

2011-11-22 Thread Eric Blake
On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: > Define the required interfaces to export the API. > > Signed-off-by: Srivatsa S. Bhat > --- > > include/libvirt/libvirt.h.in |4 > src/driver.h |5 > src/libvirt.c| 48 > ++

Re: [libvirt] [PATCH v3 1/2] Implement the asynchronous suspend and RTC wakeup

2011-11-22 Thread Srivatsa S. Bhat
On 11/22/2011 11:33 PM, Eric Blake wrote: > On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: >> Add the core functions that implement the functionality of the API. >> Suspend is done by using an asynchronous mechanism so that we can return >> the status to the caller successfully before the host get

Re: [libvirt] [PATCH v3 1/2] Implement the asynchronous suspend and RTC wakeup

2011-11-22 Thread Eric Blake
On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: > Add the core functions that implement the functionality of the API. > Suspend is done by using an asynchronous mechanism so that we can return > the status to the caller successfully before the host gets suspended. This > asynchronous operation is a

[libvirt] [PATCH] docs: fix grammar of capabilities

2011-11-22 Thread Eric Blake
* docs/formatcaps.html.in: Avoid run-on sentence, wrap lines. --- Pushing under the trivial rule. docs/formatcaps.html.in | 45 ++--- 1 files changed, 26 insertions(+), 19 deletions(-) diff --git a/docs/formatcaps.html.in b/docs/formatcaps.html.in index

Re: [libvirt] [PATCH] virsh: Allow other escape characters for console

2011-11-22 Thread Eric Blake
On 11/22/2011 09:18 AM, Michal Privoznik wrote: > Currently virsh supports only ^] as escape character for console. > However, some users might want to use something else. This patch > creates such ability by specifying '-e' switch on virsh command > line. > --- > Okay, this patch is meant as RFC m

[libvirt] [PATCH] virsh: Allow other escape characters for console

2011-11-22 Thread Michal Privoznik
Currently virsh supports only ^] as escape character for console. However, some users might want to use something else. This patch creates such ability by specifying '-e' switch on virsh command line. --- Okay, this patch is meant as RFC mainly but if it got enough ACKs I will not hesitate to push

Re: [libvirt] [PATCH V1 5/9] Add support for STP filtering

2011-11-22 Thread Eric Blake
On 11/22/2011 07:51 AM, Stefan Berger wrote: > On 11/21/2011 05:50 PM, Eric Blake wrote: >> On 10/26/2011 09:12 AM, Stefan Berger wrote: >>> This patch adds support for filtering of STP (spanning tree protocol) >>> traffic >>> to the parser and makes us of the ebtables support for STP filtering. >>

[libvirt] [PATCH v2 1/2] nwfilter: use shell variable to invoke 'ebtables' command

2011-11-22 Thread Stefan Berger
Introduce a shell variable 'EBT' to invoke the ebtables command. Hard-code the used ebtables table to '-t nat'. Tested with libvirt-tck. --- v2: - rebased --- src/nwfilter/nwfilter_ebiptables_driver.c | 170 +- 1 file changed, 97 insertions(+), 73 deletions(-) Ind

[libvirt] [PATCH v2 2/2] nwfilter: use shell variable to invoke 'ip(6)tables' command

2011-11-22 Thread Stefan Berger
Introduce a shell variable 'IBT' to invoke the ip(6)tables command. Tested with libvirt-tck. --- v2: - rebased --- src/nwfilter/nwfilter_ebiptables_driver.c | 313 ++ 1 file changed, 155 insertions(+), 158 deletions(-) Index: libvirt-acl/src/nwfilter/nwfilter_ebip

[libvirt] [PATCH V2 5/5] Improve error reporting of failures to apply filtering rules

2011-11-22 Thread Stefan Berger
Display the executed command and failure message if a command failed to execute. Signed-off-by: Stefan Berger --- v2: - addressing Eric Blake's comments --- src/nwfilter/nwfilter_ebiptables_driver.c | 86 +- 1 file changed, 50 insertions(+), 36 deletions(-) Ind

[libvirt] [PATCH V2 2/5] Add support for STP filtering

2011-11-22 Thread Stefan Berger
This patch adds support for filtering of STP (spanning tree protocol) traffic to the parser and makes us of the ebtables support for STP filtering. This code now enables the filtering of traffic in chains with prefix 'stp'. Signed-off-by: Stefan Berger --- v2: - addressing Eric Blake's comment

[libvirt] [PATCH V2 4/5] Add documentation for STP filtering support

2011-11-22 Thread Stefan Berger
Add documentation for the STP filtering support. Describe the XML attributes that are supported. Signed-off-by: Stefan Berger --- docs/formatnwfilter.html.in | 142 1 file changed, 142 insertions(+) Index: libvirt-acl/docs/formatnwfilter.html.in ==

[libvirt] [PATCH V2 3/5] Add test cases for STP traffic filtering

2011-11-22 Thread Stefan Berger
This patch adds a few test cases for the XML parsing of STP filtering nodes. Signed-off-by: Stefan Berger --- tests/nwfilterxml2xmlin/stp-test.xml | 26 ++ tests/nwfilterxml2xmlout/stp-test.xml | 12 tests/nwfilterxml2xmltest.c |1 + 3 fil

[libvirt] [PATCH V2 1/5] Add a mac chain

2011-11-22 Thread Stefan Berger
With hunks borrowed from one of David Steven's previous patches, we now add the capability of having a 'mac' chain which is useful to filter for multiple valid MAC addresses. Signed-off-by: David L Stevens Signed-off-by: Stefan Berger --- docs/schemas/nwfilter.rng |3 +++ s

[libvirt] [PATCH V2 0/5] NWFilter: Filter more protocols and other extensions

2011-11-22 Thread Stefan Berger
This patch series adds: - support for a 'mac' chain - filtering support for STP (spanning tree protocol) - better error reporting if ebtables/ip(6)table commands fail v2: - shortened series since VLAN patches have been pushed - addressed Eric Blake's comments Regards, Stefan -- libvir-lis

[libvirt] ANNOUNCE: libvirt-glib release 0.0.2

2011-11-22 Thread Daniel P. Berrange
I am pleased to announce that a new release of the libvirt-glib package, version 0.0.2 is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) New in this release: - Add API to re

[libvirt] [PATCH v5 07/13] Add support for async close of client RPC socket

2011-11-22 Thread Jiri Denemark
--- Notes: Version 5: - rebased on top of DanB's non-blocking patches; this is the only part that required non-trivial rebase so I'm posting it for additional review Version 4: - no changes Version 3: - no changes Version 2: - no changes src/rp

Re: [libvirt] [PATCH V1 9/9] Improve error reporting of failures to apply filtering rules

2011-11-22 Thread Stefan Berger
On 11/21/2011 06:42 PM, Eric Blake wrote: On 10/26/2011 09:12 AM, Stefan Berger wrote: Display the executed command and failure message if a command failed to execute. Signed-off-by: Stefan Berger --- src/nwfilter/nwfilter_ebiptables_driver.c | 82 ++ 1 file c

Re: [libvirt] [PATCH libvirt-glib] Don't reference GError **err parameter if it is NULL

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 03:50:46PM +0100, Christophe Fergeau wrote: > On Tue, Nov 22, 2011 at 02:18:15PM +, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > --- > > libvirt-gobject/libvirt-gobject-connection.c | 104 > > +- > > libvirt-gobject/libvir

[libvirt] [PATCH 3/4] rpc: Fix handling of non-blocking calls that could not be sent

2011-11-22 Thread Jiri Denemark
When virNetClientIOEventLoop is called for a non-blocking call and not even a single byte can be sent from this call without blocking, we properly reported that to the caller which properly frees the call. But we never removed the call from a call queue. --- src/rpc/virnetclient.c |7 ++-

[libvirt] [PATCH 4/4] rpc: Add some debug messages to virNetClient

2011-11-22 Thread Jiri Denemark
--- src/rpc/virnetclient.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index c99e87c..025d270 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1040,6 +1040,7 @@ static bool virNetClientIOEventLoopR

[libvirt] [PATCH 1/4] rpc: Pass the buck only to the first available thread

2011-11-22 Thread Jiri Denemark
--- src/rpc/virnetclient.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index deeeaad..b518abd 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1102,7 +1102,7 @@ static void virNetClientIOEventLoopPas

[libvirt] [PATCH 2/4] rpc: Fix a typo in virNetClientSendNonBlock documentation

2011-11-22 Thread Jiri Denemark
--- src/rpc/virnetclient.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index b518abd..0effceb 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1595,7 +1595,7 @@ int virNetClientSendNoReply(virNetClien

[libvirt] [PATCH 0/4] Small fixes to non-blocking I/O in client

2011-11-22 Thread Jiri Denemark
I missed these when reviewing the series... Jiri Denemark (4): rpc: Pass the buck only to the first available thread rpc: Fix a typo in virNetClientSendNonBlock documentation rpc: Fix handling of non-blocking calls that could not be sent rpc: Add some debug messages to virNetClient src/r

Re: [libvirt] [PATCH V1 5/9] Add support for STP filtering

2011-11-22 Thread Stefan Berger
On 11/21/2011 05:50 PM, Eric Blake wrote: On 10/26/2011 09:12 AM, Stefan Berger wrote: This patch adds support for filtering of STP (spanning tree protocol) traffic to the parser and makes us of the ebtables support for STP filtering. This code now enables the filtering of traffic in chains with

Re: [libvirt] [PATCH libvirt-glib] Don't reference GError **err parameter if it is NULL

2011-11-22 Thread Christophe Fergeau
On Tue, Nov 22, 2011 at 02:18:15PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > --- > libvirt-gobject/libvirt-gobject-connection.c | 104 > +- > libvirt-gobject/libvirt-gobject-domain.c | 70 -- > libvirt-gobject/libvirt-gobjec

Re: [libvirt] [PATCH libvirt-glib] Don't reference GError **err parameter if it is NULL

2011-11-22 Thread Zeeshan Ali (Khattak)
On Tue, Nov 22, 2011 at 4:18 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > --- >  libvirt-gobject/libvirt-gobject-connection.c     |  104 > +- >  libvirt-gobject/libvirt-gobject-domain.c         |   70 -- >  libvirt-gobject/libvirt-gobject-interfa

Re: [libvirt] [PATCH V1 4/9] Add a mac chain

2011-11-22 Thread Stefan Berger
On 11/21/2011 05:13 PM, Eric Blake wrote: On 10/26/2011 09:12 AM, Stefan Berger wrote: With hunks borrowed from one of David Steven's previous patches, we now add the capability of having a 'mac' chain which is useful to filter for multiple valid MAC addresses. Signed-off-by: David L Stevens Si

[libvirt] [PATCH libvirt-glib] Don't reference GError **err parameter if it is NULL

2011-11-22 Thread Daniel P. Berrange
From: "Daniel P. Berrange" --- libvirt-gobject/libvirt-gobject-connection.c | 104 +- libvirt-gobject/libvirt-gobject-domain.c | 70 -- libvirt-gobject/libvirt-gobject-interface.c |7 +- libvirt-gobject/libvirt-gobject-network-filter.c |

Re: [libvirt] [PATCH libvirt-glib 1/5] Add support for writing to streams

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 02:50:26PM +0100, Christophe Fergeau wrote: > On Tue, Nov 22, 2011 at 12:39:28PM +, Daniel P. Berrange wrote: > > + > > +GType_gvir_output_stream_get_type (void) > > G_GNUC_CONST; > > +GVirOutputStream * _gvir_output_stream_new

Re: [libvirt] [libvirt-glib] Release 0.0.2

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:27:17AM +0200, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > NEWS | 20 > configure.ac |3 +-- > 2 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index a0cbb60..b7b11a9 100644

Re: [libvirt] [PATCH libvirt-glib 3/5] Uncomment & fix code for returning config objects

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 02:19:44PM +0100, Christophe Fergeau wrote: > Hi, > > On Tue, Nov 22, 2011 at 12:39:30PM +, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > --- > > libvirt-gobject/libvirt-gobject-domain-snapshot.c |5 + > > libvirt-gobject/libvirt-gobject-in

Re: [libvirt] [PATCH libvirt-glib 1/5] Add support for writing to streams

2011-11-22 Thread Christophe Fergeau
On Tue, Nov 22, 2011 at 12:39:28PM +, Daniel P. Berrange wrote: > + > +GType_gvir_output_stream_get_type (void) > G_GNUC_CONST; > +GVirOutputStream * _gvir_output_stream_new > (GVirStream *stream); This brings the question of how to mark

Re: [libvirt] [PATCH libvirt-glib 4/5] Add API for creating transient domains

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 02:07:23PM +0100, Christophe Fergeau wrote: > Hey, > > On Tue, Nov 22, 2011 at 12:39:31PM +, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > --- > > libvirt-gobject/libvirt-gobject-connection.c | 49 > > ++ > > libvirt-gobj

Re: [libvirt] [PATCH libvirt-glib 5/5] Ensure domains & pools hash tables in connection are non-NULL

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 02:22:40PM +0100, Christophe Fergeau wrote: > Hi, > > I assume without this, it's easy to try to add data to NULL hash tables > when using the transient domain API you added in this patch series? > ACK patch, just curious... Actually the scenario was with persistent domain

Re: [libvirt] [libvirt-gconfig PATCHv2 19/32] Add gobject boilerplate for GVirConfigDeviceDisk

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 01:06:52PM +, Daniel P. Berrange wrote: > On Mon, Nov 21, 2011 at 07:04:16PM +0100, Christophe Fergeau wrote: > > --- > > libvirt-gconfig/Makefile.am |2 + > > libvirt-gconfig/libvirt-gconfig-device-disk.c | 81 > > + > >

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-22 Thread Zeeshan Ali (Khattak)
On Tue, Nov 22, 2011 at 11:20 AM, Daniel P. Berrange wrote: > On Mon, Nov 21, 2011 at 08:27:17PM +0100, Marc-André Lureau wrote: >> Hi >> >> On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak) >> wrote: >> > +    g_return_val_if_fail(error == NULL || *error == NULL, FALSE); >> >> This is wrong

Re: [libvirt] [libvirt-gconfig PATCHv2 13/32] Add gobject boilerplate for GVirConfigOs

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 01:01:17PM +, Daniel P. Berrange wrote: > On Mon, Nov 21, 2011 at 07:04:10PM +0100, Christophe Fergeau wrote: > > --- > > libvirt-gconfig/Makefile.am |2 + > > libvirt-gconfig/libvirt-gconfig-os.c | 79 > > ++ > > libvirt-

Re: [libvirt] [PATCH libvirt-glib 5/5] Ensure domains & pools hash tables in connection are non-NULL

2011-11-22 Thread Christophe Fergeau
Hi, I assume without this, it's easy to try to add data to NULL hash tables when using the transient domain API you added in this patch series? ACK patch, just curious... Christophe On Tue, Nov 22, 2011 at 12:39:32PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > --- > libv

Re: [libvirt] [libvirt-gconfig PATCHv2 18/32] Add gobject boilerplate for GVirConfigDevice

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 01:06:11PM +, Daniel P. Berrange wrote: > On Mon, Nov 21, 2011 at 07:04:15PM +0100, Christophe Fergeau wrote: > > This is an abstract type which will be used as a base class for > > all objects stored in the section of a domain. > > --- > > libvirt-gconfig/Makefile.am

Re: [libvirt] [PATCH libvirt-glib 3/5] Uncomment & fix code for returning config objects

2011-11-22 Thread Christophe Fergeau
Hi, On Tue, Nov 22, 2011 at 12:39:30PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > --- > libvirt-gobject/libvirt-gobject-domain-snapshot.c |5 + > libvirt-gobject/libvirt-gobject-interface.c |5 + > libvirt-gobject/libvirt-gobject-network-filter.c |

Re: [libvirt] [libvirt-gconfig PATCHv2 06/32] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 12:48:54PM +, Daniel P. Berrange wrote: > On Mon, Nov 21, 2011 at 07:04:03PM +0100, Christophe Fergeau wrote: > > --- > > libvirt-gconfig/Makefile.am |4 ++ > > libvirt-gconfig/libvirt-gconfig-clock.c | 81 > > +++ > > libv

Re: [libvirt] [libvirt-gconfig PATCHv2 32/32] Add GVirConfigDeviceVideo

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:29PM +0100, Christophe Fergeau wrote: > -- > v2: use g_return_if_fail to test function args for sanity > --- > libvirt-gconfig/Makefile.am|2 + > libvirt-gconfig/libvirt-gconfig-device-video.c | 133 > > libvirt-gconf

Re: [libvirt] [libvirt-gconfig PATCHv2 25/32] GVirConfigInterface derives from GVirConfigDevice

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:22PM +0100, Christophe Fergeau wrote: > This base class is mainly useful as a generic type when we manipulate > list of devices regardless of their actual type. > --- > libvirt-gconfig/libvirt-gconfig-interface.c |2 +- > libvirt-gconfig/libvirt-gconfig-interface.

Re: [libvirt] [libvirt-gconfig PATCHv2 24/32] Add test for adding a disk device

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:21PM +0100, Christophe Fergeau wrote: > --- > libvirt-gconfig/tests/test-domain-create.c | 19 +++ > 1 files changed, 19 insertions(+), 0 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: h

Re: [libvirt] [PATCH libvirt-glib 2/5] Change all flags from guint64 to guint to match libvirt type

2011-11-22 Thread Christophe Fergeau
ack On Tue, Nov 22, 2011 at 12:39:29PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > --- > libvirt-gobject/libvirt-gobject-connection.c |6 ++-- > libvirt-gobject/libvirt-gobject-connection.h |4 +- > libvirt-gobject/libvirt-gobject-domain-snapshot.c |2

Re: [libvirt] [libvirt-gconfig PATCHv2 22/32] Add gvir_config_object_add_child

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:19PM +0100, Christophe Fergeau wrote: > It's similar to gvir_config_object_replace_child except that if the > current node already has a child with the correct name, it returns > the existing child instead of replacing it. > > -- > v2: instead of adding an argument to

Re: [libvirt] [libvirt-gconfig PATCHv2 23/32] More GVirConfigDeviceDisk setters

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:20PM +0100, Christophe Fergeau wrote: > -- > v2: fix gvir_config_device_disk_set_source > use g_return_if_fail to test function args for sanity > --- > libvirt-gconfig/libvirt-gconfig-device-disk.c | 78 > - > libvirt-gconfig/libvirt-gco

Re: [libvirt] [libvirt-gconfig PATCHv2 21/32] Add gvir_config_domain_set_devices

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:18PM +0100, Christophe Fergeau wrote: > -- > v2: use g_return_if_fail to test function args for sanity > --- > libvirt-gconfig/libvirt-gconfig-domain.c | 23 +++ > libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ > libvirt-gconfig/libvirt-gcon

Re: [libvirt] [libvirt-gconfig PATCHv2 20/32] Add various GVirConfigDeviceDisk setters

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:17PM +0100, Christophe Fergeau wrote: > -- > v2: use g_return_if_fail to test function args for sanity > --- > libvirt-gconfig/libvirt-gconfig-device-disk.c | 50 > + > libvirt-gconfig/libvirt-gconfig-device-disk.h | 25 > lib

Re: [libvirt] [PATCH libvirt-glib 4/5] Add API for creating transient domains

2011-11-22 Thread Christophe Fergeau
Hey, On Tue, Nov 22, 2011 at 12:39:31PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > --- > libvirt-gobject/libvirt-gobject-connection.c | 49 > ++ > libvirt-gobject/libvirt-gobject-connection.h |4 ++ No addition of the new function in libvirt

Re: [libvirt] [libvirt-gconfig PATCHv2 18/32] Add gobject boilerplate for GVirConfigDevice

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:15PM +0100, Christophe Fergeau wrote: > This is an abstract type which will be used as a base class for > all objects stored in the section of a domain. > --- > libvirt-gconfig/Makefile.am |2 + > libvirt-gconfig/libvirt-gconfig-device.c | 61 +

Re: [libvirt] [libvirt-gconfig PATCHv2 19/32] Add gobject boilerplate for GVirConfigDeviceDisk

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:16PM +0100, Christophe Fergeau wrote: > --- > libvirt-gconfig/Makefile.am |2 + > libvirt-gconfig/libvirt-gconfig-device-disk.c | 81 > + > libvirt-gconfig/libvirt-gconfig-device-disk.h | 68 + > l

Re: [libvirt] [libvirt-gconfig PATCHv2 17/32] Add GVirConfigDomain::vcpu

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:14PM +0100, Christophe Fergeau wrote: > --- > libvirt-gconfig/libvirt-gconfig-domain.c | 29 > > libvirt-gconfig/libvirt-gconfig-domain.h |3 ++ > libvirt-gconfig/libvirt-gconfig.sym|2 + > libvirt-gconfig/tests/test

Re: [libvirt] [libvirt-gconfig PATCHv2 16/32] Add test for GVirConfigOs

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:13PM +0100, Christophe Fergeau wrote: > --- > libvirt-gconfig/tests/test-domain-create.c | 19 ++- > 1 files changed, 18 insertions(+), 1 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [libvirt-gconfig PATCHv2 08/32] Add gvir_config_domain_set_clock

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 12:56:02PM +, Daniel P. Berrange wrote: > On Mon, Nov 21, 2011 at 07:04:05PM +0100, Christophe Fergeau wrote: > > The implementation is likely to need to be completed later. We > > might want to store pointers from GVirConfigDomain to the associated > > GVirConfigClock,

Re: [libvirt] [libvirt-gconfig PATCHv2 15/32] Implement gvir_config_domain_set_os

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:12PM +0100, Christophe Fergeau wrote: > -- > v2: use g_return_if_fail to test function args for sanity > --- > libvirt-gconfig/libvirt-gconfig-domain.c | 12 > libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ > libvirt-gconfig/libvirt-gconfig.h

Re: [libvirt] [libvirt-gconfig PATCHv2 14/32] Add some GVirConfigOs setters

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:11PM +0100, Christophe Fergeau wrote: > -- > v2: merged several related commits > use safer g_strcmp0 for string comparison > use g_return_if_fail to test function args for sanity > --- > libvirt-gconfig/libvirt-gconfig-os.c | 138 > +

Re: [libvirt] [libvirt-gconfig PATCHv2 13/32] Add gobject boilerplate for GVirConfigOs

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:10PM +0100, Christophe Fergeau wrote: > --- > libvirt-gconfig/Makefile.am |2 + > libvirt-gconfig/libvirt-gconfig-os.c | 79 > ++ > libvirt-gconfig/libvirt-gconfig-os.h | 67 > libvirt-gcon

Re: [libvirt] [libvirt-gconfig PATCHv2 12/32] Create clock object in domain creation test

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:09PM +0100, Christophe Fergeau wrote: > --- > libvirt-gconfig/tests/test-domain-create.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.o

Re: [libvirt] [libvirt-gconfig PATCHv2 08/32] Add gvir_config_domain_set_clock

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:05PM +0100, Christophe Fergeau wrote: > The implementation is likely to need to be completed later. We > might want to store pointers from GVirConfigDomain to the associated > GVirConfigClock, from GVirConfigClock to the GVirConfigDomain that > contains it. Since I'm n

  1   2   >