Re: [libvirt] [Xen-devel] [BUG] insufficient quoting between tap-ctl list and xend/server/BlktapController.py

2011-12-02 Thread Philipp Hahn
Hello, On Thursday 01 December 2011 19:31:04 Ian Jackson wrote: Philipp Hahn writes (Re: [Xen-devel] [BUG] insufficient quoting between tap-ctl list and xend/server/BlktapController.py): As a quick work-around, the attached patch fixes the problem for me. That is, until tap-ctl changes it's

Re: [libvirt] [Xen-devel] [BUG] insufficient quoting between tap-ctl list and xend/server/BlktapController.py

2011-12-02 Thread Ian Campbell
On Fri, 2011-12-02 at 08:51 +, Philipp Hahn wrote: Hello, On Thursday 01 December 2011 19:31:04 Ian Jackson wrote: Philipp Hahn writes (Re: [Xen-devel] [BUG] insufficient quoting between tap-ctl list and xend/server/BlktapController.py): As a quick work-around, the attached patch

Re: [libvirt] [PATCH] add a default event handle, to passthough the new events come from qemu

2011-12-02 Thread ShaoHe Feng
Hi Eric, There's a question about register an Event. When user starts an application call remoteDispatchDomainEventsRegisterAny to register an event. And for some reasons, this application breaks down. Will the libvirtd daemon know the application breaks down? And delete the event? if not,

[libvirt] [PATCH] client: Check if other thread claims it has the buck before claiming it.

2011-12-02 Thread Peter Krempa
Originaly, the code checked if another client is the queue and infered ownership of the buck from that. Commit fa9595003d043df9f2efe95521c008 added a separate variable to track the buck. That caused, that a new call might enter claiming it has the buck, while another thread was signalled to take

Re: [libvirt] [PATCH] client: Check if other thread claims it has the buck before claiming it.

2011-12-02 Thread Jiri Denemark
On Fri, Dec 02, 2011 at 14:06:06 +0100, Peter Krempa wrote: Originaly, the code checked if another client is the queue and infered ownership of the buck from that. Commit fa9595003d043df9f2efe95521c008 added a separate variable to track the buck. That caused, that a new call might enter

Re: [libvirt] [PATCH] client: Check if other thread claims it has the buck before claiming it.

2011-12-02 Thread Peter Krempa
On 12/02/2011 02:21 PM, Jiri Denemark wrote: + +/* We need to re-check if the buck has been passed to this thread + * as this thread might have been signalled to wake up, but the another Just remove the from but the another. + * call might acquire the lock before this

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.8 and availability of rc1

2011-12-02 Thread Peter Krempa
On 12/02/2011 01:42 AM, Daniel Veillard wrote: On Thu, Dec 01, 2011 at 02:11:24PM -0700, Eric Blake wrote: On IRC: eblake DV: it looks like you missed my gnulib update for rc1 - what do we do about that? DV eblake: oops, well let's update in git DV it will be in rc2, as long as

[libvirt] Add console support

2011-12-02 Thread Christophe Fergeau
Hi, This patch series adds support for setting console nodes as has been discussed in the [PATCH libvirt-glib 02/15] Add objects for dealing with console devices thread. It introduces a GVirConfigDomainChardev which derives from GVirConfigDomainDevice. The actual classes to create console,

[libvirt] [libvirt-glib 2/5] Introduce GVirConfigDomainChardevSource

2011-12-02 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-domain-chardev-source.c| 49 +++ .../libvirt-gconfig-domain-chardev-source.h| 64 libvirt-gconfig/libvirt-gconfig.h |1 +

[libvirt] [libvirt-glib 5/5] Add test for GVirConfigConsole

2011-12-02 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index 9491f36..0e52e9e 100644 ---

[libvirt] [libvirt-glib 1/5] Add objects for dealing with console devices

2011-12-02 Thread Christophe Fergeau
Add an abstract GVirConfigDomainChardev object for console, serial, ... devices and a GVirConfigDomainConsole implementation. This needs to be completed with a separate GVirConfigDomainChardevSource inheritance tree which will be specialized to GVirConfigDomainChardevSourcePty, ... and

[libvirt] [libvirt-glib 3/5] Implement gvir_config_domain_chardev_add_source

2011-12-02 Thread Christophe Fergeau
This is used to associate a ChardevSource (pty, file, ...) with a Chardev (console, serial, ...). --- libvirt-gconfig/libvirt-gconfig-domain-chardev.c | 40 ++ libvirt-gconfig/libvirt-gconfig-domain-chardev.h |4 ++ libvirt-gconfig/libvirt-gconfig.sym |1

[libvirt] [libvirt-glib 4/5] Add GVirConfigDomainChardevSourcePty

2011-12-02 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-domain-chardev-source-pty.c| 94 .../libvirt-gconfig-domain-chardev-source-pty.h| 70 +++ libvirt-gconfig/libvirt-gconfig.h |1 +

[libvirt] libvirt doesn't work with qemu 1.0

2011-12-02 Thread Gerd Hoffmann
Hi, $subject says all. The error message is: error: internal error cannot parse /home/kraxel/bin/qemu-default version number in 'QEMU emulator version 1.0, Copyright (c) 2003-2008 Fabrice Bellard' cheers, Gerd PS: libvirt-0.9.4-23.el6.x86_64 -- libvir-list mailing list

Re: [libvirt] [Qemu-devel] libvirt doesn't work with qemu 1.0

2011-12-02 Thread Anthony Liguori
On 12/02/2011 08:21 AM, Gerd Hoffmann wrote: Hi, $subject says all. The error message is: error: internal error cannot parse /home/kraxel/bin/qemu-default version number in 'QEMU emulator version 1.0, Copyright (c) 2003-2008 Fabrice Bellard' Parsing help output for the version number is

[libvirt] [PATCH] qemu: Rework handling of shutdown event

2011-12-02 Thread Jiri Denemark
When QEMU guest finishes its shutdown sequence, qemu stops virtual CPUs and when started with -no-shutdown waits for us to kill it using SGITERM. Since QEMU is flushing its internal buffers, some time may pass before QEMU actually dies. We mistakenly used paused state (and events) for this which

Re: [libvirt] [Qemu-devel] libvirt doesn't work with qemu 1.0

2011-12-02 Thread Jiri Denemark
On Fri, Dec 02, 2011 at 08:50:11 -0600, Anthony Liguori wrote: On 12/02/2011 08:21 AM, Gerd Hoffmann wrote: Hi, $subject says all. The error message is: error: internal error cannot parse /home/kraxel/bin/qemu-default version number in 'QEMU emulator version 1.0, Copyright (c)

Re: [libvirt] [Qemu-devel] libvirt doesn't work with qemu 1.0

2011-12-02 Thread Anthony Liguori
On 12/02/2011 09:08 AM, Jiri Denemark wrote: On Fri, Dec 02, 2011 at 08:50:11 -0600, Anthony Liguori wrote: On 12/02/2011 08:21 AM, Gerd Hoffmann wrote: Hi, $subject says all. The error message is: error: internal error cannot parse /home/kraxel/bin/qemu-default version number in 'QEMU

[libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-storage-vol.c | 25 + libvirt-gobject/libvirt-gobject-storage-vol.h |4 libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 30 insertions(+), 0 deletions(-)

[libvirt] [libvirt-glib] Add gvir_config_domain_set_lifecycle

2011-12-02 Thread Christophe Fergeau
This is used to control what happens (restart, stop, ...) to the VM when it crashes, shuts down, ... --- libvirt-gconfig/libvirt-gconfig-domain.c | 20 libvirt-gconfig/libvirt-gconfig-domain.h | 18 ++ libvirt-gconfig/libvirt-gconfig.sym|3

Re: [libvirt] [PATCH] qemu: Rework handling of shutdown event

2011-12-02 Thread Eric Blake
On 12/02/2011 08:02 AM, Jiri Denemark wrote: When QEMU guest finishes its shutdown sequence, qemu stops virtual CPUs and when started with -no-shutdown waits for us to kill it using SGITERM. Since QEMU is flushing its internal buffers, some time may pass before QEMU actually dies. We

Re: [libvirt] [PATCH 0/5] Interface pools and passthrough mode

2011-12-02 Thread Shradha Shah
On 11/30/2011 01:29 AM, Laine Stump wrote: On 11/29/2011 02:53 PM, Daniel P. Berrange wrote: On Tue, Nov 29, 2011 at 03:46:13PM +, Shradha Shah wrote: Interface Pools and Passthrough mode: Current Method: The passthrough mode uses a macvtap a direct connection to connect each guest to

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Christophe Fergeau
On Fri, Dec 02, 2011 at 05:34:15PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-storage-vol.c | 25 + libvirt-gobject/libvirt-gobject-storage-vol.h |4

[libvirt] [RFC v5 PATCH 0/5] PowerPC : Extend Libvirt for PowerPC architecture

2011-12-02 Thread Prerna Saxena
Libvirt continues to be the key interface to configure and manage the KVM guest instances on x86. This patch set is an effort to enable libvirt to support KVM guest configuration and management on Power Book3S machines. Based on community discussion around the earlier version, this patch series

[libvirt] [libvirt-glib] Add gvir_xml_set_error

2011-12-02 Thread Christophe Fergeau
This mirrors g_set_error, but uses gvir_xml_error_new. The main benefit of using gvxr_xml_set_error over gvir_xml_error_new is that it handles NULL GError **. --- libvirt-gconfig/libvirt-gconfig-helpers-private.h |2 + libvirt-gconfig/libvirt-gconfig-helpers.c | 40

[libvirt] [RFC v5 PATCH 1/5] PowerPC : Use sysfs to gather host topology, in place of /proc/cpuinfo

2011-12-02 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Oct 2011 05:45:30 -0700 Subject: [PATCH 1/5] Use sysfs to gather host topology, in place of /proc/cpuinfo Libvirt at present depends on /proc/cpuinfo to gather host details such as CPUs, cores, threads, etc. This is an architecture-

[libvirt] [RFC v5 PATCH 2/5] PowerPC : Modify the tests/nodeinfotest.c to use sysfs in addition to proc/cpuinfo

2011-12-02 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Thu, 1 Dec 2011 12:47:52 +0530 Subject: [PATCH 2/5] Modify the tests/nodeinfotest.c to use sysfs in addition to proc/cpuinfo This patch creates a new sysfs hierarchy under tests/nodeinfodata/linux-nodeinfo-sysfs-test-1. Output files and

[libvirt] [RFC v5 PATCH 4/5] PowerPC : Clean up qemuBuildCommandLine to remove x86-specific assumptions from generic code.

2011-12-02 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 21 Nov 2011 18:20:42 +0530 Subject: [PATCH 4/5] Clean up qemuBuildCommandLine to remove x86-specific assumptions from generic code. This implements the minimal set of changes needed in libvirt to launch a PowerPC-KVM based guest. It

[libvirt] [RFC v5 PATCH 3/5] PowerPC : Add support for ppc64 qemu

2011-12-02 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Oct 2011 06:01:33 -0700 Subject: [PATCH 3/5] Add support for ppc64 qemu This enables libvirt to select the correct qemu binary (qemu-system-ppc64) for a guest vm based on arch 'ppc64'. Also, libvirt is enabled to correctly parse the list

[libvirt] [PATCH 0/2] patch pings

2011-12-02 Thread Eric Blake
These are random patches in my tree that I've previously posted with no review, but which I think are useful for inclusion in 0.9.8. Eric Blake (2): command: handle empty buffer argument correctly build: require more tools from maintainers bootstrap.conf | 15 +++

[libvirt] [PATCH 2/2] build: require more tools from maintainers

2011-12-02 Thread Eric Blake
We want our tarballs to be complete - this means that any generated file that gets shipped as part of the tarball so that ordinary users don't have to rebuild it must be something that the maintainer can generate. There have been various reports of random build failures when using libvirt.git

Re: [libvirt] libvirt doesn't work with qemu 1.0

2011-12-02 Thread Dave Allan
On Fri, Dec 02, 2011 at 03:21:54PM +0100, Gerd Hoffmann wrote: Hi, $subject says all. The error message is: Thanks for the heads up. Dave error: internal error cannot parse /home/kraxel/bin/qemu-default version number in 'QEMU emulator version 1.0, Copyright (c) 2003-2008 Fabrice

[libvirt] [PATCH 1/1] apparmor: allow tunnelled migrations.

2011-12-02 Thread Serge Hallyn
The pathname for the pipe for tunnelled migration is unresolvable. The libvirt apparmor driver therefore refuses access, causing migration to fail. If we can't resolve the path, the worst that can happen is that we should have given permission to the file but didn't. Otherwise (especially since

Re: [libvirt] [PATCH] [TCK] nwfilter:Follow changes to clean-traffic filter

2011-12-02 Thread Stefan Berger
On 12/02/2011 12:10 PM, Eric Blake wrote: On 12/01/2011 06:38 PM, Stefan Berger wrote: Follow the changes to the clean-traffic filter to pass the nwfilter tests. --- scripts/nwfilter/nwfilterxml2fwallout/testvm.fwall.dat | 33 +++-- 1 file changed, 15 insertions(+), 18

Re: [libvirt] [Qemu-devel] libvirt doesn't work with qemu 1.0

2011-12-02 Thread Eric Blake
On 12/02/2011 08:15 AM, Anthony Liguori wrote: Which of course only works with new enough QEMU that is known to support QMP (which BTW we detect by checking the version number). Or you could just try the -qmp option and if QEMU exits, it doesn't support it. That's going to be a lot more

Re: [libvirt] [RFC v5 PATCH 0/5] PowerPC : Extend Libvirt for PowerPC architecture

2011-12-02 Thread Stefan Berger
On 12/02/2011 11:54 AM, Prerna Saxena wrote: Libvirt continues to be the key interface to configure and manage the KVM guest instances on x86. This patch set is an effort to enable libvirt to support KVM guest configuration and management on Power Book3S machines. Based on community discussion

Re: [libvirt] [PATCH 0/5] Interface pools and passthrough mode

2011-12-02 Thread Laine Stump
On 12/02/2011 11:30 AM, Shradha Shah wrote: On 11/30/2011 01:29 AM, Laine Stump wrote: On 11/29/2011 02:53 PM, Daniel P. Berrange wrote: On Tue, Nov 29, 2011 at 03:46:13PM +, Shradha Shah wrote: Interface Pools and Passthrough mode: Current Method: The passthrough mode uses a macvtap a

Re: [libvirt] [PATCH 1/1] apparmor: allow tunnelled migrations.

2011-12-02 Thread Eric Blake
On 12/02/2011 12:10 PM, Serge Hallyn wrote: The pathname for the pipe for tunnelled migration is unresolvable. The libvirt apparmor driver therefore refuses access, causing migration to fail. If we can't resolve the path, the worst that can happen is that we should have given permission to

Re: [libvirt] [PATCH 1/1] apparmor: allow tunnelled migrations.

2011-12-02 Thread Jamie Strandboge
On Fri, 2011-12-02 at 13:10 -0600, Serge Hallyn wrote: The pathname for the pipe for tunnelled migration is unresolvable. The libvirt apparmor driver therefore refuses access, causing migration to fail. If we can't resolve the path, the worst that can happen is that we should have given

[libvirt] [PATCH] build: fix build at -O2 on rawhide

2011-12-02 Thread Eric Blake
I had previously tested commit 059d746 with -O intentionally omitted from my CFLAGS; but that means that I missed out on this warning from gcc 4.6.2 when optimizations are enabled: util/buf.c: In function 'virBufferGetIndent': util/buf.c:86:1: error: function might be candidate for attribute

[libvirt] [PATCH] Adapt libvirt's Qemu version parser for Qemu 1.0

2011-12-02 Thread Stefan Berger
Qemu 1.0 does not show a micro version like 0.15.50 did. Adapt the Qemu version parser to handle this. --- src/qemu/qemu_capabilities.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) Index: libvirt-tpm/src/qemu/qemu_capabilities.c

[libvirt] [PATCH] Add support for QEMU 1.0

2011-12-02 Thread Jiri Denemark
--- src/qemu/qemu_capabilities.c | 15 ++- tests/qemuhelpdata/qemu-1.0| 252 tests/qemuhelpdata/qemu-1.0-device | 138 tests/qemuhelptest.c | 62 + 4 files changed, 461 insertions(+), 6

Re: [libvirt] [PATCH] Add support for QEMU 1.0

2011-12-02 Thread Eric Blake
On 12/02/2011 01:29 PM, Jiri Denemark wrote: --- src/qemu/qemu_capabilities.c | 15 ++- tests/qemuhelpdata/qemu-1.0| 252 tests/qemuhelpdata/qemu-1.0-device | 138 tests/qemuhelptest.c | 62

Re: [libvirt] [PATCH] Adapt libvirt's Qemu version parser for Qemu 1.0

2011-12-02 Thread Eric Blake
On 12/02/2011 01:08 PM, Stefan Berger wrote: Qemu 1.0 does not show a micro version like 0.15.50 did. Adapt the Qemu version parser to handle this. --- src/qemu/qemu_capabilities.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) While this solves the problem, I prefer

Re: [libvirt] [Qemu-devel] libvirt doesn't work with qemu 1.0

2011-12-02 Thread Anthony Liguori
On 12/02/2011 01:29 PM, Eric Blake wrote: On 12/02/2011 08:15 AM, Anthony Liguori wrote: Which of course only works with new enough QEMU that is known to support QMP (which BTW we detect by checking the version number). Or you could just try the -qmp option and if QEMU exits, it doesn't

Re: [libvirt] [Qemu-devel] [PATCH] Adapt libvirt's Qemu version parser for Qemu 1.0

2011-12-02 Thread Stefan Berger
On 12/02/2011 03:32 PM, Eric Blake wrote: On 12/02/2011 01:08 PM, Stefan Berger wrote: Qemu 1.0 does not show a micro version like 0.15.50 did. Adapt the Qemu version parser to handle this. --- src/qemu/qemu_capabilities.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-)

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Zeeshan Ali (Khattak)
On Fri, Dec 2, 2011 at 6:34 PM, Christophe Fergeau cferg...@redhat.com wrote: On Fri, Dec 02, 2011 at 05:34:15PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org +    if (virStorageVolDelete(vol-priv-handle, flags) 0) { +        g_set_error (err, +        

Re: [libvirt] [PATCH 2/2] python: Expose binding for virNodeGetMemoryStats()

2011-12-02 Thread Peter Krempa
Dňa 2.12.2011 18:23, Eric Blake wrote / napísal(a): On 11/28/2011 10:19 AM, Peter Krempa wrote: +if (!(ret = PyDict_New())) { +free(stats); +return VIR_PY_NONE; +} +for (i = 0; i nparams; i++) { +PyDict_SetItem(ret, +

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Christophe Fergeau
On Sat, Dec 03, 2011 at 12:11:04AM +0200, Zeeshan Ali (Khattak) wrote: On Fri, Dec 2, 2011 at 6:34 PM, Christophe Fergeau cferg...@redhat.com wrote: On Fri, Dec 02, 2011 at 05:34:15PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org +    if

[libvirt] [libvirt-glib 2/2] Replace use of gvir_error_new with gvir_set_error

2011-12-02 Thread Christophe Fergeau
By using the gvir_set_error family of functions, we get handling of NULL GError ** for free, which wasn't consistently handled throughout the code base. --- libvirt-gobject/libvirt-gobject-connection.c | 84 -- libvirt-gobject/libvirt-gobject-domain-disk.c |6 +-

[libvirt] [libvirt-glib 1/2] Add gvir_set_error[_literal]

2011-12-02 Thread Christophe Fergeau
They mirror g_set_error[_literal] functionality but append the error reported by libvirt to the error message. --- libvirt-glib/libvirt-glib-error.c | 49 + libvirt-glib/libvirt-glib-error.h | 11 libvirt-glib/libvirt-glib.sym |2 + 3 files

[libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-storage-vol.c | 25 + libvirt-gobject/libvirt-gobject-storage-vol.h |4 libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 30 insertions(+), 0 deletions(-)