Re: [libvirt] [PATCH] maint: allow bootstrap in a sandbox

2011-12-07 Thread Osier Yang
On 2011年12月08日 00:37, Eric Blake wrote: Jiri Denemark reported an instance of bootstrapping libvirt failing when run inside a sandbox, traced to rpm trying to access /var/ which was not permitted by the sandbox. Alex Jia reported that 0.9.8-rc1 failed to bootstrap if patch(1) is not installed.

[libvirt] [PATCH] virsh: correct the cmdDomIfGetLink function return value error

2011-12-07 Thread ajia
From: Alex Jia * tools/virsh.c: Although finding interface with matching mac addr, forgot to set 'ret' boolean value to 'true'. * how to reproduce? % virsh domif-getlink % echo $? Signed-off-by: Alex Jia --- tools/virsh.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

Re: [libvirt] [PATCH] virsh: plug memory leak on cmdDomIfGetLink() sucessful path

2011-12-07 Thread Osier Yang
On 2011年12月08日 14:09, a...@redhat.com wrote: From: Alex Jia Detected by valgrind. Leak introduced in commit dc675f3: * tools/virsh.c: fix memory leak on cmdDomIfGetLink. * how to reproduce? % valgrind -v --leak-check=full virsh domif-getlink 0 * actual valgrind result: ==13102== 18 bytes

Re: [libvirt] [PATCH] virsh: plug memory leak on cmdBlkdeviotune() sucessful path

2011-12-07 Thread Osier Yang
On 2011年12月08日 14:09, a...@redhat.com wrote: From: Alex Jia Detected by valgrind. Leak introduced in commit e9bd9a0: * tools/virsh.c: fix memory leak on cmdBlkdeviotune. * how to reproduce? % valgrind -v --leak-check=full virsh blkdeviotune * actual valgrind result: ==12759== 576 bytes

[libvirt] [PATCH] virsh: plug memory leak on cmdDomIfGetLink() sucessful path

2011-12-07 Thread ajia
From: Alex Jia Detected by valgrind. Leak introduced in commit dc675f3: * tools/virsh.c: fix memory leak on cmdDomIfGetLink. * how to reproduce? % valgrind -v --leak-check=full virsh domif-getlink 0 * actual valgrind result: ==13102== 18 bytes in 1 blocks are definitely lost in loss record

[libvirt] [PATCH] virsh: plug memory leak on cmdBlkdeviotune() sucessful path

2011-12-07 Thread ajia
From: Alex Jia Detected by valgrind. Leak introduced in commit e9bd9a0: * tools/virsh.c: fix memory leak on cmdBlkdeviotune. * how to reproduce? % valgrind -v --leak-check=full virsh blkdeviotune * actual valgrind result: ==12759== 576 bytes in 1 blocks are definitely lost in loss record

Re: [libvirt] [PATCHv3 2/2] spec: don't use chkconfig --list

2011-12-07 Thread Eric Blake
On 12/07/2011 09:02 PM, Daniel Veillard wrote: >> /sbin/chkconfig is what is actually in the commit, and I see no reason >> to defer it. For the record, here's the patch that I actually tested >> (rather than fat-fingering my email): >> >> commit c4a387fdd8f3d86df7815d9a8bfca57baa3f14f1 >> Author:

Re: [libvirt] [PATCHv3 2/2] spec: don't use chkconfig --list

2011-12-07 Thread Daniel Veillard
On Wed, Dec 07, 2011 at 07:58:40PM -0700, Eric Blake wrote: > On 12/07/2011 07:53 PM, Daniel Veillard wrote: > # We check this by looking to see if the daemon is already installed > -/sbin/chkconfig --list libvirtd 1>/dev/null 2>&1 > -if test $? != 0&& test ! -f > %{_sysconfd

Re: [libvirt] [PATCH 0/4] Add new public API virDomainGetPcpusUsage and pcpuinfo command in virsh

2011-12-07 Thread Eric Blake
On 12/07/2011 08:40 PM, Lai Jiangshan wrote: > "virt-top -1" can call virDomainGetPcpusUsage() periodically and get > the CPU activities per CPU. (still require virt-top site patch). > > virsh is also added a pcpuinfo command which calls virDomainGetPcpusUsage(), > it gets information about the ph

[libvirt] [PATCH 1/4] Add new public API virDomainGetPcpusUsage

2011-12-07 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- include/libvirt/libvirt.h.in |5 python/generator.py |1 + src/driver.h |7 + src/libvirt.c| 51 ++ src/libvirt_public.syms |5 5 files changed, 6

[libvirt] [PATCH 4/4] Enable the pcpuinfo command in virsh

2011-12-07 Thread Lai Jiangshan
This command gets information about the physic CPUs. Example: # virsh pcpuinfo rhel6 CPU:0 Curr VCPU: - Usage: 47.3 CPU:1 Curr VCPU: 1 Usage: 46.8 CPU:2 Curr VCPU: 0 Usage: 52.7 CPU:3 Curr VCPU: - Usa

[libvirt] [PATCH 0/4] Add new public API virDomainGetPcpusUsage and pcpuinfo command in virsh

2011-12-07 Thread Lai Jiangshan
"virt-top -1" can call virDomainGetPcpusUsage() periodically and get the CPU activities per CPU. (still require virt-top site patch). virsh is also added a pcpuinfo command which calls virDomainGetPcpusUsage(), it gets information about the physic CPUs, such as the usage of CPUs, the current attac

[libvirt] [PATCH 3/4] qemu: implement new API virDomainGetPcpusUsage for qemu driver

2011-12-07 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- src/qemu/qemu.conf |5 ++- src/qemu/qemu_conf.c |3 +- src/qemu/qemu_driver.c | 74 src/util/cgroup.c |7 src/util/cgroup.h |1 + 5 files changed, 87 insertions(+), 3 deletions

[libvirt] [PATCH 2/4] remote: implement new API virDomainGetPcpusUsage for remote driver

2011-12-07 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- daemon/remote.c | 68 ++ src/remote/remote_driver.c | 51 +++ src/remote/remote_protocol.x | 17 ++- src/remote_protocol-structs | 13 4 files changed, 148

Re: [libvirt] [PATCH 1/2] maint: use common xml quoting style

2011-12-07 Thread Eric Blake
On 12/07/2011 08:10 PM, Daniel Veillard wrote: > On Mon, Dec 05, 2011 at 02:48:30PM -0700, Eric Blake wrote: >> According to the official XML specification [1], attributes >> can be specified with either ' or " (where the difference is >> that you can use '"' or '"' but must use """, >> and convers

Re: [libvirt] [PATCH 1/2] maint: use common xml quoting style

2011-12-07 Thread Daniel Veillard
On Mon, Dec 05, 2011 at 02:48:30PM -0700, Eric Blake wrote: > According to the official XML specification [1], attributes > can be specified with either ' or " (where the difference is > that you can use '"' or '"' but must use """, > and conversely for "'" or "'" vs. '''). But our > code generati

Re: [libvirt] [PATCHv3 2/2] spec: don't use chkconfig --list

2011-12-07 Thread Eric Blake
On 12/07/2011 07:53 PM, Daniel Veillard wrote: # We check this by looking to see if the daemon is already installed -/sbin/chkconfig --list libvirtd 1>/dev/null 2>&1 -if test $? != 0&& test ! -f %{_sysconfdir}/libvirt/qemu/networks/default.xml +if ! /sbin/chkconfig&& te

[libvirt] [PATCH 5/6] Enable the virDomain{S, G}etInterfaceParameters in virsh

2011-12-07 Thread Hu Tao
Add a new command domiftune to get/set interface parameters. * tools/virsh.c: implement the new command --- tools/virsh.c | 227 + 1 files changed, 227 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index d02be5c.

[libvirt] [PATCH 0/6] Add new command domiftune

2011-12-07 Thread Hu Tao
This series adds a new command domiftune to get/set parameters of domain's network interfaces. Supported parameters are bandwidth settings. Currently the network interface bandwidth can only be set: - in domain's xml before the domain is up - when attaching an interface by attach-interface

[libvirt] [PATCH 4/6] Add virDomain{S, G}etInterfaceParameters support to qemu driver

2011-12-07 Thread Hu Tao
* src/qemu/qemu_driver.c: implement the qemu driver support --- src/qemu/qemu_driver.c | 434 1 files changed, 434 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1e5ed9a..1d0faf8 100644 --- a/src/q

[libvirt] [PATCH 6/6] Add document for the new command domiftune

2011-12-07 Thread Hu Tao
Add document for the new command domiftune to virsh man page. --- tools/virsh.pod | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index fe92714..3c3efaa 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -553,6 +553

[libvirt] [PATCH 3/6] Add virDomain{S, G}etInterfaceparameters support to the remote driver

2011-12-07 Thread Hu Tao
* daemon/remote.c: implement the server side support * src/remote/remote_driver.c: implement the client side support * src/remote/remote_protocol.x: definitions for the mew entry points * src/remote_protocol-structs: structure definitions --- daemon/remote.c | 64 +++

[libvirt] [PATCH 1/6] Add API virDomain{S,G}etInterfaceParameters

2011-12-07 Thread Hu Tao
The APIs are used to set/get domain's network interface's parameters. Currently supported parameters are bandwidth settings. * include/libvirt/libvirt.h.in: new API and parameters definition * python/generator.py: fix compiler errors * src/driver.h: add new entry to the driver structure * src/lib

Re: [libvirt] [PATCHv3 2/2] spec: don't use chkconfig --list

2011-12-07 Thread Daniel Veillard
On Wed, Dec 07, 2011 at 05:56:26PM -0700, Eric Blake wrote: > On 12/07/2011 05:50 PM, Laine Stump wrote: > > On 12/06/2011 06:47 PM, Eric Blake wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=694403 reports that > >> the specfile is incorrectly checking for a running libvirt-guests > >> ser

[libvirt] [PATCH 2/6] virDomain{S, G}etInterfaceParameters: the main entry points

2011-12-07 Thread Hu Tao
* src/libvirt.c: implement the main entry points --- src/libvirt.c | 118 + 1 files changed, 118 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 9977915..bfa4d41 100644 --- a/src/libvirt.c +++ b/src/libvirt.c

Re: [libvirt] a compilation issue

2011-12-07 Thread Alex Jia
On 12/08/2011 12:32 AM, Eric Blake wrote: On 12/07/2011 09:23 AM, Alex Jia wrote: Hi developers, I met the following compilation issue when I 'git checkout v0.9.8-rc1' tag then run './configure&& make': Copying file ._bootmp/gnulib/lib/netinet_in.in.h Copying file ._bootmp/gnulib/lib/nonblocki

Re: [libvirt] [PATCHv3 2/2] spec: don't use chkconfig --list

2011-12-07 Thread Eric Blake
On 12/07/2011 05:50 PM, Laine Stump wrote: > On 12/06/2011 06:47 PM, Eric Blake wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=694403 reports that >> the specfile is incorrectly checking for a running libvirt-guests >> service. For example, >> >> $ LC_ALL=es_ES chkconfig --list libvirt-gues

Re: [libvirt] [PATCHv3 1/2] spec: make it easier to autoreconf when building rpm

2011-12-07 Thread Laine Stump
On 12/06/2011 06:47 PM, Eric Blake wrote: Over time, Fedora and RHEL RPMs have often backported upstream patches that touched configure.ac and/or Makefile.am; this necessitates rerunning the autotools for the patch to be effective. Making this a one-liner spec tweak will make it easier for future

Re: [libvirt] [PATCHv3 2/2] spec: don't use chkconfig --list

2011-12-07 Thread Laine Stump
On 12/06/2011 06:47 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=694403 reports that the specfile is incorrectly checking for a running libvirt-guests service. For example, $ LC_ALL=es_ES chkconfig --list libvirt-guests libvirt-guests0:desactivado 1:desactivado

Re: [libvirt] [Qemu-devel] virDomainBlockJobAbort and block_job_cancel

2011-12-07 Thread Eric Blake
On 12/07/2011 03:35 PM, Adam Litke wrote: > Stefan's qemu tree has a block_job_cancel command that always acts > asynchronously. In order to provide the synchronous behavior in libvirt (when > flags is 0), I need to wait for the block job to go away. I see two options: > > 1) Use the event: > To

Re: [libvirt] [Qemu-devel] virDomainBlockJobAbort and block_job_cancel

2011-12-07 Thread Adam Litke
On Thu, Nov 24, 2011 at 09:21:42AM +, Stefan Hajnoczi wrote: > On Thu, Nov 24, 2011 at 5:31 AM, Daniel Veillard wrote: > > On Wed, Nov 23, 2011 at 09:04:50AM -0700, Eric Blake wrote: > >> On 11/23/2011 07:48 AM, Stefan Hajnoczi wrote: > >> > This means that virDomainBlockJobAbort() returns to

[libvirt] [PATCH] build: fix build with older libxml2

2011-12-07 Thread Eric Blake
On RHEL 5, with libxml2-2.6.26, the build failed with: virsh.c: In function 'vshNodeIsSuperset': virsh.c:11951: warning: implicit declaration of function 'xmlChildElementCount' (or if warnings aren't errors, a link failure later on). * src/util/xml.h (virXMLChildElementCount): New prototype. * sr

Re: [libvirt] [PATCH] Prevent crash of libvirtd when attaching to existing qemu process

2011-12-07 Thread Eric Blake
On 12/07/2011 11:27 AM, Jim Fehlig wrote: > With security_driver set to "none" in /etc/libvirt/qemu.conf, > libvirtd would crash when attempted to attach to an existing > qemu process. Only copy the security model if it actually exists. > --- > src/qemu/qemu_process.c |3 ++- > 1 files change

[libvirt] [PATCH] Prevent crash of libvirtd when attaching to existing qemu process

2011-12-07 Thread Jim Fehlig
With security_driver set to "none" in /etc/libvirt/qemu.conf, libvirtd would crash when attempted to attach to an existing qemu process. Only copy the security model if it actually exists. --- src/qemu/qemu_process.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/q

Re: [libvirt] Horrible performance of virDomainGetInfo()

2011-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2011 at 03:45:10PM +0100, Jiri Denemark wrote: > On Wed, Dec 07, 2011 at 14:30:10 +, Daniel P. Berrange wrote: > > While investigating the RPC problems I've noticed that we have had a > > huge performance regression for virDomainGetInfo() due to the change > > which makes virDom

[libvirt] [PATCH v2 6/6] qemu: Add ability to abort existing console while creating new one

2011-12-07 Thread Peter Krempa
This patch fixes console corruption, that happens if two concurrent sessions are opened for a single console on a domain. Result of this corruption was, that each of the console streams did recieve just a part of the data written to the pipe so every console rendered unusable. New helper function

[libvirt] [PATCH v2 5/6] util: Add helpers for safe domain console operations

2011-12-07 Thread Peter Krempa
This patch adds a set of functions used in creating console streams for domains using PTYs and ensures mutualy exculsive access to the PTYs. If mutualy exclusive access is not used, two clients may open the same console, which results into corruption on both clients as both of them race to read da

[libvirt] [PATCH v2 4/6] fdstream: Add internal callback on stream close

2011-12-07 Thread Peter Krempa
This patch adds another callback to a FDstream object. The original callback is used by the daemon stream driver to handle events. This callback is called if and only if the stream is about to be closed. This might be used to handle cleanup steps after a fdstream exits. This will be used later on

[libvirt] [PATCH v2 2/6] virsh: add support for VIR_DOMAIN_CONSOLE_FORCE flag

2011-12-07 Thread Peter Krempa
This patch adds support for the newly introduced VIR_DOMAIN_CONSOLE flag. The console command now has an optional parameter --force that specifies that the user wants to forcibly interrupt an ongoing console session and create a new one. The behaviour to this point was, that the daemon openend two

[libvirt] [PATCH v2 3/6] fdstream: Emit stream abort callback even if poll() doesnt.

2011-12-07 Thread Peter Krempa
This patch causes the fdstream driver to call the stream event callback if virStreamAbort() is issued on a stream using this driver. This prohibited to abort streams from the daemon, as the daemon remote handler installs a callback to watch for stream errors as the only mean of detecting changes in

[libvirt] [PATCH v2 0/6] Console coruption with two or more clients series

2011-12-07 Thread Peter Krempa
This series fixes anoying console corruption if two clients try to connect at same time to the console. The current state of this is, that two/more of threads compete for the data from the PTY. This causes that each of the consoles get scrambled and unusable. These patches add mutual exclusion for

[libvirt] [PATCH v2 1/6] Add flags for virDomainOpenConsole

2011-12-07 Thread Peter Krempa
This patch adds a set of flags to be used with the virDomainOpenConsole API call to specify if the user wishes to interrupt an existing console session or just to try open a new one. VIR_DOMAIN_CONSOLE_TRY - specifies that the caller wants to try open a new console session

Re: [libvirt] Start of freeze for libvirt-0.9.8 and availability of rc1

2011-12-07 Thread Eric Blake
On 11/30/2011 10:48 PM, Daniel Veillard wrote: > We are now entering the freeze for libvirt-0.9.8 . > For portability sake I think adding more support for PPC machines > should still be allowed for a few days, as long as it's not impacting > too much of the common code. > > I have made a release

Re: [libvirt] [PATCH 2/2] Add documentation for

2011-12-07 Thread Eric Blake
On 12/07/2011 09:55 AM, Christophe Fergeau wrote: > --- > docs/formatdomain.html.in | 12 +++- > 1 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > index 204373e..64aede5 100644 > --- a/docs/formatdomain.html.in > ++

Re: [libvirt] [PATCH 1/2] Fix typo in virDomainResume API doc

2011-12-07 Thread Eric Blake
On 12/07/2011 09:55 AM, Christophe Fergeau wrote: > It's referring to virSuspendDomain instead of > virDomainSuspend. > --- > src/libvirt.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/libvirt.c b/src/libvirt.c > index 68074e7..9977915 100644 > --- a/src/libv

[libvirt] [PATCH 2/2] Add documentation for

2011-12-07 Thread Christophe Fergeau
--- docs/formatdomain.html.in | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 204373e..64aede5 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1023,11 +1023,13 @@ pat

[libvirt] [PATCH 1/2] Fix typo in virDomainResume API doc

2011-12-07 Thread Christophe Fergeau
It's referring to virSuspendDomain instead of virDomainSuspend. --- src/libvirt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 68074e7..9977915 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -2391,7 +2391,7 @@ error: * @domain:

[libvirt] [PATCH] maint: allow bootstrap in a sandbox

2011-12-07 Thread Eric Blake
Jiri Denemark reported an instance of bootstrapping libvirt failing when run inside a sandbox, traced to rpm trying to access /var/ which was not permitted by the sandbox. Alex Jia reported that 0.9.8-rc1 failed to bootstrap if patch(1) is not installed. * bootstrap.conf (buildreq): Avoid rpm cal

Re: [libvirt] a compilation issue

2011-12-07 Thread Eric Blake
On 12/07/2011 09:23 AM, Alex Jia wrote: > Hi developers, > I met the following compilation issue when I 'git checkout v0.9.8-rc1' tag > then run './configure && make': > > Copying file ._bootmp/gnulib/lib/netinet_in.in.h > Copying file ._bootmp/gnulib/lib/nonblocking.c > Copying file ._bootmp/gnu

[libvirt] a compilation issue

2011-12-07 Thread Alex Jia
Hi developers, I met the following compilation issue when I 'git checkout v0.9.8-rc1' tag then run './configure && make': Copying file ._bootmp/gnulib/lib/netinet_in.in.h Copying file ._bootmp/gnulib/lib/nonblocking.c Copying file ._bootmp/gnulib/lib/nonblocking.h Copying file ._bootmp/gnulib/lib

Re: [libvirt] [PATCH] API: Share code between virConnectOpen functions

2011-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2011 at 01:40:57PM -0200, Eduardo Lima (Etrunko) wrote: > From: Eduardo Lima (Etrunko) > > Signed-off-by: Eduardo Lima (Etrunko) > --- > src/libvirt.c | 30 ++ > 1 files changed, 2 insertions(+), 28 deletions(-) > > diff --git a/src/libvirt.c b/src

[libvirt] [PATCH] API: Share code between virConnectOpen functions

2011-12-07 Thread Eduardo Lima (Etrunko)
From: Eduardo Lima (Etrunko) Signed-off-by: Eduardo Lima (Etrunko) --- src/libvirt.c | 30 ++ 1 files changed, 2 insertions(+), 28 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 68074e7..ca7a9a2 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -134

Re: [libvirt] [PATCH 2/2] Fix updating of haveTheBuck in RPC client to be race-free

2011-12-07 Thread Peter Krempa
On 12/07/2011 03:46 PM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" When one thread passes the buck to another thread, it uses virCondSignal to wake up the target thread. The variable 'haveTheBuck' is not updated in a race-free manner when this occurs. The current thread sets it to fals

Re: [libvirt] [PATCH 1/2] Revert fd066925440ba48acc95d8f31b2c98b1cc9d582d

2011-12-07 Thread Peter Krempa
On 12/07/2011 03:46 PM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" Commit fd066925440ba48acc95d8f31b2c98b1cc9d582d tried to fix a race condition in commit fa9595003d043df9f2efe95521c00898cef27106 Author: Daniel P. Berrange Date: Fri Nov 11 15:28:41 2011 + Explicit

[libvirt] [PATCH 2/2] Fix updating of haveTheBuck in RPC client to be race-free

2011-12-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When one thread passes the buck to another thread, it uses virCondSignal to wake up the target thread. The variable 'haveTheBuck' is not updated in a race-free manner when this occurs. The current thread sets it to false, and the woken up thread sets it to true. There i

Re: [libvirt] Horrible performance of virDomainGetInfo()

2011-12-07 Thread Jiri Denemark
On Wed, Dec 07, 2011 at 14:30:10 +, Daniel P. Berrange wrote: > While investigating the RPC problems I've noticed that we have had a > huge performance regression for virDomainGetInfo() due to the change > which makes virDomainEndJob() save the XML status file every time it > is called. > > Pr

[libvirt] [PATCH 0/2] Fix RPC crash / hangs / badness

2011-12-07 Thread Daniel P. Berrange
Given our history with breaking stuff in RPC layer. I suggest we might want to do an rc3 release to let people test this for a couple of days -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/2] Revert fd066925440ba48acc95d8f31b2c98b1cc9d582d

2011-12-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Commit fd066925440ba48acc95d8f31b2c98b1cc9d582d tried to fix a race condition in commit fa9595003d043df9f2efe95521c00898cef27106 Author: Daniel P. Berrange Date: Fri Nov 11 15:28:41 2011 + Explicitly track whether the buck is held in remote client Un

[libvirt] Horrible performance of virDomainGetInfo()

2011-12-07 Thread Daniel P. Berrange
While investigating the RPC problems I've noticed that we have had a huge performance regression for virDomainGetInfo() due to the change which makes virDomainEndJob() save the XML status file every time it is called. Previous to this change, 2000 calls to virDomainGetInfo() took ~2.5 seconds Aft

Re: [libvirt] [PATCH] qemu: Ignore shutdown event from destroyed domain

2011-12-07 Thread Jiri Denemark
On Wed, Dec 07, 2011 at 13:58:36 +0100, Peter Krempa wrote: > On 12/07/2011 12:59 PM, Jiri Denemark wrote: > > During virDomainDestroy, QEMU may emit SHUTDOWN event as a response to > > SIGTERM and since domain object is still locked, the event is processed > > after the domain is destroyed. We nee

Re: [libvirt] [libvirt-glib] Add "priority" argument to gvir_stream_add_watch_full

2011-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2011 at 02:16:03PM +0100, Christophe Fergeau wrote: > This is more consistent with what all the other glib _full APIs > are doing. > --- > libvirt-gobject/libvirt-gobject-input-stream.c |1 + > libvirt-gobject/libvirt-gobject-output-stream.c |1 + > libvirt-gobject/libvirt

Re: [libvirt] In freeze for libvirt-0.9.8 and availability of rc2

2011-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2011 at 01:25:10PM +0100, Michal Novotny wrote: > On 12/07/2011 01:12 PM, Daniel P. Berrange wrote: > > On Sun, Dec 04, 2011 at 04:10:34PM +0800, Daniel Veillard wrote: > >> On Fri, Dec 02, 2011 at 02:30:35PM +0100, Peter Krempa wrote: > >>> On 12/02/2011 01:42 AM, Daniel Veillard w

[libvirt] [libvirt-glib] Add "priority" argument to gvir_stream_add_watch_full

2011-12-07 Thread Christophe Fergeau
This is more consistent with what all the other glib _full APIs are doing. --- libvirt-gobject/libvirt-gobject-input-stream.c |1 + libvirt-gobject/libvirt-gobject-output-stream.c |1 + libvirt-gobject/libvirt-gobject-stream.c|5 + libvirt-gobject/libvirt-gobject-stream.h

Re: [libvirt] [PATCH v2 1/2] XML definitions for guest NUMA and parsing routines

2011-12-07 Thread Michael Ellerman
On Fri, 2011-11-11 at 18:21 +0530, Bharata B Rao wrote: > XML definitions for guest NUMA and parsing routines. > > From: Bharata B Rao > > This patch adds XML definitions for guest NUMA specification and contains > routines to parse the same. The guest NUMA specification looks like this: > > >

Re: [libvirt] (no subject)

2011-12-07 Thread Sasha Levin
On Tue, 2011-12-06 at 14:38 +, Daniel P. Berrange wrote: > On Fri, Nov 11, 2011 at 07:56:58PM +0800, Osier Yang wrote: > > * Lacks of options for user's configuration, such as "-vnc", there > > is no option for user to configure the properties for the "vnc", > > such as the port. It h

Re: [libvirt] [PATCH] qemu: Ignore shutdown event from destroyed domain

2011-12-07 Thread Peter Krempa
On 12/07/2011 12:59 PM, Jiri Denemark wrote: During virDomainDestroy, QEMU may emit SHUTDOWN event as a response to SIGTERM and since domain object is still locked, the event is processed after the domain is destroyed. We need to ignore this event in such case to avoid changing domain state from

Re: [libvirt] In freeze for libvirt-0.9.8 and availability of rc2

2011-12-07 Thread Michal Novotny
On 12/07/2011 01:12 PM, Daniel P. Berrange wrote: > On Sun, Dec 04, 2011 at 04:10:34PM +0800, Daniel Veillard wrote: >> On Fri, Dec 02, 2011 at 02:30:35PM +0100, Peter Krempa wrote: >>> On 12/02/2011 01:42 AM, Daniel Veillard wrote: On Thu, Dec 01, 2011 at 02:11:24PM -0700, Eric Blake wrote: >

Re: [libvirt] In freeze for libvirt-0.9.8 and availability of rc2

2011-12-07 Thread Daniel P. Berrange
On Sun, Dec 04, 2011 at 04:10:34PM +0800, Daniel Veillard wrote: > On Fri, Dec 02, 2011 at 02:30:35PM +0100, Peter Krempa wrote: > > On 12/02/2011 01:42 AM, Daniel Veillard wrote: > > >On Thu, Dec 01, 2011 at 02:11:24PM -0700, Eric Blake wrote: > > >>But that means we really are committing to an rc

[libvirt] [PATCH] qemu: Ignore shutdown event from destroyed domain

2011-12-07 Thread Jiri Denemark
During virDomainDestroy, QEMU may emit SHUTDOWN event as a response to SIGTERM and since domain object is still locked, the event is processed after the domain is destroyed. We need to ignore this event in such case to avoid changing domain state from shutoff to shutdown. --- src/qemu/qemu_process

[libvirt] [PATCH v2] npiv: Auto-generate WWN if it's not specified

2011-12-07 Thread Osier Yang
The auto-generated WWN comply with the new addressing schema of WWN: the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. We choose hex 5 for the first nibble. And use Qumranet's OUI (00:1A:4A) as the 3-byte vendor indent

[libvirt] [libvirt-glib 2/2] Add missing items in GVirConfigDomainVirtType

2011-12-07 Thread Christophe Fergeau
Put all the items available in virDomainVirt --- libvirt-gconfig/libvirt-gconfig-domain.h | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain.h b/libvirt-gconfig/libvirt-gconfig-domain.h index cfc6452..2b631ea 100644 --- a/

[libvirt] [libvirt-glib 1/2] Fix gvir_config_domain_disk_set_target_bus API

2011-12-07 Thread Christophe Fergeau
The bus type is actually an enum, let's reflect that in libvirt-gconfig API --- libvirt-gconfig/libvirt-gconfig-domain-disk.c |8 ++-- libvirt-gconfig/libvirt-gconfig-domain-disk.h | 13 - libvirt-gconfig/libvirt-gconfig.sym |1 + libvirt-gconfig/tests/test-doma

[libvirt] [PATCH] Provide a helper method virDomainLiveHelperMethod

2011-12-07 Thread Lei Li
This chunk of code below repeated in several functions, factor it into a helper method virDomainLiveHelperMethod to eliminate duplicated code based on Eric and Adam's suggestion. I have tested it for all the relevant APIs changed. isActive = virDomainObjIsActive(vm); if (flags == VIR_DOMAIN_

[libvirt] [PATCH v5] Implement DNS SRV record into the bridge driver

2011-12-07 Thread Michal Novotny
Hi, this is the fifth version of my SRV record for DNSMasq patch rebased for the current codebase to the bridge driver and libvirt XML file to include support for the SRV records in the DNS. The syntax is based on DNSMasq man page and tests for both xml2xml and xml2argv were added as well. There ar

Re: [libvirt] [PATCH] npiv: Expose fabric_name outside

2011-12-07 Thread Osier Yang
On 2011年12月07日 05:05, Daniel P. Berrange wrote: On Tue, Dec 06, 2011 at 08:42:18PM +0800, Osier Yang wrote: This patch is to expose the fabric_name of fc_host class, which might be useful for users who wants to known which fabric the (v)HBA connects to. The patch also adds the missed capabiliti

[libvirt] Document

2011-12-07 Thread Penas Cédric
Hi, As part of a research project for the HES-SO (/http://www.hes-so.ch/), I produced a document on the operation of libvirt and implementation of a libvirt cloning function to ESXi. Currently this document is available in French (/http://www.tdeig.ch/kvm/Libvirt.pdf/). If anyone is interest

[libvirt] [libvirt-glib 2/2] Add GVirConfigDomainInterface setters

2011-12-07 Thread Christophe Fergeau
These attributes are valid for all types deriving from GVirConfigDomainInterface so we add it to the base class. --- libvirt-gconfig/libvirt-gconfig-domain-interface.c | 62 libvirt-gconfig/libvirt-gconfig-domain-interface.h | 14 + libvirt-gconfig/libvirt-gconfig.sym

[libvirt] [libvirt-glib 1/2] Add GVirConfigDomainInterfaceUser boilerplate

2011-12-07 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-domain-interface-user.c| 77 .../libvirt-gconfig-domain-interface-user.h| 68 + libvirt-gconfig/libvirt-gconfig.h |1 + libvirt-gconfig

[libvirt] Expand GVirConfigDomainInterface a bit

2011-12-07 Thread Christophe Fergeau
Hi, This patch series add setters for the GVirConfigDomainInterface properties which are common to all classes deriving from GVirConfigDomainInterface. It also adds GVirConfigDomainInterfaceUser so that it's possible to create nodes. Christophe -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [Qemu-devel] Guest Agent Summaries

2011-12-07 Thread Alon Levy
On Mon, Dec 05, 2011 at 03:36:59PM -0600, Michael Roth wrote: > On 12/05/2011 01:21 PM, Chris Wright wrote: > >* Chris Wright (chr...@redhat.com) wrote: > >>* Anthony Liguori (aligu...@us.ibm.com) wrote: > >>>1. A short introduction to each of the guest agents, what guests they > >>>support, and wh

Re: [libvirt] (no subject)

2011-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2011 at 08:21:06AM +0200, Sasha Levin wrote: > On Tue, 2011-12-06 at 14:38 +, Daniel P. Berrange wrote: > > On Fri, Nov 11, 2011 at 07:56:58PM +0800, Osier Yang wrote: > > > * KVM tool manages the network completely itself (with DHCP support?), > > > no way to configure, e