On 12/09/2011 06:35 PM, Eric Blake wrote:
Improve the documentation of what forms a valid element,
since these elements appear in numerous devices.
* docs/formatdomain.html.in (elementsAddress): New section.
(elementsControllers, elementsUSB, elementsNICS, elementsInput)
(elementsHub, elementsC
On 12/09/2011 05:07 PM, Eric Blake wrote:
On 12/09/2011 02:59 PM, Laine Stump wrote:
From: Laine Stump
This patch addresses https://bugzilla.redhat.com/show_bug.cgi?id=760442
When a network has any forward type other than route, nat or none, the
network configuration should be done completely
On 12/08/2011 02:39 PM, Eric Blake wrote:
On 12/08/2011 12:31 PM, Laine Stump wrote:
From: Laine Stump
In some error situations, the function testDomainRestoreFlags() could
unlock the test driver mutex without first locking it. This patch
moves the lock operation earlier, so that it occurs befo
On 12/09/2011 04:08 PM, Eric Blake wrote:
On 12/09/2011 01:59 PM, Laine Stump wrote:
One of the xml tests in the test suite was created using a
now-deprecated qemu machine type ("fedora-13", which was only ever
valid for Fedora builds of qemu). Although strictly speaking it's not
necessary to re
Network disks don't have paths to be resolved or files to be checked
for ownership. ee3efc41e6233e625aa03003bf3127319ccd546f checked this
for some image label functions, but was partially reverted in a
refactor. This finishes adding the check to each security driver's
set and restore label methods
Improve the documentation of what forms a valid element,
since these elements appear in numerous devices.
* docs/formatdomain.html.in (elementsAddress): New section.
(elementsControllers, elementsUSB, elementsNICS, elementsInput)
(elementsHub, elementsCharChannel, elementsSound): Refer to it.
---
On 12/07/2011 11:41 PM, Michael Ellerman wrote:
> From: Michael Ellerman
>
> Add logic to assign addresses for devices with spapr-vio addresses.
>
> We also do validation of addresses specified by the user, ie. ensuring
> that there are not duplicate addresses on the bus.
>
> Signed-off-by: Mic
On 12/07/2011 11:41 PM, Michael Ellerman wrote:
> From: Michael Ellerman
>
> Currently qemuDomainAssignPCIAddresses() is called to assign addresses
> to PCI devices.
>
> We need to do something similar for devices with spapr-vio addresses.
> So create one place where address assignment will be d
On 12/09/2011 02:59 PM, Laine Stump wrote:
> From: Laine Stump
>
> This patch addresses https://bugzilla.redhat.com/show_bug.cgi?id=760442
>
> When a network has any forward type other than route, nat or none, the
> network configuration should be done completely external to libvirt -
> libvirt
From: Laine Stump
This patch addresses https://bugzilla.redhat.com/show_bug.cgi?id=760442
When a network has any forward type other than route, nat or none, the
network configuration should be done completely external to libvirt -
libvirt only uses these types to allow configuring guests in a ma
On 12/07/2011 11:41 PM, Michael Ellerman wrote:
> From: Michael Ellerman
This is a different address than you used for patch 2 and 3 (and yet a
third address compared to the email where you sent this patch). We can
cope with that, but it means picking a favorite address for AUTHORS,
then listing
On Fri, Dec 09, 2011 at 10:24:06AM -0500, Dave Allan wrote:
> Hey all,
>
> I just noticed that make uninstall from the git HEAD fails:
>
> rmdir /etc/sasl2/
> rmdir: failed to remove `/etc/sasl2/': Directory not empty
>
> it's correct that /etc/sasl2 should not be removed, as it has other
> file
On 12/09/2011 01:59 PM, Laine Stump wrote:
> One of the xml tests in the test suite was created using a
> now-deprecated qemu machine type ("fedora-13", which was only ever
> valid for Fedora builds of qemu). Although strictly speaking it's not
> necessary to replace it with an actual supported qem
Make uninstall currently fails with the following message:
rmdir /etc/sasl2/
rmdir: failed to remove `/etc/sasl2/': Directory not empty
That's fine (correct in fact) so force the command to return success
with || :
---
daemon/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-
One of the xml tests in the test suite was created using a
now-deprecated qemu machine type ("fedora-13", which was only ever
valid for Fedora builds of qemu). Although strictly speaking it's not
necessary to replace it with an actual supported qemu machine type
(since the xml in question is never
On 12/07/2011 11:41 PM, Michael Ellerman wrote:
> From: Michael Ellerman
>
> For the PPC64 pseries machine type we need to add address information
> for the spapr-vty device.
>
> Signed-off-by: Michael Ellerman
> ---
> src/qemu/qemu_command.c | 10 +++---
> src/qemu/qemu_command.h |1
On 12/07/2011 11:41 PM, Michael Ellerman wrote:
> From: Michael Ellerman
>
> On the PPC64 pseries machine type we need to use the spapr-vscsi device
> rather than an lsi.
>
> Signed-off-by: Michael Ellerman
> ---
> src/qemu/qemu_command.c | 13 +
> src/qemu/qemu_command.h |3
On 12/08/2011 05:38 PM, Eric Blake wrote:
>> int i;
>> for (i = 0 ; i < strlen(model) ; i++) {
Hmm - an O(n) function call on an O(n) loop, for a quadratic action (of
course, it's in the noise, since the user's model name is likely short).
But we can do better with a more effici
Network should be notified if we plug in or unplug an
interface, so it can perform some action, e.g. set/unset
network part of QoS.
---
src/conf/domain_conf.h |1 +
src/conf/network_conf.c |1 +
src/conf/network_conf.h |2 +
src/libvirt_network.syms|2 +
src/networ
These set bridge part of QoS when bringing domain's interface up.
---
po/POTFILES.in|1 +
src/util/virnetdevbandwidth.c | 177 +
src/util/virnetdevbandwidth.h | 14 +++
3 files changed, 192 insertions(+), 0 deletions(-)
diff --git a/p
These classes can borrow unused bandwidth. Basically,
only egress qdsics can have classes, therefore we can
do this kind of traffic shaping only on host's outgoing,
that is domain's incoming traffic.
---
src/lxc/lxc_driver.c |3 ++-
src/network/bridge_driver.c |4 +++-
src/qemu/
Like we keep domain status file to keep some internal data
during daemon restart, now it is needed for network as well.
Because network has now class_id attribute which is hidden
from users and thus not part of network XML.
---
daemon/libvirtd.c |3 +
src/conf/network_conf.c | 2
This is however supported only on domain interfaces with
type='network'. Moreover, target network needs to have at least
inbound QoS set. This is required by hierarchical traffic shaping.
---
docs/formatdomain.html.in| 21 --
docs/schemas/networkcommon.rng |5 ++
src/conf/d
Interfaces keeps a class_id, which is an ID from which bridge
part of QoS settings is derived. We need to store class_id
in domain status file, so we can later pass it to
virNetDevBandwidthUnplug.
---
src/conf/domain_conf.c |4 +-
src/qemu/qemu_domain.c | 66 +
Since 0.9.4 release libvirt supports setting some QoS attributes on virtual
bridges and/or virtual interfaces. Average and peak rate, namely. It lacks
minimal guaranteed bandwidth aka 'floor' attribute, though. This patch set
tries to fill that hole. However, there are some things you want to know
make uninstall failed:
rmdir: failed to remove `/etc/sasl2/': Directory not empty
Fix this by following the conventions already present in
src/Makefile.am of installing with MKDIR_P, and cleaning up
any directory in a builtroot while allowing the directory to
still exist if non-empty in an instal
On 12/08/2011 02:22 AM, Alex Jia wrote:
> On 12/08/2011 05:11 PM, a...@redhat.com wrote:
>> From: Alex Jia
>>
>> Detected by valgrind. Leak introduced in commit 88a993b:
>>
>> * tools/virsh.c: fix memory leak on cmdDomblkstat.
>>
>> * how to reproduce?
>>% valgrind -v --leak-check=full virsh cm
Please do not top post in replies - make your replies to questions
inline, it makes following the conversation *much* easier.
On 12/09/2011 02:00 AM, Amit Tewari wrote:
Hi,
No guest can not get ip.
When I do ifup eth0 it give error device not found.
Hostos=rhel 6.x86_64
Guest os= rhel 6.x
On 12/09/2011 10:56 AM, Eric Blake wrote:
On 12/09/2011 07:51 AM, Stefan Berger wrote:
Fix memory leak:
==27534== 24 bytes in 1 blocks are definitely lost in loss record 207 of
530
==27534==at 0x4A05E46: malloc (vg_replace_malloc.c:195)
==27534==by 0x38EC26EC37: vasprintf (in /lib64/lib
On 12/09/2011 12:01 PM, Eric Blake wrote:
On 12/09/2011 09:45 AM, Stefan Berger wrote:
When parsing ppc64 models on an x86 host an out-of-memory error message
is displayed due
to it checking for retcpus being NULL. Fix this by removing the check
whether retcpus is NULL
since we will realloc into
On 12/09/2011 09:45 AM, Stefan Berger wrote:
> When parsing ppc64 models on an x86 host an out-of-memory error message
> is displayed due
> to it checking for retcpus being NULL. Fix this by removing the check
> whether retcpus is NULL
> since we will realloc into this variable.
> Also in the X86 m
BTW, This patch is missing your review.
Thanks,
Alex
- Original Message -
From: "Alex Jia"
To: libvir-list@redhat.com
Cc: a...@redhat.com
Sent: Thursday, December 8, 2011 5:22:51 PM
Subject: Re: [libvirt][PATCH] virsh: plug memory leak on cmdDomblkstat
On 12/08/2011 05:11 PM, a...@redha
When parsing ppc64 models on an x86 host an out-of-memory error message
is displayed due
to it checking for retcpus being NULL. Fix this by removing the check
whether retcpus is NULL
since we will realloc into this variable.
Also in the X86 model parser display the OOM error at the location wher
On 12/09/2011 09:29 AM, Michal Privoznik wrote:
> ---
> src/util/threads.h |5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/src/util/threads.h b/src/util/threads.h
> index b72610c..7d8a6ed 100644
> --- a/src/util/threads.h
> +++ b/src/util/threads.h
> @@ -88,6 +88
On 12/09/2011 09:29 AM, Michal Privoznik wrote:
> instead of simple 'if' statement as virCondWait can return
> even if associated condition was not signaled.
> ---
> src/util/threadpool.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/util/threadpool.c b/src/ut
---
src/util/threads.h |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/util/threads.h b/src/util/threads.h
index b72610c..7d8a6ed 100644
--- a/src/util/threads.h
+++ b/src/util/threads.h
@@ -88,6 +88,11 @@ void virMutexUnlock(virMutexPtr m);
int virCondInit(virCon
instead of simple 'if' statement as virCondWait can return
even if associated condition was not signaled.
---
src/util/threadpool.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/util/threadpool.c b/src/util/threadpool.c
index 883d1e5..e8689d9 100644
--- a/src/util/t
On 12/09/2011 07:27 AM, Stefan Berger wrote:
> When parsing ppc64 models on an x86 host an out-of-memory error message
> is displayed due
> to it checking for retcpus being NULL. Fix this by removing the check
> whether retcpus is NULL
> since we will realloc into this variable.
> Also in the X86 m
On 12/09/2011 07:51 AM, Stefan Berger wrote:
> Fix memory leak:
>
> ==27534== 24 bytes in 1 blocks are definitely lost in loss record 207 of
> 530
> ==27534==at 0x4A05E46: malloc (vg_replace_malloc.c:195)
> ==27534==by 0x38EC26EC37: vasprintf (in /lib64/libc-2.13.so)
> ==27534==by 0x4E
On 12/09/2011 07:26 AM, Michal Privoznik wrote:
> Pool creates new workers dynamically. However, it is possible
> for a pool to have no workers. If we want to free that pool,
> we don't want to wait on quit condition as it will never be
> signaled.
> ---
> Pushing under trivial rule
>
> src/util/
On 12/09/2011 02:39 AM, Pankaj Rawat wrote:
> Hi .well I am trying to use virtioballon driver on my KVM host . I have
> assigned 400 MB current memory to my guest
>
> The ballon size is 600MB but when I used all the 400MB of guest the RAM
> of guest is not increasing.
>
>
>
> I watch the ram u
On Fri, Dec 09, 2011 at 10:24:06AM -0500, Dave Allan wrote:
> Hey all,
>
> I just noticed that make uninstall from the git HEAD fails:
>
> rmdir /etc/sasl2/
> rmdir: failed to remove `/etc/sasl2/': Directory not empty
>
> it's correct that /etc/sasl2 should not be removed, as it has other
> file
Hey all,
I just noticed that make uninstall from the git HEAD fails:
rmdir /etc/sasl2/
rmdir: failed to remove `/etc/sasl2/': Directory not empty
it's correct that /etc/sasl2 should not be removed, as it has other
files in it, so I think this removal should be more targeted, although
I haven't i
Dear Sir or Madam:
I am engineer who want to connect hyper-v R2 via libvirt 0.9.3, but after
create ceritificate file, and set the hyper-v winRM status to
AllowUnencrypted="true"
Then I connect the hyper-v by the command: virsh -c
hyperv://192.168.58.26:5985 it always reply:
Error: unable to
This patch adds documentation about the new 'ways' that users can
access the contents of variables in filters:
- access via index: $TEST[2]
- access via iterators $TEST[@1]
---
docs/formatnwfilter.html.in | 32 +++-
1 file changed, 31 insertions(+), 1 deletion(-)
I
In this patch we introduce testing whether the iterator points to a
unique set of entries that have not been seen before at one of the previous
iterations. The point is to eliminate duplicates and with that unnecessary
filtering rules by preventing identical filtering rules from being
instantiated.
This patch adds a couple of XML parser / schema validator test cases
for the new 'ways' to access variables via index or iterator.
---
tests/nwfilterxml2xmlin/iter-test1.xml |6 ++
tests/nwfilterxml2xmlin/iter-test2.xml | 23 +++
tests/nwfilterxml2xmlin/iter-test3.
Address side effect of accessing a variable via an index: Filters
accessing a variable where an element is accessed that is beyond the
size of the list (for example $TEST[10] and only 2 elements are available)
cannot instantiate that filter. Test for this and report proper error
to user.
---
src/
This patch enables access to variables in filters using indep. iterators
($TEST[$@2]) or via index ($TEST[1]).
Three test cases are added that are also being used for libvirt-TCK to
check that the instantiation of the filtering rules is correct.
Regards,
Stefan
--
libvir-list mailing list
This patch introduces the capability to use a different iterator per
variable.
The currently supported notation of variables in a filtering rule like
processes the two lists 'A' and 'B' in parallel. This means that A and B
must have the same number of 'N' elements and that 'N' rules
This patch adds access to single elements of variables via index. Example:
---
src/conf/nwfilter_params.c | 82 +++--
src/conf/nwfilter_params.h |9 +++-
2 files changed, 71 insertions(+), 20 deletions(-)
Index: libvirt-iterator/src/conf
Fix memory leak:
==27534== 24 bytes in 1 blocks are definitely lost in loss record 207 of 530
==27534==at 0x4A05E46: malloc (vg_replace_malloc.c:195)
==27534==by 0x38EC26EC37: vasprintf (in /lib64/libc-2.13.so)
==27534==by 0x4E998E6: virVasprintf (util.c:1677)
==27534==by 0x4E999F
Peter, it's okay for me, thanks.
Regards,
Alex
- Original Message -
From: "Peter Krempa"
To: "Alex Jia"
Cc: libvir-list@redhat.com
Sent: Friday, December 9, 2011 7:45:50 PM
Subject: Re: [libvirt] [PATCH] virsh: correct the cmdDomIfGetLink function
return value error
On 12/08/2011 10:3
When parsing ppc64 models on an x86 host an out-of-memory error message
is displayed due
to it checking for retcpus being NULL. Fix this by removing the check
whether retcpus is NULL
since we will realloc into this variable.
Also in the X86 model parser display the OOM error at the location wher
Pool creates new workers dynamically. However, it is possible
for a pool to have no workers. If we want to free that pool,
we don't want to wait on quit condition as it will never be
signaled.
---
Pushing under trivial rule
src/util/threadpool.c |3 ++-
1 files changed, 2 insertions(+), 1 del
This should silence this compile warning:
GENLibvirtGObject-1.0.gir
libvirt-gobject-stream.c:603: Warning: LibvirtGObject:
gvir_stream_add_watch: argument func: Missing (scope) annotation for
callback without GDestroyNotify (valid: call, async)
This also adds API documentation for these func
---
libvirt-gconfig/libvirt-gconfig-storage-pool.c | 12
libvirt-gconfig/libvirt-gconfig-storage-pool.h | 12
libvirt-gconfig/libvirt-gconfig.sym|2 ++
libvirt-gconfig/tests/test-domain-create.c |1 +
4 files changed, 27 insertions(+), 0 deleti
Hi,
On Fri, Dec 09, 2011 at 11:18:48AM +, Daniel P. Berrange wrote:
>
> There is something odd about the way it is being built:
> The combination of these 3 sets of messages, makes me think you have
> confused libtool into linking to the old binary
>
> What arguments are you passing to 'con
Hi .well I am trying to use virtioballon driver on my KVM host . I have
assigned 400 MB current memory to my guest
The ballon size is 600MB but when I used all the 400MB of guest the RAM
of guest is not increasing.
I watch the ram usage by running following command
#free -m
But the guest is
Hi,
today I was trying to use the --copy-storage-all feature of virsh
migrate, in an attempt to migrate KVM-instances to another storage
backend. Doing so, I ran into some trouble:
First of all, it turned out the disk image-file has to be present on the
receiving end of the migration. When,
On 2011年12月07日 17:16, Daniel P. Berrange wrote:
On Wed, Dec 07, 2011 at 08:21:06AM +0200, Sasha Levin wrote:
On Tue, 2011-12-06 at 14:38 +, Daniel P. Berrange wrote:
On Fri, Nov 11, 2011 at 07:56:58PM +0800, Osier Yang wrote:
* KVM tool manages the network completely itself (with DHCP s
On 2011年12月07日 14:21, Sasha Levin wrote:
On Tue, 2011-12-06 at 14:38 +, Daniel P. Berrange wrote:
On Fri, Nov 11, 2011 at 07:56:58PM +0800, Osier Yang wrote:
* Lacks of options for user's configuration, such as "-vnc", there
is no option for user to configure the properties for the
On 2011年12月06日 22:38, Daniel P. Berrange wrote:
On Fri, Nov 11, 2011 at 07:56:58PM +0800, Osier Yang wrote:
Hi, all
This is a basic implementation of libvirt Native Linux KVM
Tool driver. Note that this is just made with my own interest
and spare time, it's not an endorsement/effort by Red Hat,
Some folks may be aware of the SpecVirt benchmark, where KVM is giving
the competition something to worry about :-)
http://www.spec.org/virt_sc2010/results/
>From the POV of libvirt uses though, there has been one annoyance with
the previously submitted results though, in that they have been
On 09.12.2011 13:08, Jiri Denemark wrote:
> Due to copy&paste error in c1df2c14b590b3d68b707aa4f3a570f95a6bc548,
> virNetDevBridge[SG]etSTPDelay APIs were accessing wrong file.
> ---
> src/util/virnetdevbridge.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
ACK
Michal
--
li
Due to copy&paste error in c1df2c14b590b3d68b707aa4f3a570f95a6bc548,
virNetDevBridge[SG]etSTPDelay APIs were accessing wrong file.
---
src/util/virnetdevbridge.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c
inde
On 12/08/2011 08:01 PM, Eric Blake wrote:
On 12/08/2011 07:18 AM, Peter Krempa wrote:
Add support for newly supported Intel cpu features. Newly supported
flags are: pclmuldq, dtes64, smx, fma, pdcm, movbe, xsave, osxsave and
avx. This adds support for Intel's Sandy Bridge platform.
---
I did not
On 12/08/2011 10:31 AM, Alex Jia wrote:
On 12/08/2011 05:25 PM, Peter Krempa wrote:
On 12/08/2011 07:30 AM, a...@redhat.com wrote:
From: Alex Jia
* tools/virsh.c: Although finding interface with matching mac addr,
forgot to
set 'ret' boolean value to 'true'.
* how to reproduce?
% virsh domif-
On Fri, Dec 09, 2011 at 11:43:21AM +0100, Christophe Fergeau wrote:
> Hi,
>
> When building libvirt 0.9.8 with jhbuild, I have now reproduced twice some
> issue during the build. Namely, after successfully building and installing
> libvirt 0.9.8, when I try to run virsh, I get:
>
> virsh: /home/t
Hi,
When building libvirt 0.9.8 with jhbuild, I have now reproduced twice some
issue during the build. Namely, after successfully building and installing
libvirt 0.9.8, when I try to run virsh, I get:
virsh: /home/teuf/jhbuild-boxes/opt/lib64/libvirt.so.0: version
`LIBVIRT_PRIVATE_0.9.7' not foun
Hi,
Can somebody help me in solving the dmesg error:
macvtap0:no ipv6 routers present
From: xhu [mailto:x...@redhat.com]
Sent: Friday, December 09, 2011 10:53 AM
To: Amit Tewari
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] how to use macvtap in kv
On Thu, Dec 8, 2011 at 10:33 PM, Adam Litke wrote:
> Qemu has changed the semantics of the "block_job_cancel" API. Originally, the
> operation was synchronous (ie. upon command completion, the operation was
> guaranteed to be completely stopped). With the new semantics, a
> "block_job_cancel" me
72 matches
Mail list logo
