Re: [libvirt] [test-API][PATCH 1/2] Add test case get_cpu_shares.py for cpu scheduler info testing

2011-12-14 Thread Guannan Ren
On 12/14/2011 02:59 PM, Wayne Sun wrote: On 12/13/2011 11:45 AM, Nan Zhang wrote: * repos/domain/get_cpu_shares.py: get the value of cpu_shares property of the guest. --- lib/domainAPI.py |2 +- repos/domain/get_cpu_shares.py | 117

Re: [libvirt] [test-API][PATCH 2/2] Add test case set_cpu_shares.py for setting cpu scheduler info

2011-12-14 Thread Guannan Ren
On 12/14/2011 02:59 PM, Wayne Sun wrote: On 12/13/2011 11:45 AM, Nan Zhang wrote: * repos/domain/set_cpu_shares.py: set the value of cpu_shares property of the guest. --- repos/domain/set_cpu_shares.py | 121 1 files changed, 121 insertions(+),

Re: [libvirt] [PATCH v2 2/6] virsh: add support for VIR_DOMAIN_CONSOLE_FORCE flag

2011-12-14 Thread Peter Krempa
Dňa 14.12.2011 1:14, Eric Blake wrote / napísal(a): Hmm, wondering about back-compat - what happens if we are talking to an older libvirt that does not know VIR_DOMAIN_CONSOLE_FORCE, but also which does not prevent multiple connections when flags==0? At first glance, it looks like we're stuck

Re: [libvirt] [test-API][PATCH 2/2] Add case for testing spice compression options

2011-12-14 Thread Osier Yang
On 2011年09月29日 17:30, Nan Zhang wrote: * repos/domain/spice_options.py: add this test for BZ#682237 --- repos/domain/spice_options.py | 138 + 1 files changed, 138 insertions(+), 0 deletions(-) create mode 100644 repos/domain/spice_options.py diff

Re: [libvirt] [test-API][PATCH 1/2] Add support for spice graphics

2011-12-14 Thread Osier Yang
On 2011年09月29日 17:30, Nan Zhang wrote: * utils/Python/xmlgenerator.py: This extends graphics element for spice XML composing, and support sub-elements settings for audio, images, streaming and so on: graphics type='spice' autoport='yes' image compression='auto_glz'/

Re: [libvirt] libvirt support on QNX

2011-12-14 Thread Daniel P. Berrange
On Wed, Dec 14, 2011 at 01:01:31PM +0530, Chandrashekhar Jamadarkhani (cjamadar) wrote: In which dir the source code for libvirt RPC client driver located to port it to QNX ? Is it in libvirt-0.9.8/src/remote ? src/remote is the dispatch code for the client. src/rpc is the general RPC

[libvirt] [PATCH] qemu: Fix race between async and query jobs

2011-12-14 Thread Jiri Denemark
If an async job run on a domain will stop the domain at the end of the job, a concurrently run query job can hang in qemu monitor nothing can be done with that domain from this point on. An attempt to start such domain results in Timed out during operation: cannot acquire state change lock error.

[libvirt] [PATCH 0/5 v3] Interface pools and passthrough mode

2011-12-14 Thread Shradha Shah
Interface Pools and Passthrough mode: Current Method: The passthrough mode uses a macvtap direct connection to connect each guest to the network. The physical interface to be used is picked from among those listed in interface sub elements of the forward element. The current specification for

[libvirt] [PATCH 1/5 v3] Added function pciSysfsFile to enable access to the PCI SYSFS files.

2011-12-14 Thread Shradha Shah
--- src/util/pci.c | 16 src/util/pci.h |2 ++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/src/util/pci.c b/src/util/pci.c index cd82b43..d0ba4c5 100644 --- a/src/util/pci.c +++ b/src/util/pci.c @@ -2027,6 +2027,22 @@ out: } /* + * Returns a path to

[libvirt] [PATCH 3/5 v3] Adding the element pf to network xml.

2011-12-14 Thread Shradha Shah
This element will help the user to just specify the SR-IOV physical function in order to access all the Virtual functions attached to it. --- docs/schemas/network.rng |7 src/conf/network_conf.c | 69 +++-- src/conf/network_conf.h |3 ++ 3

[libvirt] [PATCH 4/5 v3] Functionality to implicitly get interface pool from SR-IOV PF.

2011-12-14 Thread Shradha Shah
If a system has 64 or more VF's, it is quite tedious to mention each VF in the interface pool. The following modification will implicitly create an interface pool from the SR-IOV PF. --- src/network/bridge_driver.c | 93 +- 1 files changed, 73

[libvirt] [PATCH 2/5 v3] Added Function virNetDevGetVirtualFunctions

2011-12-14 Thread Shradha Shah
This functions enables us to get the Virtual Functions attached to a Physical function given the name of a SR-IOV physical functio. In order to accomplish the task, added a getter function pciGetDeviceAddrString to get the BDF of the Virtual Function in a char array. --- src/util/pci.c |

[libvirt] [PATCH 5/5 v3] Added new option to virsh net-dumpxml called --inactive

2011-12-14 Thread Shradha Shah
The above option helps to differentiate between implicit and explicit interface pools. --- include/libvirt/libvirt.h.in |4 src/conf/network_conf.c | 10 +++--- src/conf/network_conf.h |2 +- src/network/bridge_driver.c |4 ++-- src/test/test_driver.c |

[libvirt] [PATCH] rpc: retry to call dup() if fcntl with CLOEXEC fails

2011-12-14 Thread dongsu . park
From: Dongsu Park dongsu.p...@profitbricks.com If fcntl with F_DUPFD_CLOEXEC fails, we need to try again to use dup() to get the fd, instead of giving up right away. Signed-off-by: Dongsu Park dongsu.p...@profitbricks.com Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com

[libvirt] Fwd: [MacPorts] #32523: libvirt: update to 0.9.8

2011-12-14 Thread Justin Clift
Hi all, Just an FYI. Libvirt is now available through the Mac MacPorts package system, as well as HomeBrew. Hope that's useful. :) Regards and best wishes, Justin Clift Begin forwarded message: From: MacPorts nore...@macports.org Subject: Re: [MacPorts] #32523: libvirt: update to 0.9.8

[libvirt] macvtap nt working on kvm

2011-12-14 Thread Amit Tewari
Hi all, My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor I have made this entry in guest xml file interface type='direct' source dev='eth0' mode='bridge'/ model type='virtio'/ address type='pci' domain='0x' bus='0x00'

[libvirt] [PATCH] python: Expose blockPeek and memoryPeek in Python binding

2011-12-14 Thread Osier Yang
An simple example to show to use it: \#! /usr/bin/python import os import sys import libvirt disk = /var/lib/libvirt/images/test.img conn = libvirt.open(None) dom = conn.lookupByName('test') mem_contents = dom.memoryPeek(0, 128, libvirt.VIR_MEMORY_VIRTUAL); sys.stdout.write(mem_contents) %

Re: [libvirt] [PATCH] python: Expose blockPeek and memoryPeek in Python binding

2011-12-14 Thread Osier Yang
On 2011年12月14日 21:16, Osier Yang wrote: An simple example to show to use it: s/An/a/, s/to/how to/ \#! /usr/bin/python import os import sys import libvirt disk = /var/lib/libvirt/images/test.img conn = libvirt.open(None) dom = conn.lookupByName('test') mem_contents =

Re: [libvirt] [PATCH] rpc: retry to call dup() if fcntl with CLOEXEC fails

2011-12-14 Thread Eric Blake
On 12/14/2011 04:19 AM, dongsu.p...@profitbricks.com wrote: From: Dongsu Park dongsu.p...@profitbricks.com If fcntl with F_DUPFD_CLOEXEC fails, we need to try again to use dup() to get the fd, instead of giving up right away. NACK. gnulib guarantees that F_DUPFD_CLOEXEC works (albeit not

Re: [libvirt] [PATCH] python: Expose blockPeek and memoryPeek in Python binding

2011-12-14 Thread Eric Blake
On 12/14/2011 06:16 AM, Osier Yang wrote: An simple example to show to use it: \#! /usr/bin/python import os import sys import libvirt disk = /var/lib/libvirt/images/test.img conn = libvirt.open(None) dom = conn.lookupByName('test') mem_contents = dom.memoryPeek(0, 128,

Re: [libvirt] [libvirt-glib 02/10] Add GVirConfigStoragePool setters

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:51PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-storage-pool.c | 49 +++- libvirt-gconfig/libvirt-gconfig-storage-pool.h | 11 + libvirt-gconfig/libvirt-gconfig.sym|5 ++ 3 files changed, 64

Re: [libvirt] [libvirt-glib 01/10] Add some GVirConfigStorageVol setters

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:50PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-storage-vol.c | 29 + libvirt-gconfig/libvirt-gconfig-storage-vol.h |7 ++ libvirt-gconfig/libvirt-gconfig.sym |3 ++ 3 files changed, 39

Re: [libvirt] [libvirt-glib 03/10] Add GObject boilerplate for GVirConfigStorage*

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:52PM +0100, Christophe Fergeau wrote: We'll need several helper classes to implement configuration of storage pools and volumes. This commit introduces all of these in one go. It's just the GObject boilerplate, the actual code will come in other commits.

Re: [libvirt] [libvirt-glib 05/10] Add GVirConfigStorageVolBackingStore setters

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:54PM +0100, Christophe Fergeau wrote: --- .../libvirt-gconfig-storage-vol-backing-store.c| 22 .../libvirt-gconfig-storage-vol-backing-store.h|4 +++ libvirt-gconfig/libvirt-gconfig.sym|2 + 3 files

Re: [libvirt] [libvirt-glib 04/10] Add gvir_config_storage_vol_target_set_format

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:53PM +0100, Christophe Fergeau wrote: --- .../libvirt-gconfig-storage-vol-target.c | 13 + .../libvirt-gconfig-storage-vol-target.h |3 +++ libvirt-gconfig/libvirt-gconfig.sym|1 + 3 files changed, 17

Re: [libvirt] [libvirt-glib 08/10] Add GVirConfigStoragePermissions setters

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:57PM +0100, Christophe Fergeau wrote: --- .../libvirt-gconfig-storage-permissions.c | 37 .../libvirt-gconfig-storage-permissions.h |9 + libvirt-gconfig/libvirt-gconfig.sym|4 ++ 3 files

Re: [libvirt] [libvirt-glib 07/10] Add gvir_config_storage_pool_target_set_path

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:56PM +0100, Christophe Fergeau wrote: --- .../libvirt-gconfig-storage-pool-target.c |9 + .../libvirt-gconfig-storage-pool-target.h |3 +++ libvirt-gconfig/libvirt-gconfig.sym|1 + 3 files changed, 13

Re: [libvirt] [libvirt-glib 09/10] Add methods to link GVirStorage* classes together

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:58PM +0100, Christophe Fergeau wrote: GVirConfigStorageVolBackingStore and GVirConfigStorageVolTarget can be associated with a GVirConfigStorageVol. GVirConfigStoragePoolSource and GVirConfigStoragePoolTarget can be associated with a GVirConfigStoragePool.

Re: [libvirt] [libvirt-glib 06/10] Add GVirConfigStoragePoolSource setters

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:55PM +0100, Christophe Fergeau wrote: --- .../libvirt-gconfig-storage-pool-source.c | 100 .../libvirt-gconfig-storage-pool-source.h | 17 libvirt-gconfig/libvirt-gconfig.sym|8 ++ 3 files

Re: [libvirt] [libvirt-glib 11/10] Add gvir_config_storage_pool_set_pool_type

2011-12-14 Thread Daniel P. Berrange
On Fri, Dec 09, 2011 at 02:20:23PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-storage-pool.c | 12 libvirt-gconfig/libvirt-gconfig-storage-pool.h | 12 libvirt-gconfig/libvirt-gconfig.sym|2 ++

Re: [libvirt] [libvirt-glib 10/10] Add GVirConfigStorage* to creation test

2011-12-14 Thread Daniel P. Berrange
On Tue, Dec 06, 2011 at 04:00:59PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/tests/test-domain-create.c | 62 +++- 1 files changed, 60 insertions(+), 2 deletions(-) ACK Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH v2 5/6] util: Add helpers for safe domain console operations

2011-12-14 Thread Eric Blake
On 12/13/2011 05:31 PM, Eric Blake wrote: On 12/07/2011 11:08 AM, Peter Krempa wrote: This patch adds a set of functions used in creating console streams for domains using PTYs and ensures mutualy exculsive access to the PTYs. s/mutualy exculsive/mutually exclusive/ --- configure.ac

Re: [libvirt] [PATCH v2 2/6] virsh: add support for VIR_DOMAIN_CONSOLE_FORCE flag

2011-12-14 Thread Eric Blake
On 12/14/2011 01:46 AM, Peter Krempa wrote: But maybe we could add a new API, to allow probing whether a console is in use. If the API exists, then we know whether the console is in use (and we also know whether --force will work); if the API does not exist, the we know we are talking to an

Re: [libvirt] [PATCH] qemu: Fix race between async and query jobs

2011-12-14 Thread Eric Blake
On 12/14/2011 03:29 AM, Jiri Denemark wrote: If an async job run on a domain will stop the domain at the end of the job, a concurrently run query job can hang in qemu monitor nothing can be done with that domain from this point on. An attempt to start such domain results in Timed out during

Re: [libvirt] [PATCH 3/3] spec: fix sanlock dependency

2011-12-14 Thread Eric Blake
On 12/13/2011 06:52 PM, Wen Congyang wrote: At 12/06/2011 01:38 AM, Eric Blake Write: * libvirt.spec.in (with_sanlock): On RHEL, don't force sanlock on architectures where it isn't available. --- libvirt.spec.in | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) ++#

Re: [libvirt] macvtap nt working on kvm

2011-12-14 Thread Laine Stump
On 12/14/2011 07:40 AM, Amit Tewari wrote: Hi all, My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor I have made this entry in guest xml file interface type='direct' source dev='eth0' mode='bridge'/ model type='virtio'/ address type='pci'

[libvirt] [PATCHv2] build: let autobuild check more code

2011-12-14 Thread Eric Blake
Many times, we don't notice a bug in src/libvirt_private.syms until someone attempts a build with modules enabled. Likewise, some gcc warnings about no % in a printf format string only appear under --disable-nls. And configure.ac should automatically be excluding modules on mingw without us

Re: [libvirt] [PATCH 1/8] Convert Xen VBox drivers to use virDomainEventState

2011-12-14 Thread Eric Blake
On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The Xen VBox drivers deal with callbacks dispatching of events directly. All the other drivers use a timer to dispatch events from a clean stack state, rather than deep inside the drivers.

Re: [libvirt] [PATCH 1/8] Convert Xen VBox drivers to use virDomainEventState

2011-12-14 Thread Eric Blake
On 12/14/2011 11:17 AM, Eric Blake wrote: On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The Xen VBox drivers deal with callbacks dispatching of events directly. All the other drivers use a timer to dispatch events from a clean stack state,

Re: [libvirt] libvirt support on QNX

2011-12-14 Thread Chandrashekhar Jamadarkhani (cjamadar)
Config.h file is missing in qnx. What is the path to config.h in linux ? Build Error (pasted here for one file only) src/util/iptables.c:22:20: error: config.h: No such file or directory Thanks, Chandrashekhar -Original Message- From: Chandrashekhar Jamadarkhani (cjamadar) Sent:

Re: [libvirt] libvirt support on QNX

2011-12-14 Thread Eric Blake
On 12/14/2011 11:45 AM, Chandrashekhar Jamadarkhani (cjamadar) wrote: [Developers prefer that you avoid top-posting on technical lists like this] Config.h file is missing in qnx. What is the path to config.h in linux ? config.h is a generated file, which is built as the result of running

Re: [libvirt] [PATCH 2/8] Return count of callbacks when registering callbacks

2011-12-14 Thread Eric Blake
On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com When registering a callback for a particular event some callers need to know how many callbacks already exist for that event. While it is possible to ask for a count, this is not free from race

Re: [libvirt] macvtap nt working on kvm

2011-12-14 Thread Stefan Berger
On 12/14/2011 07:40 AM, Amit Tewari wrote: Hi all, My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor I have made this entry in guest xml file interface type='direct' source dev='eth0' mode='bridge'/ model type='virtio'/ address type='pci'

Re: [libvirt] [PATCH 3/8] Add APIs to allow management of callbacks purely with virDomainEventState

2011-12-14 Thread Eric Blake
On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com While virDomainEventState has APIs for managing removal of callbacks, while locked, adding callbacks in the first place requires direct access to the virDomainEventCallbackList structure. This is

Re: [libvirt] [PATCH 4/8] Convert drivers to thread safe APIs for adding callbacks

2011-12-14 Thread Eric Blake
On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com * src/libxl/libxl_driver.c, src/lxc/lxc_driver.c, src/qemu/qemu_driver.c, src/remote/remote_driver.c, src/test/test_driver.c, src/uml/uml_driver.c, src/vbox/vbox_tmpl.c,

Re: [libvirt] [PATCH 5/8] Remove all domain event structs from header

2011-12-14 Thread Eric Blake
On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com No caller of the domain events APIs should need to poke at the struct internals. Thus they should all be removed from the header file * src/conf/domain_event.h: Remove struct definitions *

Re: [libvirt] [PATCH 6/8] Remove decl of all APIs related to domain event callbacks queues

2011-12-14 Thread Eric Blake
On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virDomainEventCallbackList and virDomainEventQueue APIs are now solely helpers used internally by virDomainEventState APIs. Remove their decls from domain_event.h since no driver code should

Re: [libvirt] [PATCH 0/8] Refactor event state handling to fix crash

2011-12-14 Thread Laine Stump
On 12/13/2011 07:38 PM, Daniel P. Berrange wrote: When running while true ; do date ; ../tools/virsh -q -c test:///default 'shutdown test; undefine test; dominfo test' ; done I can give a functional ACK on this - my similar test had previously hung consistently at least once every 80

Re: [libvirt] [PATCH 1/8] Convert Xen VBox drivers to use virDomainEventState

2011-12-14 Thread Eric Blake
On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The Xen VBox drivers deal with callbacks dispatching of events directly. All the other drivers use a timer to dispatch events from a clean stack state, rather than deep inside the drivers.

Re: [libvirt] [PATCH 7/8] Hide use of timers for domain event dispatch

2011-12-14 Thread Eric Blake
On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently all drivers using domain events need to provide a callback for handling a timer to dispatch events in a clean stack. There is no technical reason for dispatch to go via driver specific

Re: [libvirt] macvtap nt working on kvm

2011-12-14 Thread Laine Stump
On 12/14/2011 02:26 PM, Stefan Berger wrote: On 12/14/2011 07:40 AM, Amit Tewari wrote: Hi all, My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor I have made this entry in guest xml file interface type='direct' source dev='eth0' mode='bridge'/ model

Re: [libvirt] [PATCH 8/8] Only add the timer when a callback is registered

2011-12-14 Thread Eric Blake
On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The lifetime of the virDomainEventState object is tied to the lifetime of the driver, which in stateless drivers is tied to the lifetime of the virConnectPtr. If we add remove a timer when

Re: [libvirt] [PATCH RESEND] qemu: Do not free the device from activePciHostdevs if it's in use

2011-12-14 Thread Eric Blake
On 11/29/2011 03:23 AM, Osier Yang wrote: * src/qemu/qemu_hostdev.c (qemuDomainReAttachHostdevDevices): pciDeviceListFree(pcidevs) in the end free()s the device even if it's in use by other domain, which can cause rase. s/rase/a race/ ... The patch also fixes another problem, there won't

Re: [libvirt] [PATCH RESEND] qemu: Honor the original properties of PCI device when detaching

2011-12-14 Thread Eric Blake
On 11/29/2011 03:09 AM, Osier Yang wrote: This patch fixes two problems: 1) The device will be reattached to host even if it's not managed, as there is a pciDeviceSetManaged. 2) The device won't be reattached to host with original driver properly. As it doesn't honor the

Re: [libvirt] [PATCH v2 5/6] util: Add helpers for safe domain console operations

2011-12-14 Thread Eric Blake
On 12/07/2011 11:08 AM, Peter Krempa wrote: This patch adds a set of functions used in creating console streams for domains using PTYs and ensures mutualy exculsive access to the PTYs. If mutualy exclusive access is not used, two clients may open the same console, which results into

Re: [libvirt] virtio console: name=foo is not supported

2011-12-14 Thread MATSUDA, Daiki
(2011/12/13 13:02), MATSUDA, Daiki wrote: (2011/12/12 22:58), Daniel P. Berrange wrote: On Mon, Dec 12, 2011 at 10:18:23AM +0900, MATSUDA, Daiki wrote: In addition, the QEMU guest agent requires specified socket. Virt IO Console, too. But unfortunately libvirt does not support to xml tags to

Re: [libvirt] [PATCH RESEND] qemu: Honor the original properties of PCI device when detaching

2011-12-14 Thread Osier Yang
On 2011年12月15日 07:01, Eric Blake wrote: On 11/29/2011 03:09 AM, Osier Yang wrote: This patch fixes two problems: 1) The device will be reattached to host even if it's not managed, as there is a pciDeviceSetManaged. 2) The device won't be reattached to host with original

Re: [libvirt] macvtap nt working on kvm

2011-12-14 Thread Amit Tewari
Hi, Actually macvatap doesn't work with bridge. So once the physical device is attached to a bridge, a macvtap attached to that device no longer works. In my case there is no bridge on the interface. but still guest os is not able to get ip address. Is there no support for macvtap on red hat 6.1

Re: [libvirt] macvtap nt working on kvm

2011-12-14 Thread Amit Tewari
Hi Stefan, May be you can try again this test of macvtap on your environment, but please remove the bridge from eth0. because macvtap doesent work with bridge setup. -Original Message- From: Amit Tewari Sent: Thursday, December 15, 2011 9:05 AM To: 'Laine Stump'; libvir-list@redhat.com