Re: [libvirt] [PATCH 0/4] Add new public API virDomainGetPcpusUsage and pcpuinfo command in virsh

2011-12-15 Thread Lai Jiangshan
Hi, Eric On 12/08/2011 11:44 AM, Eric Blake wrote: On 12/07/2011 08:40 PM, Lai Jiangshan wrote: virt-top -1 can call virDomainGetPcpusUsage() periodically and get the CPU activities per CPU. (still require virt-top site patch). virsh is also added a pcpuinfo command which calls

Re: [libvirt] [PATCHv2] build: let autobuild check more code

2011-12-15 Thread Daniel P. Berrange
On Wed, Dec 14, 2011 at 11:02:23AM -0700, Eric Blake wrote: Many times, we don't notice a bug in src/libvirt_private.syms until someone attempts a build with modules enabled. Likewise, some gcc warnings about no % in a printf format string only appear under --disable-nls. And configure.ac

[libvirt] FW: macvtap not working on rhel 6.1 x86 machine

2011-12-15 Thread Amit Tewari
Hi all, My test environment Host os=rhel6.1 x86 machine Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor I am creating macvtap interface on host machine ip link add link eth1 name macvtap0 type macvtap ip link set macvtap0 up ip link show macvtap0 25: macvtap0@eth1:

Re: [libvirt] FW: macvtap not working on rhel 6.1 x86 machine

2011-12-15 Thread Gerhard Stenzel
On Thu, 2011-12-15 at 15:20 +0530, Amit Tewari wrote: Hi all, My test environment Host os=rhel6.1 x86 machine Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor Hi, maybe it would help if you try to explain first, what you are trying to achieve, what your setup looks like

Re: [libvirt] FW: macvtap not working on rhel 6.1 x86 machine

2011-12-15 Thread Amit Tewari
hi, i want the kvm guest machine to connect to network using macvtap.. I tried this vepa mode it is also not working. My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor I have made this entry in guest xml file interface type='direct' source

[libvirt] [PATCHv3 0/8] add command numatune

2011-12-15 Thread Hu Tao
This series adds a new command numatune to get/set numatune parameters. Besides libnuma, cpuset cgroup parameters are also set according to numatune parameters. But for now, only cpuset.mems is supported. Hu Tao (8): Add functions to set/get cgroup cpuset parameters use cpuset to manage numa

[libvirt] [PATCHv3 1/8] Add functions to set/get cgroup cpuset parameters

2011-12-15 Thread Hu Tao
--- src/libvirt_private.syms |2 ++ src/util/cgroup.c| 32 src/util/cgroup.h|3 +++ 3 files changed, 37 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 48ffdf2..e39b076 100644 ---

[libvirt] [PATCHv3 5/8] Add virDomain{G, S}etNumaParameters support to the remote driver

2011-12-15 Thread Hu Tao
--- daemon/remote.c | 64 ++ src/remote/remote_driver.c | 50 src/remote/remote_protocol.x | 24 +++- src/remote_protocol-structs | 16 ++ 4 files changed, 153 insertions(+), 1

[libvirt] [PATCHv3 7/8] add new command numatune to virsh

2011-12-15 Thread Hu Tao
add new command numatune to virsh to get/set numa parameters --- tools/virsh.c | 181 + 1 files changed, 181 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index f6571f7..2b509bf 100644 --- a/tools/virsh.c +++

[libvirt] [PATCHv3 2/8] use cpuset to manage numa

2011-12-15 Thread Hu Tao
This patch also sets cgroup cpuset parameters for numatune. --- src/qemu/qemu_cgroup.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index d663798..2d970d6 100644 --- a/src/qemu/qemu_cgroup.c +++

[libvirt] [PATCHv3 6/8] Implement virDomain{G, S}etNumaParameters for the qemu driver

2011-12-15 Thread Hu Tao
--- src/qemu/qemu_driver.c | 334 1 files changed, 334 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 725b593..cc94fec 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -97,6

[libvirt] [PATCHv3 8/8] Add document for new command numatune.

2011-12-15 Thread Hu Tao
--- tools/virsh.pod | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index c468f13..91baf4d 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -832,6 +832,19 @@ migrated to another host. Get the maximum migration

[libvirt] [PATCHv3 4/8] Implement main entries of virDomain{G, S}etNumaParameters

2011-12-15 Thread Hu Tao
--- src/libvirt.c | 113 + 1 files changed, 113 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 9977915..e61d91e 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -3769,6 +3769,119 @@ error: } /** + *

[libvirt] [PATCHv3 3/8] add new API virDomain{G, S}etNumaParameters

2011-12-15 Thread Hu Tao
Set up the types for the numa functions and insert them into the virDriver structure definition. --- include/libvirt/libvirt.h.in | 23 +++ python/generator.py |2 ++ src/driver.h | 15 +++ src/libvirt_public.syms |6 ++

Re: [libvirt] [PATCH] qemu: Fix race between async and query jobs

2011-12-15 Thread Jiri Denemark
On Wed, Dec 14, 2011 at 10:05:03 -0700, Eric Blake wrote: On 12/14/2011 03:29 AM, Jiri Denemark wrote: If an async job run on a domain will stop the domain at the end of the job, a concurrently run query job can hang in qemu monitor nothing can be done with that domain from this point on.

Re: [libvirt] FW: macvtap not working on rhel 6.1 x86 machine

2011-12-15 Thread Gerhard Stenzel
On Thu, 2011-12-15 at 15:54 +0530, Amit Tewari wrote: hi, i want the kvm guest machine to connect to network using macvtap.. I tried this vepa mode it is also not working. where is your DHCP server? On the network or on your host? eth0 has same mac address as that of macvatap0 that is

Re: [libvirt] FW: macvtap not working on rhel 6.1 x86 machine

2011-12-15 Thread Amit Tewari
Hi, Can you please tell me what step iam missing? -Original Message- From: Gerhard Stenzel [mailto:gsten...@linux.vnet.ibm.com] Sent: Thursday, December 15, 2011 5:03 PM To: Amit Tewari Cc: libvir-list@redhat.com Subject: RE: [libvirt] FW: macvtap not working on rhel 6.1 x86 machine On

[libvirt] Need source for sanlock and libvirt-lock-sanlock

2011-12-15 Thread Upendra Moturi
Hello Can some please point me the location of sanlock and libvirt-lock-sanlock source. And also install them from source. -- Thanks and Regards, Upendra.M As a leading developer of IT infrastructure software solutions, Hexagrid developed the first cloud computing platform that directly

[libvirt] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Stefan Hajnoczi
What is the status of QEMU's transition from HMP to the QMP interface? My current understanding is that QEMU provides new HMP commands for humans, but HMP is being phased out as an API. Management tools should rely only on QMP for new commands. That would mean new HMP commands are not

Re: [libvirt] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Jan Kiszka
On 2011-12-15 14:02, Stefan Hajnoczi wrote: What is the status of QEMU's transition from HMP to the QMP interface? My current understanding is that QEMU provides new HMP commands for humans, but HMP is being phased out as an API. Management tools should rely only on QMP for new commands.

Re: [libvirt] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Kevin Wolf
Am 15.12.2011 14:18, schrieb Jan Kiszka: On 2011-12-15 14:02, Stefan Hajnoczi wrote: What is the status of QEMU's transition from HMP to the QMP interface? My current understanding is that QEMU provides new HMP commands for humans, but HMP is being phased out as an API. Management tools

Re: [libvirt] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Stefan Berger
On 12/15/2011 08:02 AM, Stefan Hajnoczi wrote: What is the status of QEMU's transition from HMP to the QMP interface? My current understanding is that QEMU provides new HMP commands for humans, but HMP is being phased out as an API. Management tools should rely only on QMP for new commands.

Re: [libvirt] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Jan Kiszka
On 2011-12-15 14:33, Kevin Wolf wrote: Am 15.12.2011 14:18, schrieb Jan Kiszka: On 2011-12-15 14:02, Stefan Hajnoczi wrote: What is the status of QEMU's transition from HMP to the QMP interface? My current understanding is that QEMU provides new HMP commands for humans, but HMP is being

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Jan Kiszka
On 2011-12-15 14:38, Lucas Meneghel Rodrigues wrote: On 12/15/2011 11:33 AM, Kevin Wolf wrote: Am 15.12.2011 14:18, schrieb Jan Kiszka: On 2011-12-15 14:02, Stefan Hajnoczi wrote: What is the status of QEMU's transition from HMP to the QMP interface? My current understanding is that QEMU

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Kevin Wolf
Am 15.12.2011 14:39, schrieb Jan Kiszka: On 2011-12-15 14:38, Lucas Meneghel Rodrigues wrote: On 12/15/2011 11:33 AM, Kevin Wolf wrote: Am 15.12.2011 14:18, schrieb Jan Kiszka: On 2011-12-15 14:02, Stefan Hajnoczi wrote: What is the status of QEMU's transition from HMP to the QMP interface?

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Stefan Hajnoczi
On Thu, Dec 15, 2011 at 1:39 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2011-12-15 14:38, Lucas Meneghel Rodrigues wrote: On 12/15/2011 11:33 AM, Kevin Wolf wrote: Am 15.12.2011 14:18, schrieb Jan Kiszka: On 2011-12-15 14:02, Stefan Hajnoczi wrote: What is the status of QEMU's transition

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Stefan Hajnoczi
On Thu, Dec 15, 2011 at 1:49 PM, Kevin Wolf kw...@redhat.com wrote: Am 15.12.2011 14:39, schrieb Jan Kiszka: On 2011-12-15 14:38, Lucas Meneghel Rodrigues wrote: On 12/15/2011 11:33 AM, Kevin Wolf wrote: Am 15.12.2011 14:18, schrieb Jan Kiszka: On 2011-12-15 14:02, Stefan Hajnoczi wrote:

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Jan Kiszka
On 2011-12-15 14:53, Stefan Hajnoczi wrote: On Thu, Dec 15, 2011 at 1:49 PM, Kevin Wolf kw...@redhat.com wrote: Am 15.12.2011 14:39, schrieb Jan Kiszka: On 2011-12-15 14:38, Lucas Meneghel Rodrigues wrote: On 12/15/2011 11:33 AM, Kevin Wolf wrote: Am 15.12.2011 14:18, schrieb Jan Kiszka: On

Re: [libvirt] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Luiz Capitulino
On Thu, 15 Dec 2011 13:02:40 + Stefan Hajnoczi stefa...@gmail.com wrote: What is the status of QEMU's transition from HMP to the QMP interface? Depends on what you consider the transition to be. For management tools the transition can be considered done already because we do not support

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Anthony Liguori
On 12/15/2011 07:57 AM, Luiz Capitulino wrote: On Thu, 15 Dec 2011 13:02:40 + Stefan Hajnoczistefa...@gmail.com wrote: What is the status of QEMU's transition from HMP to the QMP interface? Depends on what you consider the transition to be. For management tools the transition can be

Re: [libvirt] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Stefan Hajnoczi
On Thu, Dec 15, 2011 at 1:57 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 15 Dec 2011 13:02:40 + Stefan Hajnoczi stefa...@gmail.com wrote: What is the status of QEMU's transition from HMP to the QMP interface? Depends on what you consider the transition to be. For

[libvirt] Modern CPU models cannot be used with libvirt

2011-12-15 Thread Jiri Denemark
Hi, Recently I realized that all modern CPU models defined in /etc/qemu/target-x86_64.conf are useless when qemu is used through libvirt. That's because we start qemu with -nodefconfig which results in qemu ignoring that file with CPU model definitions. We have a very good reason for using

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Luiz Capitulino
On Thu, 15 Dec 2011 08:06:41 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 12/15/2011 07:57 AM, Luiz Capitulino wrote: On Thu, 15 Dec 2011 13:02:40 + Stefan Hajnoczistefa...@gmail.com wrote: What is the status of QEMU's transition from HMP to the QMP interface? Depends

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Luiz Capitulino
On Thu, 15 Dec 2011 14:57:51 +0100 Jan Kiszka jan.kis...@siemens.com wrote: On 2011-12-15 14:53, Stefan Hajnoczi wrote: On Thu, Dec 15, 2011 at 1:49 PM, Kevin Wolf kw...@redhat.com wrote: Am 15.12.2011 14:39, schrieb Jan Kiszka: On 2011-12-15 14:38, Lucas Meneghel Rodrigues wrote: On

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Anthony Liguori
On 12/15/2011 08:52 AM, Luiz Capitulino wrote: On Thu, 15 Dec 2011 08:06:41 -0600 Anthony Liguorianth...@codemonkey.ws wrote: There are still a lot of HMP commands that don't have an QMP analog. Luiz, it might make sense to setup a wiki page which instructions on how to convert an HMP

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2011-12-15 Thread Anthony Liguori
On 12/15/2011 08:54 AM, Jiri Denemark wrote: Hi, Recently I realized that all modern CPU models defined in /etc/qemu/target-x86_64.conf are useless when qemu is used through libvirt. That's because we start qemu with -nodefconfig which results in qemu ignoring that file with CPU model

[libvirt] [PATCH v4] virsh: Add option to undefine storage with domains

2011-12-15 Thread Peter Krempa
Add an option for virsh undefine command, to remove associated storage volumes while undefining a domain. This patch allows the user to remove associated (libvirt managed ) storage volumes while undefining a domain. The new option --storage for the undefine command takes a string argument that

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2011-12-15 Thread Jiri Denemark
On Thu, Dec 15, 2011 at 08:58:55 -0600, Anthony Liguori wrote: Pass '-readconfig /etc/qemu/target-x86_64.conf' to pick up those models and if you are absolutely insistent on not giving the user any ability to change things on their own, cp the file from qemu.git into libvirt.git and

Re: [libvirt] [Qemu-devel] Transitioning from HMP to QMP for QEMU

2011-12-15 Thread Lucas Meneghel Rodrigues
On 12/15/2011 11:33 AM, Kevin Wolf wrote: Am 15.12.2011 14:18, schrieb Jan Kiszka: On 2011-12-15 14:02, Stefan Hajnoczi wrote: What is the status of QEMU's transition from HMP to the QMP interface? My current understanding is that QEMU provides new HMP commands for humans, but HMP is being

Re: [libvirt] Modern CPU models cannot be used with libvirt

2011-12-15 Thread Daniel P. Berrange
On Thu, Dec 15, 2011 at 03:54:15PM +0100, Jiri Denemark wrote: Hi, Recently I realized that all modern CPU models defined in /etc/qemu/target-x86_64.conf are useless when qemu is used through libvirt. That's because we start qemu with -nodefconfig which results in qemu ignoring that file

Re: [libvirt] [libvirt-glib 03/10] Add GObject boilerplate for GVirConfigStorage*

2011-12-15 Thread Christophe Fergeau
On Wed, Dec 14, 2011 at 02:51:33PM +, Daniel P. Berrange wrote: On Tue, Dec 06, 2011 at 04:00:52PM +0100, Christophe Fergeau wrote: We'll need several helper classes to implement configuration of storage pools and volumes. This commit introduces all of these in one go. It's just the

Re: [libvirt] [libvirt-glib 03/10] Add GObject boilerplate for GVirConfigStorage*

2011-12-15 Thread Daniel P. Berrange
On Thu, Dec 15, 2011 at 05:07:47PM +0100, Christophe Fergeau wrote: On Wed, Dec 14, 2011 at 02:51:33PM +, Daniel P. Berrange wrote: On Tue, Dec 06, 2011 at 04:00:52PM +0100, Christophe Fergeau wrote: We'll need several helper classes to implement configuration of storage pools and

[libvirt] PATCH: Inform QEMU prepare hook of migration in progress

2011-12-15 Thread Adam Tilghman
From: Eric Blake eblake redhat com Subject: Re: [libvirt-users] Wanted: method for qemu hook script to know if called for migration Date: Mon, 25 Jul 2011 14:17:08 -0600 As a feature suggestion, it would be nice if that fourth input variable, currently -, was something like migrate in this

Re: [libvirt] [PATCH libvirt-glib 1/2] Add binding for virDomainOpenConsole

2011-12-15 Thread Christophe Fergeau
On Mon, Dec 12, 2011 at 04:04:44PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-domain.c | 48 ++ libvirt-gobject/libvirt-gobject-domain.h |6 libvirt-gobject/libvirt-gobject.sym

Re: [libvirt] [PATCH libvirt-glib 2/2] Add binding for virDomainOpenGraphics

2011-12-15 Thread Christophe Fergeau
On Mon, Dec 12, 2011 at 04:04:45PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-domain.c | 41 ++ libvirt-gobject/libvirt-gobject-domain.h |6 No addition to the .sym file? 2

Re: [libvirt] [libvirt-glib] Add annotations for gvir_stream_add_watch{_full}

2011-12-15 Thread Christophe Fergeau
Ping? On Fri, Dec 09, 2011 at 02:21:04PM +0100, Christophe Fergeau wrote: This should silence this compile warning: GENLibvirtGObject-1.0.gir libvirt-gobject-stream.c:603: Warning: LibvirtGObject: gvir_stream_add_watch: argument func: Missing (scope) annotation for callback without

Re: [libvirt] [libvirt-glib] Add annotations for gvir_stream_add_watch{_full}

2011-12-15 Thread Daniel P. Berrange
On Fri, Dec 09, 2011 at 02:21:04PM +0100, Christophe Fergeau wrote: This should silence this compile warning: GENLibvirtGObject-1.0.gir libvirt-gobject-stream.c:603: Warning: LibvirtGObject: gvir_stream_add_watch: argument func: Missing (scope) annotation for callback without

Re: [libvirt] [PATCH libvirt-glib 2/2] Add binding for virDomainOpenGraphics

2011-12-15 Thread Daniel P. Berrange
On Thu, Dec 15, 2011 at 05:59:31PM +0100, Christophe Fergeau wrote: On Mon, Dec 12, 2011 at 04:04:45PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-domain.c | 41 ++

[libvirt] [PATCH] qemu: Don't drop hostdev config until security label restore

2011-12-15 Thread Michal Privoznik
Currently, on device detach, we parse given XML, find the device in domain object, free it and try to restore security labels. However, in some cases (e.g. usb hostdev) parsed XML contains less information than freed device. In usb case it is bus device IDs. These are needed during label

Re: [libvirt] Need source for sanlock and libvirt-lock-sanlock

2011-12-15 Thread Eric Blake
On 12/15/2011 06:01 AM, Upendra Moturi wrote: Hello Can some please point me the location of sanlock and libvirt-lock-sanlock source. And also install them from source. sanlock comes from: https://www.fedorahosted.org/sanlock/ libvirt-lock-sanlock is a subpackage of the libvirt project;

[libvirt] [PATCH] Fix default migration speed in qemu driver

2011-12-15 Thread Jim Fehlig
In commit 6f84e110 I mistakenly set default migration speed to 33554432 Mb! The units of migMaxBandwidth is Mb, with conversion handled in qemuMonitor{JSON,Text}SetMigrationSpeed(). Also, remove definition of QEMU_DOMAIN_FILE_MIG_BANDWIDTH_MAX since it is no longer used after reverting commit

Re: [libvirt] [PATCHv2] build: let autobuild check more code

2011-12-15 Thread Eric Blake
On 12/15/2011 01:49 AM, Daniel P. Berrange wrote: On Wed, Dec 14, 2011 at 11:02:23AM -0700, Eric Blake wrote: Many times, we don't notice a bug in src/libvirt_private.syms until someone attempts a build with modules enabled. Likewise, some gcc warnings about no % in a printf format string

Re: [libvirt] [PATCH v4] virsh: Add option to undefine storage with domains

2011-12-15 Thread Eric Blake
On 12/15/2011 08:20 AM, Peter Krempa wrote: Add an option for virsh undefine command, to remove associated storage volumes while undefining a domain. This patch allows the user to remove associated (libvirt managed ) storage volumes while undefining a domain. The new option --storage for the

Re: [libvirt] [PATCH] Fix default migration speed in qemu driver

2011-12-15 Thread Eric Blake
On 12/15/2011 11:36 AM, Jim Fehlig wrote: In commit 6f84e110 I mistakenly set default migration speed to 33554432 Mb! The units of migMaxBandwidth is Mb, with conversion handled in qemuMonitor{JSON,Text}SetMigrationSpeed(). Oh my - sorry I missed that when acking the original series.

Re: [libvirt] [PATCH] Fix default migration speed in qemu driver

2011-12-15 Thread Jim Fehlig
Eric Blake wrote: On 12/15/2011 11:36 AM, Jim Fehlig wrote: In commit 6f84e110 I mistakenly set default migration speed to 33554432 Mb! The units of migMaxBandwidth is Mb, with conversion handled in qemuMonitor{JSON,Text}SetMigrationSpeed(). Oh my - sorry I missed that when acking

Re: [libvirt] PATCH: Inform QEMU prepare hook of migration in progress

2011-12-15 Thread Eric Blake
On 12/15/2011 09:49 AM, Adam Tilghman wrote: From: Eric Blake eblake redhat com Subject: Re: [libvirt-users] Wanted: method for qemu hook script to know if called for migration Date: Mon, 25 Jul 2011 14:17:08 -0600 As a feature suggestion, it would be nice if that fourth input variable,

Re: [libvirt] [PATCHv2] build: let autobuild check more code

2011-12-15 Thread Daniel P. Berrange
On Thu, Dec 15, 2011 at 01:00:02PM -0700, Eric Blake wrote: On 12/15/2011 01:49 AM, Daniel P. Berrange wrote: On Wed, Dec 14, 2011 at 11:02:23AM -0700, Eric Blake wrote: Many times, we don't notice a bug in src/libvirt_private.syms until someone attempts a build with modules enabled.

Re: [libvirt] PATCH: Inform QEMU prepare hook of migration in progress

2011-12-15 Thread Daniel P. Berrange
On Thu, Dec 15, 2011 at 01:59:06PM -0700, Eric Blake wrote: On 12/15/2011 09:49 AM, Adam Tilghman wrote: From: Eric Blake eblake redhat com Subject: Re: [libvirt-users] Wanted: method for qemu hook script to know if called for migration Date: Mon, 25 Jul 2011 14:17:08 -0600 As a

Re: [libvirt] PATCH: Inform QEMU prepare hook of migration in progress

2011-12-15 Thread Adam Tilghman
On Thu, Dec 15, 2011 at 11:32:23PM +, Daniel P. Berrange wrote: Rather, we need to thread something through the call chain so that we can tell whether this code was reached from qemu_migrate.c during an actual migration case. That information is in fact already passed into

[libvirt] [PATCH] qemu: detect truncated file as invalid save image

2011-12-15 Thread Eric Blake
If managed save fails at the right point in time, then the save image can end up with 0 bytes in length (no valid header), and our attempts in commit 55d88def to detect and skip invalid save files missed this case. * src/qemu/qemu_driver.c (qemuDomainSaveImageOpen): Also unlink empty file as

Re: [libvirt] [PATCHv2] build: let autobuild check more code

2011-12-15 Thread Eric Blake
On 12/15/2011 04:25 PM, Daniel P. Berrange wrote: On Thu, Dec 15, 2011 at 01:00:02PM -0700, Eric Blake wrote: On 12/15/2011 01:49 AM, Daniel P. Berrange wrote: On Wed, Dec 14, 2011 at 11:02:23AM -0700, Eric Blake wrote: Many times, we don't notice a bug in src/libvirt_private.syms until

[libvirt] possible 0.9.8 regression?

2011-12-15 Thread Jim Fehlig
Hi All, I've noticed a regression in libvirt 0.9.8 on some of my kvm test machines # virsh start opensuse12 error: Failed to start domain opensuse12 error: Cannot open network interface control socket: Permission denied Opening a control socket for setting MAC addr, etc. failed with EACCES. In

Re: [libvirt] [PATCH] qemu: detect truncated file as invalid save image

2011-12-15 Thread Osier Yang
On 2011年12月16日 08:42, Eric Blake wrote: If managed save fails at the right point in time, then the save image can end up with 0 bytes in length (no valid header), and our attempts in commit 55d88def to detect and skip invalid save files missed this case. * src/qemu/qemu_driver.c