Re: [libvirt] [PATCHv3 6/8] Implement virDomain{G, S}etNumaParameters for the qemu driver

2011-12-16 Thread Eric Blake
On 12/15/2011 03:50 AM, Hu Tao wrote: > --- > src/qemu/qemu_driver.c | 334 > > 1 files changed, 334 insertions(+), 0 deletions(-) > > + > +isActive = virDomainObjIsActive(vm); > + > +if (flags == VIR_DOMAIN_AFFECT_CURRENT) { > +

Re: [libvirt] [PATCHv3 3/8] add new API virDomain{G, S}etNumaParameters

2011-12-16 Thread Eric Blake
On 12/15/2011 03:50 AM, Hu Tao wrote: > Set up the types for the numa functions and insert them into the > virDriver structure definition. > --- > include/libvirt/libvirt.h.in | 23 +++ > python/generator.py |2 ++ > src/driver.h | 15 ++

Re: [libvirt] [PATCH] [TCK] nwfilter: Add tests to detect unnecessarily created ebtables chains

2011-12-16 Thread Eric Blake
On 12/16/2011 01:48 PM, Stefan Berger wrote: > This patch adds a couple of test to detect unnecessarily created > ebtables chains in the case where only iptables chains should have been > created. > > Stefan > > --- > scripts/nwfilter/nwfilterxml2fwallout/sctp-ipv6-test.fwall |4 > sc

Re: [libvirt] [PATCH] nwfilter: do not create ebtables chain unnecessarily

2011-12-16 Thread Eric Blake
On 12/16/2011 01:46 PM, Stefan Berger wrote: > If only iptables rules are created then two unnecessary ebtables chains > are also created. This patch fixes this. > The chains had been cleaned up properly when the interface disappeared, > though. > > --- > src/nwfilter/nwfilter_ebiptables_driver.c

[libvirt] [PATCH] [TCK] nwfilter: Add tests to detect unnecessarily created ebtables chains

2011-12-16 Thread Stefan Berger
This patch adds a couple of test to detect unnecessarily created ebtables chains in the case where only iptables chains should have been created. Stefan --- scripts/nwfilter/nwfilterxml2fwallout/sctp-ipv6-test.fwall |4 scripts/nwfilter/nwfilterxml2fwallout/sctp-test.fwall |

[libvirt] [PATCH] nwfilter: do not create ebtables chain unnecessarily

2011-12-16 Thread Stefan Berger
If only iptables rules are created then two unnecessary ebtables chains are also created. This patch fixes this. The chains had been cleaned up properly when the interface disappeared, though. --- src/nwfilter/nwfilter_ebiptables_driver.c | 10 ++ 1 file changed, 6 insertions(+), 4 d

Re: [libvirt] [PATCHv2] build: let autobuild check more code

2011-12-16 Thread Eric Blake
On 12/16/2011 02:08 AM, Daniel P. Berrange wrote: >> @@ -71,23 +76,7 @@ if [ -x /usr/bin/i686-pc-mingw32-gcc ]; then >> --host=i686-pc-mingw32 \ >> --prefix="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw" \ >> --enable-compile-warnings=error \ >> ---without-xen \ >> -

Re: [libvirt] [PATCH 1/4] add a qemu-specific event register API, to passthough the new events come from qemu

2011-12-16 Thread ShaoHe Feng
there are still some questions: In my code the add new libvirt_qemu specific events and the former libvirt events share the same event queue. so in libvirtd, the qemuDomainEventFlush will dispatch these two kinds of event. so should I add new event queue for the new libvirt_qemu specific events, i

Re: [libvirt] [PATCHv3 5/8] Add virDomain{G, S}etNumaParameters support to the remote driver

2011-12-16 Thread Eric Blake
On 12/15/2011 03:50 AM, Hu Tao wrote: > --- > daemon/remote.c | 64 > ++ > src/remote/remote_driver.c | 50 > src/remote/remote_protocol.x | 24 +++- > src/remote_protocol-structs | 16 +++

Re: [libvirt] [PATCHv3 4/8] Implement main entries of virDomain{G, S}etNumaParameters

2011-12-16 Thread Eric Blake
On 12/15/2011 03:50 AM, Hu Tao wrote: > --- > src/libvirt.c | 113 > + > 1 files changed, 113 insertions(+), 0 deletions(-) I've reviewed 1-4, and the first three look fine; however, I'm going to squash 3 and 4 into a single patch (it's ea

[libvirt] for testing the python binding API

2011-12-16 Thread shaohef
From: ShaoHe Feng there will come an "RESUME" events when qemu domains are started. this python test can catch the "RESUME" event Signed-off-by: ShaoHe Feng --- qemu-event-test.py | 57 1 files changed, 57 insertions(+), 0 deletions(-) c

[libvirt] [PATCH 1/4] add a qemu-specific event register API, to passthough the new events come from qemu

2011-12-16 Thread shaohef
From: ShaoHe Feng Basically, this feature can go along with qemu monitor passthrough. That way, if we use new commands in the monitor that generate new events, we want some way to receive those new events too. Signed-off-by: ShaoHe Feng --- include/libvirt/libvirt-qemu.h | 27 include/

[libvirt] [PATCH 2/4] add a qemu-specific event register API supported in remote driver

2011-12-16 Thread shaohef
From: ShaoHe Feng Signed-off-by: ShaoHe Feng --- daemon/libvirtd.h| 10 +++ daemon/remote.c | 172 +- src/remote/qemu_protocol.x | 29 +++- src/remote/remote_driver.c | 162 ++- s

[libvirt] for testing the new qemu specific regiater API

2011-12-16 Thread shaohef
From: ShaoHe Feng this patch is just used to the new register API add two command, register-event and deregister-event in virsh in order to test the new API. there will come an "RESUME" events when qemu domains are started. virish starts a qemu domain and to catch "RESUME" event. virsh# regi

[libvirt] [PATCH 4/4] add a qemu-specific event register python binding API

2011-12-16 Thread shaohef
From: ShaoHe Feng Signed-off-by: ShaoHe Feng --- python/generator.py | 28 + python/libvirt-qemu-override.c | 140 +++ python/libvirt-qemu-override.py | 55 +++ python/libvirt_qemu.py | 105

[libvirt] [PATCH 3/4] add a qemu-specific event register API supported in qemu driver

2011-12-16 Thread shaohef
From: ShaoHe Feng Signed-off-by: ShaoHe Feng --- src/qemu/qemu_driver.c | 42 ++ src/qemu/qemu_monitor.c | 10 ++ src/qemu/qemu_monitor.h |8 src/qemu/qemu_monitor_json.c | 35 +++

[libvirt] for testing the new qemu specific regiater API

2011-12-16 Thread shaohef
From: ShaoHe Feng this patch is just used to the new register API add two command, register-event and deregister-event in virsh in order to test the new API. there will come an "RESUME" events when qemu domains are started. virish starts a qemu domain and to catch "RESUME" event. virsh# regi

[libvirt] for testing the python binding API

2011-12-16 Thread shaohef
From: ShaoHe Feng there will come an "RESUME" events when qemu domains are started. this python test can catch the "RESUME" event Signed-off-by: ShaoHe Feng --- qemu-event-test.py | 57 1 files changed, 57 insertions(+), 0 deletions(-) c

[libvirt] add a qemu-specific event register API supported in remote driver

2011-12-16 Thread shaohef
From: ShaoHe Feng Signed-off-by: ShaoHe Feng --- daemon/libvirtd.h| 10 +++ daemon/remote.c | 172 +- src/remote/qemu_protocol.x | 29 +++- src/remote/remote_driver.c | 162 ++- s

[libvirt] add a qemu-specific event register API, to passthough the new events come from qemu

2011-12-16 Thread shaohef
From: ShaoHe Feng Basically, this feature can go along with qemu monitor passthrough. That way, if we use new commands in the monitor that generate new events, we want some way to receive those new events too. Signed-off-by: ShaoHe Feng --- include/libvirt/libvirt-qemu.h | 27 include/

[libvirt] add a qemu-specific event register python binding API

2011-12-16 Thread shaohef
From: ShaoHe Feng Signed-off-by: ShaoHe Feng --- python/generator.py | 28 + python/libvirt-qemu-override.c | 140 +++ python/libvirt-qemu-override.py | 55 +++ python/libvirt_qemu.py | 105

[libvirt] add a qemu-specific event register API supported in qemu driver

2011-12-16 Thread shaohef
From: ShaoHe Feng Signed-off-by: ShaoHe Feng --- src/qemu/qemu_driver.c | 42 ++ src/qemu/qemu_monitor.c | 10 ++ src/qemu/qemu_monitor.h |8 src/qemu/qemu_monitor_json.c | 35 +++

Re: [libvirt] [PATCHv2] build: let autobuild check more code

2011-12-16 Thread Eric Blake
On 12/16/2011 08:42 AM, Eric Blake wrote: > > I'm pushing this under the build-breaker rule, which gets me to the next > build failure that I'll be patching soon: > > Creating library file: .libs/libvirt.dll.a > Cannot export virDomainEventDispatch: symbol not defined > Cannot export virDomainEve

Re: [libvirt] [PATCH] migration: Add more specific error code/message on migration abort

2011-12-16 Thread Peter Krempa
On 12/16/2011 04:19 PM, Eric Blake wrote: On 12/16/2011 07:14 AM, Peter Krempa wrote: A generic error code was returned, if the user aborted a migration job. This made it hard to distinguish between a user requested abort and an error that might have occured. This patch introduces a new error co

Re: [libvirt] [PATCHv2] build: let autobuild check more code

2011-12-16 Thread Eric Blake
On 12/16/2011 02:08 AM, Daniel P. Berrange wrote: > On Wed, Dec 14, 2011 at 11:02:23AM -0700, Eric Blake wrote: >> Many times, we don't notice a bug in src/libvirt_private.syms >> until someone attempts a build with modules enabled. Likewise, >> some gcc warnings about no % in a printf format stri

Re: [libvirt] [PATCH] qemu: detect truncated file as invalid save image

2011-12-16 Thread Eric Blake
On 12/15/2011 08:37 PM, Osier Yang wrote: > On 2011年12月16日 08:42, Eric Blake wrote: >> If managed save fails at the right point in time, then the save >> image can end up with 0 bytes in length (no valid header), and >> our attempts in commit 55d88def to detect and skip invalid save >> files missed

Re: [libvirt] [PATCH] qemu: Don't drop hostdev config until security label restore

2011-12-16 Thread Michal Privoznik
On 16.12.2011 16:07, Eric Blake wrote: > On 12/15/2011 10:12 AM, Michal Privoznik wrote: >> Currently, on device detach, we parse given XML, find the device >> in domain object, free it and try to restore security labels. >> However, in some cases (e.g. usb hostdev) parsed XML contains >> less info

Re: [libvirt] [PATCH] migration: Add more specific error code/message on migration abort

2011-12-16 Thread Eric Blake
On 12/16/2011 07:14 AM, Peter Krempa wrote: > A generic error code was returned, if the user aborted a migration job. > This made it hard to distinguish between a user requested abort and an > error that might have occured. This patch introduces a new error code, s/occured/occurred/ > which is re

Re: [libvirt] [PATCH] qemu: Don't drop hostdev config until security label restore

2011-12-16 Thread Eric Blake
On 12/15/2011 10:12 AM, Michal Privoznik wrote: > Currently, on device detach, we parse given XML, find the device > in domain object, free it and try to restore security labels. > However, in some cases (e.g. usb hostdev) parsed XML contains > less information than freed device. In usb case it is

[libvirt] [PATCH] migration: Add more specific error code/message on migration abort

2011-12-16 Thread Peter Krempa
A generic error code was returned, if the user aborted a migration job. This made it hard to distinguish between a user requested abort and an error that might have occured. This patch introduces a new error code, which is returned if a migration API call fails. This makes it easier to distinguish

Re: [libvirt] [PATCH v4] virsh: Add option to undefine storage with domains

2011-12-16 Thread Peter Krempa
On 12/15/2011 09:17 PM, Eric Blake wrote: On 12/15/2011 08:20 AM, Peter Krempa wrote: Changes to v3: - fix ton'o'typos (I should install a spell checker.) - add a new variable to hold copy of argument to avoid confusion, typecasting ... - break volume string

Re: [libvirt] [PATCHv2] build: let autobuild check more code

2011-12-16 Thread Daniel P. Berrange
On Wed, Dec 14, 2011 at 11:02:23AM -0700, Eric Blake wrote: > Many times, we don't notice a bug in src/libvirt_private.syms > until someone attempts a build with modules enabled. Likewise, > some gcc warnings about no % in a printf format string only > appear under --disable-nls. And configure.ac