[libvirt] [PATCH] python: plug memory leak on libvirt_virConnectOpenAuth

2011-12-19 Thread ajia
From: Alex Jia a...@redhat.com * Detected by valgrind. Leak introduced in commit 5ab109f. * python/libvirt-override.c: avoid memory leak on libvirt_virConnectOpenAuth. * How to reproduce? % valgrind -v --leak-check=full virt-clone --print-xml Note: it can hit the issue although options are

Re: [libvirt] [PATCHv3 3/8] add new API virDomain{G, S}etNumaParameters

2011-12-19 Thread Hu Tao
On Fri, Dec 16, 2011 at 03:45:36PM -0700, Eric Blake wrote: On 12/15/2011 03:50 AM, Hu Tao wrote: Set up the types for the numa functions and insert them into the virDriver structure definition. --- include/libvirt/libvirt.h.in | 23 +++ python/generator.py

Re: [libvirt] [PATCHv3 4/8] Implement main entries of virDomain{G, S}etNumaParameters

2011-12-19 Thread Hu Tao
On Fri, Dec 16, 2011 at 09:22:37AM -0700, Eric Blake wrote: On 12/15/2011 03:50 AM, Hu Tao wrote: --- src/libvirt.c | 113 + 1 files changed, 113 insertions(+), 0 deletions(-) I've reviewed 1-4, and the first three look fine;

Re: [libvirt] [PATCHv3 5/8] Add virDomain{G, S}etNumaParameters support to the remote driver

2011-12-19 Thread Hu Tao
On Fri, Dec 16, 2011 at 09:32:19AM -0700, Eric Blake wrote: On 12/15/2011 03:50 AM, Hu Tao wrote: --- daemon/remote.c | 64 ++ src/remote/remote_driver.c | 50 src/remote/remote_protocol.x |

Re: [libvirt] [PATCH 1/8] Convert Xen VBox drivers to use virDomainEventState

2011-12-19 Thread Daniel P. Berrange
On Wed, Dec 14, 2011 at 11:17:47AM -0700, Eric Blake wrote: On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The Xen VBox drivers deal with callbacks dispatching of events directly. All the other drivers use a timer to dispatch events

Re: [libvirt] [PATCH] python: plug memory leak on libvirt_virConnectOpenAuth

2011-12-19 Thread Osier Yang
On 2011年12月19日 16:12, a...@redhat.com wrote: From: Alex Jiaa...@redhat.com * Detected by valgrind. Leak introduced in commit 5ab109f. * python/libvirt-override.c: avoid memory leak on libvirt_virConnectOpenAuth. * How to reproduce? % valgrind -v --leak-check=full virt-clone --print-xml

Re: [libvirt] [PATCH v5] Implement DNS SRV record into the bridge driver

2011-12-19 Thread Daniel Veillard
On Wed, Dec 07, 2011 at 11:58:13AM +0100, Michal Novotny wrote: Hi, this is the fifth version of my SRV record for DNSMasq patch rebased for the current codebase to the bridge driver and libvirt XML file to include support for the SRV records in the DNS. The syntax is based on DNSMasq man

[libvirt] [PATCH] virsh: Fix a regression of detaching device

2011-12-19 Thread Osier Yang
Since for node address, the values for attrs domain, bus, slot, function are all converted to heximal when parsing the XML. However commit ea7182c29 tries to examine if the device represented by the XML from user exists in the domain XML earlier before the XML parsing, and thus if the user use

Re: [libvirt] [PATCH 1/8] Convert Xen VBox drivers to use virDomainEventState

2011-12-19 Thread Daniel P. Berrange
On Wed, Dec 14, 2011 at 11:26:57AM -0700, Eric Blake wrote: On 12/14/2011 11:17 AM, Eric Blake wrote: On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The Xen VBox drivers deal with callbacks dispatching of events directly. All the other

Re: [libvirt] [PATCH 4/8] Convert drivers to thread safe APIs for adding callbacks

2011-12-19 Thread Daniel P. Berrange
On Wed, Dec 14, 2011 at 01:15:58PM -0700, Eric Blake wrote: On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com * src/libxl/libxl_driver.c, src/lxc/lxc_driver.c, src/qemu/qemu_driver.c, src/remote/remote_driver.c, src/test/test_driver.c,

Re: [libvirt] [PATCH 7/8] Hide use of timers for domain event dispatch

2011-12-19 Thread Daniel P. Berrange
On Wed, Dec 14, 2011 at 01:56:36PM -0700, Eric Blake wrote: On 12/13/2011 05:38 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently all drivers using domain events need to provide a callback for handling a timer to dispatch events in a clean stack. There

[libvirt] ANNOUNCE: libvirt-glib release 0.0.3

2011-12-19 Thread Daniel P. Berrange
I am pleased to announce that a new release of the libvirt-glib package, version 0.0.3 is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) New in this release: - Flesh out API

Re: [libvirt] [PATCHv2] build: let autobuild check more code

2011-12-19 Thread Daniel P. Berrange
On Fri, Dec 16, 2011 at 11:39:26AM -0700, Eric Blake wrote: On 12/16/2011 02:08 AM, Daniel P. Berrange wrote: @@ -71,23 +76,7 @@ if [ -x /usr/bin/i686-pc-mingw32-gcc ]; then --host=i686-pc-mingw32 \ --prefix=$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw \

[libvirt] [PATCH] Fix typo in storage pool documentation

2011-12-19 Thread Christophe Fergeau
Remove 2 words that shouldn't be here. --- docs/formatstorage.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index f13ca6a..0dcf6df 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in

Re: [libvirt] [PATCH] Fix typo in storage pool documentation

2011-12-19 Thread Eric Blake
On 12/19/2011 07:20 AM, Christophe Fergeau wrote: Remove 2 words that shouldn't be here. --- docs/formatstorage.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index f13ca6a..0dcf6df 100644 ---

Re: [libvirt] [PATCH 0/2] Introduce two new virsh commands

2011-12-19 Thread Dave Allan
On Mon, Dec 19, 2011 at 12:41:08PM +0800, Osier Yang wrote: On 2011年06月30日 00:26, Eric Blake wrote: On 06/29/2011 06:19 AM, Osier Yang wrote: These two patches is to introduce two new virsh commands, one is eject-media, which is to eject media from CD or floppy drive, the other is

Re: [libvirt] [PATCHv3 0/8] add command numatune

2011-12-19 Thread Daniel P. Berrange
On Thu, Dec 15, 2011 at 06:50:14PM +0800, Hu Tao wrote: This series adds a new command numatune to get/set numatune parameters. Besides libnuma, cpuset cgroup parameters are also set according to numatune parameters. But for now, only cpuset.mems is supported. I've not done a detailed

Re: [libvirt] [PATCH] virsh: Fix a regression of detaching device

2011-12-19 Thread Eric Blake
On 12/19/2011 04:01 AM, Osier Yang wrote: Since for node address, the values for attrs domain, bus, slot, function are all converted to heximal when parsing the XML. However commit ea7182c29 tries to examine if the device represented by the XML from user exists in the domain XML earlier before

Re: [libvirt] [PATCH] python: plug memory leak on libvirt_virConnectOpenAuth

2011-12-19 Thread Eric Blake
On 12/19/2011 02:47 AM, Osier Yang wrote: On 2011年12月19日 16:12, a...@redhat.com wrote: From: Alex Jiaa...@redhat.com * Detected by valgrind. Leak introduced in commit 5ab109f. Wow - present since 0.4.1! +++ b/python/libvirt-override.c @@ -1520,6 +1520,7 @@

Re: [libvirt] [PATCH] virsh: Fix a regression of detaching device

2011-12-19 Thread Eric Blake
On 12/19/2011 11:38 AM, Eric Blake wrote: On 12/19/2011 04:01 AM, Osier Yang wrote: Since for node address, the values for attrs domain, bus, slot, function are all converted to heximal when parsing the XML. However commit ea7182c29 tries to examine if the device represented by the XML from

[libvirt] [PATCH] docs: document qemu:commandline xml

2011-12-19 Thread Eric Blake
Even though we technically don't support qemu:commandline (as in, if you mis-use things, you get to keep the pieces), we should at least document how to use it. * docs/drvqemu.html.in (qemucommand): New section. --- I wrote this in response to an IRC comment lamenting that the only existing

Re: [libvirt] [PATCH] docs: document qemu:commandline xml

2011-12-19 Thread Daniel P. Berrange
On Mon, Dec 19, 2011 at 12:12:31PM -0700, Eric Blake wrote: Even though we technically don't support qemu:commandline (as in, if you mis-use things, you get to keep the pieces), we should at least document how to use it. * docs/drvqemu.html.in (qemucommand): New section. --- I wrote this

Re: [libvirt] [PATCH 1/4] add a qemu-specific event register API, to passthough the new events come from qemu

2011-12-19 Thread Adam Litke
Please remember to Cc: the libvirt list as well so that others may contribute to the discussion. On Sat, Dec 17, 2011 at 12:58:58AM +0800, ShaoHe Feng wrote: From: ShaoHe Feng shao...@linux.vnet.ibm.com Basically, this feature can go along with qemu monitor passthrough. That way, if we use

Re: [libvirt] [PATCH] docs: document qemu:commandline xml

2011-12-19 Thread Eric Blake
On 12/19/2011 12:21 PM, Daniel P. Berrange wrote: On Mon, Dec 19, 2011 at 12:12:31PM -0700, Eric Blake wrote: Even though we technically don't support qemu:commandline (as in, if you mis-use things, you get to keep the pieces), we should at least document how to use it. *

Re: [libvirt] [PATCH 1/6] Add address type for SPAPR VIO devices

2011-12-19 Thread Michael Ellerman
On Tue, 2011-12-13 at 10:39 +1100, Michael Ellerman wrote: For QEMU PPC64 we have a machine type (pseries) which has a virtual bus called spapr-vio. We need to be able to create devices on this bus, and as such need a way to specify the address for those devices. This patch adds a new

[libvirt] polkit-auth question

2011-12-19 Thread Jim Fehlig
While debugging a PolicyKit issue I noticed that libvirt would proceed with authentication even though polkit-auth failed: testusr@xen134:~ virsh list --all Attempting to obtain authorization for org.libvirt.unix.manage. polkit-grant-helper: given auth type (8 - yes) is bogus Failed to obtain

[libvirt] [PATCH] virsh: simply printing of typed parameters

2011-12-19 Thread Eric Blake
No need to repeat code for formatting typed parameters. * tools/virsh.c (vshGetTypedParamValue): Support strings. (cmdSchedinfo, cmdBlkiotune, cmdMemtune, cmdBlkdeviotune): Use it for less code. --- tools/virsh.c | 134 + 1 files changed,

Re: [libvirt] [PATCHv3 7/8] add new command numatune to virsh

2011-12-19 Thread Eric Blake
On 12/15/2011 03:50 AM, Hu Tao wrote: add new command numatune to virsh to get/set numa parameters --- tools/virsh.c | 181 + 1 files changed, 181 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index

Re: [libvirt] [PATCHv3 8/8] Add document for new command numatune.

2011-12-19 Thread Eric Blake
On 12/15/2011 03:50 AM, Hu Tao wrote: --- tools/virsh.pod | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) This should be squashed in with 7/8. diff --git a/tools/virsh.pod b/tools/virsh.pod index c468f13..91baf4d 100644 --- a/tools/virsh.pod +++

Re: [libvirt] [PATCH] virsh: simply printing of typed parameters

2011-12-19 Thread Peter Krempa
Dňa 20.12.2011 0:08, Eric Blake wrote / napísal(a): No need to repeat code for formatting typed parameters. * tools/virsh.c (vshGetTypedParamValue): Support strings. (cmdSchedinfo, cmdBlkiotune, cmdMemtune, cmdBlkdeviotune): Use it for less code. --- tools/virsh.c | 134

Re: [libvirt] [PATCH] virsh: simply printing of typed parameters

2011-12-19 Thread Eric Blake
On 12/19/2011 04:57 PM, Peter Krempa wrote: Dňa 20.12.2011 0:08, Eric Blake wrote / napísal(a): No need to repeat code for formatting typed parameters. * tools/virsh.c (vshGetTypedParamValue): Support strings. (cmdSchedinfo, cmdBlkiotune, cmdMemtune, cmdBlkdeviotune): Use it for less code.

Re: [libvirt] [PATCHv3 0/8] add command numatune

2011-12-19 Thread Eric Blake
On 12/19/2011 10:16 AM, Daniel P. Berrange wrote: On Thu, Dec 15, 2011 at 06:50:14PM +0800, Hu Tao wrote: This series adds a new command numatune to get/set numatune parameters. Besides libnuma, cpuset cgroup parameters are also set according to numatune parameters. But for now, only

[libvirt] [PATCHv4 0/6] add numatune command

2011-12-19 Thread Eric Blake
Not quite polished - see my complaints that will require a v5: https://www.redhat.com/archives/libvir-list/2011-December/msg00843.html I'm hoping Hu can help cover the remaining points, as I've already spent quite a bit of time cleaning it up to here. Hu Tao (6): Add functions to set/get

[libvirt] [PATCHv4 1/6] Add functions to set/get cgroup cpuset parameters

2011-12-19 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com --- src/libvirt_private.syms |2 ++ src/util/cgroup.c| 32 src/util/cgroup.h|3 +++ 3 files changed, 37 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms

[libvirt] [PATCHv4 2/6] use cpuset to manage numa

2011-12-19 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com This patch also sets cgroup cpuset parameters for numatune. --- src/qemu/qemu_cgroup.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index d663798..2d970d6 100644 ---

[libvirt] [PATCHv4 5/6] Implement virDomain{G, S}etNumaParameters for the qemu driver

2011-12-19 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com --- src/qemu/qemu_driver.c | 262 1 files changed, 262 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 660d771..3f8167f 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCHv4 4/6] Add virDomain{G, S}etNumaParameters support to the remote driver

2011-12-19 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com --- daemon/remote.c | 64 ++ src/remote/remote_driver.c | 50 src/remote/remote_protocol.x | 24 +++- src/remote_protocol-structs | 22 ++ 4

[libvirt] [PATCHv4 3/6] add new API virDomain{G, S}etNumaParameters

2011-12-19 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com Set up the types for the numa functions and insert them into the virDriver structure definition. --- include/libvirt/libvirt.h.in | 39 + python/generator.py |2 + src/conf/domain_conf.h |8 --- src/driver.h |

[libvirt] [PATCHv4 6/6] add new command numatune to virsh

2011-12-19 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com add new command numatune to virsh to get/set numa parameters --- tools/virsh.c | 159 +++ tools/virsh.pod | 19 +++ 2 files changed, 178 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c

[libvirt] [PATCH] qemu: Add a capability flag for -no-acpi

2011-12-19 Thread Michael Ellerman
Currently non-x86 guests must have acpi/ defined in features to prevent libvirt from running qemu with -no-acpi. Although it works, it is a hack. Instead add a capability flag which indicates whether qemu understands the -no-acpi option. Use it to control whether libvirt emits -no-acpi. Current

Re: [libvirt] [PATCHv4 4/6] Add virDomain{G, S}etNumaParameters support to the remote driver

2011-12-19 Thread Eric Blake
On 12/19/2011 05:42 PM, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com --- daemon/remote.c | 64 ++ src/remote/remote_driver.c | 50 src/remote/remote_protocol.x | 24 +++-

Re: [libvirt] [PATCH] virsh: Fix a regression of detaching device

2011-12-19 Thread Osier Yang
On 2011年12月20日 02:51, Eric Blake wrote: On 12/19/2011 11:38 AM, Eric Blake wrote: On 12/19/2011 04:01 AM, Osier Yang wrote: Since for nodeaddress, the values for attrs domain, bus, slot, function are all converted to heximal when parsing the XML. However commit ea7182c29 tries to examine if

Re: [libvirt] [PATCHv4 4/6] Add virDomain{G, S}etNumaParameters support to the remote driver

2011-12-19 Thread Eric Blake
On 12/19/2011 08:13 PM, Eric Blake wrote: On 12/19/2011 05:42 PM, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com --- daemon/remote.c | 64 ++ src/remote/remote_driver.c | 50

Re: [libvirt] [PATCHv4 4/6] Add virDomain{G, S}etNumaParameters support to the remote driver

2011-12-19 Thread Hu Tao
Hi Eric, Will you look at the code in xdr_remote_typed_param_value() in file sre/remote/remote_protocol.c that processes VIR_TYPED_PARAM_INT? It looks odd and I'm sure it's the cause of the bug you mentioned. switch (objp-type) { case VIR_TYPED_PARAM_INT:

Re: [libvirt] [PATCHv4 5/6] Implement virDomain{G, S}etNumaParameters for the qemu driver

2011-12-19 Thread Hu Tao
On Mon, Dec 19, 2011 at 05:42:02PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com --- src/qemu/qemu_driver.c | 262 1 files changed, 262 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 0/4] RFC: grant KVM guests retain arbitrary capabilities

2011-12-19 Thread Taku Izumi
Hi all, This patchset adds an option for KVM guests to retain arbitrary capabilities. I want KVM guests to retain cap_sys_rawio capability, so I tried to run qemu as root user. However because libvirt clears all capability of KVM guest by default, even if guest is running as root user, it