Re: [libvirt] [PATCH 6/6] qemu: Add support for host CPU modes

2012-01-07 Thread Eric Blake
On 01/06/2012 08:04 AM, Jiri Denemark wrote: > --- Also a bit light on the commit message. > src/libvirt_private.syms |1 + > src/qemu/qemu_capabilities.c |5 + > src/qemu/qemu_capabilities.h |1 + > src/qemu/qemu_

Re: [libvirt] [PATCH 5/6] Taint domains configured with cpu mode=host-passthrough

2012-01-07 Thread Eric Blake
On 01/06/2012 08:04 AM, Jiri Denemark wrote: > --- > src/conf/domain_conf.c |3 ++- > src/conf/domain_conf.h |1 + > src/qemu/qemu_domain.c |3 +++ > 3 files changed, 6 insertions(+), 1 deletions(-) Aargh - 'git grep taint docs/*.in' turned up nothing, so we don't have any documentati

Re: [libvirt] [PATCH 4/6] cpu: Update guest CPU in host-* mode

2012-01-07 Thread Eric Blake
On 01/06/2012 08:04 AM, Jiri Denemark wrote: > --- A little light on the commit message, perhaps. > src/conf/cpu_conf.c| 75 > +++- > src/conf/cpu_conf.h|8 ++ > src/cpu/cpu_x86.c

Re: [libvirt] [PATCH 3/6] Add support for cpu mode attribute

2012-01-07 Thread Eric Blake
On 01/06/2012 08:04 AM, Jiri Denemark wrote: > The mode can be either of "custom" (default), "host-model", > "host-passthrough". The semantics of each mode is described in the > following examples: nice examples > --- > Oh man, I just realized I forgot to update documentation. I'll transform thi

Re: [libvirt] [PATCH 2/6] cpu: Optionally forbid fallback CPU models

2012-01-07 Thread Eric Blake
On 01/06/2012 08:04 AM, Jiri Denemark wrote: > In case a hypervisor doesn't support the exact CPU model requested by a > domain XML, we automatically fallback to a closest CPU model the > hypervisor supports (and make sure we add/remove any additional features > if needed). This patch adds 'fallbac

Re: [libvirt] [PATCH 1/6] tests: Print XML file name in verbose CPU test

2012-01-07 Thread Eric Blake
On 01/06/2012 08:04 AM, Jiri Denemark wrote: > It's not totally obvious that a failure in > CPU guest data(x86): host/guest (models, pref="qemu64") > test means one needs to fix > x86-host+guest,models,qemu64-result.xml > where the expected XML is stored. Better to provide a nice hint in >

Re: [libvirt] [PATCH] config: report error when script given for inappropriate interface type

2012-01-07 Thread Eric Blake
On 01/06/2012 11:16 AM, Laine Stump wrote: > This fixes https://bugzilla.redhat.com/show_bug.cgi?id=638633 > > > Currently the qemu, xen, libxml, and uml drivers recognize the script > parameter and do something with it (the uml driver only to report that > it isn't supported). Those drivers hav

[libvirt] [PATCHv2 2/3] util: add new file for virTypedParameter utils

2012-01-07 Thread Eric Blake
Preparation for another patch that refactors common patterns into the new file for fewer lines of code overall. * src/util/util.h (virTypedParameterArrayClear): Move... * src/util/virtypedparam.h: ...to new file. (virTypedParameterArrayValidate, virTypedParameterAssign): New prototypes. * src/util

[libvirt] [PATCHv2 0/3] helper functions for virTypedParameters

2012-01-07 Thread Eric Blake
v1 was: https://www.redhat.com/archives/libvir-list/2012-January/msg00102.html New in v2: more cleanups to lxc, and rebase to post-release tree Eric Blake (3): lxc: use live/config helper util: add new file for virTypedParameter utils util: use new virTypedParameter helpers daemon/remote.

[libvirt] [PATCHv2 1/3] lxc: use live/config helper

2012-01-07 Thread Eric Blake
Based on qemu changes made in commits ae523427 and 659ded58. * src/lxc/lxc_driver.c (lxcSetSchedulerParametersFlags) (lxcGetSchedulerParametersFlags, lxcDomainSetBlkioParameters) (lxcDomainGetBlkioParameters): Use helpers. (lxcDomainSetBlkioParameters): Allow setting live and config at once. ---

Re: [libvirt] [PATCH] qemu: one more client to live/config helper

2012-01-07 Thread Eric Blake
On 01/03/2012 03:05 AM, Michal Privoznik wrote: > On 03.01.2012 00:37, Eric Blake wrote: >> Commit ae523427 missed one pair of functions that could use >> the helper routine. >> >> * src/qemu/qemu_driver.c (qemuSetSchedulerParametersFlags) >> (qemuGetSchedulerParametersFlags): Simplify. >> --- >>