[libvirt] [PATCH v2][TCK] add test for get and define save image xml

2012-01-11 Thread Xiaoqiang Hu
v2: change save image path from working dir to libvirt-tck cache dir v1: add test for get and define save image xml and there are types of save image file covered in the test: persistent, transient and invalid domain save image --- scripts/qemu/400-save-image-xml.t | 107

Re: [libvirt] [PATCH][TCK] add test for get and define save image xml

2012-01-11 Thread xhu
On 01/11/2012 01:13 AM, Daniel P. Berrange wrote: On Mon, Jan 09, 2012 at 03:43:47PM +0800, Xiaoqiang Hu wrote: add test for get and define save image xml and there are types of save image file covered in the test: persistent, transient and invalid domain save image ---

[libvirt] [PATCH] virsh: improve doMigrate function docs

2012-01-11 Thread ajia
From: Alex Jia a...@redhat.com When running virsh migrate with --xml option and actual xml file doesn't exist, virsh hasn't output any error information, although return value is 1. * tools/virsh.c: Raising a appropriate error information when operation fails. * How to reproduce? % virsh

Re: [libvirt] [PATCH v2][TCK] add test for get and define save image xml

2012-01-11 Thread Daniel P. Berrange
On Wed, Jan 11, 2012 at 04:04:02PM +0800, Xiaoqiang Hu wrote: v2: change save image path from working dir to libvirt-tck cache dir v1: add test for get and define save image xml and there are types of save image file covered in the test: persistent, transient and invalid domain save

Re: [libvirt] [PATCH 5/6] Taint domains configured with cpu mode=host-passthrough

2012-01-11 Thread Jiri Denemark
On Sat, Jan 07, 2012 at 07:21:02 -0700, Eric Blake wrote: On 01/06/2012 08:04 AM, Jiri Denemark wrote: --- src/conf/domain_conf.c |3 ++- src/conf/domain_conf.h |1 + src/qemu/qemu_domain.c |3 +++ 3 files changed, 6 insertions(+), 1 deletions(-) Aargh - 'git grep taint

Re: [libvirt] [PATCH 5/6] Taint domains configured with cpu mode=host-passthrough

2012-01-11 Thread Daniel P. Berrange
On Wed, Jan 11, 2012 at 10:42:39AM +0100, Jiri Denemark wrote: On Sat, Jan 07, 2012 at 07:21:02 -0700, Eric Blake wrote: On 01/06/2012 08:04 AM, Jiri Denemark wrote: --- src/conf/domain_conf.c |3 ++- src/conf/domain_conf.h |1 + src/qemu/qemu_domain.c |3 +++ 3

Re: [libvirt] [PATCH] Change security driver APIs to use virDomainDefPtr instead of virDomainObjPtr

2012-01-11 Thread Daniel P. Berrange
On Mon, Nov 28, 2011 at 12:31:12PM -0500, Stefan Berger wrote: On 11/28/2011 12:11 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com When sVirt is integrated with the LXC driver, it will be neccessary to invoke the security driver APIs using only a virDomainDefPtr

[libvirt] [BUG, PATCH-RFC] libvirt localtime and rtc_timeoffset handling in xen-sexpr/sxpr/sxp

2012-01-11 Thread Philipp Hahn
Hello, I'm currently tracking a problem in libvirt regarding Xens handling of localtime and rtc_timeoffset. My current understanding (Xen-3.4.3 and Xen-4.1.2 under Linux) of Xend (the depcrecated Python one still used by libvirt) is as this: - for HV domains, the RTC gets setup to either UTC

Re: [libvirt] [PATCH] virsh: improve doMigrate function docs

2012-01-11 Thread Michal Privoznik
On 11.01.2012 09:23, a...@redhat.com wrote: From: Alex Jia a...@redhat.com When running virsh migrate with --xml option and actual xml file doesn't exist, virsh hasn't output any error information, although return value is 1. * tools/virsh.c: Raising a appropriate error information when

[libvirt] [PATCH] Revert virsh: Increase device-detach intelligence

2012-01-11 Thread Osier Yang
This reverts commit ea7182c29f185e7c1527b10fbe16dc4ba1f45a88. Conflicts are resolved. This is a temporary reverting for it introduces regression of device detaching (any device XML doesn't uses the same order as libvirt generates, or has uses decimal for some attrs (e.g. slot) will cause the

Re: [libvirt] [PATCH v2 0/6] nwfilter: Enable access to variables via iterator or index

2012-01-11 Thread Stefan Berger
On 01/10/2012 05:51 PM, Eric Blake wrote: On 01/10/2012 02:04 PM, Stefan Berger wrote: This patch enables access to variables in filters using indep. iterators ($TEST[$@2]) or via index ($TEST[1]). Three test cases are added that are also being used for libvirt-TCK to check that the

Re: [libvirt] [Xen-devel] [BUG, PATCH-RFC] libvirt localtime and rtc_timeoffset handling in xen-sexpr/sxpr/sxp

2012-01-11 Thread Ian Campbell
On Wed, 2012-01-11 at 10:20 +, Philipp Hahn wrote: Hello, I'm currently tracking a problem in libvirt regarding Xens handling of localtime and rtc_timeoffset. My current understanding (Xen-3.4.3 and Xen-4.1.2 under Linux) of Xend (the depcrecated Python one still used by libvirt) is

[libvirt] [PATCH] virsh: New command print summary of all virtual interfaces

2012-01-11 Thread Osier Yang
Just like command domblklist, the command extracts type, source, target, model, and MAC of all virtual interfaces from domain XML (live or persistent). --- tools/virsh.c | 98 +++ tools/virsh.pod |9 + 2 files changed, 107

[libvirt] [PATCH 1/3][TCK] nwfilter: test access to 2 lists in one rule

2012-01-11 Thread Stefan Berger
Test access to 2 lists in one rule --- scripts/nwfilter/nwfilter2vmtest.sh|6 +++ scripts/nwfilter/nwfilterxml2fwallout/iter-test1.fwall | 31 + scripts/nwfilter/nwfilterxml2xmlin/iter-test1.xml |6 +++ 3 files changed, 43 insertions(+) Index:

[libvirt] [PATCH 3/3][TCK] nwfilter: test access via index and iterators

2012-01-11 Thread Stefan Berger
Test access to variables using index and iterators --- scripts/nwfilter/nwfilterxml2fwallout/iter-test3.fwall | 37 + scripts/nwfilter/nwfilterxml2xmlin/iter-test3.xml | 13 + 2 files changed, 50 insertions(+) Index:

[libvirt] ALERT Virtualization Automatic Builder

2012-01-11 Thread berrange
Overall status: failed Start date: Wed Jan 11 2012 Start time: 11:29:22 UTC / 06:29:22 EST Build counter: 1326281362 Build timestamp: 1326281362 URL: http://builder.virt-tools.org/index.html Module: libvirt Status: failed URL: http://builder.virt-tools.org/module-libvirt.html -- libvir-list

[libvirt] [PATCH 2/3][TCK] nwfilter: test access via iterators

2012-01-11 Thread Stefan Berger
Test access to variables using different iterators. --- scripts/nwfilter/nwfilter2vmtest.sh|6 scripts/nwfilter/nwfilterxml2fwallout/iter-test2.fwall | 193 + scripts/nwfilter/nwfilterxml2xmlin/iter-test2.xml | 23 ++ 3 files changed, 222

Re: [libvirt] [Xen-devel] [BUG, PATCH-RFC] libvirt localtime and rtc_timeoffset handling in xen-sexpr/sxpr/sxp

2012-01-11 Thread Philipp Hahn
Hello Ian, Am Mittwoch 11 Januar 2012 12:54:04 schrieb Ian Campbell: On Wed, 2012-01-11 at 10:20 +, Philipp Hahn wrote: I'm currently tracking a problem in libvirt regarding Xens handling of localtime and rtc_timeoffset. My current understanding (Xen-3.4.3 and Xen-4.1.2 under Linux) of

[libvirt] [PATCH] virsh: Two new fields for command domblklist

2012-01-11 Thread Osier Yang
Disk type and device are generally interesting stuffs the user who wants to known too. Though it's likely breaks the script which parses the command output by field (e.g. awk), putting them in the head is better, as it coheres with the user's habit more. (Trying to find the small word (type,

[libvirt] [PATCH] docs: Add missed RNG schema for interface

2012-01-11 Thread Osier Yang
We support interface of type mcast, server, and client, but the RNG schema for them are missed. --- docs/schemas/domaincommon.rng | 44 + 1 files changed, 44 insertions(+), 0 deletions(-) diff --git a/docs/schemas/domaincommon.rng

[libvirt] [PATCH] build: avoid spurious compiler warning

2012-01-11 Thread Eric Blake
For some weird reason, i686-pc-mingw32-gcc version 4.6.1 at -O2 complained: ../../src/conf/nwfilter_params.c: In function 'virNWFilterVarCombIterCreate': ../../src/conf/nwfilter_params.c:346:23: error: 'minValue' may be used uninitialized in this function [-Werror=uninitialized]

Re: [libvirt] [PATCH] stream: Check for stream EOF

2012-01-11 Thread Daniel P. Berrange
On Tue, Jan 10, 2012 at 05:28:50PM +0100, Michal Privoznik wrote: If client stream does not have any data to sink and neither received EOF, a dummy packet is sent to the daemon signalising client is ready to sink some data. However, after we added event loop to client a race may occur:

[libvirt] [PATCH] build: fix build on mingw with netcf available

2012-01-11 Thread Eric Blake
The autobuilder pointed out an odd failure on mingw: ../../src/interface/netcf_driver.c:644:5: error: unknown field 'close_used_without_including_unistd_h' specified in initializer cc1: warnings being treated as errors This is because the gnulib headers #define close in order to work around some

[libvirt] [PATCH] Disable netcf if building without libvirtd

2012-01-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Although the netcf interface driver can in theory be used by the stateless drivers, in practice none of them want to use it because they have different ways of dealing with interfaces. Furthermore, if you have mingw32-netcf installed, then the libvirt

Re: [libvirt] ALERT Virtualization Automatic Builder

2012-01-11 Thread Daniel P. Berrange
On Tue, Jan 10, 2012 at 11:48:19AM -0700, Eric Blake wrote: On 01/10/2012 11:27 AM, berra...@redhat.com wrote: Overall status: failed Start date: Tue Jan 10 2012 Start time: 18:05:04 UTC / 13:05:04 EST Build counter: 1326218704 Build timestamp: 1326218704 URL:

Re: [libvirt] [PATCH libvirt-glib] Add support for configuring serial, parallel channel devices

2012-01-11 Thread Christophe Fergeau
On Tue, Jan 10, 2012 at 04:34:39PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The basic config of serial, parallel channel devices is just the same as console devices. Add basic stubs for these new devices --- libvirt-gconfig/Makefile.am

Re: [libvirt] [PATCH] build: fix build on mingw with netcf available

2012-01-11 Thread Daniel P. Berrange
On Wed, Jan 11, 2012 at 07:09:37AM -0700, Eric Blake wrote: The autobuilder pointed out an odd failure on mingw: ../../src/interface/netcf_driver.c:644:5: error: unknown field 'close_used_without_including_unistd_h' specified in initializer cc1: warnings being treated as errors This is

Re: [libvirt] [PATCH libvirt-glib] Add support for shutdown event to avoid console warnings

2012-01-11 Thread Christophe Fergeau
On Tue, Jan 10, 2012 at 04:34:56PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-connection.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c

Re: [libvirt] [PATCH] Disable netcf if building without libvirtd

2012-01-11 Thread Eric Blake
On 01/11/2012 07:11 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Although the netcf interface driver can in theory be used by the stateless drivers, in practice none of them want to use it because they have different ways of dealing with interfaces.

Re: [libvirt] [PATCH] build: fix build on mingw with netcf available

2012-01-11 Thread Eric Blake
On 01/11/2012 07:16 AM, Daniel P. Berrange wrote: On Wed, Jan 11, 2012 at 07:09:37AM -0700, Eric Blake wrote: The autobuilder pointed out an odd failure on mingw: ../../src/interface/netcf_driver.c:644:5: error: unknown field 'close_used_without_including_unistd_h' specified in initializer

[libvirt] [PATCH 1/1] Added check for maximum number of vcpus exceeding topology limit

2012-01-11 Thread Martin Kletzander
Earlier, when the number of vcpus was greater than the topology allowed, libvirt didn't raise an error and continued, resulting in running qemu with parameters making no sense. Even though qemu did not report any error itself, the number of vcpus was set to maximum allowed by the topology. ---

[libvirt] [PATCH 2/7] Don't bind mount onto a char device for /dev/ptmx in LXC

2012-01-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The current setup code for LXC is bind mounting /dev/pts/ptmx ontop of a character device /dev/ptmx. This is denied by SELinux policy and is just wrong. The target of a bind mount should just be a plain file * src/lxc/lxc_container.c: Don't bind

[libvirt] [PATCH 4/7] Re-add domain device seclabel parsing / formatting

2012-01-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com This re-introduces parsing formatting for per device seclabels. There is a new virDomainDeviceSeclabelPtr struct and corresponding APIs for parsing/formatting. --- src/conf/domain_conf.c | 115 ++--

[libvirt] [PATCH 5/7] Add two new security label types

2012-01-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Curently security labels can be of type 'dynamic' or 'static'. If no security label is given, then 'dynamic' is assumed. The current code takes advantage of this default, and avoids even saving seclabel elements with type='dynamic' to disk. This means

[libvirt] [PATCH 1/7] Add virFileTouch for creating empty files

2012-01-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a virFileTouch API which ensures that a file will always exist, even if zero length * src/lxc/lxc_container.c, src/util/virfile.h: virFileTouch --- src/util/virfile.c | 21 + src/util/virfile.h |2 ++ 2 files changed, 23

[libvirt] [PATCH 3/7] Revert changes to sec label parsing

2012-01-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Revert parsing changes: commit 302fe95ffa1bc5f1c61c0beb31a1adfbc38c668e Author: Eric Blake ebl...@redhat.com Date: Wed Jan 4 16:01:24 2012 -0700 seclabel: fix regression in libvirtd restart commit

[libvirt] [PATCH 7/7] Set a security context on /dev and /dev/pts mounts

2012-01-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com To allow the container to access /dev and /dev/pts when under sVirt, set an explicit mount option. Also set a max size on the /dev mount to prevent DOS on memory usage * src/lxc/lxc_container.c: Set /dev mount context * src/lxc/lxc_controller.c: Set

Re: [libvirt] [PATCH 1/1] Added check for maximum number of vcpus exceeding topology limit

2012-01-11 Thread Eric Blake
On 01/11/2012 09:10 AM, Martin Kletzander wrote: Earlier, when the number of vcpus was greater than the topology allowed, libvirt didn't raise an error and continued, resulting in running qemu with parameters making no sense. Even though qemu did not report any error itself, the number of

[libvirt] [PATCH 6/7] Add support for sVirt in the LXC driver

2012-01-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com For the sake of backwards compat, LXC guests are *not* confined by default. This is because it is not practical to dynamically relabel containers using large filesystem trees. Applications can create confined containers though, by giving suitable XML

[libvirt] [PATCH 0/7] Introduce sVirt to LXC driver

2012-01-11 Thread Daniel P. Berrange
This patch series adds support for sVirt to the LXC driver. In this series, all LXC guests continue to run unconfined by default. The app has to explicitly request sVirt confinement for the guest. This is to ensure backwards compatibility with existing deployments. Since we won't auto-relabel

Re: [libvirt] [PATCH v2][TCK] add test for get and define save image xml

2012-01-11 Thread Eric Blake
On 01/11/2012 01:58 AM, Daniel P. Berrange wrote: On Wed, Jan 11, 2012 at 04:04:02PM +0800, Xiaoqiang Hu wrote: v2: change save image path from working dir to libvirt-tck cache dir v1: add test for get and define save image xml and there are types of save image file covered in the test:

Re: [libvirt] [PATCH 3/3][TCK] nwfilter: test access via index and iterators

2012-01-11 Thread Eric Blake
On 01/11/2012 05:19 AM, Stefan Berger wrote: Test access to variables using index and iterators --- scripts/nwfilter/nwfilterxml2fwallout/iter-test3.fwall | 37 + scripts/nwfilter/nwfilterxml2xmlin/iter-test3.xml | 13 + 2 files changed, 50 insertions(+) ACK

Re: [libvirt] [PATCH] virsh: Two new fields for command domblklist

2012-01-11 Thread Eric Blake
On 01/11/2012 06:13 AM, Osier Yang wrote: Disk type and device are generally interesting stuffs the user who wants to known too. Though it's likely breaks the script which parses the command output by field (e.g. awk), putting them in the head is better, as it coheres with the user's habit

Re: [libvirt] [PATCH] virsh: New command print summary of all virtual interfaces

2012-01-11 Thread Eric Blake
On 01/11/2012 05:45 AM, Osier Yang wrote: Just like command domblklist, the command extracts type, source, target, model, and MAC of all virtual interfaces from domain XML (live or persistent). --- tools/virsh.c | 98 +++

Re: [libvirt] [PATCH] docs: Add missed RNG schema for interface

2012-01-11 Thread Laine Stump
On 01/11/2012 08:39 AM, Osier Yang wrote: We supportinterface of type mcast, server, and client, but the RNG schema for them are missed. Right you are! ACK. (A test case with one of each in the xml2argv test would be nice, though - that would have prevented this omission. anticipatory ACK

Re: [libvirt] [PATCH] Revert virsh: Increase device-detach intelligence

2012-01-11 Thread Eric Blake
On 01/11/2012 04:47 AM, Osier Yang wrote: This reverts commit ea7182c29f185e7c1527b10fbe16dc4ba1f45a88. Conflicts are resolved. This is a temporary reverting for it introduces regression of device detaching (any device XML doesn't uses the same order as libvirt generates, or has uses

Re: [libvirt] [PATCH] docs: Add missed RNG schema for interface

2012-01-11 Thread Eric Blake
On 01/11/2012 10:25 AM, Laine Stump wrote: On 01/11/2012 08:39 AM, Osier Yang wrote: We supportinterface of type mcast, server, and client, but the RNG schema for them are missed. Right you are! ACK. (A test case with one of each in the xml2argv test would be nice, though - that would have

Re: [libvirt] [PATCH 3/5 v3] Adding the element pf to network xml.

2012-01-11 Thread Eric Blake
On 01/10/2012 05:41 PM, Eric Blake wrote: /* all of these modes can use a pool of physical interfaces */ nForwardIfs = virXPathNodeSet(./interface, ctxt, forwardIfNodes); -if (nForwardIfs 0) +if (nForwardIfs = 0) { +

Re: [libvirt] [PATCH 3/3][TCK] nwfilter: test access via index and iterators

2012-01-11 Thread Stefan Berger
On 01/11/2012 12:17 PM, Eric Blake wrote: On 01/11/2012 05:19 AM, Stefan Berger wrote: Test access to variables using index and iterators --- scripts/nwfilter/nwfilterxml2fwallout/iter-test3.fwall | 37 + scripts/nwfilter/nwfilterxml2xmlin/iter-test3.xml | 13 +

Re: [libvirt] [PATCH 3/5 v3] Adding the element pf to network xml.

2012-01-11 Thread Eric Blake
On 01/11/2012 11:08 AM, Eric Blake wrote: On 01/10/2012 05:41 PM, Eric Blake wrote: /* all of these modes can use a pool of physical interfaces */ nForwardIfs = virXPathNodeSet(./interface, ctxt, forwardIfNodes); -if (nForwardIfs 0) +if (nForwardIfs = 0) {

Re: [libvirt] [PATCH 5/5 v3] Added new option to virsh net-dumpxml called --inactive

2012-01-11 Thread Eric Blake
On 12/14/2011 03:50 AM, Shradha Shah wrote: The above option helps to differentiate between implicit and explicit interface pools. --- include/libvirt/libvirt.h.in |4 src/conf/network_conf.c | 10 +++--- src/conf/network_conf.h |2 +-

[libvirt] blockJob events broken

2012-01-11 Thread Adam Litke
Hi Dan, I noticed that since d09f6ba5feb655925175dc80122ca2a1e14db2b9, blockJob events are not being delivered to registered clients. I did verify that VM lifecycle events are still working fine though. I am confused why your patch has only affected my blockJob events. Do you have any ideas?

[libvirt] [PATCH] nwfilter: fix typing error in filter

2012-01-11 Thread Stefan Berger
Fix a typing error in the no-ip-spoofing filter. Return DHCP request packets passing through this filter. Have the user use another filter to actually allow DHCP requests to be sent (action='accept'). --- examples/xml/nwfilter/no-ip-spoofing.xml |6 +++--- 1 file changed, 3 insertions(+), 3

Re: [libvirt] [PATCH] nwfilter: fix typing error in filter

2012-01-11 Thread Eric Blake
On 01/11/2012 12:42 PM, Stefan Berger wrote: Fix a typing error in the no-ip-spoofing filter. Return DHCP request packets passing through this filter. Have the user use another filter to actually allow DHCP requests to be sent (action='accept'). ---

Re: [libvirt] [PATCH] nwfilter: fix typing error in filter

2012-01-11 Thread Stefan Berger
On 01/11/2012 02:57 PM, Eric Blake wrote: On 01/11/2012 12:42 PM, Stefan Berger wrote: Fix a typing error in the no-ip-spoofing filter. Return DHCP request packets passing through this filter. Have the user use another filter to actually allow DHCP requests to be sent (action='accept'). ---

Re: [libvirt] [PATCH v2] Do not generate security_model when fs driver is anything but 'path'

2012-01-11 Thread Eric Blake
On 01/10/2012 06:08 AM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 06:23:31PM +0530, Deepak C Shetty wrote: On 01/10/2012 04:17 PM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 03:35:26PM +0530, Deepak C Shetty wrote: --- v2: - removed xml accessmode changes as suggested by dan.

Re: [libvirt] [PATCH v3] Add new attribute wrpolicy to driver element

2012-01-11 Thread Eric Blake
On 01/10/2012 07:29 AM, Deepak C Shetty wrote: This introduces new attribute wrpolicy with only supported value as immediate. This will be an optional attribute with no defaults. This helps specify whether to skip the host page cache. When wrpolicy is specified, meaning when

Re: [libvirt] [PATCH v3] Add new attribute wrpolicy to driver element

2012-01-11 Thread Eric Blake
On 01/11/2012 03:19 PM, Eric Blake wrote: On 01/10/2012 07:29 AM, Deepak C Shetty wrote: This introduces new attribute wrpolicy with only supported value as immediate. This will be an optional attribute with no defaults. This helps specify whether to skip the host page cache. When wrpolicy

[libvirt] [PATCH] build: update to latest gnulib

2012-01-11 Thread Eric Blake
Pick up recent gnulib improvements. * .gnulib: Update to latest. * bootstrap: Resync. * bootstrap.conf (gnulib_tool_option_extras): Adjust to bootstrap changes. * gnulib/lib/Makefile.am: Likewise. --- I'm not sure that we are desparate for any of these patches, so much as it's nice to re-sync

[libvirt] [PATCH] uuid: fix off-by-one

2012-01-11 Thread Eric Blake
Detected by Coverity. Although unlikely, if we are ever started with stdin closed, we could reach a situation where we open a uuid file but then fail to close it, making that file the new stdin for the rest of the process. * src/util/uuid.c (getDMISystemUUID): Allow for stdin. ---

Re: [libvirt] [PATCH] Revert virsh: Increase device-detach intelligence

2012-01-11 Thread Osier Yang
On 2012年01月12日 01:34, Eric Blake wrote: On 01/11/2012 04:47 AM, Osier Yang wrote: This reverts commit ea7182c29f185e7c1527b10fbe16dc4ba1f45a88. Conflicts are resolved. This is a temporary reverting for it introduces regression of device detaching (any device XML doesn't uses the same order as

Re: [libvirt] [PATCH] docs: Add missed RNG schema for interface

2012-01-11 Thread Osier Yang
On 2012年01月12日 01:25, Laine Stump wrote: On 01/11/2012 08:39 AM, Osier Yang wrote: We supportinterface of type mcast, server, and client, but the RNG schema for them are missed. Right you are! ACK. (A test case with one of each in the xml2argv test would be nice, though - that would have

Re: [libvirt] [PATCH v2] Do not generate security_model when fs driver is anything but 'path'

2012-01-11 Thread Deepak C Shetty
On 01/12/2012 02:18 AM, Eric Blake wrote: On 01/10/2012 06:08 AM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 06:23:31PM +0530, Deepak C Shetty wrote: On 01/10/2012 04:17 PM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 03:35:26PM +0530, Deepak C Shetty wrote: --- v2: - removed

[libvirt] [PATCH v3 0/5] RFC: grant KVM guests retain arbitrary capabilities

2012-01-11 Thread Taku Izumi
Hi Osier-san, Daniel-san, and all, This patchset adds an option for KVM guests to retain arbitrary capabilities. The previous versions are here: http://www.redhat.com/archives/libvir-list/2011-December/msg00857.html http://www.redhat.com/archives/libvir-list/2011-December/msg00950.html v2