Re: [libvirt] [libvirt-glib] Compilation warning and error

2012-01-13 Thread Christophe Fergeau
On Thu, Jan 12, 2012 at 10:50:57PM -0500, Alex Jia wrote: CC libvirt_gobject_1_0_la-libvirt-gobject-main.lo CC libvirt_gobject_1_0_la-libvirt-gobject-domain-snapshot.lo CC libvirt_gobject_1_0_la-libvirt-gobject-domain-device.lo libvirt-gobject-domain-device.c: In function

Re: [libvirt] [libvirt-glib] Make use of G_PARAM_STATIC_STRINGS everywhere

2012-01-13 Thread Christophe Fergeau
G_PARAM_STATIC_STRINGS was added in glib 2.13, configure.ac only check for glib 2.10 at the moment. The patch looks good, but please wait until we make a decision on the minimum glib version we require so that we know if we need to add some fallback for this or not. Imo raising the requirement to

Re: [libvirt] [libvirt-glib] Compilation warning and error

2012-01-13 Thread Alex Jia
Hi Christophe, Thanks for your comments, as you said, it should be my old glib version issue. Regards, Alex - Original Message - From: Christophe Fergeau cferg...@redhat.com To: Alex Jia a...@redhat.com Cc: Daniel Berrange berra...@redhat.com, libvir libvir-list@redhat.com Sent:

Re: [libvirt] [libvirt-glib] Compilation warning and error

2012-01-13 Thread Christophe Fergeau
On Fri, Jan 13, 2012 at 04:21:33AM -0500, Alex Jia wrote: Hi Christophe, Thanks for your comments, as you said, it should be my old glib version issue. Thanks for reporting this issue btw :) I think we should raise the glib requirement a bit (maybe 2.18) and then add fallbacks for the

Re: [libvirt] [PATCH v2] virsh: Two new fields for command domblklist

2012-01-13 Thread Osier Yang
On 2012年01月13日 07:00, Eric Blake wrote: On 01/12/2012 03:53 AM, Osier Yang wrote: Disk type and device are generally interesting stuffs the s/stuffs/stuff/ user who wants to known too. To not breaking the scripts which s/who wants to known too/may want to know, too/ s/breaking the/break

[libvirt] [PATCH] virsh domiflist: change output

2012-01-13 Thread Taku Izumi
When using virsh domifstat command or virsh domiftune command, we pass an interface name as a parameter, so interface name is important. virsh domiflist output should display interface names on the first row. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- tools/virsh.c |9

[libvirt] [PATCH] qemu: Introduce inactive PCI device list

2012-01-13 Thread Osier Yang
pciTrySecondaryBusReset checks if there is active device on the same bus, however, qemu driver doesn't maintain an effective list for the inactive devices, and it passes meaningless argment for parameter inactiveDevs. e.g. (qemuPrepareHostdevPCIDevices) if (!(pcidevs =

[libvirt] [PATCH] export virNetDevGetVirtualFunctions as a private symbol

2012-01-13 Thread Paolo Bonzini
This avoids a linking error. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- src/libvirt_private.syms |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 27a093c..912f1b4 100644 --- a/src/libvirt_private.syms +++

[libvirt] [PATCH 1/2] qemu: add ibmvscsi controller model

2012-01-13 Thread Paolo Bonzini
KVM will be able to use a PCI SCSI controller even on POWER. Let the user specify the vSCSI controller by other means than a default. After this patch, the QEMU driver will actually look at the model and reject anything but auto, lsilogic and ibmvscsi. Signed-off-by: Paolo Bonzini

[libvirt] [PATCH 2/2] qemu: add virtio-scsi controller model

2012-01-13 Thread Paolo Bonzini
Adding a new model for virtio-scsi roughly follows the same scheme as the previous patch. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- This is the bare minimum necessary to use virtio-scsi. I'll gladly leave everything else, including support for full SCSI

[libvirt] [PATCH 0/2] add ibmvscsi and virtio-scsi controller models

2012-01-13 Thread Paolo Bonzini
Hi, these patches let you specify explicitly all supported controller models for QEMU, and add the new virtio-scsi model. Paolo Bonzini (2): qemu: add ibmvscsi controller model qemu: add virtio-scsi controller model docs/formatdomain.html.in |4 +-

Re: [libvirt] [PATCH v3 0/5] RFC: grant KVM guests retain arbitrary capabilities

2012-01-13 Thread Daniel P. Berrange
On Thu, Jan 12, 2012 at 04:25:27PM +0900, Taku Izumi wrote: Hi Osier-san, Daniel-san, and all, This patchset adds an option for KVM guests to retain arbitrary capabilities. The previous versions are here: http://www.redhat.com/archives/libvir-list/2011-December/msg00857.html

Re: [libvirt] [PATCH] export virNetDevGetVirtualFunctions as a private symbol

2012-01-13 Thread Eric Blake
On 01/13/2012 05:08 AM, Paolo Bonzini wrote: This avoids a linking error. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- src/libvirt_private.syms |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

Re: [libvirt] [PATCH] virsh domiflist: change output

2012-01-13 Thread Eric Blake
On 01/13/2012 03:41 AM, Taku Izumi wrote: When using virsh domifstat command or virsh domiftune command, we pass an interface name as a parameter, so interface name is important. virsh domiflist output should display interface names on the first row. Signed-off-by: Taku Izumi

[libvirt] [PATCH 0/4] Add ability to store and display notes and description with domains

2012-01-13 Thread Peter Krempa
This patchset adds ability to store, display and modify comments for domains to help administrators identify and store metadata to domains to allow easy identification. A short description note was added as an attribute for the description element to hold a shorter description (limited to max

[libvirt] [PATCH 1/4] xml: Add attribute to description element to hold a short note

2012-01-13 Thread Peter Krempa
This patch adds an optional attribute note= to the description element in the domain XML. This attribute can hold a short note defined by the user to ease the identification of domains. The note is limited to 40 characters. *docs/formatdomain.html.in *docs/schemas/domaincommon.rng -

[libvirt] [PATCH 2/4] api: Add api to set domain note and description in runtime

2012-01-13 Thread Peter Krempa
The description element was accessible only throught the XML, that makes it hard to work with. Atomic operations and modification of the live domain are impossible. This patch adds a function to the public API to set arbitrary descriptions for live and persistent domains.

[libvirt] [PATCH 4/4] virsh: Add support for modifying domain description and notes

2012-01-13 Thread Peter Krempa
This patch adds a new command desc to show and modify notes and description for the domains using the new API. This patch also adds a new flag for the list command to show notes in the domain list, to allow easy identification of VMs by storing a short description. Example: virsh # list --note

[libvirt] [PATCH 3/4] qemu: Implement note API in qemu driver

2012-01-13 Thread Peter Krempa
This patch adds support for the new api to change domain descriptions to the qemu driver. --- src/qemu/qemu_driver.c | 70 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH 4/4] native: add driver support

2012-01-13 Thread Eric Blake
Xen was the trickiest, since it supports two formats. * src/esx/esx_driver.c (esxDomainNativeFormats): New function. * src/libxl/libxl_driver.c (libxlDomainNativeFormats): Likewise. * src/qemu/qemu_driver.c (qemuDomainNativeFormats): Likewise. * src/xen/xen_driver.c

[libvirt] [PATCH 0/4] add virsh domxml-formats

2012-01-13 Thread Eric Blake
I previously proposed this here: https://www.redhat.com/archives/libvir-list/2011-December/msg00899.html although it's been on my wish list a lot longer than that. Questions: I had the new API take nformats as an int, and return the number of populated slots; should I switch this to take

[libvirt] [PATCH 2/4] native: add virsh command domxml-formats

2012-01-13 Thread Eric Blake
I've wanted this command for ages :) * tools/virsh.c (cmdDomXMLFormats): New function. * tools/virsh.pod (domxml-formats): Document it. --- tools/virsh.c | 48 tools/virsh.pod | 11 +-- 2 files changed, 57 insertions(+), 2

[libvirt] [PATCH 1/4] native: add virConnectNativeFormats API

2012-01-13 Thread Eric Blake
Make it easier to query what nativeFormat strings are valid in the conversion between XML and native formats. * include/libvirt/libvirt.h.in (virConnectDomainNativeFormats): New declaration. * src/libvirt.c (virConnectDomainNativeFormats): Implement it. * src/driver.h

[libvirt] [PATCH 3/4] native: implement rpc handling of new API

2012-01-13 Thread Eric Blake
Alas, the special handling of nformats == 0 means we can't use autogen. * src/remote/remote_protocol.x (remote_domain_native_formats_args) (remote_domain_native_formats_ret): New types. * daemon/remote.c (remoteDispatchDomainNativeFormats): New function. * src/remote/remote_driver.c

Re: [libvirt] [libvirt-glib] Compilation warning and error

2012-01-13 Thread Daniel P. Berrange
On Fri, Jan 13, 2012 at 10:27:30AM +0100, Christophe Fergeau wrote: On Fri, Jan 13, 2012 at 04:21:33AM -0500, Alex Jia wrote: Hi Christophe, Thanks for your comments, as you said, it should be my old glib version issue. Thanks for reporting this issue btw :) I think we should raise the

Re: [libvirt] [PATCH 1/4] xml: Add attribute to description element to hold a short note

2012-01-13 Thread Daniel P. Berrange
On Fri, Jan 13, 2012 at 07:17:36PM +0100, Peter Krempa wrote: This patch adds an optional attribute note= to the description element in the domain XML. This attribute can hold a short note defined by the user to ease the identification of domains. The note is limited to 40 characters. I

Re: [libvirt] [PATCH 0/4] Add ability to store and display notes and description with domains

2012-01-13 Thread Eric Blake
On 01/13/2012 11:17 AM, Peter Krempa wrote: This patchset adds ability to store, display and modify comments for domains to help administrators identify and store metadata to domains to allow easy identification. A short description note was added as an attribute for the description

[libvirt] [libvirt-glib] Add gvir_config_domain_disk_set_readonly()

2012-01-13 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain-disk.c | 11 +++ libvirt-gconfig/libvirt-gconfig-domain-disk.h |2 ++ libvirt-gconfig/libvirt-gconfig.sym |1 + 3 files changed, 14 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH 1/4] xml: Add attribute to description element to hold a short note

2012-01-13 Thread Eric Blake
On 01/13/2012 11:17 AM, Peter Krempa wrote: This patch adds an optional attribute note= to the description element in the domain XML. This attribute can hold a short note defined by the user to ease the identification of domains. The note is limited to 40 characters. I'd go one step further,

Re: [libvirt] [PATCH 2/4] api: Add api to set domain note and description in runtime

2012-01-13 Thread Eric Blake
On 01/13/2012 11:17 AM, Peter Krempa wrote: The description element was accessible only throught the XML, that s/throught/through/ makes it hard to work with. Atomic operations and modification of the live domain are impossible. This patch adds a function to the public API to set arbitrary

Re: [libvirt] [PATCH 3/4] qemu: Implement note API in qemu driver

2012-01-13 Thread Eric Blake
On 01/13/2012 11:17 AM, Peter Krempa wrote: This patch adds support for the new api to change domain descriptions to the qemu driver. --- src/qemu/qemu_driver.c | 70 1 files changed, 70 insertions(+), 0 deletions(-) This seems simple

Re: [libvirt] [PATCH 4/4] virsh: Add support for modifying domain description and notes

2012-01-13 Thread Eric Blake
On 01/13/2012 11:17 AM, Peter Krempa wrote: This patch adds a new command desc to show and modify notes and description for the domains using the new API. This patch also adds a new flag for the list command to show notes in the domain list, to allow easy identification of VMs by storing a

[libvirt] [PATCH] events: Return the correct number of registered events

2012-01-13 Thread Adam Litke
Commit d09f6ba5feb655925175dc80122ca2a1e14db2b9 introduced a regression in event registration. virDomainEventCallbackListAddID() will only return a positive integer if the type of event being registered is VIR_DOMAIN_EVENT_ID_LIFECYCLE. For other event types, 0 is always returned on success.

[libvirt] [PATCH] BlockJob: Support sync/async virDomainBlockJobAbort

2012-01-13 Thread Adam Litke
Qemu has changed the semantics of the block_job_cancel API. Originally, the operation was synchronous (ie. upon command completion, the operation was guaranteed to be completely stopped). With the new semantics, a block_job_cancel merely requests that the operation be cancelled and an event is

Re: [libvirt] [PATCH] events: Return the correct number of registered events

2012-01-13 Thread Eric Blake
On 01/13/2012 01:44 PM, Adam Litke wrote: Commit d09f6ba5feb655925175dc80122ca2a1e14db2b9 introduced a regression in event registration. virDomainEventCallbackListAddID() will only return a positive integer if the type of event being registered is VIR_DOMAIN_EVENT_ID_LIFECYCLE. For other

Re: [libvirt] [PATCH] BlockJob: Support sync/async virDomainBlockJobAbort

2012-01-13 Thread Dave Allan
On Fri, Jan 13, 2012 at 02:51:23PM -0600, Adam Litke wrote: Qemu has changed the semantics of the block_job_cancel API. Originally, the operation was synchronous (ie. upon command completion, the operation was guaranteed to be completely stopped). With the new semantics, a block_job_cancel

Re: [libvirt] [PATCH 1/2] qemu: add ibmvscsi controller model

2012-01-13 Thread Eric Blake
On 01/13/2012 05:23 AM, Paolo Bonzini wrote: KVM will be able to use a PCI SCSI controller even on POWER. Let the user specify the vSCSI controller by other means than a default. After this patch, the QEMU driver will actually look at the model and reject anything but auto, lsilogic and

Re: [libvirt] [PATCH 2/2] qemu: add virtio-scsi controller model

2012-01-13 Thread Eric Blake
On 01/13/2012 05:23 AM, Paolo Bonzini wrote: Adding a new model for virtio-scsi roughly follows the same scheme as the previous patch. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- This is the bare minimum necessary to use virtio-scsi. I'll gladly leave everything else,

Re: [libvirt] [PATCH 1/4] Make drive unit attribute optional in the XML schema

2012-01-13 Thread Eric Blake
On 01/12/2012 08:39 PM, Michael Ellerman wrote: The unit attribute of a drive address is optional in the code, so should also be in the XML schema. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- docs/schemas/domaincommon.rng |8 +--- 1 files changed, 5 insertions(+), 3

[libvirt] ALERT Virtualization Automatic Builder

2012-01-13 Thread berrange
Overall status: failed Start date: Fri Jan 13 2012 Start time: 22:05:02 UTC / 17:05:02 EST Build counter: 1326492302 Build timestamp: 1326492302 URL: http://builder.virt-tools.org/index.html Module: libvirt Status: failed URL: http://builder.virt-tools.org/module-libvirt.html -- libvir-list

Re: [libvirt] [PATCH] BlockJob: Support sync/async virDomainBlockJobAbort

2012-01-13 Thread Adam Litke
On Fri, Jan 13, 2012 at 04:48:30PM -0500, Dave Allan wrote: On Fri, Jan 13, 2012 at 02:51:23PM -0600, Adam Litke wrote: Qemu has changed the semantics of the block_job_cancel API. Originally, the operation was synchronous (ie. upon command completion, the operation was guaranteed to be

Re: [libvirt] ALERT Virtualization Automatic Builder

2012-01-13 Thread Eric Blake
On 01/13/2012 03:19 PM, berra...@redhat.com wrote: Overall status: failed Start date: Fri Jan 13 2012 Start time: 22:05:02 UTC / 17:05:02 EST Build counter: 1326492302 Build timestamp: 1326492302 URL: http://builder.virt-tools.org/index.html Module: libvirt Status: failed URL:

Re: [libvirt] [PATCH 2/4] tests: Teach qemuxml2argvtest about spapr-vio addresses

2012-01-13 Thread Eric Blake
On 01/12/2012 08:39 PM, Michael Ellerman wrote: We can't call qemuCapsExtractVersionInfo() from test code, because it expects to be able to call the emulator, and for testing we have fake emulators that can't be executed. For that reason qemuxml2argvtest.c doesn't call

Re: [libvirt] [PATCH 3/4] tests: Add qemuxml2argv tests for PPC64 pseries machine

2012-01-13 Thread Eric Blake
On 01/12/2012 08:39 PM, Michael Ellerman wrote: Add four tests of the XML - argv handling for the PPC64 pseries machine. The first is just a basic test of a bare bones machine. The three others test various aspects of the spapr-vio address handling. It seems that currently we can't

Re: [libvirt] [PATCH 4/4] conf: Remove do-nothing validation functions

2012-01-13 Thread Eric Blake
On 01/12/2012 08:39 PM, Michael Ellerman wrote: There are three address validation routines that do nothing: virDomainDeviceDriveAddressIsValid() virDomainDeviceUSBAddressIsValid() virDomainDeviceVirtioSerialAddressIsValid() Remove them, and replace their call sites with 1 which is