[libvirt] [PATCH] XML file used to test libvirt proxy FS support

2012-01-16 Thread M. Mohan Kumar
From: "M. Mohan Kumar" Signed-off-by: M. Mohan Kumar --- diff --git a/test.xml b/test.xml new file mode 100644 index 000..46fc6fc --- /dev/null +++ b/patch/test.xml @@ -0,0 +1,39 @@ + + test_vm + 7e359ba6-3833-dfe0-6c31-c09fcfad169b + 524288 + 524288 + 1 + +hvm +/vm/bzImage

[libvirt] [RFC PATCH] Add proxy FS (9p) support to libvirt

2012-01-16 Thread M. Mohan Kumar
From: "M. Mohan Kumar" This patch *) adds new sub element under element. This sub-element is used to specify the virtfs-proxy-helper binary (part of QEMU) to be executed when proxy FS driver is used. *) invokes proxy_helper binary specified by the sub-element with passing one of the created s

Re: [libvirt] [libvirt-glib] Make use of G_PARAM_STATIC_STRINGS everywhere

2012-01-16 Thread Zeeshan Ali (Khattak)
On Fri, Jan 13, 2012 at 11:01 AM, Christophe Fergeau wrote: > G_PARAM_STATIC_STRINGS was added in glib 2.13, configure.ac only check for > glib 2.10 at the moment. The patch looks good, but please wait until we > make a decision on the minimum glib version we require so that we know if > we need t

Re: [libvirt] [PATCH v2 3/6] Add support for cpu mode attribute

2012-01-16 Thread Eric Blake
On 01/16/2012 01:59 PM, Jiri Denemark wrote: > On Mon, Jan 16, 2012 at 13:38:00 -0700, Eric Blake wrote: >> On 01/12/2012 04:02 AM, Jiri Denemark wrote: >>> The mode can be either of "custom" (default), "host-model", >>> "host-passthrough". The semantics of each mode is described in the >>> followi

Re: [libvirt] [PATCH] virNetServer: Don't fail if we can't initialize avahi

2012-01-16 Thread Guido Günther
On Mon, Jan 16, 2012 at 07:52:38PM +, Daniel P. Berrange wrote: > On Mon, Jan 16, 2012 at 11:29:51AM -0700, Eric Blake wrote: > > On 01/14/2012 01:01 PM, Guido Günther wrote: > > > since libvird won't start otherwise without avahi running. > > > > > > Having avahi compiled in shouldn't force u

Re: [libvirt] [PATCH v2 3/6] Add support for cpu mode attribute

2012-01-16 Thread Jiri Denemark
On Mon, Jan 16, 2012 at 13:38:00 -0700, Eric Blake wrote: > On 01/12/2012 04:02 AM, Jiri Denemark wrote: > > The mode can be either of "custom" (default), "host-model", > > "host-passthrough". The semantics of each mode is described in the > > following examples: > > > > > --- > > Notes: > >

Re: [libvirt] [PATCH v2 6/6] qemu: Add support for host CPU modes

2012-01-16 Thread Eric Blake
On 01/12/2012 04:03 AM, Jiri Denemark wrote: > This adds support for host-model and host-passthrough CPU modes to qemu > driver. The host-passthrough mode is mapped to -cpu host. > --- > Notes: > Version 2: > - more verbose commit messages > - portability fixes in shell scripts > +++ b

Re: [libvirt] [PATCH v2 5/6] Taint domains configured with cpu mode=host-passthrough

2012-01-16 Thread Eric Blake
On 01/12/2012 04:02 AM, Jiri Denemark wrote: > There are several reasons for doing this: > > - the CPU specification is out of libvirt's control so we cannot > guarantee stable guest ABI > - not every feature of a CPU may actually work as expected when > advertised directly to a guest > - migr

Re: [libvirt] [PATCH v2 3/6] Add support for cpu mode attribute

2012-01-16 Thread Eric Blake
On 01/12/2012 04:02 AM, Jiri Denemark wrote: > The mode can be either of "custom" (default), "host-model", > "host-passthrough". The semantics of each mode is described in the > following examples: > > --- > Notes: > Version 2: > - added documentation > - fixed XML examples and schema

Re: [libvirt] [PATCH v2 4/6] cpu: Update guest CPU in host-* mode

2012-01-16 Thread Eric Blake
On 01/12/2012 04:02 AM, Jiri Denemark wrote: > VIR_DOMAIN_XML_UPDATE_CPU flag for virDomainGetXMLDesc may be used to > get updated custom mode guest CPU definition in case it depends on host > CPU. This patch implements the same behavior for host-model and > host-passtrhough CPU modes. s/passtrhou

Re: [libvirt] [PATCH v2 2/6] cpu: Optionally forbid fallback CPU models

2012-01-16 Thread Eric Blake
On 01/12/2012 04:02 AM, Jiri Denemark wrote: > In case a hypervisor doesn't support the exact CPU model requested by a > domain XML, we automatically fallback to a closest CPU model the > hypervisor supports (and make sure we add/remove any additional features > if needed). This patch adds 'fallbac

Re: [libvirt] [PATCH v2 1/6] tests: Print XML file name in verbose CPU test

2012-01-16 Thread Eric Blake
On 01/12/2012 04:02 AM, Jiri Denemark wrote: > It's not totally obvious that a failure in > > CPU guest data(x86): host/guest (models, pref="qemu64") > > test means one needs to fix > > x86-host+guest,models,qemu64-result.xml > > where the expected XML is stored. Better to provide a nic

Re: [libvirt] [PATCH] virNetServer: Don't fail if we can't initialize avahi

2012-01-16 Thread Daniel P. Berrange
On Mon, Jan 16, 2012 at 11:29:51AM -0700, Eric Blake wrote: > On 01/14/2012 01:01 PM, Guido Günther wrote: > > since libvird won't start otherwise without avahi running. > > > > Having avahi compiled in shouldn't force us to have avahi running. > > --- > > src/rpc/virnetserver.c |5 ++--- > >

Re: [libvirt] [PATCH] BlockJob: Support sync/async virDomainBlockJobAbort

2012-01-16 Thread Dave Allan
On Fri, Jan 13, 2012 at 04:30:56PM -0600, Adam Litke wrote: > On Fri, Jan 13, 2012 at 04:48:30PM -0500, Dave Allan wrote: > > On Fri, Jan 13, 2012 at 02:51:23PM -0600, Adam Litke wrote: > > > Qemu has changed the semantics of the "block_job_cancel" API. > > > Originally, the > > > operation was s

Re: [libvirt] [PATCH 0/4] add virsh domxml-formats

2012-01-16 Thread Eric Blake
On 01/16/2012 06:01 AM, Cole Robinson wrote: > On 01/13/2012 02:11 PM, Eric Blake wrote: >> I previously proposed this here: >> https://www.redhat.com/archives/libvir-list/2011-December/msg00899.html >> although it's been on my wish list a lot longer than that. >> >> Questions: I had the new API ta

Re: [libvirt] [PATCH] Clarify semantics of virDomainMigrate{, ToURI}2

2012-01-16 Thread Eric Blake
On 01/16/2012 03:19 AM, Jiri Denemark wrote: > Commit 5d784bd6d7b19314b0908aec6b46bfe377aeba42 was a nice attempt to > clarify the semantics by requiring domain name from dxml to either match > original name or dname. However, setting dxml domain name to dname > doesn't really work since destinatio

Re: [libvirt] [PATCH] virNetServer: Don't fail if we can't initialize avahi

2012-01-16 Thread Eric Blake
On 01/14/2012 01:01 PM, Guido Günther wrote: > since libvird won't start otherwise without avahi running. > > Having avahi compiled in shouldn't force us to have avahi running. > --- > src/rpc/virnetserver.c |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/rp

[libvirt] [PATCH] build: fix bootstrap on fresh clone

2012-01-16 Thread Eric Blake
Commit 29db7a0 picked up a gnulib bug, where a change in bootstrap meant that it would fail to run libtoolize on projects, like libvirt, that used the older spelling AM_PROG_LIBTOOL instead of LT_INIT for the sake of building on RHEL 5. Now that gnulib is fixed, we should pick up that fix. * .gnu

Re: [libvirt] [BUG] EPOLL_CLOEXEC undeclared

2012-01-16 Thread Eric Blake
On 01/16/2012 08:07 AM, Philipp Hahn wrote: > Hi, > > $ cat /etc/debian_version > 5.0.1 > $ dpkg -S eventpoll.h > linux-libc-dev: /usr/include/linux/eventpoll.h > $ dpkg-query -W linux-libc-dev > linux-libc-dev 2.6.32-35~ucs1.48.201109051614 glibc has supported epoll_create1() and EPOLL_CLOEXEC

[libvirt] [BUG] EPOLL_CLOEXEC undeclared

2012-01-16 Thread Philipp Hahn
Hi, $ cat /etc/debian_version 5.0.1 $ dpkg -S eventpoll.h linux-libc-dev: /usr/include/linux/eventpoll.h $ dpkg-query -W linux-libc-dev linux-libc-dev 2.6.32-35~ucs1.48.201109051614 $ git describe v0.9.9-57-g7eb9cfd $ ./autogen.sh ; make ... (cd .libs && rm -f libvirt_test.la && ln -s ../libvirt

Re: [libvirt] cpu models for AMD Bulldozer and Sandy Bridge

2012-01-16 Thread Shahar Havivi
On 16.01.12 15:41, Peter Krempa wrote: > On 01/15/2012 03:48 PM, Shahar Havivi wrote: > >Hi, > >what are the cpu models for AMD Bulldozer and Sandy Bridge? > Hi Sharah, > > libvirt has recently added flags that are now supported by the new > Sandy Bridge CPU's from Intel. (Well, to be honest, all

Re: [libvirt] cpu models for AMD Bulldozer and Sandy Bridge

2012-01-16 Thread Peter Krempa
On 01/15/2012 03:48 PM, Shahar Havivi wrote: Hi, what are the cpu models for AMD Bulldozer and Sandy Bridge? Hi Sharah, libvirt has recently added flags that are now supported by the new Sandy Bridge CPU's from Intel. (Well, to be honest, all flags that are implemented in qemu and were missin

[libvirt] [libvirt-glib 2/3] Don't use g_error in xxx_get_name

2012-01-16 Thread Christophe Fergeau
g_error will trigger an abort of the running process so it's not desirable to call it in a library. This commit adds a GError ** parameter to all _get_name methods which were calling g_error. --- libvirt-gobject/libvirt-gobject-connection.c | 10 -- libvirt-gobject/libvirt-gobject-d

[libvirt] [libvirt-glib 3/3] Replace g_error with g_warning in constructors

2012-01-16 Thread Christophe Fergeau
g_error generates a fatal error message, meaning it will abort the currently running process. It's nicer to use g_warning here. --- libvirt-gobject/libvirt-gobject-domain.c |4 +++- libvirt-gobject/libvirt-gobject-network-filter.c |4 +++- libvirt-gobject/libvirt-gobject-network.c

[libvirt] [libvirt-glib 1/3] Add proper error reporting to GVirStorageVol getters

2012-01-16 Thread Christophe Fergeau
gvir_storage_vol_get_name and gvir_storage_vol_get_path currently call g_error when an error occurs. Since g_error trigger a coredump, calling it in a library is harmful. Replace this with proper GError error reporting. --- libvirt-gobject/libvirt-gobject-storage-pool.c | 10 +++--- libvirt-

[libvirt] g_error considered harmful

2012-01-16 Thread Christophe Fergeau
Hi, g_error calls abort() when it's called, thus it should only be used for bad assertion failures. We currently are using it in some places in libvirt-gobject as if it was g_warning. This patch series gets rid of most occurrences of g_error by either replacing it with g_warning or by adding a GEr

[libvirt] [PATCH v2] docs: Add missed RNG schema for interface

2012-01-16 Thread Osier Yang
We support of type "mcast", "server", and "client", but the RNG schema for them are missed. Attribute "address" is optional for "server" type. And these 3 types support , too. --- docs/formatdomain.html.in |3 + docs/schemas/domaincommon.rng | 5

Re: [libvirt] [PATCH 0/4] add virsh domxml-formats

2012-01-16 Thread Cole Robinson
On 01/13/2012 02:11 PM, Eric Blake wrote: > I previously proposed this here: > https://www.redhat.com/archives/libvir-list/2011-December/msg00899.html > although it's been on my wish list a lot longer than that. > > Questions: I had the new API take nformats as an int, and return the > number of p

Re: [libvirt] [PATCH 2/3] docs: Expose alias tag in domain RNG schema

2012-01-16 Thread Osier Yang
On 2012年01月16日 19:10, Daniel P. Berrange wrote: On Mon, Jan 16, 2012 at 06:33:59PM +0800, Osier Yang wrote: Though is ignored when defining a domain, it can cause failure if one validates (e.g. virt-xml-validate) the XML dumped from a running domain. This patch expose it in domain RNG schema fo

Re: [libvirt] [PATCH 1/3] docs: Add readonly to filesystem RNG schema

2012-01-16 Thread Osier Yang
On 2012年01月16日 19:09, Daniel P. Berrange wrote: On Mon, Jan 16, 2012 at 06:19:26PM +0800, Osier Yang wrote: "" is supported by filesystem XML, and also documented. --- docs/schemas/domaincommon.rng |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/docs/schemas/domai

Re: [libvirt] [PATCH 2/3] docs: Expose alias tag in domain RNG schema

2012-01-16 Thread Daniel P. Berrange
On Mon, Jan 16, 2012 at 06:33:59PM +0800, Osier Yang wrote: > Though is ignored when defining a domain, it can cause > failure if one validates (e.g. virt-xml-validate) the XML dumped > from a running domain. This patch expose it in domain RNG schema > for all the devices which support it. > --- >

Re: [libvirt] [PATCH 1/3] docs: Add readonly to filesystem RNG schema

2012-01-16 Thread Daniel P. Berrange
On Mon, Jan 16, 2012 at 06:19:26PM +0800, Osier Yang wrote: > "" is supported by filesystem XML, and also documented. > --- > docs/schemas/domaincommon.rng |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.r

Re: [libvirt] [libvirt-glib] Raise libvirt requirement to 0.9.8

2012-01-16 Thread Daniel P. Berrange
On Mon, Jan 16, 2012 at 11:37:27AM +0100, Christophe Fergeau wrote: > We are using VIR_DOMAIN_EVENT_SHUTDOWN which was introduced > in libvirt 0.9.8. Reflect this requirement by bumping the minimum > version of libvirt we require in configure.ac. > This issue was reported by Nirbheek Chauhan > ---

[libvirt] [PATCH] Add two NUMA tuning python bindings APIs

2012-01-16 Thread Guannan Ren
*virDomainSetNumaParameters *virDomainGetNumaParameters --- python/libvirt-override-api.xml | 13 +++ python/libvirt-override.c | 186 +++ 2 files changed, 199 insertions(+), 0 deletions(-) diff --git a/python/libvirt-override-api.xml b

Re: [libvirt] [PATCH] events: Return the correct number of registered events

2012-01-16 Thread Daniel P. Berrange
On Fri, Jan 13, 2012 at 02:00:31PM -0700, Eric Blake wrote: > On 01/13/2012 01:44 PM, Adam Litke wrote: > > Commit d09f6ba5feb655925175dc80122ca2a1e14db2b9 introduced a regression in > > event > > registration. virDomainEventCallbackListAddID() will only return a positive > > integer if the type

[libvirt] [libvirt-glib] Raise libvirt requirement to 0.9.8

2012-01-16 Thread Christophe Fergeau
We are using VIR_DOMAIN_EVENT_SHUTDOWN which was introduced in libvirt 0.9.8. Reflect this requirement by bumping the minimum version of libvirt we require in configure.ac. This issue was reported by Nirbheek Chauhan --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) di

Re: [libvirt] [libvirt-glib] Add gvir_config_domain_disk_set_readonly()

2012-01-16 Thread Christophe Fergeau
ACK On Fri, Jan 13, 2012 at 09:44:35PM +0200, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > libvirt-gconfig/libvirt-gconfig-domain-disk.c | 11 +++ > libvirt-gconfig/libvirt-gconfig-domain-disk.h |2 ++ > libvirt-gconfig/libvirt-gconfig.sym |1

[libvirt] [PATCH] Clarify semantics of virDomainMigrate{,ToURI}2

2012-01-16 Thread Jiri Denemark
Commit 5d784bd6d7b19314b0908aec6b46bfe377aeba42 was a nice attempt to clarify the semantics by requiring domain name from dxml to either match original name or dname. However, setting dxml domain name to dname doesn't really work since destination host needs to know the original domain name to be a

[libvirt] [PATCH 3/3] docs: Improve the schema for fs device

2012-01-16 Thread Osier Yang
is just redundant, as every group uses it; shouldn't be in in case of the meaning could be "filesystemtarget"; The elements , , , ... should be interleaved. --- docs/schemas/domaincommon.rng | 58 ++-- 1 files changed, 26 insertions(+), 32 deletions(-) dif

[libvirt] [PATCH 2/3] docs: Expose alias tag in domain RNG schema

2012-01-16 Thread Osier Yang
Though is ignored when defining a domain, it can cause failure if one validates (e.g. virt-xml-validate) the XML dumped from a running domain. This patch expose it in domain RNG schema for all the devices which support it. --- docs/schemas/domaincommon.rng | 64 +

[libvirt] [PATCH 1/3] docs: Add readonly to filesystem RNG schema

2012-01-16 Thread Osier Yang
"" is supported by filesystem XML, and also documented. --- docs/schemas/domaincommon.rng |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 6d265f3..b34526f 100644 --- a/docs/schemas/domaincommon.rng +++