Re: [libvirt] [PATCH v3 0/5] RFC: grant KVM guests retain arbitrary capabilities

2012-01-17 Thread Taku Izumi
Sorry for late response. On Fri, 13 Jan 2012 14:46:08 + "Daniel P. Berrange" wrote: > On Thu, Jan 12, 2012 at 04:25:27PM +0900, Taku Izumi wrote: > > Hi Osier-san, Daniel-san, and all, > > > > This patchset adds an option for KVM guests to retain arbitrary > > capabilities. > > The previ

[libvirt] [PATCH 3/5 V3] qemu: implement new API virDomainGetPcpusUsage for qemu driver

2012-01-17 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- src/qemu/qemu.conf |5 ++- src/qemu/qemu_conf.c |3 +- src/qemu/qemu_driver.c | 74 src/util/cgroup.c |7 src/util/cgroup.h |1 + 5 files changed, 87 insertions(+), 3 deletions

[libvirt] [PATCH 5/5 V3] python: implement virDomainGetPcpusUsage

2012-01-17 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- python/generator.py |2 +- python/libvirt-override-api.xml |6 ++ python/libvirt-override.c | 33 + 3 files changed, 40 insertions(+), 1 deletions(-) diff --git a/python/generator.py b/python/generat

[libvirt] [PATCH 2/5 V3] remote: mplement new API virDomainGetPcpusUsage for remote driver

2012-01-17 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- daemon/remote.c | 68 ++ src/remote/remote_driver.c | 51 +++ src/remote/remote_protocol.x | 17 ++- src/remote_protocol-structs | 13 4 files changed, 148

[libvirt] [PATCH 1/1 V3] ocaml-libvirt: and virDomainGetPcpusUsage() API to ocaml-libvirt

2012-01-17 Thread Lai Jiangshan
Acked-by: "Richard W.M. Jones" Signed-off-by: Lai Jiangshan --- libvirt/libvirt.ml |1 + libvirt/libvirt.mli |4 libvirt/libvirt_c_oneoffs.c | 25 + 3 files changed, 30 insertions(+), 0 deletions(-) diff --git a/libvirt/libvirt.ml b/libvir

[libvirt] [PATCH 0/5 0/1 0/1 V3] Add new public API virDomainGetPcpusUsage() and pcpuinfo command in virsh

2012-01-17 Thread Lai Jiangshan
"virt-top -1" can call virDomainGetPcpusUsage() periodically and get the CPU activities per CPU. (See the last patch in this series). virsh is also added a pcpuinfo command which calls virDomainGetPcpusUsage(), it gets information about the physical CPUs, such as the usage of CPUs, the current att

[libvirt] [PATCH 1/5 V3] libvirt: Add new public API virDomainGetPcpusUsage

2012-01-17 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan --- include/libvirt/libvirt.h.in |5 python/generator.py |1 + src/driver.h |7 + src/libvirt.c| 51 ++ src/libvirt_public.syms |5 5 files changed, 6

[libvirt] [PATCH 1/1 V3] virt-top: correct "virt-top -1" command via cpuacct cgroup

2012-01-17 Thread Lai Jiangshan
Old "virt-top -1" is not correct, its output is generated by guess: use average usage for pinned physical CPUs. example(old "virt-top -1"): PHYCPU %CPU rhel6 Windows 00.6 0.1= 0.5= 10.6 0.1= 0.5=#

[libvirt] [PATCH 4/5 V3] virsh: Enable the pcpuinfo command in virsh

2012-01-17 Thread Lai Jiangshan
This command gets information about the physical CPUs. Example: # virsh pcpuinfo rhel6 CPU:0 Curr VCPU: - Usage: 47.3 CPU:1 Curr VCPU: 1 Usage: 46.8 CPU:2 Curr VCPU: 0 Usage: 52.7 CPU:3 Curr VCPU: - U

Re: [libvirt] [PATCH] qemu: Do not fail if detachment succeeded but failed on resetting device

2012-01-17 Thread Alex Jia
On 01/18/2012 08:18 AM, Eric Blake wrote: On 01/17/2012 01:46 PM, Osier Yang wrote: It makes one curious to see error "Failed to detach device" while the device is detached successfully, only because of it failed on resetting the device. And on the other hand, failed on resetting is not the end

Re: [libvirt] [PATCH v4] Add new attribute wrpolicy to element

2012-01-17 Thread Deepak C Shetty
On 01/18/2012 04:07 AM, Eric Blake wrote: You had lots of trailing whitespace, caught by 'make syntax-check'. +++ b/tests/qemuxml2argvdata/qemuxml2argv-fs9p.args @@ -4,10 +4,10 @@ unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -hda \ /dev/HostVG/QEMUGuest1 -fsdev local,security_model=

Re: [libvirt] [RFC PATCH] Add proxy FS (9p) support to libvirt

2012-01-17 Thread M. Mohan Kumar
On Wednesday, January 18, 2012 03:01:47 AM Daniel P. Berrange wrote: > On Tue, Jan 17, 2012 at 10:48:15AM +0530, M. Mohan Kumar wrote: > > Is it okay to add the sub-element "virtfs-proxy-helper" under "devices" > > element? Proxy helper binary is common for all 9p proxy FS devices, so it > > can no

Re: [libvirt] [PATCH v2] qemu: Introduce inactive PCI device list

2012-01-17 Thread Osier Yang
On 2012年01月18日 08:14, Eric Blake wrote: On 01/17/2012 01:02 PM, Osier Yang wrote: pciTrySecondaryBusReset checks if there is active device on the same bus, however, qemu driver doesn't maintain an effective list for the inactive devices, and it passes meaningless argment s/argment/argument/

Re: [libvirt] [PATCH] remote: avoid memory leak on successful path

2012-01-17 Thread Alex Jia
On 01/18/2012 05:32 AM, Eric Blake wrote: On 01/17/2012 02:59 AM, a...@redhat.com wrote: From: Alex Jia when everything is okay, 'rv' will be 0, however, 'cleanup' lable only free allocated memory with 'rv< 0', so memory leak on successful path. The patch uses new virTypedParameterArrayClear f

[libvirt] [libvirt-glib 3/3] Correct return type of gvir_storage_pool_create_volume()

2012-01-17 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- libvirt-gobject/libvirt-gobject-storage-pool.c |6 +++--- libvirt-gobject/libvirt-gobject-storage-pool.h |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-storage-pool.c b/libvirt-gobject/libvirt-gob

[libvirt] [libvirt-glib 2/3] Handle failure of virDomainIsPersistent() correctly

2012-01-17 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" virDomainIsPersistent() failing most probably means that domain is no longer available so flaging it as transient isn't exactly wrong. --- libvirt-gobject/libvirt-gobject-domain.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libvirt-gobj

[libvirt] [libvirt-glib 1/3] API to get/set 'description' node in domain config

2012-01-17 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- libvirt-gconfig/libvirt-gconfig-domain.c | 28 libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ libvirt-gconfig/libvirt-gconfig.sym |2 ++ 3 files changed, 32 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/

[libvirt] [PATCHv2 2/2] qemu: eliminate "Ignoring open failure" when using root-squash NFS

2012-01-17 Thread Laine Stump
This eliminates the warning message reported in: https://bugzilla.redhat.com/show_bug.cgi?id=624447 It was caused by a failure to open an image file that is not accessible by root (the uid libvirtd is running as) because it's on a root-squash NFS share, owned by a different user, with permission

[libvirt] [PATCHv2 1/2] util: refactor virFileOpenAs

2012-01-17 Thread Laine Stump
virFileOpenAs previously would only try opening a file as the current user, or as a different user, but wouldn't try both methods in a single call. This made it cumbersome to use as a replacement for open(2). Additionally, it had a lot of historical baggage that led to it being difficult to underst

[libvirt] [PATCHv2 2/2] qemu: eliminate "Ignoring open failure"

2012-01-17 Thread Laine Stump
These patches are a 2nd go at eliminating the warning message described in: https://bugzilla.redhat.com/show_bug.cgi?id=624447 The first round of patches was here: https://www.redhat.com/archives/libvir-list/2012-January/msg00503.html This time I've addressed Eric's concerns from the first

Re: [libvirt] [PATCH] qemu: Prohibit reattaching node device if it is in use

2012-01-17 Thread Eric Blake
On 01/17/2012 01:31 PM, Osier Yang wrote: > It doesn't make sense to reattach a device to host while it's > still in use, e.g, by a domain. > --- > src/qemu/qemu_driver.c | 15 +++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu

Re: [libvirt] [PATCH] qemu: Do not fail if detachment succeeded but failed on resetting device

2012-01-17 Thread Eric Blake
On 01/17/2012 01:46 PM, Osier Yang wrote: > It makes one curious to see error "Failed to detach device" while > the device is detached successfully, only because of it failed > on resetting the device. And on the other hand, failed on resetting > is not the end of world, one could resolve the probl

Re: [libvirt] [PATCH v2] qemu: Introduce inactive PCI device list

2012-01-17 Thread Eric Blake
On 01/17/2012 01:02 PM, Osier Yang wrote: > pciTrySecondaryBusReset checks if there is active device on the > same bus, however, qemu driver doesn't maintain an effective > list for the inactive devices, and it passes meaningless argment s/argment/argument/ > for parameter "inactiveDevs". e.g. (q

Re: [libvirt] [PATCH v2 6/6] qemu: Add ability to abort existing console while creating new one

2012-01-17 Thread Eric Blake
On 12/07/2011 11:08 AM, Peter Krempa wrote: > This patch fixes console corruption, that happens if two concurrent > sessions are opened for a single console on a domain. Result of this > corruption was, that each of the console streams did recieve just a part s/was, that/was that/ s/did recieve/re

Re: [libvirt] [PATCH RFCv2 0/5] LibSSH2 transport for libvirt

2012-01-17 Thread Daniel P. Berrange
On Wed, Jan 04, 2012 at 12:47:36AM +0100, Peter Krempa wrote: > This patchset proposes to use libssh2 as ssh transport option in libvirt > instead of the usual "spawn the client and connect pipes" approach. > > For this to work, you'll need at least libssh2 v 1.3.0. > > This is the second iterati

Re: [libvirt] [PATCH v2 5/6] util: Add helpers for safe domain console operations

2012-01-17 Thread Eric Blake
On 12/07/2011 11:08 AM, Peter Krempa wrote: > This patch adds a set of functions used in creating console streams for > domains using PTYs and ensures mutualy exculsive access to the PTYs. Picking up on my (stalled) review... > +++ b/src/Makefile.am > @@ -101,6 +101,9 @@ UTIL_SOURCES =

Re: [libvirt] [PATCH v2 0/6] Console coruption with two or more clients series

2012-01-17 Thread Eric Blake
On 01/17/2012 02:47 PM, Daniel P. Berrange wrote: > On Wed, Dec 07, 2011 at 07:08:00PM +0100, Peter Krempa wrote: >> This series fixes anoying console corruption if two clients try to connect >> at same time to the console. The current state of this is, that two/more >> of threads compete for the d

Re: [libvirt] [PATCH] Fix startup of LXC containers with filesystems containing symlinks

2012-01-17 Thread Eric Blake
On 01/17/2012 02:40 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Given an LXC guest with a root filesystem path of > > /export/lxc/roots/helloworld/root > > During startup, we will pivot the root filesystem to end up > at > > /.oldroot/export/lxc/roots/helloworld/root >

Re: [libvirt] [PATCH] Permission change for systemtap examples.

2012-01-17 Thread Eric Blake
On 01/17/2012 02:21 PM, Daniel P. Berrange wrote: > On Tue, Jan 17, 2012 at 03:57:41PM +0100, Martin Kletzander wrote: >> Execute bit on *.stp files in examples/systemtap/ caused dependency when >> building RPM packages. Disabling execute permission should help the auto >> dependency resolver to se

Re: [libvirt] [PATCH v4] Add new attribute wrpolicy to element

2012-01-17 Thread Eric Blake
On 01/17/2012 05:44 AM, Deepak C Shetty wrote: > This introduces new attribute wrpolicy with only supported > value as immediate. This will be an optional > attribute with no defaults. This helps specify whether > to skip the host page cache. > > When wrpolicy is specified, meaning when wrpolicy=i

Re: [libvirt] [BUG] EPOLL_CLOEXEC undeclared

2012-01-17 Thread Eric Blake
On 01/17/2012 04:42 AM, Philipp Hahn wrote: >> glibc has supported epoll_create1() and EPOLL_CLOEXEC since glibc 2.9. > > That's the problem on this (old) Debian Lenny system: > # dpkg-query -W libc6-dev > libc6-dev 2.7-18.32.201101241735 And what kernel is that system running? We already

Re: [libvirt] [PATCH v2 0/6] Console coruption with two or more clients series

2012-01-17 Thread Daniel P. Berrange
On Wed, Dec 07, 2011 at 07:08:00PM +0100, Peter Krempa wrote: > This series fixes anoying console corruption if two clients try to connect > at same time to the console. The current state of this is, that two/more > of threads compete for the data from the PTY. This causes that each of the > consol

[libvirt] [PATCH] Fix startup of LXC containers with filesystems containing symlinks

2012-01-17 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Given an LXC guest with a root filesystem path of /export/lxc/roots/helloworld/root During startup, we will pivot the root filesystem to end up at /.oldroot/export/lxc/roots/helloworld/root We then try to open /.oldroot/export/lxc/roots/helloworld/root/dev/pt

Re: [libvirt] [PATCH] remote: avoid memory leak on successful path

2012-01-17 Thread Eric Blake
On 01/17/2012 02:59 AM, a...@redhat.com wrote: > From: Alex Jia > > when everything is okay, 'rv' will be 0, however, 'cleanup' lable only free > allocated memory with 'rv < 0', so memory leak on successful path. The patch > uses new virTypedParameterArrayClear function to free memory instead. >

Re: [libvirt] [RFC PATCH] Add proxy FS (9p) support to libvirt

2012-01-17 Thread Daniel P. Berrange
On Tue, Jan 17, 2012 at 10:48:15AM +0530, M. Mohan Kumar wrote: > From: "M. Mohan Kumar" > > This patch > *) adds new sub element under element. > This sub-element is used to specify the virtfs-proxy-helper binary > (part of QEMU) to be executed when proxy FS driver is used. > > *) invokes pro

Re: [libvirt] [PATCH] Xen: Fix handling

2012-01-17 Thread Daniel P. Berrange
On Tue, Jan 17, 2012 at 05:02:14PM +0100, Philipp Hahn wrote: > For PV, Xen implements the and offset='localtime'> behaviour, while for HV it implements offset='variable'>. > This difference is important for domUs, which switch daylight saving on > there own, since the state is kept inside the V

Re: [libvirt] [PATCH] Permission change for systemtap examples.

2012-01-17 Thread Daniel P. Berrange
On Tue, Jan 17, 2012 at 03:57:41PM +0100, Martin Kletzander wrote: > Execute bit on *.stp files in examples/systemtap/ caused dependency when > building RPM packages. Disabling execute permission should help the auto > dependency resolver to see that systemtap is not needed. > --- > 0 files change

[libvirt] [PATCH] qemu: Do not fail if detachment succeeded but failed on resetting device

2012-01-17 Thread Osier Yang
It makes one curious to see error "Failed to detach device" while the device is detached successfully, only because of it failed on resetting the device. And on the other hand, failed on resetting is not the end of world, one could resolve the problem of resetting outside of libvirt, and do reattac

Re: [libvirt] [PATCH] qemu: Don't break domain with 0:0:2.0 assigned to anything but VGA

2012-01-17 Thread Jiri Denemark
On Tue, Jan 17, 2012 at 12:05:03 -0700, Eric Blake wrote: > On 01/17/2012 08:47 AM, Jiri Denemark wrote: > > In the past we didn't reserve 0:0:2.0 PCI address if there was no video > > device assigned to a domain, which made it impossible to add a video > > device later on. So we fixed it (commit v

[libvirt] [PATCH] qemu: Prohibit reattaching node device if it is in use

2012-01-17 Thread Osier Yang
It doesn't make sense to reattach a device to host while it's still in use, e.g, by a domain. --- src/qemu/qemu_driver.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 47e2380..c920bfd 100644 --- a/src/q

Re: [libvirt] [PATCH v2] qemu: Introduce inactive PCI device list

2012-01-17 Thread Osier Yang
On 2012年01月18日 04:02, Osier Yang wrote: From: root pciTrySecondaryBusReset checks if there is active device on the same bus, however, qemu driver doesn't maintain an effective list for the inactive devices, and it passes meaningless argment for parameter "inactiveDevs". e.g. (qemuPrepareHostdevP

[libvirt] [PATCH v2] qemu: Introduce inactive PCI device list

2012-01-17 Thread Osier Yang
From: root pciTrySecondaryBusReset checks if there is active device on the same bus, however, qemu driver doesn't maintain an effective list for the inactive devices, and it passes meaningless argment for parameter "inactiveDevs". e.g. (qemuPrepareHostdevPCIDevices) if (!(pcidevs = qemuGetPciHos

Re: [libvirt] [PATCH] qemuxml2argvtest: Add /usr/bin to PATH

2012-01-17 Thread Eric Blake
On 01/17/2012 11:31 AM, Michal Privoznik wrote: > On some systems, notably Fedora 16, dirname is located under /usr/bin > making our qemuxml2argvtest fail as we default to /bin; > --- > tests/qemuxml2argvtest.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tests/q

Re: [libvirt] [PATCH] qemu: Don't break domain with 0:0:2.0 assigned to anything but VGA

2012-01-17 Thread Eric Blake
On 01/17/2012 08:47 AM, Jiri Denemark wrote: > In the past we didn't reserve 0:0:2.0 PCI address if there was no video > device assigned to a domain, which made it impossible to add a video > device later on. So we fixed it (commit v0.9.0-37-g7b2cac1) by always > reserving that address. However, th

Re: [libvirt] [PATCH] Fixed dumxml of parameters

2012-01-17 Thread Eric Blake
s/dumxml/dumpxml/ in the subject On 01/17/2012 07:55 AM, Martin Kletzander wrote: > The output of dumpxml for settings was misformatted, this > patch just adds missing newlines. > --- > src/conf/domain_conf.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/c

[libvirt] [PATCH] qemuxml2argvtest: Add /usr/bin to PATH

2012-01-17 Thread Michal Privoznik
On some systems, notably Fedora 16, dirname is located under /usr/bin making our qemuxml2argvtest fail as we default to /bin; --- tests/qemuxml2argvtest.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index d1834f5..96

Re: [libvirt] [PATCH] Remove dmidecode dependancy outside PC arches

2012-01-17 Thread Daniel Veillard
On Tue, Jan 17, 2012 at 04:50:03PM +0100, Jiri Denemark wrote: > On Tue, Jan 17, 2012 at 23:45:10 +0800, Daniel Veillard wrote: > > The new dependancy is only available on ix86, x86_64 and ia64 > > > > diff --git a/libvirt.spec.in b/libvirt.spec.in > > index d06c067..a5bd173 100644 > > --- a/libvi

[libvirt] [PATCH] XenXs: Update documentation

2012-01-17 Thread Philipp Hahn
Fix several references to now renamed functions and parameters when the functions were moved from src/xen/ to src/xenxs/. Signed-off-by: Philipp Hahn --- src/xenxs/xen_sxpr.c | 222 + 1 files changed, 185 insertions(+), 37 deletions(-) diff --git

[libvirt] [PATCH] Xen: Fix handling

2012-01-17 Thread Philipp Hahn
For PV, Xen implements the and behaviour, while for HV it implements . This difference is important for domUs, which switch daylight saving on there own, since the state is kept inside the VM and must be in sync with the RTC provided by Xen. For backward compatibility with previous versions of l

Re: [libvirt] g_error considered harmful

2012-01-17 Thread Christophe Fergeau
On Tue, Jan 17, 2012 at 02:19:47PM +0100, Marc-André Lureau wrote: > On Tue, Jan 17, 2012 at 2:05 PM, Christophe Fergeau > wrote: > > And I forgot to mention that the only remaining use of g_error are in > > gvir_init_object and gvir_init_config where it's probably acceptable to die > > if things

Re: [libvirt] [PATCH] Remove dmidecode dependancy outside PC arches

2012-01-17 Thread Jiri Denemark
On Tue, Jan 17, 2012 at 23:45:10 +0800, Daniel Veillard wrote: > The new dependancy is only available on ix86, x86_64 and ia64 > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index d06c067..a5bd173 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in > @@ -346,8 +346,10 @@ Requires: device-

[libvirt] [PATCH] Remove dmidecode dependancy outside PC arches

2012-01-17 Thread Daniel Veillard
The new dependancy is only available on ix86, x86_64 and ia64 diff --git a/libvirt.spec.in b/libvirt.spec.in index d06c067..a5bd173 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -346,8 +346,10 @@ Requires: device-mapper %if %{with_cgconfig} Requires: libcgroup %endif +%ifarch i386 i586

[libvirt] [PATCH] qemu: Don't break domain with 0:0:2.0 assigned to anything but VGA

2012-01-17 Thread Jiri Denemark
In the past we didn't reserve 0:0:2.0 PCI address if there was no video device assigned to a domain, which made it impossible to add a video device later on. So we fixed it (commit v0.9.0-37-g7b2cac1) by always reserving that address. However, that breaks existing domains without video devices that

[libvirt] [PATCH] Permission change for systemtap examples.

2012-01-17 Thread Martin Kletzander
Execute bit on *.stp files in examples/systemtap/ caused dependency when building RPM packages. Disabling execute permission should help the auto dependency resolver to see that systemtap is not needed. --- 0 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 examples/sys

[libvirt] [PATCH] Fixed dumxml of parameters

2012-01-17 Thread Martin Kletzander
The output of dumpxml for settings was misformatted, this patch just adds missing newlines. --- src/conf/domain_conf.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d474551..f84e76d 100644 --- a/src/conf/domain_co

Re: [libvirt] g_error considered harmful

2012-01-17 Thread Zeeshan Ali (Khattak)
On Tue, Jan 17, 2012 at 3:19 PM, Marc-André Lureau wrote: > On Tue, Jan 17, 2012 at 2:05 PM, Christophe Fergeau > wrote: >> And I forgot to mention that the only remaining use of g_error are in >> gvir_init_object and gvir_init_config where it's probably acceptable to die >> if things didn't wor

Re: [libvirt] g_error considered harmful

2012-01-17 Thread Marc-André Lureau
On Tue, Jan 17, 2012 at 2:05 PM, Christophe Fergeau wrote: > And I forgot to mention that the only remaining use of g_error are in > gvir_init_object and gvir_init_config where it's probably acceptable to die > if things didn't work as expected. Not really, it would be better to return an error.

Re: [libvirt] g_error considered harmful

2012-01-17 Thread Christophe Fergeau
On Mon, Jan 16, 2012 at 03:01:00PM +0100, Christophe Fergeau wrote: > Hi, > > g_error calls abort() when it's called, thus it should only be used for > bad assertion failures. We currently are using it in some places in > libvirt-gobject as if it was g_warning. This patch series gets rid of most >

Re: [libvirt] [PATCH v3] Add new attribute wrpolicy to element

2012-01-17 Thread Deepak C Shetty
Hello Eric, Posted v4 of this patch with your comments implemented at ... https://www.redhat.com/archives/libvir-list/2012-January/msg00633.html thanx, deepak -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v4] Add new attribute wrpolicy to element

2012-01-17 Thread Deepak C Shetty
This introduces new attribute wrpolicy with only supported value as immediate. This will be an optional attribute with no defaults. This helps specify whether to skip the host page cache. When wrpolicy is specified, meaning when wrpolicy=immediate a writeback is explicitly initiated for the dirty

[libvirt] [PATCH 4/4] Allow choice of shutdown method via virsh

2012-01-17 Thread Michal Privoznik
Extend the 'shutdown' and 'reboot' methods so that they both accept a new argument --mode acpi|agent * tools/virsh.c: New args for shutdown/reboot * tools/virsh.pod: Document new args --- tools/virsh.c | 47 +-- tools/virsh.pod | 24 +

[libvirt] [PATCH 1/4] QEMU guest agent support

2012-01-17 Thread Michal Privoznik
There is now a standard QEMU guest agent that can be installed and given a virtio serial channel The protocol that runs over the guest agent is JSON based and very similar to the JSON monitor. We can't use exactly the same code because there are some odd differences in the

[libvirt] [PATCH 2/4] Add new virDomainShutdownFlags API

2012-01-17 Thread Michal Privoznik
Add a new API virDomainShutdownFlags and define: VIR_DOMAIN_SHUTDOWN_DEFAULT= 0, VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN = (1 << 0), VIR_DOMAIN_SHUTDOWN_GUEST_AGENT= (1 << 1), Also define some flags for the reboot API VIR_DOMAIN_REBOOT_DEFAULT= 0, VIR_DOMAIN_RE

[libvirt] [PATCH 3/4] Wire up QEMU agent to reboot/shutdown APIs

2012-01-17 Thread Michal Privoznik
This makes use of the QEMU guest agent to implement the virDomainShutdownFlags and virDomainReboot APIs. With no flags specified, it will prefer to use the agent, but fallback to ACPI. Explicit choice can be made by using a suitable flag * src/qemu/qemu_driver.c: Wire up use of agent --- src/qemu

[libvirt] [PATCH 0/4] Add support for QEMU guest agent control

2012-01-17 Thread Michal Privoznik
These patches are taken from here: https://www.redhat.com/archives/libvir-list/2011-October/msg00135.html I've just rebased and polished them. The QEMU guest agent "/usr/bin/qemu-ga" has some handy functions for controlling the guest, not least, shutdown/reboot and filesystem freeze/tha

Re: [libvirt] [BUG] EPOLL_CLOEXEC undeclared

2012-01-17 Thread Philipp Hahn
Hello Eric, thank you for taking a look at my problem. On Monday 16 January 2012 16:36:00 Eric Blake wrote: > On 01/16/2012 08:07 AM, Philipp Hahn wrote: > > $ dpkg-query -W linux-libc-dev > > linux-libc-dev 2.6.32-35~ucs1.48.201109051614 > > glibc has supported epoll_create1() and EPOLL_CLOEXEC

Re: [libvirt] [PATCH v3] Add new attribute wrpolicy to element

2012-01-17 Thread Deepak C Shetty
Please add a new pair of test files to tests/qemuxml2argvdata (both .xml and .args file) to validate the RNG, as well as listing that file name in tests/qemuxml2argvtest.c to validate the qemu command line generation (I find it easiest to start from an existing similar .xml file, and just add in

Re: [libvirt] [PATCH v2 0/6] Enhancements in CPU selection

2012-01-17 Thread Jiri Denemark
On Thu, Jan 12, 2012 at 12:02:54 +0100, Jiri Denemark wrote: > The main goal of this series is to provide an easy way to say that a guest CPU > should match host. Details can be found in individual patches. > > Jiri Denemark (6): > tests: Print XML file name in verbose CPU test > cpu: Optional

Re: [libvirt] [RFC PATCH 0/6] New API to normalize the device XML

2012-01-17 Thread Osier Yang
On 2012年01月10日 06:53, Eric Blake wrote: On 01/09/2012 07:37 AM, Daniel P. Berrange wrote: On Mon, Jan 09, 2012 at 10:29:08PM +0800, Osier Yang wrote: The initial purpose was to fix a regression for detaching device, (introduced by commit ea7182c29). There was a patch posted to resolve the probl

[libvirt] [PATCH] remote: avoid memory leak on successful path

2012-01-17 Thread ajia
From: Alex Jia when everything is okay, 'rv' will be 0, however, 'cleanup' lable only free allocated memory with 'rv < 0', so memory leak on successful path. The patch uses new virTypedParameterArrayClear function to free memory instead. * src/remote/remote_driver.c: fix memory leak on remoteDe

Re: [libvirt] [PATCH] Clarify semantics of virDomainMigrate{, ToURI}2

2012-01-17 Thread Jiri Denemark
On Mon, Jan 16, 2012 at 11:33:52 -0700, Eric Blake wrote: > On 01/16/2012 03:19 AM, Jiri Denemark wrote: > > Commit 5d784bd6d7b19314b0908aec6b46bfe377aeba42 was a nice attempt to > > clarify the semantics by requiring domain name from dxml to either match > > original name or dname. However, settin

Re: [libvirt] [libvirt-glib] Make use of G_PARAM_STATIC_STRINGS everywhere

2012-01-17 Thread Christophe Fergeau
On Tue, Jan 17, 2012 at 05:25:44AM +0200, Zeeshan Ali (Khattak) wrote: > On Fri, Jan 13, 2012 at 11:01 AM, Christophe Fergeau > wrote: > > G_PARAM_STATIC_STRINGS was added in glib 2.13, configure.ac only check for > > glib 2.10 at the moment. The patch looks good, but please wait until we > > make

Re: [libvirt] [PATCH v2] docs: Add missed RNG schema for interface

2012-01-17 Thread Osier Yang
On 2012年01月17日 16:51, Daniel Veillard wrote: On Mon, Jan 16, 2012 at 10:08:07PM +0800, Osier Yang wrote: We support of type "mcast", "server", and "client", but the RNG schema for them are missed. Attribute "address" is optional for "server" type. And these 3 types support , too. --- docs/for

Re: [libvirt] [PATCH v2] docs: Add missed RNG schema for interface

2012-01-17 Thread Daniel Veillard
On Mon, Jan 16, 2012 at 10:08:07PM +0800, Osier Yang wrote: > We support of type "mcast", "server", and "client", > but the RNG schema for them are missed. Attribute "address" is > optional for "server" type. And these 3 types support > , too. > --- > docs/formatdomain.html.in