On Mon, Jan 23, 2012 at 14:11:10 +0100, Paolo Bonzini wrote:
Creating part of the -cpu command-line from something other than the
cpu XML element introduces some ugliness.
Well, that's what we get for creating virtual CPUID features :-)
---
src/qemu/qemu_command.c
The 23/01/12, Daniel P. Berrange wrote:
On Mon, Jan 23, 2012 at 04:41:43PM +0100, Nicolas Sebrecht wrote:
The 23/01/12, Michal Privoznik wrote:
+By default the hypervisor will try to pick a suitable shutdown
+method. To specify an alternative method, the I--mode parameter
+can
On Mon, Jan 23, 2012 at 11:31:57PM +0200, Zeeshan Ali (Khattak) wrote:
On Mon, Jan 23, 2012 at 7:19 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Based on a patch from Zeeshan Ali (Khattak) zeesha...@gnome.org
Looks good! I'll test it later
I've only compile-tested it, if it doesn't
On Mon, Jan 23, 2012 at 05:20:50PM -0700, Eric Blake wrote:
On 01/23/2012 03:29 PM, Marc-André Lureau wrote:
Hi,
I tried to update the fedora mingw package to follow the mingw64
packaging guideline and allow build for x86 and x64. But I got into
build warning and errors for x86_64.
On 01/24/2012 06:19 AM, Michal Privoznik wrote:
Therefore I am pushing this under trivial and build-breaker rules (yeah,
one thing - and perhaps the only one - i like about 4.6 gcc is enhanced
static analysis as I spotted warning while compiling current HEAD):
Author: Michal
On 18.01.2012 17:20, Stefan Berger wrote:
+
+static int
+testHashEqual(const void *data ATTRIBUTE_UNUSED)
+{
+virHashTablePtr hash1, hash2;
+int ret = -1;
+char keya[] = a;
+char keyb[] = b;
+char keyc[] = c;
+char value1[] = 1;
+char value2[] = 2;
+char
On 23.01.2012 15:48, Michal Privoznik wrote:
These patches are taken from here:
https://www.redhat.com/archives/libvir-list/2011-October/msg00135.html
I've just rebased and polished them.
The QEMU guest agent /usr/bin/qemu-ga has some handy functions
for controlling the guest,
Thanks for these comments.
I will refactor the loop code, rethink about other codes and make v3 patch.
Guannan Ren
- Original Message -
From: Eric Blake ebl...@redhat.com
To: Guannan Ren g...@redhat.com
Cc: libvir-list@redhat.com
Sent: Saturday, January 21, 2012 11:04:15 PM
Signed-off-by: Alon Levy al...@redhat.com
---
src/datatypes.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/datatypes.h b/src/datatypes.h
index 91b1bfd..47058ed 100644
--- a/src/datatypes.h
+++ b/src/datatypes.h
@@ -31,7 +31,7 @@
* VIR_CONNECT_MAGIC:
*
*
On 01/24/2012 05:07 AM, Guan Nan Ren wrote:
static PyObject *
+libvirt_virDomainSetNumaParameters(PyObject *self ATTRIBUTE_UNUSED,
+ PyObject *args) {
+LIBVIRT_BEGIN_ALLOW_THREADS;
+i_retval = virDomainGetNumaParameters(domain, params, nparams,
On 24.01.2012 13:45, Alon Levy wrote:
Signed-off-by: Alon Levy al...@redhat.com
---
src/datatypes.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/datatypes.h b/src/datatypes.h
index 91b1bfd..47058ed 100644
--- a/src/datatypes.h
+++ b/src/datatypes.h
@@
One more parameter added into the function parsing /proc/pid/stat
and the call of the function is fixed as well.
---
v2:
- correction of the format in fscanf in qemudGetProcessInfo
src/qemu/qemu_driver.c | 25 ++---
1 files changed, 18 insertions(+), 7 deletions(-)
diff
On Mon, Jan 23, 2012 at 17:21:01 +0100, Paolo Bonzini wrote:
On 01/23/2012 04:52 PM, Jiri Denemark wrote:
I think we could just set cpu-model even if the model used in qemu command
line was {qemu,kvm}{32,64}. That would probably mean we need to add some of
the models in cpu_map.xml, though.
Added RSS information gathering into qemuMemoryStats into qemu driver
and the reporting into virsh dommemstat.
---
v2:
- fixed sign for the ret variable (can be negative)
include/libvirt/libvirt.h.in |7 ++-
src/qemu/qemu_driver.c | 23 ++-
tools/virsh.c
On 01/24/2012 02:28 PM, Jiri Denemark wrote:
The idea is that, if you were using -cpu just to set -cpu
{qemu,kvm}{32,64},-kvmclock, you will not get an irrelevant
cpumodelqemu32/model/cpu in domxml-from-native output.
Yeah, I understand why you did so, however, you just discard
The idea is that currently we have only the domain name usable as
a description for the domain. It is not really a good human readable
identifier, as the kind of string allowed is limited (no space for
example). The idea would then be to extend the existing description
field in the domain XML to
On 01/24/2012 07:18 AM, Daniel Veillard wrote:
The idea is that currently we have only the domain name usable as
a description for the domain. It is not really a good human readable
identifier, as the kind of string allowed is limited (no space for
example). The idea would then be to extend
On Tue, Jan 24, 2012 at 08:06:31AM -0700, Eric Blake wrote:
On 01/24/2012 07:18 AM, Daniel Veillard wrote:
The idea is that currently we have only the domain name usable as
a description for the domain. It is not really a good human readable
identifier, as the kind of string allowed is
POLLIN and POLLHUP are not mutually exclusive. Currently the following
seems possible: the child writes 3K to its stdout or stderr pipe, and
immediately closes it. We get POLLIN|POLLHUP (I'm not sure that's possible
on Linux, but SUSv4 seems to allow it). We read 1K and throw away the
rest.
When
- Original Message -
From: Jiri Denemark jdene...@redhat.com
To: libvir-list@redhat.com
Sent: Monday, January 23, 2012 2:30:54 PM
Subject: [libvirt] [PATCH 1/4] virDomainIOError public API and remote protocol
We already provide ways to detect when a domain has been paused as a
These functions simply issue command to guest agent which
should freeze or unfreeze all file systems within guest.
---
src/qemu/qemu_agent.c | 68 +
src/qemu/qemu_agent.h |3 ++
2 files changed, 71 insertions(+), 0 deletions(-)
diff --git
With this flag, virDomainSnapshotCreate will use fs-freeze and
fs-thaw guest agent commands to quiesce guest's disks.
---
include/libvirt/libvirt.h.in |4 ++
src/libvirt.c|6 ++
src/qemu/qemu_driver.c | 118 -
3 files changed,
Since we have qemu guest agent support in libvirt,
we can start wiring up some things that GA already
knows how to do. One of them is file system freeze
and thaw. Domain snapshots can profit from this
functionality.
Michal Privoznik (3):
qemu_agent: Create file system freeze and thaw functions
to cmdSnapshotCreate and cmdSnapshotCreateAs.
---
tools/virsh.c |6 ++
tools/virsh.pod | 14 --
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 5560988..41c 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -14662,6
On Tue, Jan 24, 2012 at 11:57:23 -0500, Federico Simoncelli wrote:
+/**
+ * virDomainIoError:
+ *
+ * Disk I/O error.
+ */
+typedef enum {
+VIR_DOMAIN_IOERROR_NONE = 0, /* no error */
+VIR_DOMAIN_IOERROR_NO_SPACE = 1, /* no space left on the device
*/
+
On Tue, Jan 24, 2012 at 18:37:43 +0100, Michal Privoznik wrote:
These functions simply issue command to guest agent which
should freeze or unfreeze all file systems within guest.
---
src/qemu/qemu_agent.c | 68
+
src/qemu/qemu_agent.h |
On 01/11/2012 09:33 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
For the sake of backwards compat, LXC guests are *not*
confined by default. This is because it is not practical
to dynamically relabel containers using large filesystem
trees. Applications can
On 24.01.2012 19:21, Jiri Denemark wrote:
On Tue, Jan 24, 2012 at 18:37:43 +0100, Michal Privoznik wrote:
+
+if (qemuAgentCommand(mon, cmd, reply) 0 ||
+qemuAgentCheckError(cmd, reply) 0)
+goto cleanup;
+
+virJSONValueObjectGetNumberInt(reply, return, ret);
On Tue, Jan 24, 2012 at 18:37:44 +0100, Michal Privoznik wrote:
With this flag, virDomainSnapshotCreate will use fs-freeze and
fs-thaw guest agent commands to quiesce guest's disks.
---
include/libvirt/libvirt.h.in |4 ++
src/libvirt.c|6 ++
src/qemu/qemu_driver.c
Systemd detects containers based on whether they have
an environment variable starting with 'container=lxc';
using a longer name fits the expectations, while also
allowing detection of who created the container.
Requested by Lennart Poettering, in response to
On Tue, Jan 24, 2012 at 18:37:45 +0100, Michal Privoznik wrote:
to cmdSnapshotCreate and cmdSnapshotCreateAs.
---
tools/virsh.c |6 ++
tools/virsh.pod | 14 --
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
On 24.01.2012 19:57, Jiri Denemark wrote:
On Tue, Jan 24, 2012 at 18:37:45 +0100, Michal Privoznik wrote:
to cmdSnapshotCreate and cmdSnapshotCreateAs.
---
tools/virsh.c |6 ++
tools/virsh.pod | 14 --
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git
On 24.01.2012 19:49, Jiri Denemark wrote:
On Tue, Jan 24, 2012 at 18:37:44 +0100, Michal Privoznik wrote:
With this flag, virDomainSnapshotCreate will use fs-freeze and
fs-thaw guest agent commands to quiesce guest's disks.
---
include/libvirt/libvirt.h.in |4 ++
src/libvirt.c
These functions simply issue command to guest agent which
should freeze or unfreeze all file systems within guest.
---
src/qemu/qemu_agent.c | 74 +
src/qemu/qemu_agent.h |3 ++
2 files changed, 77 insertions(+), 0 deletions(-)
diff --git
Since we have qemu guest agent support in libvirt,
we can start wiring up some things that GA already
knows how to do. One of them is file system freeze
and thaw. Domain snapshots can profit from this
functionality.
Michal Privoznik (3):
qemu_agent: Create file system freeze and thaw functions
With this flag, virDomainSnapshotCreate will use fs-freeze and
fs-thaw guest agent commands to quiesce guest's disks.
---
include/libvirt/libvirt.h.in |4 ++
src/libvirt.c|6 +++
src/qemu/qemu_driver.c | 87 ++
3 files
to cmdSnapshotCreate and cmdSnapshotCreateAs.
---
tools/virsh.c |6 ++
tools/virsh.pod | 16 ++--
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 5560988..41c 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -14662,6
On 01/11/2012 09:33 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
To allow the container to access /dev and /dev/pts when under
sVirt, set an explicit mount option. Also set a max size on
the /dev mount to prevent DOS on memory usage
* src/lxc/lxc_container.c:
On 01/24/2012 01:21 PM, Eric Blake wrote:
+if (virAsprintf(opts, mode=755,size=65536%%%s%s%s,
+con ? ,context=\ : ,
+con ? (const char *)con : ,
+con ? \ : ) 0) {
I would have split this:
if
Direct boot (using kernel, initrd, and command line) is used by
virt-install/virt-manager for network install. While any bootindex has
no direct effect since -kernel is always first, we need it as a hint for
SeaBIOS to present disks in the same order as they will be presented
during normal boot.
On 01/24/2012 03:53 PM, Jiri Denemark wrote:
Direct boot (using kernel, initrd, and command line) is used by
virt-install/virt-manager for network install. While any bootindex has
no direct effect since -kernel is always first, we need it as a hint for
SeaBIOS to present disks in the same
I am happy that you provide the patches.
These functions simply issue command to guest agent which
should freeze or unfreeze all file systems within guest.
---
src/qemu/qemu_agent.c | 74 +
src/qemu/qemu_agent.h |3 ++
2 files changed,
On 01/24/2012 04:17 PM, MATSUDA, Daiki wrote:
I am happy that you provide the patches.
These functions simply issue command to guest agent which
should freeze or unfreeze all file systems within guest.
---
But qemuAgentFSFreeze() and qemuAgentFSThaw() are almost same. In
addition, qemu
On 01/23/2012 07:26 PM, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Applications can now insert custom nodes and hierarchies into domain
cofiguration XML. Although currently not enforced, application are
s/cofiguration/configuration/
s/application
Noticed while reviewing the previous patch; thankfully, there
are no violations.
* cfg.mk (useless_free_options): Add xmlFreeNode.
---
+if (def-metadata)
+xmlFreeNode(def-metadata);
Useless use of if before free, since xmlFreeNode is documented as a
no-op on NULL. I'll update
It's better to group all the metadata together. This is a
cosmetic output change; since the RNG allows interleave, it
doesn't matter where the user stuck it on input, and an XPath
query will find it in the same location when parsing the output.
* src/conf/domain_conf.c
On Wed, Jan 25, 2012 at 2:28 AM, Eric Blake ebl...@redhat.com wrote:
It's better to group all the metadata together. This is a
cosmetic output change; since the RNG allows interleave, it
doesn't matter where the user stuck it on input, and an XPath
query will find it in the same location when
On 01/24/2012 05:49 PM, Zeeshan Ali (Khattak) wrote:
On Wed, Jan 25, 2012 at 2:28 AM, Eric Blake ebl...@redhat.com wrote:
It's better to group all the metadata together. This is a
cosmetic output change; since the RNG allows interleave, it
doesn't matter where the user stuck it on input, and
---
Pushed under the trivial rule.
docs/formatdomain.html.in | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index dca9a81..dfb010d 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@
On Tue, Jan 24, 2012 at 08:06:31AM -0700, Eric Blake wrote:
On 01/24/2012 07:18 AM, Daniel Veillard wrote:
The idea is that currently we have only the domain name usable as
a description for the domain. It is not really a good human readable
identifier, as the kind of string allowed is
50 matches
Mail list logo
