Re: [libvirt] [PATCHv3 2/2] conf: allow fuzz in XML with cur balloon > max

2012-03-31 Thread Eric Blake
On 03/31/2012 10:22 AM, Zhou Peng wrote: > Thank you! > ACK patch serials > > On Sat, Mar 31, 2012 at 11:33 PM, Eric Blake wrote: >> Commit 1b1402b introduced a regression. Since older libvirt versions >> would silently round memory up (until the previous patch), but populated >> current memory

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-31 Thread Laine Stump
On 03/31/2012 07:56 AM, Daniel Veillard wrote: > I just made the second release candidate > > ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz > > along with the rpms and tagged the git tree. > > It seems to work okay in my limited testing. If all goes well I would > probably push on Tuesday

Re: [libvirt] [PATCHv3 2/2] conf: allow fuzz in XML with cur balloon > max

2012-03-31 Thread Zhou Peng
Thank you! ACK patch serials On Sat, Mar 31, 2012 at 11:33 PM, Eric Blake wrote: > Commit 1b1402b introduced a regression.  Since older libvirt versions > would silently round memory up (until the previous patch), but populated > current memory based on querying the guest, it was possible to have

[libvirt] [PATCHv3 2/2] conf: allow fuzz in XML with cur balloon > max

2012-03-31 Thread Eric Blake
Commit 1b1402b introduced a regression. Since older libvirt versions would silently round memory up (until the previous patch), but populated current memory based on querying the guest, it was possible to have dumpxml show cur > max by the amount of the rounding. For example, if a user requested

Re: [libvirt] [PATCH] python: improve conversion validation

2012-03-31 Thread Eric Blake
On 03/31/2012 01:36 AM, Osier Yang wrote: > On 03/31/2012 02:49 AM, Eric Blake wrote: >> Laszlo Ersek pointed out that in trying to convert a long to an >> unsigned int, we used: >> >> long long_val = ...; >> if ((unsigned int)long_val == long_val) >> >> Fix this by using direct comparisons, rathe

Re: [libvirt] [PATCHv2 2/2] conf: allow fuzz in XML with cur balloon > max

2012-03-31 Thread Eric Blake
On 03/31/2012 01:19 AM, Osier Yang wrote: > On 03/30/2012 11:56 PM, Eric Blake wrote: >> Commit 1b1402b introduced a regression. Since older libvirt versions >> would silently round memory up (until the previous patch), but populated >> current memory based on querying the guest, it was possible t

Re: [libvirt] [PATCHv2 2/2] conf: allow fuzz in XML with cur balloon > max

2012-03-31 Thread Eric Blake
On 03/30/2012 08:36 PM, Zhou Peng wrote: > Thanks for your patch serials. > I think they fix the true bug. > > But I have a little doubt on the fuzz allowance, pls have a see > comment in line below. > >> if (def->mem.cur_balloon > def->mem.max_balloon) { >> -virDomainReportError(VIR

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-31 Thread Justin Clift
On 31/03/2012, at 10:56 PM, Daniel Veillard wrote: > I juts made the second release candidate > > ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz > > along with the rpms and tagged the git tree. > > It seems to work okay in my limited testing. If all goes well I would > probably push on Tu

[libvirt] [PATCH] Fix client only RPM build & other misc RPM problems

2012-03-31 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Pushing under build break rule - some misc problems discovered while doing the RPM refactoring * libvirt.spec.in: Remove obsolete --with-remote-pid-file arg. Add missing %{without_libxl} statement. Fix handling of docs in client only build. Put systemtap files in -

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-31 Thread Daniel Veillard
On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote: > As scheduled, we are entering the freeze for 0.9.11. > I think most API additions are now commited to git upstream (please > raise your voice quickly if you see something missing !) > > I have made a release candidate 1 tarball (

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-31 Thread Daniel Veillard
On Mon, Mar 26, 2012 at 09:18:53AM +0200, Philipp Hahn wrote: > Hello, > > On Monday 26 March 2012 04:32:23 Daniel Veillard wrote: > > As scheduled, we are entering the freeze for 0.9.11. > > I think most API additions are now commited to git upstream (please > > raise your voice quickly if you

Re: [libvirt] [PATCH] Refactor the libvirt RPM daemon pieces

2012-03-31 Thread Daniel P. Berrange
On Fri, Mar 30, 2012 at 04:40:09PM -0600, Eric Blake wrote: > On 03/30/2012 10:53 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > There are a number of flaws with our packaging of the libvirtd > > daemon: > > > > > + > > +%if %{with_libvirtd} > > +%package daemon > > +Summa