Re: [libvirt] [test-API PATCH 3/3] comments change according to previous two patches

2012-04-10 Thread Guannan Ren
On 04/10/2012 11:56 AM, Osier Yang wrote: repos/domain/destroy.py repos/domain/resume.py repos/domain/shutdown.py repos/domain/start.py repos/domain/suspend.py --- repos/domain/destroy.py |2 +- repos/domain/resume.py |2 +- repos/domain/shutdown.py |2

Re: [libvirt] [test-API PATCH 1/3] test-API: Get rid of utils/Python

2012-04-10 Thread Guannan Ren
On 04/10/2012 11:56 AM, Osier Yang wrote: test-API tends to only support testing via libvirt Python binding now, and moving it to utils makes sense. --- utils/{Python = }/XMLParser.py|0 utils/{Python = }/check.py|0 utils/{Python = }/env_parser.py |0

Re: [libvirt] [test-API PATCH 2/3] test-API: Replace utils.Python with utils

2012-04-10 Thread Guannan Ren
On 04/10/2012 11:56 AM, Osier Yang wrote: for i in $(find . -type f -name *.py); do \ sed -i -e 's/utils\.Python/utils/g' $i; \ done --- env_clear.py |2 +- generator.py |6 +++--- libvirt-test-api.py

[libvirt] [test-API PATCH 3/5] test-API: Substitute utils.Utils with utils

2012-04-10 Thread Osier Yang
$ for i in $(find . -type f -name *.py); do \ sed -i -e 's/utils\.Utils()/utils/g' $i; \ done --- repos/domain/cpu_affinity.py |2 +- utils/xmlgenerator.py| 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/repos/domain/cpu_affinity.py

[libvirt] [test-API PATCH 5/5] testcase: remove useless utils import

2012-04-10 Thread Osier Yang
--- repos/domain/autostart.py|1 - repos/domain/blkstats.py |1 - repos/domain/console_mutex.py|1 - repos/domain/domain_blkinfo.py |1 - repos/domain/domain_id.py|1 - repos/domain/domain_uuid.py

[libvirt] [test-API PATCH 2/5] test-API: Remove the codes used to construct utils object

2012-04-10 Thread Osier Yang
$ for i in $(find . -type f -name *.py); do \ sed -i -e '/util *= *utils\.Utils()/d' $i; \ done --- repos/domain/attach_disk.py|1 - repos/domain/attach_interface.py |1 - repos/domain/autostart.py |1 -

[libvirt] [test-API PATCH 0/5] Destroy class definition in utils.py

2012-04-10 Thread Osier Yang
These five patches are to change utils.py into a collection of functions. And cleanup all of existing testcase to use the functions in it directly. (1) Destroy Utils class definition (2) Remove util = utils.Utils() (3) Substitue util. with utils. (4) Remove useless utils import from utils

[libvirt] [test-API PATCH 1/5] test-API: Destroy the class for utils.py

2012-04-10 Thread Osier Yang
IMHO there is not any benifit to use class in a utils script, except you have to construct the object again and again in scripts. :-) Incidental cleanups: * s/parser_uri/parse_uri/ * s/#this/# This/ * Useless comments on the top are removed. --- utils/utils.py | 769

[libvirt] [PATCH 0/2 v2] use qemu's dump-guest-meory when vm uses host device

2012-04-10 Thread Wen Congyang
Currently, we use migrate to dump guest's memory. There is one restriction in migrate command: the device's status should be stored in qemu because the device's status should be passed to target machine. If we passthrough a host device to guest, the device's status is stored in the real device.

[libvirt] [PATCH 2/2 v2] qemu: try to use qemu's dump-guest-meory when vm uses host device

2012-04-10 Thread Wen Congyang
--- src/qemu/qemu_domain.c |1 + src/qemu/qemu_domain.h |1 + src/qemu/qemu_driver.c | 42 -- 3 files changed, 42 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 69d9e6e..e3a668a 100644 ---

Re: [libvirt] xen-hypervisor: GetVcpus may not find a certain domain

2012-04-10 Thread Stefan Bader
On 04/08/2012 03:19 PM, Cole Robinson wrote: On 04/02/2012 10:38 AM, Stefan Bader wrote: xen-hypervisor: GetVcpus may not find a certain domain Observed on connections that have been running and then shut down. The hypervisor subdriver fills the log with internal errors while the xend driver

Re: [libvirt] xend_internal: Use domain/status for shutdown check

2012-04-10 Thread Stefan Bader
On 04/08/2012 03:08 PM, Cole Robinson wrote: On 04/02/2012 10:38 AM, Stefan Bader wrote: xend_internal: Use domain/status for shutdown check On newer xend (v3.x and after) there is no state and domid reported for inactive domains. When initially creating connections this is handled in

[libvirt] [PATCH 1/2 v2] qemu: implement qemu's dump-guest-memory

2012-04-10 Thread Wen Congyang
--- src/qemu/qemu_monitor.c | 36 src/qemu/qemu_monitor.h | 13 + src/qemu/qemu_monitor_json.c | 42 ++ src/qemu/qemu_monitor_json.h |7 +++ 4 files changed, 98 insertions(+), 0

Re: [libvirt] Should we always dump an usb controlled in XML domains

2012-04-10 Thread Daniel P. Berrange
On Tue, Apr 10, 2012 at 11:58:52AM +0800, Daniel Veillard wrote: I realize that we have that behaviour for quite some times but I wonder about it, basically we always dump an usb controller on the XML domain format: controller type='usb' index='0'/ even if there is no USB device

Re: [libvirt] [PATCH 4/4] Replace daemon-conf test script with a proper test case

2012-04-10 Thread Daniel P. Berrange
On Fri, Apr 06, 2012 at 11:05:02AM -0600, Eric Blake wrote: On 04/04/2012 08:07 AM, Daniel P. Berrange wrote: + +//VIR_DEBUG(New config [%s], newdata); Did you mean to leave this commented? Yes, it makes the debug output far too verbose. Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH] Fix compilation error on 32bit

2012-04-10 Thread Stefan Berger
On 04/09/2012 12:23 PM, Eric Blake wrote: On 04/06/2012 01:13 PM, Stefan Berger wrote: Below code failed to compile on a 32 bit machine with error typewrappers.c: In function 'libvirt_intUnwrap': typewrappers.c:135:5: error: logical 'and' of mutually exclusive tests is always false

[libvirt] [PATCH] virsh: Clarify use of the --managed-save flag for the list command

2012-04-10 Thread Peter Krempa
The documentation for the flag doesn't clearly state that the flag only enhances the output and the user needs to specify other flags to list inactive domains, that are enhanced by this flag. --- tools/virsh.c |2 +- tools/virsh.pod |5 +++-- 2 files changed, 4 insertions(+), 3

Re: [libvirt] Memory leak in libvirt / gnutls

2012-04-10 Thread Daniel P. Berrange
On Tue, Apr 10, 2012 at 12:08:14PM +0100, Richard W.M. Jones wrote: On Mon, Apr 09, 2012 at 10:19:38AM -0600, Eric Blake wrote: On 04/07/2012 03:33 AM, Richard W.M. Jones wrote: However the above commit is later amended by this commit:

[libvirt] [PATCH] Fix comment about GNUTLS initialization/cleanup

2012-04-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- src/rpc/virnettlscontext.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 74a61e0..7440c7a 100644 --- a/src/rpc/virnettlscontext.c +++

Re: [libvirt] [test-API PATCH 1/2] sharedmod: Add a new file for variable sharing in testcases

2012-04-10 Thread Martin Kletzander
On 04/06/2012 11:14 AM, Guannan Ren wrote: sharedmod.py: in root directory --- sharedmod.py | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 sharedmod.py diff --git a/sharedmod.py b/sharedmod.py new file mode 100644 index 000..f3de5a6

[libvirt] [PATCH] tests: Fix libvirtdconftest in VPATH build

2012-04-10 Thread Jiri Denemark
Without this, libvirtdconftest fails to build with fatal error: daemon/libvirtd-config.h: No such file or directory --- tests/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 57358e9..c4d550f 100644 ---

Re: [libvirt] help for libvirt0.9.8 compile

2012-04-10 Thread Arjun Asok Nair
Hi Alex, I am stuck here too. Where you able to resolve the issue? I tried installing libdevmapper-devel it gave dependency error for libdevmapper and then that gave dependency error of libc.so.6. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] libvirt starts KVM domain without -enable-kvm

2012-04-10 Thread Reinier Schoof
Hey, we're running a VM-pool based on libvirt and QEMU/KVM. The host machines run debian 6 (squeeze). All VM's have a similar libvirt XML-definition. Since we've moved to the combination of Linux kernel 3.2.0-1 and libvirt 0.9.9 (installed from testing/wheezy repo's), we periodically notice

Re: [libvirt] [PATCH] tests: Fix libvirtdconftest in VPATH build

2012-04-10 Thread Daniel P. Berrange
On Tue, Apr 10, 2012 at 02:12:01PM +0200, Jiri Denemark wrote: Without this, libvirtdconftest fails to build with fatal error: daemon/libvirtd-config.h: No such file or directory --- tests/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [test-API PATCH 1/2] sharedmod: Add a new file for variable sharing in testcases

2012-04-10 Thread Guannan Ren
On 04/10/2012 07:28 PM, Martin Kletzander wrote: On 04/06/2012 11:14 AM, Guannan Ren wrote: sharedmod.py: in root directory --- sharedmod.py | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 sharedmod.py diff --git a/sharedmod.py

Re: [libvirt] [PATCH] virsh: Clarify use of the --managed-save flag for the list command

2012-04-10 Thread Eric Blake
On 04/10/2012 04:35 AM, Peter Krempa wrote: The documentation for the flag doesn't clearly state that the flag only enhances the output and the user needs to specify other flags to list inactive domains, that are enhanced by this flag. --- tools/virsh.c |2 +- tools/virsh.pod |5

[libvirt] [PATCH] virsh: Clean up usage of boolean flag variables

2012-04-10 Thread Peter Krempa
This patch cleans up variables used to store boolean command flags that are inquired by vshCommandOptBool to use the bool data type instead of an integer. Additionaly this patch cleans up flag variables that are inferred from existing flags. --- tools/virsh.c | 120

Re: [libvirt] [PATCH] virsh: Clean up usage of boolean flag variables

2012-04-10 Thread Eric Blake
On 04/10/2012 06:44 AM, Peter Krempa wrote: This patch cleans up variables used to store boolean command flags that are inquired by vshCommandOptBool to use the bool data type instead of an integer. Additionaly this patch cleans up flag variables that are inferred from

Re: [libvirt] xend_internal: Use domain/status for shutdown check

2012-04-10 Thread Cole Robinson
On 04/10/2012 04:46 AM, Stefan Bader wrote: On 04/08/2012 03:08 PM, Cole Robinson wrote: On 04/02/2012 10:38 AM, Stefan Bader wrote: xend_internal: Use domain/status for shutdown check On newer xend (v3.x and after) there is no state and domid reported for inactive domains. When initially

[libvirt] [PATCH] qemu: Fix deadlock when qemuDomainOpenConsole cleans up a connection

2012-04-10 Thread Peter Krempa
The new safe console handling introduced a possibility to deadlock the qemu driver when a new console connection forcibly disconnects a previous console stream that belongs to an already closed connection. The virStreamFree function calls subsequently a the virReleaseConnect function that tries

Re: [libvirt] xend_internal: Use domain/status for shutdown check

2012-04-10 Thread Stefan Bader
On 10.04.2012 15:22, Cole Robinson wrote: On 04/10/2012 04:46 AM, Stefan Bader wrote: On 04/08/2012 03:08 PM, Cole Robinson wrote: On 04/02/2012 10:38 AM, Stefan Bader wrote: xend_internal: Use domain/status for shutdown check On newer xend (v3.x and after) there is no state and domid

Re: [libvirt] xend_internal: Use domain/status for shutdown check

2012-04-10 Thread Cole Robinson
On 04/10/2012 09:32 AM, Stefan Bader wrote: On 10.04.2012 15:22, Cole Robinson wrote: On 04/10/2012 04:46 AM, Stefan Bader wrote: On 04/08/2012 03:08 PM, Cole Robinson wrote: On 04/02/2012 10:38 AM, Stefan Bader wrote: xend_internal: Use domain/status for shutdown check On newer xend (v3.x

[libvirt] [test-API PATCHv2 1/2] sharemod: Add a new file for variable sharing in testcases

2012-04-10 Thread Guannan Ren
sharedmod.py --- sharedmod.py | 16 1 files changed, 16 insertions(+), 0 deletions(-) create mode 100644 sharedmod.py diff --git a/sharedmod.py b/sharedmod.py new file mode 100644 index 000..8af26d8 --- /dev/null +++ b/sharedmod.py @@ -0,0 +1,16 @@ +# This is a module

[libvirt] [test-API PATCHv2 2/2] rewrite env_inspect.py and initialize sharedmod

2012-04-10 Thread Guannan Ren
dist/redhat/env_inspect.py: initialize shared connection object for use in all testcases generator.py: make use of sharedmod --- dist/redhat/env_inspect.py | 192 generator.py | 15 +--- 2 files

[libvirt] [PATCH] daemon: Add libvirtd-config.c to the list of files to translate

2012-04-10 Thread Jiri Denemark
--- po/POTFILES.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index 5d5739a..4c49200 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -1,3 +1,4 @@ +daemon/libvirtd-config.c daemon/libvirtd.c daemon/qemu_dispatch.h daemon/remote.c

[libvirt] [PATCH] qemu: Avoid excessive calls to qemuDomainObjSaveJob()

2012-04-10 Thread Jiri Denemark
As reported by Daniel Berrangé, we have a huge performance regression for virDomainGetInfo() due to the change which makes virDomainEndJob() save the XML status file every time it is called. Previous to that change, 2000 calls to virDomainGetInfo() took ~2.5 seconds. After that change, 2000 calls

Re: [libvirt] xend_internal: Use domain/status for shutdown check

2012-04-10 Thread Stefan Bader
On 10.04.2012 15:33, Cole Robinson wrote: On 04/10/2012 09:32 AM, Stefan Bader wrote: On 10.04.2012 15:22, Cole Robinson wrote: On 04/10/2012 04:46 AM, Stefan Bader wrote: On 04/08/2012 03:08 PM, Cole Robinson wrote: On 04/02/2012 10:38 AM, Stefan Bader wrote: xend_internal: Use

[libvirt] [test-API PATCHv2 1/2] sharemod: Add a new file for variable sharing in testcases

2012-04-10 Thread Guannan Ren
sharedmod.py --- sharedmod.py | 16 1 files changed, 16 insertions(+), 0 deletions(-) create mode 100644 sharedmod.py diff --git a/sharedmod.py b/sharedmod.py new file mode 100644 index 000..8af26d8 --- /dev/null +++ b/sharedmod.py @@ -0,0 +1,16 @@ +# This is a module

Re: [libvirt] [PATCH] virsh: Clarify use of the --managed-save flag for the list command

2012-04-10 Thread Peter Krempa
On 04/10/2012 02:43 PM, Eric Blake wrote: On 04/10/2012 04:35 AM, Peter Krempa wrote: The documentation for the flag doesn't clearly state that the flag only enhances the output and the user needs to specify other flags to list inactive domains, that are enhanced by this flag. ---

[libvirt] [test-API PATCHv2 2/2] rewrite env_inspect.py and initialize sharedmod

2012-04-10 Thread Guannan Ren
dist/redhat/env_inspect.py: initialize shared connection object for use in all testcases generator.py: make use of sharedmod --- dist/redhat/env_inspect.py | 192 generator.py | 15 +--- 2 files

Re: [libvirt] [PATCH] virsh: Clean up usage of boolean flag variables

2012-04-10 Thread Peter Krempa
On 04/10/2012 02:55 PM, Eric Blake wrote: On 04/10/2012 06:44 AM, Peter Krempa wrote: This patch cleans up variables used to store boolean command flags that are inquired by vshCommandOptBool to use the bool data type instead of an integer. Additionaly this patch cleans up flag variables that

Re: [libvirt] [PATCH] Wire up loader to set the QEMU BIOS path

2012-04-10 Thread Eric Blake
On 04/10/2012 08:03 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com * src/qemu/qemu_command.c: Wire up -bios with loader * tests/qemuxml2argvdata/qemuxml2argv-bios.args, tests/qemuxml2argvdata/qemuxml2argv-bios.xml: Expand existing BIOS test case to cover

[libvirt] [PATCH] Wire up loader to set the QEMU BIOS path

2012-04-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * src/qemu/qemu_command.c: Wire up -bios with loader * tests/qemuxml2argvdata/qemuxml2argv-bios.args, tests/qemuxml2argvdata/qemuxml2argv-bios.xml: Expand existing BIOS test case to cover loader --- src/qemu/qemu_command.c |

[libvirt] [PATCH 1/2] qemu: Track job owner for better debugging

2012-04-10 Thread Jiri Denemark
In case an API fails with cannot acquire state change lock, searching for the API that possibly forgot to end its job is not always easy. Let's keep track of the job owner and print it out for easier identification. --- src/qemu/qemu_domain.c| 53

[libvirt] [PATCH 2/2] qemu: Warn on possibly incorrect usage of EnterMonitor*

2012-04-10 Thread Jiri Denemark
qemuDomainObjEnterMonitor{,WithDriver} should not be called from async jobs, only EnterMonitorAsync variant is allowed. --- src/qemu/qemu_domain.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7f1f8ee..4dda2e0

Re: [libvirt] [PATCH] daemon: Add libvirtd-config.c to the list of files to translate

2012-04-10 Thread Eric Blake
On 04/10/2012 07:42 AM, Jiri Denemark wrote: --- po/POTFILES.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index 5d5739a..4c49200 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -1,3 +1,4 @@ +daemon/libvirtd-config.c

Re: [libvirt] [PATCH] qemu: Fix deadlock when qemuDomainOpenConsole cleans up a connection

2012-04-10 Thread Eric Blake
On 04/10/2012 07:29 AM, Peter Krempa wrote: The new safe console handling introduced a possibility to deadlock the qemu driver when a new console connection forcibly disconnects a previous console stream that belongs to an already closed connection. The virStreamFree function calls

[libvirt] [PATCH] build: avoid s390 compiler warnings

2012-04-10 Thread Eric Blake
I noticed compiler warnings when building for the s390 architecture. * src/node_device/node_device_udev.c (udevDeviceMonitorStartup): Mark unused variable. * src/nodeinfo.c (linuxNodeInfoCPUPopulate): Avoid unused variable. --- Pushing under the trivial rule. src/node_device/node_device_udev.c

Re: [libvirt] [PATCH] qemu: Avoid excessive calls to qemuDomainObjSaveJob()

2012-04-10 Thread Eric Blake
On 04/10/2012 07:45 AM, Jiri Denemark wrote: As reported by Daniel Berrangé, we have a huge performance regression for virDomainGetInfo() due to the change which makes virDomainEndJob() save the XML status file every time it is called. Previous to that change, 2000 calls to virDomainGetInfo()

Re: [libvirt] [PATCH 2/2] qemu: Warn on possibly incorrect usage of EnterMonitor*

2012-04-10 Thread Eric Blake
On 04/10/2012 09:05 AM, Jiri Denemark wrote: qemuDomainObjEnterMonitor{,WithDriver} should not be called from async jobs, only EnterMonitorAsync variant is allowed. --- src/qemu/qemu_domain.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCHv4 01/18] blockjob: add qemu capabilities related to block jobs

2012-04-10 Thread Laine Stump
On 04/09/2012 11:52 PM, Eric Blake wrote: The new block copy storage migration sequence requires both the 'drive-mirror' action in 'transaction' (present if the 'drive-mirror' standalone monitor command also exists) and the 'drive-reopen' monitor command (it would be nice if that were also

Re: [libvirt] [PATCHv4 01/18] blockjob: add qemu capabilities related to block jobs

2012-04-10 Thread Daniel P. Berrange
On Tue, Apr 10, 2012 at 01:17:44PM -0400, Laine Stump wrote: On 04/09/2012 11:52 PM, Eric Blake wrote: The new block copy storage migration sequence requires both the 'drive-mirror' action in 'transaction' (present if the 'drive-mirror' standalone monitor command also exists) and the

Re: [libvirt] [PATCHv4 01/18] blockjob: add qemu capabilities related to block jobs

2012-04-10 Thread Eric Blake
On 04/10/2012 11:24 AM, Daniel P. Berrange wrote: As of this[1] qemu email, both commands have been proposed but not yet incorporated into the tree; in fact, the implementation I tested with has changed to match this[2] email that suggested a mandatory 'full':'bool' argument rather than

[libvirt] [libvirt-glib] Explicitly link conn-test against libvirt-gconfig libvirt-glib

2012-04-10 Thread Guido Günther
otherwise the build fails with: $ CCLD conn-test ../libvirt-gobject/.libs/libvirt-gobject-1.0.so: undefined reference to `gvir_config_domain_new_from_xml@LIBVIRT_GCONFIG_0.0.4' ../libvirt-gobject/.libs/libvirt-gobject-1.0.so: undefined reference to `gvir_set_error@LIBVIRT_GLIB_0.0.4'

[libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-10 Thread Guido Günther
Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683 --- If this looks correct I'll have a look at libvirt-glib and libvirt-gobject too. -- Guido libvirt-gconfig/libvirt-gconfig.sym | 50 +++ 1 files changed, 33 insertions(+), 17 deletions(-)

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-10 Thread Daniel P. Berrange
On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote: Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683 --- If this looks correct I'll have a look at libvirt-glib and libvirt-gobject too. Doing this would break ABI. We should just make sure future symbols are

Re: [libvirt] [libvirt-glib] Explicitly link conn-test against libvirt-gconfig libvirt-glib

2012-04-10 Thread Daniel P. Berrange
On Tue, Apr 10, 2012 at 10:29:59PM +0200, Guido Günther wrote: otherwise the build fails with: $ CCLD conn-test ../libvirt-gobject/.libs/libvirt-gobject-1.0.so: undefined reference to `gvir_config_domain_new_from_xml@LIBVIRT_GCONFIG_0.0.4' ../libvirt-gobject/.libs/libvirt-gobject-1.0.so:

Re: [libvirt] [PATCHv4 02/18] blockjob: add API for async virDomainBlockJobAbort

2012-04-10 Thread Laine Stump
On 04/09/2012 11:52 PM, Eric Blake wrote: From: Adam Litke a...@us.ibm.com Qemu has changed the semantics of the block_job_cancel API. The original qed implementation (pretty much only backported to RHEL 6.2 qemu) was synchronous (ie. upon command completion, the operation was guaranteed to

Re: [libvirt] [PATCHv4 02/18] blockjob: add API for async virDomainBlockJobAbort

2012-04-10 Thread Eric Blake
On 04/10/2012 03:01 PM, Laine Stump wrote: On 04/09/2012 11:52 PM, Eric Blake wrote: From: Adam Litke a...@us.ibm.com Qemu has changed the semantics of the block_job_cancel API. The original qed implementation (pretty much only backported to RHEL 6.2 qemu) was synchronous (ie. upon command

Re: [libvirt] Etsy uses Libvirt... :)

2012-04-10 Thread Eric Blake
On 04/09/2012 10:25 AM, Eric Blake wrote: On 04/09/2012 12:28 AM, Justin Clift wrote: Hey everyone, Just noticed that Etsy uses libvirt: http://codeascraft.etsy.com/2012/03/13/making-it-virtually-easy-to-deploy-on-day-one/ Of specific note, there's this bit: Libvirt supports live

Re: [libvirt] Etsy uses Libvirt... :)

2012-04-10 Thread Justin Clift
On 11/04/2012, at 8:36 AM, Eric Blake wrote: snip Thanks for the research. Would you care to help write up a documentation patch that mentions this as yet another client project? If you don't have time, I will probably get around to it later in the week. Turns out it's an internal use,

[libvirt] [PATCH] qemu: optimize JSON event handler lookup

2012-04-10 Thread Eric Blake
Probably in the noise, but this will let us scale more efficiently as we recognize ever more qemu events. * src/qemu/qemu_monitor_json.c (eventHandlers): Sort. (eventSearch): New helper function. (qemuMonitorJSONIOProcessEvent): Optimize event lookup. --- In reply to:

Re: [libvirt] [PATCH] qemu: optimize JSON event handler lookup

2012-04-10 Thread Wen Congyang
At 04/11/2012 06:47 AM, Eric Blake Wrote: Probably in the noise, but this will let us scale more efficiently as we recognize ever more qemu events. * src/qemu/qemu_monitor_json.c (eventHandlers): Sort. (eventSearch): New helper function. (qemuMonitorJSONIOProcessEvent): Optimize event