Re: [libvirt] virsh list hangs

2012-04-17 Thread Qian Zhang
Thanks Eric. I'd like to know if this issue will be resolved in later release of RHEL (e.g., RHEL 6.3), if yes, I think I can wait. Regards, Qian [please don't top-post on technical lists] On 04/15/2012 03:30 AM, Qian Zhang wrote: I think what happened to me is

Re: [libvirt] [PATCHv4 12/18] blockjob: implement block copy for qemu

2012-04-17 Thread Jiri Denemark
On Mon, Apr 16, 2012 at 17:28:10 -0600, Eric Blake wrote: On 04/13/2012 09:15 AM, Eric Blake wrote: On 04/13/2012 08:46 AM, Jiri Denemark wrote: On Mon, Apr 09, 2012 at 21:52:21 -0600, Eric Blake wrote: Minimal patch to wire up all the pieces in the previous patches to actually enable a

Re: [libvirt] [PATCHv4 16/18] blockjob: add virDomainBlockCopy

2012-04-17 Thread Jiri Denemark
On Mon, Apr 16, 2012 at 21:21:54 -0600, Eric Blake wrote: On 04/16/2012 08:29 AM, Jiri Denemark wrote: /** + * virDomainBlockCopy: + * @dom: pointer to domain object + * @disk: path to the block device, or device shorthand + * @dest: path to the copy destination + * @format: format

[libvirt] [PATCH v2] qemu: Split scsi-disk into into scsi-hd and scsi-cd

2012-04-17 Thread Osier Yang
A scsi-disk device can be either a hard disk or a CD-ROM, if there is ,media=cdrom specified for the backend, it's a CD-ROM, otherwise it's a hard disk. But upstream qemu splitted scsi-disk into scsi-hd and scsi-cd since commit b443ae, and ,media=cdrom is not required for scsi-cd anymore.

Re: [libvirt] [PATCH v2] qemu: Split scsi-disk into into scsi-hd and scsi-cd

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 04:56:33PM +0800, Osier Yang wrote: A scsi-disk device can be either a hard disk or a CD-ROM, if there is ,media=cdrom specified for the backend, it's a CD-ROM, otherwise it's a hard disk. But upstream qemu splitted scsi-disk into scsi-hd and scsi-cd since commit

[libvirt] [PATCH v3] qemu: Split scsi-disk into into scsi-hd and scsi-cd

2012-04-17 Thread Osier Yang
A scsi-disk device can be either a hard disk or a CD-ROM, if there is ,media=cdrom specified for the backend, it's a CD-ROM, otherwise it's a hard disk. But upstream qemu splitted scsi-disk into scsi-hd and scsi-cd since commit b443ae, and ,media=cdrom is not required for scsi-cd anymore.

[libvirt] [PATCH v2] qemu: Split ide-drive into ide-cd and ide-hd

2012-04-17 Thread Osier Yang
A ide-drive device can be either a hard disk or a CD-ROM, if there is ,media=cdrom specified for the backend, it's a CD-ROM, otherwise it's a hard disk. Upstream qemu splitted ide-drive into ide-hd and ide-cd since commit 1f56e32, and ,media=cdrom is not required for ide-cd anymore. ide-drive is

Re: [libvirt] [PATCH v3] qemu: Split scsi-disk into into scsi-hd and scsi-cd

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 05:11:31PM +0800, Osier Yang wrote: A scsi-disk device can be either a hard disk or a CD-ROM, if there is ,media=cdrom specified for the backend, it's a CD-ROM, otherwise it's a hard disk. But upstream qemu splitted scsi-disk into scsi-hd and scsi-cd since commit

Re: [libvirt] [PATCH v2] qemu: Split ide-drive into ide-cd and ide-hd

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 05:18:19PM +0800, Osier Yang wrote: A ide-drive device can be either a hard disk or a CD-ROM, if there is ,media=cdrom specified for the backend, it's a CD-ROM, otherwise it's a hard disk. Upstream qemu splitted ide-drive into ide-hd and ide-cd since commit 1f56e32,

Re: [libvirt] cgroup cpuset limited by default?

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 11:09:33AM +0530, Srivatsa S. Bhat wrote: On 04/16/2012 09:43 PM, Daniel P. Berrange wrote: On Mon, Apr 16, 2012 at 06:00:22PM +0200, Marc-André Lureau wrote: Hi On Mon, Apr 16, 2012 at 2:32 PM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: On

Re: [libvirt] [PATCH v3] qemu: Split scsi-disk into into scsi-hd and scsi-cd

2012-04-17 Thread Osier Yang
On 2012年04月17日 17:17, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 05:11:31PM +0800, Osier Yang wrote: A scsi-disk device can be either a hard disk or a CD-ROM, if there is ,media=cdrom specified for the backend, it's a CD-ROM, otherwise it's a hard disk. But upstream qemu splitted

Re: [libvirt] [PATCH v2] qemu: Split ide-drive into ide-cd and ide-hd

2012-04-17 Thread Osier Yang
On 2012年04月17日 17:26, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 05:18:19PM +0800, Osier Yang wrote: A ide-drive device can be either a hard disk or a CD-ROM, if there is ,media=cdrom specified for the backend, it's a CD-ROM, otherwise it's a hard disk. Upstream qemu splitted ide-drive

Re: [libvirt] [PATCHv5 01/23] virsh: minor syntactic cleanups

2012-04-17 Thread Jiri Denemark
On Mon, Apr 16, 2012 at 23:05:52 -0600, Eric Blake wrote: No semantic change. * tools/virsh.c: Fix some spacing issues, {} usage, long lines, and redundant (). --- v5: new patch, factored out from comments on other patches tools/virsh.c | 197

[libvirt] [PATCH v2] docs: Improve the schema for fs device

2012-04-17 Thread Osier Yang
filesystemtgt is redundant, as every group uses it; address shouldn't be in filesystemtgt in case of the meaning could be filesystemtarget; The elements address, alias, target, ... should be interleaved. --- v1 ~ v2: No changes --- docs/schemas/domaincommon.rng | 58

Re: [libvirt] [PATCHv5 02/23] qemu: use consistent error when qemu binary is too old

2012-04-17 Thread Jiri Denemark
On Mon, Apr 16, 2012 at 23:05:53 -0600, Eric Blake wrote: Most of our errors complaining about an inability to support a particular action due to qemu limitations used CONFIG_UNSUPPORTED, but we had a few outliers. Reported by Jiri Denemark. * src/qemu/qemu_command.c (qemuBuildDriveDevStr):

Re: [libvirt] cgroup cpuset limited by default?

2012-04-17 Thread Srivatsa S. Bhat
On 04/17/2012 03:02 PM, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 11:09:33AM +0530, Srivatsa S. Bhat wrote: On 04/16/2012 09:43 PM, Daniel P. Berrange wrote: On Mon, Apr 16, 2012 at 06:00:22PM +0200, Marc-André Lureau wrote: Hi On Mon, Apr 16, 2012 at 2:32 PM, Srivatsa S. Bhat

[libvirt] [test-API 0/3] Improve the copyright statements in scripts

2012-04-17 Thread Osier Yang
The new copyright statements is: Copyright (C) 2010-2012 Red Hat, Inc. libvirt-test-API is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 2 of the License, or (at

[libvirt] [test-API 1/3] Remove the unseemly copyright statements in scripts

2012-04-17 Thread Osier Yang
There will be a follow up patch to add the copyright statements in a better manner. % for i in $(find . -type f -name *.py); do \ sed -i -e '/copyright/,/www\.gnu\.org/d' $i; \ done --- activityfilter.py | 12 casecfgcheck.py| 12

[libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Osier Yang
The new copyright statements is: copyright Copyright (C) 2010-2012 Red Hat, Inc. libvirt-test-API is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 2 of the License, or

[libvirt] [test-API 3/3] Remove the redundant empty comment line

2012-04-17 Thread Osier Yang
--- activityfilter.py |3 --- casecfgcheck.py|2 -- dist/redhat/env_inspect.py |2 -- env_clear.py |2 -- exception.py |1 - generator.py |2 -- libvirt-test-api.py|2 -- logxmlparser.py

Re: [libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 06:59:24PM +0800, Osier Yang wrote: The new copyright statements is: copyright Copyright (C) 2010-2012 Red Hat, Inc. libvirt-test-API is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by

Re: [libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Osier Yang
On 2012年04月17日 19:04, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 06:59:24PM +0800, Osier Yang wrote: The new copyright statements is: copyright Copyright (C) 2010-2012 Red Hat, Inc. libvirt-test-API is free software; you can redistribute it and/or modify it under the terms of the

Re: [libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Osier Yang
On 2012年04月17日 19:09, Osier Yang wrote: On 2012年04月17日 19:04, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 06:59:24PM +0800, Osier Yang wrote: The new copyright statements is: copyright Copyright (C) 2010-2012 Red Hat, Inc. libvirt-test-API is free software; you can redistribute it

Re: [libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 07:09:36PM +0800, Osier Yang wrote: On 2012年04月17日 19:04, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 06:59:24PM +0800, Osier Yang wrote: The new copyright statements is: copyright Copyright (C) 2010-2012 Red Hat, Inc. libvirt-test-API is free software;

Re: [libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Osier Yang
On 2012年04月17日 19:13, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 07:09:36PM +0800, Osier Yang wrote: On 2012年04月17日 19:04, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 06:59:24PM +0800, Osier Yang wrote: The new copyright statements is: copyright Copyright (C) 2010-2012 Red

Re: [libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Osier Yang
[ CC to Rich ] On 2012年04月17日 19:18, Osier Yang wrote: On 2012年04月17日 19:13, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 07:09:36PM +0800, Osier Yang wrote: On 2012年04月17日 19:04, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 06:59:24PM +0800, Osier Yang wrote: The new copyright

Re: [libvirt] [test-API 2/3 v2] Add the better copyright statements in scripts

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 07:23:32PM +0800, Osier Yang wrote: diff --git a/activityfilter.py b/activityfilter.py index e6ad1bf..46e43d9 100644 --- a/activityfilter.py +++ b/activityfilter.py @@ -13,6 +13,22 @@ # PURPOSE. # # You should have received a copy of the GNU General Public

[libvirt] [test-API 2/3 v2] Add the better copyright statements in scripts

2012-04-17 Thread Osier Yang
The new copyright statements is: Copyright (C) 2010-2012 Red Hat, Inc. libvirt-test-API is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 2 of the License, or (at your

[libvirt] [test-API 2/3 v3] Add the better copyright statements in scripts

2012-04-17 Thread Osier Yang
The new copyright statements is: Copyright (C) 2010-2012 Red Hat, Inc. libvirt-test-API is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 2 of the License, or (at your

Re: [libvirt] [test-API 2/3 v3] Add the better copyright statements in scripts

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 07:26:54PM +0800, Osier Yang wrote: The new copyright statements is: Copyright (C) 2010-2012 Red Hat, Inc. libvirt-test-API is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free

[libvirt] [test-API 3/3 v2] Remove the redundant empty comment line

2012-04-17 Thread Osier Yang
--- v1 ~ v2: Changes to be consistent with 2/3's updating --- activityfilter.py |4 casecfgcheck.py|3 --- dist/redhat/env_inspect.py |3 --- env_clear.py |3 --- exception.py |2 -- generator.py |3 ---

Re: [libvirt] [test-API 3/3 v2] Remove the redundant empty comment line

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 07:32:37PM +0800, Osier Yang wrote: --- v1 ~ v2: Changes to be consistent with 2/3's updating --- activityfilter.py |4 casecfgcheck.py|3 --- dist/redhat/env_inspect.py |3 --- env_clear.py |3 ---

Re: [libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Richard W.M. Jones
On Tue, Apr 17, 2012 at 07:22:48PM +0800, Osier Yang wrote: [ CC to Rich ] On 2012年04月17日 19:18, Osier Yang wrote: On 2012年04月17日 19:13, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 07:09:36PM +0800, Osier Yang wrote: On 2012年04月17日 19:04, Daniel P. Berrange wrote: On Tue, Apr 17,

Re: [libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Daniel P. Berrange
On Tue, Apr 17, 2012 at 12:41:19PM +0100, Richard W.M. Jones wrote: On Tue, Apr 17, 2012 at 07:22:48PM +0800, Osier Yang wrote: [ CC to Rich ] On 2012年04月17日 19:18, Osier Yang wrote: On 2012年04月17日 19:13, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 07:09:36PM +0800, Osier Yang

Re: [libvirt] [PATCH 7/8] block: add witness argument to drive-reopen

2012-04-17 Thread Eric Blake
[adding libvir-list for some interesting discussions on potential libvirt design issues] On 04/17/2012 12:47 AM, Paolo Bonzini wrote: Il 16/04/2012 23:55, Eric Blake ha scritto: Do transient guests have persistent storage for them in /var while they are running? Yes - that's how libvirt

Re: [libvirt] [PATCHv4 12/18] blockjob: implement block copy for qemu

2012-04-17 Thread Eric Blake
On 04/17/2012 02:32 AM, Jiri Denemark wrote: In the meantime, I think I will patch this instead by documentation: state that non-zero bandwidth in virDomainBlockRebase() may be silently ignored; if error checking is needed, the user should use a separate call to virDomainBlockJobSetSpeed();

Re: [libvirt] [test-API 2/3] Add the better copyright statements in scripts

2012-04-17 Thread Osier Yang
On 2012年04月17日 19:41, Richard W.M. Jones wrote: On Tue, Apr 17, 2012 at 07:22:48PM +0800, Osier Yang wrote: [ CC to Rich ] On 2012年04月17日 19:18, Osier Yang wrote: On 2012年04月17日 19:13, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 07:09:36PM +0800, Osier Yang wrote: On 2012年04月17日

Re: [libvirt] [PATCHv5 03/23] blockjob: add virsh blockpull --wait

2012-04-17 Thread Jiri Denemark
On Mon, Apr 16, 2012 at 23:05:54 -0600, Eric Blake wrote: I'm tired of shell-scripting to wait for completion of a block pull, when virsh can be taught to do the same. I couldn't quite reuse vshWatchJob, as this is not a case of a long-running command where a second thread must be used to

Re: [libvirt] [PATCH V10 4/7] nwfilter: add DHCP snooping

2012-04-17 Thread Stefan Berger
On 04/16/2012 11:08 AM, Stefan Berger wrote: This patch adds DHCP snooping support to libvirt. The learning method for IP addresses is specified by setting the ip_learning variable to one of any [default] (existing IP learning code), none (static only addresses) or dhcp (DHCP snooping).

[libvirt] [test-API 0/3] Destroy class for utils/check.py

2012-04-17 Thread Osier Yang
Just as what we did for utils/utils.py, we don't benifit from the class use at all. Osier Yang (3): remove importing of unused check module Destroy class of utils/check.py Destroy use of check class repos/domain/balloon_memory.py |3 +- repos/domain/dump.py|4

[libvirt] [test-API 3/3] Destroy use of check class

2012-04-17 Thread Osier Yang
--- I see much TODO for cleaning up/refactoring, will come step by step in near future. --- repos/domain/balloon_memory.py |3 +-- repos/domain/dump.py|4 +--- repos/domain/install_linux_check.py | 15 +++ repos/snapshot/file_flag.py |7

[libvirt] [test-API 1/3] remove importing of unused check module

2012-04-17 Thread Osier Yang
--- utils/xmlgenerator.py |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/utils/xmlgenerator.py b/utils/xmlgenerator.py index d93f58c..7f5839b 100644 --- a/utils/xmlgenerator.py +++ b/utils/xmlgenerator.py @@ -26,7 +26,6 @@ sys.path.append(../utils) import

[libvirt] [test-API] Improve the comments telling what the scripts does for utils/*.py

2012-04-17 Thread Osier Yang
It's a habit to comment on the top of program to tell what the program does, and actually it's what GNU suggests: quote one line to give the program's name and a brief idea of what it does. Copyright (C) year name of author /quote --- utils/XMLParser.py|4 ++-- utils/check.py

Re: [libvirt] [PATCH] Remove the useless scripts directory and script under it

2012-04-17 Thread Osier Yang
Sorry, the title should be [test-API PATCH] On 2012年04月17日 22:19, Osier Yang wrote: The script is useful only if all the scripts have good document comments. Unfortunately, it's not true, and it's burden for developers to write those documents in specific format somehow, on the other hand,

[libvirt] [test-API] Add one space between shebang and following interpreter

2012-04-17 Thread Osier Yang
We want it looks better. Isn't it? :-) --- activityfilter.py |2 +- casecfgcheck.py|2 +- dist/redhat/env_inspect.py |2 +- env_clear.py |2 +-

[libvirt] [PATCH V11 6/7] nwfilter: Add multiple IP address support to DHCP snooping

2012-04-17 Thread Stefan Berger
With support for multiple IP addresses per interface in place, this patch now adds support for multiple IP addresses per interface for the DHCP snooping code. Testing: Since the infrastructure I tested this with does not provide multiple IP addresses per MAC address (anymore), I either had to

[libvirt] [PATCH V11 1/7] Implement virHashRemoveAll function

2012-04-17 Thread Stefan Berger
Implement function to remove all entries of a hash table. --- src/libvirt_private.syms |1 + src/util/virhash.c | 25 + src/util/virhash.h |5 + 3 files changed, 31 insertions(+) Index: libvirt-acl/src/libvirt_private.syms

[libvirt] [PATCH V11 5/7] nwfilter: move code for IP address map into separate file

2012-04-17 Thread Stefan Berger
The goal of this patch is to prepare for support for multiple IP addresses per interface in the DHCP snooping code. Move the code for the IP address map that maps interface names to IP addresses into their own file. Rename the functions on the way but otherwise leave the code as-is. Initialize

[libvirt] [PATCH V11 0/7] Add DHCP snooping support to nwfilter

2012-04-17 Thread Stefan Berger
This series of patches adds DHCP snooping support to libvirt's nwfilter subsystem. DHCP snooping detects DHCP leases obtained by a VM and automatically adjusts the network traffic filters to reflect the IP addresses with which a VM may send its traffic, thus for example preventing IP address

[libvirt] [PATCH V11 2/7] Support for atomic operations on integers

2012-04-17 Thread Stefan Berger
For threading support, add atomic add and sub operations working on integers. Base this on locking support provided by virMutex. --- src/util/viratomic.h | 91 +++ 1 file changed, 91 insertions(+) Index: libvirt-acl/src/util/viratomic.h

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-17 Thread Eric Blake
On 04/16/2012 10:45 PM, Osier Yang wrote: Two follow up patches, one is to update test read-bufsiz to delete the UUID, as domain UUID for test driver is fixed now. The other is to allow the parsing of cpuset if the placement is not specified, but cpuset is specified, and in this case the

[libvirt] [PATCH V11 7/7] nwfilter: Display detected IP address in domain XML

2012-04-17 Thread Stefan Berger
Display detected IP addresses in the domain XML using the IP_LEASE variable name. This variable name now becomes a reserved variable name that can be read only but not set by the user. The format of the value is: ip addresss,lease timeout in seconds An example of a displayed XML may then be:

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-17 Thread Osier Yang
On 2012年04月17日 22:49, Eric Blake wrote: On 04/16/2012 10:45 PM, Osier Yang wrote: Two follow up patches, one is to update test read-bufsiz to delete the UUID, as domain UUID for test driver is fixed now. The other is to allow the parsing of cpuset if the placement is not specified, but cpuset

Re: [libvirt] [test-API] Add one space between shebang and following interpreter

2012-04-17 Thread Osier Yang
On 2012年04月17日 22:42, Eric Blake wrote: On 04/17/2012 08:34 AM, Osier Yang wrote: We want it looks better. Isn't it? :-) --- +++ b/activityfilter.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#! /usr/bin/env/ python This is purely cosmetic. The kernel does not care either way. Yeah, I'm

Re: [libvirt] VN-Link vNIC memory state copying on VM Migration

2012-04-17 Thread Jagath Weerasinghe
Chris OK. In phase 3, the RAM used by VM in source host is copied to the destination. Then what about the memory state of vNIC's in the M81KR VIC. Isn't there any memory for traffic passing through vNICs and also for vNIC statistics?  What I am talking about is copying of this memory to the

[libvirt] [test-API] Add one space between shebang and following interpreter

2012-04-17 Thread R P Herrold
On Tue, 17 Apr 2012, Osier Yang wrote: up top, so it is not missed: Executive summary: please reject this path -- details infra ... We want it looks better. Isn't it? :-) --- activityfilter.py |2 +- ... snippety ... utils/xmlgenerator.py

[libvirt] [libvirt-glib 1/2] Parse GVirConfigDomainController nodes

2012-04-17 Thread Christophe Fergeau
Update gvir_config_domain_device_new_from_tree to handle GVirConfigDomainController nodes --- .../libvirt-gconfig-domain-controller.c| 37 .../libvirt-gconfig-domain-device-private.h|3 ++ libvirt-gconfig/libvirt-gconfig-domain-device.c|2 +-

[libvirt] [libvirt-glib 2/2] Parse GVirConfigDomainRedirdev nodes

2012-04-17 Thread Christophe Fergeau
Update gvir_config_domain_device_new_from_tree to handle GVirConfigDomainRedirdev nodes --- libvirt-gconfig/libvirt-gconfig-domain-device.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-device.c

[libvirt] [test-API] Delete the script to generate the testing coverage statistics

2012-04-17 Thread Osier Yang
lib/*.py were destroyed. And there is no way to count the API coverage now. --- I tried to write a rough patch to generate the statistics, but failed. There is no way to detect if the API is covered by the cases, because the different class can have same methods name, though I can filter out the

Re: [libvirt] [PATCH v2] docs: Improve the schema for fs device

2012-04-17 Thread Eric Blake
On 04/17/2012 03:50 AM, Osier Yang wrote: filesystemtgt is redundant, as every group uses it; address shouldn't be in filesystemtgt in case of the meaning could be filesystemtarget; The elements address, alias, target, ... should be interleaved. --- v1 ~ v2: No changes ---

Re: [libvirt] [PATCH v2] docs: Improve the schema for fs device

2012-04-17 Thread Osier Yang
On 2012年04月18日 00:37, Eric Blake wrote: On 04/17/2012 03:50 AM, Osier Yang wrote: filesystemtgt is redundant, as every group uses it;address shouldn't be infilesystemtgt in case of the meaning could be filesystemtarget; The elementsaddress,alias,target, ... should be interleaved. --- v1 ~

Re: [libvirt] [PATCH] vbox: avoid provoking assertions in VBoxSVC

2012-04-17 Thread Eric Blake
On 04/13/2012 07:04 AM, Jean-Baptiste Rouault wrote: Passing a NULL pointer to IMachine::delete virtualbox API causes VBoxSVC to raise an assertion. This patch passes an empty array instead. --- src/vbox/vbox_tmpl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCHv5 03/23] blockjob: add virsh blockpull --wait

2012-04-17 Thread Eric Blake
On 04/17/2012 07:15 AM, Jiri Denemark wrote: On Mon, Apr 16, 2012 at 23:05:54 -0600, Eric Blake wrote: I'm tired of shell-scripting to wait for completion of a block pull, when virsh can be taught to do the same. I couldn't quite reuse vshWatchJob, as this is not a case of a long-running

[libvirt] [PATCH 2/2] python: return error if PyObject obj is NULL for unwrapper helper functions

2012-04-17 Thread Guannan Ren
The result is indeterminate for NULL argument to python functions as follows. It's better to return negative value in these situations. PyObject_IsTrue will segfault if the argument is NULL PyFloat_AsDouble(NULL) is -1.00 PyLong_AsUnsignedLongLong(NULL) is 0.00 ---

[libvirt] [PATCH 1/2] python: cleanup vcpu related binding APIs

2012-04-17 Thread Guannan Ren
*libvirt_virDomainGetVcpus: add error handling, return -1 instead of None *libvirt_virDomainPinVcpu and libvirt_virDomainPinVcpuFlags: make use of libvirt_boolUnwrap set vcpus which are list in tuple pycpumap, trun off the rest in cpumap. The original way

Re: [libvirt] [PATCH 2/2] python: return error if PyObject obj is NULL for unwrapper helper functions

2012-04-17 Thread Eric Blake
On 04/17/2012 11:45 AM, Guannan Ren wrote: The result is indeterminate for NULL argument to python functions as follows. It's better to return negative value in these situations. PyObject_IsTrue will segfault if the argument is NULL PyFloat_AsDouble(NULL) is -1.00

Re: [libvirt] [PATCH 2/2] python: return error if PyObject obj is NULL for unwrapper helper functions

2012-04-17 Thread Eric Blake
On 04/17/2012 11:49 AM, Eric Blake wrote: On 04/17/2012 11:45 AM, Guannan Ren wrote: The result is indeterminate for NULL argument to python functions as follows. It's better to return negative value in these situations. PyObject_IsTrue will segfault if the argument is NULL

Re: [libvirt] [PATCH 0/9] Add basic driver for Parallels Virtuozzo Server

2012-04-17 Thread Dmitry Guryanov
On 04/16/2012 06:13 AM, Daniel Veillard wrote: On Fri, Apr 13, 2012 at 10:26:14PM +0400, Dmitry Guryanov wrote: Parallels Virtuozzo Server is a cloud-ready virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server.

Re: [libvirt] [PATCH 1/2] python: cleanup vcpu related binding APIs

2012-04-17 Thread Eric Blake
On 04/17/2012 11:45 AM, Guannan Ren wrote: *libvirt_virDomainGetVcpus: add error handling, return -1 instead of None *libvirt_virDomainPinVcpu and libvirt_virDomainPinVcpuFlags: make use of libvirt_boolUnwrap set vcpus which are list in tuple pycpumap, trun off the

Re: [libvirt] VN-Link vNIC memory state copying on VM Migration

2012-04-17 Thread Christian Benvenuti (benve)
-Original Message- From: Jagath Weerasinghe [mailto:jagf...@gmail.com] Sent: Tuesday, April 17, 2012 8:19 AM To: Christian Benvenuti (benve) Cc: libvir-list@redhat.com Subject: Re: [libvirt] VN-Link vNIC memory state copying on VM Migration Chris OK. In phase 3, the RAM used

Re: [libvirt] [libvirt-glib 1/2] Parse GVirConfigDomainController nodes

2012-04-17 Thread Zeeshan Ali (Khattak)
On Tue, Apr 17, 2012 at 6:35 PM, Christophe Fergeau cferg...@redhat.com wrote: Update gvir_config_domain_device_new_from_tree to handle GVirConfigDomainController nodes Looks good but please update the commit log to reflect that its only adding support for USB controller for the moment. --

Re: [libvirt] [libvirt-glib 2/2] Parse GVirConfigDomainRedirdev nodes

2012-04-17 Thread Zeeshan Ali (Khattak)
On Tue, Apr 17, 2012 at 6:35 PM, Christophe Fergeau cferg...@redhat.com wrote: Update gvir_config_domain_device_new_from_tree to handle GVirConfigDomainRedirdev nodes ACK! -- Regards, Zeeshan Ali (Khattak) FSF member#5124 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] Fix a memory leak

2012-04-17 Thread Stefan Berger
The below patch fixes the following memory leak. ==20624== 24 bytes in 2 blocks are definitely lost in loss record 532 of 1,867 ==20624==at 0x4A05E46: malloc (vg_replace_malloc.c:195) ==20624==by 0x38EC27FC01: strdup (strdup.c:43) ==20624==by 0x4EB6BA3: virDomainChrSourceDefCopy

Re: [libvirt] [PATCH] Fix a memory leak

2012-04-17 Thread Eric Blake
On 04/17/2012 12:55 PM, Stefan Berger wrote: The below patch fixes the following memory leak. ==20624== 24 bytes in 2 blocks are definitely lost in loss record 532 of 1,867 ==20624==at 0x4A05E46: malloc (vg_replace_malloc.c:195) ==20624==by 0x38EC27FC01: strdup (strdup.c:43)

Re: [libvirt] [PATCH] Fix a memory leak

2012-04-17 Thread Stefan Berger
On 04/17/2012 03:03 PM, Eric Blake wrote: On 04/17/2012 12:55 PM, Stefan Berger wrote: } +dest-type = src-type; + ACK. No good writing into a union if you forget to also update the discriminator to say which branch of the union is active. The missing assignment definitely

Re: [libvirt] [PATCH V10 0/7] Add DHCP snooping support to nwfilter

2012-04-17 Thread dennis jenkins
On Mon, Apr 16, 2012 at 2:33 PM, dennis jenkins dennis.jenkins...@gmail.com wrote: On Mon, Apr 16, 2012 at 2:22 PM, Stefan Berger stef...@linux.vnet.ibm.com wrote: ** On 04/16/2012 03:12 PM, dennis jenkins wrote: On Mon, Apr 16, 2012 at 10:08 AM, Stefan Berger

Re: [libvirt] [PATCHv5 03/23] blockjob: add virsh blockpull --wait

2012-04-17 Thread Jiri Denemark
On Tue, Apr 17, 2012 at 11:13:53 -0600, Eric Blake wrote: On 04/17/2012 07:15 AM, Jiri Denemark wrote: On Mon, Apr 16, 2012 at 23:05:54 -0600, Eric Blake wrote: I'm tired of shell-scripting to wait for completion of a block pull, when virsh can be taught to do the same. I couldn't quite

Re: [libvirt] [PATCH V10 0/7] Add DHCP snooping support to nwfilter

2012-04-17 Thread Stefan Berger
On 04/17/2012 03:55 PM, dennis jenkins wrote: Stefan, There is a potential bug [1] in the Gentoo package that tracks the libvirt git repository. I will wait a few days for the Gentoo folks to sort it out. If not, I will remove the Gentoo libvirt package and install the latest from git

Re: [libvirt] [PATCH 0/9] Add basic driver for Parallels Virtuozzo Server

2012-04-17 Thread Daniel Veillard
On Tue, Apr 17, 2012 at 10:01:50PM +0400, Dmitry Guryanov wrote: On 04/16/2012 06:13 AM, Daniel Veillard wrote: On Fri, Apr 13, 2012 at 10:26:14PM +0400, Dmitry Guryanov wrote: Parallels Virtuozzo Server is a cloud-ready virtualization solution that allows users to simultaneously run multiple

Re: [libvirt] [test-API] Add one space between shebang and following interpreter

2012-04-17 Thread Osier Yang
On 2012年04月17日 23:20, R P Herrold wrote: On Tue, 17 Apr 2012, Osier Yang wrote: up top, so it is not missed: Executive summary: please reject this path -- details infra ... We want it looks better. Isn't it? :-) --- activityfilter.py | 2 +- ... snippety ... utils/xmlgenerator.py | 2 +- 116

Re: [libvirt] [test-API 3/3 v2] Remove the redundant empty comment line

2012-04-17 Thread Osier Yang
On 2012年04月17日 19:35, Daniel P. Berrange wrote: On Tue, Apr 17, 2012 at 07:32:37PM +0800, Osier Yang wrote: --- v1 ~ v2: Changes to be consistent with 2/3's updating --- activityfilter.py |4 casecfgcheck.py|3 --- dist/redhat/env_inspect.py |3 ---

Re: [libvirt] [PATCH 2/2] python: return error if PyObject obj is NULL for unwrapper helper functions

2012-04-17 Thread Guannan Ren
On 04/18/2012 01:53 AM, Eric Blake wrote: On 04/17/2012 11:49 AM, Eric Blake wrote: On 04/17/2012 11:45 AM, Guannan Ren wrote: The result is indeterminate for NULL argument to python functions as follows. It's better to return negative value in these situations.

[libvirt] Incomplete stdout returned by qemu -help cause kvm disabled

2012-04-17 Thread 杨镭
Hi: In our setup(libvirt 0.9.9 with Arch Linux with kernel 3.2+), when libvirt are accessed simultaneously, say 8 createDomain requests, there is a large chance that `qemu -help` return incomplete stdout which cause kvm to be disabled. Another user have the same situation like us[1] and he

[libvirt] [test-API 06/10] Move install-autotest-server into 'scripts'

2012-04-17 Thread Osier Yang
--- .../install-autotest-server|0 1 files changed, 0 insertions(+), 0 deletions(-) rename install-autotest-server = scripts/install-autotest-server (100%) diff --git a/install-autotest-server b/scripts/install-autotest-server similarity index 100% rename from

[libvirt] [test-API 03/10] Remove the suffix .py for libvirt-test-api.py

2012-04-17 Thread Osier Yang
As the main excutable program, it's habit to have no suffix. s/libvirt-test-api.py/libvirt-test-api/g --- libvirt-test-api.py = libvirt-test-api | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) rename libvirt-test-api.py = libvirt-test-api (95%) diff --git

[libvirt] [test-API 01/10] Create new dir 'conf' and move conf files into it

2012-04-17 Thread Osier Yang
--- env.cfg = conf/env.cfg|0 kickstart.cfg = conf/kickstart.cfg|0 exception.py |2 +- generator.py |2 +- parser.py |

[libvirt] [test-API 00/10] Reorgnize/refactoring round 2

2012-04-17 Thread Osier Yang
This should be the second round to reorgnize/refactor the codes. What this round does: * New directory conf; Move $root/*.cfg into it * New directory src; Move $root/*.{py,css,xls} into it (except the main program libvirt-test-api.py) * Rename libvirt-test-api.py to libvirt-test-api *

[libvirt] [test-API 02/10] Fix the typo in usage string

2012-04-17 Thread Osier Yang
The usage functions really need to be improved, but it will be a follow up patch. --- libvirt-test-api.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libvirt-test-api.py b/libvirt-test-api.py index b7b2b74..ae53d14 100644 --- a/libvirt-test-api.py +++

[libvirt] [test-API 04/10] New directory 'src' and move *.{py, css, xls} files into it

2012-04-17 Thread Osier Yang
The import statements are updated incidentally. --- dist/redhat/env_inspect.py |2 +- libvirt-test-api | 16 repos/domain/attach_disk.py|2 +- repos/domain/attach_interface.py

[libvirt] [test-API 08/10] Add document to tell the default log output file

2012-04-17 Thread Osier Yang
--- libvirt-test-api |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libvirt-test-api b/libvirt-test-api index 651717c..b7c2468 100644 --- a/libvirt-test-api +++ b/libvirt-test-api @@ -37,7 +37,8 @@ def usage(): print \noptions: -h, --help : Display usage

[libvirt] [test-API 05/10] Fix the typo which mispells 'shutil' as 'shutils'

2012-04-17 Thread Osier Yang
This should be caused by previous 'utils/utils.py' cleaning up --- repos/domain/install_linux_cdrom.py |6 +++--- repos/domain/install_linux_net.py |6 +++--- repos/domain/install_windows_cdrom.py |4 ++-- repos/remoteAccess/tls_setup.py |8 4 files changed,