Re: [libvirt] [test-API 1/3] remove importing of unused check module

2012-04-18 Thread Guannan Ren
On 04/17/2012 09:44 PM, Osier Yang wrote: --- utils/xmlgenerator.py |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/utils/xmlgenerator.py b/utils/xmlgenerator.py index d93f58c..7f5839b 100644 --- a/utils/xmlgenerator.py +++ b/utils/xmlgenerator.py @@ -26,7 +26,6 @@ sys

Re: [libvirt] [test-API 0/3] Destroy class for utils/check.py

2012-04-18 Thread Guannan Ren
On 04/17/2012 09:44 PM, Osier Yang wrote: Just as what we did for utils/utils.py, we don't benifit from the class use at all. Osier Yang (3): remove importing of unused check module Destroy class of utils/check.py Destroy use of check class repos/domain/balloon_memory.py |3

Re: [libvirt] [test-API] Improve the comments telling what the scripts does for utils/*.py

2012-04-18 Thread Guannan Ren
On 04/17/2012 10:07 PM, Osier Yang wrote: It's a habit to comment on the top of program to tell what the program does, and actually it's what GNU suggests: Copyright (C) --- utils/XMLParser.py|4 ++-- utils/check.py|7 ++- utils/env_parser.py |6 ++--

Re: [libvirt] [PATCH] Remove the useless scripts directory and script under it

2012-04-18 Thread Guannan Ren
On 04/17/2012 10:19 PM, Osier Yang wrote: The script is useful only if all the scripts have good document comments. Unfortunately, it's not true, and it's burden for developers to write those documents in specific format somehow, on the other hand, because we introduced required_opts, optional_op

Re: [libvirt] [test-API] Delete the script to generate the testing coverage statistics

2012-04-18 Thread Guannan Ren
On 04/18/2012 12:23 AM, Osier Yang wrote: lib/*.py were destroyed. And there is no way to count the API coverage now. --- I tried to write a rough patch to generate the statistics, but failed. There is no way to detect if the API is covered by the cases, because the different class can have same

Re: [libvirt] [test-API 0/3] Destroy class for utils/check.py

2012-04-18 Thread Osier Yang
On 2012年04月18日 15:07, Guannan Ren wrote: On 04/17/2012 09:44 PM, Osier Yang wrote: Just as what we did for utils/utils.py, we don't benifit from the class use at all. Osier Yang (3): remove importing of unused check module Destroy class of utils/check.py Destroy use of check class repos/domain

Re: [libvirt] [PATCH] Remove the useless scripts directory and script under it

2012-04-18 Thread Osier Yang
On 2012年04月18日 15:12, Guannan Ren wrote: On 04/17/2012 10:19 PM, Osier Yang wrote: The script is useful only if all the scripts have good document comments. Unfortunately, it's not true, and it's burden for developers to write those documents in specific format somehow, on the other hand, becaus

Re: [libvirt] [test-API] Delete the script to generate the testing coverage statistics

2012-04-18 Thread Osier Yang
On 2012年04月18日 15:13, Guannan Ren wrote: On 04/18/2012 12:23 AM, Osier Yang wrote: lib/*.py were destroyed. And there is no way to count the API coverage now. --- I tried to write a rough patch to generate the statistics, but failed. There is no way to detect if the API is covered by the cases,

Re: [libvirt] [PATCH] Remove the useless scripts directory and script under it

2012-04-18 Thread Guannan Ren
On 04/18/2012 03:18 PM, Osier Yang wrote: On 2012年04月18日 15:12, Guannan Ren wrote: On 04/17/2012 10:19 PM, Osier Yang wrote: The script is useful only if all the scripts have good document comments. Unfortunately, it's not true, and it's burden for developers to write those documents in specifi

Re: [libvirt] [PATCH] Remove the useless scripts directory and script under it

2012-04-18 Thread Osier Yang
On 2012年04月18日 15:29, Guannan Ren wrote: On 04/18/2012 03:18 PM, Osier Yang wrote: On 2012年04月18日 15:12, Guannan Ren wrote: On 04/17/2012 10:19 PM, Osier Yang wrote: The script is useful only if all the scripts have good document comments. Unfortunately, it's not true, and it's burden for deve

Re: [libvirt] [test-API 01/10] Create new dir 'conf' and move conf files into it

2012-04-18 Thread Guannan Ren
On 04/18/2012 01:49 PM, Osier Yang wrote: --- env.cfg => conf/env.cfg|0 kickstart.cfg => conf/kickstart.cfg|0 exception.py |2 +- generator.py |2 +- p

Re: [libvirt] [test-API 03/10] Remove the suffix .py for libvirt-test-api.py

2012-04-18 Thread Guannan Ren
On 04/18/2012 01:49 PM, Osier Yang wrote: As the main excutable program, it's habit to have no suffix. s/libvirt-test-api.py/libvirt-test-api/g --- libvirt-test-api.py => libvirt-test-api | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) rename libvirt-test-api.py

Re: [libvirt] [test-API 01/10] Create new dir 'conf' and move conf files into it

2012-04-18 Thread Osier Yang
On 2012年04月18日 15:41, Guannan Ren wrote: On 04/18/2012 01:49 PM, Osier Yang wrote: --- env.cfg => conf/env.cfg | 0 kickstart.cfg => conf/kickstart.cfg | 0 exception.py | 2 +- generator.py | 2 +- parser.py | 4 ++-- repos/domain/install_image.py | 2 +- repos/domain/install_linux_cdrom.py | 2 +- re

Re: [libvirt] [test-API 03/10] Remove the suffix .py for libvirt-test-api.py

2012-04-18 Thread Osier Yang
On 2012年04月18日 15:44, Guannan Ren wrote: On 04/18/2012 01:49 PM, Osier Yang wrote: As the main excutable program, it's habit to have no suffix. s/libvirt-test-api.py/libvirt-test-api/g --- libvirt-test-api.py => libvirt-test-api | 18 +- 1 files changed, 9 insertions(+), 9 deleti

Re: [libvirt] [PATCH 0/2 v2] use qemu's dump-guest-meory when vm uses host device

2012-04-18 Thread Wen Congyang
Hi, Eric Luiz will accept the qemu's patch: http://lists.nongnu.org/archive/html/qemu-devel/2012-04/msg02346.html Do you have any comment about this patchset? Thanks Wen Congyang At 04/10/2012 04:03 PM, Wen Congyang Wrote: > Currently, we use migrate to dump guest's memory. There is one > restr

Re: [libvirt] [test-API 01/10] Create new dir 'conf' and move conf files into it

2012-04-18 Thread Guannan Ren
On 04/18/2012 03:41 PM, Osier Yang wrote: On 2012年04月18日 15:41, Guannan Ren wrote: On 04/18/2012 01:49 PM, Osier Yang wrote: --- env.cfg => conf/env.cfg | 0 kickstart.cfg => conf/kickstart.cfg | 0 exception.py | 2 +- generator.py | 2 +- parser.py | 4 ++-- repos/domain/install_image.py | 2 +- re

Re: [libvirt] [test-API 04/10] New directory 'src' and move *.{py, css, xls} files into it

2012-04-18 Thread Guannan Ren
On 04/18/2012 01:49 PM, Osier Yang wrote: The "import" statements are updated incidentally. --- dist/redhat/env_inspect.py |2 +- libvirt-test-api | 16 repos/domain/attach_disk.py|2 +

Re: [libvirt] [test-API 05/10] Fix the typo which mispells 'shutil' as 'shutils'

2012-04-18 Thread Guannan Ren
On 04/18/2012 01:49 PM, Osier Yang wrote: This should be caused by previous 'utils/utils.py' cleaning up --- repos/domain/install_linux_cdrom.py |6 +++--- repos/domain/install_linux_net.py |6 +++--- repos/domain/install_windows_cdrom.py |4 ++-- repos/remoteAccess/tls_set

Re: [libvirt] [test-API 06/10] Move install-autotest-server into 'scripts'

2012-04-18 Thread Guannan Ren
On 04/18/2012 01:49 PM, Osier Yang wrote: --- .../install-autotest-server|0 1 files changed, 0 insertions(+), 0 deletions(-) rename install-autotest-server => scripts/install-autotest-server (100%) diff --git a/install-autotest-server b/scripts/install-autotest

Re: [libvirt] [test-API 08/10] Add document to tell the default log output file

2012-04-18 Thread Guannan Ren
On 04/18/2012 01:49 PM, Osier Yang wrote: --- libvirt-test-api |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libvirt-test-api b/libvirt-test-api index 651717c..b7c2468 100644 --- a/libvirt-test-api +++ b/libvirt-test-api @@ -37,7 +37,8 @@ def usage(): print "

[libvirt] [PATCHv2] util: only register callbacks for CREATE operations in virnetdevmacvlan.c

2012-04-18 Thread Laine Stump
From: "D. Herrendoerfer" I believe the following is the correct patch for this - when a guest is started from a snapshot or from a saved image, qemuProcessStart is called with VIR_NETDEV_VPORT_PROFILE_OP_RESTORE. From my reading of the code, the callback will have been removed when the guest was

Re: [libvirt] [PATCH] storage backend: Add RBD (RADOS Block Device) support

2012-04-18 Thread Daniel P. Berrange
On Fri, Mar 30, 2012 at 11:04:43AM +0200, Wido den Hollander wrote: > This patch adds support for a new storage backend with RBD support. > > RBD is the RADOS Block Device and is part of the Ceph distributed storage > system. > > It comes in two flavours: Qemu-RBD and Kernel RBD, this storage ba

[libvirt] [PATCH v2] util: only register callbacks for CREATE operations in virnetdevmacvlan.c

2012-04-18 Thread D. Herrendoerfer
From: "D. Herrendoerfer" currently upon a migration a callback is created when a 802.1qbg link is set to PREASSOCIATE, this should not happen because this is a no-op on most switches, and does not lead to an ASSOCIATE state. This patch only creates callbacks when CREATE is requested. A VM restore

Re: [libvirt] [test-API 09/10] Rename and modify the syntax of BUGSKIP

2012-04-18 Thread Guannan Ren
On 04/18/2012 01:49 PM, Osier Yang wrote: Skipping only step(s) of a test case doesn't make sense, e.g. there is a bug of domain defining, if we only skip the "domain:define" in all test cases, that means all the followup steps (e.g. domain start, checking) of all of the test cases use "domain:de

[libvirt] [PATCH 1/2] Add a new flag VIR_DOMAIN_CPU_STATS_F_VCPU to virDomainGetCPUStats

2012-04-18 Thread Hu Tao
Currently virDomainGetCPUStats gets total cpu usage, which consists of: 1. vcpu usage: the physical cpu time consumed by virtual cpu(s) of domain 2. hypervisor: `total cpu usage' - `vcpu usage' The flag VIR_DOMAIN_CPU_STATS_F_VCPU is for getting vcpu usages. --- include/libvirt/libvirt.

[libvirt] [PATCH 2/2] Adds support to VIR_DOMAIN_CPU_STATS_F_VCPU in qemu_driver.

2012-04-18 Thread Hu Tao
--- src/qemu/qemu_driver.c | 152 ++- src/util/cgroup.c |4 +- tools/virsh.c | 17 -- 3 files changed, 150 insertions(+), 23 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0d3b0bd..165b5f3 100644

[libvirt] [PATCH 3] add parameter flags to D.get_cpu_stats()

2012-04-18 Thread Hu Tao
--- examples/get_cpu_stats.ml |2 +- libvirt/libvirt.ml |2 +- libvirt/libvirt.mli |2 +- libvirt/libvirt_c_oneoffs.c |9 + 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/get_cpu_stats.ml b/examples/get_cpu_stats.ml index 79d5c3c.

[libvirt] [PATCH 4] show `vcpu usages' by `virt-top -1'

2012-04-18 Thread Hu Tao
Before this patch, `virt-top -1' shows total cpu usages which euqal to `vcpu usages' + `hypervisor usages'. This patch adds another column for domains showing `vcpu usages'. An example is: PHYCPU %CPU example_domain 0 10.4 10.4 0.8 11.6 1.6 1.4 22.6 2.6 2.6 30.0 0.0

[libvirt] [PATCH 0/2] physical cpu usages of virtual cpus

2012-04-18 Thread Hu Tao
See patch 1 and patch 4 for the purpose of this series. patches 1,2 are for libvirt. patch 3 is for ocaml-libvirt. patch 4 is for virt-top. Hu Tao (2): Add a new flag VIR_DOMAIN_CPU_STATS_F_VCPU to virDomainGetCPUStats Adds support to VIR_DOMAIN_CPU_STATS_F_VCPU in qemu_driver. include/libv

Re: [libvirt] [PATCH v2] util: only register callbacks for CREATE operations in virnetdevmacvlan.c

2012-04-18 Thread Stefan Berger
On 04/18/2012 07:09 AM, D. Herrendoerfer wrote: From: "D. Herrendoerfer" currently upon a migration a callback is created when a 802.1qbg link is set to PREASSOCIATE, this should not happen because this is a no-op on most switches, and does not lead to an ASSOCIATE state. This patch only creates

Re: [libvirt] [PATCHv2] util: only register callbacks for CREATE operations in virnetdevmacvlan.c

2012-04-18 Thread D. Herrendoerfer
On Apr 18, 2012, at 10:53 AM, Laine Stump wrote: From: "D. Herrendoerfer" I believe the following is the correct patch for this - when a guest is started from a snapshot or from a saved image, qemuProcessStart is called with VIR_NETDEV_VPORT_PROFILE_OP_RESTORE. From my reading of the code, th

Re: [libvirt] Incomplete stdout returned by qemu -help cause kvm disabled

2012-04-18 Thread Cole Robinson
On 04/18/2012 12:47 AM, 杨镭 wrote: > Hi: > > In our setup(libvirt 0.9.9 with Arch Linux with kernel 3.2+), when libvirt are > accessed simultaneously, say 8 createDomain requests,  there is a large > chance that `qemu -help` return incomplete stdout which cause kvm to be > disabled. > > Anothe

Re: [libvirt] [PATCH 1/2] Add a new flag VIR_DOMAIN_CPU_STATS_F_VCPU to virDomainGetCPUStats

2012-04-18 Thread Eric Blake
On 04/18/2012 05:14 AM, Hu Tao wrote: > Currently virDomainGetCPUStats gets total cpu usage, which consists > of: > > 1. vcpu usage: the physical cpu time consumed by virtual cpu(s) of > domain > 2. hypervisor: `total cpu usage' - `vcpu usage' > > The flag VIR_DOMAIN_CPU_STATS_F_VCPU is

[libvirt] [PATCH] cpu: Improve error reporting on incompatible CPUs

2012-04-18 Thread Peter Krempa
This patch modifies the CPU comparrison function to report the incompatibilities in more detail to ease identification of problems. * src/cpu/cpu.h: cpuGuestData(): Add argument to return detailed error message. * src/cpu/cpu.c: cpuGuestData(): Add passthrough for error argument. * src/cpu

Re: [libvirt] VN-Link vNIC memory state copying on VM Migration

2012-04-18 Thread Jagath Weerasinghe
Chris Thanks Jagath On Wed, Apr 18, 2012 at 3:40 AM, Christian Benvenuti (benve) wrote: >> -Original Message- >> From: Jagath Weerasinghe [mailto:jagf...@gmail.com] >> Sent: Tuesday, April 17, 2012 8:19 AM >> To: Christian Benvenuti (benve) >> Cc: libvir-list@redhat.com >> Subject: Re:

Re: [libvirt] [PATCHv5 04/23] blockjob: add new API flags

2012-04-18 Thread Jiri Denemark
On Mon, Apr 16, 2012 at 23:05:55 -0600, Eric Blake wrote: > This patch introduces a new block job, useful for live storage > migration using pre-copy streaming. Justification for including > this under virDomainBlockRebase rather than adding a new command > includes: 1) there are now two possible

Re: [libvirt] [PATCHv5 05/23] blockjob: add 'blockcopy' to virsh

2012-04-18 Thread Jiri Denemark
On Mon, Apr 16, 2012 at 23:05:56 -0600, Eric Blake wrote: > Rather than further overloading 'blockpull', I decided to create a > new virsh command to expose the new flags of virDomainBlockRebase. > > Blocking until the command completes naturally is pointless, since > the block copy job is intende

Re: [libvirt] [PATCHv5 06/23] blockjob: enhance xml to track mirrors across libvirtd restart

2012-04-18 Thread Jiri Denemark
On Mon, Apr 16, 2012 at 23:05:57 -0600, Eric Blake wrote: > In order to track a block copy job across libvirtd restarts, we > need to save internal XML that tracks the name of the file > holding the mirror. Displaying this name in dumpxml might also > be useful to the user, even if we don't yet ha

Re: [libvirt] [PATCHv5 04/23] blockjob: add new API flags

2012-04-18 Thread Paolo Bonzini
Il 18/04/2012 16:18, Jiri Denemark ha scritto: > However, the question is whether we feel comfortable enough with pushing this > with the risk that qemu implementation is not upstream yet. I think the API is > sane but the history of pushing something that qemu ended up implementing in a > differen

Re: [libvirt] [PATCH 2/2] Adds support to VIR_DOMAIN_CPU_STATS_F_VCPU in qemu_driver.

2012-04-18 Thread Eric Blake
On 04/18/2012 05:14 AM, Hu Tao wrote: > --- > src/qemu/qemu_driver.c | 152 ++- > src/util/cgroup.c |4 +- > tools/virsh.c | 17 -- > 3 files changed, 150 insertions(+), 23 deletions(-) Commit message is too sparse. You are mix

Re: [libvirt] [test-API 00/10] Reorgnize/refactoring round 2

2012-04-18 Thread Osier Yang
On 2012年04月18日 13:49, Osier Yang wrote: This should be the second round to reorgnize/refactor the codes. What this round does: * New directory "conf"; Move $root/*.cfg into it * New directory "src"; Move $root/*.{py,css,xls} into it (except the main program libvirt-test-api.py) * R

Re: [libvirt] [PATCHv5 06/23] blockjob: enhance xml to track mirrors across libvirtd restart

2012-04-18 Thread Eric Blake
On 04/18/2012 08:23 AM, Jiri Denemark wrote: > On Mon, Apr 16, 2012 at 23:05:57 -0600, Eric Blake wrote: >> In order to track a block copy job across libvirtd restarts, we >> need to save internal XML that tracks the name of the file >> holding the mirror. Displaying this name in dumpxml might als

Re: [libvirt] [PATCH 3] add parameter flags to D.get_cpu_stats()

2012-04-18 Thread Eric Blake
On 04/18/2012 05:14 AM, Hu Tao wrote: > --- > examples/get_cpu_stats.ml |2 +- > libvirt/libvirt.ml |2 +- > libvirt/libvirt.mli |2 +- > libvirt/libvirt_c_oneoffs.c |9 + > 4 files changed, 8 insertions(+), 7 deletions(-) > > +++ b/libvirt/libvirt_c_one

Re: [libvirt] [PATCH 3] add parameter flags to D.get_cpu_stats()

2012-04-18 Thread Richard W.M. Jones
On Wed, Apr 18, 2012 at 09:18:45AM -0600, Eric Blake wrote: > On 04/18/2012 05:14 AM, Hu Tao wrote: > > --- > > examples/get_cpu_stats.ml |2 +- > > libvirt/libvirt.ml |2 +- > > libvirt/libvirt.mli |2 +- > > libvirt/libvirt_c_oneoffs.c |9 + > > 4 files

Re: [libvirt] [PATCH v2] util: only register callbacks for CREATE operations in virnetdevmacvlan.c

2012-04-18 Thread Laine Stump
On 04/18/2012 07:09 AM, D. Herrendoerfer wrote: > From: "D. Herrendoerfer" > > currently upon a migration a callback is created when a 802.1qbg link > is set to PREASSOCIATE, this should not happen because this is > a no-op on most switches, and does not lead to an ASSOCIATE state. > This patch on

[libvirt] [PATCH v2 0/9] Add basic driver for Parallels Virtuozzo Server

2012-04-18 Thread Dmitry Guryanov
Parallels Virtuozzo Server is a cloud-ready virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server. Current name of this product is Parallels Server Bare Metal and more information about it can be found here - http://www

[libvirt] [PATCH v2 2/9] util: add functions for interating over json object

2012-04-18 Thread Dmitry Guryanov
Add function virJSONValueObjectKeysNumber, virJSONValueObjectGetKey and virJSONValueObjectGetValue, which allow you to iterate over all fields of json object: you can get number of fields and then get name and value, stored in field with that name by index. Signed-off-by: Dmitry Guryanov --- src

[libvirt] [PATCH v2 5/9] pvs: get info about serial ports

2012-04-18 Thread Dmitry Guryanov
Add support of collecting information about serial ports. This change is needed mostly as an example, support of other devices will be added later. Signed-off-by: Dmitry Guryanov --- src/pvs/pvs_driver.c | 115 ++ 1 files changed, 115 insertions(+

[libvirt] [PATCH v2 4/9] pvs: implement functions for domain life cycle management

2012-04-18 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov --- src/pvs/pvs_driver.c | 148 ++ src/pvs/pvs_driver.h |1 + src/pvs/pvs_utils.c | 18 ++ 3 files changed, 167 insertions(+), 0 deletions(-) diff --git a/src/pvs/pvs_driver.c b/src/pvs/pvs_driver.c index

[libvirt] [PATCH v2 9/9] pvs: implement VM creation

2012-04-18 Thread Dmitry Guryanov
To create a new VM in PVS we should issue "prlctl create" command, and give path to the directory, where VM should be created. VM's storage will be in that directory later. So in this first version find out location of first VM's hard disk and create VM there. Signed-off-by: Dmitry Guryanov ---

[libvirt] [PATCH v2 6/9] pvs: add support of VNC remote display

2012-04-18 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov --- src/pvs/pvs_driver.c | 65 ++ 1 files changed, 65 insertions(+), 0 deletions(-) diff --git a/src/pvs/pvs_driver.c b/src/pvs/pvs_driver.c index a4d9ecf..2886736 100644 --- a/src/pvs/pvs_driver.c +++ b/src/pvs/pv

[libvirt] [PATCH v2 8/9] pvs: add storage driver

2012-04-18 Thread Dmitry Guryanov
PVS has one serious discrepancy with libvirt: libvirt stores domain configuration files always in one place, and storage files in other places (with API of storage pools and storage volumes). PVS store all domain data in a single directory, for example, you may have domain with name fedora-15, whic

[libvirt] [PATCH v2 7/9] pvs: implement virDomainDefineXML operation for existing domains

2012-04-18 Thread Dmitry Guryanov
Add pvsDomainDefineXML functions, it works only for existing domains for the present. It's too hard to convert libvirt's XML domain configuration into PVS's one, so I've decided to compare virDomainDef structures: current domain definition and the one created from XML, given to the function. And c

[libvirt] [PATCH v2 3/9] pvs: add functions to list domains and get info

2012-04-18 Thread Dmitry Guryanov
PVS driver is 'stateless', like vmware or openvz drivers. It collects information about domains during startup using command-line utility prlctl. VMs in PVS identified by UUIDs or unique names, which can be used as respective fields in virDomainDef structure. Currently only basic info, like descrip

Re: [libvirt] [PATCH v2 3/9] pvs: add functions to list domains and get info

2012-04-18 Thread Stefan Berger
On 04/18/2012 02:07 PM, Dmitry Guryanov wrote: PVS driver is 'stateless', like vmware or openvz drivers. It collects information about domains during startup using command-line utility prlctl. VMs in PVS identified by UUIDs or unique names, which can be used as respective fields in virDomainDef s

Re: [libvirt] [PATCH v2 6/9] pvs: add support of VNC remote display

2012-04-18 Thread Stefan Berger
On 04/18/2012 02:07 PM, Dmitry Guryanov wrote: Signed-off-by: Dmitry Guryanov --- [...] */ @@ -397,6 +459,9 @@ pvsLoadDomain(pvsConnPtr privconn, virJSONValuePtr jobj) if (pvsAddDomainHardware(dom, jobj2)) goto cleanup_unlock; +if (pvsAddVNCInfo(dom, jobj)) Nit: check

[libvirt] CfP 7th Workshop on Virtualization in High-Performance Cloud Computing (VHPC'12)

2012-04-18 Thread VHPC 11
we apologize if you receive multiple copies of this CFP. === CALL FOR PAPERS 7th Workshop on Virtualization in High-Performance Cloud Computing VHPC '12 as part of Euro-Par 2012, Rhodes Island, Greece ===

Re: [libvirt] [PATCH v2 8/9] pvs: add storage driver

2012-04-18 Thread Stefan Berger
On 04/18/2012 02:07 PM, Dmitry Guryanov wrote: PVS has one serious discrepancy with libvirt: libvirt stores domain configuration files always in one place, and storage files in other places (with API of storage pools and storage volumes). PVS store all domain data in a single directory, for examp

Re: [libvirt] [PATCH v2 9/9] pvs: implement VM creation

2012-04-18 Thread Stefan Berger
On 04/18/2012 02:07 PM, Dmitry Guryanov wrote: To create a new VM in PVS we should issue "prlctl create" command, and give path to the directory, where VM should be created. VM's storage will be in that directory later. So in this first version find out location of first VM's hard disk and create

[libvirt] [PATCH 3/5] move list of default config files to an array

2012-04-18 Thread Eduardo Habkost
More files will be added to the list, with additional attributes, later. Signed-off-by: Eduardo Habkost --- arch_init.c | 25 - 1 files changed, 16 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 152cbbb..62332e9 100644 --- a/arch_init.c +++

[libvirt] [PATCH 0/5] -no-user-config option, move CPU models to /usr/share

2012-04-18 Thread Eduardo Habkost
This is the first try of the new -no-user-config option. Patches 1 to 3 just move some code around, patch 4 just adds the new option without adding any new config file. Patch 5 finally creates a /usr/share/qemu /cpus-x86_64.conf file, with the CPU models we currently have on Qemu. Reference to pr

[libvirt] [PATCH 1/5] move code to read default config files to a separate function

2012-04-18 Thread Eduardo Habkost
Function added to arch_init.c because it depends on arch-specific settings. Signed-off-by: Eduardo Habkost --- arch_init.c | 18 ++ arch_init.h |4 vl.c| 10 ++ 3 files changed, 24 insertions(+), 8 deletions(-) diff --git a/arch_init.c b/arch_init.c

[libvirt] [PATCH 4/5] implement -no-user-config command-line option

2012-04-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- arch_init.c | 10 +++--- arch_init.h |2 +- qemu-options.hx | 16 +--- vl.c|6 +- 4 files changed, 26 insertions(+), 8 deletions(-) diff --git a/arch_init.c b/arch_init.c index 62332e9..c5fc00f 100644 --- a/ar

[libvirt] [PATCH 2/5] eliminate arch_config_name variable

2012-04-18 Thread Eduardo Habkost
Not needed anymore, as the code that uses the variable is already inside arch_init.c. Signed-off-by: Eduardo Habkost --- arch_init.c |3 +-- arch_init.h |2 -- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index 4008115..152cbbb 100644 --- a/arc

[libvirt] [PATCH 5/5] move CPU definitions to /usr/share/qemu/cpus-x86_64.conf

2012-04-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Makefile | 12 +++- arch_init.c |1 + sysconfigs/target/cpus-x86_64.conf | 128 ++ sysconfigs/target/target-x86_64.conf | 128 -- 4 fil

Re: [libvirt] [PATCHv5 08/23] blockjob: add qemu capabilities related to block jobs

2012-04-18 Thread Laine Stump
On 04/17/2012 01:05 AM, Eric Blake wrote: > The new block copy storage migration sequence requires both the > 'drive-mirror' and 'drive-reopen' monitor commands, which have > been proposed[1] for qemu 1.1. Someday (probably for qemu 1.2), > these commands may also be added to the 'transaction' mon

Re: [libvirt] [PATCH V10 0/7] Add DHCP snooping support to nwfilter

2012-04-18 Thread dennis jenkins
On Tue, Apr 17, 2012 at 6:57 PM, Stefan Berger wrote: > > Let me know when you tested it. I have pretty high confidence in the > correctness of the code now :-) > > Regards, > Stefan > > Short version: I got an error "internal error IP parameter must be provided since snooping the IP addres

Re: [libvirt] [PATCHv5 08/23] blockjob: add qemu capabilities related to block jobs

2012-04-18 Thread Eric Blake
On 04/18/2012 02:18 PM, Laine Stump wrote: > On 04/17/2012 01:05 AM, Eric Blake wrote: >> The new block copy storage migration sequence requires both the >> 'drive-mirror' and 'drive-reopen' monitor commands, which have >> been proposed[1] for qemu 1.1. Someday (probably for qemu 1.2), >> these co

Re: [libvirt] [PATCH V10 0/7] Add DHCP snooping support to nwfilter

2012-04-18 Thread Stefan Berger
On 04/18/2012 04:54 PM, dennis jenkins wrote: On Tue, Apr 17, 2012 at 6:57 PM, Stefan Berger mailto:stef...@linux.vnet.ibm.com>> wrote: Let me know when you tested it. I have pretty high confidence in the correctness of the code now :-) Regards, Stefan Short version:

[libvirt] [PATCH] util: remove dead casts

2012-04-18 Thread Eric Blake
The sequence: long long val; if ((long long) val != val) is dead code. * src/util/util.c (virStrToLong_ll, virStrToLong_ull): Remove useless cast. --- Pushing under the trivial rule. src/util/util.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/util.c

[libvirt] [PATCH 1/3] virsh: avoid strtol

2012-04-18 Thread Eric Blake
We were forgetting to check errno for overflow. * tools/virsh.c (get_integer_keycode, vshCommandOptInt) (vshCommandOptUInt, vshCommandOptUL, vshCommandOptLongLong) (vshCommandOptULongLong): Rewrite to be safer. --- tools/virsh.c | 66 1 f

[libvirt] [libvirt-glib] Add async variant of gvir_domain_get_info()

2012-04-18 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- libvirt-gobject/libvirt-gobject-domain.c | 74 ++ libvirt-gobject/libvirt-gobject-domain.h |7 +++ libvirt-gobject/libvirt-gobject.sym |2 + 3 files changed, 83 insertions(+), 0 deletions(-) diff --git a/libvirt-gobjec

[libvirt] [PATCH 2/3] conf: tighten up XML integer parsing

2012-04-18 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=617711 reported that even with my recent patched to allow 1, people can still get away with trying 1G and silently get 1 instead. While virt-xml-validate catches the error, our C parser was not. I always love it when I can reduce lines of code while fix

[libvirt] [PATCH 3/3] build: avoid strtol and strtod

2012-04-18 Thread Eric Blake
Ensure we don't introduce any more lousy integer parsing in new code, while avoiding a scrub-down of existing legacy code. Note that we also need to enable sc_prohibit_atoi_atof (see cfg..mk local-checks-to-sckip) before we are bulletproof, but that also entails scrubbing I'm not ready to do at th

[libvirt] [PATCH 0/3] tighten up integer parsing

2012-04-18 Thread Eric Blake
I thought my recent improvements to parsing were complete, until I stumbled upon https://bugzilla.redhat.com/show_bug.cgi?id=617711, which shows a file that fails 'virt-xml-validate' but was silently accepted, and worse, misintepreted the user's intentions. I didn't have time to scrub the entire

Re: [libvirt] [libvirt-glib] Add async variant of gvir_domain_get_info()

2012-04-18 Thread Marc-André Lureau
On Thu, Apr 19, 2012 at 2:12 AM, Zeeshan Ali (Khattak) wrote: > +/** > + * gir_domain_get_info_async: You have a couple of s/gir/gvir to do > + * gir_domain_get_info_finish: here too > +++ b/libvirt-gobject/libvirt-gobject.sym > @@ -70,6 +70,8 @@ LIBVIRT_GOBJECT_0.0.7 { >        gvir_domain_se

Re: [libvirt] [PATCH 1/3] virsh: avoid strtol

2012-04-18 Thread Stefan Berger
On 04/18/2012 08:14 PM, Eric Blake wrote: We were forgetting to check errno for overflow. * tools/virsh.c (get_integer_keycode, vshCommandOptInt) (vshCommandOptUInt, vshCommandOptUL, vshCommandOptLongLong) (vshCommandOptULongLong): Rewrite to be safer. --- tools/virsh.c | 66

[libvirt] [PATCH 0/2 v3 use qemu's dump-guest-meory when vm uses host device

2012-04-18 Thread Wen Congyang
Currently, we use migrate to dump guest's memory. There is one restriction in migrate command: the device's status should be stored in qemu because the device's status should be passed to target machine. If we passthrough a host device to guest, the device's status is stored in the real device. So

[libvirt] [PATCH 2/2 v3] qemu: try to use qemu's dump-guest-meory when vm uses host device

2012-04-18 Thread Wen Congyang
--- src/qemu/qemu_domain.c |1 + src/qemu/qemu_domain.h |1 + src/qemu/qemu_driver.c | 39 +-- 3 files changed, 39 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 69d9e6e..e3a668a 100644 --- a/src/qemu/

[libvirt] [PATCH 1/2 v3] qemu: implement qemu's dump-guest-memory

2012-04-18 Thread Wen Congyang
--- src/qemu/qemu_monitor.c | 36 src/qemu/qemu_monitor.h | 13 + src/qemu/qemu_monitor_json.c | 42 ++ src/qemu/qemu_monitor_json.h |7 +++ 4 files changed, 98 insertions(+), 0 deletio

Re: [libvirt] [PATCH 2/3] conf: tighten up XML integer parsing

2012-04-18 Thread Stefan Berger
On 04/18/2012 08:14 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=617711 reported that even with my recent patched to allow1, people can still get away with trying1G and silently get1 instead. While virt-xml-validate catches the error, our C parser was not. I always love i

Re: [libvirt] [PATCH 3/3] build: avoid strtol and strtod

2012-04-18 Thread Stefan Berger
On 04/18/2012 08:14 PM, Eric Blake wrote: Ensure we don't introduce any more lousy integer parsing in new code, while avoiding a scrub-down of existing legacy code. Note that we also need to enable sc_prohibit_atoi_atof (see cfg..mk local-checks-to-sckip) before we are bulletproof, but that also

[libvirt] [test-API 01/14] Change libvirt-test-api to be executable

2012-04-18 Thread Osier Yang
And remove the redundant "python" in usage string. --- libvirt-test-api | 16 1 files changed, 8 insertions(+), 8 deletions(-) mode change 100644 => 100755 libvirt-test-api diff --git a/libvirt-test-api b/libvirt-test-api old mode 100644 new mode 100755 index 373e5c6..7eaaf21

[libvirt] [test-API 00/14] Reorgnize/refactoring round 3

2012-04-18 Thread Osier Yang
The TODO in round 2 is still not done, but let's get these cleanups reviewed first. Osier Yang (14): Change libvirt-test-api to be executable Remove NEWS and TODO Destroy utils/check.py and move the functions into utils/utils.py Move directory dist to src Move utils/env_parser.py into sr

[libvirt] [test-API 07/14] Improve more comments to tell what the program does

2012-04-18 Thread Osier Yang
--- src/dist/redhat/env_inspect.py |5 ++--- src/exception.py |7 ++- src/logxmlparser.py|7 ++- src/process.py |7 ++- 4 files changed, 8 insertions(+), 18 deletions(-) diff --git a/src/dist/redhat/env_inspect.py b/src/dist/re

[libvirt] [test-API 04/14] Move directory dist to src

2012-04-18 Thread Osier Yang
env_inspect.py is part of the framework. --- {dist => src/dist}/__init__.py |0 {dist => src/dist}/redhat/__init__.py|0 {dist => src/dist}/redhat/env_inspect.py |0 src/generator.py |4 ++-- 4 files changed, 2 insertions(+), 2 deletions(-) re

[libvirt] [test-API 02/14] Remove NEWS and TODO

2012-04-18 Thread Osier Yang
We don't have a release cycle, and seems we will never update TODO --- TODO |4 1 files changed, 0 insertions(+), 4 deletions(-) delete mode 100644 NEWS delete mode 100644 TODO diff --git a/NEWS b/NEWS deleted file mode 100644 index e69de29..000 diff --git a/TODO b/TODO deleted fil

[libvirt] [test-API 05/14] Move utils/env_parser.py into src

2012-04-18 Thread Osier Yang
env_parser.py is to parse env.cfg, which is part of the framework. --- repos/domain/install_image.py |2 +- repos/domain/install_linux_cdrom.py |2 +- repos/domain/install_linux_check.py |2 +- repos/domain/install_linux_net.py |2 +- repos/domain/install_windows_cd

[libvirt] [test-API 09/14] Use bash as the interpreter explicitly

2012-04-18 Thread Osier Yang
--- utils/dev_num.sh |2 +- utils/disk_num.sh |2 +- utils/ipget.sh|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/dev_num.sh b/utils/dev_num.sh index 5e79313..552721b 100755 --- a/utils/dev_num.sh +++ b/utils/dev_num.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/b

[libvirt] [test-API 03/14] Destroy utils/check.py and move the functions into utils/utils.py

2012-04-18 Thread Osier Yang
Scripts which use 'check.py' are updated to use "utils.py". --- repos/domain/balloon_memory.py |2 +- repos/domain/dump.py|2 +- repos/domain/install_linux_check.py | 15 +- repos/snapshot/file_flag.py |3 +- repos/snapshot/flag_check.py|3 +-

[libvirt] [test-API 11/14] Update AUTHORS

2012-04-18 Thread Osier Yang
Sorted by the contribution date, not exactly. --- AUTHORS | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/AUTHORS b/AUTHORS index 55cd38d..4ec4ca8 100644 --- a/AUTHORS +++ b/AUTHORS @@ -1,14 +1,15 @@ +Maintainers and people with commit rights:: -The prima

[libvirt] [test-API 08/14] Remove trainling blank lines for utils/*.sh

2012-04-18 Thread Osier Yang
--- utils/dev_num.sh |3 --- utils/disk_num.sh |3 --- 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/utils/dev_num.sh b/utils/dev_num.sh index 9f50398..5e79313 100755 --- a/utils/dev_num.sh +++ b/utils/dev_num.sh @@ -23,6 +23,3 @@ else rm -f guestdump.xml exit 1

[libvirt] [test-API 06/14] Improve the comments telling what the scripts does for utils/*.py

2012-04-18 Thread Osier Yang
What GNU recommends: Copyright (C) --- v1 was ACKed, but I forgot to push it, this is a rebasing on the same files (some of them are moved to different place). --- src/env_parser.py |6 ++ utils/XMLParser.py|7 ++- utils/format.py |6 ++ utils/lo

[libvirt] [test-API 13/14] Rename src/logxmlparser.py as src/log_generator.py

2012-04-18 Thread Osier Yang
>From the codes, it's to generator the output log in XML format, but not to parse. The class name is also changed from "Logxml_parser" to "LogGenerator". --- libvirt-test-api |8 src/{logxmlparser.py => log_generator.py} |4 ++-- 2 files changed, 6 inserti

[libvirt] [test-API 12/14] Rename utils/*.py with consistent naming style

2012-04-18 Thread Osier Yang
We use foo_bar across the project (except the main program), though it might be not good to use "foo_bar" as the module name in Python, but let's unify it first. --- .../en-US/Understanding_libvirt-test-API.xml |4 +- .../en-US/Writing_a_test_case.xml |8 ++-- libvir

[libvirt] [test-API 14/14] Rename 'env.cfg' as 'global.cfg'

2012-04-18 Thread Osier Yang
It's not only about environment actually, many default settings are defined in it. --- env.cfg => global.cfg |0 repos/domain/install_image.py |2 +- repos/domain/install_linux_cdrom.py|2 +- repos/domain/install_linux_c

[libvirt] [RFC][PATCH] Revision for message payload encoding error when adding a large mount of virtio disks

2012-04-18 Thread Chen Hanxiao
From: Chen Hanxiao When adding a large number of virtio storage devices to virtual machine by using 'virsh edit' command, there is a problem: When we added more than 190 virtio disks by 'virsh edit' command, we got a feedback as 'error: Unable to encode message payload'. In virt-mananger, the sam