Detected by valgrind. Leaks are introduced in commit 122fa379.
src/conf/storage_conf.c: fix memory leaks.
How to reproduce?
$ make make -C tests check TESTS=storagepoolxml2xmltest
$ cd tests valgrind -v --leak-check=full ./storagepoolxml2xmltest
actual result:
==28571== LEAK SUMMARY:
Hi~
Users can use vcpupin command to bind a vcpu thread to a specific physical cpu.
But besides vcpu threads, there are alse some other threads created by qemu
(known as hypervisor threads) that could not be explicitly bound to physical
cpus.
This 10 patches implemented hypervisor threads
This patch enables cpuset cgroup, and synchronous vcpupin info set by
sched_setaffinity() to cgroup.
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
src/qemu/qemu_cgroup.c | 47 +++
src/qemu/qemu_cgroup.h |2 ++
src/qemu/qemu_driver.c |
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
docs/schemas/domaincommon.rng |7 ++
src/conf/domain_conf.c | 96 ++-
src/conf/domain_conf.h |1 +
tests/qemuxml2argvdata/qemuxml2argv-cputune.xml
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
src/qemu/qemu_cgroup.c | 41 +
src/qemu/qemu_cgroup.h |1 +
2 files changed, 42 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index a123a00..2d8d9ee
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
src/qemu/qemu_process.c | 54 +++
1 files changed, 54 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index b605eee..33f65e1 100644
---
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
src/remote/remote_driver.c | 102 ++
src/remote/remote_protocol.x | 24 +-
src/remote_protocol-structs | 24 ++
3 files changed, 149 insertions(+), 1 deletions(-)
diff --git
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
src/driver.h | 13 +++-
src/qemu/qemu_driver.c | 223
2 files changed, 235 insertions(+), 1 deletions(-)
diff --git a/src/driver.h b/src/driver.h
index 03d249b..18f7f26 100644
---
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
daemon/remote.c | 103 +++
1 files changed, 103 insertions(+), 0 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index 16a8a05..524c4bf 100644
--- a/daemon/remote.c
+++
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
include/libvirt/libvirt.h.in |9 +++
src/libvirt.c| 147 ++
src/libvirt_public.syms |2 +
3 files changed, 158 insertions(+), 0 deletions(-)
diff --git
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
src/conf/domain_conf.c | 76 ++
src/conf/domain_conf.h |6
src/libvirt_private.syms |2 +
3 files changed, 84 insertions(+), 0 deletions(-)
diff --git a/src/conf/domain_conf.c
Hi~
Forgot to mention that this patch set is based on Wen Congyang's patch set:
support to set cpu bandwidth for hypervisor threads
https://www.redhat.com/archives/libvir-list/2012-April/msg01326.html
Wen's patches should be applied first.
Thanks.:)
On 05/09/2012 02:08 PM, tangchen wrote:
Signed-off-by: Tang Chen tangc...@cn.fujitsu.com
---
tests/vcpupin |6 +-
tools/virsh.c | 145 +--
tools/virsh.pod | 16 --
3 files changed, 110 insertions(+), 57 deletions(-)
diff --git a/tests/vcpupin b/tests/vcpupin
index
ibmvscsi is based on spapr-vio bus address type.
It can't work on PCI bus. Now, it is still on
pci bus.
This patch is to assign spapr-vio address type
to ibmvscsi controller.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/qemu/qemu_command.c |1 +
1 file changed, 1 insertion(+)
On 2012年05月09日 14:15, Alex Jia wrote:
Detected by valgrind. Leaks are introduced in commit 122fa379.
src/conf/storage_conf.c: fix memory leaks.
How to reproduce?
$ make make -C tests check TESTS=storagepoolxml2xmltest
$ cd tests valgrind -v --leak-check=full ./storagepoolxml2xmltest
actual
On 05/09/2012 08:15 AM, Alex Jia wrote:
Detected by valgrind. Leaks are introduced in commit 122fa379.
src/conf/storage_conf.c: fix memory leaks.
How to reproduce?
$ make make -C tests check TESTS=storagepoolxml2xmltest
$ cd tests valgrind -v --leak-check=full ./storagepoolxml2xmltest
With machine option,user can specify macine type to emulate.
For example : define in xml file , machine='pc' or machine='pseries'.
Signed-off-by: Qing Lin qing...@linux.vnet.ibm.com
---
repos/domain/create.py |1 +
repos/domain/define.py
On 2012年05月09日 16:17, Qing Lin wrote:
With machine option,user can specify macine type to emulate.
For example : define in xml file , machine='pc' or machine='pseries'.
Signed-off-by: Qing Linqing...@linux.vnet.ibm.com
ACK, and pushed.
Osier
--
libvir-list mailing list
On Wed, May 02, 2012 at 01:43:03PM -0600, Eric Blake wrote:
On 04/24/2012 03:20 AM, Hu Tao wrote:
Currently virDomainGetCPUStats gets total cpu usage, which consists
of:
1. vcpu usage: the physical cpu time consumed by virtual cpu(s) of
domain
2. hypervisor: `total cpu
On 05/09/2012 04:06 PM, Peter Krempa wrote:
On 05/09/2012 08:15 AM, Alex Jia wrote:
Detected by valgrind. Leaks are introduced in commit 122fa379.
src/conf/storage_conf.c: fix memory leaks.
How to reproduce?
$ make make -C tests check TESTS=storagepoolxml2xmltest
$ cd tests valgrind -v
Currently virDomainGetCPUStats gets total cpu usage, which consists
of:
1. vcpu usage: the physical cpu time consumed by virtual cpu(s) of
domain
2. hypervisor: `total cpu usage' - `vcpu usage'
The param 'vcpu_time' is for getting vcpu usages.
---
include/libvirt/libvirt.h.in |6
---
src/qemu/qemu_driver.c | 166 ++--
src/util/cgroup.c |4 +-
tools/virsh.c |2 +-
3 files changed, 164 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2bec617..1480666 100644
we use 4 spaces for the indention in Shell codes.
fix the uncompliance in ksiso.sh.
Signed-off-by: Qing Linqing...@linux.vnet.ibm.com
---
utils/ksiso.sh | 51 +++
1 files changed, 27 insertions(+), 24 deletions(-)
diff --git a/utils/ksiso.sh
On 05/09/2012 04:01 PM, Osier Yang wrote:
On 2012年05月09日 14:15, Alex Jia wrote:
Detected by valgrind. Leaks are introduced in commit 122fa379.
src/conf/storage_conf.c: fix memory leaks.
How to reproduce?
$ make make -C tests check TESTS=storagepoolxml2xmltest
$ cd tests valgrind -v
show `vcpu usages' by `virt-top -1'
Before this patch, `virt-top -1' shows total cpu usages
which euqal to `vcpu usages' + `hypervisor usages'. This
patch adds another column for domains showing `vcpu
usages'. An example is:
PHYCPU %CPU example_domain
0 10.4 10.4 0.8
11.6 1.6 1.4
This parameter is to indicate wheter to get total cpu statistic
or per_cpu statistics.
---
examples/get_cpu_stats.ml | 48 ++---
libvirt/libvirt.ml |2 +-
libvirt/libvirt.mli |4 +-
libvirt/libvirt_c_oneoffs.c | 83
remove the value because we can get it from the libvirt API
---
examples/.depend|4 ++--
examples/get_cpu_stats.ml |2 +-
libvirt/.depend |6 +++---
libvirt/libvirt.ml |2 +-
libvirt/libvirt.mli |4 ++--
libvirt/libvirt_c_oneoffs.c |
On Wed, May 09, 2012 at 02:51:21PM +0800, Li Zhang wrote:
ibmvscsi is based on spapr-vio bus address type.
It can't work on PCI bus. Now, it is still on
pci bus.
This patch is to assign spapr-vio address type
to ibmvscsi controller.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
On 05/09/2012 10:45 AM, Alex Jia wrote:
On 05/09/2012 04:06 PM, Peter Krempa wrote:
The problem with the added line is not visible with this context, so
I'm adding
some more:
source-nhost = virXPathNodeSet(./host, ctxt,nodeset);
if (source-nhost) {
if (VIR_ALLOC_N(source-hosts, source-nhost)
Commit 642973135c54b93242c4548ef27d591b52b0994c added three direct
references to nl_handle_* instead of using our aliases which hide
differences between libnl-3 and libnl-1.
---
Pushed as a build-breaker.
src/util/virnetlink.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
On 05/09/2012 05:50 PM, Peter Krempa wrote:
On 05/09/2012 10:45 AM, Alex Jia wrote:
On 05/09/2012 04:06 PM, Peter Krempa wrote:
The problem with the added line is not visible with this context, so
I'm adding
some more:
source-nhost = virXPathNodeSet(./host, ctxt,nodeset);
if (source-nhost) {
Detected by valgrind. Leaks are introduced in commit 122fa379.
src/conf/storage_conf.c: fix memory leaks.
How to reproduce?
$ make make -C tests check TESTS=storagepoolxml2xmltest
$ cd tests valgrind -v --leak-check=full ./storagepoolxml2xmltest
actual result:
==28571== LEAK SUMMARY:
On Sat, May 05, 2012 at 02:46:31AM +0200, Marc-André Lureau wrote:
Allow to specify preallocation mode for QCOW2 images.
If not specified or not available, it's ignored.
This change only modify the schema, doc, parsing and tests.
---
docs/formatstorage.html.in |6 ++
On Sat, May 05, 2012 at 02:46:32AM +0200, Marc-André Lureau wrote:
+if (vol-target.format != VIR_STORAGE_FILE_QCOW2 with_preallocation) {
+virStorageReportError(VIR_ERR_INTERNAL_ERROR,
+ _(Preallocation is only available with
qcow2));
+
On Wed, May 9, 2012 at 12:55 PM, Christophe Fergeau cferg...@redhat.com wrote:
). I think it would be nicer to be consistent
with that for preallocation and not return an error either in this case.
I am not convinced this is the right thing to do. Perhaps sparse
allocation, or not, does not
On Wed, May 09, 2012 at 01:25:20PM +0200, Marc-André Lureau wrote:
On Wed, May 9, 2012 at 12:55 PM, Christophe Fergeau cferg...@redhat.com
wrote:
). I think it would be nicer to be consistent
with that for preallocation and not return an error either in this case.
I am not convinced this
Hi
On Wed, May 9, 2012 at 1:33 PM, Christophe Fergeau cferg...@redhat.com wrote:
Big speed difference during win7 installations? or are you thinking of
another big difference? sparse/non-sparse allocation can make a big
I guess it's mostly speed up in any appending write IO (20G for
win7..).
Allow to specify preallocation mode for QCOW2 images.
If not specified or not available, it's ignored.
This change only modify the schema, doc, parsing and tests.
---
docs/formatstorage.html.in |6 ++
docs/schemas/storagevol.rng | 18 ++
This does not seem to apply on top of master + PATCH 1/4 :-/
Christophe
On Wed, May 09, 2012 at 04:16:14AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
---
libvirt-gconfig/Makefile.am|
On Wed, May 9, 2012 at 4:17 PM, Christophe Fergeau cferg...@redhat.com wrote:
This does not seem to apply on top of master + PATCH 1/4 :-/
Sorry, I forgot to mention this capabilities series is on top the
other changes I sent earlier.
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
--
On Thu, May 03, 2012 at 06:27:09PM +0800, Daniel Veillard wrote:
A bit late compared to my estimate from last week, I have just tagged
the git tree and made an rc1 snapshot for testing:
ftp://libvirt.org/libvirt/libvirt-0.9.12-rc1.tar.gz
and currently pushing along the large set of
If users {net-,pool-,}edit but make a mistake in XML all changes
are permanently lost. However, if virsh is running in interactive
mode we can as user if he wants to re-edit the file and correct
the mistakes.
---
tools/console.c | 40 +---
tools/console.h |
On Wed, May 09, 2012 at 04:16:13AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-capabilities.c |4 -
libvirt-gobject/libvirt-gobject-connection.c | 104
Hey,
We are now working on adding the support for native USB devices on oVirt, and
we have some difficulties.
Please see the details/discussion below.
Thank you for your help,
Oved
- Forwarded Message -
From: Itamar Heim ih...@redhat.com
To: Michal Privoznik mpriv...@redhat.com
Cc:
On Wed, May 09, 2012 at 04:30:39PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 9, 2012 at 4:17 PM, Christophe Fergeau cferg...@redhat.com
wrote:
This does not seem to apply on top of master + PATCH 1/4 :-/
Sorry, I forgot to mention this capabilities series is on top the
other changes
On Wed, May 09, 2012 at 03:36:26PM +0200, Michal Privoznik wrote:
If users {net-,pool-,}edit but make a mistake in XML all changes
are permanently lost. However, if virsh is running in interactive
mode we can as user if he wants to re-edit the file and correct
the mistakes.
---
+
From: Daniel P. Berrange berra...@redhat.com
Sometimes it is useful to see the callpath for log messages.
This change enhances the log filter syntax so that stck traces
can be show by setting '1:+NAME' instead of '1:NAME'.
This results in output like:
2012-05-09 14:18:45.136+: 13314: debug
In libguestfs, we recently got rid of gettextize (or rather, we got
rid of the po/Makefile* cruft that gettextize produces).
We replaced it with a very simple 100 line Makefile.am which does the
same thing, without the many bugs and problems caused by gettextize
and autopoint:
Final
On Wed, May 09, 2012 at 04:16:15AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
---
libvirt-gconfig/Makefile.am|8 +
.../libvirt-gconfig-capabilities-guest-arch.c | 122
On 05/09/2012 02:38 AM, Hu Tao wrote:
Question: is it better to make the user call virDomainGetCPUStats twice
(once for total with flags==0, once for vcpu with flags=VCPU), where
there is a race between the two calls? Or should we instead return both
As Richard said, we already have had
On 05/09/2012 07:52 AM, Daniel P. Berrange wrote:
On Wed, May 09, 2012 at 03:36:26PM +0200, Michal Privoznik wrote:
If users {net-,pool-,}edit but make a mistake in XML all changes
are permanently lost. However, if virsh is running in interactive
mode we can as user if he wants to re-edit the
On 05/09/2012 04:49 AM, Alex Jia wrote:
Detected by valgrind. Leaks are introduced in commit 122fa379.
src/conf/storage_conf.c: fix memory leaks.
How to reproduce?
$ make make -C tests check TESTS=storagepoolxml2xmltest
$ cd tests valgrind -v --leak-check=full ./storagepoolxml2xmltest
On 05/09/2012 08:52 AM, Richard W.M. Jones wrote:
In libguestfs, we recently got rid of gettextize (or rather, we got
rid of the po/Makefile* cruft that gettextize produces).
We replaced it with a very simple 100 line Makefile.am which does the
same thing, without the many bugs and problems
On Wed, May 09, 2012 at 09:15:10AM -0600, Eric Blake wrote:
On 05/09/2012 08:52 AM, Richard W.M. Jones wrote:
In libguestfs, we recently got rid of gettextize (or rather, we got
rid of the po/Makefile* cruft that gettextize produces).
We replaced it with a very simple 100 line
Hi,
There's still one bit I'm missing, here is my understanding so far:
On Thu, May 03, 2012 at 12:53:10PM +0100, Daniel P. Berrange wrote:
On Thu, May 03, 2012 at 01:11:26PM +0200, Christophe Fergeau wrote:
Guest features (capabilities XML) - these are really just capabilities of
the
From: Daniel P. Berrange berra...@redhat.com
Introduce a new syntax for filesystems to allow use of a RAM
filesystem
filesystem type='ram'
source usage='1024'/
target dir='/mnt'/
/filesystem
The usasge is in KB to limit consumption of host memory.
* docs/formatdomain.html.in:
On 05/09/2012 09:49 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce a new syntax for filesystems to allow use of a RAM
filesystem
filesystem type='ram'
source usage='1024'/
target dir='/mnt'/
/filesystem
The usasge is in KB to
On Wed, May 09, 2012 at 05:47:19PM +0200, Christophe Fergeau wrote:
Hi,
There's still one bit I'm missing, here is my understanding so far:
On Thu, May 03, 2012 at 12:53:10PM +0100, Daniel P. Berrange wrote:
On Thu, May 03, 2012 at 01:11:26PM +0200, Christophe Fergeau wrote:
Guest
Sorry, I messed up the quoting while reviewing this, hope it's fine with my
comments inline in the patch (looking for lines not starting with + should
show all my comments), sorry for the inconvenience.
diff --git a/libvirt-gconfig/Makefile.am b/libvirt-gconfig/Makefile.am
index fd32c3d..54899a3
On Wed, May 09, 2012 at 05:01:25PM +0100, Daniel P. Berrange wrote:
Opps, no I was meaning /domain/cpu/feature here, which is the
same schem as /capabilities/host/cpu/feature.
Ah thanks, that clears things up.
I forgot there was also a /domain/features which corresponds
to
ACK
On Wed, May 09, 2012 at 03:54:34AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This function should set 'path' as attribute of 'source' node rather
than as child node.
---
.../libvirt-gconfig-domain-chardev-source-pty.c| 11 ---
1
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 05/09/2012 11:49 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce a new syntax for filesystems to allow use of a RAM filesystem
filesystem type='ram' source usage='1024'/ target dir='/mnt'/
/filesystem
This patch changes libxl to use the interface in Xen 4.2. It is provided
as an example, not intended to go in to libvirt as-is since it removes
all support for libxl from Xen 4.1. It also still has some cruft (extra
void casts on parameters) and the device model info population is not
written. It
No useful error was being reported when an invalid character device
target type is specified in the domainXML. E.g.
...
console type=pty
source path=/dev/pts/2/
target type=kvm port=0/
/console
...
resulted in
error: Failed to define domain from x.xml
error: An error
On 05/09/2012 11:48 AM, Jim Fehlig wrote:
No useful error was being reported when an invalid character device
target type is specified in the domainXML. E.g.
...
console type=pty
source path=/dev/pts/2/
target type=kvm port=0/
/console
...
resulted in
Eric Blake wrote:
On 05/09/2012 11:48 AM, Jim Fehlig wrote:
No useful error was being reported when an invalid character device
target type is specified in the domainXML. E.g.
...
console type=pty
source path=/dev/pts/2/
target type=kvm port=0/
/console
Running on linux and libvirt 0.9.11. Using libvirt java 0.4.7. Notice that the
Tomcat server crashes and shows the dump like this:
*** glibc detected *** jsvc.exec: double free or corruption (out): 0x086f14a8
***
=== Backtrace: =
/lib/libc.so.6[0xc03745]
On Wed, May 9, 2012 at 7:10 PM, Christophe Fergeau cferg...@redhat.com wrote:
+const gchar *
+gvir_config_capabilities_cpu_feature_get_name(GVirConfigCapabilitiesCpuFeature
*caps)
s/caps/feature
I was thinking of using 'caps' for all GVirConfigCapabilities*
instances but no strong feelings
ping
On 04/30/2012 02:54 PM, Eric Blake wrote:
Based on a report by Seth Vidal. Just because _you_ can use virsh
to connect to both source and destinations does not mean that libvirtd
on the source (aka _root_) can likewise connect to the destination;
this matters when setting up a
On Wed, May 9, 2012 at 5:54 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Wed, May 09, 2012 at 04:16:15AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
+{
+ g_debug(Init GVirConfigCapabilitiesGuest=%p,
Commit 97010eb1f forgot to change the other side of an #ifdef.
* src/qemu/qemu_process.c (qemuProcessInitNumaMemoryPolicy): Add
argument.
---
Pushing under the build-breaker rule.
src/qemu/qemu_process.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git
Add element forward to add TCP or UDP port redirection from host to
guest in user mode networking.
---
docs/formatdomain.html.in| 21
docs/schemas/domaincommon.rng| 29 +
src/conf/domain_conf.c | 140
Implement port forwarding for user mode networking with QEMU.
---
src/libvirt_private.syms |3 +
src/qemu/qemu_command.c | 115 +
tests/qemuargv2xmltest.c |3 +-
Thanks and pushed now.
- Original Message -
From: Eric Blake ebl...@redhat.com
To: Alex Jia a...@redhat.com
Cc: libvir-list@redhat.com
Sent: Wednesday, May 9, 2012 11:03:50 PM
Subject: Re: [libvirt] [PATCHv2] conf: Fix memory leaks in
virStoragePoolDefParseSource
On 05/09/2012 04:49 AM,
s/nuamd/numad/,
--
Pushed under trivial rule.
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 93cc3e8..f7e15f9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1525,7 +1525,7 @@ if test $with_numad != no ; then
if
75 matches
Mail list logo
