[libvirt] Re-2: Re-4: [Patch] Libvirt - Fix locking for readonly devices

2012-05-14 Thread David Weber
> >> Thanks, your patch looks good but needs two further small additions > >> to the libvirt_sanlock.aug and test_libvirt_sanlock.aug files to > >> take account of the new config parameter. > > > > Oops, Updated patch attached (tested with augparse) > > > > David > > > > > > ---

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-14 Thread Oved Ourfalli
Did some more digging on that. The id is constructed in the function qemuUsbId: static void qemuUsbId(virBufferPtr buf, int idx) { if (idx == 0) virBufferAsprintf(buf, "usb"); else virBufferAsprintf(buf, "usb%d", idx); } So, as you can see it is either usb, or usbX... Howev

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-14 Thread Oved Ourfalli
Hey, I built libvirt RPM with this fix (and the previous addresses fix), and I get the following error when running a VM with USB support: internal error Process exited while reading console log output: qemu-kvm: -device ich9-usb-ehci1,id=usb,bus=pci.0,addr=0x4.0x7: Duplicate ID 'usb' for devic

[libvirt] suggestions on snapshotting testing

2012-05-14 Thread Kashyap Chamarthy
Hi, I'm willing to test/understand snapshotting in libivrt/qemu in a much better way. I can spend 10-ish hours or so a week. I see a lot of work going on the snapshot front, upstream qemu/libvirt. I'm currently following/reading: -- http://wiki.qemu.org/Features/SnapshotsMultipleDev

Re: [libvirt] no check of freeMem before restoring a VM in libxl-driver, is it a bug?

2012-05-14 Thread Jim Fehlig
Oscar Ben wrote: > in func 'libxlDomainRestoreFlags',it doesn't use 'libxlFreeMem' to > check whether there are enough memory before restoring the vm!It just > restore the vm anyway,until xenlight found no enough space in the > middle of the process Is this a bug?or It's designed this way by purpos

Re: [libvirt] Libvirt Support Virtio-serail

2012-05-14 Thread Pankaj Rawat
# libvirtd --version libvirtd (libvirt) 0.9.4 Regards Pankaj Rawat -Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Monday, May 14, 2012 5:30 PM To: Pankaj Rawat Cc: Christophe Fergeau; libvir-list@redhat.com Subject: Re: [libvirt] Libvirt Support Virtio-se

Re: [libvirt] [PATCH] libvirt-guests: Remove LISTFILE if it's empty when stopping service

2012-05-14 Thread Osier Yang
On 2012年05月15日 00:13, Eric Blake wrote: On 05/14/2012 01:21 AM, Osier Yang wrote: $LISTFILE is created even no domain is running, and the empty $LISTFILE could cause improper service status. stoped ,with saved guests Do we really say "stoped", or is that a typo in the commit message? Y

Re: [libvirt] [PATCH v3] nodeinfo: Get the correct CPU number on AMD Magny Cours platform

2012-05-14 Thread Osier Yang
On 2012年05月15日 01:41, Eric Blake wrote: On 05/14/2012 07:12 AM, Osier Yang wrote: "Instead of developing one CPU with 12 cores, the Magny Cours is actually two 6 core “Bulldozer” CPUs combined in to one package" I.e, each package has two NUMA nodes, and the two numa nodes share the same core ID

Re: [libvirt] [PATCH 1/2] qemu: Set memory policy using cgroup if placement is auto

2012-05-14 Thread Osier Yang
On 2012年05月15日 06:59, Eric Blake wrote: On 05/12/2012 06:53 AM, Osier Yang wrote: Like for 'static' placement, when the memory policy mode is 'strict', set the memory policy by writing the advisory nodeset returned from numad to cgroup file cpuset.mems, --- src/qemu/qemu_cgroup.c | 15 +

Re: [libvirt] [PATCH] qemu: Use the CPU index in capabilities to map NUMA node to cpu list.

2012-05-14 Thread Osier Yang
On 2012年05月15日 01:03, Eric Blake wrote: On 05/12/2012 06:52 AM, Osier Yang wrote: On some of the NUMA platforms, the CPU index in each NUMA node grows sequentially. While on other platforms, it can be inconsecutive, s/inconsecutive/non-consecutive/ This patch is to fix the problem by using

[libvirt] [PATCH V4] nwfilter: Add support for ipset

2012-05-14 Thread Stefan Berger
This patch adds support for the recent ipset iptables extension to libvirt's nwfilter subsystem. Ipset allows to maintain 'sets' of IP addresses, ports and other packet parameters and allows for faster lookup (in the order of O(1) vs. O(n)) and rule evaluation to achieve higher throughput than wha

Re: [libvirt] [PATCH V3] nwfilter: Add support for ipset

2012-05-14 Thread Stefan Berger
On 05/14/2012 06:20 PM, Eric Blake wrote: On 04/23/2012 06:00 AM, Stefan Berger wrote: This patch adds support for the recent ipset iptables extension to libvirt's nwfilter subsystem. Ipset allows to maintain 'sets' of IP addresses, ports and other packet parameters and allows for faster lookup

Re: [libvirt] [PATCH] Allow stack traces to be included with log messages

2012-05-14 Thread Eric Blake
On 05/09/2012 08:22 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Sometimes it is useful to see the callpath for log messages. > This change enhances the log filter syntax so that stck traces s/stck/stack/ > can be show by setting '1:+NAME' instead of '1:NAME'. Cool. > * docs

[libvirt] [PATCH] nodeinfo: test more details

2012-05-14 Thread Eric Blake
Make it obvious why we need Osier's patch to fix NUMA parsing of an AMD machine with two cores sharing a socket id. * tests/nodeinfotest.c (linuxTestCompareFiles): Enhance the test. * tests/nodeinfodata/linux-nodeinfo-sysfs-test-*-output.txt: Update. --- As promised here: https://www.redhat.com/a

Re: [libvirt] [PATCH 1/2] qemu: Set memory policy using cgroup if placement is auto

2012-05-14 Thread Eric Blake
On 05/12/2012 06:53 AM, Osier Yang wrote: > Like for 'static' placement, when the memory policy mode is > 'strict', set the memory policy by writing the advisory nodeset > returned from numad to cgroup file cpuset.mems, > --- > src/qemu/qemu_cgroup.c | 15 +-- > src/qemu/qemu_cgroup.h

Re: [libvirt] [PATCHv3 1/1] Assign spapr-vio bus address to ibmvscsi controller

2012-05-14 Thread Eric Blake
On 05/14/2012 12:16 AM, Li Zhang wrote: > For pseries guest, the default controller model is > ibmvscsi controller, this controller only can work > on spapr-vio address. > > This patch is to assign spapr-vio address type to > ibmvscsi controller and correct vscsi test case. > > Signed-off-by: Li

Re: [libvirt] Re-4: [Patch] Libvirt - Fix locking for readonly devices

2012-05-14 Thread Eric Blake
On 05/14/2012 03:53 AM, David Weber wrote: >> >> Thanks, your patch looks good but needs two further small additions >> to the libvirt_sanlock.aug and test_libvirt_sanlock.aug files to >> take account of the new config parameter. > > Oops, Updated patch attached (tested with augparse) > > David >

Re: [libvirt] [PATCH 2/4] Avoid LXC pivot root in the root source is still /

2012-05-14 Thread Eric Blake
On 05/11/2012 10:48 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > If the LXC config has a filesystem > > > > > > > then there is no need to go down the pivot root codepath. > We can simply use the existing root as needed. > > Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 1/4] Mount fresh instance of sysfs/selinux in LXC

2012-05-14 Thread Eric Blake
On 05/11/2012 10:48 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Currently to make sysfs readonly, we remount the existing > instance and then bind it readonly. Unfortunately this means > sysfs is still showing device objects wrt the host OS namespace. > We need it to reflect th

Re: [libvirt] [PATCH V3] nwfilter: Add support for ipset

2012-05-14 Thread Eric Blake
On 04/23/2012 06:00 AM, Stefan Berger wrote: > This patch adds support for the recent ipset iptables extension > to libvirt's nwfilter subsystem. Ipset allows to maintain 'sets' > of IP addresses, ports and other packet parameters and allows for > faster lookup (in the order of O(1) vs. O(n)) and r

Re: [libvirt] [PATCH] Fix logic for assigning PCI addresses to USB2 companion controllers

2012-05-14 Thread Eric Blake
On 05/14/2012 04:19 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Currently each USB2 companion controller gets put on a separate > PCI slot. Not only is this wasteful of PCI slots, but it is not > in compliance with the spec for USB2 controllers. The master > echi1 and all compa

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-14 Thread Eric Blake
On 05/14/2012 06:24 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The uhci1, uhci2, uhci3 companion controllers for ehci1 must > have a master start port set. Since this value is predictable > we should set it automatically if the app does not supply it > --- > src/conf/domain_c

Re: [libvirt] [PATCH 2/2] rpc: Size up RPC limits

2012-05-14 Thread Eric Blake
On 04/27/2012 07:22 AM, Michal Privoznik wrote: > Since we are allocating RPC buffer dynamically, we can increase limits > for max. size of RPC message and RPC string. This is needed to cover > some corner cases where libvirt is run on such huge machines that their > capabilities XML is 4 times big

Re: [libvirt] [PATCH 1/2] rpc: Switch to dynamically allocated message buffer

2012-05-14 Thread Eric Blake
On 04/27/2012 07:22 AM, Michal Privoznik wrote: > Currently, we are allocating buffer for RPC messages statically. > This is not such pain when RPC limits are small. However, if we want > ever to increase those limits, we need to allocate buffer dynamically, > based on RPC message len (= the first

Re: [libvirt] Release of libvirt-0.9.12

2012-05-14 Thread Jason Helfman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Mon, May 14, 2012 at 11:42:48AM +0800, Daniel Veillard thus spake: > So I made the release, it is now available on the FTP server (the rpms >are slowly being uploaded too): > ftp://libvirt.org/libvirt/ This has been updated in FreeBSD. Thanks

Re: [libvirt] [PATCH v3] nodeinfo: Get the correct CPU number on AMD Magny Cours platform

2012-05-14 Thread Eric Blake
On 05/14/2012 07:12 AM, Osier Yang wrote: > "Instead of developing one CPU with 12 cores, the Magny Cours is > actually two 6 core “Bulldozer” CPUs combined in to one package" > > I.e, each package has two NUMA nodes, and the two numa nodes share > the same core ID set (0-6), which means parsing t

Re: [libvirt] [PATCHv2 3/4] nodeinfo: add some more tests

2012-05-14 Thread Eric Blake
On 05/11/2012 07:25 PM, Stefan Berger wrote: > On 05/11/2012 06:41 PM, Eric Blake wrote: >> Test 2 data grabbed from a 2-core 1-node laptop. >> Test 3 data grabbed from a 48-core AMD Magny Cours box. > > ACK Thanks; I've pushed 1-3 with the nit you mentioned in 2 fixed. -- Eric Blake ebl...@r

Re: [libvirt] [PATCH 0/2] Rework RPC message buffer

2012-05-14 Thread Michal Privoznik
On 03.05.2012 20:58, Eric Blake wrote: > On 04/27/2012 07:22 AM, Michal Privoznik wrote: >> This patch set tries to fix corner cases where libvirt runs on huge >> system, e.g. 4K CPU monster. In these cases, capabilities XML is >> enormously big, as we are transferring info about each singe CPU cor

Re: [libvirt] [PATCH V3] nwfilter: Add support for ipset

2012-05-14 Thread Stefan Berger
Does anyone have time to look at this one? Stefan On 04/23/2012 08:00 AM, Stefan Berger wrote: This patch adds support for the recent ipset iptables extension to libvirt's nwfilter subsystem. Ipset allows to maintain 'sets' of IP addresses, ports and other packet parameters and allows for

Re: [libvirt] [PATCH] qemu: Use the CPU index in capabilities to map NUMA node to cpu list.

2012-05-14 Thread Eric Blake
On 05/12/2012 06:52 AM, Osier Yang wrote: > On some of the NUMA platforms, the CPU index in each NUMA node > grows sequentially. While on other platforms, it can be inconsecutive, s/inconsecutive/non-consecutive/ > > This patch is to fix the problem by using the CPU index in > caps->host.numaCel

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.12

2012-05-14 Thread Justin Clift
On 14/05/2012, at 1:42 PM, Daniel Veillard wrote: > So I made the release, it is now available on the FTP server (the rpms > are slowly being uploaded too): > ftp://libvirt.org/libvirt/ This, and the 0.9.11.3 stable release, are now available in Homebrew on MacOS X. + Justin -- Aeolus Commun

Re: [libvirt] [PATCH] build: really silence the 32-bit warning

2012-05-14 Thread Stefan Berger
On 05/14/2012 11:05 AM, Eric Blake wrote: Commit cdce2f42d tried to silence a compiler warning on 32-bit builds, but the gcc shipped with RHEL 5 is old enough that the type conversion via multiplication by 1 was insufficient for the task. * src/qemu/qemu_monitor.c (qemuMonitorBlockJob): Previous

Re: [libvirt] [PATCHv4] Use XDG Base Directories instead of storing in home directory

2012-05-14 Thread Eric Blake
On 05/03/2012 10:36 AM, William Jon McCann wrote: > As defined in: > http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html > > This offers a number of advantages: > * Allows sharing a home directory between different machines, or > sessions (eg. using NFS) > * Cleanly separates

Re: [libvirt] [PATCH] Move user libvirtd socket out of abstract namespace

2012-05-14 Thread Eric Blake
On 05/14/2012 08:18 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The current unprivileged user libvirtd sockets are in the abstract > namespace. This has a number of problems > > - You can't connect to them remotely using the nc/ssh tunnel > - This is not portable for OS-X o

Re: [libvirt] [PATCH] libvirt-guests: Remove LISTFILE if it's empty when stopping service

2012-05-14 Thread Eric Blake
On 05/14/2012 01:21 AM, Osier Yang wrote: > $LISTFILE is created even no domain is running, and the empty > $LISTFILE could cause improper service status. > > stoped ,with saved guests Do we really say "stoped", or is that a typo in the commit message? > > Which is not right, as there is no

Re: [libvirt] [libvirt-php PATCH] Fix installation of libvirt-php.ini

2012-05-14 Thread Michal Novotny
On 05/11/2012 05:31 PM, Ivo van den Abeelen wrote: > Building/installing libvirt-php seems to create an incomplete libvirt-php.ini > file. > This patch solves this issue, and replaces the '#' comments (deprecated in > PHP 5.4). > --- > src/Makefile.am | 16 > 1 file changed, 8

[libvirt] [PATCH] build: really silence the 32-bit warning

2012-05-14 Thread Eric Blake
Commit cdce2f42d tried to silence a compiler warning on 32-bit builds, but the gcc shipped with RHEL 5 is old enough that the type conversion via multiplication by 1 was insufficient for the task. * src/qemu/qemu_monitor.c (qemuMonitorBlockJob): Previous attempt didn't get past all gcc versions. -

Re: [libvirt] [Qemu-devel] [PATCH qemu v3 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-14 Thread Anthony Liguori
On 05/02/2012 11:07 AM, Eduardo Habkost wrote: Changes v2 -> v3: - Actually change 'defconfig' type declaration to bool - Rebase against latest qemu.git (commit 563987d0a799f90b58a575b190a57546c335191b) Changes v1 -> v2: - Move qemu_read_default_config_files() prototype to qemu-config.h

Re: [libvirt] [libvirt-glib] Add missing domain OS type enums

2012-05-14 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 05:54:28PM +0300, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > libvirt-gconfig/libvirt-gconfig-domain-os.h |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) NB, for future reference, please put a bit more in the commit message. ie

Re: [libvirt] [PATCH 03/12] Remove hack using existance of an 'identity' string to disable auth

2012-05-14 Thread Daniel P. Berrange
On Wed, May 02, 2012 at 05:23:01PM +0200, Michal Privoznik wrote: > On 02.05.2012 13:44, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Currently the server determines whether authentication of clients > > is complete, by checking whether an identity is set. This patch > > remov

[libvirt] [libvirt-glib] Add missing domain OS type enums

2012-05-14 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- libvirt-gconfig/libvirt-gconfig-domain-os.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-os.h b/libvirt-gconfig/libvirt-gconfig-domain-os.h index 44b8bdd..832e275 100644 --- a/libvirt-gconfig

Re: [libvirt] [libvirt-glib] Add missing domain OS type enums

2012-05-14 Thread Zeeshan Ali (Khattak)
Pushed already based on trivial rule! -- Regards, Zeeshan Ali (Khattak) FSF member#5124 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Move user libvirtd socket out of abstract namespace

2012-05-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The current unprivileged user libvirtd sockets are in the abstract namespace. This has a number of problems - You can't connect to them remotely using the nc/ssh tunnel - This is not portable for OS-X - Parent directory permissions don't apply --- daemon/libvirtd.c

Re: [libvirt] [PATCHv4] Use XDG Base Directories instead of storing in home directory

2012-05-14 Thread Daniel P. Berrange
On Thu, May 03, 2012 at 12:36:27PM -0400, William Jon McCann wrote: > As defined in: > http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html > > This offers a number of advantages: > * Allows sharing a home directory between different machines, or > sessions (eg. using NFS) > *

Re: [libvirt] [PATCH 3/4] Trim /proc & /sys subtrees before mounting new instances

2012-05-14 Thread Daniel P. Berrange
On Fri, May 11, 2012 at 10:04:24PM -0400, Stefan Berger wrote: > On 05/11/2012 12:48 PM, Daniel P. Berrange wrote: > >From: "Daniel P. Berrange" > > > >Both /proc and /sys may have sub-mounts in them from the host > >OS. We must explicitly unmount them all before mounting the > >new instance over t

Re: [libvirt] [PATCH 5/6] Add security driver APIs for getting mount options

2012-05-14 Thread Daniel P. Berrange
On Fri, May 11, 2012 at 10:43:50PM -0400, Stefan Berger wrote: > On 05/11/2012 06:10 AM, Daniel P. Berrange wrote: > >From: Daniel Walsh > > > >Some security drivers require special options to be passed to > >the mount system call. Add a security driver API for handling > >this data. > > > >Signed-

Re: [libvirt] [PATCH 3/6] Use private data struct in SELinux driver

2012-05-14 Thread Daniel P. Berrange
On Fri, May 11, 2012 at 10:43:38PM -0400, Stefan Berger wrote: > On 05/11/2012 06:10 AM, Daniel P. Berrange wrote: > >From: Daniel Walsh > > > >Currently the SELinux driver stores its state in a set of global > >variables. This switches it to use a private data struct instead. > >This will enable d

Re: [libvirt] [PATCH 2/6] Don't enable the AppArmour security driver with LXC

2012-05-14 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 08:06:03AM -0500, Jamie Strandboge wrote: > On Fri, 2012-05-11 at 22:39 -0400, Stefan Berger wrote: > > > +if (virtDriver&& STREQ(virtDriver, "LXC")) > > > +return rc; > > > + > > ACK once changed to: > if (virtDriver && STREQ(virtDriver, "LXC")) The patch is

[libvirt] [PATCH v3] nodeinfo: Get the correct CPU number on AMD Magny Cours platform

2012-05-14 Thread Osier Yang
"Instead of developing one CPU with 12 cores, the Magny Cours is actually two 6 core “Bulldozer” CPUs combined in to one package" I.e, each package has two NUMA nodes, and the two numa nodes share the same core ID set (0-6), which means parsing the cores number from sysfs doesn't work in this case

Re: [libvirt] [PATCH 2/6] Don't enable the AppArmour security driver with LXC

2012-05-14 Thread Jamie Strandboge
On Fri, 2012-05-11 at 22:39 -0400, Stefan Berger wrote: > > +if (virtDriver&& STREQ(virtDriver, "LXC")) > > +return rc; > > + ACK once changed to: if (virtDriver && STREQ(virtDriver, "LXC")) ... -- Jamie Strandboge | http://www.canonical.com signature.asc Description:

[libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The uhci1, uhci2, uhci3 companion controllers for ehci1 must have a master start port set. Since this value is predictable we should set it automatically if the app does not supply it --- src/conf/domain_conf.c | 22 ++ ...

Re: [libvirt] [libvirt-php PATCH] Fix installation of libvirt-php.ini

2012-05-14 Thread Daniel P. Berrange
On Fri, May 11, 2012 at 05:31:28PM +0200, Ivo van den Abeelen wrote: > Building/installing libvirt-php seems to create an incomplete libvirt-php.ini > file. > This patch solves this issue, and replaces the '#' comments (deprecated in > PHP 5.4). > --- > src/Makefile.am | 16 >

Re: [libvirt] [PATCH libvirt 1/2] domain: add element for user mode networking

2012-05-14 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 01:29:11PM +0200, Marc-André Lureau wrote: > Hi > > Ah, I just realized that there is 'guestfwd' support already, so we > may want to use the same syntax > > > > > > > It seems a bit contrieved to me, it is harder to interpret. 'host' > address and guest 'address'

Re: [libvirt] [PATCH] nodeinfo: Get the correct CPU number on AMD Magny Cours platform

2012-05-14 Thread Stefan Berger
On 05/14/2012 04:25 AM, Osier Yang wrote: "Instead of developing one CPU with 12 cores, the Magny Cours is actually two 6 core “Bulldozer” CPUs combined in to one package" I.e, each package has two NUMA nodes, and the two numa nodes share the same core ID set (0-6), which means parsing the cores

Re: [libvirt] [PATCH] Fix logic for assigning PCI addresses to USB2 companion controllers

2012-05-14 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 01:06:50PM +0200, Hans de Goede wrote: > Hi, > > Thanks for working on this. I've little useful feedback atm > I'm afraid, but I do have a question based on reading the xml > for the tests, is it necessary to set the startports explicitly? > or do they get the correct defau

Re: [libvirt] Libvirt Support Virtio-serail

2012-05-14 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 11:09:46AM +, Pankaj Rawat wrote: > Well I tried it but it doesn’t work > > > > > > > > > > > > > > > All above are merged into one > > > > > When I define the guest xml Hmm, what ve

[libvirt] no check of freeMem before restoring a VM in libxl-driver, is it a bug?

2012-05-14 Thread Oscar Ben
in func 'libxlDomainRestoreFlags',it doesn't use 'libxlFreeMem' to check whether there are enough memory before restoring the vm!It just restore the vm anyway,until xenlight found no enough space in the middle of the process Is this a bug?or It's designed this way by purpose?Thanks in advance. -- l

Re: [libvirt] [PATCH libvirt 1/2] domain: add element for user mode networking

2012-05-14 Thread Marc-André Lureau
Hi Ah, I just realized that there is 'guestfwd' support already, so we may want to use the same syntax It seems a bit contrieved to me, it is harder to interpret. 'host' address and guest 'address' are no longer optional. There is no way to specify the protocol. However, I imagined we m

Re: [libvirt] Libvirt Support Virtio-serail

2012-05-14 Thread Pankaj Rawat
Well I tried it but it doesn’t work All above are merged into one When I define the guest xml Following error received when I tried to execute the command # virsh console --device console1 serial error: com

Re: [libvirt] [PATCH] Fix logic for assigning PCI addresses to USB2 companion controllers

2012-05-14 Thread Hans de Goede
Hi, Thanks for working on this. I've little useful feedback atm I'm afraid, but I do have a question based on reading the xml for the tests, is it necessary to set the startports explicitly? or do they get the correct default based on the model, ie uhci1 startport 0, uhci startport 2, etc? Regar

Re: [libvirt] [PATCH 2/6] introduce the function virCgroupMoveTask()

2012-05-14 Thread Hu Tao
On Wed, Apr 25, 2012 at 05:44:52PM +0800, Wen Congyang wrote: > introduce a new API to move all tasks from a cgroup to another cgroup > > --- > src/util/cgroup.c | 55 > + > src/util/cgroup.h |2 + > 2 files changed, 57 insertions(+), 0 d

Re: [libvirt] Libvirt Support Virtio-serail

2012-05-14 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 10:03:11AM +, Pankaj Rawat wrote: > Actually I wanted to have private communication channel b/w host and guest > By default I cannot have multiple console on guest through virsh console > guestname > ( they all are dependent on each other , if I execute a command on one

[libvirt] [PATCH] Fix logic for assigning PCI addresses to USB2 companion controllers

2012-05-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently each USB2 companion controller gets put on a separate PCI slot. Not only is this wasteful of PCI slots, but it is not in compliance with the spec for USB2 controllers. The master echi1 and all companion controllers should be in the same slot, with echi1 in fun

Re: [libvirt] Libvirt Support Virtio-serail

2012-05-14 Thread Pankaj Rawat
Thanks for the input Actually I wanted to have private communication channel b/w host and guest By default I cannot have multiple console on guest through virsh console guestname ( they all are dependent on each other , if I execute a command on one shell its output is reflected on all of them ).

Re: [libvirt] [libvirt-glib 2/2] Add guest capabilities API

2012-05-14 Thread Christophe Fergeau
On Fri, May 11, 2012 at 04:18:16PM +0300, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Not quite complete but its a good start. > --- > libvirt-gconfig/Makefile.am|8 + > .../libvirt-gconfig-capabilities-guest-arch.c | 125 ++

Re: [libvirt] [libvirt-glib 1/2] Add host capabilities API

2012-05-14 Thread Christophe Fergeau
ACK On Fri, May 11, 2012 at 04:18:15PM +0300, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Not quite complete but its a good start. > --- > libvirt-gconfig/Makefile.am|6 + > .../libvirt-gconfig-capabilities-cpu-feature.c | 58 ++ >

[libvirt] Re-4: [Patch] Libvirt - Fix locking for readonly devices

2012-05-14 Thread David Weber
> On Mon, May 14, 2012 at 08:32:01AM +, David Weber wrote: > > > This isn't good - the lock manager implementation must be the > > > one to decide what todo with readonly & shared disks. The sanlock > > > plugin, however, does not currently support readonly/shared leases > > > hence why it reje

[libvirt] [PATCH] storage backend: Add RBD (RADOS Block Device) support

2012-05-14 Thread Wido den Hollander
This patch adds support for a new storage backend with RBD support. RBD is the RADOS Block Device and is part of the Ceph distributed storage system. It comes in two flavours: Qemu-RBD and Kernel RBD, this storage backend only supports Qemu-RBD, thus limiting the use of this storage driver to Q

Re: [libvirt] Re-2: [Patch] Libvirt - Fix locking for readonly devices

2012-05-14 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 08:32:01AM +, David Weber wrote: > > This isn't good - the lock manager implementation must be the > > one to decide what todo with readonly & shared disks. The sanlock > > plugin, however, does not currently support readonly/shared leases > > hence why it rejects them.

[libvirt] Re-2: [Patch] Libvirt - Fix locking for readonly devices

2012-05-14 Thread David Weber
> On Tue, May 08, 2012 at 09:41:02AM +, David Weber wrote: > > Hi, > > > > I'm currently working on getting sanlock into Debian/Ubuntu. > > While testing, I noticed that I wasn't able to add a readonly > > or shared device: "internal error unsupported > > configuration: Readonly leases are n

[libvirt] [PATCH] nodeinfo: Get the correct CPU number on AMD Magny Cours platform

2012-05-14 Thread Osier Yang
"Instead of developing one CPU with 12 cores, the Magny Cours is actually two 6 core “Bulldozer” CPUs combined in to one package" I.e, each package has two NUMA nodes, and the two numa nodes share the same core ID set (0-6), which means parsing the cores number from sysfs doesn't work in this case

Re: [libvirt] [PATCHv2 4/4] nodeinfo: Get the correct CPU number on AMD Magny Cours platform

2012-05-14 Thread Osier Yang
On 2012年05月12日 09:26, Stefan Berger wrote: On 05/11/2012 06:41 PM, Eric Blake wrote: From: Osier Yang "Instead of developing one CPU with 12 cores, the Magny Cours is actually two 6 core “Bulldozer” CPUs combined in to one package" I.e, each package has two NUMA nodes, and the two numa nodes s

Re: [libvirt] Libvirt Support Virtio-serail

2012-05-14 Thread Christophe Fergeau
Hi Pankaj, On Mon, May 14, 2012 at 03:52:54AM +, Pankaj Rawat wrote: > I wanted to know whether libvirt has any kind of support for virt-io serial > or not > If yes then how can I use it? I think http://libvirt.org/formatdomain.html#elementCharChannel is what you are looking for, if it's not

[libvirt] [PATCH] libvirt-guests: Remove LISTFILE if it's empty when stopping service

2012-05-14 Thread Osier Yang
$LISTFILE is created even no domain is running, and the empty $LISTFILE could cause improper service status. stoped ,with saved guests Which is not right, as there is no domain was saved. --- tools/libvirt-guests.init.sh | 42 +++--- 1 files changed, 23