Re: [libvirt] [PATCH 1/1] Assign correct address type to spapr-vlan and spapr-vty.

2012-05-31 Thread Li Zhang
Hi Daniel and Eric, Would you please help review it? Thanks a lot. :) On 05/29/2012 04:35 PM, Li Zhang wrote: For pseires guest, spapr-vlan and spapr-vty is based on spapr-vio address. According to model of network device, the address type should be assigned automatically. For serial device,

[libvirt] [Fwd: error: this function is not supported by the connection driver : virConnectNumOfStoragePool]

2012-05-31 Thread Onkar
Hello All, Any idea on this issue ? Regards, Onkar Forwarded Message From: Onkar kern...@gmail.com To: libvir-list libvir-list@redhat.com Subject: error: this function is not supported by the connection driver : virConnectNumOfStoragePool Date: Wed, 30 May 2012 21:29:42

Re: [libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)

2012-05-31 Thread Alex Jia
Hi Eric, Compiling error still exists: snip Considering target file `test_libvirt_sanlock.aug'. File `test_libvirt_sanlock.aug' does not exist. Considering target file `locking/test_libvirt_sanlock.aug.in'. File `locking/test_libvirt_sanlock.aug.in' does not exist. Finished

[libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Martin Kletzander
This patch makes virt-pki-validate work with certificates that have acl or xattr set. Otherwise it failing due to wrong permissions. --- tools/virt-pki-validate.in |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virt-pki-validate.in b/tools/virt-pki-validate.in

Re: [libvirt] [PATCHv4] add-vcpu-usage

2012-05-31 Thread Hu Tao
Hi Rich, The libvirt counterpart have been already in, do you have time to look at the ocaml-libvirt and virt-top patches? On Wed, May 09, 2012 at 04:48:29PM +0800, Hu Tao wrote: show `vcpu usages' by `virt-top -1' Before this patch, `virt-top -1' shows total cpu usages which euqal to `vcpu

Re: [libvirt] [PATCH] SNMP: include inactive domains in guest table

2012-05-31 Thread Michal Privoznik
On 31.05.2012 00:04, Jonathan Daugherty wrote: Hi, I've written a patch to include inactive domains in the guest table available via the libvirt-snmp subagent. This makes it possible to start domains via SNMP (a state transition which AFAICT was previously impossible, because inactive

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Philipp Hahn
Hello, I find parsing the output of ls -l very suspect and fragile, since its output heaviely depends on the environment: SELinux, ACLs, locale. Perhaps using /usr/bin/stat would be better, but I don't know how available /usr/bin/stat is on non-Linux-platforms (on my Debian system it's in

Re: [libvirt] [PATCHv4] add-vcpu-usage

2012-05-31 Thread Richard W.M. Jones
On Thu, May 31, 2012 at 06:54:47PM +0800, Hu Tao wrote: Hi Rich, The libvirt counterpart have been already in, do you have time to look at the ocaml-libvirt and virt-top patches? I am intending to look at them, don't worry about that, but I'm busy for the next week. Rich. -- Richard

[libvirt] Bug report 826704 - sanlock releases all resources on virsh detach-disk

2012-05-31 Thread Frido Roose
Hello, I logged a bug about using virsh detach-disk cleaning up all sanlock resources for the domain instead of only the device in question. After a quick look into the code, I think a new method similar to virLockManagerSanlockAddResource is needed in case of detaching a disk from the

Re: [libvirt] [Fwd: error: this function is not supported by the connection driver : virConnectNumOfStoragePool]

2012-05-31 Thread xingxing gao
i download the libvirt-0.9.12.tar.gz and make rpms rpmbuild -tb libvirt-0.9.12.tar.gz everything is ok.maybe you can have a try. 2012/5/31 Onkar kern...@gmail.com: Hello All,    Any idea on this issue ? Regards, Onkar Forwarded Message From: Onkar kern...@gmail.com To:

Re: [libvirt] [PATCH v2 0/2] Make virsh *edit more bearable

2012-05-31 Thread Michal Privoznik
On 24.05.2012 18:20, Michal Privoznik wrote: If there's an error in XML, all changes made by user are lost. Users (read /me) tends to get angry with this. Allow them to get back and re-edit. diff to v1: -Eric's review suggestions included Michal Privoznik (2): virsh: Switch from

[libvirt] [PATCH v3 1/2] rpc: Switch to dynamically allocated message buffer

2012-05-31 Thread Michal Privoznik
Currently, we are allocating buffer for RPC messages statically. This is not such pain when RPC limits are small. However, if we want ever to increase those limits, we need to allocate buffer dynamically, based on RPC message len (= the first 4 bytes). Therefore we will decrease our mem usage in

[libvirt] [PATCH v3 2/2] rpc: Size up RPC limits

2012-05-31 Thread Michal Privoznik
Since we are allocating RPC buffer dynamically, we can increase limits for max. size of RPC message and RPC string. This is needed to cover some corner cases where libvirt is run on such huge machines that their capabilities XML is 4 times bigger than our current limit. This leaves users with

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Eric Blake
On 05/31/2012 05:57 AM, Philipp Hahn wrote: Hello, I find parsing the output of ls -l very suspect and fragile, As do I. since its output heaviely depends on the environment: SELinux, ACLs, That only affects the 11th character, which we are stripping. locale. That affects the date

[libvirt] [PATCH v3 0/2] Rework RPC message buffer

2012-05-31 Thread Michal Privoznik
This patch set tries to fix corner cases where libvirt runs on huge system, e.g. 4K CPU monster. In these cases, capabilities XML is enormously big, as we are transferring info about each singe CPU core (to which NUMA node it belongs, etc.). This XML is bigger than our RPC limit, therefore users

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Eric Blake
On 05/31/2012 03:02 AM, Martin Kletzander wrote: This patch makes virt-pki-validate work with certificates that have acl or xattr set. Otherwise it failing due to wrong permissions. --- tools/virt-pki-validate.in |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [Fwd: error: this function is not supported by the connection driver : virConnectNumOfStoragePool]

2012-05-31 Thread Eric Blake
On 05/31/2012 12:33 AM, Onkar wrote: Hello All, Any idea on this issue ? Regards, Onkar Forwarded Message From: Onkar kern...@gmail.com To: libvir-list libvir-list@redhat.com Subject: error: this function is not supported by the connection driver :

Re: [libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)

2012-05-31 Thread Eric Blake
On 05/31/2012 02:19 AM, Alex Jia wrote: Hi Eric, Compiling error still exists: snip Considering target file `test_libvirt_sanlock.aug'. File `test_libvirt_sanlock.aug' does not exist. Considering target file `locking/test_libvirt_sanlock.aug.in'. File

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Martin Kletzander
On 05/31/2012 04:49 PM, Eric Blake wrote: On 05/31/2012 03:02 AM, Martin Kletzander wrote: This patch makes virt-pki-validate work with certificates that have acl or xattr set. Otherwise it failing due to wrong permissions. --- tools/virt-pki-validate.in |6 -- 1 files changed, 4

Re: [libvirt] [PATCH v3 0/2] Rework RPC message buffer

2012-05-31 Thread Eric Blake
On 05/31/2012 08:48 AM, Michal Privoznik wrote: This patch set tries to fix corner cases where libvirt runs on huge system, e.g. 4K CPU monster. In these cases, capabilities XML is enormously big, as we are transferring info about each singe CPU core (to which NUMA node it belongs, etc.). This

Re: [libvirt] [PATCH v2 1/2] virsh: Switch from generated cmd*Edit commands to nongenerated

2012-05-31 Thread Eric Blake
On 05/24/2012 10:20 AM, Michal Privoznik wrote: Currently, we either generate some cmd*Edit commands (cmdPoolEdit and cmdNetworkEdit) via sed script or copy the body of cmdEdit (e.g. cmdInterfaceEdit, cmdNWFilterEdit, etc.). This fact makes it harder to implement any new feature to our editing

Re: [libvirt] [PATCH v2 2/2] virsh: Allow users to reedit rejected XML

2012-05-31 Thread Eric Blake
On 05/24/2012 10:20 AM, Michal Privoznik wrote: If users *-edit but make a mistake in XML all changes are permanently lost. However, if virsh is not running within a script we can ask user if he wants to re-edit the file and correct the mistakes. --- tools/console.c| 40

Re: [libvirt] [PATCH] SNMP: include inactive domains in guest table

2012-05-31 Thread Jonathan Daugherty
Firstly, have you known that you are the first person outside RH to post patch for libvirt-snmp? It's awesome. Neat! Secondly, as Eric replied, I'd wait for the new API as well, so we can do an atomic list. Therefore ACK to the idea. That's for sure. So are you comfortable with this

[libvirt] Authentication

2012-05-31 Thread Jagannath Timma
Are there any plans to add support for the default authentication method of the server? http://libvirt.org/drvhyperv.html Authentication In order to perform any useful operation the driver needs to log into the Hyper-V server. Therefore, only virConnectOpenAuth can be used to connect to

Re: [libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)

2012-05-31 Thread Alex Jia
On 05/31/2012 11:01 PM, Eric Blake wrote: On 05/31/2012 02:19 AM, Alex Jia wrote: Hi Eric, Compiling error still exists: snip Considering target file `test_libvirt_sanlock.aug'. File `test_libvirt_sanlock.aug' does not exist. Considering target file