[libvirt] can't get right capabilities

2012-06-04 Thread Li Zhang
Hi, I am trying to use x86 machine to create VMs. But one error occurs. [root@mcd kvm-test]# virsh create test.xml error: Failed to create domain from test.xml error: unknown OS type hvm My xml file is as the following: domain type='kvm' nametest/name memory524288/memory

Re: [libvirt] can't get right capabilities

2012-06-04 Thread Osier Yang
On 2012年06月04日 14:17, Li Zhang wrote: Hi, I am trying to use x86 machine to create VMs. But one error occurs. [root@mcd kvm-test]# virsh create test.xml error: Failed to create domain from test.xml error: unknown OS type hvm My xml file is as the following: domain type='kvm' nametest/name

Re: [libvirt] can't get right capabilities

2012-06-04 Thread Alex Jia
On 06/04/2012 02:17 PM, Li Zhang wrote: Hi, I am trying to use x86 machine to create VMs. But one error occurs. [root@mcd kvm-test]# virsh create test.xml error: Failed to create domain from test.xml error: unknown OS type hvm My xml file is as the following: domain type='kvm' nametest/name

Re: [libvirt] [PATCH] fix make syntax-check failed

2012-06-04 Thread Osier Yang
On 2012年06月04日 11:37, Wen Congyang wrote: --- tools/virsh.c | 170 1 files changed, 85 insertions(+), 85 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index a934c13..0e41d00 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@

Re: [libvirt] [PATCH] build: include viratomic.h into dist file

2012-06-04 Thread Osier Yang
On 2012年06月04日 11:36, Wen Congyang wrote: We add viratomic.h, but we forget to include it into dist file. This file is used in nwfilter/nwfilter_dhcpsnoop.c now. --- src/Makefile.am |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am

Re: [libvirt] can't get right capabilities

2012-06-04 Thread Radu Caragea
- Original Message - From: Li Zhang zhlci...@linux.vnet.ibm.com To: libvir-list@redhat.com Cc: Sent: Monday, June 4, 2012 9:17 AM Subject: [libvirt] can't get right capabilities Hi, I am trying to use x86 machine to create VMs. But one error occurs. [root@mcd kvm-test]# virsh

Re: [libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)

2012-06-04 Thread Alex Jia
Martin help me find a root reason, I don't know when the src/locking/test_libvirt_sanlock.aug.in is deleted from my git repo, in fact, I have never manually done it by myself except running 'make', 'make clean' or 'make rpm' ago, it's weird for me. Martin, Thanks. Alex - Original

Re: [libvirt] [PATCH] fix sync issue in virnetclientstream

2012-06-04 Thread Michal Privoznik
On 03.06.2012 22:12, Radu Caragea wrote: The stream lock is unlocked twice instead of being locked and then unlocked. Probably a typo. ACK I've turned this into a git commit and added you to AUTHORS. Michal -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)

2012-06-04 Thread Martin Kletzander
On 06/04/2012 09:54 AM, Alex Jia wrote: Martin help me find a root reason, I don't know when the src/locking/test_libvirt_sanlock.aug.in is deleted from my git repo, in fact, I have never manually done it by myself except running 'make', 'make clean' or 'make rpm' ago, it's weird for me.

[libvirt] [PATCH] virsh: Accept UUID as an argument for storage commands

2012-06-04 Thread Osier Yang
Affected commands are: pool-start, vol-create-from. --- tools/virsh.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 1303da9..4737948 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -11286,7 +11286,7 @@ static const

[libvirt] [PATCH] virsh: Accept UUID as an argument for net-info and net-start

2012-06-04 Thread Osier Yang
--- tools/virsh.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index a934c13..1303da9 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -8505,7 +8505,7 @@ static const vshCmdInfo info_network_info[] = { }; static const

[libvirt] [PATCH] virsh: Back out if the argument for vol-create-as is malformed

2012-06-04 Thread Osier Yang
--- tools/virsh.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4737948..4810627 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -11372,18 +11372,24 @@ cmdVolCreateAs(vshControl *ctl, const vshCmd *cmd) if

Re: [libvirt] can't get right capabilities

2012-06-04 Thread Li Zhang
On 06/04/2012 03:48 PM, Radu Caragea wrote: - Original Message - From: Li Zhangzhlci...@linux.vnet.ibm.com To: libvir-list@redhat.com Cc: Sent: Monday, June 4, 2012 9:17 AM Subject: [libvirt] can't get right capabilities Hi, I am trying to use x86 machine to create VMs. But one

Re: [libvirt] can't get right capabilities

2012-06-04 Thread Li Zhang
On 06/04/2012 03:35 PM, Alex Jia wrote: On 06/04/2012 02:17 PM, Li Zhang wrote: Hi, I am trying to use x86 machine to create VMs. But one error occurs. [root@mcd kvm-test]# virsh create test.xml error: Failed to create domain from test.xml error: unknown OS type hvm My xml file is as the

[libvirt] [PATCH] syntax-check: Don't check virsh.c for preprocessor indentation

2012-06-04 Thread Michal Privoznik
With recent re-edit commits we have #define and #include not indented as it ought to be from preprocessor POV. However, these are part of a function, therefore they are indented well. To solve this, skip preprocessor indentation check on virsh.c --- cfg.mk |3 +++ 1 files changed, 3

Re: [libvirt] [PATCH] fix make syntax-check failed

2012-06-04 Thread Michal Privoznik
On 04.06.2012 05:37, Wen Congyang wrote: --- tools/virsh.c | 170 1 files changed, 85 insertions(+), 85 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index a934c13..0e41d00 100644 --- a/tools/virsh.c +++ b/tools/virsh.c

Re: [libvirt] [libvirt-glib] API to get/set domain title

2012-06-04 Thread Christophe Fergeau
On Sat, Jun 02, 2012 at 07:33:08PM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain.c | 33 ++ libvirt-gconfig/libvirt-gconfig-domain.h |2 ++

Re: [libvirt] can't get right capabilities

2012-06-04 Thread Li Zhang
On 06/04/2012 03:35 PM, Alex Jia wrote: On 06/04/2012 02:17 PM, Li Zhang wrote: Hi, I am trying to use x86 machine to create VMs. But one error occurs. [root@mcd kvm-test]# virsh create test.xml error: Failed to create domain from test.xml error: unknown OS type hvm My xml file is as the

Re: [libvirt] [PATCH] syntax-check: Don't check virsh.c for preprocessor indentation

2012-06-04 Thread Eric Blake
On 06/04/2012 03:36 AM, Michal Privoznik wrote: With recent re-edit commits we have #define and #include not indented as it ought to be from preprocessor POV. However, these are part of a function, therefore they are indented well. To solve this, skip preprocessor indentation check on virsh.c

Re: [libvirt] [PATCH] fix make syntax-check failed

2012-06-04 Thread Eric Blake
On 06/04/2012 04:29 AM, Michal Privoznik wrote: On 04.06.2012 05:37, Wen Congyang wrote: --- tools/virsh.c | 170 1 files changed, 85 insertions(+), 85 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index a934c13..0e41d00

[libvirt] [patch]make libvirt run dir accessable for applications

2012-06-04 Thread Royce Lv
vdsm failed to connect to libvirt because of can't access /var/run/libvirt,caused by libvirt create this dir with umask(077) change the create umask to 022: https://bugzilla.redhat.com/show_bug.cgi?id=828073 Signed-off-by: lvroyce lvro...@linux.vnet.ibm.com --- daemon/libvirtd.c |2 +- 1

[libvirt] [PATCH] virsh: use keepalive protocol in virsh for migration

2012-06-04 Thread Guannan Ren
Bugzilla:https://bugzilla.redhat.com/show_bug.cgi?id=822839 For non-p2p migration, if the network is down in the process of migrate, The virsh client will hang up for a fair long time. The patch will add keepalive into virsh to determine the status of network connection with remote libvirtd,

Re: [libvirt] [PATCH 1/7] Update internal data structures to support multiple security label definitions

2012-06-04 Thread Michal Privoznik
On 21.05.2012 15:39, Marcelo Cerri wrote: --- src/conf/capabilities.c | 17 ++- src/conf/capabilities.h |6 +- src/conf/domain_audit.c | 14 ++- src/conf/domain_conf.c | 310 +++ src/conf/domain_conf.h | 18 +++- 5 files changed,

Re: [libvirt] [PATCH] virsh: use keepalive protocol in virsh for migration

2012-06-04 Thread Jiri Denemark
On Mon, Jun 04, 2012 at 21:51:02 +0800, Guannan Ren wrote: Bugzilla:https://bugzilla.redhat.com/show_bug.cgi?id=822839 For non-p2p migration, if the network is down in the process of migrate, The virsh client will hang up for a fair long time. The patch will add keepalive into virsh to

Re: [libvirt] [PATCH] virsh: use keepalive protocol in virsh for migration

2012-06-04 Thread Guannan Ren
On 06/04/2012 10:13 PM, Jiri Denemark wrote: On Mon, Jun 04, 2012 at 21:51:02 +0800, Guannan Ren wrote: Bugzilla:https://bugzilla.redhat.com/show_bug.cgi?id=822839 For non-p2p migration, if the network is down in the process of migrate, The virsh client will hang up for a fair long time. The

[libvirt] [PATCH v2] file: Log closing filedescriptors

2012-06-04 Thread Jiri Denemark
EBADF errors are logged as warnings as they normally indicate a double close bug. This patch also provides VIR_MASS_CLOSE helper to be user in the only case of mass close after fork when EBADF should rather be ignored. --- src/util/command.c |2 +- src/util/virfile.c | 31

Re: [libvirt] [PATCH v2] file: Log closing filedescriptors

2012-06-04 Thread Eric Blake
On 06/04/2012 08:46 AM, Jiri Denemark wrote: EBADF errors are logged as warnings as they normally indicate a double close bug. This patch also provides VIR_MASS_CLOSE helper to be user in the only case of mass close after fork when EBADF should rather be ignored. --- src/util/command.c |

Re: [libvirt] [PATCH] virsh: use keepalive protocol in virsh for migration

2012-06-04 Thread Jiri Denemark
On Mon, Jun 04, 2012 at 22:41:00 +0800, Guannan Ren wrote: On 06/04/2012 10:13 PM, Jiri Denemark wrote: On Mon, Jun 04, 2012 at 21:51:02 +0800, Guannan Ren wrote: Bugzilla:https://bugzilla.redhat.com/show_bug.cgi?id=822839 For non-p2p migration, if the network is down in the process of

Re: [libvirt] [PATCH v2] file: Log closing filedescriptors

2012-06-04 Thread Jiri Denemark
On Mon, Jun 04, 2012 at 08:55:56 -0600, Eric Blake wrote: On 06/04/2012 08:46 AM, Jiri Denemark wrote: EBADF errors are logged as warnings as they normally indicate a double close bug. This patch also provides VIR_MASS_CLOSE helper to be user in the only case of mass close after fork when

Re: [libvirt] [PATCH 1/2] Add VSCSI bus type and VSCSI controller type for pseries guest.

2012-06-04 Thread Cole Robinson
On 05/30/2012 02:57 AM, Li Zhang wrote: On 05/30/2012 07:25 AM, Cole Robinson wrote: On 05/03/2012 10:05 PM, Li Zhang wrote: Now, there is only SCSI bus and controller type in libvirt. And when configuring VSCSI controller, it needs to configure the spapr-vio bus address type externally. It's

Re: [libvirt] [PATCH] fix make syntax-check failed

2012-06-04 Thread Eric Blake
On 06/04/2012 07:19 AM, Eric Blake wrote: On 06/04/2012 04:29 AM, Michal Privoznik wrote: On 04.06.2012 05:37, Wen Congyang wrote: --- tools/virsh.c | 170 1 files changed, 85 insertions(+), 85 deletions(-) Therefore we need

[libvirt] [PATCH] build: allow building with newer glibc-headers and -O0

2012-06-04 Thread Eric Blake
glibc 2.15 (on Fedora 17) coupled with explicit disabling of optimization during development dies a painful death: In file included from /usr/include/limits.h:27:0, from /usr/lib/gcc/x86_64-redhat-linux/4.7.0/include/limits.h:169, from

[libvirt] [PATCH] util: fix make rpm when viratomic.h is used

2012-06-04 Thread Laine Stump
Although src/util/viratomic.h has been added to the repo, up until now it hasn't been used. Stefan Berger is using it in his proposed dhcp snooping patches, and an rpm build with those patches failed due to viratomic.h not being packed up with the rest of the sources. Pushed under build-breaker +

Re: [libvirt] [PATCH] build: include viratomic.h into dist file

2012-06-04 Thread Eric Blake
On 06/04/2012 01:43 AM, Osier Yang wrote: On 2012年06月04日 11:36, Wen Congyang wrote: We add viratomic.h, but we forget to include it into dist file. This file is used in nwfilter/nwfilter_dhcpsnoop.c now. --- src/Makefile.am |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

Re: [libvirt] [PATCH] virsh: Accept UUID as an argument for storage commands

2012-06-04 Thread Eric Blake
On 06/04/2012 02:35 AM, Osier Yang wrote: Affected commands are: pool-start, vol-create-from. --- tools/virsh.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) Nice usability enhancement. ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCH] virsh: Back out if the argument for vol-create-as is malformed

2012-06-04 Thread Eric Blake
On 06/04/2012 03:08 AM, Osier Yang wrote: --- tools/virsh.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4737948..4810627 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -11372,18 +11372,24 @@

Re: [libvirt] [PATCH] virsh: Accept UUID as an argument for net-info and net-start

2012-06-04 Thread Eric Blake
On 06/04/2012 02:37 AM, Osier Yang wrote: --- tools/virsh.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [libvirt] [patch]make libvirt run dir accessable for applications

2012-06-04 Thread Eric Blake
On 06/04/2012 06:56 AM, Royce Lv wrote: vdsm failed to connect to libvirt because of can't access /var/run/libvirt,caused by libvirt create this dir with umask(077) change the create umask to 022: https://bugzilla.redhat.com/show_bug.cgi?id=828073 Signed-off-by: lvroyce

Re: [libvirt] [patch]make libvirt run dir accessable for applications

2012-06-04 Thread Eric Blake
On 06/04/2012 01:16 PM, Eric Blake wrote: On 06/04/2012 06:56 AM, Royce Lv wrote: vdsm failed to connect to libvirt because of can't access /var/run/libvirt,caused by libvirt create this dir with umask(077) change the create umask to 022: https://bugzilla.redhat.com/show_bug.cgi?id=828073

Re: [libvirt] [PATCH] Add some missing hook functions

2012-06-04 Thread Eric Blake
On 05/28/2012 08:20 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com A core use case of the hook scripts is to be able to do things to a guest's network configuration. It is possible to hook into the 'start' operation for a QEMU guest which runs just before the

Re: [libvirt] [PATCH] command: avoid deadlock on EPIPE situation

2012-06-04 Thread Eric Blake
On 06/02/2012 02:12 AM, Michal Privoznik wrote: On 01.06.2012 17:41, Eric Blake wrote: It is possible to deadlock libvirt by having a domain with XML longer than PIPE_BUF, and by writing a hook script that closes stdin early. This is because libvirt was keeping a copy of the child's stdin

[libvirt] [PATCH] maint: command.c whitespace cleanups

2012-06-04 Thread Eric Blake
Noticed during the previous commit. * src/util/command.c: Fix some spacing and break long lines. --- Pushing under the trivial rule. src/util/command.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/src/util/command.c

Re: [libvirt] [PATCH] Fix for parallel port passtrough for QEMU

2012-06-04 Thread Eric Blake
On 05/22/2012 11:50 PM, beat.jo...@ssatr.ch wrote: Hi As requested by Dave, I send this to the list. Thank you. I came across a bug that the command line generated for passtrough of the host parallel port /dev/parport0 by libvirt for QEMU is incorrect. s/passtrough/passthrough/ It

Re: [libvirt] [PATCH] Convert 'raw MAC address' usages to use virMacAddr

2012-06-04 Thread Eric Blake
On 06/03/2012 07:08 PM, Stefan Berger wrote: Introduce new members in the virMacAddr 'class': - virMacAddrSet: set virMacAddr from a virMacAddr - virMacAddrSetRaw: setting virMacAddr from raw 6 byte MAC address buffer - virMacAddrGetRaw: writing virMacAddr into raw 6 byte MAC address buffer -

Re: [libvirt] [PATCH] Convert 'raw MAC address' usages to use virMacAddr

2012-06-04 Thread Stefan Berger
On 06/04/2012 07:26 PM, Eric Blake wrote: On 06/03/2012 07:08 PM, Stefan Berger wrote: Introduce new members in the virMacAddr 'class': - virMacAddrSet: set virMacAddr from a virMacAddr - virMacAddrSetRaw: setting virMacAddr from raw 6 byte MAC address buffer - virMacAddrGetRaw: writing

Re: [libvirt] [PATCH 1/2] Add VSCSI bus type and VSCSI controller type for pseries guest.

2012-06-04 Thread Li Zhang
On 06/04/2012 11:16 PM, Cole Robinson wrote: On 05/30/2012 02:57 AM, Li Zhang wrote: On 05/30/2012 07:25 AM, Cole Robinson wrote: On 05/03/2012 10:05 PM, Li Zhang wrote: Now, there is only SCSI bus and controller type in libvirt. And when configuring VSCSI controller, it needs to configure