[libvirt] [libvirt-php PATCH 2/2] add wrapper function libvirt_storagepool_delete for virStoragePoolDelete

2012-06-10 Thread Tiziano Müller
--- src/libvirt-php.c | 25 + src/libvirt-php.h |1 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index c50fd74..6513c52 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -156,6 +156,7 @@ static zend_fu

[libvirt] [libvirt-php PATCH 1/2] Fix building with threaded php

2012-06-10 Thread Tiziano Müller
--- src/libvirt-php.c | 344 +++-- src/libvirt-php.h |2 +- 2 files changed, 174 insertions(+), 172 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 20e5d27..c50fd74 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@

Re: [libvirt] [PATCH 1/2] Add VSCSI bus type and VSCSI controller type for pseries guest.

2012-06-10 Thread Paolo Bonzini
Il 08/06/2012 04:08, Li Zhang ha scritto: >> A simple >> >> >> >> >> >> >> >> >> will do exactly what you want and add a default ibmvscsi controller. >> More complex cases are handled with the controller element: > > It's a little hard to know if the dis

Re: [libvirt] [PATCH] docs: link to FLOSS Weekly podcast

2012-06-10 Thread Guido Günther
On Thu, Jun 07, 2012 at 01:28:44PM -0600, Eric Blake wrote: > Eric Blake and Guido Günther were guests during this week's > FLOSS Weekly podcast, giving insights into libvirt as a Free > Software project. > > * docs/relatedlinks.html.in: Add link. > --- > > I'm not sure if I picked the best place

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-10 Thread Guido Günther
On Fri, Jun 08, 2012 at 11:13:53AM +0200, Michal Privoznik wrote: > On 08.06.2012 11:02, Alex Jia wrote: > > On 06/08/2012 04:04 PM, Michal Privoznik wrote: > >> This feature has been requested for a very long time. However, > > I'm very glad to see this patch :-) > >> we had to wait for guest agen

Re: [libvirt] [PATCH] msg_buf_size is unsigned long not size_t

2012-06-10 Thread Guido Günther
On Sat, Jun 09, 2012 at 07:07:01PM -0600, Eric Blake wrote: > On 06/09/2012 01:12 PM, Guido Günther wrote: > > This fixes the build on 32bit systems which otherwise fails with: > > > > virnetmessagetest.c: In function 'testMessageHeaderEncode': > > virnetmessagetest.c:75:9: error: format '%zu' exp

Re: [libvirt] [PATCH] docs: link to FLOSS Weekly podcast

2012-06-10 Thread Guido Günther
On Sat, Jun 09, 2012 at 09:31:54PM +0200, Guido Günther wrote: > On Thu, Jun 07, 2012 at 01:28:44PM -0600, Eric Blake wrote: > > Eric Blake and Guido Günther were guests during this week's > > FLOSS Weekly podcast, giving insights into libvirt as a Free > > Software project. > > > > * docs/related

[libvirt] [PATCH] LXC: delete unused variable src in lxcContainerMountBasicFS

2012-06-10 Thread Gao feng
there is no code use the variable "src" in lxcContainerMountBasicFS. so delete it and VIR_FREE. Signed-off-by: Gao feng --- src/lxc/lxc_container.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index fb59694..506e

[libvirt] [PATCH] LXC: fix incorrect parameter of mount in lxcContainerMountFSBind

2012-06-10 Thread Gao feng
when do remount,the source and target should be the same values specified in the initial mount() call. So change fs->dst to src. Signed-off-by: Gao feng --- src/lxc/lxc_container.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_co

Re: [libvirt] [PATCH] LXC: delete unused variable src in lxcContainerMountBasicFS

2012-06-10 Thread Osier Yang
On 2012年06月11日 11:30, Gao feng wrote: there is no code use the variable "src" in lxcContainerMountBasicFS. so delete it and VIR_FREE. Signed-off-by: Gao feng --- src/lxc/lxc_container.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxc_container.c b/sr

Re: [libvirt] [PATCH] snapshot: avoid virsh crash with older servers

2012-06-10 Thread Osier Yang
On 2012年06月09日 01:56, Eric Blake wrote: Commits 51082301, 16d7b39, and 521cc447 introduced support for 'virsh snapshot-list --from' when talking to a server older than 0.9.5, but broke support for plain 'virsh snapshot-list' for the same old server in the process. Because the code is not properl

Re: [libvirt] [PATCH] virsh: let 'connect' without args remember -c option

2012-06-10 Thread Osier Yang
On 2012年06月09日 07:42, Eric Blake wrote: If a user invokes 'virsh -c $URI', then within that batch shell, they probably want 'connect' to revert to $URI rather than the normal default URI you get for passing in NULL. In particular, I had a setup where qemu:///session was failing, but took 20 seco

Re: [libvirt] [PATCH] LXC: fix incorrect parameter of mount in lxcContainerMountFSBind

2012-06-10 Thread Osier Yang
On 2012年06月11日 11:37, Gao feng wrote: when do remount,the source and target should be the same values specified in the initial mount() call. So change fs->dst to src. Signed-off-by: Gao feng --- src/lxc/lxc_container.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

Re: [libvirt] [PATCH] docs: link to FLOSS Weekly podcast

2012-06-10 Thread Osier Yang
On 2012年06月10日 03:31, Guido Günther wrote: On Thu, Jun 07, 2012 at 01:28:44PM -0600, Eric Blake wrote: Eric Blake and Guido Günther were guests during this week's FLOSS Weekly podcast, giving insights into libvirt as a Free Software project. * docs/relatedlinks.html.in: Add link. --- I'm not s

[libvirt] [PATCH] LXC: fix memory leak in lxcContainerMountFSBlockAuto

2012-06-10 Thread Gao feng
we forgot to free fslist,just add VIR_FREE(fslist). Signed-off-by: Gao feng --- src/lxc/lxc_container.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index cd15ca4..297bd6d 100644 --- a/src/lxc/lxc_container.c +++ b/src

Re: [libvirt] [PATCH] LXC: fix memory leak in lxcContainerMountFSBlockAuto

2012-06-10 Thread Osier Yang
On 2012年06月11日 13:52, Gao feng wrote: we forgot to free fslist,just add VIR_FREE(fslist). Signed-off-by: Gao feng --- src/lxc/lxc_container.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index cd15ca4..297bd6d 10064

Re: [libvirt] [PATCH 2/4] snapshot: add 'virsh snapshot-info'

2012-06-10 Thread Osier Yang
On 2012年05月25日 11:33, Eric Blake wrote: Expose the recent API additions in virsh. Borrows ideas from 'dominfo' for the general type of information to display. Output looks like: $ tools/virsh snapshot-info fedora-local tmp Name: tmp Domain: fedora-local Current:no Sta

Re: [libvirt] [PATCH 1/4] snapshot: new query APIs

2012-06-10 Thread Osier Yang
On 2012年05月25日 11:33, Eric Blake wrote: Right now, starting from just a virDomainSnapshotPtr, and wanting to know if it is the current snapshot for its respective domain, you have to use virDomainSnapshotGetDomain(), then virDomainSnapshotCurrent(), then compare the two names returned by virDomai

Re: [libvirt] [PATCH 3/4] snapshot: RPC for new query APIs

2012-06-10 Thread Osier Yang
On 2012年05月25日 11:33, Eric Blake wrote: Pretty straightforward. * src/remote/remote_protocol.x (remote_domain_snapshot_is_current_args) (remote_domain_snapshot_is_current_ret) (remote_domain_snapshot_has_metadata_args) (remote_domain_snapshot_has_metadata_ret): New structs. (REMOTE_PROC_DOMAIN_S