[libvirt] virDomainMemoryStats call

2012-07-18 Thread Parakkal, Navin S
Hi, I'm using the API virDomainMemoryStats to fetch memory stats for a domain/guest on Fedora 16/RHEL 6.3 . I don't get these counters filled up VIR_DOMAIN_MEMORY_STAT_UNUSED, VIR_DOMAIN_MEMORY_STAT_ACTUAL_BALLOON,VIR_DOMAIN_MEMORY_STAT_AVAILABLE , VIR_DOMAIN_MEMORY_STAT_MAJOR_FAULT and

Re: [libvirt] [PATCH] remote: Fix locking in stream APIs

2012-07-18 Thread Michal Privoznik
On 17.07.2012 19:30, Jiri Denemark wrote: Remote driver needs to make sure the driver lock is released before entering client IO loop as that may block indefinitely in poll(). As a direct consequence of not following this in stream APIs, tunneled migration to a destination host which becomes

Re: [libvirt] virDomainMemoryStats call

2012-07-18 Thread Osier Yang
On 2012年07月18日 15:00, Parakkal, Navin S wrote: Hi, I’m using the API virDomainMemoryStats to fetch memory stats for a domain/guest on Fedora 16/RHEL 6.3 . I don’t get these counters filled up VIR_DOMAIN_MEMORY_STAT_UNUSED, VIR_DOMAIN_MEMORY_STAT_ACTUAL_BALLOON,VIR_DOMAIN_MEMORY_STAT_AVAILABLE

Re: [libvirt] How to get the real device in guest os after attached a disk?

2012-07-18 Thread Stefan Hajnoczi
On Wed, Jul 18, 2012 at 5:01 AM, Wangpan hzwang...@corp.netease.com wrote: But how can I get the serial info in the guest os? General documentation on persistent block device naming (just grabbed the first useful link of Google):

Re: [libvirt] [PATCH] remote: Fix locking in stream APIs

2012-07-18 Thread Jiri Denemark
On Wed, Jul 18, 2012 at 09:46:12 +0200, Michal Privoznik wrote: On 17.07.2012 19:30, Jiri Denemark wrote: Remote driver needs to make sure the driver lock is released before entering client IO loop as that may block indefinitely in poll(). As a direct consequence of not following this in

Re: [libvirt] [PATCH v3] storage backend: Add sheepdog support

2012-07-18 Thread Sebastian Wiedenroth
*ping* if this version addresses all previous concerns, what can i do to get this merged? ;-) Am 26.06.2012 um 13:25 schrieb Sebastian Wiedenroth: This patch brings support to manage sheepdog pools and volumes to libvirt. It uses the collie command-line utility that comes with sheepdog for

Re: [libvirt] [PATCH] nodeinfo: deal with offline cpus in a node

2012-07-18 Thread Peter Krempa
On 07/18/12 04:01, Eric Blake wrote: Commit 80533ca forgot to think about offline cpus. When a node cpu is offline, then its topology/ subdirectory is not present, leading to spurious error messages leaked to the user such as: libvir: error : cannot open

Re: [libvirt] [RFC] Support cpu hotplug in libvirt.

2012-07-18 Thread Viktor Mihajlovski
On 07/18/2012 03:44 AM, Eric Blake wrote: On 07/17/2012 07:33 PM, tangchen wrote: Hi~ It seems that libvirt is not cpu hotplug aware. Portions of libvirt are aware of host hotplug issues, but you are correct that there are still lingering bugs (I just found one today in nodeinfo.c). 4.

Re: [libvirt] [PATCH 13/13] Turn virNetClient* into virObject instances

2012-07-18 Thread Daniel P. Berrange
On Tue, Jul 17, 2012 at 02:36:18PM -0600, Eric Blake wrote: On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make all the virNetClient* objects use virObject APIs for reference counting Signed-off-by: Daniel P. Berrange

Re: [libvirt] How to get the real device in guest os after attached a disk?

2012-07-18 Thread Wangpan
Thanks Stefan, But how can I get the serial info in the guest os? I have tried 'hdparm', 'sdparm', 'lshw', 'smartctl' and failed finally. for example, root@debian:~# hdparm -i /dev/vdc /dev/vdb: HDIO_DRIVE_CMD(identify) failed: Inappropriate ioctl for device HDIO_GET_IDENTITY failed:

Re: [libvirt] [PATCHv3] fix failure when building with --disable-debug

2012-07-18 Thread Cong Wang
On Fri, 13 Jul 2012 at 07:50 GMT, Hu Tao hu...@cn.fujitsu.com wrote: +/** + * virLogEatParam: + * + * Do nothing but eat parameters. + */ +static inline void virLogEatParam(const char *category, + const char *funcname, +

Re: [libvirt] [glib PATCH V2] Add bindings for virStorageDownload() and virStorageUpload()

2012-07-18 Thread Cong Wang
On Fri, 13 Jul 2012 at 07:37 GMT, Jovanka Gulicoska jovanka.gulico...@gmail.com wrote: +gboolean gvir_storage_vol_download(GVirStorageVol *vol, + GVirStream *stream, + unsigned long long offset, +

Re: [libvirt] virDomainMemoryStats call

2012-07-18 Thread Navin P
+++ Osier Yang [18/07/12 16:13 +0800]: On 2012年07月18日 15:00, Parakkal, Navin S wrote: Hi, I’m using the API virDomainMemoryStats to fetch memory stats for a domain/guest on Fedora 16/RHEL 6.3 . I don’t get these counters filled up VIR_DOMAIN_MEMORY_STAT_UNUSED,

Re: [libvirt] [glib PATCH V2] Add bindings for virStorageDownload() and virStorageUpload()

2012-07-18 Thread Daniel P. Berrange
On Wed, Jul 18, 2012 at 09:33:58AM +, Cong Wang wrote: On Fri, 13 Jul 2012 at 07:37 GMT, Jovanka Gulicoska jovanka.gulico...@gmail.com wrote: +gboolean gvir_storage_vol_download(GVirStorageVol *vol, + GVirStream *stream, +

Re: [libvirt] [PATCH] storage: netfs and iscsi need option srcSpec for resource discovery

2012-07-18 Thread Cong Wang
On Mon, 16 Jul 2012 at 15:21 GMT, Guannan Ren g...@redhat.com wrote: This patch adds a check for it, error info changed to: error: Failed to find any netfs pool sources error: internal error pool type 'netfs' need option \ --srcSpec for source discovery s/need/needs/ -- libvir-list

[libvirt] Libvirt on power pc

2012-07-18 Thread B Veera-B37207
Hi, Using command line I am able to bring up VM Here is the command: qemu-system-ppc -enable-kvm -m 512M -mem-path /var/lib/hugetlbfs/pagesize-4MB -nographic -M ppce500v2 -kernel /boot/uImage-p2020rdb.bin -initrd ./guest.rootfs.ext2.gz -append root=/dev/ram rw console=ttyS0,115200 -serial

[libvirt] [PATCH] rpc: remove trailing carriage return character in error string

2012-07-18 Thread Guannan Ren
If the error message string ends with '\r\n', it is not enough to remove '\n' only which leads to messed string. Example, after three time incorrect password input, virsh command virsh -c qemu://remoteserver/system will report error like: : Connection reset by

Re: [libvirt] [PATCH] storage: netfs and iscsi need option srcSpec for resource discovery

2012-07-18 Thread Guannan Ren
On 07/18/2012 05:58 PM, Cong Wang wrote: On Mon, 16 Jul 2012 at 15:21 GMT, Guannan Ren g...@redhat.com wrote: This patch adds a check for it, error info changed to: error: Failed to find any netfs pool sources error: internal error pool type 'netfs' need option \ --srcSpec for source

[libvirt] [PATCH v2] storage: netfs and iscsi need option srcSpec for resource discovery

2012-07-18 Thread Guannan Ren
The option 'srcSpec' to virsh command find-storage-pool-sources is optional for logical type of storage pool, but mandatory for netfs and iscsi type. When missing the option for netfs and iscsi, libvirt reports XML parsing error due to null string option srcSpec. error: Failed to find any netfs

Re: [libvirt] virDomainMemoryStats call

2012-07-18 Thread Osier Yang
On 2012年07月18日 17:34, Navin P wrote: +++ Osier Yang [18/07/12 16:13 +0800]: On 2012年07月18日 15:00, Parakkal, Navin S wrote: Hi, I’m using the API virDomainMemoryStats to fetch memory stats for a domain/guest on Fedora 16/RHEL 6.3 . I don’t get these counters filled up

Re: [libvirt] [RFC] Support cpu hotplug in libvirt.

2012-07-18 Thread tangchen
Hi Viktor: On 07/18/2012 05:06 PM, Viktor Mihajlovski wrote: I was actually considering a workaround in libvirt for what I believe to be a kernel misbehavior, however it is possible to deconfigure the cpuset controller in the host (i.e. removing it from /etc/cgconfig.conf). The CPU pinning

Re: [libvirt] [RFC] Support cpu hotplug in libvirt.

2012-07-18 Thread Viktor Mihajlovski
On 07/18/2012 12:53 PM, tangchen wrote: Hi Viktor: On 07/18/2012 05:06 PM, Viktor Mihajlovski wrote: I was actually considering a workaround in libvirt for what I believe to be a kernel misbehavior, however it is possible to deconfigure the cpuset controller in the host (i.e. removing it

[libvirt] [PATCH 01/13] Introduce virReportError macro for general error reporting

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Nearly every source file does something like #define VIR_FROM_THIS VIR_FROM_FOO #define virFooReportErorr(code, ...) \ virReportErrorHelper(VIR_FROM_THIS, code, __FILE__,\ __FUNCTION__, __LINE__, \

[libvirt] [PATCH 04/13] Remove newline from end of error message in virnodesuspend.c

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/virnodesuspend.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c index 7e37118..c6becce 100644 ---

[libvirt] [PATCH 00/13] Remove many custom error reporting macros

2012-07-18 Thread Daniel P. Berrange
This series is all about replacing custom error reporting macros with a common virReportError macro cfg.mk| 29 po/POTFILES.in|1 src/conf/cpu_conf.c | 224 +- src/conf/domain_conf.c

[libvirt] [PATCH 02/13] Add _(...) around two error messages in src/util/

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virnetdevtap.c and viruri.c files had two error report messages which were not annotated with _(...) Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/virnetdevtap.c |4 ++-- src/util/viruri.c |2 +- 2 files

[libvirt] [PATCH 09/13] Replace use of virSecretReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the secret driver to use virReportError instead of the virSecretReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/secret/secret_driver.c | 70

[libvirt] [PATCH 03/13] Add viruri.c to POTFILES.in

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- po/POTFILES.in |1 + 1 file changed, 1 insertion(+) diff --git a/po/POTFILES.in b/po/POTFILES.in index 31246f7..6ca40d9 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -151,6 +151,7 @@

[libvirt] [PATCH 13/13] Replace use of networkReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the linux bridge driver to use virReportError instead of the networkReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/network/bridge_driver.c | 344

[libvirt] [PATCH 10/13] Replace use of virNodeDeviceReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the node device driver to use virReportError instead of the virNodeDeviceReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/node_device/node_device_driver.c |

Re: [libvirt] [PATCH 00/13] Remove many custom error reporting macros

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: This series is all about replacing custom error reporting macros with a common virReportError macro 79 files changed, 3510 insertions(+), 3705 deletions(-) Yet another big series that nukes more than it adds, and is probably mostly

[libvirt] [PATCH 11/13] Replace use of virNWFilterReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the network filter driver to use virReportError instead of the virNWFilterReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk|1 - src/nwfilter/nwfilter_dhcpsnoop.c

[libvirt] [PATCH 12/13] Replace use of interfaceReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the netcf driver to use virReportError instead of the interfaceReportError custom macro --- cfg.mk |1 - src/interface/netcf_driver.c | 150 -- 2 files changed, 73

Re: [libvirt] [PATCH 02/13] Add _(...) around two error messages in src/util/

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virnetdevtap.c and viruri.c files had two error report messages which were not annotated with _(...) Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/virnetdevtap.c |

Re: [libvirt] [PATCH 01/13] Introduce virReportError macro for general error reporting

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Nearly every source file does something like #define VIR_FROM_THIS VIR_FROM_FOO #define virFooReportErorr(code, ...) \ virReportErrorHelper(VIR_FROM_THIS, code, __FILE__,\

Re: [libvirt] [PATCH 03/13] Add viruri.c to POTFILES.in

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- po/POTFILES.in |1 + 1 file changed, 1 insertion(+) diff --git a/po/POTFILES.in b/po/POTFILES.in index 31246f7..6ca40d9 100644

Re: [libvirt] [PATCH 04/13] Remove newline from end of error message in virnodesuspend.c

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/virnodesuspend.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnodesuspend.c

Re: [libvirt] [PATCH 00/13] Remove many custom error reporting macros

2012-07-18 Thread Daniel P. Berrange
On Wed, Jul 18, 2012 at 05:58:34AM -0600, Eric Blake wrote: On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: This series is all about replacing custom error reporting macros with a common virReportError macro 79 files changed, 3510 insertions(+), 3705 deletions(-) Yet another big

[libvirt] [RFC] [PATCH] Support for uevent netlink and hotplug event.

2012-07-18 Thread tangchen
NOTE: This patch is just for some comments, so that we can try to improve netlink support in libvirt. This patch introduces a new global array servers[MAX_LINKS], and all the netlink protocol (at most 32 protocols) can be supportted. And also, it creates a NETLINK_KOBJECT_UEVENT socket to

Re: [libvirt] [libvirt-glib] Fix *_new_from_xml

2012-07-18 Thread Christophe Fergeau
On Wed, Jul 18, 2012 at 03:16:03PM +0200, Christophe Fergeau wrote: For objects with a subtype 'type' attribute, when the _new_from_xml function was called, the 'type' attribute was forcefully set to the right value rather than checking that the passed-in value matches the type of the subclass

[libvirt] [libvirt-glib PATCHv2] Fix *_new_from_xml

2012-07-18 Thread Christophe Fergeau
For objects with a subtype 'type' attribute, when the _new_from_xml function was called, the 'type' attribute was forcefully set to the right value rather than checking that the passed-in value matches the type of the subclass we are trying to instantiate. This commit changes this, and returns

Re: [libvirt] [PATCH 05/13] Convert (nearly) all files in src/util/ to use virReportError()

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This removes nearly all the per-file error reporting macros from the code in src/util/. A few custom macros remain for the case, where the file needs to report errors with a variety of different

Re: [libvirt] [PATCH 06/13] Convert all files in src/rpc/ to use virReportError()

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This rmoves all the per-file error reporting macros s/rmoves/removes/ from the code in src/rpc/ Signed-off-by: Daniel P. Berrange berra...@redhat.com --- +++ b/src/rpc/virnetserver.c @@

Re: [libvirt] [PATCH] rpc: remove trailing carriage return character in error string

2012-07-18 Thread Eric Blake
On 07/18/2012 04:15 AM, Guannan Ren wrote: If the error message string ends with '\r\n', it is not enough to remove '\n' only which leads to messed string. Example, after three time incorrect password input, virsh command virsh -c qemu://remoteserver/system will report error like: :

[libvirt] [PATCH v2] rpc: remove trailing whitespace character in error string

2012-07-18 Thread Guannan Ren
Instead of only removing the ending newline character, it is better to remove all of standard whitespace character for the sake of log format. One example that we have to do this is: After three times incorrect password input, virsh command virsh -c qemu://remoteserver/system will report error

Re: [libvirt] [PATCH 05/13] Convert (nearly) all files in src/util/ to use virReportError()

2012-07-18 Thread Daniel P. Berrange
On Wed, Jul 18, 2012 at 07:54:11AM -0600, Eric Blake wrote: +++ b/src/util/hooks.c @@ -252,9 +248,9 @@ virHookCall(int driver, break; } if (opstr == NULL) { -virHookReportError(VIR_ERR_INTERNAL_ERROR, - _(Hook for %s, failed

Re: [libvirt] [PATCH 06/13] Convert all files in src/rpc/ to use virReportError()

2012-07-18 Thread Daniel P. Berrange
On Wed, Jul 18, 2012 at 08:20:12AM -0600, Eric Blake wrote: On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This rmoves all the per-file error reporting macros s/rmoves/removes/ from the code in src/rpc/ Signed-off-by: Daniel P.

[libvirt] [PATCH] virsh man page - domain-id consistency

2012-07-18 Thread Jan Tomko
Using 'domain-id' to represent domain name, domain id or uuid, as introduced in the DOMAIN COMMANDS section. --- tools/virsh.pod | 86 +++--- 1 files changed, 43 insertions(+), 43 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index

Re: [libvirt] [PATCH v2] rpc: remove trailing whitespace character in error string

2012-07-18 Thread Eric Blake
On 07/18/2012 09:23 AM, Guannan Ren wrote: Instead of only removing the ending newline character, it is better to remove all of standard whitespace character for the sake of log format. One example that we have to do this is: After three times incorrect password input, virsh command virsh

Re: [libvirt] [PATCH] virsh man page - domain-id consistency

2012-07-18 Thread Eric Blake
On 07/18/2012 10:03 AM, Jan Tomko wrote: Using 'domain-id' to represent domain name, domain id or uuid, as introduced in the DOMAIN COMMANDS section. --- tools/virsh.pod | 86 +++--- 1 files changed, 43 insertions(+), 43 deletions(-) diff

[libvirt] [PATCH 09/16] Move cgroup setup code out of lxc_controller.c

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move the cgroup setup code out of the lxc_controller.c file and into lxc_cgroup.{c,h}. This reduces the size of the lxc_controller.c file and paves the way to invoke cgroup setup from lxc_driver.c instead of lxc_controller.c in the future

[libvirt] [PATCH 12/16] Rename all APIs in lxc_domain.c to have a virLXCDomain prefix

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com For consistency all the APIs in the lxc_domain.c file should have a virLXCDomain prefix in their name Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_domain.c | 14 +++--- src/lxc/lxc_domain.h |2 +-

[libvirt] [PATCH 01/16] Add missing deps on driver modules in libvirt RPM

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Turning on the building of driver modules in libvirt.spec.in means that installing 'libvirt' no longer pulls in all the drivers. For upgrade compatibility we need to list all drivers module sub-RPMs against the 'libvirt' RPM. Signed-off-by: Daniel P.

Re: [libvirt] [PATCH v2 2/5] multiple security drivers in XML data

2012-07-18 Thread Michal Privoznik
On 18.07.2012 03:28, Marcelo Cerri wrote: This patch updates the domain XML parser and formatter to support more than one seclabel element for each domain and device. The RNG schema and the tests related to this are also updated by this patch. --- docs/schemas/domaincommon.rng

[libvirt] [PATCH 00/16] Misc fixes and refactoring of LXC driver

2012-07-18 Thread Daniel P. Berrange
The first 7 patches in this series are a set of misc fixes I identified while working on the LXC driver code. The remaining 9 patches heavily re-arrange, re-factor and re-name the LXC driver code. The intent is to make the code layout closer in style to the QEMU driver, to facilitate its future

[libvirt] [PATCH 06/16] Process all pending I/O for a RPC client before checking EOF

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com In the socket event handler for the RPC client we must deal with read/write events, before checking for EOF, otherwise we might close the socket before we've read acted upon the last RPC messages Signed-off-by: Daniel P. Berrange berra...@redhat.com

[libvirt] [PATCH 02/16] Don't autostart domains when reloading config

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When sending SIGHUP to libvirtd, it will trigger the virStateDriver reload operation. This is intended to reload the configuration files for guests. For unknown historical reasons this is also triggering autostart of all guests. Autostart is generally

[libvirt] [PATCH 05/16] Reset the 'quit' flag in virNetServerRun

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com To allow virNetServerRun/virNetServerQuit to be invoked multiple times, we must reset the 'quit' flag in virNetServerRun Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/rpc/virnetserver.c |2 ++ 1 file changed, 2 insertions(+) diff

[libvirt] [PATCH 13/16] Rename lxc_driver_t to virLXCDriver

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Rename the lxc_driver_t struct typedef to virLXCDriver to more closely follow normal libvirt naming conventions Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_conf.c|4 +- src/lxc/lxc_conf.h| 14 ---

[libvirt] [PATCH 16/16] Move LXC monitor code out into separate file

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move the code that handles the LXC monitor out of the lxc_process.c file and into lxc_monitor.{c,h} Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/Makefile.am |1 + src/lxc/lxc_domain.h |4 +- src/lxc/lxc_monitor.c |

[libvirt] [PATCH 08/16] Move LXC domain private data into separate file

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move the LXC driver code related to the virDomainObjPtr private data into separate lxc_domain.{c,h} files to reduce the size of lxc_driver.c Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/Makefile.am |1 + src/lxc/lxc_domain.c

[libvirt] [PATCH 07/16] Add lots of internal symbols to libvirt_private.syms

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Make sure that libvirt_private.syms has all the internal symbols from APIs in src/rpc/*.h and src/util/cgroup.h, since the LXC controller/driver will shortly need them Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/libvirt_private.syms

[libvirt] [PATCH 04/16] If in delay close mode for an RPC client, don't read further data

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com In the delayed close mode, we're just waiting for final data to be written back to the client. While waiting, we should not bother to read more data from the client. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH 14/16] Replace use of lxcError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update all LXC code to use virReportError instead of the custom lxcError macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_conf.c| 10 +- src/lxc/lxc_conf.h|5 - src/lxc/lxc_container.c |

Re: [libvirt] [PATCH v2 1/5] Internal refactory of data structures

2012-07-18 Thread Michal Privoznik
On 18.07.2012 03:28, Marcelo Cerri wrote: This patch updates the structures that store information about each domain and each hypervisor to support multiple security labels and drivers. It also updates all the remaining code to use the new fields. --- src/conf/capabilities.c | 17

[libvirt] [PATCH 03/16] Add callback to virNetClient to be invoked on EOF

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Allow detection of EOF in virNetClient via an callback function, triggered from the socket event handler Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/rpc/virnetclient.c | 43 +++

[libvirt] [PATCH 11/16] Rename all APIs in lxc_process.c to have a virLXCProcess prefix

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com For consistency all the APIs in the lxc_process.c file should have a virLXCProcess prefix in their name Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_driver.c | 24 +++--- src/lxc/lxc_process.c | 216

[libvirt] [PATCH 15/16] Convert the LXC driver to use virNetClient

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the LXC driver to use the virNetClient APIs for connecting to the libvirt_lxc monitor, instead of the low-level socket APIs. This is a step towards running a full RPC protocol with libvirt_lxc Signed-off-by: Daniel P. Berrange

Re: [libvirt] libvirt + kvm external snapshots: use case?

2012-07-18 Thread Eric Blake
On 07/15/2012 02:03 PM, Cole Robinson wrote: Forgive my ignorance, but I'm trying to fill in some details for a Fedora feature page: https://fedoraproject.org/w/index.php?title=Features/Virt_Live_Snapshots Yet things aren't working quite as expected in my tests. I'm trying to think of

Re: [libvirt] [PATCH 07/13] Convert all files in src/conf/ to use virReportError()

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This rmoves all the per-file error reporting macros s/rmoves/removes/ from the code in src/conf/ Signed-off-by: Daniel P. Berrange berra...@redhat.com --- 28 files changed, 1912

[libvirt] [PATCH libvirt-glib] gobject: add GVir.DomainXMLFlags binding

2012-07-18 Thread Marc-André Lureau
--- libvirt-gobject/libvirt-gobject-domain.c |2 +- libvirt-gobject/libvirt-gobject-domain.h | 14 ++ libvirt-gobject/libvirt-gobject.sym |5 + 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c

Re: [libvirt] [PATCH v2 1/5] Internal refactory of data structures

2012-07-18 Thread Eric Blake
On 07/18/2012 10:31 AM, Michal Privoznik wrote: On 18.07.2012 03:28, Marcelo Cerri wrote: This patch updates the structures that store information about each domain and each hypervisor to support multiple security labels and drivers. It also updates all the remaining code to use the new

Re: [libvirt] [PATCH v2 2/5] multiple security drivers in XML data

2012-07-18 Thread Eric Blake
On 07/18/2012 10:31 AM, Michal Privoznik wrote: On 18.07.2012 03:28, Marcelo Cerri wrote: This patch updates the domain XML parser and formatter to support more than one seclabel element for each domain and device. The RNG schema and the tests related to this are also updated by this patch.

Re: [libvirt] [RFC] [PATCH] Support for uevent netlink and hotplug event.

2012-07-18 Thread Viktor Mihajlovski
On 07/18/2012 02:22 PM, tangchen wrote: NOTE: This patch is just for some comments, so that we can try to improve netlink support in libvirt. This patch introduces a new global array servers[MAX_LINKS], and all the netlink protocol (at most 32 protocols) can be supportted. And

Re: [libvirt] [PATCH 08/13] Replace use of virStorageReportError with virReportError

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Update the storage driver to use virReportError instead of the virStorageReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- Still big, but not as big as 7/13.

Re: [libvirt] [PATCH 10/13] Replace use of virNodeDeviceReportError with virReportError

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Update the node device driver to use virReportError instead of the virNodeDeviceReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk

Re: [libvirt] [PATCH 09/13] Replace use of virSecretReportError with virReportError

2012-07-18 Thread Eric Blake
On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Update the secret driver to use virReportError instead of the virSecretReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 -

Re: [libvirt] [PATCH 08/13] Replace use of virStorageReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
On Wed, Jul 18, 2012 at 12:05:20PM -0600, Eric Blake wrote: On 07/18/2012 05:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Update the storage driver to use virReportError instead of the virStorageReportError custom macro Signed-off-by: Daniel P.

[libvirt] [PATCH 00/23] Convert remaining areas of code to use virReportError

2012-07-18 Thread Daniel P. Berrange
This converts all the remaining areas of libvirt code to use the virReportError macro for reporting errors. As before this is a mechanical change which should be a no-op. cfg.mk| 25 daemon/libvirtd-config.c | 60 - daemon/remote.c |

[libvirt] [PATCH 01/23] Replace use of networkReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the linux bridge driver to use virReportError instead of the networkReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/network/bridge_driver.c | 344

[libvirt] [PATCH 05/23] Replace use of virCPUReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the CPU helper APIs to use virReportError instead of the virCPUReportError custom macor Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk|1 - src/cpu/cpu.c | 86

[libvirt] [PATCH 02/23] Replace use of umlReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the UML driver to use virReportError instead of the umlReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/uml/uml_conf.c | 24 +-- src/uml/uml_conf.h |5 ---

[libvirt] [PATCH 11/23] Replace use of virLockError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the lock manager drivers to use virReportError instead of the virLockError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/locking/lock_driver_sanlock.c | 157 ++---

[libvirt] [PATCH 04/23] Replace use of testError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the test driver to use virReportError instead of the testError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/test/test_driver.c | 509 1 file changed, 255

[libvirt] [PATCH 07/23] Replace use of XENXS_ERROR with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the XenXS shared code to use virReportError instead of the XENXS_ERROR custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk|1 - src/xenxs/xen_sxpr.c | 256

[libvirt] [PATCH 06/23] Replace use of openvzError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the OpenVZ driver to use virReportError instead of the openvzError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/openvz/openvz_conf.c | 132 ++---

[libvirt] [PATCH 15/23] Replace use of virSecurityReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the security drivers to use virReportError instead of the virSecurityReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/security/security_apparmor.c | 94

[libvirt] [PATCH 08/23] Replace use of vmwareError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the VMWare driver to use virReportError instead of the vmwareError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/vmware/vmware_conf.c | 56 +++---

[libvirt] [PATCH 16/23] Replace use of PHYP_ERROR with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the Power-Hypervisor driver to use virReportError instead of the PHYP_ERROR custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/phyp/phyp_driver.c | 76

[libvirt] [PATCH 22/23] Replace use of virConfError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the libvirtd config handling code to use virReportError instead of the virConfError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - daemon/libvirtd-config.c | 60

[libvirt] [PATCH 18/23] Replace use of streamsReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the streams code to use virReportError instead of the streamsReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/fdstream.c | 69

[libvirt] [PATCH 23/23] Replace use of virNetError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the libvirtd dispatch code to use virReportError instead of the virNetError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- daemon/remote.c| 214 daemon/stream.c

[libvirt] [PATCH 21/23] Replace use of xenapiError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the XenAPI driver to use virReportError instead of the xenapiError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xenapi/xenapi_driver.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff

[libvirt] [PATCH 14/23] Replace use of HYPERV_ERROR with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the Hyper-V driver to use virReportError instead of the HYPERV_ERROR custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/hyperv/hyperv_driver.c | 142

[libvirt] [PATCH 10/23] Replace use of remoteError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the remote driver to use virReportError instead of the remoteError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/remote/remote_driver.c | 310

[libvirt] [PATCH 20/23] Replace use of nodeReportError with virReportError

2012-07-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the nodeinfo helper code to use virReportError instead of the nodeReportError custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 - src/nodeinfo.c | 104

Re: [libvirt] We need this patch to mount all tmpfs file systems with the correct context.

2012-07-18 Thread Daniel P. Berrange
On Tue, Jul 17, 2012 at 11:48:12AM -0400, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Basically within a Secure Linux Container (virt-sandbox) we want all content that the process within the container can write to be labeled the same. We are labeling the physical

Re: [libvirt] [PATCH v3] storage backend: Add sheepdog support

2012-07-18 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 01:25:55PM +0200, Sebastian Wiedenroth wrote: This patch brings support to manage sheepdog pools and volumes to libvirt. It uses the collie command-line utility that comes with sheepdog for that. A sheepdog pool in libvirt maps to a sheepdog cluster. It needs a host

Re: [libvirt] [PATCH v3] storage backend: Add sheepdog support

2012-07-18 Thread Daniel P. Berrange
On Wed, Jul 18, 2012 at 10:48:38AM +0200, Sebastian Wiedenroth wrote: *ping* if this version addresses all previous concerns, what can i do to get this merged? ;-) Sorry for the delay, I have applied this now :-) Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH v3] esx: Extend esxVI_CURL_Download for partial downloads

2012-07-18 Thread Daniel P. Berrange
On Fri, Jul 13, 2012 at 02:00:19AM +0200, Matthias Bolte wrote: Also ensure that the virBuffer used to store the downloaded data does not overflow. --- v3: - Fix virBuffer limit checks. v2: - Ensure that the used virBuffer dos not overflow. src/esx/esx_driver.c |2 +-

  1   2   >