Re: [libvirt] [PATCH 04/13] Enable cpuset cgroup and synchronous vcpupin info to cgroup.

2012-07-24 Thread Hu Tao
On Tue, Jul 10, 2012 at 05:14:42PM +0800, tangchen wrote: > vcpu threads pin are implemented using sched_setaffinity(), but not > controlled by cgroup. > This patch does the following things: > 1) enable cpuset cgroup I think it's better to make this part and adding of virCgroupGetCpusetCpus/

Re: [libvirt] [PATCH] maint: don't permit format strings without %

2012-07-24 Thread Jim Meyering
Eric Blake wrote: > Any time we have a string with no % passed through gettext, a > translator can inject a % to cause a stack overread. When there > is nothing to format, it's easier to ask for a string that cannot > be used as a formatter, by using a trivial "%s" format instead. > > In the past,

Re: [libvirt] [PATCH] tests: reduce length of nodeinfodata test names

2012-07-24 Thread Jim Meyering
Eric Blake wrote: ... > This [change-set] LOOKS huge, but is really just a couple of 'git mv' > commands and a change to nodeinfotest.c. Scroll to the bottom for > the real change; I've shortened boring parts of this mail to get past > the 100k mail cap enforced by the list. If you set git diff's

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/23/2012 09:42 PM, Daniel P. Berrange wrote: > On Mon, Jul 23, 2012 at 02:25:23PM -0500, Doug Goldstein wrote: >> On Mon, Jul 23, 2012 at 1:51 PM, Martin Kletzander >> wrote: >>> The 'domdisplay' command didn't properly evaluate '--include-password' >>> option. >>> --- >>> tools/virsh.c |

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/23/2012 09:42 PM, Eric Blake wrote: > On 07/23/2012 12:51 PM, Martin Kletzander wrote: >> The 'domdisplay' command didn't properly evaluate '--include-password' >> option. >> --- >> tools/virsh.c | 35 +++ >> 1 files changed, 23 insertions(+), 12 deletions(-

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Daniel P. Berrange
On Tue, Jul 24, 2012 at 09:16:38AM +0200, Martin Kletzander wrote: > On 07/23/2012 09:42 PM, Daniel P. Berrange wrote: > > On Mon, Jul 23, 2012 at 02:25:23PM -0500, Doug Goldstein wrote: > >> On Mon, Jul 23, 2012 at 1:51 PM, Martin Kletzander > >> wrote: > >>> The 'domdisplay' command didn't prop

Re: [libvirt] [PATCH] maint: don't permit format strings without %

2012-07-24 Thread Daniel P. Berrange
On Mon, Jul 23, 2012 at 02:37:42PM -0600, Eric Blake wrote: > Any time we have a string with no % passed through gettext, a > translator can inject a % to cause a stack overread. When there > is nothing to format, it's easier to ask for a string that cannot > be used as a formatter, by using a tri

Re: [libvirt] [PATCH 08/13] Introduce virDomainHypervisorPinAdd and virDomainHypervisorPinDel functions

2012-07-24 Thread Hu Tao
On Tue, Jul 10, 2012 at 05:17:08PM +0800, tangchen wrote: > Introduce 2 APIs to support hypervisor threads pin. > 1) virDomainHypervisorPinAdd: setup hypervisor threads pin with a given > cpumap string. > 2) virDomainHypervisorPinDel: remove all hypervisor threads pin. > > Signed-off-by:

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/24/2012 09:58 AM, Daniel P. Berrange wrote: > On Tue, Jul 24, 2012 at 09:16:38AM +0200, Martin Kletzander wrote: >> On 07/23/2012 09:42 PM, Daniel P. Berrange wrote: >>> On Mon, Jul 23, 2012 at 02:25:23PM -0500, Doug Goldstein wrote: On Mon, Jul 23, 2012 at 1:51 PM, Martin Kletzander >

[libvirt] [PATCH] virsh: Clarify that memtune parameters may be rounded in the man page

2012-07-24 Thread Jan Tomko
--- tools/virsh.pod |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index b4a3d5c..6ecf6ce 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1366,7 +1366,10 @@ appropriate limit is adjusted if supported by the hypervisor. LXC an

[libvirt] [PATCH 00/13 v2] Split virsh

2012-07-24 Thread Osier Yang
There are conflicts after splitting 2/11 and 3/11, so post the whole set again. v1 - v2: * split 2/11, and 3/11 for the patches were too big. However, the new 3/13 is still quite big. I will send it individualy after compression. This splits virsh.c by the command groups, except 'virsh itse

[libvirt] [PATCH 01/13] virsh: Move definition of cmds and cmd groups right at the top of main

2012-07-24 Thread Osier Yang
This will avoid many conflicts if moving the codes for each command group into separate files in later patches. --- tools/virsh.c | 967 - 1 files changed, 483 insertions(+), 484 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index

[libvirt] [PATCH 12/13] virsh: Split cmds in node device group from virsh.c

2012-07-24 Thread Osier Yang
Commands in node device group moved from virsh.c to virsh-nodedev.c, * virsh.c: Remove commands in node device group. * virsh-nodedev.c: New file, filled with commands in node device group --- tools/virsh-nodedev.c | 383 + tools/virsh.c |

[libvirt] [PATCH 06/13] virsh: Split cmds to manage network from virsh.c

2012-07-24 Thread Osier Yang
Commands to manage network are moved from virsh.c to virsh-network.c, with a few helpers for network command use. * virsh.c: Remove network commands and a few helpers. * virsh-network.c: New file, filled with network commands its helpers. --- tools/virsh-network.c | 688 +

[libvirt] [PATCH 09/13] virsh: Split cmds to manage secret from virsh.c

2012-07-24 Thread Osier Yang
Commands to manage secret are moved from virsh.c to virsh-secret.c, with a few helpers for secret command use. * virsh.c: Remove secret commands and helper (vshCommandOptSecret). * virsh-secret.c: New file, filled with secret commands and its helper. --- tools/virsh-secret.c | 358 ++

[libvirt] [PATCH 08/13] virsh: Split cmds to manage network filter from virsh.c

2012-07-24 Thread Osier Yang
Commands to manage network filter are moved from virsh.c to virsh-nwfilter.c, with a few helpers for network filter command use. * virsh.c: Remove network filter commands and a few helpers. (vshCommandOptNWFilter, and vshCommandOptNWFilterBy) * virsh-nwfilter.c: New file, filled with ne

[libvirt] [PATCH 11/13] virsh: Split cmds in host group from virsh.c

2012-07-24 Thread Osier Yang
Commands in host group moved from virsh.c to virsh-host.c, * virsh.c: Remove commands in host group. * virsh-host.c: New file, filled with commands in host group --- tools/virsh-host.c | 820 tools/virsh.c | 799 +

[libvirt] [PATCH 13/13] virsh: Move command group definition into its own file

2012-07-24 Thread Osier Yang
* virsh-domain-monitor.c: Add domMonitoringCmds * virsh-domain.c: Add domManagementCmds * virsh-host.c: Add hostAndHypervisorCmds * virsh-interface.c: Add ifaceCmds * virsh-network.c: Add networkCmds * virsh-nodedev.c: Add nodedevCmds * virsh-nwfilter.c: Add nwfilterCmds * virsh-pool.c: Add storage

Re: [libvirt] [PATCH 0/3] Storage: Allow pool building while creating it

2012-07-24 Thread Osier Yang
Ping. Patch 1/3 is just about the indention fix. We tries to start the pool while creating a transicient pool, if the pool target is not existed yet, we must fail on starting, and thus we see many users raise up the problem on either list or bugzilla. Patch 2/3 and 3/3 are to fix the problem

Re: [libvirt] [libvirt-glib PATCHv2] Fix *_new_from_xml

2012-07-24 Thread Christophe Fergeau
ping? Christophe On Wed, Jul 18, 2012 at 03:39:39PM +0200, Christophe Fergeau wrote: > For objects with a subtype 'type' attribute, when the _new_from_xml > function was called, the 'type' attribute was forcefully set to the > right value rather than checking that the passed-in value matches > th

Re: [libvirt] [PATCH 1/3] Fix the indentions of libvirt.h.in

2012-07-24 Thread Peter Krempa
On 07/11/12 16:27, Osier Yang wrote: Substitute 2 spaces with 4 spaces instead. ACK, just whitespace change. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/3] storage: New flags to allow building the pool while creating it

2012-07-24 Thread Peter Krempa
On 07/11/12 16:27, Osier Yang wrote: We see the requirement for allowing to build the pool while pool-create /pool-create-as/pool-start often in either upstream list or bugzilla, so this patch introduces the flags virStoragePoolCreateFlags for both virStoragePoolCreate and virStoragePoolCreateXML

Re: [libvirt] [PATCH 09/13] Introduce qemudDomainPinHypervisorFlags and qemudDomainGetHypervisorPinInfo in qemu driver.

2012-07-24 Thread Hu Tao
On Tue, Jul 10, 2012 at 05:17:45PM +0800, tangchen wrote: > Introduce 2 APIs to support hypervisor threads pin in qemu driver. > 1) qemudDomainPinHypervisorFlags: setup hypervisor threads pin info. > 2) qemudDomainGetHypervisorPinInfo: get all hypervisor threads pin info. > They are similar

Re: [libvirt] [PATCH 11/13] Introduce remoteDispatchDomainPinHypervisorFlags and remoteDispatchDomainGetHypervisorPinInfo functions.

2012-07-24 Thread Hu Tao
Please squash this patch into patch 10. -- Thanks, Hu Tao -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib PATCHv2] Fix *_new_from_xml

2012-07-24 Thread Daniel P. Berrange
On Wed, Jul 18, 2012 at 03:39:39PM +0200, Christophe Fergeau wrote: > For objects with a subtype 'type' attribute, when the _new_from_xml > function was called, the 'type' attribute was forcefully set to the > right value rather than checking that the passed-in value matches > the type of the subcl

[libvirt] [PATCH][TCK] add tests for network interface transaction

2012-07-24 Thread Kyla Zhang
From: Xiaoqiang Hu add tests for network interface transaction: interface_change_begin, interface_change_commit and interface_change_rollback --- .../networks/110-interface-change-transaction.t| 81 1 files changed, 81 insertions(+), 0 deletions(-) create mode 100644

[libvirt] [PATCH v2][TCK] add test case for block job lifecycle testing

2012-07-24 Thread Kyla Zhang
From: Xiaoqiang Hu v2: Add skip block for qemu only and 120s timeout for test v1: Add tests for block job lifecyle and the test flow is as follows: create 50M qed img with qed backing img-> block pull->abort block job->resume block pull->set block job speed-> wait to finish --- scripts/qemu/300

Re: [libvirt] [libvirt-glib PATCHv2] Fix *_new_from_xml

2012-07-24 Thread Marc-André Lureau
On Tue, Jul 24, 2012 at 12:24 PM, Daniel P. Berrange wrote: > Should we instead be using g_return_if_fail() so you get a dianostic, > on the basis that this is programmer mistake ? That was my feeling too. Although I think returning NULL is not a real problem, especailly if the object implements

Re: [libvirt] [libvirt-glib PATCHv2] Fix *_new_from_xml

2012-07-24 Thread Christophe Fergeau
On Tue, Jul 24, 2012 at 12:55:52PM +0200, Marc-André Lureau wrote: > On Tue, Jul 24, 2012 at 12:24 PM, Daniel P. Berrange > wrote: > > Should we instead be using g_return_if_fail() so you get a dianostic, > > on the basis that this is programmer mistake ? > > That was my feeling too. Although I t

Re: [libvirt] [libvirt-glib PATCHv2] Fix *_new_from_xml

2012-07-24 Thread Marc-André Lureau
On Tue, Jul 24, 2012 at 1:53 PM, Christophe Fergeau wrote: > GVirConfigObject does not implement GInitable. I don't think that would break API/ABI to implement it (provided you don't return GError in existing _new() functions), but the bindings could use that information to check return value. Bu

Re: [libvirt] [PATCH v5 0/6] file descriptor passing using fd sets

2012-07-24 Thread Kevin Wolf
Am 23.07.2012 15:07, schrieb Corey Bryant: > Corey Bryant (6): > qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg > qapi: Introduce add-fd, remove-fd, query-fdsets > monitor: Clean up fd sets on monitor disconnect > block: Convert open calls to qemu_open > block: Convert close calls to qem

Re: [libvirt] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-24 Thread Kevin Wolf
Am 23.07.2012 15:08, schrieb Corey Bryant: > When qemu_open is passed a filename of the "/dev/fdset/nnn" > format (where nnn is the fdset ID), an fd with matching access > mode flags will be searched for within the specified monitor > fd set. If the fd is found, a dup of the fd will be returned >

[libvirt] Unable to start VM Libvirt-0.9.13

2012-07-24 Thread B Veera-B37207
Hi Daniel, I am unable to start VM Lbvirt Version : Compiled against library: libvir 0.9.13 Using library: libvir 0.9.13 Using API: QEMU 0.9.13 Running hypervisor: QEMU 1.0.0 Here is my command: LC_ALL=C PATH=/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin HOME=/home/root USER=roo

Re: [libvirt] [PATCH] building: fix deps error when some drivers are not built

2012-07-24 Thread Wen Congyang
On 07/24/2012 06:12 AM, Eric Blake wrote: On 07/23/2012 03:58 AM, Wen Congyang wrote: libvirt-daemon-driver-XXX should be depent on only when with_driver_modules s/depent on/a dependency/g is 1. libvirt-daemon-driver-libxl should be depent on only when with_libxl is 1. libvirt-daemon-driver-

[libvirt] [PATCH v2 3/5] Add callback to virNetClient to be invoked on connection close

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Allow detection of socket close in virNetClient via an callback function, triggered on any condition that causes the socket to be close. Signed-off-by: Daniel P. Berrange --- src/libvirt_private.syms |2 +- src/rpc/virnetclient.c | 35

[libvirt] [PATCH v2 0/5] Callbacks to detect connection failure

2012-07-24 Thread Daniel P. Berrange
Update of this series https://www.redhat.com/archives/libvir-list/2012-July/msg00917.html Most significant change is adding a separate API to allow the callback to be unregistered -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 1/5] Add public API to register a callback to be invoked on connection close

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Define new virConnect{Register,Unregister}CloseCallback() public APIs which allows registering/unregistering a callback to be invoked when the connection to a hypervisor is closed. The callback is provided with the reason for the close, which may be 'error', 'eof' or 'k

[libvirt] [PATCH v2 2/5] Ensure client is marked for close in all error paths

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently if the keepalive timer triggers, the 'markClose' flag is set on the virNetClient. A controlled shutdown will then be performed. If an I/O error occurs during read or write of the connection an error is raised back to the caller, but the connection isn't marked

[libvirt] [PATCH 05/11] Replace use of lxcError with virReportError

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Update all LXC code to use virReportError instead of the custom lxcError macro Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_conf.c | 10 +- src/lxc/lxc_conf.h |5 - src/lxc/lxc_container.c | 30 ++--- src/lxc/lxc_controller.c | 58

[libvirt] [PATCH 06/11] Convert the LXC driver to use virNetClient

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Update the LXC driver to use the virNetClient APIs for connecting to the libvirt_lxc monitor, instead of the low-level socket APIs. This is a step towards running a full RPC protocol with libvirt_lxc Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_domain.c |3

[libvirt] [PATCH 07/11] Move LXC monitor code out into separate file

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move the code that handles the LXC monitor out of the lxc_process.c file and into lxc_monitor.{c,h} Signed-off-by: Daniel P. Berrange --- po/POTFILES.in|1 + src/Makefile.am |1 + src/lxc/lxc_domain.h |4 +- src/lxc/lxc_monitor.c | 163 +++

[libvirt] [PATCH v2 5/5] Extend events demo to show close callbacks in use

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Use a driver close callback to trigger shutdown of the events demo program Signed-off-by: Daniel P. Berrange --- examples/domain-events/events-c/event-test.c | 33 -- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/examples/do

[libvirt] [PATCH v2 4/5] Update remote driver to support the connection close callbacks

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Update the remote driver to use the virNetClient close callback to trigger the virConnectPtr close callbacks Signed-off-by: Daniel P. Berrange --- src/remote/remote_driver.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/remote/remote_d

[libvirt] [PATCH 10/11] Allow CAP_SYS_REBOOT on new enough kernels

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Check whether the reboot() system call is virtualized, and if it is, then allow the container to keep CAP_SYS_REBOOT. Based on an original patch by Serge Hallyn Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_container.c | 88

[libvirt] [PATCH 11/11] Add handling for reboots of LXC containers

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The reboot() syscall is allowed by new kernels for LXC containers. The LXC controller can detect whether a reboot was requested (instead of a normal shutdown) by looking at the "init" process exit status. If a reboot was triggered, the exit status will record SIGHUP as

[libvirt] Handle reboots in LXC driver

2012-07-24 Thread Daniel P. Berrange
This is a series which makes it possible to properly handle reboots in the LXC driver. The lxc_controller can detect if the container asked for a reboot by looking at the exit status of the init process & checking for SIGHUP as the termination signal. The fun is that the lxc controller cannot actua

[libvirt] [PATCH 02/11] Rename all APIs in lxc_process.c to have a virLXCProcess prefix

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" For consistency all the APIs in the lxc_process.c file should have a virLXCProcess prefix in their name Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_driver.c | 24 +++--- src/lxc/lxc_process.c | 216 - src/lxc/

[libvirt] [PATCH 08/11] Make RPC code generator a little more flexible

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Update the gendispatch.pl script to get a little closer to being able to generate code for the LXC monitor, by passing in the struct prefix separately from the procedure prefix. Also allow method names using virCapitalLetters instead of vir_underscore_separator Signed-

[libvirt] [PATCH 09/11] Run an RPC protocol over the LXC controller monitor

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This defines a new RPC protocol to be used between the LXC controller and the libvirtd LXC driver. There is only a single RPC message defined thus far, an asynchronous "EXIT" event that is emitted just before the LXC controller process exits. This provides the LXC drive

[libvirt] [PATCH 03/11] Rename all APIs in lxc_domain.c to have a virLXCDomain prefix

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" For consistency all the APIs in the lxc_domain.c file should have a virLXCDomain prefix in their name Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_domain.c | 14 +++--- src/lxc/lxc_domain.h |8 src/lxc/lxc_driver.c |2 +- src/lxc/lx

[libvirt] [PATCH 01/11] Process all pending I/O for a RPC client before checking EOF

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" In the socket event handler for the RPC client we must deal with read/write events, before checking for EOF, otherwise we might close the socket before we've read & acted upon the last RPC messages Signed-off-by: Daniel P. Berrange --- src/rpc/virnetclient.c | 20 +

[libvirt] [PATCH 04/11] Rename lxc_driver_t to virLXCDriver

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Rename the lxc_driver_t struct typedef to virLXCDriver to more closely follow normal libvirt naming conventions Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_conf.c|4 +- src/lxc/lxc_conf.h| 14 --- src/lxc/lxc_driver.c | 101 +

Re: [libvirt] [PATCH 2/3] storage: New flags to allow building the pool while creating it

2012-07-24 Thread Osier Yang
On 2012年07月24日 17:53, Peter Krempa wrote: On 07/11/12 16:27, Osier Yang wrote: We see the requirement for allowing to build the pool while pool-create /pool-create-as/pool-start often in either upstream list or bugzilla, so this patch introduces the flags virStoragePoolCreateFlags for both virSt

Re: [libvirt] [PATCH 2/3] storage: New flags to allow building the pool while creating it

2012-07-24 Thread Osier Yang
On 2012年07月24日 17:53, Peter Krempa wrote: On 07/11/12 16:27, Osier Yang wrote: We see the requirement for allowing to build the pool while pool-create /pool-create-as/pool-start often in either upstream list or bugzilla, so this patch introduces the flags virStoragePoolCreateFlags for both virSt

[libvirt] [PATCH 2/3 v2] storage: New flags to allow building the pool while creating it

2012-07-24 Thread Osier Yang
We see the requirement for allowing to build the pool while pool-create /pool-create-as/pool-start often in either upstream list or bugzilla, so this patch introduces the flags virStoragePoolCreateFlags for both virStoragePoolCreate and virStoragePoolCreateXML. VIR_STORAGE_POOL_CREATE_WITH_BUILD a

[libvirt] [PATCH] Add a test case that checks there are no bogus entries in .syms

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" During refactoring of code, it has proved common to forget to remove old symbols from the .syms file. While the Win32 linker will complain about this, the Linux ELF linker does not. The new test case validates that every symbol listed in the .syms file actually exists i

[libvirt] [PATCH] Remove two non-existant NWFilter driver symbols from .syms

2012-07-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" virNWFilterGetIpAddrForIfname and virNWFilterDelIpAddrForIfname do not exist, so remove them from libvirt_nwfilter.syms Signed-off-by: Daniel P. Berrange --- src/libvirt_nwfilter.syms |2 -- 1 file changed, 2 deletions(-) diff --git a/src/libvirt_nwfilter.syms b

[libvirt] [PATCH v2] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
The 'domdisplay' command didn't properly evaluate '--include-password' option. --- v2: - switched to using 'flags' - kept the second condition in place - fixed indentation after virAsprintf tools/virsh.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/v

Re: [libvirt] [PATCH 27/49] daemon: Fix the wrong macro name

2012-07-24 Thread Guannan Ren
On 07/20/2012 10:25 PM, Osier Yang wrote: WITH_INTERFACE is not defined, it should be WITH_NETCF there to load the interface driver. Eric posted patch weeks ago to resolve the problems in the whole build system, but it's not finalised yet: https://www.redhat.com/archives/libvir-list/2012-June/m

[libvirt] [PATCH v2] fixed SegFault in virauth

2012-07-24 Thread Martin Kletzander
No check for conn->uri being NULL in virAuthGetConfigFilePath (valid state) made the client segfault. This happens for example with these settings: - no virtualbox driver installed (modifies conn->uri) - no default URI set (VIRSH_DEFAULT_CONNECT_URI="", LIBVIRT_DEFAULT_URI="", uri_default="")

Re: [libvirt] [PATCH][TCK] add tests for network interface transaction

2012-07-24 Thread Guannan Ren
On 07/24/2012 06:32 PM, Kyla Zhang wrote: From: Xiaoqiang Hu add tests for network interface transaction: interface_change_begin, interface_change_commit and interface_change_rollback --- .../networks/110-interface-change-transaction.t| 81 1 files changed, 81 inse

Re: [libvirt] [PATCH v2] virsh: fixed domdisplay command

2012-07-24 Thread Peter Krempa
On 07/24/12 16:06, Martin Kletzander wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- v2: - switched to using 'flags' - kept the second condition in place - fixed indentation after virAsprintf tools/virsh.c | 11 --- 1 files changed, 8

Re: [libvirt] [PATCH v2] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/24/2012 04:49 PM, Peter Krempa wrote: > On 07/24/12 16:06, Martin Kletzander wrote: >> The 'domdisplay' command didn't properly evaluate '--include-password' >> option. >> --- >> v2: >> - switched to using 'flags' >> - kept the second condition in place >> - fixed indentation after virA

[libvirt] [libvirt-glib PATCHv3] Fix *_new_from_xml

2012-07-24 Thread Christophe Fergeau
For objects with a subtype 'type' attribute, when the _new_from_xml function was called, the 'type' attribute was forcefully set to the right value rather than checking that the passed-in value matches the type of the subclass we are trying to instantiate. This commit changes this, and returns NULL

Re: [libvirt] [PATCH v2] virsh: fixed domdisplay command

2012-07-24 Thread Doug Goldstein
On Tue, Jul 24, 2012 at 9:06 AM, Martin Kletzander wrote: > The 'domdisplay' command didn't properly evaluate '--include-password' > option. > --- > v2: > - switched to using 'flags' > - kept the second condition in place > - fixed indentation after virAsprintf > > tools/virsh.c | 11 +++

Re: [libvirt] [PATCH 22/49] list: Add helpers to list network objects

2012-07-24 Thread Laine Stump
On 07/24/2012 01:09 AM, Osier Yang wrote: > On 2012年07月24日 04:53, Laine Stump wrote: >> On 07/20/2012 10:25 AM, Osier Yang wrote: >>> src/conf/virobjectlist.c: Add virNetworkMatch to filter the networks; >>> and virNetworkList to iterate over all the networks with the filter. >>> >>> src/conf/virob

Re: [libvirt] [PATCH 1/2] ESX: Add routines to interface driver

2012-07-24 Thread Matthias Bolte
2012/7/23 Laine Stump : > On 07/20/2012 05:20 PM, Ata E Husain Bohra wrote: >> Add following routines to esx_interface_driver: >> esxNumOfInterfaces, >> esxNumOfDefinedInterfaces, >> esxListInterfaces, >> esxListDefinedInterfaces, >> esxInterfaceLookupByMACString, >> esxInte

Re: [libvirt] [PATCH v2] doc: update the minimum value for nodesuspend time duration

2012-07-24 Thread Eric Blake
On 07/23/2012 09:08 PM, Guannan Ren wrote: > On 07/23/2012 11:10 PM, Eric Blake wrote: >> On 07/20/2012 07:47 AM, Guannan Ren wrote: >>> libvirt asks the duration time is above 60 seconds in code >>> >>> -specified by the 'duration' parameter. >>> +specified by the 'duration' parameter. The duratio

Re: [libvirt] [PATCH] maint: don't permit format strings without %

2012-07-24 Thread Eric Blake
On 07/23/2012 03:05 PM, Jim Meyering wrote: > Eric Blake wrote: >> Any time we have a string with no % passed through gettext, a >> translator can inject a % to cause a stack overread. When there >> is nothing to format, it's easier to ask for a string that cannot >> be used as a formatter, by usi

Re: [libvirt] [PATCH] Add a test case that checks there are no bogus entries in .syms

2012-07-24 Thread Laine Stump
On 07/24/2012 09:48 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > During refactoring of code, it has proved common to forget to > remove old symbols from the .syms file. While the Win32 linker > will complain about this, the Linux ELF linker does not. The > new test case validates

Re: [libvirt] [PATCH v2] doc: update the minimum value for nodesuspend time duration

2012-07-24 Thread Srivatsa S. Bhat
On 07/24/2012 08:38 AM, Guannan Ren wrote: > On 07/23/2012 11:10 PM, Eric Blake wrote: >> On 07/20/2012 07:47 AM, Guannan Ren wrote: >>> libvirt asks the duration time is above 60 seconds in code >>> >>> src/util/virnodesuspend.c: >>> define MIN_TIME_REQ_FOR_SUSPEND 60 /* in seconds */ >>> >>>

Re: [libvirt] [PATCH 1/2] ESX: Add routines to interface driver

2012-07-24 Thread Laine Stump
On 07/24/2012 03:26 PM, Matthias Bolte wrote: > 2012/7/23 Laine Stump : >> On 07/20/2012 05:20 PM, Ata E Husain Bohra wrote: >>> Add following routines to esx_interface_driver: >>> esxNumOfInterfaces, >>> esxNumOfDefinedInterfaces, >>> esxListInterfaces, >>> esxListDefinedInterfaces

Re: [libvirt] [PATCH] Remove two non-existant NWFilter driver symbols from .syms

2012-07-24 Thread Laine Stump
On 07/24/2012 09:48 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > virNWFilterGetIpAddrForIfname and virNWFilterDelIpAddrForIfname > do not exist, so remove them from libvirt_nwfilter.syms > > Signed-off-by: Daniel P. Berrange > --- > src/libvirt_nwfilter.syms |2 -- > 1 file

Re: [libvirt] [PATCH] Remove two non-existant NWFilter driver symbols from .syms

2012-07-24 Thread Eric Blake
On 07/24/2012 07:48 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > virNWFilterGetIpAddrForIfname and virNWFilterDelIpAddrForIfname > do not exist, so remove them from libvirt_nwfilter.syms > > Signed-off-by: Daniel P. Berrange > --- > src/libvirt_nwfilter.syms |2 -- > 1 fi

Re: [libvirt] [PATCH] tests: reduce length of nodeinfodata test names

2012-07-24 Thread Eric Blake
On 07/21/2012 09:08 AM, Jim Meyering wrote: > Eric Blake wrote: > ... >> This [change-set] LOOKS huge, but is really just a couple of 'git mv' >> commands and a change to nodeinfotest.c. Scroll to the bottom for >> the real change; I've shortened boring parts of this mail to get past >> the 100k m

Re: [libvirt] [PATCH] esx: Improve error reporting for unknown VI types

2012-07-24 Thread Eric Blake
On 07/21/2012 02:51 PM, Matthias Bolte wrote: > Print the actual unknown type name instead of for AnyType objects. > --- > src/esx/esx_vi.c |2 +- > src/esx/esx_vi_types.c | 36 +--- > src/esx/esx_vi_types.h |1 + > 3 files changed, 27 insertions(+)

Re: [libvirt] [PATCH] Fix libnl CFLAGS/LIBS inclusion

2012-07-24 Thread Eric Blake
On 07/21/2012 07:02 AM, Doug Goldstein wrote: > When using libnl use the variables pkg-config provides incase there are s/incase/in case/ > additional libraries or CFLAGS required to build it. Specificially if s/Specificially/Specifically/ > the libnl headers are not directly in /usr/include. >

Re: [libvirt] [PATCH] virsh: Clarify that memtune parameters may be rounded in the man page

2012-07-24 Thread Eric Blake
On 07/24/2012 02:50 AM, Jan Tomko wrote: > --- > tools/virsh.pod |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/tools/virsh.pod b/tools/virsh.pod > index b4a3d5c..6ecf6ce 100644 > --- a/tools/virsh.pod > +++ b/tools/virsh.pod > @@ -1366,7 +1366,10 @@ appropriate

Re: [libvirt] [PATCH v2] fixed SegFault in virauth

2012-07-24 Thread Eric Blake
On 07/24/2012 08:08 AM, Martin Kletzander wrote: > No check for conn->uri being NULL in virAuthGetConfigFilePath (valid > state) made the client segfault. This happens for example with these > settings: > - no virtualbox driver installed (modifies conn->uri) > - no default URI set (VIRSH_DEFAULT_

Re: [libvirt] [PATCH][TCK] add tests for network interface transaction

2012-07-24 Thread Eric Blake
On 07/24/2012 08:14 AM, Guannan Ren wrote: > On 07/24/2012 06:32 PM, Kyla Zhang wrote: >> From: Xiaoqiang Hu >> >> add tests for network interface transaction: interface_change_begin, >> interface_change_commit and interface_change_rollback >> --- >> .../networks/110-interface-change-transaction

Re: [libvirt] [PATCH 27/49] daemon: Fix the wrong macro name

2012-07-24 Thread Eric Blake
On 07/24/2012 08:05 AM, Guannan Ren wrote: > On 07/20/2012 10:25 PM, Osier Yang wrote: >> WITH_INTERFACE is not defined, it should be WITH_NETCF there to load >> the interface driver. >> >> Eric posted patch weeks ago to resolve the problems in the whole >> build system, but it's not finalised yet:

Re: [libvirt] [PATCH 22/49] list: Add helpers to list network objects

2012-07-24 Thread Osier Yang
On 2012年07月25日 01:22, Laine Stump wrote: On 07/24/2012 01:09 AM, Osier Yang wrote: On 2012年07月24日 04:53, Laine Stump wrote: On 07/20/2012 10:25 AM, Osier Yang wrote: src/conf/virobjectlist.c: Add virNetworkMatch to filter the networks; and virNetworkList to iterate over all the networks with t

Re: [libvirt] [PATCH v2][TCK] add test case for block job lifecycle testing

2012-07-24 Thread Guannan Ren
On 07/24/2012 06:32 PM, Kyla Zhang wrote: From: Xiaoqiang Hu v2: Add skip block for qemu only and 120s timeout for test v1: Add tests for block job lifecyle and the test flow is as follows: create 50M qed img with qed backing img-> block pull->abort block job->resume block pull->set block job

Re: [libvirt] [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-24 Thread Corey Bryant
On 07/24/2012 08:07 AM, Kevin Wolf wrote: Am 23.07.2012 15:08, schrieb Corey Bryant: When qemu_open is passed a filename of the "/dev/fdset/nnn" format (where nnn is the fdset ID), an fd with matching access mode flags will be searched for within the specified monitor fd set. If the fd is fou

Re: [libvirt] [Qemu-devel] [PATCH v5 0/6] file descriptor passing using fd sets

2012-07-24 Thread Corey Bryant
On 07/24/2012 08:09 AM, Kevin Wolf wrote: Am 23.07.2012 15:07, schrieb Corey Bryant: Corey Bryant (6): qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg qapi: Introduce add-fd, remove-fd, query-fdsets monitor: Clean up fd sets on monitor disconnect block: Convert open calls to qemu_o

[libvirt] [PATCH 01/12] Introduce the function virCgroupForHypervisor

2012-07-24 Thread tangchen
From: Wen Congyang Introduce the function virCgroupForHypervisor() to create sub directory for hypervisor thread(include I/O thread, vhost-net thread) Signed-off-by: Wen Congyang Signed-off-by: Tang Chen Signed-off-by: Hu Tao --- src/libvirt_private.syms |1 + src/util/cgroup.c|

[libvirt] [PATCH 02/12] Introduce the function virCgroupMoveTask

2012-07-24 Thread tangchen
From: Wen Congyang Introduce a new API to move tasks of one controller from a cgroup to another cgroup Signed-off-by: Wen Congyang Signed-off-by: Tang Chen Signed-off-by: Hu Tao --- src/libvirt_private.syms |2 + src/util/cgroup.c| 111 ++

[libvirt] [PATCH 03/12] create a new cgroup and move all hypervisor threads to the new cgroup

2012-07-24 Thread tangchen
From: Wen Congyang Create a new cgroup and move all hypervisor threads to the new cgroup. And then we can do the other things: 1. limit only vcpu usage rather than the whole qemu 2. limit for hypervisor threads(include vhost-net threads) Signed-off-by: Wen Congyang Signed-off-by: Tang Chen Sig

[libvirt] [PATCH 05/12] Support hypervisorpin xml parse.

2012-07-24 Thread tangchen
From: Tang Chen This patch adds a new xml element , and also the parser functions, docs, and tests. hypervisorpin means pinning hypervisor threads, and cpuset = '1' means pinning all hypervisor threads to cpu 1. Signed-off-by: Tang Chen Signed-off-by: Hu Tao --- docs/schemas/domaincommon.rng

[libvirt] [PATCH 06/12] Introduce qemuSetupCgroupHypervisorPin and synchronize hypervisorpin info to cgroup.

2012-07-24 Thread tangchen
From: Tang Chen Introduce qemuSetupCgroupHypervisorPin() function to add hypervisor threads pin info to cpuset cgroup, the same as vcpupin. Signed-off-by: Tang Chen Signed-off-by: Hu Tao --- src/qemu/qemu_cgroup.c | 36 src/qemu/qemu_cgroup.h |1 + 2

[libvirt] [PATCH 04/12] Enable cpuset cgroup and synchronous vcpupin info to cgroup.

2012-07-24 Thread tangchen
From: Tang Chen vcpu threads pin are implemented using sched_setaffinity(), but not controlled by cgroup. This patch does the following things: 1) enable cpuset cgroup 2) reflect all the vcpu threads pin info to cgroup Signed-off-by: Tang Chen Signed-off-by: Hu Tao --- src/libvirt_pr

[libvirt] [PATCH 07/12] Add qemuProcessSetHypervisorAffinites and set hypervisor threads affinities

2012-07-24 Thread tangchen
From: Tang Chen Hypervisor threads should also be pinned by sched_setaffinity(), just the same as vcpu threads. Signed-off-by: Tang Chen Signed-off-by: Hu Tao --- src/qemu/qemu_process.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/src

[libvirt] [PATCH v4 00/12] Support hypervisor-threads-pin in vcpupin.

2012-07-24 Thread tangchen
Users can use vcpupin command to bind a vcpu thread to a specific physical cpu. But besides vcpu threads, there are alse some other threads created by qemu (known as hypervisor threads) that could not be explicitly bound to physical cpus. The first 3 patches are from Wen Congyang, which implemen

[libvirt] [PATCH 08/12] Introduce virDomainHypervisorPinAdd and virDomainHypervisorPinDel functions

2012-07-24 Thread tangchen
From: Tang Chen Introduce 2 APIs to support hypervisor threads pin. 1) virDomainHypervisorPinAdd: setup hypervisor threads pin with a given cpumap string. 2) virDomainHypervisorPinDel: remove all hypervisor threads pin. Signed-off-by: Tang Chen Signed-off-by: Hu Tao --- src/conf/doma

[libvirt] [PATCH 09/12] Introduce virDomainPinHypervisorFlags and virDomainGetHypervisorPinInfo functions.

2012-07-24 Thread tangchen
From: Tang Chen Introduce 2 APIs for client to use. 1) virDomainPinHypervisorFlags: call remote driver api, such as remoteDomainPinHypervisorFlags. 2) virDomainGetHypervisorPinInfo: call remote driver api, such as remoteDomainGetHypervisorPinInfo. Signed-off-by: Tang Chen Signed-off-b

[libvirt] [PATCH 11/12] Introduce remoteDomainPinHypervisorFlags and remoteDomainGetHypervisorPinInfo functions in remote driver.

2012-07-24 Thread tangchen
From: Tang Chen Introduce 2 APIs to support hypervisor threads in remote driver. 1) remoteDomainPinHypervisorFlags: call driver api, such as qemudDomainPinHypervisorFlags. 2) remoteDomainGetHypervisorPinInfo: call driver api, such as qemudDomainGetHypervisorPinInfo. They are similar to

[libvirt] [PATCH 12/12] Improve vcpupin to support hypervisorpin dynically.

2012-07-24 Thread tangchen
From: Tang Chen Modify vcpupin command to support hypervisor threads pin. 1) add "--hypervisor" option to get hypervisor threads info. 2) add "--hypervisor cpuset" to set hypervisor threads to specified cpuset. Signed-off-by: Tang Chen Signed-off-by: Hu Tao --- tests/vcpupin |6

[libvirt] [PATCH 10/12] Introduce qemudDomainPinHypervisorFlags and qemudDomainGetHypervisorPinInfo in qemu driver.

2012-07-24 Thread tangchen
From: Tang Chen Introduce 2 APIs to support hypervisor threads pin in qemu driver. 1) qemudDomainPinHypervisorFlags: setup hypervisor threads pin info. 2) qemudDomainGetHypervisorPinInfo: get all hypervisor threads pin info. They are similar to qemudDomainPinVcpuFlags and qemudDomainGetVc

[libvirt] [PATCH v3] util: set minimum value of nodesuspend duration to 60 seconds

2012-07-24 Thread Guannan Ren
Change the permissible minimum value of nodesuspend duration time to 60 seconds. If option is less than the value, reports error. Update virsh help and manpage the infomation. --- src/util/virnodesuspend.c |2 +- tools/virsh.c |2 +- tools/virsh.pod |3 ++- 3 file