[libvirt] [PATCH 08/17] Introduce virDomainHypervisorPinAdd and virDomainHypervisorPinDel functions

2012-08-03 Thread Hu Tao
From: Tang Chen tangc...@cn.fujitsu.com Introduce 2 APIs to support hypervisor threads pin. 1) virDomainHypervisorPinAdd: setup hypervisor threads pin with a given cpumap string. 2) virDomainHypervisorPinDel: remove all hypervisor threads pin. Signed-off-by: Tang Chen

[libvirt] [PATCH 02/17] Introduce the function virCgroupMoveTask

2012-08-03 Thread Hu Tao
From: Wen Congyang we...@cn.fujitsu.com Introduce a new API to move tasks of one controller from a cgroup to another cgroup Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Tang Chen tangc...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/libvirt_private.syms

[libvirt] [PATCH 01/17] Introduce the function virCgroupForHypervisor

2012-08-03 Thread Hu Tao
From: Wen Congyang we...@cn.fujitsu.com Introduce the function virCgroupForHypervisor() to create sub directory for hypervisor thread(include I/O thread, vhost-net thread). There is already function to create cgroup dir for vcpus. Function virCgroupForHypervisor() creates cgroup dir for

[libvirt] [PATCH 00/17] Supports for hypervisor-pin and hypervisor-bandwidth

2012-08-03 Thread Hu Tao
This series is a merge of 1) Support hypervisor-threads-pin in vcpupin (https://www.redhat.com/archives/libvir-list/2012-July/msg01361.html) 2) support to set cpu bandwidth for hypervisor threads (https://www.redhat.com/archives/libvir-list/2012-June/msg01161.html) to make life

[libvirt] [PATCH 09/17] Introduce virDomainPinHypervisorFlags and virDomainGetHypervisorPinInfo functions.

2012-08-03 Thread Hu Tao
From: Tang Chen tangc...@cn.fujitsu.com Introduce 2 APIs for client to use. 1) virDomainPinHypervisorFlags: call remote driver api, such as remoteDomainPinHypervisorFlags. 2) virDomainGetHypervisorPinInfo: call remote driver api, such as remoteDomainGetHypervisorPinInfo. Signed-off-by:

[libvirt] [PATCH 07/17] Add qemuProcessSetHypervisorAffinites and set hypervisor threads affinities

2012-08-03 Thread Hu Tao
From: Tang Chen tangc...@cn.fujitsu.com Hypervisor threads should also be pinned by sched_setaffinity(), just the same as vcpu threads. Signed-off-by: Tang Chen tangc...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/qemu/qemu_process.c | 54

[libvirt] [PATCH 13/17] limit cpu bandwidth only for vcpus

2012-08-03 Thread Hu Tao
This patch changes the behaviour of xml element cputune.period and cputune.quota to limit cpu bandwidth only for vcpus, and no longer limit cpu bandwidth for the whole guest. The reasons to do this are: - This matches docs of cputune.period and cputune.quota. - The other parts excepting

[libvirt] [PATCH 03/17] create a new cgroup and move all hypervisor threads to the new cgroup

2012-08-03 Thread Hu Tao
From: Wen Congyang we...@cn.fujitsu.com Create a new cgroup and move all hypervisor threads to the new cgroup. And then we can do the other things: 1. limit only vcpu usage rather than the whole qemu 2. limit for hypervisor threads(include vhost-net threads) Signed-off-by: Wen Congyang

[libvirt] [PATCH 11/17] Introduce remoteDomainPinHypervisorFlags and remoteDomainGetHypervisorPinInfo functions in remote driver.

2012-08-03 Thread Hu Tao
From: Tang Chen tangc...@cn.fujitsu.com Introduce 2 APIs to support hypervisor threads in remote driver. 1) remoteDomainPinHypervisorFlags: call driver api, such as qemudDomainPinHypervisorFlags. 2) remoteDomainGetHypervisorPinInfo: call driver api, such as

[libvirt] [PATCH 17/17] update doc about hypervisor_period/hypervisor_quota

2012-08-03 Thread Hu Tao
--- tools/virsh.pod | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index ffc0777..92cb897 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1202,7 +1202,8 @@ available for each hypervisor are: LXC (posix scheduler) :

[libvirt] [PATCH 04/17] Enable cpuset cgroup and synchronous vcpupin info to cgroup.

2012-08-03 Thread Hu Tao
From: Tang Chen tangc...@cn.fujitsu.com vcpu threads pin are implemented using sched_setaffinity(), but not controlled by cgroup. This patch does the following things: 1) enable cpuset cgroup 2) reflect all the vcpu threads pin info to cgroup Signed-off-by: Tang Chen

[libvirt] [PATCH 06/17] Introduce qemuSetupCgroupHypervisorPin and synchronize hypervisorpin info to cgroup.

2012-08-03 Thread Hu Tao
From: Tang Chen tangc...@cn.fujitsu.com Introduce qemuSetupCgroupHypervisorPin() function to add hypervisor threads pin info to cpuset cgroup, the same as vcpupin. Signed-off-by: Tang Chen tangc...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/qemu/qemu_cgroup.c | 36

[libvirt] [PATCH 05/17] Support hypervisorpin xml parse.

2012-08-03 Thread Hu Tao
From: Tang Chen tangc...@cn.fujitsu.com This patch adds a new xml element hypervisorpin cpuset='1', and also the parser functions, docs, and tests. hypervisorpin means pinning hypervisor threads, and cpuset = '1' means pinning all hypervisor threads to cpu 1. Signed-off-by: Tang Chen

[libvirt] [PATCH 12/17] Improve vcpupin to support hypervisorpin dynamically.

2012-08-03 Thread Hu Tao
From: Tang Chen tangc...@cn.fujitsu.com Modify vcpupin command to support hypervisor threads pin. 1) add --hypervisor option to get hypervisor threads info. 2) add --hypervisor cpuset to set hypervisor threads to specified cpuset. Signed-off-by: Tang Chen tangc...@cn.fujitsu.com

[libvirt] [PATCH 16/17] qemu: Implement hypervisor_period and hypervisor_quota's modification

2012-08-03 Thread Hu Tao
From: Wen Congyang we...@cn.fujitsu.com allow the user change/get hypervisor's period and quota when the vm is running. --- include/libvirt/libvirt.h.in | 16 + src/qemu/qemu_driver.c | 133 +- 2 files changed, 148 insertions(+), 1 deletion(-)

[libvirt] [PATCH 10/17] Introduce qemudDomainPinHypervisorFlags and qemudDomainGetHypervisorPinInfo in qemu driver.

2012-08-03 Thread Hu Tao
From: Tang Chen tangc...@cn.fujitsu.com Introduce 2 APIs to support hypervisor threads pin in qemu driver. 1) qemudDomainPinHypervisorFlags: setup hypervisor threads pin info. 2) qemudDomainGetHypervisorPinInfo: get all hypervisor threads pin info. They are similar to

[libvirt] [PATCH 14/17] Update XML Schema for new entries

2012-08-03 Thread Hu Tao
From: Wen Congyang we...@cn.fujitsu.com --- docs/schemas/domaincommon.rng | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index c0b83b3..8729c02 100644 --- a/docs/schemas/domaincommon.rng +++

[libvirt] [PATCH 15/17] qemu: Implement hypervisor's period and quota tunable XML configuration and parsing

2012-08-03 Thread Hu Tao
From: Wen Congyang we...@cn.fujitsu.com set hypervisor's period and quota to limit cpu bandwidth when the vm starts. --- src/conf/domain_conf.c | 25 +++-- src/conf/domain_conf.h |2 ++ src/qemu/qemu_cgroup.c | 11 ++- 3 files changed, 35 insertions(+), 3

Re: [libvirt] [PATCH] build: fix make rpm

2012-08-03 Thread Michal Privoznik
On 03.08.2012 07:46, Laine Stump wrote: make rpm was failing with the following error: Entering directory `/home/laine/devel/libvirt/tests' make[2]: *** No rule to make target `viratomicdata.h', needed by `distdir'. Stop. viratomicdata.h is listed in tests/Makefile.am as a

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-08-03 Thread Hendrik Schwartke
Thanks for your support Eric! Hendrik On 03.08.2012 01:14, Eric Blake wrote: On 07/25/2012 01:43 AM, Hendrik Schwartke wrote: The access, birth, modification and change times are added to storage volumes and corresponding xml representations. Listing the actual output XML in the commit

Re: [libvirt] [PATCH v2 1/3] Add per-guest S3/S4 state configuration

2012-08-03 Thread Paolo Bonzini
Il 03/08/2012 07:16, Doug Goldstein ha scritto: You are proposing /domain/pm; but we also have /domain/os/bios, would this be better as a subelement /domain/os/bios/pm, since it is related to bios options? I would say that /domain/os/bios/pm isn't the correct place because /domain/os

Re: [libvirt] [PATCH v2 1/3] Add per-guest S3/S4 state configuration

2012-08-03 Thread Martin Kletzander
On 08/03/2012 07:16 AM, Doug Goldstein wrote: On Thu, Aug 2, 2012 at 3:36 PM, Eric Blake ebl...@redhat.com wrote: On 08/02/2012 06:05 AM, Martin Kletzander wrote: There is a new pm/ element implemented that can control what ACPI sleeping states will be advertised by BIOS and allowed to be

Re: [libvirt] [PATCH v2 1/3] Add per-guest S3/S4 state configuration

2012-08-03 Thread Martin Kletzander
On 08/03/2012 09:46 AM, Paolo Bonzini wrote: Il 03/08/2012 07:16, Doug Goldstein ha scritto: You are proposing /domain/pm; but we also have /domain/os/bios, would this be better as a subelement /domain/os/bios/pm, since it is related to bios options? I would say that /domain/os/bios/pm isn't

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for S3/S4 state configuration

2012-08-03 Thread Martin Kletzander
On 08/02/2012 10:48 PM, Eric Blake wrote: On 08/02/2012 06:05 AM, Martin Kletzander wrote: This patch adds support for running qemu guests with the required parameters to forcefully enable or disable BIOS advertising of S3 and S4 states. The support for this is added to capabilities and there

[libvirt] [PATCH v2] qemu: Set reasonable RSS limit on domain startup

2012-08-03 Thread Michal Privoznik
If there's a memory leak in qemu or qemu is exploited the host's system will sooner or later start trashing instead of killing the bad process. This however has impact on performance and other guests as well. Therefore we should set a reasonable RSS limit even when user hasn't set any. It's better

[libvirt] [PATCH] conf: Remove console stream callback only when freeing console helper

2012-08-03 Thread Peter Krempa
Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of the daemon when a domain with a open console was destroyed. The fix was wrong as it tried to remove the callback also when the stream was aborted, where at that point the fd stream driver was already freed and removed. This

Re: [libvirt] [PATCH] conf: Remove console stream callback only when freeing console helper

2012-08-03 Thread Alex Jia
On 08/03/2012 05:27 PM, Peter Krempa wrote: Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of the daemon when a domain with a open console was destroyed. The fix was wrong as it tried to remove the callback also when the stream was aborted, where at that point the fd stream

Re: [libvirt] [PATCH] remote: Fill snapshot argument in remoteDomainSnapshotListAllChildren

2012-08-03 Thread Michal Privoznik
On 03.08.2012 11:57, Peter Krempa wrote: The remote driver did not fill the required snapshot parent argument in the RPC call structure that caused a client crash when trying to use this new API. --- src/remote/remote_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

[libvirt] [PATCH] remote: Fill snapshot argument in remoteDomainSnapshotListAllChildren

2012-08-03 Thread Peter Krempa
The remote driver did not fill the required snapshot parent argument in the RPC call structure that caused a client crash when trying to use this new API. --- src/remote/remote_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/remote/remote_driver.c

Re: [libvirt] [glib PATCH V3] Add bindings for virDomainSnapshotCreateXML()

2012-08-03 Thread Christophe Fergeau
Hey, I've worked with Jovanka on this patch, so ACK from me, but I'd appreciate another pair of eyes having a quick look through it just in case. Christophe On Thu, Aug 02, 2012 at 05:58:22PM +0200, Jovanka Gulicoska wrote: --- libvirt-gobject/libvirt-gobject-domain.c | 52

Re: [libvirt] [PATCH libvirt-glib] gobject: add GVir.DomainShutdownFlags binding

2012-08-03 Thread Christophe Fergeau
Hey, On Thu, Jul 19, 2012 at 07:36:50PM +0200, Marc-André Lureau wrote: --- libvirt-gobject/libvirt-gobject-domain.c |2 +- libvirt-gobject/libvirt-gobject-domain.h | 13 + libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 15 insertions(+), 1 deletion(-)

Re: [libvirt] [PATCH libvirt-glib] gobject: add GVir.DomainShutdownFlags binding

2012-08-03 Thread Marc-André Lureau
Hey On Fri, Aug 3, 2012 at 12:20 PM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Thu, Jul 19, 2012 at 07:36:50PM +0200, Marc-André Lureau wrote: --- libvirt-gobject/libvirt-gobject-domain.c |2 +- libvirt-gobject/libvirt-gobject-domain.h | 13 +

Re: [libvirt] [PATCH v10 9/9] parallels: implement VM creation

2012-08-03 Thread Alex Jia
On 08/01/2012 10:51 PM, Eric Blake wrote: On 07/31/2012 09:34 PM, Daniel Veillard wrote: On Tue, Jul 31, 2012 at 10:56:13PM +0400, Dmitry Guryanov wrote: To create a new VM in Parallels Clud Server we should issue s/Clud/Cloud/ ? prlctl create command, and give path to the directory, where

Re: [libvirt] [PATCH libvirt-glib] gobject: add GVir.DomainShutdownFlags binding

2012-08-03 Thread Christophe Fergeau
On Fri, Aug 03, 2012 at 12:44:10PM +0200, Marc-André Lureau wrote: The counterpart GVirDomainStartFlags uses _NONE. Is this a flawed in libvirt API? Do we prefer to copy libvirt or do we want consitancy? I prefer constitancy. I don't think this is a flaw, it's just that '0' has a different

Re: [libvirt] [glib PATCH V3] Add bindings for virDomainSnapshotCreateXML()

2012-08-03 Thread Marc-André Lureau
looks good to me, ack On Fri, Aug 3, 2012 at 12:12 PM, Christophe Fergeau cferg...@redhat.com wrote: Hey, I've worked with Jovanka on this patch, so ACK from me, but I'd appreciate another pair of eyes having a quick look through it just in case. Christophe On Thu, Aug 02, 2012 at

Re: [libvirt] [PATCH] remote: Fill snapshot argument in remoteDomainSnapshotListAllChildren

2012-08-03 Thread Peter Krempa
On 08/03/12 11:59, Michal Privoznik wrote: On 03.08.2012 11:57, Peter Krempa wrote: The remote driver did not fill the required snapshot parent argument in the RPC call structure that caused a client crash when trying to use this new API. --- src/remote/remote_driver.c |1 + 1 files

Re: [libvirt] [PATCH libvirt-glib] gobject: add GVir.DomainShutdownFlags binding

2012-08-03 Thread Marc-André Lureau
On Fri, Aug 3, 2012 at 12:54 PM, Christophe Fergeau cferg...@redhat.com wrote: On Fri, Aug 03, 2012 at 12:44:10PM +0200, Marc-André Lureau wrote: The counterpart GVirDomainStartFlags uses _NONE. Is this a flawed in libvirt API? Do we prefer to copy libvirt or do we want consitancy? I prefer

[libvirt] [glib PATCH V1] Add bindings for virDomainSnapshotCreateFlags

2012-08-03 Thread Jovanka Gulicoska
--- libvirt-gobject/libvirt-gobject-domain.c | 2 +- libvirt-gobject/libvirt-gobject-domain.h | 25 + libvirt-gobject/libvirt-gobject.sym | 1 + 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c

[libvirt] [PATCH] virsh: console: Avoid using stream after being freed.

2012-08-03 Thread Peter Krempa
The stream object wasn't freed causing a double free attempt. --- tools/console.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/console.c b/tools/console.c index afece27..fee2ce3 100644 --- a/tools/console.c +++ b/tools/console.c @@ -101,6 +101,7 @@

Re: [libvirt] [PATCH] virsh: console: Avoid using stream after being freed.

2012-08-03 Thread Martin Kletzander
On 08/03/2012 01:28 PM, Peter Krempa wrote: The stream object wasn't freed causing a double free attempt. --- tools/console.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/console.c b/tools/console.c index afece27..fee2ce3 100644 --- a/tools/console.c +++

Re: [libvirt] [PATCH] virsh: console: Avoid using stream after being freed.

2012-08-03 Thread Peter Krempa
On 08/03/12 13:29, Martin Kletzander wrote: On 08/03/2012 01:28 PM, Peter Krempa wrote: The stream object wasn't freed causing a double free attempt. --- tools/console.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Pushed. Thanks! Peter -- libvir-list mailing list

[libvirt] [PATCH 0/5] Add LibSSH2 transport

2012-08-03 Thread Peter Krempa
This patchset adds LibSSH2 transport implementation for libvirt's virNetSocket object and other needed places to enable connections using the native library instead of spawning the ssh client and communicating using pipes. This patchset lacks addition of documentation (I'll do that later, but I'd

[libvirt] [PATCH 1/5] remote: Clean up coding style and refactor remote connection opening

2012-08-03 Thread Peter Krempa
Remove spaces before fucntion calls and some other coding nits in some parts of the remote driver and refactor getting of URI argument components into variables used by libvirt later on. --- src/remote/remote_driver.c | 292 +--- 1 files changed, 142

[libvirt] [PATCH 4/5] libssh2_transport: Add libssh2 session support to net client code

2012-08-03 Thread Peter Krempa
This patch adds a glue layer to enable using libssh2 code with the network client code. As in the original client implementation, shell code is sent to the server to detect correct options for netcat. --- src/rpc/virnetclient.c | 120 +++-

[libvirt] [PATCH 5/5] libssh2_transport: Use libssh2 driver code in remote driver

2012-08-03 Thread Peter Krempa
This patch adds URI options to support libssh2 transport in the remote driver. A new transport sceme is introduced eg. qemu+libssh://... that utilizes the libssh2 code added in previous patches. The libssh2 code requires the authentication callback to be able to perform keyboard-interactive

[libvirt] [PATCH 2/5] libssh2_transport: add main libssh2 transport implementation

2012-08-03 Thread Peter Krempa
This patch adds helper functions to libssh2 that enable us to use libssh2 in conjunction with libvirt-native virNetSockets instead of using a spawned ssh client process. This implemetation supports tunneled plaintext, keyboard-interactive, private key, ssh agent based and null authentication.

[libvirt] [PATCH 3/5] libssh2_transport: add ssh context support to virNetSocket

2012-08-03 Thread Peter Krempa
This patch enables virNetSocket to be used as an ssh client when properly configured. Fucntion virNetSocketNewConnectLibSSH() is added, that takes all needed parameters and creates a libssh2 session context and performs steps needed to open the connection. --- src/libvirt_private.syms |1 +

Re: [libvirt] [PATCH] conf: Remove console stream callback only when freeing console helper

2012-08-03 Thread Peter Krempa
On 08/03/12 11:56, Alex Jia wrote: On 08/03/2012 05:27 PM, Peter Krempa wrote: Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of the daemon when a domain with a open console was destroyed. The fix was wrong as it tried to remove the callback also when the stream was aborted,

[libvirt] [PATCH v3 4/5] Support for multiple default security drivers in QEMU config

2012-08-03 Thread Marcelo Cerri
This patch replaces the key security_driver in QEMU config by security_drivers, which accepts a list of default drivers. If security_drivers can't be found, libvirt will use security_driver to ensure that it will remain compatible with older version of the config file. Signed-off-by: Marcelo

[libvirt] [PATCH v3 5/5] Update the remote API

2012-08-03 Thread Marcelo Cerri
Thist patch updates libvirt's API to allow applications to inspect the full list of security labels of a domain. Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- daemon/remote.c | 63 include/libvirt/libvirt.h.in |2 +

[libvirt] [PATCH v3 0/5] Per-guest configurable user/group for QEMU processes

2012-08-03 Thread Marcelo Cerri
This is a v3 patch series that updates the libvirt's security driver mechanism to support per-guest configurable user and group for QEMU processes running together with other security drivers, such as SELinux and AppArmor. Comments and feedbacks are welcome. Marcelo Cerri (5): Internal

[libvirt] [PATCH v3 2/5] Multiple security drivers in XML data

2012-08-03 Thread Marcelo Cerri
This patch updates the domain and capability XML parser and formatter to support morethan one seclabel element for each domain and device. The RNG schema and the tests related to this are also updated by this patch. Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com ---

[libvirt] [PATCH v3 1/5] Internal refactory of data structures

2012-08-03 Thread Marcelo Cerri
This patch updates the structures that store information about each domain and each hypervisor to support multiple security labels and drivers. It also updates all the remaining code to use the new fields. Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- src/conf/capabilities.c

[libvirt] [PATCH] Export virUUIDIsValid to libvirt internal code

2012-08-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Pushed under trivial rule --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 75997fe..44b6652 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms

[libvirt] [PATCH] Fix typo s/AM_CLFAGS/AM_CFLAGS/ in sanlock link

2012-08-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Pushed under trivial rule --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index d4c198e..49bcf50 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1455,7 +1455,7 @@

Re: [libvirt] [PATCH] build: fix make rpm

2012-08-03 Thread Laine Stump
On 08/03/2012 02:48 AM, Michal Privoznik wrote: On 03.08.2012 07:46, Laine Stump wrote: make rpm was failing with the following error: Entering directory `/home/laine/devel/libvirt/tests' make[2]: *** No rule to make target `viratomicdata.h', needed by `distdir'. Stop.

[libvirt] [PATCH] output status information during guest shutdown again

2012-08-03 Thread Gerd v. Egidy
With SysV-init libvirt-guests wrote status information to the console during shutdown of the guests. Since the move to systemd libvirt-guests doesn't output this progress information anymore. This patch brings back this feature. It is helpful to show the admin what the system is waiting for

[libvirt] [PATCH] Fix save/restore with USB controller in XML.

2012-08-03 Thread Ján Tomko
USB controller gets put on the first place in XML, but the default one is added at the end of the controllers array. Sorting them before checking ABI compatibility solves this. The default USB controller also doesn't get a PCI address assigned, making virDomainDeviceInfoCheckABIStability fail.

Re: [libvirt] [PATCH] Add APIs for obtaining the unique ID of LVM SCSI volumes

2012-08-03 Thread Daniel P. Berrange
On Thu, Aug 02, 2012 at 11:32:14PM -0500, Doug Goldstein wrote: On Thu, Aug 2, 2012 at 8:09 AM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com Both LVM volumes and SCSI LUNs have a globally unique identifier associated with them. It is useful

[libvirt] [PATCH] client: Free message when freeing client

2012-08-03 Thread Peter Krempa
The last message of the client was not freed leaking 4 bytes of memory in the client when the remote daemon crashed while processing a message. --- src/rpc/virnetclient.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c

Re: [libvirt] [PATCH] client: Free message when freeing client

2012-08-03 Thread Daniel P. Berrange
On Fri, Aug 03, 2012 at 05:32:59PM +0200, Peter Krempa wrote: The last message of the client was not freed leaking 4 bytes of memory in the client when the remote daemon crashed while processing a message. --- src/rpc/virnetclient.c |3 +++ 1 files changed, 3 insertions(+), 0

Re: [libvirt] [glib PATCH V1] Add bindings for virDomainSnapshotCreateFlags

2012-08-03 Thread Christophe Fergeau
ACK On Fri, Aug 03, 2012 at 01:05:19PM +0200, Jovanka Gulicoska wrote: --- libvirt-gobject/libvirt-gobject-domain.c | 2 +- libvirt-gobject/libvirt-gobject-domain.h | 25 + libvirt-gobject/libvirt-gobject.sym | 1 + 3 files changed, 27 insertions(+), 1

[libvirt] [PATCH 08/48] list: Add helper to convert strings separated by ', ' to array

2012-08-03 Thread Osier Yang
tools/virsh.c: New helper function vshStringToArray. tools/virsh-domain.c: use the helper in cmdUndefine. --- tools/virsh-domain.c | 19 ++- tools/virsh.c| 45 + 2 files changed, 47 insertions(+), 17 deletions(-) diff --git

[libvirt] [PATCH 09/48] virsh: Fix the wrong doc for pool-list

2012-08-03 Thread Osier Yang
The storage pool's management doesn't relate with a domain, it probably was a intention, but not achieved yet. And the fact is only active pools are listed by default. --- tools/virsh.pod |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/virsh.pod

[libvirt] [PATCH 10/48] list: Change MATCH for common use in virsh

2012-08-03 Thread Osier Yang
Move definition of MATCH from virsh-domain-monitor.c into virsh.c for further use. --- tools/virsh-domain-monitor.c |2 -- tools/virsh.c|2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index

[libvirt] [PATCH 05/48] list: Implement the RPC calls for virConnectListAllStoragePools

2012-08-03 Thread Osier Yang
The RPC generator doesn't support returning list of object, this patch do the work manually. * daemon/remote.c: Implement the server side handler remoteDispatchConnectListAllStoragePools * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllStoragePools. *

[libvirt] [PATCH 03/48] list: Define new API virStorageListALlStoragePools

2012-08-03 Thread Osier Yang
This introduces a new API to list the storage pool objects, 4 groups of flags are provided to filter the returned pools: * Active or not * Autostarting or not * Persistent or not * And the pool type. include/libvirt/libvirt.h.in: New enum virConnectListAllStoragePoolFlags;

[libvirt] [PATCH 01/48] Avoid strcase check for virsh-*.c

2012-08-03 Thread Osier Yang
The is a preparation patch, all the files listed in _virsh_avoid_strcase will use strcasecmp to sort the objects. --- cfg.mk |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/cfg.mk b/cfg.mk index e2af2bb..871e50a 100644 --- a/cfg.mk +++ b/cfg.mk @@ -736,7 +736,10 @@

[libvirt] [PATCH 04/48] list: Add helpers for listing storage pool objects

2012-08-03 Thread Osier Yang
src/conf/storage_conf.c: Add virStoragePoolMatch to filter the pools; Add virStoragePoolList to iterate over the pool objects with filter. src/conf/storage_conf.h: Declare virStoragePoolMatch, virStoragePoolList, and the macros for filters. src/libvirt_private.syms: Export helper

[libvirt] [PATCH 06/48] list: Implement listAllStoragePools for storage driver

2012-08-03 Thread Osier Yang
src/storage/storage_driver.c: Implement listAllStoragePools. --- src/storage/storage_driver.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 6d7dd2b..7ccb965 100644 ---

[libvirt] [PATCH 02/48] Destroy virdomainlist.[ch]

2012-08-03 Thread Osier Yang
As the consensus in: https://www.redhat.com/archives/libvir-list/2012-July/msg01692.html, this patch is to destroy conf/virdomainlist.[ch], foldering the helpers into conf/domain_conf.[ch]. * src/Makefile.am: - Various indentions fixes incidentally - Add macro DATATYPES_SOURCES

[libvirt] [PATCH 14/48] list: Define new API virStoragePoolListAllVolumes

2012-08-03 Thread Osier Yang
Simply returns the storage volume objects. No supported filter flags. include/libvirt/libvirt.h.in: Declare the API python/generator.py: Skip the function for generating. virStoragePool.py will be added in later patch. src/driver.h: virDrvStoragePoolListVolumesFlags

[libvirt] [PATCH 00/48 v3] Atomic APIs to list objects

2012-08-03 Thread Osier Yang
v2 - v3: * Various document fixes/improvements (Suggested by Laine and Eric) * Destroy virdomainlist.[ch], and folder all list helper funcs into its own *_conf.[ch] * Improve the helpers to get the object list. See https://www.redhat.com/archives/libvir-list/2012-July/msg01267.html

[libvirt] [PATCH 07/48] list: Implement listAllStoragePools for test driver

2012-08-03 Thread Osier Yang
src/test/test_driver.c: Implement listAllStoragePools --- src/test/test_driver.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a767e21..18691ad 100644 --- a/src/test/test_driver.c +++

[libvirt] [PATCH 12/48] virsh: Use vshPrint instead of printf

2012-08-03 Thread Osier Yang
--- tools/virsh-host.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 98d9e62..d9d09b4 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -573,7 +573,7 @@ cmdQemuMonitorCommand(vshControl *ctl, const vshCmd *cmd)

[libvirt] [PATCH 19/48] list: Expose virStoragePoolListAllVolumes to Python binding

2012-08-03 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virStoragePool.py: * New file, includes implementation of listAllVolumes. python/libvirt-override.c:

[libvirt] [PATCH 16/48] list: Implement virStoragePoolListAllVolumes for storage driver

2012-08-03 Thread Osier Yang
src/storage/storage_driver.c: Implement poolListAllVolumes. --- src/storage/storage_driver.c | 67 ++ 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 7ccb965..3e595de 100644

[libvirt] [PATCH 22/48] list: Add helpers to list network objects

2012-08-03 Thread Osier Yang
src/conf/network_conf.c: Add virNetworkMatch to filter the networks; and virNetworkList to iterate over all the networks with the filter. src/conf/network_conf.h: Declare virNetworkList and define the macros for filters. src/libvirt_private.syms: Export virNetworkList. ---

[libvirt] [PATCH 15/48] list: Implemente RPC calls for virStoragePoolListAllVolumes

2012-08-03 Thread Osier Yang
The RPC generator doesn't returning support list of object, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchStoragePoolListAllVolumes * src/remote/remote_driver.c: Add remote driver handler remoteStoragePoolListAllVolumes *

[libvirt] [PATCH 11/48] list: Use virConnectListAllStoragePools in virsh

2012-08-03 Thread Osier Yang
tools/virsh-pool.c: * vshStoragePoolSorter to sort the pool list by pool name. * struct vshStoragePoolList to present the pool list, pool info is collected by list-poolinfo if 'details' is specified by user. * vshStoragePoolListFree to free the pool list *

[libvirt] [PATCH 17/48] list: Implement virStoragePoolListAllVolumes for test driver

2012-08-03 Thread Osier Yang
src/test/test_driver.c: Implement poolListAllVolumes. --- src/test/test_driver.c | 67 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 18691ad..f7913aa 100644 ---

[libvirt] [PATCH 13/48] python: Expose virStorageListAllStoragePools to python binding

2012-08-03 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: Add listAllStoragePools python/libvirt-override.c: Implementation for the wrapper. ---

[libvirt] [PATCH 25/48] list: Use virConnectListAllNetworks in virsh

2012-08-03 Thread Osier Yang
tools/virsh-network.c: * vshNetworkSorter to sort networks by name * vshNetworkListFree to free the network objects list. * vshNetworkListCollect to collect the network objects, trying to use new API first, fall back to older APIs if it's not supported. * New options --persistent,

[libvirt] [PATCH 28/48] list: Implemente RPC calls for virConnectListAllInterfaces

2012-08-03 Thread Osier Yang
The RPC generator doesn't support returning list of object yet, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllInterfaces. * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllInterfaces. *

[libvirt] [PATCH 26/48] list: Expose virConnectListAllNetworks to Python binding

2012-08-03 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: Implement listAllNetworks. python/libvirt-override.c: Implementation for the wrapper. ---

[libvirt] [PATCH 29/48] list: Implement listAllInterfaces

2012-08-03 Thread Osier Yang
This is not that ideal as API for other objects, as it's still O(n). Because interface driver uses netcf APIs to manage the stuffs, instead of by itself. And netcf APIs don't return a object. It provides APIs like old libvirt APIs: ncf_number_of_interfaces ncf_list_interfaces

[libvirt] [PATCH 18/48] list: Use virStoragePoolListAllVolumes in virsh

2012-08-03 Thread Osier Yang
tools/virsh-volume.c: * vshStorageVolSorter to sort storage vols by name * vshStorageVolumeListFree to free the volume objects list * vshStorageVolumeListCollect to collect the volume objects, trying to use new API first, fall back to older APIs if it's not supported. ---

[libvirt] [PATCH 21/48] list: Implement RPC calls for virConnectListAllNetworks

2012-08-03 Thread Osier Yang
The RPC generator doesn't support returning list of object, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllNetworks. * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllNetworks. *

[libvirt] [PATCH 20/48] list: Define new API virConnectListAllNetworks

2012-08-03 Thread Osier Yang
This is to list the network objects, supported filtering flags are: active|inactive, persistent|transient, autostart|no-autostart. include/libvirt/libvirt.h.in: Declare enum virConnectListAllNetworkFlags and virConnectListAllNetworks. python/generator.py: Skip

[libvirt] [PATCH 23/48] list: Implement listAllNetworks for network driver

2012-08-03 Thread Osier Yang
src/network/bridge_driver.c: Implement listAllNetworks. --- src/network/bridge_driver.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index a5046f1..0b5cc85 100644 ---

[libvirt] [PATCH 35/48] list: Implement listAllNodeDevices

2012-08-03 Thread Osier Yang
This simply implements listAllNodeDevices using helper virNodeDeviceList src/node_device/node_device_driver.h: * Declare nodeListAllNodeDevices. src/node_device/node_device_driver.c: * Implement nodeListAllNodeDevices. src/node_device/node_device_hal.c: * Hook listAllNodeDevices to

[libvirt] [PATCH 33/48] list: Implemente RPC calls for virConnectListAllNodeDevices

2012-08-03 Thread Osier Yang
The RPC generator doesn't support returning list of object yet, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllNodeDevices. * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllNodeDevices.

[libvirt] [PATCH 31/48] list: Expose virConnectListAllInterfaces to Python binding

2012-08-03 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: * New file, includes implementation of listAllInterfaces. python/libvirt-override.c:

[libvirt] [PATCH 38/48] list: Use virConnectListAllNodeDevices in virsh

2012-08-03 Thread Osier Yang
tools/virsh-nodedev.c: * vshNodeDeviceSorter to sort node devices by name * vshNodeDeviceListFree to free the node device objects list. * vshNodeDeviceListCollect to collect the node device objects, trying to use new API first, fall back to older APIs if it's not supported. * Change

[libvirt] [PATCH 44/48] list: Define new API virConnectListAllSecrets

2012-08-03 Thread Osier Yang
This is to list the secret objects. No flags are supported include/libvirt/libvirt.h.in: Declare enum virConnectListAllSecretFlags and virConnectListAllSecrets. python/generator.py: Skip auto-generating src/driver.h: (virDrvConnectListAllSecrets) src/libvirt.c:

[libvirt] [PATCH 32/48] list: Define new API virConnectListAllNodeDevices

2012-08-03 Thread Osier Yang
This is to list the node device objects, supports to filter the results by capability types. include/libvirt/libvirt.h.in: Declare enum virConnectListAllNodeDeviceFlags and virConnectListAllNodeDevices. python/generator.py: Skip auto-generating src/driver.h:

[libvirt] [PATCH 36/48] list: Expose virConnectListAllNodeDevices to Python binding

2012-08-03 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: * Implementation for listAllNodeDevices. python/libvirt-override.c: Implementation for the

[libvirt] [PATCH 41/48] list: Implement listAllNWFilters

2012-08-03 Thread Osier Yang
Simply returns the object list. No filtering. src/nwfilter/nwfilter_driver.c: Implement listAllNWFilters --- src/nwfilter/nwfilter_driver.c | 56 1 files changed, 56 insertions(+), 0 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c

[libvirt] [PATCH 24/48] list: Implement listAllNetworks for test driver

2012-08-03 Thread Osier Yang
src/test/test_driver.c: Implement listAllNetworks. --- src/test/test_driver.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index f7913aa..7b4dd02 100644 --- a/src/test/test_driver.c +++

[libvirt] [PATCH 37/48] virsh: Fix a bug of nodedev-list

2012-08-03 Thread Osier Yang
output of commands like '%virsh nodedev-list --tree --cap pci' could be empty. Remove the useless checking. --- tools/virsh-nodedev.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index 5a0987d..6848925 100644 ---

  1   2   >