This is very short, becaquse almost everything is autogenerated. All
that's needed are:
* src/remote/remote_driver.c: add pointer to autogenerated
remoteNetworkDefineXMLFlags to the function table for the remote
network driver.
* src/remote/remote_protocol.x: add the args and ret structs
I would like to enhance libvirt's network API to allow enacting any
changes in definition immediately, as an alternative to the current
behavior of saving the changes right away, but not using them until
the next time the network is destroyed and re-started.
This could easily be handled by a flag
Currently there is no practical difference between this and using the
old virNetworkDefinXML API, it just allows using the new API to make
sure it's working.
Soon there will be a flag defined for the new function (to request
changes in re-definitions of existing+active networks take effect
We need to be able to pass a flag when (re)defining a network that
says to enact the changes immediately rather than waiting until the
next restart of the network, but the existing virNetworkDefineXML has
no flags arg.
This patch adds a new public API virNetworkDefineXMLFlags that will be
Just add an entry to the function table, rename the original
virNetworkDefineXML to virNetworkDefineXMLFlags (with a check for
flags == 0), and add a one line replacement for virNetworkDefineXML.
---
src/test/test_driver.c | 14 +-
1 file changed, 13 insertions(+), 1
Just add an entry to the function table, rename the original
virNetworkDefineXML to virNetworkDefineXMLFlags (with a check for
flags == 0), and add a one line replacement for virNetworkDefineXML
that calls virNetworkDefineXMLFlags.
---
src/network/bridge_driver.c | 14 +-
1 file
On 08/20/2012 02:10 AM, MATSUDA, Daiki wrote:
(2012/08/16 21:58), Martin Kletzander wrote:
On 08/15/2012 03:36 AM, MATSUDA Daiki wrote:
Add @seconds variable to qemuAgentSend().
When @tiemout is true, @seconds controls how long to wait for a
response
(if @seconds is
On 08/20/2012 02:16 AM, MATSUDA, Daiki wrote:
(2012/08/16 22:13), Martin Kletzander wrote:
On 08/15/2012 03:36 AM, MATSUDA Daiki wrote:
[...]
+char *
+virAgentCommand(virDomainPtr domain,
+const char *cmd,
+int timeout,
+unsigned int flags)
On 08/20/2012 02:20 AM, MATSUDA, Daiki wrote:
(2012/08/16 22:25), Martin Kletzander wrote:
On 08/15/2012 03:36 AM, MATSUDA Daiki wrote:
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 353a153..3c60709 100644
--- a/src/remote/remote_driver.c
+++
We move the macro vshStrcasecmp from tools/virsh.c to tools/virsh.h
after commit c2e494cc, so we should not check strcase* in the file
tools/virsh.h.
Some macros are not properly indented in the file tools/virsh.h
and tools/virsh-domain.h. This patch also fixes this problem.
---
cfg.mk
On 08/17/2012 03:33 PM, Viktor Mihajlovski wrote:
With qemu it is possible to override the geometry (cylinders, heads,
sectors) of disks.
This series adds a new XML tag for geometry and the related
support in the qemu driver.
V2 Changes:
Refactor into the generic domain configuration/XML
*** BLURB HERE ***
J.B. Joret (2):
Support for Disk Geometry Override
qemu: Disk Geometry Override Support
docs/formatdomain.html.in | 25 +++
docs/schemas/domaincommon.rng | 25 +++
src/conf/domain_conf.c
From: J.B. Joret j...@linux.vnet.ibm.com
A hypervisor may allow to override the disk geometry of drives.
Qemu, as an example with cyls=,heads=,secs=[,trans=].
This patch extends the domain config to allow the specification of
disk geometry with libvirt.
V2 Changes: Split out qemu specific code,
With qemu it is possible to override the geometry (cylinders, heads,
sectors) of disks.
This series adds a new XML tag for geometry and the related
support in the qemu driver.
V2 Changes:
Refactor into the generic domain configuration/XML support for disk
geometry and a qemu specific part with
From: J.B. Joret j...@linux.vnet.ibm.com
Qemu command line generation for geometry override and testcases.
V2 Changes: squashed qemu code and testcases.
V3 Changes: use virReportError.
V4 Changes: rebase
V5 Changes: Fixed test invocation for geometry.
Signed-off-by: J.B. Joret
On 08/20/12 10:11, Wen Congyang wrote:
in subject: s/syntak/syntax-check/
We move the macro vshStrcasecmp from tools/virsh.c to tools/virsh.h
s/move/moved/
after commit c2e494cc, so we should not check strcase* in the file
tools/virsh.h.
Some macros are not properly indented in the file
On Fri, Aug 17, 2012 at 11:25:37AM -0600, Eric Blake wrote:
On 08/16/2012 05:07 PM, Eric Blake wrote:
On 08/09/2012 09:20 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add two new APIs virLockSpaceNewPostExecRestart and
virLockSpacePreExecRestart which allow
On Fri, Aug 17, 2012 at 02:53:29PM +0200, Viktor Mihajlovski wrote:
This is an ad-hoc fix for the file label generation. It uses the base context
role to determine whether to use the libvirt process context role. If this
is object_r we don't touch it.
It might be better to add a new flag to
On Sun, Aug 19, 2012 at 11:42:43PM +0800, Guannan Ren wrote:
BZ RFE https://bugzilla.redhat.com/show_bug.cgi?id=795929
qemu support:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=6af165892cf900291046f1d25f95416f379504c2
Since qemu has have the code to support USB redirection filter. This
After delete duplicate remote_exec_pexect function, the left function
with same name causes some problem with cases, so update the function
and sync all cases using it.
Signed-off-by: Wayne Sun g...@redhat.com
---
repos/domain/cpu_topology.py|8 +++---
repos/domain/define.py |
On 2012年08月20日 14:17, Laine Stump wrote:
We need to be able to pass a flag when (re)defining a network that
says to enact the changes immediately rather than waiting until the
next restart of the network, but the existing virNetworkDefineXML has
no flags arg.
This patch adds a new public API
On 2012年08月20日 14:17, Laine Stump wrote:
This is very short, becaquse almost everything is autogenerated. All
that's needed are:
* src/remote/remote_driver.c: add pointer to autogenerated
remoteNetworkDefineXMLFlags to the function table for the remote
network driver.
*
On 2012年08月20日 14:17, Laine Stump wrote:
Just add an entry to the function table, rename the original
virNetworkDefineXML to virNetworkDefineXMLFlags (with a check for
flags == 0), and add a one line replacement for virNetworkDefineXML.
---
src/test/test_driver.c | 14
On 2012年08月20日 14:17, Laine Stump wrote:
Just add an entry to the function table, rename the original
virNetworkDefineXML to virNetworkDefineXMLFlags (with a check for
flags == 0), and add a one line replacement for virNetworkDefineXML
that calls virNetworkDefineXMLFlags.
---
On 2012年08月20日 14:17, Laine Stump wrote:
Currently there is no practical difference between this and using the
old virNetworkDefinXML API, it just allows using the new API to make
sure it's working.
Soon there will be a flag defined for the new function (to request
changes in re-definitions of
Messed up during send-email. Please ignore this one, I'll send out a
fresh set.
--
Mit freundlichen Grüßen/Kind Regards
Viktor Mihajlovski
IBM Deutschland Research Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft:
This is a fix for the object label generation. It uses a new flag for
virSecuritySELinuxGenNewContext that specifies whether the context is
for an object. If so the context role remains unchanged.
Without this fix it is not possible to start domains with image file or
block device backed storage
From: J.B. Joret j...@linux.vnet.ibm.com
Qemu command line generation for geometry override and testcases.
V2 Changes: squashed qemu code and testcases.
V3 Changes: use virReportError.
V4 Changes: rebase
V5 Changes: Fixed test invocation for geometry.
Signed-off-by: J.B. Joret
From: J.B. Joret j...@linux.vnet.ibm.com
A hypervisor may allow to override the disk geometry of drives.
Qemu, as an example with cyls=,heads=,secs=[,trans=].
This patch extends the domain config to allow the specification of
disk geometry with libvirt.
V2 Changes: Split out qemu specific code,
On Mon, Aug 20, 2012 at 01:52:16PM +0200, Viktor Mihajlovski wrote:
This is a fix for the object label generation. It uses a new flag for
virSecuritySELinuxGenNewContext that specifies whether the context is
for an object. If so the context role remains unchanged.
Without this fix it is not
With qemu it is possible to override the geometry (cylinders, heads,
sectors) of disks.
This series adds a new XML tag for geometry and the related
support in the qemu driver.
V2 Changes:
Refactor into the generic domain configuration/XML support for disk
geometry and a qemu specific part with
On Mon, Aug 20, 2012 at 01:58:24PM +0200, Viktor Mihajlovski wrote:
From: J.B. Joret j...@linux.vnet.ibm.com
A hypervisor may allow to override the disk geometry of drives.
Qemu, as an example with cyls=,heads=,secs=[,trans=].
This patch extends the domain config to allow the specification
On Mon, Aug 20, 2012 at 01:58:25PM +0200, Viktor Mihajlovski wrote:
From: J.B. Joret j...@linux.vnet.ibm.com
Qemu command line generation for geometry override and testcases.
V2 Changes: squashed qemu code and testcases.
V3 Changes: use virReportError.
V4 Changes: rebase
V5
On 08/20/2012 02:11 AM, Wen Congyang wrote:
We move the macro vshStrcasecmp from tools/virsh.c to tools/virsh.h
after commit c2e494cc, so we should not check strcase* in the file
tools/virsh.h.
Some macros are not properly indented in the file tools/virsh.h
and tools/virsh-domain.h. This
On 08/20/2012 12:17 AM, Laine Stump wrote:
We need to be able to pass a flag when (re)defining a network that
says to enact the changes immediately rather than waiting until the
next restart of the network, but the existing virNetworkDefineXML has
no flags arg.
This patch adds a new public
On Mon, Aug 20, 2012 at 06:46:58AM -0600, Eric Blake wrote:
On 08/20/2012 02:11 AM, Wen Congyang wrote:
We move the macro vshStrcasecmp from tools/virsh.c to tools/virsh.h
after commit c2e494cc, so we should not check strcase* in the file
tools/virsh.h.
Some macros are not properly
On 08/20/2012 12:17 AM, Laine Stump wrote:
Just add an entry to the function table, rename the original
virNetworkDefineXML to virNetworkDefineXMLFlags (with a check for
flags == 0), and add a one line replacement for virNetworkDefineXML
that calls virNetworkDefineXMLFlags.
---
On 08/20/2012 04:14 AM, Osier Yang wrote:
On 2012年08月19日 12:10, Eric Blake wrote:
Convert the exported items in virsh.h to use a common 'vsh' prefix.
ACK.
Thanks; pushed. More to come...
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library
From: Daniel P. Berrange berra...@redhat.com
Take advantage of the previously added monitor helpers to
create a test suite for the QEMU JSON monitor impl. As a
proof of concept, this tests the 'qemuMonitorGetStatus'
implementation
---
.gitignore | 1 +
tests/Makefile.am
This series adds support for some new QEMU JSON monitor commands
that will be used to replace -help parsing. It also adds a framework
for testing QEMU monitor command implementations
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: Daniel P. Berrange berra...@redhat.com
To be able to test the QEMU monitor code, we need to have a fake
QEMU monitor server. This introduces a simple (dumb) framework
that can do this. The test case registers a series of items to
be sent back as replies to commands that will be executed. A
From: Daniel P. Berrange berra...@redhat.com
Add some non-null annotations to qemuMonitorOpen and also
check that the error callback is set, since it is mandatory
---
src/qemu/qemu_monitor.c | 7 ++-
src/qemu/qemu_monitor.h | 3 ++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff
From: Daniel P. Berrange berra...@redhat.com
Add a new qemuMonitorGetMachines() method to support invocation
of the 'query-machines' JSON monitor command. No HMP equivalent
is required, since this will only be present for QEMU = 1.2
---
src/qemu/qemu_monitor.c | 30 +
From: Daniel P. Berrange berra...@redhat.com
Add a new qemuMonitorGetVersion() method to support invocation
of the 'query-version' JSON monitor command. No HMP equivalent
is provided, since this will only be used for QEMU = 1.2
---
src/qemu/qemu_monitor.c | 24 ++
From: J.B. Joret j...@linux.vnet.ibm.com
A hypervisor may allow to override the disk geometry of drives.
Qemu, as an example with cyls=,heads=,secs=[,trans=].
This patch extends the domain config to allow the specification of
disk geometry with libvirt.
V2 Changes: Split out qemu specific code,
From: J.B. Joret j...@linux.vnet.ibm.com
Qemu command line generation for geometry override and testcases.
V2 Changes: squashed qemu code and testcases.
V3 Changes: use virReportError.
V4 Changes: rebase
V5 Changes: Fixed test invocation for geometry.
V6 Changes: Remove conditional geometry
Another file worth compiling on its own instead of by .c inclusion.
* tools/virsh-domain-monitor.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh.h (vshGetDomainDescription): Move to correct
header.
* tools/virsh-domain-monitor.c: Use new header.
* tools/virsh.c:
On 08/20/2012 02:06 PM, Daniel P. Berrange wrote:
On Mon, Aug 20, 2012 at 01:58:25PM +0200, Viktor Mihajlovski wrote:
From: J.B. Joret j...@linux.vnet.ibm.com
Qemu command line generation for geometry override and testcases.
V2 Changes: squashed qemu code and testcases.
V3 Changes: use
With qemu it is possible to override the geometry (cylinders, heads,
sectors) of disks.
This series adds a new XML tag for geometry and the related
support in the qemu driver.
V2 Changes:
Refactor into the generic domain configuration/XML support for disk
geometry and a qemu specific part with
On 08/20/2012 07:49 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add some non-null annotations to qemuMonitorOpen and also
check that the error callback is set, since it is mandatory
---
src/qemu/qemu_monitor.c | 7 ++-
src/qemu/qemu_monitor.h | 3 ++-
2
On 08/20/2012 02:01 PM, Daniel P. Berrange wrote:
On Mon, Aug 20, 2012 at 01:52:16PM +0200, Viktor Mihajlovski wrote:
ACK
Daniel
there was make syntax-check error (trailing blank) which I missed :-(.
Resending the patch.
--
Mit freundlichen Grüßen/Kind Regards
Viktor Mihajlovski
On 08/20/2012 07:49 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
To be able to test the QEMU monitor code, we need to have a fake
QEMU monitor server. This introduces a simple (dumb) framework
that can do this. The test case registers a series of items to
be
This is a fix for the object label generation. It uses a new flag for
virSecuritySELinuxGenNewContext that specifies whether the context is
for an object. If so the context role remains unchanged.
Without this fix it is not possible to start domains with image file or
block device backed storage
On Mon, Aug 20, 2012 at 08:11:14AM -0600, Eric Blake wrote:
On 08/20/2012 07:49 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
To be able to test the QEMU monitor code, we need to have a fake
QEMU monitor server. This introduces a simple (dumb) framework
Nothing in the testsuite or examples directory should be translated,
as it is not part of the normally installed binary. We already
meet this rule, but enforcing it will make it easier to remember.
Suggested by Daniel P. Berrange.
* cfg.mk (sc_prohibit_useless_translation): Enhance rule.
---
On 08/20/2012 08:13 AM, Daniel P. Berrange wrote:
exclude_file_name_regexp--sc_libvirt_unmarked_diagnostics = \
- ^src/rpc/gendispatch\.pl$$
+ ^(src/rpc/gendispatch\.pl$$|tests/)
A rather heavy hammer for just one added test, but makes sense (tests
aren't installed, so translating them is
On 08/20/2012 06:46 AM, Osier Yang wrote:
On 2012年08月20日 14:17, Laine Stump wrote:
Currently there is no practical difference between this and using the
old virNetworkDefinXML API, it just allows using the new API to make
sure it's working.
Soon there will be a flag defined for the new
On Mon, Aug 20, 2012 at 08:30:07AM -0600, Eric Blake wrote:
Nothing in the testsuite or examples directory should be translated,
as it is not part of the normally installed binary. We already
meet this rule, but enforcing it will make it easier to remember.
Suggested by Daniel P. Berrange.
From: Daniel P. Berrange berra...@redhat.com
The _event_timeout_remove and _event_handle_remove methods
were holding onto the global lock when invoking the free
callback. This is a violation of the libvirt events API
contract which requires free callbacks to be invoked in
a re-entrant safe
On 08/20/2012 08:33 AM, Daniel P. Berrange wrote:
On Mon, Aug 20, 2012 at 08:30:07AM -0600, Eric Blake wrote:
Nothing in the testsuite or examples directory should be translated,
as it is not part of the normally installed binary. We already
meet this rule, but enforcing it will make it
On 08/13/2012 04:37 PM, Cole Robinson wrote:
libvirt 0.9.11.5 maintenance release is now available. This is
libvirt 0.9.11 with additional bugfixes that have accumulated
upstream since the initial release.
This release can be downloaded at:
The previous commit now trips up 'make syntax-check' due to a useless
use of signal.h.
* tools/virsh.c (includes): Drop useless includes.
---
Pushing under the build-breaker rule.
tools/virsh.c | 4
1 file changed, 4 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
On 08/20/2012 08:12 AM, Viktor Mihajlovski wrote:
This is a fix for the object label generation. It uses a new flag for
virSecuritySELinuxGenNewContext that specifies whether the context is
for an object. If so the context role remains unchanged.
Without this fix it is not possible to start
On 08/20/2012 07:49 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add a new qemuMonitorGetVersion() method to support invocation
of the 'query-version' JSON monitor command. No HMP equivalent
is provided, since this will only be used for QEMU = 1.2
---
On 08/20/2012 07:49 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add a new qemuMonitorGetMachines() method to support invocation
of the 'query-machines' JSON monitor command. No HMP equivalent
is required, since this will only be present for QEMU = 1.2
---
On Mon, Aug 20, 2012 at 10:29:39AM -0600, Eric Blake wrote:
On 08/20/2012 07:49 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add a new qemuMonitorGetVersion() method to support invocation
of the 'query-version' JSON monitor command. No HMP equivalent
is
On Mon, Aug 20, 2012 at 11:00:28AM -0600, Eric Blake wrote:
On 08/20/2012 10:57 AM, Daniel P. Berrange wrote:
+if (STRNEQ_NULLABLE(info[i]-alias, (wantalias))) { \
+virReportError(VIR_ERR_INTERNAL_ERROR, \
+
On Mon, Aug 20, 2012 at 10:54:47AM -0600, Eric Blake wrote:
On 08/20/2012 07:49 AM, Daniel P. Berrange wrote:
+++ b/tests/qemumonitorjsontest.c
@@ -224,6 +224,81 @@ cleanup:
}
static int
+testQemuMonitorJSONGetMachines(const void *data)
+{
+virCapsPtr caps =
On 08/20/2012 10:57 AM, Daniel P. Berrange wrote:
+if (STRNEQ_NULLABLE(info[i]-alias, (wantalias))) { \
+virReportError(VIR_ERR_INTERNAL_ERROR, \
+ alias %s is not %s,\
+
On 16.08.2012 00:10, Marcelo Cerri wrote:
This patch updates the structures that store information about each
domain and each hypervisor to support multiple security labels and
drivers. It also updates all the remaining code to use the new fields.
Signed-off-by: Marcelo Cerri
On 16.08.2012 00:10, Marcelo Cerri wrote:
This patch updates libvirt's API to allow applications to inspect the
full list of security labels of a domain.
Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com
---
daemon/remote.c | 63
On 16.08.2012 00:10, Marcelo Cerri wrote:
These changes make the security drivers able to find and handle the
correct security label information when more than one label is
available. They also update the DAC driver to be used as an usual
security driver.
Signed-off-by: Marcelo Cerri
On 16.08.2012 00:10, Marcelo Cerri wrote:
This patch updates the domain and capability XML parser and formatter to
support more than one seclabel element for each domain and device. The
RNG schema and the tests related to this are also updated by this patch.
Signed-off-by: Marcelo Cerri
On 16.08.2012 00:10, Marcelo Cerri wrote:
This patch updates the key security_driver in QEMU config to suport
both a sigle default driver or a list of default drivers. This ensures
that it will remain compatible with older versions of the config file.
Signed-off-by: Marcelo Cerri
On 16.08.2012 00:10, Marcelo Cerri wrote:
This patch updates the key security_driver in QEMU config to suport
both a sigle default driver or a list of default drivers. This ensures
that it will remain compatible with older versions of the config file.
Signed-off-by: Marcelo Cerri
On 16.08.2012 00:10, Marcelo Cerri wrote:
This is a v4 patch series that updates the libvirt's security driver
mechanism to support per-guest configurable user and group for QEMU processes
running together with other security drivers, such as SELinux and AppArmor.
Marcelo Cerri (5):
I am pleased to announce that a new release of the libvirt-glib package,
version 0.1.2, is now available from
ftp://libvirt.org/libvirt/glib/
The packages are GPG signed with
Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R)
New in this release:
- Add async
Resent of
http://www.redhat.com/archives/libvir-list/2012-August/msg01353.html.
Merging recent branch updates to this patch.
Ata E Husain Bohra (1):
Refactor ESX storage driver and add iSCSI support
src/Makefile.am | 16 +-
src/esx/esx_driver.c|4 +-
On 08/20/2012 11:00 AM, Eric Blake wrote:
On 08/20/2012 10:57 AM, Daniel P. Berrange wrote:
+CHECK(0, pc-1.0, false, null);
Can't you just s/null/NULL/ and avoid the intermediate variable?
I hit some GCC-wierdness when doing that:
CC qemumonitorjsontest-qemumonitorjsontest.o
Our existing STRNEQ_NULLABLE() triggered a warning in gcc 4.7 when
used with a literal NULL argument:
qemumonitorjsontest.c: In function 'testQemuMonitorJSONGetMachines':
qemumonitorjsontest.c:289:5: error: null argument where non-null required
(argument 1) [-Werror=nonnull]
even though the
The splits are getting easier, with fewer cleanups needed in virsh.h.
* tools/virsh-host.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh-host.c: Use new header.
* tools/virsh.c: Likewise.
---
tools/Makefile.am | 2 +-
tools/virsh-host.c | 16 +++-
Hi all,
Does anyone know if Libvirt supports shared memory devices such as IVSHMEM.
I know it didn't at one point but I didn't know if support for it had been
recently added.
Thanks,
Shawn
--
Virginia Tech
Bradley Department of Electrical and Computer Engineering
B.S. Electrical Engineering
In preparation for splitting virsh-interface.c, I found these
functions need to be declared in virsh.h, as well as one that
belongs more properly in virsh-domain.h.
* tools/virsh.h (vshNameSorter, vshCmdHasOption): Declare.
(vshCommandOptDomainBy): Move...
* tools/virsh-domain.h): ...here.
*
libguestfs recently added support for virtio-scsi and libvirt, and
when these are both available this lets us relatively easily add
hotplugging of drives. This email is about how we would present that
through the libguestfs API.
(a) The current API
Currently you have to add drive(s) via
In preparation for splitting virsh-interface.c, I found these
functions need to be declared in virsh.h, as well as one that
belongs more properly in virsh-domain.h. Also, since we
use the VSH_BY* flags in more than one function, I improved
how they are used.
* tools/virsh.h (vshNameSorter,
Another relatively easy split, since helper functions were fixed
in the previous patch.
* tools/virsh-interface.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh.c: Use new header.
* tools/virsh-interface.c: Likewise.
(vshCommandOptInterfaceBy): Check flags.
---
Another relatively easy file split.
* tools/virsh-network.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh.c: Use new header.
* tools/virsh-network.c: Likewise.
---
tools/Makefile.am | 2 +-
tools/virsh-network.c | 29 -
Another worthwhile split, needed one more public function.
* tools/virsh-nodedev.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh-nodedev.c: Use new header.
* tools/virsh.c: Likewise.
(vshTreePrint): Export.
* tools/virsh.h (vshTreePrint): Declare.
---
tools/Makefile.am
Another worthwhile split, needed one more public function.
* tools/virsh-nodedev.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh-nodedev.c: Use new header.
* tools/virsh.c: Likewise.
(vshTreePrint): Export.
* tools/virsh.h (vshTreePrint): Declare.
---
tools/Makefile.am
Yet another split file.
* tools/virsh-network.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh.c: Use new header.
* tools/virsh-nwfilter.c: Likewise.
---
tools/Makefile.am | 2 +-
tools/virsh-nwfilter.c | 31 +--
tools/virsh-nwfilter.h |
More in a series of file splits.
* tools/virsh-pool.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh.c: Use new header.
* tools/virsh-pool.c: Likewise.
---
tools/Makefile.am | 2 +-
tools/virsh-pool.c | 28 +++-
tools/virsh-pool.h | 42
One of the simpler splits.
* tools/virsh-secret.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh.c: Use new header.
* tools/virsh-secret.c: Likewise.
---
tools/Makefile.am| 2 +-
tools/virsh-secret.c | 17 -
tools/virsh-secret.h | 33
Almost done with the splits.
* tools/virsh-snapshot.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh.c: Use new header.
* tools/virsh-snapshot.c: Likewise.
---
tools/Makefile.am | 2 +-
tools/virsh-snapshot.c | 21 +++--
tools/virsh-snapshot.h | 33
Last of the file splits.
* tools/virsh-volume.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh.c: Use new header.
* tools/virsh-volume.c: Likewise.
---
tools/Makefile.am| 3 +--
tools/virsh-volume.c | 36 +---
tools/virsh-volume.h |
Just a quick heads-up (I'll fix it later, when I have more time): I just
learned commit 350583c85 broke builds on RHEL 5, because of the use of
AS_VERSION_COMPARE in configure.ac which was not available in older
autoconf 2.59.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt
On 08/20/2012 06:06 PM, Daniel P. Berrange wrote:
On Sun, Aug 19, 2012 at 11:42:43PM +0800, Guannan Ren wrote:
BZ RFE https://bugzilla.redhat.com/show_bug.cgi?id=795929
qemu support:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=6af165892cf900291046f1d25f95416f379504c2
Since qemu has have the
On 08/20/2012 04:13 PM, Eric Blake wrote:
The splits are getting easier, with fewer cleanups needed in virsh.h.
* tools/virsh-host.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh-host.c: Use new header.
* tools/virsh.c: Likewise.
---
tools/Makefile.am | 2 +-
On 08/20/2012 04:54 PM, Eric Blake wrote:
In preparation for splitting virsh-interface.c, I found these
functions need to be declared in virsh.h, as well as one that
belongs more properly in virsh-domain.h.
* tools/virsh.h (vshNameSorter, vshCmdHasOption): Declare.
On 08/20/2012 05:30 PM, Eric Blake wrote:
In preparation for splitting virsh-interface.c, I found these
functions need to be declared in virsh.h, as well as one that
belongs more properly in virsh-domain.h. Also, since we
use the VSH_BY* flags in more than one function, I improved
how they
On 08/20/2012 05:37 PM, Eric Blake wrote:
Another relatively easy split, since helper functions were fixed
in the previous patch.
* tools/virsh-interface.h: New file.
* tools/Makefile.am (virsh_SOURCES): Build it.
* tools/virsh.c: Use new header.
* tools/virsh-interface.c: Likewise.
1 - 100 of 108 matches
Mail list logo
