Re: [libvirt] [PATCHv4] add-vcpu-usage

2012-08-22 Thread Hu Tao
Hi Rich, The corresponding bugzilla item is 841759. Will you have a look at this patch? On Wed, May 09, 2012 at 04:48:29PM +0800, Hu Tao wrote: > show `vcpu usages' by `virt-top -1' > > Before this patch, `virt-top -1' shows total cpu usages > which euqal to `vcpu usages' + `hypervisor usages'.

Re: [libvirt] [PATCH] fix check of vcpuid in virDomainVcpuPinDefParseXML

2012-08-22 Thread Hu Tao
On Thu, Aug 23, 2012 at 02:12:32PM +0800, Daniel Veillard wrote: > On Thu, Aug 23, 2012 at 10:31:12AM +0800, Hu Tao wrote: > > For emulator, the vcpuid field is always set to -1, instead of parsing > > XML for the value of it. > > > > --- > > src/conf/domain_conf.c | 22 -- >

Re: [libvirt] [PATCH] fix check of vcpuid in virDomainVcpuPinDefParseXML

2012-08-22 Thread Daniel Veillard
On Thu, Aug 23, 2012 at 10:31:12AM +0800, Hu Tao wrote: > For emulator, the vcpuid field is always set to -1, instead of parsing > XML for the value of it. > > --- > src/conf/domain_conf.c | 22 -- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/src/con

[libvirt] [PATCH v4 2/7] add qemuAgentArbitraryCommand() for general qemu agent command. add qemuAgentArbitraryCommand() for general qemu agent command.

2012-08-22 Thread MATSUDA Daiki
Signed-off-by: MATSUDA Daiki --- src/qemu/qemu_agent.c | 30 ++ src/qemu/qemu_agent.h |5 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 61f070c..c658bf8 100644 --- a/src/qemu/qemu_agent.

[libvirt] [PATCH v4 7/7] add qemu-agent-command to virsh Add qemu-agent-command to virsh to support virDomainQemuAgentCommand().

2012-08-22 Thread MATSUDA Daiki
Signed-off-by: MATSUDA Daiki --- tools/virsh-host.c | 89 tools/virsh.pod| 13 +++ 2 files changed, 102 insertions(+), 0 deletions(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index b09d9f9..682d374 100644 --- a/tools/v

[libvirt] [PATCH v4 6/7] add python module support Add virDomainQemuAgentCommand() support function to python module.

2012-08-22 Thread MATSUDA Daiki
Signed-off-by: MATSUDA Daiki --- python/libvirt-qemu-override-api.xml |8 python/libvirt-qemu-override.c | 29 + 2 files changed, 37 insertions(+), 0 deletions(-) diff --git a/python/libvirt-qemu-override-api.xml b/python/libvirt-qemu-override-a

[libvirt] [PATCH v4 4/7] add qemu driver support Add qemuDrvDomainAgentCommand() for .qemuDomainArbitraryAgentCommand to qemu driver.

2012-08-22 Thread MATSUDA Daiki
Signed-off-by: MATSUDA Daiki --- src/qemu/qemu_driver.c | 71 1 files changed, 71 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 109d18d..a62d1bb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qe

[libvirt] [PATCH v4 1/7] Add @seconds variable to qemuAgentSend(). Add @seconds variable to qemuAgentSend(). When @tiemout is true, @seconds controls how long to wait for a response (if @seconds is VI

2012-08-22 Thread MATSUDA Daiki
Signed-off-by: MATSUDA Daiki --- include/libvirt/libvirt-qemu.h |7 +++ src/qemu/qemu_agent.c | 32 ++-- 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h index a37f897..

[libvirt] [PATCH v4 3/7] Add virDrvDomainQemuAgentCommand prototype for drivers. Add virDrvDomainQemuAgentCommand prototype for drivers. Add virDomainQemuAgentCommand() for virDrvDomainQemuAgentComman

2012-08-22 Thread MATSUDA Daiki
Signed-off-by: MATSUDA Daiki --- include/libvirt/libvirt-qemu.h |3 ++ python/generator.py|1 + src/driver.h |4 +++ src/libvirt-qemu.c | 54 src/libvirt_qemu.syms |5 +++ 5 files change

[libvirt] [PATCH v4 5/7] add remote driver support Add qemuDomainAgentCommand() which is generated automatically, for .qemuDomainArbitraryAgentCommand to remote driver.

2012-08-22 Thread MATSUDA Daiki
Signed-off-by: MATSUDA Daiki --- src/qemu_protocol-structs | 10 ++ src/remote/qemu_protocol.x | 14 +- src/remote/remote_driver.c |1 + 3 files changed, 24 insertions(+), 1 deletions(-) diff --git a/src/qemu_protocol-structs b/src/qemu_protocol-structs index 67968e

[libvirt] [PATCH v4 0/7] support guest agent general command

2012-08-22 Thread MATSUDA, Daiki
Hi. All. I rewrote the patched for git head tree, adding some code. And @timeout must be following VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK(-2) : does not block and wait forever. VIR_DOMAIN_QEMU_AGENT_COMMAND_DEFAULT(-1) : use default time for waiting VIR_DOMAIN_QEMU_AGENT_COMMAND_NOWIAT(0) : does not

Re: [libvirt] [PATCH] util: eliminate erroneous VIR_WARNs in (eb|ip)tables.c

2012-08-22 Thread Laine Stump
On 08/22/2012 05:18 PM, Eric Blake wrote: > On 08/22/2012 02:07 PM, Laine Stump wrote: >> Several VIR_DEBUG()'s were changed to VIR_WARN() while I was testing >> the firewalld support patch, and I neglected to change them back >> before I pushed. >> >> In the meantime I've decided that it would be

[libvirt] [PATCH] fix check of vcpuid in virDomainVcpuPinDefParseXML

2012-08-22 Thread Hu Tao
For emulator, the vcpuid field is always set to -1, instead of parsing XML for the value of it. --- src/conf/domain_conf.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7242205..419088c 100644 -

Re: [libvirt] [PATCH] Fix some typos in messages, docs and comments

2012-08-22 Thread Eric Blake
On 08/22/2012 12:32 PM, Yuri Chornoivan wrote: > > 0001-Fix-some-typos-in-messages-docs-and-comments.patch > > > From 18c3b2ada7fbc5c2ec7563a1e97f55e627b544f1 Mon Sep 17 00:00:00 2001 > From: Yuri Chornoivan > Date: Wed, 22 Aug 2012 21:29:18 +0300 > Subject: [PATCH] Fix some typos in messages,

Re: [libvirt] [PATCH] util: eliminate erroneous VIR_WARNs in (eb|ip)tables.c

2012-08-22 Thread Eric Blake
On 08/22/2012 02:07 PM, Laine Stump wrote: > Several VIR_DEBUG()'s were changed to VIR_WARN() while I was testing > the firewalld support patch, and I neglected to change them back > before I pushed. > > In the meantime I've decided that it would be useful to have them be > VIR_INFO(), just so the

Re: [libvirt] [PATCH] (updated) additional parameters needed for dnsmasq

2012-08-22 Thread Eric Blake
On 08/22/2012 01:36 PM, Gene Czarcinski wrote: >> Oh, and now that I've already pushed, I have a high-level question: what >> is the minimum version of 'dnsmasq' that supports the command-line >> syntax that this patch introduces? >> > I went back and checked some of the older versions of dnsmasq

[libvirt] [PATCH] util: eliminate erroneous VIR_WARNs in (eb|ip)tables.c

2012-08-22 Thread Laine Stump
Several VIR_DEBUG()'s were changed to VIR_WARN() while I was testing the firewalld support patch, and I neglected to change them back before I pushed. In the meantime I've decided that it would be useful to have them be VIR_INFO(), just so there will be logged evidence of which method is being use

Re: [libvirt] [PATCH] (updated) additional parameters needed for dnsmasq

2012-08-22 Thread Gene Czarcinski
On 08/22/2012 01:47 PM, Eric Blake wrote: On 08/22/2012 11:39 AM, Eric Blake wrote: On 08/22/2012 10:59 AM, Gene Czarcinski wrote: As I said in a previous message, dnsmasq is forwarding a number of queries upstream that should not be done. There still remains an MX query for a plain name with

[libvirt] [PATCH] Fix some typos in messages, docs and comments

2012-08-22 Thread Yuri Chornoivan
0001-Fix-some-typos-in-messages-docs-and-comments.patch Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH libvirt-virshcmdref] Add blockpull and blockjob commands

2012-08-22 Thread Eric Blake
On 08/22/2012 07:40 AM, Stefan Hajnoczi wrote: > The blockpull and blockjob commands have been present since 0.9.4. This > patch adds basic usage examples and command syntax. Thanks for tackling this. > > Signed-off-by: Stefan Hajnoczi > --- > common.sh|8 ++-- > source/blockj

[libvirt] [gluster]try to add gluster protocol in libvirt, but has qemuMonitorIO error

2012-08-22 Thread Yin Yin
Hi, all: after test the qemu gluster V5 patch: http://lists.nongnu.org/archive/html/qemu-devel/2012-08/msg01023.html I had write a patch in libvirt to support gluster protocol, but has qemuMonitorIO error: 2012-08-22 17:17:47.600+: 29121: error : qemuMonitorIORead:490 : Unable

Re: [libvirt] [PATCH] (updated) additional parameters needed for dnsmasq

2012-08-22 Thread Eric Blake
On 08/22/2012 11:39 AM, Eric Blake wrote: > On 08/22/2012 10:59 AM, Gene Czarcinski wrote: >> As I said in a previous message, dnsmasq is forwarding a number of >> queries upstream that should not be done. There still remains an MX >> query for a plain name with no domain specified that will be fo

Re: [libvirt] [PATCH] (updated) additional parameters needed for dnsmasq

2012-08-22 Thread Eric Blake
On 08/22/2012 10:59 AM, Gene Czarcinski wrote: > As I said in a previous message, dnsmasq is forwarding a number of > queries upstream that should not be done. There still remains an MX > query for a plain name with no domain specified that will be forwarded > is dnsmasq has --domain=xxx --local=

[libvirt] [PATCH] (updated) additional parameters needed for dnsmasq

2012-08-22 Thread Gene Czarcinski
As I said in a previous message, dnsmasq is forwarding a number of queries upstream that should not be done. There still remains an MX query for a plain name with no domain specified that will be forwarded is dnsmasq has --domain=xxx --local=/xxx/ specified. This does not happen with no domai

Re: [libvirt] [PATCH 0/5] add usb redirection filter support

2012-08-22 Thread Guannan Ren
On 08/19/2012 11:42 PM, Guannan Ren wrote: BZ RFE https://bugzilla.redhat.com/show_bug.cgi?id=795929 qemu support: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=6af165892cf900291046f1d25f95416f379504c2 Since qemu has have the code to support USB redirection filter. This set of patches try to su

Re: [libvirt] [PATCH] additional parameter needed for dnsmasq

2012-08-22 Thread Gene Czarcinski
On 08/22/2012 10:48 AM, Claudio Bley wrote: +virCommandAddArgFormat(cmd, > >>>+"--domain %s --local=/%s/", > >>>+network->def->domain, > >>>+network->def->domain); Here, you're adding "--domain D --local=/D/" as a*single* argument to the dnsma

Re: [libvirt] [PATCH] docs: fix blockpull/blockcopy bandwidth Mbps -> MiB/s

2012-08-22 Thread Michal Privoznik
On 22.08.2012 17:12, Eric Blake wrote: > On 08/22/2012 07:59 AM, Stefan Hajnoczi wrote: >> The bandwidth units for blockpull and blockcopy are in Megabytes per >> Second, not Megabits per Second. >> >> Signed-off-by: Stefan Hajnoczi >> --- >> src/libvirt.c | 10 +- >> tools/virsh.pod

Re: [libvirt] [PATCH v3 4/4] docs: Add pm element into documentation

2012-08-22 Thread Martin Kletzander
On 08/22/2012 05:08 PM, Eric Blake wrote: > On 08/22/2012 07:37 AM, Michal Privoznik wrote: >> On 09.08.2012 10:26, Martin Kletzander wrote: >>> --- >>> docs/formatdomain.html.in | 21 + >>> 1 files changed, 21 insertions(+), 0 deletions(-) >>> >>> diff --git a/docs/formatdom

Re: [libvirt] [PATCH v3 4/4] docs: Add pm element into documentation

2012-08-22 Thread Eric Blake
On 08/22/2012 07:37 AM, Michal Privoznik wrote: > On 09.08.2012 10:26, Martin Kletzander wrote: >> --- >> docs/formatdomain.html.in | 21 + >> 1 files changed, 21 insertions(+), 0 deletions(-) >> >> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in >> index f

Re: [libvirt] [PATCH] docs: fix blockpull/blockcopy bandwidth Mbps -> MiB/s

2012-08-22 Thread Eric Blake
On 08/22/2012 07:59 AM, Stefan Hajnoczi wrote: > The bandwidth units for blockpull and blockcopy are in Megabytes per > Second, not Megabits per Second. > > Signed-off-by: Stefan Hajnoczi > --- > src/libvirt.c | 10 +- > tools/virsh.pod |4 ++-- > 2 files changed, 7 insertions(+)

Re: [libvirt] [PATCH 0/4] Preparation for external live snapshot

2012-08-22 Thread Eric Blake
On 08/22/2012 07:46 AM, Michal Privoznik wrote: >> Although I'm still in the middle of polishing the src/qemu patches, >> I'd at least like to post this series of prep-work to document >> how I plan to expose it all, and to make sure my design >> decisions are on track. The first three can be appl

Re: [libvirt] [PATCH] additional parameter needed for dnsmasq

2012-08-22 Thread Claudio Bley
At Wed, 22 Aug 2012 10:23:44 -0400, Gene Czarcinski wrote: > Second, I have since the rpm will compile with my patch and goes > through enough of -bi --short-circuit to create > BUILDROOT/libvirt.../usr/sbin/libvirtd I am copying this over to a > real system and installing it replacing the original

Re: [libvirt] [PATCH] additional parameter needed for dnsmasq

2012-08-22 Thread Gene Czarcinski
On 08/22/2012 06:51 AM, Gene Czarcinski wrote: On 08/21/2012 11:04 AM, Daniel P. Berrange wrote: On Tue, Aug 21, 2012 at 10:43:44AM -0400, Gene Czarcinski wrote: RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=849787 As currently configured, dnsmasq for a virtual network will pass some queri

[libvirt] [PATCH] docs: fix blockpull/blockcopy bandwidth Mbps -> MiB/s

2012-08-22 Thread Stefan Hajnoczi
The bandwidth units for blockpull and blockcopy are in Megabytes per Second, not Megabits per Second. Signed-off-by: Stefan Hajnoczi --- src/libvirt.c | 10 +- tools/virsh.pod |4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c in

Re: [libvirt] [PATCH 0/4] Preparation for external live snapshot

2012-08-22 Thread Michal Privoznik
On 18.08.2012 04:08, Eric Blake wrote: > I've determined that it is possible to mix migration to file > with disk snapshots on existing qemu 1.1 in such a way to > take a live system checkpoint snapshot of a system without > the downtime of either 'virsh snapshot-create' or 'virsh save'; > without

Re: [libvirt] [PATCH libvirt-virshcmdref] Add blockpull and blockjob commands

2012-08-22 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 02:40:57PM +0100, Stefan Hajnoczi wrote: > The blockpull and blockjob commands have been present since 0.9.4. This > patch adds basic usage examples and command syntax. > > Signed-off-by: Stefan Hajnoczi > --- > common.sh|8 ++-- > source/blockjob.xml |

[libvirt] [PATCH libvirt-virshcmdref] Add blockpull and blockjob commands

2012-08-22 Thread Stefan Hajnoczi
The blockpull and blockjob commands have been present since 0.9.4. This patch adds basic usage examples and command syntax. Signed-off-by: Stefan Hajnoczi --- common.sh|8 ++-- source/blockjob.xml | 79 +++ source/blockpull.xml | 101 +

Re: [libvirt] [PATCH v3 4/4] docs: Add pm element into documentation

2012-08-22 Thread Michal Privoznik
On 09.08.2012 10:26, Martin Kletzander wrote: > --- > docs/formatdomain.html.in | 21 + > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > index f97c630..50c4783 100644 > --- a/docs/formatdomain.html.i

Re: [libvirt] [PATCH v3 3/4] tests: Add tests for qemu S3/S4 state configuration

2012-08-22 Thread Michal Privoznik
On 09.08.2012 10:26, Martin Kletzander wrote: > Few tests were added which are checking whether the parsing of the xml > and command-line arguments is working and compatible with each other. > --- > tests/qemuargv2xmltest.c |3 ++ > .../qemuxml2argv-misc-disable-s3.ar

Re: [libvirt] [PATCH v3 2/4] qemu: Add support for S3/S4 state configuration

2012-08-22 Thread Michal Privoznik
On 09.08.2012 10:26, Martin Kletzander wrote: > This patch adds support for running qemu guests with the required > parameters to forcefully enable or disable BIOS advertising of S3 and > S4 states. The support for this is added to capabilities and there is > also a qemu command parameter parsing

Re: [libvirt] [PATCH v3 1/4] Add per-guest S3/S4 state configuration

2012-08-22 Thread Michal Privoznik
On 09.08.2012 10:26, Martin Kletzander wrote: > There is a new element implemented that can control what ACPI > sleeping states will be advertised by BIOS and allowed to be switched > to by libvirt. The default keeps defaults on hypervisor, otherwise > forces chosen setting. > --- > docs/schemas/

[libvirt] Entering freeze for libvirt-0.10.0

2012-08-22 Thread Daniel Veillard
As planned, I just tagged 0.10.0 release candidate 1 in git and pushed a tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ I gave it a try locally and things seems to work as expected, but that's far from an extensive testing :-) So please try it, try to compile it on variou

Re: [libvirt] [PATCH] output status information during guest shutdown again

2012-08-22 Thread Gerd v. Egidy
Hi Eric, > Beyond that, you met my comments on v1, and I didn't spot anything else, so: > > ACK and pushed. Thanks. > > This is version 2 of the patch and includes fixes as suggested by Eric > > Blake. > This last sentence can go... > > > --- > > after the ---, so that git doesn't store it in

Re: [libvirt] [PATCH] additional parameter needed for dnsmasq

2012-08-22 Thread Gene Czarcinski
On 08/21/2012 11:04 AM, Daniel P. Berrange wrote: On Tue, Aug 21, 2012 at 10:43:44AM -0400, Gene Czarcinski wrote: RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=849787 As currently configured, dnsmasq for a virtual network will pass some queries upstream toward the Internet. This includes

Re: [libvirt] [PATCH v2.1 21/21] qemu: support of emulator_period and emulator_quota's modification

2012-08-22 Thread Daniel Veillard
On Wed, Aug 22, 2012 at 05:19:32PM +0800, Hu Tao wrote: > On Wed, Aug 22, 2012 at 05:04:57PM +0800, Daniel Veillard wrote: > > On Tue, Aug 21, 2012 at 05:18:44PM +0800, Hu Tao wrote: [...] > > Okay, we now have 5 parameters instead of 3. that looks fine, ACK, > > > > the question I have is if

Re: [libvirt] [PATCH V3 3/3] Add uevent netlink service.

2012-08-22 Thread Daniel Veillard
On Wed, Aug 22, 2012 at 12:10:25PM +0800, Tang Chen wrote: > This patch adds a new netlink service with NETLINK_KOBJECT_UEVENT > protocol hotplug event. > > Signed-off-by: Tang Chen > --- > daemon/libvirtd.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/daemon/libvirtd.c b/d

Re: [libvirt] [PATCH V3 1/3] Improve netlink to support all protocol.

2012-08-22 Thread Daniel Veillard
On Wed, Aug 22, 2012 at 12:10:23PM +0800, Tang Chen wrote: > This patch improve all the API in virnetlink.c to support > all kinds of netlink protocols, and make all netlink sockets > be able to join in groups. > > Signed-off-by: Tang Chen > --- > daemon/libvirtd.c|6 +- > sr

Re: [libvirt] [PATCH V3 2/3] Introduce virNetlinkEventServiceStopAll() to stop all netlink services.

2012-08-22 Thread Daniel Veillard
On Wed, Aug 22, 2012 at 12:10:24PM +0800, Tang Chen wrote: > This patch introduce virNetlinkEventServiceStopAll() to stop > all the monitors to receive netlink messages for libvirtd. > > Signed-off-by: Tang Chen > --- > daemon/libvirtd.c|2 +- > src/libvirt_private.syms |1 + > s

Re: [libvirt] [PATCH 2/2] client: Change default location of known_hosts file for libssh2 layer

2012-08-22 Thread Peter Krempa
On 08/21/12 19:23, Eric Blake wrote: On 08/21/2012 10:48 AM, Peter Krempa wrote: Unfortunately libssh2 doesn't support all types of host keys that can be saved in the known_hosts file. Also it does not report that parsing of the file failed. This results into truncated known_hosts files where th

Re: [libvirt] [PATCH] virsh: don't print error info when snapshot xml is not changed

2012-08-22 Thread Guannan Ren
On 08/22/2012 05:43 PM, Michal Privoznik wrote: On 21.08.2012 22:54, Guannan Ren wrote: If xml is not changed, error message is printed. So check ret value instead of edit variable for error message. --- tools/virsh-snapshot.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

Re: [libvirt] [PATCH] virsh: don't print error info when snapshot xml is not changed

2012-08-22 Thread Michal Privoznik
On 21.08.2012 22:54, Guannan Ren wrote: > If xml is not changed, error message is printed. > So check ret value instead of edit variable for error message. > --- > tools/virsh-snapshot.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/virsh-snapshot.c b/too

Re: [libvirt] [PATCH v2.1 00/21] Supports for emulator-pin and emulator-bandwidth

2012-08-22 Thread Hu Tao
On Wed, Aug 22, 2012 at 05:06:03PM +0800, Daniel Veillard wrote: > On Wed, Aug 22, 2012 at 03:55:48PM +0800, Daniel Veillard wrote: > > On Tue, Aug 21, 2012 at 05:18:23PM +0800, Hu Tao wrote: > > > This series adds support of emulator-pin to pin emulator threads on > > > specified physical CPUs, an

Re: [libvirt] [PATCH v2.1 21/21] qemu: support of emulator_period and emulator_quota's modification

2012-08-22 Thread Hu Tao
On Wed, Aug 22, 2012 at 05:04:57PM +0800, Daniel Veillard wrote: > On Tue, Aug 21, 2012 at 05:18:44PM +0800, Hu Tao wrote: > > From: Wen Congyang > > > > allow the user change/get emulator's period and quota when the vm is > > running. > > --- > > src/qemu/qemu_driver.c | 133 > >

Re: [libvirt] [PATCH v2.1 00/21] Supports for emulator-pin and emulator-bandwidth

2012-08-22 Thread Daniel Veillard
On Wed, Aug 22, 2012 at 03:55:48PM +0800, Daniel Veillard wrote: > On Tue, Aug 21, 2012 at 05:18:23PM +0800, Hu Tao wrote: > > This series adds support of emulator-pin to pin emulator threads on > > specified physical CPUs, and emulator-bandwidth to control physical > > CPU bandwidth for emulator t

Re: [libvirt] [PATCH v2.1 21/21] qemu: support of emulator_period and emulator_quota's modification

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:44PM +0800, Hu Tao wrote: > From: Wen Congyang > > allow the user change/get emulator's period and quota when the vm is running. > --- > src/qemu/qemu_driver.c | 133 > +++- > 1 file changed, 132 insertions(+), 1 deletio

Re: [libvirt] [PATCH v2.1 20/21] new interface to control emulator_period/emulator_quota

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:43PM +0800, Hu Tao wrote: > This patch adds two macros: VIR_DOMAIN_SCHEDULER_EMULATOR_PERIOD, > VIR_DOMAIN_SCHEDULER_EMULATOR_QUOTA for controlling cpu bandwidth > for emulator activities not tied to vcpus > --- > include/libvirt/libvirt.h.in | 24 ++

Re: [libvirt] [PATCH v2.1 19/21] qemu: introduce period/quota tuning for emulator

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:42PM +0800, Hu Tao wrote: > This patch introduces support of setting emulator's period and > quota to limit cpu bandwidth when the vm starts. Also updates > XML Schema for new entries and docs. > --- > docs/formatdomain.html.in | 24 >

Re: [libvirt] [PATCH v2.1 18/21] limit cpu bandwidth only for vcpus

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:41PM +0800, Hu Tao wrote: > This patch changes the behaviour of xml element cputune.period > and cputune.quota to limit cpu bandwidth only for vcpus, and no > longer limit cpu bandwidth for the whole guest. > > The reasons to do this are: > > - This matches docs of

[libvirt] [PATCH] virsh: don't print error info when snapshot xml is not changed

2012-08-22 Thread Guannan Ren
If xml is not changed, error message is printed. So check ret value instead of edit variable for error message. --- tools/virsh-snapshot.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index aff91d3..5d84f7a 100644 ---

Re: [libvirt] [PATCH v2.1 17/21] new command emulatorpin

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:40PM +0800, Hu Tao wrote: > --- > tools/virsh-domain.c | 188 > ++ > tools/virsh.pod | 16 + > 2 files changed, 204 insertions(+) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index 047d374

Re: [libvirt] [PATCH v2.1 16/21] Add a new function vshPrintPinInfo.

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:39PM +0800, Hu Tao wrote: > This is a helper function to print vcpu pin info. > --- > tools/virsh-domain.c | 65 > -- > 1 file changed, 42 insertions(+), 23 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/

Re: [libvirt] [PATCHv6 2/2] qemu: Disk Geometry Override Support

2012-08-22 Thread Viktor Mihajlovski
On 08/21/2012 11:36 PM, Eric Blake wrote: Pushed with this squashed in: diff --git i/src/qemu/qemu_command.c w/src/qemu/qemu_command.c index cdc8e55..ca62f0c 100644 --- i/src/qemu/qemu_command.c +++ w/src/qemu/qemu_command.c @@ -2281,7 +2281,7 @@ qemuBuildDriveStr(virConnectPtr conn ATTRIBUTE_UN

Re: [libvirt] [PATCH v2.1 15/21] remote: introduce emulator pinning RPCs

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:38PM +0800, Hu Tao wrote: > From: Tang Chen > > Introduce 2 APIs to support emulator threads in remote driver. > 1) remoteDomainPinEmulator: call driver api, such as > qemudDomainPinEmulator. > 2) remoteDomainGetEmulatorPinInfo: call driver api, such as > q

Re: [libvirt] [PATCH v2.1 14/21] qemu: support emulator pinning

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:37PM +0800, Hu Tao wrote: > Introduce 2 APIs to support emulator threads pin in qemu driver. > > 1) qemudDomainPinEmulator: setup emulator threads pin info. > 2) qemudDomainGetEmulatorPinInfo: get all emulator threads pin info. > > They are similar to qemudDo

Re: [libvirt] [PATCH v2.1 12/21] Introduce virDomainPinEmulator and virDomainGetEmulatorPinInfo functions.

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:35PM +0800, Hu Tao wrote: > From: Tang Chen > > Introduce 2 APIs to set/get physical cpu pinning info of emulator threads. > > Signed-off-by: Tang Chen > Signed-off-by: Hu Tao > --- > include/libvirt/libvirt.h.in | 10 +++ > src/driver.h | 12

Re: [libvirt] [PATCH v2.1 13/21] Introduce virDomainEmulatorPinAdd and virDomainEmulatorPinDel functions

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:36PM +0800, Hu Tao wrote: > From: Tang Chen > > Introduce 2 APIs to support emulator threads pin. > 1) virDomainEmulatorPinAdd: setup emulator threads pin with a given > cpumap string. > 2) virDomainEmulatorPinDel: remove all emulator threads pin. > > Signe

Re: [libvirt] [PATCH v2.1 11/21] Add qemuProcessSetEmulatorAffinites and set emulator threads affinities

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:34PM +0800, Hu Tao wrote: > From: Tang Chen > > Emulator threads should also be pinned by sched_setaffinity(), just > the same as vcpu threads. > > Signed-off-by: Tang Chen > Signed-off-by: Hu Tao > --- > src/qemu/qemu_process.c | 54 >

Re: [libvirt] [PATCH v2.1 10/21] qemu: synchronize emulatorpin info to cgroup

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:33PM +0800, Hu Tao wrote: > From: Tang Chen > > Introduce qemuSetupCgroupEmulatorPin() function to add emulator > threads pin info to cpuset cgroup, the same as vcpupin. > > Signed-off-by: Tang Chen > Signed-off-by: Hu Tao > --- > src/qemu/qemu_cgroup.c | 51 >

Re: [libvirt] [PATCH] atomic: mark header functions static

2012-08-22 Thread Daniel P. Berrange
On Tue, Aug 21, 2012 at 01:55:33PM -0600, Eric Blake wrote: > When gcc atomic intrinsics are not available (such as on RHEL 5 > with gcc 4.1.2), we were getting link errors due to multiple > definitions: > > ./.libs/libvirt_util.a(libvirt_util_la-virobject.o): In function > `virAtomicIntXor': > /

Re: [libvirt] [PATCH v2.1 00/21] Supports for emulator-pin and emulator-bandwidth

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:23PM +0800, Hu Tao wrote: > This series adds support of emulator-pin to pin emulator threads on > specified physical CPUs, and emulator-bandwidth to control physical > CPU bandwidth for emulator threads. > > changes: > > v2.1: > - rebase > - include emulator-band

Re: [libvirt] [PATCH v2.1 09/21] Support emulatorpin xml parse.

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:32PM +0800, Hu Tao wrote: > From: Tang Chen > > This patch adds a new xml element , which is a sibling > to the existing element under the , to pin emulator > threads to specified physical CPUs. > > Signed-off-by: Tang Chen > Signed-off-by: Hu Tao > --- > docs/f

Re: [libvirt] [PATCH v2.1 08/21] Change virDomainVcpuPinDefParseXML to support parsing emulatorpin

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:44:10PM +0100, Daniel P. Berrange wrote: > On Tue, Aug 21, 2012 at 05:18:31PM +0800, Hu Tao wrote: > > --- > > src/conf/domain_conf.c | 22 +++--- > > 1 file changed, 15 insertions(+), 7 deletions(-) > > > > diff --git a/src/conf/domain_conf.c b/src/co

Re: [libvirt] [PATCH v2.1 05/21] refactor virDomainVcpuPinAdd()

2012-08-22 Thread Daniel Veillard
On Tue, Aug 21, 2012 at 05:18:28PM +0800, Hu Tao wrote: > --- > src/conf/domain_conf.c | 81 > ++ > src/conf/domain_conf.h |3 +- > src/libxl/libxl_driver.c | 13 +++- > src/qemu/qemu_driver.c | 26 +-- > src/xen/xend_int