[libvirt] [PATCH] nwfilter: don't log error if firewalld is disabled

2012-08-24 Thread Laine Stump
The original patch to support firewalld in nwfilter wasn't personally checking the exit status of firewall-cmd, but was instead sending NULL in the *exitstatus arg, which meant that virCommandWait would log an error just for the exit status being non-0 (and a more scary than useful error at that).

[libvirt] [PATCH] openvz: check the exitstatus of vzlist

2012-08-24 Thread Laine Stump
I noticed this while auditing all calls to virCommandRun that request an exit status from virCommandRun. Two functions in the openvz driver openvzDomainGetBarrierLimit openvzDomainSetBarrierLimit request an exit status from virCommandRun (thus assuring that virCommandRun won't log any errors

Re: [libvirt] [RFC PATCH v1 0/2] Qemu/Gluster support in Libvirt

2012-08-24 Thread Daniel Veillard
On Thu, Aug 23, 2012 at 04:31:50PM +0530, Harsh Prateek Bora wrote: This patchset provides support for Gluster protocol based network disks. It is based on the proposed gluster support in Qemu on qemu-devel: http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01539.html Just to be clear,

[libvirt] [PATCHv2] nwfilter: don't log error if firewalld is disabled, improve diagnostics

2012-08-24 Thread Laine Stump
The original patch to support firewalld in nwfilter wasn't personally checking the exit status of firewall-cmd, but was instead sending NULL in the *exitstatus arg, which meant that virCommandWait would log an error just for the exit status being non-0 (and a more scary than useful error at that).

Re: [libvirt] [RFC PATCH v1 0/2] Qemu/Gluster support in Libvirt

2012-08-24 Thread Harsh Bora
On 08/24/2012 12:05 PM, Daniel Veillard wrote: On Thu, Aug 23, 2012 at 04:31:50PM +0530, Harsh Prateek Bora wrote: This patchset provides support for Gluster protocol based network disks. It is based on the proposed gluster support in Qemu on qemu-devel:

Re: [libvirt] [PATCHv2 1/3] snapshot: make virDomainSnapshotObjList opaque

2012-08-24 Thread Daniel Veillard
On Thu, Aug 23, 2012 at 02:54:14PM -0600, Eric Blake wrote: We were failing to react to allocation failure when initializing a snapshot object list. Changing things to store a pointer instead of a complete object adds one more possible point of allocation failure, but at the same time, will

Re: [libvirt] [PATCHv2 2/3] snapshot: split snapshot conf code into own file

2012-08-24 Thread Daniel Veillard
On Thu, Aug 23, 2012 at 02:54:15PM -0600, Eric Blake wrote: This has several benefits: 1. Future snapshot-related code has a definite place to go (and I _will_ be adding some) 2. Snapshot errors now use the VIR_FROM_DOMAIN_SNAPSHOT error classification, which has been underutilized

Re: [libvirt] [PATCHv2 3/3] snapshot: rename an enum

2012-08-24 Thread Daniel Veillard
On Thu, Aug 23, 2012 at 02:54:16PM -0600, Eric Blake wrote: The name 'virDomainDiskSnapshot' didn't fit in with our normal conventions of using a prefix hinting that it is related to a virDomainSnapshotPtr. Also, a future patch will reuse the enum for declaring where the VM memory is stored.

Re: [libvirt] [PATCHv2] nwfilter: don't log error if firewalld is disabled, improve diagnostics

2012-08-24 Thread Daniel Veillard
On Fri, Aug 24, 2012 at 02:39:48AM -0400, Laine Stump wrote: The original patch to support firewalld in nwfilter wasn't personally checking the exit status of firewall-cmd, but was instead sending NULL in the *exitstatus arg, which meant that virCommandWait would log an error just for the exit

Re: [libvirt] [PATCH] openvz: check the exitstatus of vzlist

2012-08-24 Thread Daniel Veillard
On Fri, Aug 24, 2012 at 02:07:15AM -0400, Laine Stump wrote: I noticed this while auditing all calls to virCommandRun that request an exit status from virCommandRun. Two functions in the openvz driver openvzDomainGetBarrierLimit openvzDomainSetBarrierLimit request an exit status from

Re: [libvirt] [PATCHv2] nwfilter: don't log error if firewalld is disabled, improve diagnostics

2012-08-24 Thread Laine Stump
On 08/24/2012 03:02 AM, Daniel Veillard wrote: On Fri, Aug 24, 2012 at 02:39:48AM -0400, Laine Stump wrote: The original patch to support firewalld in nwfilter wasn't personally checking the exit status of firewall-cmd, but was instead sending NULL in the *exitstatus arg, which meant that

Re: [libvirt] [PATCH] openvz: check the exitstatus of vzlist

2012-08-24 Thread Laine Stump
On 08/24/2012 03:03 AM, Daniel Veillard wrote: On Fri, Aug 24, 2012 at 02:07:15AM -0400, Laine Stump wrote: I noticed this while auditing all calls to virCommandRun that request an exit status from virCommandRun. Two functions in the openvz driver openvzDomainGetBarrierLimit

Re: [libvirt] [RFC PATCH v1 0/2] Qemu/Gluster support in Libvirt

2012-08-24 Thread Deepak C Shetty
On 08/24/2012 12:22 PM, Harsh Bora wrote: On 08/24/2012 12:05 PM, Daniel Veillard wrote: On Thu, Aug 23, 2012 at 04:31:50PM +0530, Harsh Prateek Bora wrote: This patchset provides support for Gluster protocol based network disks. It is based on the proposed gluster support in Qemu on

[libvirt] Libvirt 0.10.0-rc1 segfaults when daemon run as root

2012-08-24 Thread Shawn Furrow
Hi all, For some reason when I run libvirtd -d as root it seems to not start. I investigate by running libvirtd -v as root and I get a segfault. Here is the output: 2012-08-23 19:01:23.237+: 27464: info : libvirt version: 0.10.0 2012-08-23 19:01:23.237+: 27464: error :

[libvirt] [PATCH 1/2] virsh: Improve checking for connection when running commands

2012-08-24 Thread Peter Krempa
Almost each virsh command uses the function vshConnectionUsability before doing anything, to check if the connection is alive. Commands that don't need an conection are already conveniently marked with VSH_CMD_FLAG_NOCONNECT. We can automaticaly check for the connection before calling any remote

[libvirt] [PATCH 0/2] virsh: Check for connection usability before each command

2012-08-24 Thread Peter Krempa
Some commands in virsh forgot to do this check before executing remote commands and printed unexpected error messages. This series moves the connection check to a central point so that these mistakes don't happen. Also it's a nice cleanup :). Peter Krempa (2): virsh: Improve checking for

Re: [libvirt] [PATCH 0/2] virsh: Check for connection usability before each command

2012-08-24 Thread Martin Kletzander
On 08/24/2012 02:42 PM, Peter Krempa wrote: Some commands in virsh forgot to do this check before executing remote commands and printed unexpected error messages. This series moves the connection check to a central point so that these mistakes don't happen. Also it's a nice cleanup :).

[libvirt] [PATCH 1/2] security: Add DAC to security_drivers

2012-08-24 Thread Michal Privoznik
Currently, if users set 'security_driver=dac' in qemu.conf libvirtd fails to initialize as DAC driver is not found because it is missing in our security drivers array. --- src/security/security_driver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH 2/2] conf: Don't always require security/@model

2012-08-24 Thread Michal Privoznik
Only parse model, if static labelling, or a base label is set, or doing active XML. --- src/conf/domain_conf.c | 39 --- 1 files changed, 24 insertions(+), 15 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 419088c..0f7bf78

[libvirt] [PATCH] libssh2_transport: Add docs to remote.html

2012-08-24 Thread Peter Krempa
Describe the existence of the transport driver and document the configurable options. --- docs/remote.html.in | 52 +++- 1 file changed, 47 insertions(+), 5 deletions(-) diff --git a/docs/remote.html.in b/docs/remote.html.in index e6af4c2..40696b9

Re: [libvirt] [PATCH 1/2] security: Add DAC to security_drivers

2012-08-24 Thread Eric Blake
On 08/24/2012 07:15 AM, Michal Privoznik wrote: Currently, if users set 'security_driver=dac' in qemu.conf libvirtd fails to initialize as DAC driver is not found because it is missing in our security drivers array. --- src/security/security_driver.c |2 ++ 1 files changed, 2

Re: [libvirt] [PATCH 2/2] conf: Don't always require security/@model

2012-08-24 Thread Eric Blake
On 08/24/2012 07:15 AM, Michal Privoznik wrote: Only parse model, if static labelling, or a base label is set, or doing active XML. --- src/conf/domain_conf.c | 39 --- 1 files changed, 24 insertions(+), 15 deletions(-) I can confirm that this solves a

Re: [libvirt] [PATCH] libssh2_transport: Add docs to remote.html

2012-08-24 Thread Eric Blake
On 08/24/2012 07:51 AM, Peter Krempa wrote: Describe the existence of the transport driver and document the configurable options. --- docs/remote.html.in | 52 +++- 1 file changed, 47 insertions(+), 5 deletions(-) ACK. -- Eric Blake

Re: [libvirt] How to solve this problem---libvirtError: this function is not supported by the connection driver: virNWFilterDefineXML

2012-08-24 Thread Eric Blake
On 08/23/2012 07:39 PM, Zhihong Wang wrote: Dear all: I am trying to deploy openstack on xen hypervisor.Since XenSever or XCP is not available on our customized virtulization platform. We decide to use libvirt on xen as a middleware operating the xen hypervisor. But when I try to boot a

Re: [libvirt] [PATCH] libssh2_transport: Add docs to remote.html

2012-08-24 Thread Peter Krempa
On 08/24/12 16:09, Eric Blake wrote: On 08/24/2012 07:51 AM, Peter Krempa wrote: Describe the existence of the transport driver and document the configurable options. --- docs/remote.html.in | 52 +++- 1 file changed, 47 insertions(+), 5

Re: [libvirt] Entering freeze for libvirt-0.10.0

2012-08-24 Thread Viktor Mihajlovski
On 08/22/2012 01:51 PM, Daniel Veillard wrote: As planned, I just tagged 0.10.0 release candidate 1 in git and pushed a tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ I gave it a try locally and things seems to work as expected, but that's far from an extensive

[libvirt] [PATCH] xen-xs: fix uuid of renamed domain

2012-08-24 Thread Philipp Hahn
When the XenStore tdb lives persistently and is not cleared between host reboots, Xend (version 3.4 and 4.1) re-creates the domain information located in XenStore below /vm/$UUID. (According to the xen-3.2-commit hg265950e3df69 to fix a problem when locally migrating a domain to the host itself.)

Re: [libvirt] Entering freeze for libvirt-0.10.0

2012-08-24 Thread Eric Blake
On 08/24/2012 08:28 AM, Viktor Mihajlovski wrote: fwiw ... with the current GIT level I get the following build error on Ubuntu 10.04 32-bit CC libvirt_util_la-virnetdev.lo cc1: warnings being treated as errors /usr/include/netlink/object.h:58: error: inline function 'nl_object_priv'

Re: [libvirt] [PATCH 2/2] conf: Don't always require security/@model

2012-08-24 Thread Michal Privoznik
On 24.08.2012 16:07, Eric Blake wrote: On 08/24/2012 07:15 AM, Michal Privoznik wrote: Only parse model, if static labelling, or a base label is set, or doing active XML. --- src/conf/domain_conf.c | 39 --- 1 files changed, 24 insertions(+), 15

Re: [libvirt] Entering freeze for libvirt-0.10.0

2012-08-24 Thread Laine Stump
On 08/24/2012 10:28 AM, Viktor Mihajlovski wrote: fwiw ... with the current GIT level I get the following build error on Ubuntu 10.04 32-bit CC libvirt_util_la-virnetdev.lo cc1: warnings being treated as errors /usr/include/netlink/object.h:58: error: inline function 'nl_object_priv'

Re: [libvirt] [PATCHv2 3/3] snapshot: rename an enum

2012-08-24 Thread Eric Blake
On 08/24/2012 01:00 AM, Daniel Veillard wrote: On Thu, Aug 23, 2012 at 02:54:16PM -0600, Eric Blake wrote: The name 'virDomainDiskSnapshot' didn't fit in with our normal conventions of using a prefix hinting that it is related to a virDomainSnapshotPtr. Also, a future patch will reuse the

Re: [libvirt] [PATCH] xen-xs: fix uuid of renamed domain

2012-08-24 Thread Eric Blake
On 08/24/2012 06:58 AM, Philipp Hahn wrote: When the XenStore tdb lives persistently and is not cleared between host reboots, Xend (version 3.4 and 4.1) re-creates the domain information located in XenStore below /vm/$UUID. (According to the xen-3.2-commit hg265950e3df69 to fix a problem when

Re: [libvirt] [PATCHv2 2/3] snapshot: split snapshot conf code into own file

2012-08-24 Thread Eric Blake
On 08/24/2012 12:58 AM, Daniel Veillard wrote: On Thu, Aug 23, 2012 at 02:54:15PM -0600, Eric Blake wrote: This has several benefits: 1. Future snapshot-related code has a definite place to go (and I _will_ be adding some) 2. Snapshot errors now use the VIR_FROM_DOMAIN_SNAPSHOT error

Re: [libvirt] [PATCHv2 3/3] snapshot: rename an enum

2012-08-24 Thread Daniel Veillard
On Fri, Aug 24, 2012 at 09:49:38AM -0600, Eric Blake wrote: On 08/24/2012 01:00 AM, Daniel Veillard wrote: On Thu, Aug 23, 2012 at 02:54:16PM -0600, Eric Blake wrote: The name 'virDomainDiskSnapshot' didn't fit in with our normal conventions of using a prefix hinting that it is related to a

Re: [libvirt] Entering freeze for libvirt-0.10.0

2012-08-24 Thread Thomas Graf
On Fri, Aug 24, 2012 at 11:30:44AM -0400, Laine Stump wrote: On 08/24/2012 10:28 AM, Viktor Mihajlovski wrote: fwiw ... with the current GIT level I get the following build error on Ubuntu 10.04 32-bit CC libvirt_util_la-virnetdev.lo cc1: warnings being treated as errors

Re: [libvirt] Entering freeze for libvirt-0.10.0

2012-08-24 Thread Eric Blake
On 08/24/2012 09:49 AM, Thomas Graf wrote: It's a static inline which I guess is the problem here. Laine, you Actually, Viktor hit the problem; Laine couldn't reproduce, so it is probably Viktor with the older header. are probably using a libnl version which does not include the commit below.

Re: [libvirt] [PATCHv2 3/3] snapshot: rename an enum

2012-08-24 Thread Eric Blake
On 08/24/2012 09:57 AM, Daniel Veillard wrote: ACK, the only annoyance is that the name being longuer the simple substitution leads to lines over 80 characters, I would be a proponent of dropping the indentation to the opening ( for the sake of keeping everything on one 80 char line

Re: [libvirt] Entering freeze for libvirt-0.10.0

2012-08-24 Thread Laine Stump
On 08/24/2012 11:49 AM, Thomas Graf wrote: On Fri, Aug 24, 2012 at 11:30:44AM -0400, Laine Stump wrote: On 08/24/2012 10:28 AM, Viktor Mihajlovski wrote: fwiw ... with the current GIT level I get the following build error on Ubuntu 10.04 32-bit CC libvirt_util_la-virnetdev.lo cc1:

Re: [libvirt] Entering freeze for libvirt-0.10.0

2012-08-24 Thread Eric Blake
On 08/24/2012 01:54 PM, Laine Stump wrote: Thomas, do you have any info on the libnl version used in Ubuntu 10.04, and/or what might be the cause of this warning. It's a static inline which I guess is the problem here. Laine, you are probably using a libnl version which does not include the

[libvirt] switching both libvirt and netcf packages to use libnl3 instead of libnl-1.1

2012-08-24 Thread Laine Stump
Both libvirt and the netcf library it links to use libnl for doing things with netlink sockets. libnl comes in a couple of different and API-incompatible flavors, namely libnl-1.1 and libnl-3. For a long time Fedora had just libnl-1.1, and libvirt only supported libnl-1.1 Awhile back Fedora

Re: [libvirt] Entering freeze for libvirt-0.10.0

2012-08-24 Thread Laine Stump
On 08/24/2012 04:02 PM, Eric Blake wrote: On 08/24/2012 01:54 PM, Laine Stump wrote: Thomas, do you have any info on the libnl version used in Ubuntu 10.04, and/or what might be the cause of this warning. It's a static inline which I guess is the problem here. Laine, you are probably using a

[libvirt] [PATCH] specfile: require libnl3 for Fedora = 18 and RHEL = 7

2012-08-24 Thread Laine Stump
Everything is ready in both netcf and libvirt to switch over to libnl3 in future releases of both Fedora and RHEL. This needs to be done more or less simultaneously in both packages, though, because you can't mix libnl1.1 and libnl3 in the same process (e.g. libvirtd using libnl-3.so and

Re: [libvirt] [PATCH] specfile: require libnl3 for Fedora = 18 and RHEL = 7

2012-08-24 Thread Eric Blake
On 08/24/2012 03:57 PM, Laine Stump wrote: Everything is ready in both netcf and libvirt to switch over to libnl3 in future releases of both Fedora and RHEL. This needs to be done more or less simultaneously in both packages, though, because you can't mix libnl1.1 and libnl3 in the same