On Tue, Aug 28, 2012 at 01:38:32PM +0800, liguang wrote:
Signed-off-by: liguang lig.f...@cn.fujitsu.com
Please provide a full description of what this patch is supposed
to be doing and why you've implemented it this way. I struggle
to understand what on earth this patch is doing with the streams
On 08/27/2012 11:20 PM, Daniel P. Berrange wrote:
On Tue, Aug 28, 2012 at 01:38:32PM +0800, liguang wrote:
Signed-off-by: liguang lig.f...@cn.fujitsu.com
Please provide a full description of what this patch is supposed
to be doing and why you've implemented it this way. I struggle
to
Actually, I've sent some description before,
by now, as I know, in a condition when a domain only defined,
but not active(so called offline migration),some one may
require the domain to be active at another remote server, not the local,
libvirt can't do it.
so, I try to construct a kludge to
On Mon, Aug 27, 2012 at 11:32:11AM -0500, Doug Goldstein wrote:
On Mon, Aug 27, 2012 at 4:57 AM, Justin Clift jcl...@redhat.com wrote:
On 27/08/2012, at 1:00 PM, Daniel Veillard wrote:
I tagged the rc2 in the git tree and pushed tarball and rpms to
the usual place:
Thanks Eric! After reading the code of virCommandRun and
virExecWithHook, I know there is no problem of passing arguments.
On 08/28/2012 12:06, Eric Blake wrote:
On 08/27/2012 08:05 PM, Zhou Zheng Sheng wrote:
When passing kernel command line arguments, it is possible to have
spaces. The
On 08/27/12 16:37, Martin Kletzander wrote:
There was a request for clarifying this part of the
documentation. This also fixes a case used with CPU.
---
docs/formatdomain.html.in | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.html.in
I will be rebasing this remaining patch series this week.
Many Thanks,
Regards,
Shradha Shah
On 08/21/2012 11:34 PM, Eric Blake wrote:
On 08/10/2012 10:24 AM, Shradha Shah wrote:
This patch introduces the new interface type='hostdev-hybrid' along with
attribute managed
Includes updates to
Fedora uses gawk as awk so there's no change and in behavior while
Debian/Ubuntu use mawk by default.
This was reported by Luca Capello in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636712
---
src/nwfilter/nwfilter_ebiptables_driver.c | 12 ++--
1 file changed, 6 insertions(+), 6
On 08/27/12 23:09, Eric Blake wrote:
On 08/24/2012 10:19 AM, Eric Blake wrote:
Ah, that rings a bell, I knew I'd seen this issue before. I'm actually
surprised it STILL hasn't been fixed in Ubuntu, and maybe it's time to
apply the workaround below as a build-breaker fix (I think I've posted
在 2012-08-27一的 23:38 -0700，Eric Blake写道：
On 08/27/2012 11:20 PM, Daniel P. Berrange wrote:
On Tue, Aug 28, 2012 at 01:38:32PM +0800, liguang wrote:
Signed-off-by: liguang lig.f...@cn.fujitsu.com
Please provide a full description of what this patch is supposed
to be doing and why you've
On 08/28/2012 10:32 AM, Peter Krempa wrote:
On 08/27/12 16:37, Martin Kletzander wrote:
There was a request for clarifying this part of the
documentation. This also fixes a case used with CPU.
---
docs/formatdomain.html.in | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
Previous commit 0b4b53bb80 defined 'inline' to prevent broken build on
systems with libnl1 headers. However, it broke build on systems with
libnl3 headers. Therefore we must make that fix conditional.
---
Pushed under build breaker rule.
src/util/virnetlink.h |8 ++--
1 files changed, 6
* src/util/virnetdevopenvswitch.c (virNetDevOpenvswitchAddPort): avoid libvirtd
crash due to derefing a NULL virtVlan-tag.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=852383
Signed-off-by: Alex Jia a...@redhat.com
---
src/util/virnetdevopenvswitch.c |3 ++-
1 files changed, 2
* src/conf/domain_conf.c: Use STREQ_NULLABLE instead of STREQ,
as def-seclables[i]-model could be NULL.
---
I guess this doesn't fix the root cause (perhaps on XML parsing),
but this fix is sufficient anyway.
---
src/conf/domain_conf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
On 28/08/2012, at 6:05 PM, Daniel Veillard wrote:
snip
I would suggest a fix along those lines:
Daniel
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 19dd26b..352d4fe 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -1312,17 +1312,21 @@ int main(int argc, char **argv)
On 27.08.2012 16:14, Marcelo Cerri wrote:
Hi,
I was notified that the latest patches for libvirt DAC isolation is
causing some regression issues. I'm working on fixes for it but I have
some doubts of how I should handle some scenarios. I'd appreciate some
suggestions:
* Item 3.2: this is
To silence error if DBus support is not compiled in.
---
src/nwfilter/nwfilter_driver.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c
index ae09960..a30026e 100644
--- a/src/nwfilter/nwfilter_driver.c
+++
On 08/27/2012 06:36 PM, Wayne Sun wrote:
After delete duplicate remote_exec_pexect function, the left function
with same name causes some problem with cases, so update the function
and sync all cases using it.
Signed-off-by: Wayne Sun g...@redhat.com
---
repos/domain/cpu_topology.py |2 +-
On 08/28/2012 03:10 AM, Michal Privoznik wrote:
Previous commit 0b4b53bb80 defined 'inline' to prevent broken build on
systems with libnl1 headers. However, it broke build on systems with
libnl3 headers. Therefore we must make that fix conditional.
---
Pushed under build breaker rule.
On 08/28/2012 04:28 AM, Alex Jia wrote:
* src/util/virnetdevopenvswitch.c (virNetDevOpenvswitchAddPort): avoid
libvirtd
crash due to derefing a NULL virtVlan-tag.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=852383
Signed-off-by: Alex Jia a...@redhat.com
---
On 08/28/2012 04:47 AM, Osier Yang wrote:
* src/conf/domain_conf.c: Use STREQ_NULLABLE instead of STREQ,
as def-seclables[i]-model could be NULL.
---
ACK.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description:
On 08/28/2012 02:21 AM, liguang wrote:
src: begin - pass the xml to dst (unchanged for offline)
dst: prepare - get ready to accept incoming VM (online starts a new qemu
but, how can dst knows the prepared migration is offline or not at src?
By the cookie that was passed in from src from the
On 08/28/2012 01:57 AM, Guido Günther wrote:
Fedora uses gawk as awk so there's no change and in behavior while
Debian/Ubuntu use mawk by default.
This was reported by Luca Capello in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636712
---
src/nwfilter/nwfilter_ebiptables_driver.c |
These APIs accept one more argument (flags), which was ignored in
the XS implementations.
---
Virt.xs | 46 ++
1 files changed, 26 insertions(+), 20 deletions(-)
diff --git a/Virt.xs b/Virt.xs
index 2b8d74c..100ca43 100644
--- a/Virt.xs
+++ b/Virt.xs
On 2012年08月28日 23:25, Eric Blake wrote:
On 08/28/2012 04:47 AM, Osier Yang wrote:
* src/conf/domain_conf.c: Use STREQ_NULLABLE instead of STREQ,
as def-seclables[i]-model could be NULL.
---
ACK.
Thanks, pushed.
--
libvir-list mailing list
libvir-list@redhat.com
To make sure the domain config is not broken after the API calls.
---
This depends on
https://www.redhat.com/archives/libvir-list/2012-August/msg01792.html
---
scripts/domain/202-numa-set-parameters.t | 99 ++
1 files changed, 99 insertions(+), 0 deletions(-)
To keep the internal data structure consistent.
---
src/qemu/qemu_driver.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index d74bf52..955744a 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@
On 2012年08月29日 00:00, Osier Yang wrote:
To keep the internal data structure consistent.
I should mention this is v3, v2 is here:
https://www.redhat.com/archives/libvir-list/2012-July/msg01680.html
---
src/qemu/qemu_driver.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
On 08/27/2012 01:39 PM, Gautam Sampathkumar wrote:
Hi All,
I've been trying to upgrade our version of libvirt-java to 0.4.8
since we're now running libvirt 0.10.0 and are running into the following
dependency problems on our Centos 6.2 machine.
libvirt-java requires libvirt-client
On Tue, Aug 28, 2012 at 4:19 AM, Peter Krempa pkre...@redhat.com wrote:
On 08/27/12 23:09, Eric Blake wrote:
On 08/24/2012 10:19 AM, Eric Blake wrote:
Ah, that rings a bell, I knew I'd seen this issue before. I'm actually
surprised it STILL hasn't been fixed in Ubuntu, and maybe it's time to
When using the DAC security driver with security_default_confined = 0
the daemon segfaulted. After fixing that problem guests could not be started
because the driver had a logic bug that used uninitialized values while
setting hypervisor uid and gid.
This is probably a regression and I would
When no DAC label was requested for a domain the DAC manager tried to
strdup a NULL string causing a segfault.
---
src/security/security_dac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 925498f..4162e26
getpwuid_r returns success but sets the return structure to NULL when it
fails to deliver data about the requested uid. In our helper code this
created following strange error messages:
... cannot getpwuid_r(1234): Success
This patch creates a more helpful message:
... getpwuid_r failed to
When starting a machine the DAC security driver tries to set the UID and
GID of the newly spawned process. This worked as desired if the desired
label was set. When the label was missing a logical bug in
virSecurityDACGenLabel() caused that uninitialised values were used as
uid and gid for the new
On 08/28/2012 09:00 AM, Osier Yang wrote:
To keep the internal data structure consistent.
---
src/qemu/qemu_driver.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
On 08/28/2012 09:51 AM, Peter Krempa wrote:
When no DAC label was requested for a domain the DAC manager tried to
strdup a NULL string causing a segfault.
---
src/security/security_dac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/security/security_dac.c
On 08/28/2012 09:51 AM, Peter Krempa wrote:
When using the DAC security driver with security_default_confined = 0
the daemon segfaulted. After fixing that problem guests could not be started
because the driver had a logic bug that used uninitialized values while
setting hypervisor uid and
Without this patch, logged command executions can be ambiguous if
the command contained any shell metacharacters. This has caused
more than one person to attempt to patch clients to add unnecessary
quoting, without realizing that the command itself was run with
correct args, and only the logged
Hi All,
I built libvirt on centos 6.2 and the configure and make steps went
through successfully. I did try a make rpm which fails with the error: cp:
cannot stat `./404.html': No such file or directory.
Doesnt looks like any RPMs were generated. I tried to manually create
404.html in the
On 08/28/2012 02:22 PM, Gautam Sampathkumar wrote:
Hi All,
I built libvirt on centos 6.2 and the configure and make steps went
Which version? libvirt.git, or an earlier tarball?
through successfully. I did try a make rpm which fails with the error: cp:
cannot stat `./404.html': No
Hi Eric,
I was using the libvirt-0.10.0 tarball. I installed xslt proc and
ran make and make rpm again. Looks like some of the other errors went away
(missing html file) but make rpm still comes to a halt with missing
404.html.
--Gautam
On Tue, Aug 28, 2012 at 2:30 PM, Eric Blake
Sorry forgot to add. I'm getting a whole bunch of these types of errors
Generating formatnetwork.html.tmp
missing XHTML1 DTD
--Gautam
On Tue, Aug 28, 2012 at 2:43 PM, Gautam Sampathkumar
gsampathku...@gmail.com wrote:
Hi Eric,
I was using the libvirt-0.10.0 tarball. I installed
On 08/28/2012 02:43 PM, Gautam Sampathkumar wrote:
Hi Eric,
Please don't top-post.
I was using the libvirt-0.10.0 tarball.
0.10.0 hasn't been released yet (only the 0.10.0-rc1 and 0.10.0-rc2
release candidates).
I installed xslt proc and
ran make and make rpm again. Looks like
On 08/28/2012 02:44 PM, Gautam Sampathkumar wrote:
Sorry forgot to add. I'm getting a whole bunch of these types of errors
Generating formatnetwork.html.tmp
missing XHTML1 DTD
Again, without top-posting, this one is solved by:
BuildRequires: xhtml1-dtds
--
Eric Blake ebl...@redhat.com
On 08/28/12 19:24, Eric Blake wrote:
On 08/28/2012 09:51 AM, Peter Krempa wrote:
When using the DAC security driver with security_default_confined = 0
the daemon segfaulted. After fixing that problem guests could not be started
because the driver had a logic bug that used uninitialized values
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On Tue, Aug 28, 2012 at 04:05:36PM +0800, Daniel Veillard thus spake:
I don't like too much the idea of adding kernel defines in our headers.
Basically this is all due to commits
d57567940153147f4d43875fb92c3030b3178b03 and
On Mon, Aug 27, 2012 at 11:32:11AM -0500, Doug Goldstein thus spake:
On Mon, Aug 27, 2012 at 4:57 AM, Justin Clift jcl...@redhat.com wrote:
On 27/08/2012, at 1:00 PM, Daniel Veillard wrote:
I tagged the rc2 in the git tree and pushed tarball and rpms to
the usual place:
As in the previous commit also images are chowned to uninitialised
values if the label is not present.
---
As this fix is identical to already ACKed 3/3, I'm pushing this as trivial.
---
src/security/security_dac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Aug 28, 2012 at 10:01:27AM -0700, Jason Helfman wrote:
On Tue, Aug 28, 2012 at 04:05:36PM +0800, Daniel Veillard thus spake:
I don't like too much the idea of adding kernel defines in our headers.
Basically this is all due to commits
d57567940153147f4d43875fb92c3030b3178b03 and
On 2012年08月29日 00:55, Eric Blake wrote:
On 08/28/2012 09:00 AM, Osier Yang wrote:
To keep the internal data structure consistent.
---
src/qemu/qemu_driver.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
ACK.
Thanks, pushed.
--
libvir-list mailing list
On Tue, Aug 28, 2012 at 03:19:31PM +0200, Peter Krempa wrote:
To silence error if DBus support is not compiled in.
---
src/nwfilter/nwfilter_driver.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c
On Tue, Aug 28, 2012 at 11:16:13AM -0700, Eric Blake wrote:
Without this patch, logged command executions can be ambiguous if
the command contained any shell metacharacters. This has caused
more than one person to attempt to patch clients to add unnecessary
quoting, without realizing that the
Thanks for review, I will update it based on your advise, in addition, the
commit message is very common,
so also change it to util: Prevent libvirtd crash from
virNetDevOpenvswitchAddPort(), push now.
--
Regards,
Alex
- Original Message -
From: Eric Blake ebl...@redhat.com
To:
On 08/28/2012 11:11 AM, Wayne Sun wrote:
create_netfs_pool:
In rhel7 the source nfs mount dir shows in /proc/mounts will end with a
'/' which in rhel6 and rhel5 didn't. So the check with exact match will
fail on rhel7. Change with '/*' will accept with both '/' exist or not.
not part of the commit
Really just looking for feedback if this an acceptable update to the previous
work. My plan is to add a 'udev' backend that will provide just some basic
read-only host interface information. Basically I've been seeing postings to
libvirt-users and virt-tools where people
As planned, I tagged the release this morning and pushed the builds
at the usual place:
ftp://libvirt.org/libvirt/
This is a huge release, with close to 550 commits, which is normal
considering the time since the 0.9.13 release, close to two month instead
of one. I think it's better to go
ACK.
--
Regards,
Alex
- Original Message -
From: Osier Yang jy...@redhat.com
To: libvir-list@redhat.com
Sent: Tuesday, August 28, 2012 11:52:24 PM
Subject: [libvirt] [libvirt-perl PATCH] Fix several APIs
These APIs accept one more argument (flags), which was ignored in
the XS
57 matches
Mail list logo
