[libvirt] [PATCH] docs: Fix typo in CPU tuning

2012-08-31 Thread Jiri Denemark
--- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index be8489a..bb842f9 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -385,7 +385,7 @@ lt;vcpupin vcpu=1

[libvirt] [PATCH] qemu: Don't ignore CPU tuning config if required cgroups are missing

2012-08-31 Thread Jiri Denemark
--- src/qemu/qemu_cgroup.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index df67ff3..7298e28 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -546,16 +546,21 @@ int

[libvirt] [PATCH] virsh: Document subdriver option of attach-disk

2012-08-31 Thread Jiri Denemark
--- tools/virsh.pod | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index cad5b1c..a26c420 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1675,9 +1675,15 @@ Isource is path for the files and devices. Itarget controls the

Re: [libvirt] Heads up 0.10.1 release on Friday

2012-08-31 Thread Daniel Veillard
On Thu, Aug 30, 2012 at 08:44:57PM +0200, Guido Günther wrote: On Wed, Aug 29, 2012 at 11:19:42PM +0800, Daniel Veillard wrote: I was a bit afraid of the .0 effect on release name, but we really have a number of problem with 0.10.0 that ought to be fixed in a brown paper bag release. I

Re: [libvirt] [PATCH] docs: Fix typo in CPU tuning

2012-08-31 Thread Peter Krempa
On 08/31/12 08:22, Jiri Denemark wrote: --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This would definitely qualify as trivial. ACK Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] docs: Fix typo in CPU tuning

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 08:22:57AM +0200, Jiri Denemark wrote: --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index be8489a..bb842f9 100644 --- a/docs/formatdomain.html.in +++

Re: [libvirt] [PATCH] virsh: Document subdriver option of attach-disk

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 08:23:30AM +0200, Jiri Denemark wrote: --- tools/virsh.pod | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index cad5b1c..a26c420 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1675,9

Re: [libvirt] [PATCH] qemu: Don't ignore CPU tuning config if required cgroups are missing

2012-08-31 Thread Daniel Veillard
A bit of context would be nice On Fri, Aug 31, 2012 at 08:23:15AM +0200, Jiri Denemark wrote: --- src/qemu/qemu_cgroup.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index

[libvirt] [PATCH 0/2] WIP: additional fixes to the security driver

2012-08-31 Thread Jiri Denemark
Hi, these patches are a work in progress and apply on top of the two recent patches from Marcelo. Jiri Denemark (2): Fix seclabels parsing Format seclabels in a compatible way src/conf/domain_conf.c | 41 + 1 file changed, 25 insertions(+), 16

[libvirt] [PATCH 1/2] Fix seclabels parsing

2012-08-31 Thread Jiri Denemark
--- src/conf/domain_conf.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3819ed9..1394297 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3161,27 +3161,36 @@

[libvirt] [PATCH 2/2] Format seclabels in a compatible way

2012-08-31 Thread Jiri Denemark
--- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1394297..49327df 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11253,7 +11253,7 @@ virSecurityLabelDefFormat(virBufferPtr

[libvirt] [PATCH] doc: Fix emulator pinning example in formatdomain.html

2012-08-31 Thread Peter Krempa
Add correct closing tags. --- Pushing under trivial rule. --- docs/formatdomain.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index be8489a..fbdf36b 100644 --- a/docs/formatdomain.html.in +++

[libvirt] [PATCH][TCK] add script to test storage and vol get commands

2012-08-31 Thread Kyla Zhang
including pool-get_uuid pool-get_name pool-refresh pool-get_volume_by_name vol-get_name vol-get_key vol-get_path vol-get_info vmm-get_storage_pool_by_uuid --- scripts/storage/120-get-ops.t | 116 + 1 files changed, 116 insertions(+), 0 deletions(-) create

Re: [libvirt] [PATCH] docs: Fix typo in CPU tuning

2012-08-31 Thread Peter Krempa
On 08/31/12 08:41, Peter Krempa wrote: On 08/31/12 08:22, Jiri Denemark wrote: --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This would definitely qualify as trivial. ACK I pushed this patch along with another docs fix. Peter -- libvir-list mailing

[libvirt] RFC: APIs to manage KSM

2012-08-31 Thread Osier Yang
Triggered by the requirement to control the new sys knob /sys/kernel/mm/ksm/merge_nodes for a NUMA aware host by patch: http://permalink.gmane.org/gmane.linux.kernel.mm/81497 It shows there is no methods to manage the KSM in libvirt. This proposes the new APIs like following, thanks for

[libvirt] [PATCH 2/3] cgroup: fix a typo on extracting data from vcpu cgroup

2012-08-31 Thread Guannan Ren
--- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5670ca0..5081b52 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13460,7 +13460,7 @@ getSumVcpuPercpuStats(virCgroupPtr group,

[libvirt] [PATCH 3/3] cgroup: fix libvirtd crash caused by messed memory

2012-08-31 Thread Guannan Ren
The variable max_id is initialized again in the step of getting cpu mapping variable map2. But in the next for loop we still expect original value of max_id, the bug will crash libvirtd when using on NUMA machine with big number of cpus. --- src/qemu/qemu_driver.c | 11 +++ 1 file

[libvirt] [PATCH 1/3] cgroup: read more data from cgroup cpuacct.usage_percpu

2012-08-31 Thread Guannan Ren
On NUMA machine, the length of string got from file cpuacct.usage_percpu is quite large, so expand the limit of 1024 bytes. errors like: Failed to read file \ '/cgroup/cpuacct/libvirt/qemu/rhel6q/cpuacct.usage_percpu': \ Value too large for defined data type --- src/util/cgroup.c | 2 +- 1 file

Re: [libvirt] [PATCH 2/3] cgroup: fix a typo on extracting data from vcpu cgroup

2012-08-31 Thread Osier Yang
On 2012年08月31日 17:22, Guannan Ren wrote: --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5670ca0..5081b52 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13460,7 +13460,7

Re: [libvirt] [PATCH 3/3] cgroup: fix libvirtd crash caused by messed memory

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 05:22:59PM +0800, Guannan Ren wrote: The variable max_id is initialized again in the step of getting cpu mapping variable map2. But in the next for loop we still expect original value of max_id, the bug will crash libvirtd when using on NUMA machine with big number of

Re: [libvirt] [PATCH 1/3] cgroup: read more data from cgroup cpuacct.usage_percpu

2012-08-31 Thread Osier Yang
On 2012年08月31日 17:22, Guannan Ren wrote: On NUMA machine, the length of string got from file cpuacct.usage_percpu is quite large, so expand the limit of 1024 bytes. errors like: Failed to read file \ '/cgroup/cpuacct/libvirt/qemu/rhel6q/cpuacct.usage_percpu': \ Value too large for defined data

Re: [libvirt] [PATCH V3] implement offline migration

2012-08-31 Thread liguang
在 2012-08-27一的 23:38 -0700,Eric Blake写道: On 08/27/2012 11:20 PM, Daniel P. Berrange wrote: On Tue, Aug 28, 2012 at 01:38:32PM +0800, liguang wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com Please provide a full description of what this patch is supposed to be doing and why you've

Re: [libvirt] [PATCH 1/3] cgroup: read more data from cgroup cpuacct.usage_percpu

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 05:22:57PM +0800, Guannan Ren wrote: On NUMA machine, the length of string got from file cpuacct.usage_percpu is quite large, so expand the limit of 1024 bytes. errors like: Failed to read file \ '/cgroup/cpuacct/libvirt/qemu/rhel6q/cpuacct.usage_percpu': \ Value

Re: [libvirt] [PATCH 1/3] cgroup: read more data from cgroup cpuacct.usage_percpu

2012-08-31 Thread Guannan Ren
On 08/31/2012 05:43 PM, Osier Yang wrote: On 2012年08月31日 17:22, Guannan Ren wrote: On NUMA machine, the length of string got from file cpuacct.usage_percpu is quite large, so expand the limit of 1024 bytes. errors like: Failed to read file \

[libvirt] [PATCH] doc: update option force to subcommand change-media

2012-08-31 Thread Guannan Ren
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=837761 --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index dbcaa25..10361cd 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8236,7 +8236,7 @@

Re: [libvirt] [PATCH 1/3] cgroup: read more data from cgroup cpuacct.usage_percpu

2012-08-31 Thread Guannan Ren
On 08/31/2012 05:22 PM, Guannan Ren wrote: On NUMA machine, the length of string got from file cpuacct.usage_percpu is quite large, so expand the limit of 1024 bytes. errors like: Failed to read file \ '/cgroup/cpuacct/libvirt/qemu/rhel6q/cpuacct.usage_percpu': \ Value too large for defined

Re: [libvirt] [PATCH] doc: update option force to subcommand change-media

2012-08-31 Thread Osier Yang
On 2012年08月31日 18:01, Guannan Ren wrote: BZ: https://bugzilla.redhat.com/show_bug.cgi?id=837761 --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index dbcaa25..10361cd 100644 --- a/tools/virsh-domain.c +++

[libvirt] [PATCH v2] doc: update option force to subcommand change-media

2012-08-31 Thread Guannan Ren
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=837761 --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index dbcaa25..10361cd 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8236,7 +8236,7 @@

Re: [libvirt] [PATCH v2] doc: update option force to subcommand change-media

2012-08-31 Thread Osier Yang
On 2012年08月31日 18:13, Guannan Ren wrote: BZ: https://bugzilla.redhat.com/show_bug.cgi?id=837761 --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index dbcaa25..10361cd 100644 --- a/tools/virsh-domain.c +++

Re: [libvirt] [PATCH V1 1/3] Implement virMacAddrIsBroadcastRaw

2012-08-31 Thread Stefan Berger
On 08/30/2012 11:33 PM, Daniel Veillard wrote: On Thu, Aug 30, 2012 at 02:29:49PM -0400, Stefan Berger wrote: Index: libvirt-acl/src/util/virmacaddr.h === --- libvirt-acl.orig/src/util/virmacaddr.h +++

Re: [libvirt] [PATCH V1 1/3] Implement virMacAddrIsBroadcastRaw

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 06:37:29AM -0400, Stefan Berger wrote: On 08/30/2012 11:33 PM, Daniel Veillard wrote: On Thu, Aug 30, 2012 at 02:29:49PM -0400, Stefan Berger wrote: Index: libvirt-acl/src/util/virmacaddr.h === ---

[libvirt] [PATCH 2/4 v2] conf: Parse and format disk wwn

2012-08-31 Thread Osier Yang
Validates the wwn while parsing, error out if it's malformed. * src/util/util.h: Declare virValidateWWN * src/util/util.c: Implement virValidateWWN * src/libvirt_private.syms: Export virValidateWWN. * src/conf/domain_conf.h: New member 'wwn' for disk def. * src/conf/domain_conf.c: Parse and

Re: [libvirt] [PATCH 2/4 v2] conf: Parse and format disk wwn

2012-08-31 Thread Osier Yang
On 2012年08月31日 19:10, Osier Yang wrote: Validates the wwn while parsing, error out if it's malformed. * src/util/util.h: Declare virValidateWWN * src/util/util.c: Implement virValidateWWN * src/libvirt_private.syms: Export virValidateWWN. * src/conf/domain_conf.h: New member 'wwn' for disk def.

Re: [libvirt] [PATCH 0/2] WIP: additional fixes to the security driver

2012-08-31 Thread Jiri Denemark
On Fri, Aug 31, 2012 at 09:49:40 +0200, Jiri Denemark wrote: Hi, these patches are a work in progress and apply on top of the two recent patches from Marcelo. Jiri Denemark (2): Fix seclabels parsing Format seclabels in a compatible way src/conf/domain_conf.c | 41

Re: [libvirt] [PATCH] qemu: Don't ignore CPU tuning config if required cgroups are missing

2012-08-31 Thread Jiri Denemark
On Fri, Aug 31, 2012 at 14:50:32 +0800, Daniel Veillard wrote: A bit of context would be nice On Fri, Aug 31, 2012 at 08:23:15AM +0200, Jiri Denemark wrote: --- src/qemu/qemu_cgroup.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) ACK,

Re: [libvirt] [PATCH] virsh: Document subdriver option of attach-disk

2012-08-31 Thread Jiri Denemark
On Fri, Aug 31, 2012 at 14:52:01 +0800, Daniel Veillard wrote: On Fri, Aug 31, 2012 at 08:23:30AM +0200, Jiri Denemark wrote: --- tools/virsh.pod | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) ACK Pushed, thanks. Jirka -- libvir-list mailing list

[libvirt] [PATCH] virsh: fixed incorrect timing report

2012-08-31 Thread Viktor Mihajlovski
When executing virsh -t command the reported timing was off by 3 orders of magnitude if the command took more than one second. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c

[libvirt] [PATCH 0/2] conf: Fix parsing and formatting of seclabels

2012-08-31 Thread Jiri Denemark
This patchset contains updated patches from Marcelo with the changes I sent previously as a WIP. Marcelo Cerri (2): conf: Fix parsing of seclabels without model conf: Avoid formatting auto-generated DAC labels src/conf/domain_conf.c | 78 ++

[libvirt] [PATCH 1/2] conf: Fix parsing of seclabels without model

2012-08-31 Thread Jiri Denemark
From: Marcelo Cerri mhce...@linux.vnet.ibm.com With this patch libvirt tries to assign a model to a single seclabel when model is missing. Libvirt will look up at host's capabilities and assign the first model to seclabel. This patch fixes: 1. The problem with existing guests that have a

Re: [libvirt] [PATCH] virsh: fixed incorrect timing report

2012-08-31 Thread Jiri Denemark
On Fri, Aug 31, 2012 at 13:32:45 +0200, Viktor Mihajlovski wrote: When executing virsh -t command the reported timing was off by 3 orders of magnitude if the command took more than one second. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- tools/virsh.c |2 +- 1

[libvirt] [PATCH 2/2] conf: Avoid formatting auto-generated DAC labels

2012-08-31 Thread Jiri Denemark
From: Marcelo Cerri mhce...@linux.vnet.ibm.com To avoid backward compatibility issues, this patch suppresses auto-generated DAC labels from XML. This change affects commands such as dumpxml and save. Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 15

Re: [libvirt] [PATCH 2/2] conf: Avoid formatting auto-generated DAC labels

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 01:40:41PM +0200, Jiri Denemark wrote: From: Marcelo Cerri mhce...@linux.vnet.ibm.com To avoid backward compatibility issues, this patch suppresses auto-generated DAC labels from XML. This change affects commands such as dumpxml and save. Signed-off-by: Marcelo

Re: [libvirt] [PATCH 1/2] conf: Fix parsing of seclabels without model

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 01:40:40PM +0200, Jiri Denemark wrote: From: Marcelo Cerri mhce...@linux.vnet.ibm.com With this patch libvirt tries to assign a model to a single seclabel when model is missing. Libvirt will look up at host's capabilities and assign the first model to seclabel.

Re: [libvirt] [PATCH] virsh: fixed incorrect timing report

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 01:42:00PM +0200, Jiri Denemark wrote: On Fri, Aug 31, 2012 at 13:32:45 +0200, Viktor Mihajlovski wrote: When executing virsh -t command the reported timing was off by 3 orders of magnitude if the command took more than one second. Signed-off-by: Viktor

[libvirt] Release of libvirt-0.10.1

2012-08-31 Thread Daniel Veillard
As promised there is a fixup release since 0.10.0 is catastrophic, and I should probably wear a brown paper bag ... The tarball is being pushed as I write this and should be available soon at the usual place: ftp://libvirt.org/libvirt/ There are still known issues, count 2 weeks of

Re: [libvirt] [PATCH] Fix adding ports to OVS bridges without VLAN tags

2012-08-31 Thread Kyle Mestery (kmestery)
On Aug 30, 2012, at 10:23 PM, Daniel Veillard wrote: On Thu, Aug 30, 2012 at 04:38:06PM -0400, Kyle Mestery wrote: The introduction of the new VLAN code, along with the fix from 5e465df6be8bcb00f0b4bff831e91f4042fae272, caused the addition of OVS ports to fail with the following message:

Re: [libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-08-31 Thread Viktor Mihajlovski
On 08/30/2012 07:37 PM, Daniel P. Berrange wrote: How about using this: blockio logical_size='512' physical_size='4096'/ Regards, Daniel That is perfectly fine with me. Any other suggestions for a v2 patch? -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland

Re: [libvirt] [PATCH] schemas: Fix wwn pattern

2012-08-31 Thread Osier Yang
On 2012年08月30日 00:47, Eric Blake wrote: On 08/29/2012 09:28 AM, Osier Yang wrote: It should be [] instead of (). --- docs/schemas/nodedev.rng |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK. Thanks, pushed. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] util: Update the inconsistent and outdated comments

2012-08-31 Thread Osier Yang
The codes were updated to allow to reset the device as long as there is no devices/functions behind the same bus. However, the comments were kept without touched. --- Pushed under trivial rule. --- src/util/pci.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH] qemu: fix remote port searching

2012-08-31 Thread Martin Kletzander
After fixing the last review comments on remote port searching (commit a14b4aea512d6c3a42af56207a65ef10ac4a12a1), the commit right after that wasn't modified accordingly, therefore two values weren't changed as they should and the configurable ports don't work as expected. This simple commit

Re: [libvirt] [PATCH] qemu: fix remote port searching

2012-08-31 Thread Jiri Denemark
On Fri, Aug 31, 2012 at 15:48:19 +0200, Martin Kletzander wrote: After fixing the last review comments on remote port searching (commit a14b4aea512d6c3a42af56207a65ef10ac4a12a1), the commit right after that wasn't modified accordingly, therefore two values weren't changed as they should and

Re: [libvirt] [PATCH] Fix adding ports to OVS bridges without VLAN tags

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 01:32:34PM +, Kyle Mestery (kmestery) wrote: On Aug 30, 2012, at 10:23 PM, Daniel Veillard wrote: On Thu, Aug 30, 2012 at 04:38:06PM -0400, Kyle Mestery wrote: [...] Still there is something which looks wrong, if we don't have a profileID why do we end up with

Re: [libvirt] [PATCH] qemu: fix remote port searching

2012-08-31 Thread Martin Kletzander
On 08/31/2012 04:06 PM, Jiri Denemark wrote: On Fri, Aug 31, 2012 at 15:48:19 +0200, Martin Kletzander wrote: After fixing the last review comments on remote port searching (commit a14b4aea512d6c3a42af56207a65ef10ac4a12a1), the commit right after that wasn't modified accordingly, therefore two

[libvirt] [PATCH] pci: Read bridge control register from the bridge

2012-08-31 Thread Osier Yang
Though I don't quite understand it well enough, but it looks wrong to read the control register from the device, and then write to its parent twice, while doing the secondary bus reset. --- src/util/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/pci.c

Re: [libvirt] [PATCH V3] Add proxy FS support to libvirt

2012-08-31 Thread M. Mohan Kumar
Hi Daniel, Any comment? On Thu, 23 Aug 2012 14:36:40 +0530, M. Mohan Kumar mo...@in.ibm.com wrote: From: M. Mohan Kumar mo...@in.ibm.com A new FS driver type 'proxy' is added to QEMU 9p server. This patch adds support for using proxy FS driver from libvirt. QEMU proxy FS driver uses

Re: [libvirt] [PATCH 0/2] virsh: Check for connection usability before each command

2012-08-31 Thread Peter Krempa
On 08/24/12 15:00, Martin Kletzander wrote: On 08/24/2012 02:42 PM, Peter Krempa wrote: Some commands in virsh forgot to do this check before executing remote commands and printed unexpected error messages. This series moves the connection check to a central point so that these mistakes don't

Re: [libvirt] [PATCH] qemu: fix remote port searching

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 04:09:39PM +0200, Martin Kletzander wrote: On 08/31/2012 04:06 PM, Jiri Denemark wrote: On Fri, Aug 31, 2012 at 15:48:19 +0200, Martin Kletzander wrote: After fixing the last review comments on remote port searching (commit a14b4aea512d6c3a42af56207a65ef10ac4a12a1),

Re: [libvirt] [PATCH 2/4 v2] conf: Parse and format disk wwn

2012-08-31 Thread Eric Blake
On 08/31/2012 04:10 AM, Osier Yang wrote: Validates the wwn while parsing, error out if it's malformed. * src/util/util.h: Declare virValidateWWN * src/util/util.c: Implement virValidateWWN * src/libvirt_private.syms: Export virValidateWWN. * src/conf/domain_conf.h: New member 'wwn' for

Re: [libvirt] [PATCH] qemu: fix remote port searching

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 04:31:56PM +0200, Martin Kletzander wrote: On 08/31/2012 04:29 PM, Daniel Veillard wrote: On Fri, Aug 31, 2012 at 04:09:39PM +0200, Martin Kletzander wrote: Hum, too bad that would have been good in 0.10.1, but after all 0.10.2 should not be too far away anyway ...

Re: [libvirt] [PATCH][TCK] add script to test storage and vol get commands

2012-08-31 Thread Daniel P. Berrange
On Fri, Aug 31, 2012 at 04:23:48PM +0800, Kyla Zhang wrote: including pool-get_uuid pool-get_name pool-refresh pool-get_volume_by_name vol-get_name vol-get_key vol-get_path vol-get_info vmm-get_storage_pool_by_uuid --- scripts/storage/120-get-ops.t | 116

Re: [libvirt] [PATCH] qemu: fix remote port searching

2012-08-31 Thread Martin Kletzander
On 08/31/2012 04:29 PM, Daniel Veillard wrote: On Fri, Aug 31, 2012 at 04:09:39PM +0200, Martin Kletzander wrote: On 08/31/2012 04:06 PM, Jiri Denemark wrote: On Fri, Aug 31, 2012 at 15:48:19 +0200, Martin Kletzander wrote: After fixing the last review comments on remote port searching (commit

Re: [libvirt] RFC: APIs to manage KSM

2012-08-31 Thread Daniel P. Berrange
On Fri, Aug 31, 2012 at 04:56:01PM +0800, Osier Yang wrote: Triggered by the requirement to control the new sys knob /sys/kernel/mm/ksm/merge_nodes for a NUMA aware host by patch: http://permalink.gmane.org/gmane.linux.kernel.mm/81497 It shows there is no methods to manage the KSM in

Re: [libvirt] RFC: APIs to manage KSM

2012-08-31 Thread Eric Blake
On 08/31/2012 07:46 AM, Daniel P. Berrange wrote: On Fri, Aug 31, 2012 at 04:56:01PM +0800, Osier Yang wrote: Triggered by the requirement to control the new sys knob /sys/kernel/mm/ksm/merge_nodes for a NUMA aware host by patch: As a general point, we should not use the term 'KSM' in the

Re: [libvirt] RFC: APIs to manage KSM

2012-08-31 Thread Osier Yang
On 2012年08月31日 22:46, Daniel P. Berrange wrote: On Fri, Aug 31, 2012 at 04:56:01PM +0800, Osier Yang wrote: Triggered by the requirement to control the new sys knob /sys/kernel/mm/ksm/merge_nodes for a NUMA aware host by patch: http://permalink.gmane.org/gmane.linux.kernel.mm/81497 It shows

Re: [libvirt] RFC: APIs to manage KSM

2012-08-31 Thread Daniel P. Berrange
On Fri, Aug 31, 2012 at 07:54:31AM -0700, Eric Blake wrote: On 08/31/2012 07:46 AM, Daniel P. Berrange wrote: On Fri, Aug 31, 2012 at 04:56:01PM +0800, Osier Yang wrote: Triggered by the requirement to control the new sys knob /sys/kernel/mm/ksm/merge_nodes for a NUMA aware host by patch:

Re: [libvirt] RFC: APIs to manage KSM

2012-08-31 Thread Eric Blake
On 08/31/2012 07:57 AM, Daniel P. Berrange wrote: some more generic name. eg virNodeSetMemorySharingParameters likewise for all the enum/constant names. For that matter, why can't we reuse the existing virDomainSetMemoryParameters() for the enum/constants? That is, whether or not to

[libvirt] [PATCH v4 3/3] tests: Add tests for qemu S3/S4 state configuration

2012-08-31 Thread Martin Kletzander
Few tests were added which are checking whether the parsing of the xml and command-line arguments is working and compatible with each other. --- tests/qemuargv2xmltest.c | 3 +++ .../qemuxml2argv-misc-disable-s3.args | 4 +++

[libvirt] [PATCH v4 0/3] Per-guest S3/S4 configuration

2012-08-31 Thread Martin Kletzander
There is a way to tell qemu how (not) to advertise S3/S4 ACPI sleep state capability to the guest OS. This series includes the capability to set this in the XML and also covers all the handling from qemu point of view including checking for the support, parameter parsing, command building,

[libvirt] [PATCH v4 1/3] Add per-guest S3/S4 state configuration

2012-08-31 Thread Martin Kletzander
There is a new pm/ element implemented that can control what ACPI sleeping states will be advertised by BIOS and allowed to be switched to by libvirt. The default keeps defaults on hypervisor, otherwise forces chosen setting. The documentation of the pm element is added as well. ---

[libvirt] [PATCH v4 2/3] qemu: Add support for S3/S4 state configuration

2012-08-31 Thread Martin Kletzander
This patch adds support for running qemu guests with the required parameters to forcefully enable or disable BIOS advertising of S3 and S4 states. The support for this is added to capabilities and there is also a qemu command parameter parsing implemented. --- src/qemu/qemu_capabilities.c | 7

[libvirt] [PATCHv6 0/2] Implementation of virConnectListAllDomains() for esx and hyperv

2012-08-31 Thread Peter Krempa
Yet another respin updated and rebased to current head. Both drivers are compile tested but I don't have the infrastructure do a functional test. Peter Krempa (2): hyperv: Add implementation for virConnectListAllDomains() esx: Add implementation for virConnectListAllDomains()

[libvirt] [PATCHv6 1/2] hyperv: Add implementation for virConnectListAllDomains()

2012-08-31 Thread Peter Krempa
Hyperv doesn't use the common virDomainObj implementation so this patch adds a separate implementation. This driver supports all currently added flags for filtering although some of those don't make sense with this driver (no support yet) and thus produce no output when used. ---

[libvirt] [PATCHv6 2/2] esx: Add implementation for virConnectListAllDomains()

2012-08-31 Thread Peter Krempa
ESX doesn't use the common virDomainObj implementation so this patch adds a separate implementation. This driver supports all currently defined filtering flags, but as with other drivers some combinations yield a empty result list. --- src/esx/esx_driver.c | 194

Re: [libvirt] [PATCH] command: shell-quote when logging commands

2012-08-31 Thread Eric Blake
On 08/28/2012 07:08 PM, Daniel Veillard wrote: On Tue, Aug 28, 2012 at 11:16:13AM -0700, Eric Blake wrote: Without this patch, logged command executions can be ambiguous if the command contained any shell metacharacters. This has caused more than one person to attempt to patch clients to add

Re: [libvirt] [PATCH][TCK] add script to test storage and vol get commands

2012-08-31 Thread Eric Blake
On 08/31/2012 07:39 AM, Daniel P. Berrange wrote: On Fri, Aug 31, 2012 at 04:23:48PM +0800, Kyla Zhang wrote: including pool-get_uuid pool-get_name pool-refresh pool-get_volume_by_name vol-get_name vol-get_key vol-get_path vol-get_info vmm-get_storage_pool_by_uuid ---

Re: [libvirt] [PATCH v4 1/3] Add per-guest S3/S4 state configuration

2012-08-31 Thread Eric Blake
On 08/31/2012 07:59 AM, Martin Kletzander wrote: There is a new pm/ element implemented that can control what ACPI sleeping states will be advertised by BIOS and allowed to be switched to by libvirt. The default keeps defaults on hypervisor, otherwise forces chosen setting. The documentation

Re: [libvirt] [PATCH v4 2/3] qemu: Add support for S3/S4 state configuration

2012-08-31 Thread Eric Blake
On 08/31/2012 07:59 AM, Martin Kletzander wrote: This patch adds support for running qemu guests with the required parameters to forcefully enable or disable BIOS advertising of S3 and S4 states. The support for this is added to capabilities and there is also a qemu command parameter parsing

[libvirt] [PATCH] python: don't mask libvirt errors

2012-08-31 Thread Eric Blake
A user reported this crash when using python bindings: File /home/nox/workspace/NOX/src/NOX/hooks.py, line 134, in trigger hook.trigger(event) File /home/nox/workspace/NOX/src/NOX/hooks.py, line 33, in trigger self.handlers[event]() File /home/nox/workspace/NOX/hooks/volatility.py,

Re: [libvirt] [PATCH v4 3/3] tests: Add tests for qemu S3/S4 state configuration

2012-08-31 Thread Eric Blake
On 08/31/2012 07:59 AM, Martin Kletzander wrote: Few tests were added which are checking whether the parsing of the xml and command-line arguments is working and compatible with each other. --- tests/qemuargv2xmltest.c | 3 +++ .../qemuxml2argv-misc-disable-s3.args

Re: [libvirt] [PATCH] pci: Read bridge control register from the bridge

2012-08-31 Thread Eric Blake
On 08/31/2012 07:17 AM, Osier Yang wrote: Though I don't quite understand it well enough, but it looks wrong to read the control register from the device, and then write to its parent twice, while doing the secondary bus reset. --- src/util/pci.c |2 +- 1 files changed, 1 insertions(+),

Re: [libvirt] [PATCH 1/2] conf: Support for Block Device IO Limits

2012-08-31 Thread Eric Blake
On 08/29/2012 08:48 AM, Viktor Mihajlovski wrote: Introducing a new iolimits element allowing to override certain properties of a guest block device like the physical and logical block size. This can be useful for platforms with 'non-standard' disk formats like S390 DASD with its 4K block

Re: [libvirt] [PATCH 2/2] qemu: Support for Block Device IO Limits.

2012-08-31 Thread Eric Blake
On 08/29/2012 08:48 AM, Viktor Mihajlovski wrote: Implementation of iolimits for the qemu driver with capability probing for block size attribute and command line generation for block sizes. Including testcase for qemuxml2argvtest. Signed-off-by: Viktor Mihajlovski

Re: [libvirt] [perl-Sys-Virt][PATCH] Virt.xs: fix flag issue on set_scheduler_parameters

2012-08-31 Thread Eric Blake
On 08/29/2012 02:56 AM, Alex Jia wrote: On 08/29/2012 02:12 PM, Guannan Ren wrote: On 08/28/2012 11:38 AM, Alex Jia wrote: From: Alex Jia Alex Jia a...@redhat.com The default flags are inconsistent on both qemuSetSchedulerParameters() and qemuGetSchedulerParameters() in libvirt, the

Re: [libvirt] [libvirt-perl PATCH v2] Virt.xs: fix flag issue on set_scheduler_parameters

2012-08-31 Thread Eric Blake
On 08/29/2012 03:03 AM, Alex Jia wrote: From: Alex Jia Alex Jia a...@redhat.com The default flags are inconsistent on both qemuSetSchedulerParameters() and qemuGetSchedulerParameters() in libvirt, the qemuGetSchedulerParameters() always passes 'VIR_DOMAIN_AFFECT_CURRENT' flag to the

Re: [libvirt] Libvirt 0.10.0-rc1 segfaults when daemon run as root

2012-08-31 Thread Eric Blake
On 08/24/2012 05:16 AM, Shawn Furrow wrote: Hi all, For some reason when I run libvirtd -d as root it seems to not start. I investigate by running libvirtd -v as root and I get a segfault. Here is the output: 2012-08-23 19:01:23.237+: 27464: info : libvirt version: 0.10.0 2012-08-23

[libvirt] [PATCH 0/1] Migrate per-port data during Qemu Live Migration

2012-08-31 Thread Kyle Mestery
Open vSwitch controllers may store per-port data in the OVS DB on a host. This is an opaque data blob utilized by a controller to store information relevant to the port itself. This patch provides a mechanism for this to migrate with the virtual machine during live migration by adding code to

[libvirt] [PATCH 1/1] Migrate per-port data for OVS ports during Qemu Live Migration

2012-08-31 Thread Kyle Mestery
Add the ability to migrate per-port data on Open vSwitch ports during qemu live migration. A controller can use this to store data relating to each port, and have it migrated with the virtual machine and populated on the destination host. Signed-off-by: Kyle Mestery kmest...@cisco.com ---

Re: [libvirt] [PATCH] build: define WITH_INTERFACE for the driver

2012-08-31 Thread Eric Blake
On 08/28/2012 09:17 PM, Doug Goldstein wrote: not part of the commit Really just looking for feedback if this an acceptable update to the previous work. My plan is to add a 'udev' backend that will provide just some basic read-only host interface information. Basically I've been seeing

Re: [libvirt] [PATCH] python: don't mask libvirt errors

2012-08-31 Thread Peter Krempa
On 08/31/12 19:10, Eric Blake wrote: A user reported this crash when using python bindings: File /home/nox/workspace/NOX/src/NOX/hooks.py, line 134, in trigger hook.trigger(event) File /home/nox/workspace/NOX/src/NOX/hooks.py, line 33, in trigger self.handlers[event]() File

Re: [libvirt] [PATCH] python: don't mask libvirt errors

2012-08-31 Thread Eric Blake
On 08/31/2012 03:05 PM, Peter Krempa wrote: On 08/31/12 19:10, Eric Blake wrote: A user reported this crash when using python bindings: In the python bindings, returning NULL makes python think an exception was thrown, while returning the None object lets the wrappers know that a libvirt

[libvirt] [PATCH] nwfilter: drop use of awk

2012-08-31 Thread Eric Blake
Commit 2a41bc9 dropped a dependency on gawk, but we can go one step further and avoid awk altogether. * src/nwfilter/nwfilter_ebiptables_driver.c (iptablesLinkIPTablesBaseChain): Simplify command. (ebiptablesDriverInit, ebiptablesDriverShutdown): Drop awk probe. --- Caveat - I was not set up to

Re: [libvirt] [libvirt-perl PATCH v2] Virt.xs: fix flag issue on set_scheduler_parameters

2012-08-31 Thread Daniel P. Berrange
On Fri, Aug 31, 2012 at 11:49:52AM -0700, Eric Blake wrote: On 08/29/2012 03:03 AM, Alex Jia wrote: From: Alex Jia Alex Jia a...@redhat.com The default flags are inconsistent on both qemuSetSchedulerParameters() and qemuGetSchedulerParameters() in libvirt, the