Re: [libvirt] [PATCH 0/3] more build fixes

2012-09-18 Thread Osier Yang
On 2012年09月19日 09:57, Eric Blake wrote: Pushing all three under the build-breaker rules. Well, I should look at this earlier. Eric Blake (3): bitmap: fix problems in previous commit build: fix nodeinfo build on non-Linux platforms build: avoid unused symbol src/libvirt_private.sy

Re: [libvirt] [PATCH 2/3] build: fix nodeinfo build on non-Linux platforms

2012-09-18 Thread Osier Yang
On 2012年09月19日 09:57, Eric Blake wrote: Commit aaa8ab3 added new static functions that are only used on Linux; but commit 22acfdc didn't go far enough to fix compiler issues. * src/nodeinfo.c (nodeSetMemoryParameterValue) (nodeGetMemoryParameterValue): Conditionally compile based on use. --- s

Re: [libvirt] [PATCH 3/3] build: avoid unused symbol

2012-09-18 Thread Osier Yang
On 2012年09月19日 09:57, Eric Blake wrote: Commit f36309d added an export with no matching implementation; probably a misspelling of an earlier version of the final addition of virNetworkObjSetDefTransient. * src/libvirt_private.syms (network_conf.h): Drop bogus virNetworkSetDefTransient. --- src

[libvirt] [PATCH 3/3] build: avoid unused symbol

2012-09-18 Thread Eric Blake
Commit f36309d added an export with no matching implementation; probably a misspelling of an earlier version of the final addition of virNetworkObjSetDefTransient. * src/libvirt_private.syms (network_conf.h): Drop bogus virNetworkSetDefTransient. --- src/libvirt_private.syms | 1 - 1 file changed

[libvirt] [PATCH 2/3] build: fix nodeinfo build on non-Linux platforms

2012-09-18 Thread Eric Blake
Commit aaa8ab3 added new static functions that are only used on Linux; but commit 22acfdc didn't go far enough to fix compiler issues. * src/nodeinfo.c (nodeSetMemoryParameterValue) (nodeGetMemoryParameterValue): Conditionally compile based on use. --- src/nodeinfo.c | 4 1 file changed, 4 i

Re: [libvirt] [PATCHv2 5/9] network: reorganize dnsmasq and radvd config file / startup

2012-09-18 Thread Eric Blake
On 09/18/2012 01:39 AM, Laine Stump wrote: > This patch splits the starting of dnsmasq and radvd into multiple > files, and adds new networkRefreshXX() and networkRestartXX() > functions for each. These new functions are currently commented out > because they won't be used until the next commit, an

[libvirt] [PATCH 1/3] bitmap: fix problems in previous commit

2012-09-18 Thread Eric Blake
Commit ee3d3893 missed the fact that (unsigned char)<<(int) is truncated to int, and therefore failed for any bitmap data longer than four bytes, but only on 64-bit platforms. Also, I failed to run 'make syntax-check' on my commit 4bba6579; for whatever odd reason, ffs lives in a different header

Re: [libvirt] [PATCH] util: don't free dmidecode path string before printing it

2012-09-18 Thread Eric Blake
On 09/18/2012 04:57 AM, Ján Tomko wrote: > The path was freed before printing the error message, resulting in: > error : virSysinfoRead:773 : internal error Failed to execute command > (null) > --- > src/util/sysinfo.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) While this fixes

Re: [libvirt] [PATCHv3 1/2] build: define WITH_INTERFACE for the driver

2012-09-18 Thread Eric Blake
On 09/17/2012 07:27 PM, Doug Goldstein wrote: > Based exclusively on work by Eric Blake in a patch posted with the same > subject. However some modifications related to comments and my plans to > add another backend. > > Added WITH_INTERFACE as the only automake variable deciding whether to > buil

Re: [libvirt] [PATCH] Ensure existing selinux mount is removed before mounting new one in LXC

2012-09-18 Thread Eric Blake
On 09/18/2012 05:34 AM, Daniel P. Berrange wrote: > Some kernel versions (at least RHEL-6 2.6.32) do not let you over-mount > an existing selinuxfs instance with a new one. Thus we must unmount the > existing instance inside our namespace. > > Signed-off-by: Daniel P. Berrange > --- > src/lxc/lx

[libvirt] [PATCH 0/3] more build fixes

2012-09-18 Thread Eric Blake
Pushing all three under the build-breaker rules. Eric Blake (3): bitmap: fix problems in previous commit build: fix nodeinfo build on non-Linux platforms build: avoid unused symbol src/libvirt_private.syms | 1 - src/nodeinfo.c | 4 src/util/bitmap.c| 3 +-- tests

Re: [libvirt] [PATCH] Improve some debugging log messages in LXC mount setup

2012-09-18 Thread Eric Blake
On 09/18/2012 05:29 AM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > src/lxc/lxc_container.c |9 + > 1 files changed, 5 insertions(+), 4 deletions(-) ACK. Safe for 0.10.2 -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library h

Re: [libvirt] [PATCH] build: avoid non-portable byte-swapping

2012-09-18 Thread Eric Blake
On 09/18/2012 03:32 PM, Eric Blake wrote: > > With this, a cross-build to mingw gets further (it was failing for > undefined functions, and now fails on: > > CC libvirt_util_la-virdbus.lo > ../../src/util/virdbus.c: In function 'virDBusAddWatch': > ../../src/util/virdbus.c:149:5: error: 'd

Re: [libvirt] [PATCH] build: avoid non-portable byte-swapping

2012-09-18 Thread Eric Blake
On 09/18/2012 02:54 PM, Peter Krempa wrote: > On 09/18/12 21:55, Eric Blake wrote: >> Commit 0fc89098 used functions only available on glibc, completely >> botched 32-bit environments, and risked SIGBUS due to unaligned >> memory access on platforms that aren't as forgiving as x86_64. >> >> * boots

Re: [libvirt] [PATCH] build: avoid non-portable byte-swapping

2012-09-18 Thread Peter Krempa
On 09/18/12 21:55, Eric Blake wrote: Commit 0fc89098 used functions only available on glibc, completely botched 32-bit environments, and risked SIGBUS due to unaligned memory access on platforms that aren't as forgiving as x86_64. * bootstrap.conf (gnulib_modules): Import ffsl. * src/util/bitmap

Re: [libvirt] [PATCH v4 2/9] New functions for virBitmap

2012-09-18 Thread Eric Blake
On 09/18/2012 08:29 AM, Eric Blake wrote: > On 09/18/2012 01:27 AM, Osier Yang wrote: >> On 2012年09月14日 15:46, Hu Tao wrote: >>> In many places we store bitmap info in a chunk of data >>> (pointed to by a char *), and have redundant codes to >>> set/unset bits. This patch extends virBitmap, and con

[libvirt] [PATCH] build: avoid non-portable byte-swapping

2012-09-18 Thread Eric Blake
Commit 0fc89098 used functions only available on glibc, completely botched 32-bit environments, and risked SIGBUS due to unaligned memory access on platforms that aren't as forgiving as x86_64. * bootstrap.conf (gnulib_modules): Import ffsl. * src/util/bitmap.c (includes): Use for ffsl. (virBitma

[libvirt] update: dnsmasq and dynamic dns for IPv6

2012-09-18 Thread Gene Czarcinski
I have done a bunch of testing and NetworkManager does not send the client-host's name to the server so that an IPv6 dns entry can occur. I have dupicated the problem with dnsmasq and bind/dhcp. This has been reported: https://bugzilla.redhat.com/show_bug.cgi?id=858327 Now back to figuring ou

Re: [libvirt] [libvirt-users] virNodeGetCPUStats and virDomainGetCPUStats have same name in pyton binding as getCPUStats

2012-09-18 Thread Buggi, Harsha
Hi, Thanks for your quick responses. On class specific bindin that Daniel mentioned: That’s what I thought too. But I believe right now we cant do something like "from import " since both virNodeGetCPUStats and virDomainGetCPUStats are in the same module. Is there a workaround for

Re: [libvirt] [PATCH 2/4] Add support for reboot-timeout

2012-09-18 Thread Daniel P. Berrange
On Tue, Sep 18, 2012 at 05:36:47PM +0200, Martin Kletzander wrote: > Whenever the guest machine fails to boot, new parameter (reboot-timeout) > controls whether it should reboot and after how many ms it should do so. > > Docs included. > --- > docs/formatdomain.html.in | 9 + > docs/

Re: [libvirt] [PATCH 1/4] qemu: Cleanup boot parameter building

2012-09-18 Thread Michal Privoznik
On 18.09.2012 17:36, Martin Kletzander wrote: > This patch cleans up building the "-boot" parameter and while on that > fixes one inconsistency by modifying these things: > > - First off, there's the cleanup for all *_LAST enum values to end >without comma at the end. I chose this way because

Re: [libvirt] [PATCH 3/4] qemu: Add support for reboot-timeout

2012-09-18 Thread Michal Privoznik
On 18.09.2012 17:36, Martin Kletzander wrote: > This patch adds support for "-boot reboot-timeout=rb_time" that is > added in QEMU. > --- > src/qemu/qemu_capabilities.c | 4 > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 36 > 3 f

Re: [libvirt] [PATCH 2/4] Add support for reboot-timeout

2012-09-18 Thread Michal Privoznik
On 18.09.2012 17:36, Martin Kletzander wrote: > Whenever the guest machine fails to boot, new parameter (reboot-timeout) > controls whether it should reboot and after how many ms it should do so. > > Docs included. > --- > docs/formatdomain.html.in | 9 + > docs/schemas/domaincommon.

Re: [libvirt] [PATCH 4/4] QEMU Tests for reboot-timeout

2012-09-18 Thread Michal Privoznik
On 18.09.2012 17:36, Martin Kletzander wrote: > --- > tests/qemuargv2xmltest.c| 4 > .../qemuxml2argv-reboot-timeout-disabled.args | 3 +++ > .../qemuxml2argv-reboot-timeout-disabled.xml| 21 > + > .../qemuxml2argv-reboot-timeou

Re: [libvirt] [PATCH 0/4] Add support for reboot-timeout

2012-09-18 Thread Michal Privoznik
On 18.09.2012 17:36, Martin Kletzander wrote: > This series introduces simple reboot timeout support. That means what > should be done in case all boot options fail, reboot or not. And if > yes, then how long the machine should wait. > > Before adding the support for that into XML parser, builder,

[libvirt] [libvirt-designer][PATCH 4/6] spec: Remove unused rules

2012-09-18 Thread Michal Privoznik
and update to reflect virtxml binary. --- libvirt-designer.spec.in | 22 +++--- 1 files changed, 3 insertions(+), 19 deletions(-) diff --git a/libvirt-designer.spec.in b/libvirt-designer.spec.in index b4107ea..1d5f4b6 100644 --- a/libvirt-designer.spec.in +++ b/libvirt-designer.

[libvirt] [libvirt-designer][PATCH 2/6] Create basic documentation

2012-09-18 Thread Michal Privoznik
In fact, it's only bare skeleton for gtkdoc --- .gitignore | 16 +++ Makefile.am|2 +- configure.ac |1 + docs/Makefile.am | 42 docs/libvirt-designer-docs.xml |

[libvirt] [libvirt-designer][PATCH 6/6] spec: Cleanup for rpmlint

2012-09-18 Thread Michal Privoznik
In order to prevent warnings and errors from rpmlint we need to cleanup spec file: capitalization summary and spell check (s/runtime/run-time/) --- libvirt-designer.spec.in |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libvirt-designer.spec.in b/libvirt-designer.s

[libvirt] [libvirt-designer][PATCH 5/6] Create manpage for virtxml

2012-09-18 Thread Michal Privoznik
--- .gitignore |1 + examples/Makefile.am | 11 examples/virtxml.pod | 121 ++ libvirt-designer.spec.in |1 + 4 files changed, 134 insertions(+), 0 deletions(-) create mode 100644 examples/virtxml.pod diff --git a/

[libvirt] [libvirt-designer][PATCH 0/6] Another functional extension

2012-09-18 Thread Michal Privoznik
and couple of fixes for clean RPM build. Michal Privoznik (6): Implement resources setting Create basic documentation domain.c: Document @error on public APIs spec: Remove unused rules Create manpage for virtxml spec: Cleanup for rpmlint .gitignore |

[libvirt] [libvirt-designer][PATCH 1/6] Implement resources setting

2012-09-18 Thread Michal Privoznik
Users can choose between minimum and recommended values for VCPU count and amount of RAM. Moreover, recommended values should inherit defaults from the minimum. --- examples/virtxml.c | 23 +++ libvirt-designer/libvirt-designer-domain.c | 91

[libvirt] [libvirt-designer][PATCH 3/6] domain.c: Document @error on public APIs

2012-09-18 Thread Michal Privoznik
to prevent warnings when generating the documentation. --- libvirt-designer/libvirt-designer-domain.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/libvirt-designer-domain.c index 1f734de..8423357 100644 -

[libvirt] [PATCH 3/4] qemu: Add support for reboot-timeout

2012-09-18 Thread Martin Kletzander
This patch adds support for "-boot reboot-timeout=rb_time" that is added in QEMU. --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 36 3 files changed, 41 insertions(+) diff --git a/src/qemu/qemu_c

[libvirt] [PATCH 2/4] Add support for reboot-timeout

2012-09-18 Thread Martin Kletzander
Whenever the guest machine fails to boot, new parameter (reboot-timeout) controls whether it should reboot and after how many ms it should do so. Docs included. --- docs/formatdomain.html.in | 9 + docs/schemas/domaincommon.rng | 20 src/conf/domain_conf.c

[libvirt] [PATCH 0/4] Add support for reboot-timeout

2012-09-18 Thread Martin Kletzander
This series introduces simple reboot timeout support. That means what should be done in case all boot options fail, reboot or not. And if yes, then how long the machine should wait. Before adding the support for that into XML parser, builder, and qemu, I felt the need to cleanup the boot parsing a

[libvirt] [PATCH 4/4] QEMU Tests for reboot-timeout

2012-09-18 Thread Martin Kletzander
--- tests/qemuargv2xmltest.c| 4 .../qemuxml2argv-reboot-timeout-disabled.args | 3 +++ .../qemuxml2argv-reboot-timeout-disabled.xml| 21 + .../qemuxml2argv-reboot-timeout-enabled.args| 3 +++ .../qemuxml2argv-reboot-tim

[libvirt] [PATCH 1/4] qemu: Cleanup boot parameter building

2012-09-18 Thread Martin Kletzander
This patch cleans up building the "-boot" parameter and while on that fixes one inconsistency by modifying these things: - First off, there's the cleanup for all *_LAST enum values to end without comma at the end. I chose this way because if it were the other way around, the patch would hav

[libvirt] [PATCH 0/5] Support ephemeral passthrough hostdevs

2012-09-18 Thread Shradha Shah
The ephemeral flag helps support migration with PCI-passthrough. An ephemeral hostdev is automatically unplugged before migration and replugged (if one is available on the destination) after migration. Shradha Shah (5): Added ephemeral flag for hostdev in domain conf. Adding ephemeral flag f

[libvirt] [PATCH 4/5] Ephemeral flag modification within the qemu driver.

2012-09-18 Thread Shradha Shah
When a guest with ephemeral device is migrated the PCI- passthrough of the ephemeral device should take place after migration and hence we check for the vmop in qemuBuildCommandLine. --- src/qemu/qemu_command.c | 48 -- 1 files changed, 25 insertions(+

[libvirt] [PATCH 5/5] Migration support for ephemeral hostdevs.

2012-09-18 Thread Shradha Shah
--- src/qemu/qemu_migration.c | 98 +++-- 1 files changed, 94 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 99fc8ce..f3414b0 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@

[libvirt] [PATCH 2/5] Adding ephemeral flag for hostdev in network conf.

2012-09-18 Thread Shradha Shah
The ephemeral flag helps support migration with PCI-passthrough. An ephemeral hostdev is automatically unplugged before migration and replugged (if one is available on the destination) after migration. --- docs/schemas/network.rng |8 src/conf/network_conf.c

[libvirt] [PATCH 3/5] Ephemeral flag mofication within the network driver.

2012-09-18 Thread Shradha Shah
--- src/network/bridge_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 0e38016..61d5b13 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3456,6 +3456,7 @@ networkAllocate

[libvirt] [PATCH 1/5] Added ephemeral flag for hostdev in domain conf.

2012-09-18 Thread Shradha Shah
The ephemeral flag helps support migration with PCI-passthrough. An ephemeral hostdev is automatically unplugged before migration and replugged (if one is available on the destination) after migration. --- docs/schemas/domaincommon.rng | 16 + src/conf/domain_con

Re: [libvirt] Entering freeze for 0.10.2

2012-09-18 Thread Kashyap Chamarthy
On 09/18/2012 04:55 PM, Daniel Veillard wrote: > I have just tagged the release candidate 1 version and provided > tarball and rpms at ftp://libvirt.org/libvirt/ > > so we have now entered freeze, I hope we didn't forgot any feature > except Dan's work for a locking daemon. maybe we can try to

Re: [libvirt] [PATCH] secret: Fix error for private secrets

2012-09-18 Thread Martin Kletzander
On 09/18/2012 04:09 PM, Peter Krempa wrote: > On 09/18/12 15:53, Martin Kletzander wrote: >> When trying to get the value of a private secret, the code used >> 'operation denied' error. That error is specified as an error for >> read-only connections trying to perform denied operation. The >> follo

Re: [libvirt] [PATCH] virNetDevBandwidthClear: Improve error handling

2012-09-18 Thread Martin Kletzander
On 09/18/2012 04:23 PM, Peter Krempa wrote: > On 09/18/12 15:52, Martin Kletzander wrote: >> Two changes are introduced in this patch. The first change removes >> ATTRIBUTE_RETURN_CHECK from virNetDevBandwidthClear, because it was >> called with ignore_value always, anyway. The function is used eve

Re: [libvirt] [PATCH] Fix minor details in apic eoi

2012-09-18 Thread Martin Kletzander
On 09/18/2012 04:33 PM, Peter Krempa wrote: > On 09/18/12 16:01, Martin Kletzander wrote: >> The introduction of APIC EOI patches had a few little details that >> could look better, so this patch fixes that. >> >> The fixes: >> - "on" and "off" as values are changed to on and >> off respectiv

Re: [libvirt] [PATCH] Fix minor details in apic eoi

2012-09-18 Thread Peter Krempa
On 09/18/12 16:01, Martin Kletzander wrote: The introduction of APIC EOI patches had a few little details that could look better, so this patch fixes that. The fixes: - "on" and "off" as values are changed to on and off respectively, because the code around uses the same tags for such

Re: [libvirt] [PATCH v4 2/9] New functions for virBitmap

2012-09-18 Thread Eric Blake
On 09/18/2012 01:27 AM, Osier Yang wrote: > On 2012年09月14日 15:46, Hu Tao wrote: >> In many places we store bitmap info in a chunk of data >> (pointed to by a char *), and have redundant codes to >> set/unset bits. This patch extends virBitmap, and convert >> those codes to use virBitmap in subseque

Re: [libvirt] [PATCH] virNetDevBandwidthClear: Improve error handling

2012-09-18 Thread Peter Krempa
On 09/18/12 15:52, Martin Kletzander wrote: Two changes are introduced in this patch. The first change removes ATTRIBUTE_RETURN_CHECK from virNetDevBandwidthClear, because it was called with ignore_value always, anyway. The function is used even when it's not necessary to call it, just for cleanu

Re: [libvirt] [PATCH] secret: Fix error for private secrets

2012-09-18 Thread Peter Krempa
On 09/18/12 15:53, Martin Kletzander wrote: When trying to get the value of a private secret, the code used 'operation denied' error. That error is specified as an error for read-only connections trying to perform denied operation. The following error seems more accurate. To compare the differen

Re: [libvirt] NFS over RDMA small block DIRECT_IO bug

2012-09-18 Thread Andrew Holway
Hi Steve, Do you think these patches will make their way into the redhat kernel sometime soon? What is the state of support for NFS over RDMA support at redhat? Thanks, Andrew On Sep 11, 2012, at 7:03 PM, Steve Dickson wrote: > > > On 09/04/2012 05:31 AM, Andrew Holway wrote: >> Hello. >>

[libvirt] [PATCH] Fix minor details in apic eoi

2012-09-18 Thread Martin Kletzander
The introduction of APIC EOI patches had a few little details that could look better, so this patch fixes that. The fixes: - "on" and "off" as values are changed to on and off respectively, because the code around uses the same tags for such values. - VIR_FREE is unnecessary as it is done

[libvirt] [PATCHv2] security: Don't ignore errors when parsing DAC security labels

2012-09-18 Thread Peter Krempa
The DAC security driver silently ignored errors when parsing the DAC label and used default values instead. With a domain containing the following label definition: sdfklsdjlfjklsdjkl the domain would start normaly but the disk images would be still owned by root and no error was displayed. T

[libvirt] [PATCH] secret: Fix error for private secrets

2012-09-18 Thread Martin Kletzander
When trying to get the value of a private secret, the code used 'operation denied' error. That error is specified as an error for read-only connections trying to perform denied operation. The following error seems more accurate. To compare the difference: - BEFORE error: operation secret is priva

[libvirt] [PATCH] virNetDevBandwidthClear: Improve error handling

2012-09-18 Thread Martin Kletzander
Two changes are introduced in this patch. The first change removes ATTRIBUTE_RETURN_CHECK from virNetDevBandwidthClear, because it was called with ignore_value always, anyway. The function is used even when it's not necessary to call it, just for cleanup purposes. The second change is an added para

Re: [libvirt] [libvirt-users] virNodeGetCPUStats and virDomainGetCPUStats have same name in pyton binding as getCPUStats

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 12:33:12PM +0100, Daniel P. Berrange wrote: > On Tue, Sep 18, 2012 at 07:28:44PM +0800, Daniel Veillard wrote: > > On Tue, Sep 18, 2012 at 10:56:55AM +, Buggi, Harsha wrote: > > > Hi, > > > > > > virNodeGetCPUStats and virDomainGetCPUStats have same name in pyton > > >

Re: [libvirt] [PATCH] Adhere to copyright_address check

2012-09-18 Thread Martin Kletzander
On 09/18/2012 01:10 PM, Daniel P. Berrange wrote: > On Tue, Sep 18, 2012 at 01:07:26PM +0200, Guido Günther wrote: >> to fix "make syntax-check" >> >> Found by http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/ >> --- >> run.in |3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >

[libvirt] [PATCH] syntax-check: fix run.in

2012-09-18 Thread Martin Kletzander
Two more problems in "run.in" made the syntax-check fail. --- Pushed under the 'build-breaker' rule. cfg.mk | 2 +- run.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index 0dd58df..bbfd4a2 100644 --- a/cfg.mk +++ b/cfg.mk @@ -789,7 +789,7 @@ exclude_fi

[libvirt] [PATCH] security: Don't ignore errors when parsing DAC security labels

2012-09-18 Thread Peter Krempa
The DAC security driver silently ignored errors when parsing the DAC label and used default values instead. With a domain containing the following label definition: sdfklsdjlfjklsdjkl the domain would start normaly but the disk images would be still owned by root and no error was displayed. T

[libvirt] [PATCH] Ensure existing selinux mount is removed before mounting new one in LXC

2012-09-18 Thread Daniel P. Berrange
Some kernel versions (at least RHEL-6 2.6.32) do not let you over-mount an existing selinuxfs instance with a new one. Thus we must unmount the existing instance inside our namespace. Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_container.c | 16 1 files changed, 16 inser

Re: [libvirt] [libvirt-users] virNodeGetCPUStats and virDomainGetCPUStats have same name in pyton binding as getCPUStats

2012-09-18 Thread Daniel P. Berrange
On Tue, Sep 18, 2012 at 07:28:44PM +0800, Daniel Veillard wrote: > On Tue, Sep 18, 2012 at 10:56:55AM +, Buggi, Harsha wrote: > > Hi, > > > > virNodeGetCPUStats and virDomainGetCPUStats have same name in pyton binding > > as getCPUStats > > > > virDomainGetCPUStats gets called internally whe

[libvirt] [PATCH] Improve some debugging log messages in LXC mount setup

2012-09-18 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_container.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index f5b0bc6..8fbbc0d 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -556,8 +556

Re: [libvirt] [libvirt-users] virNodeGetCPUStats and virDomainGetCPUStats have same name in pyton binding as getCPUStats

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 10:56:55AM +, Buggi, Harsha wrote: > Hi, > > virNodeGetCPUStats and virDomainGetCPUStats have same name in pyton binding > as getCPUStats > > virDomainGetCPUStats gets called internally when we use the method > getCPUStats. How do we access virNodeGetCPUStats? Ouc

Re: [libvirt] [PATCH] qemuhelptest: convert runaway tab to spaces

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 11:17:26AM +0200, Ján Tomko wrote: > Make syntax-check happy and smiling again. > --- > tests/qemuhelptest.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c > index 5c6ecd5..a3d9656 100644 > --- a/t

[libvirt] FYI: valgrind output from libvirtd when running the libguestfs test suite

2012-09-18 Thread Richard W.M. Jones
./run \ valgrind --leak-check=full --child-silent-after-fork=yes \ --log-file=/tmp/valgrind.log \ daemon/libvirtd --timeout=30 Then run '../libvirt/run make check' in another window. This is with libvirt from git, updated a few hours ago. I'm always dubious about these strlen problems s

[libvirt] Entering freeze for 0.10.2

2012-09-18 Thread Daniel Veillard
I have just tagged the release candidate 1 version and provided tarball and rpms at ftp://libvirt.org/libvirt/ so we have now entered freeze, I hope we didn't forgot any feature except Dan's work for a locking daemon. maybe we can try to push that one for rc2 possibly Thursday or Friday. Then

Re: [libvirt] [PATCH] Adhere to copyright_address check

2012-09-18 Thread Daniel P. Berrange
On Tue, Sep 18, 2012 at 01:07:26PM +0200, Guido Günther wrote: > to fix "make syntax-check" > > Found by http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/ > --- > run.in |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/run.in b/run.in > index 7700e52..83c1785 10

[libvirt] [PATCH] Adhere to copyright_address check

2012-09-18 Thread Guido Günther
to fix "make syntax-check" Found by http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/ --- run.in |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/run.in b/run.in index 7700e52..83c1785 100644 --- a/run.in +++ b/run.in @@ -13,8 +13,7 @@ # GNU General Public License fo

[libvirt] [PATCH] util: don't free dmidecode path string before printing it

2012-09-18 Thread Ján Tomko
The path was freed before printing the error message, resulting in: error : virSysinfoRead:773 : internal error Failed to execute command (null) --- src/util/sysinfo.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c index 92c3539..8

Re: [libvirt] [libvirt-glib][PATCH] autobuild: Init AUTOBUILD_INSTALL_ROOT variable

2012-09-18 Thread Michal Privoznik
On 18.09.2012 12:20, Daniel P. Berrange wrote: > On Tue, Sep 18, 2012 at 12:10:56PM +0200, Michal Privoznik wrote: >> Otherwise autobuild sets prefix to / resulting in >> Permission denied when building as non-root as >> 'make install' tries to write to /lib. We need to >> set this var to accessibl

Re: [libvirt] [libvirt-glib][PATCH] autobuild: Init AUTOBUILD_INSTALL_ROOT variable

2012-09-18 Thread Daniel P. Berrange
On Tue, Sep 18, 2012 at 12:10:56PM +0200, Michal Privoznik wrote: > Otherwise autobuild sets prefix to / resulting in > Permission denied when building as non-root as > 'make install' tries to write to /lib. We need to > set this var to accessible path like $HOME/builder. > --- > autobuild.sh |

Re: [libvirt] [PATCH 00/10] new virNetworkUpdate API

2012-09-18 Thread Laine Stump
On 09/17/2012 02:04 PM, Daniel P. Berrange wrote: > On Mon, Sep 17, 2012 at 05:48:45AM -0400, Laine Stump wrote: >> This patchset implements a new API function called virNetworkUpdate >> which enables updating certain parts of a libvirt network's definition >> without the need to destroy/re-start t

[libvirt] [libvirt-glib][PATCH] autobuild: Init AUTOBUILD_INSTALL_ROOT variable

2012-09-18 Thread Michal Privoznik
Otherwise autobuild sets prefix to / resulting in Permission denied when building as non-root as 'make install' tries to write to /lib. We need to set this var to accessible path like $HOME/builder. --- autobuild.sh |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/autobuild

[libvirt] [PATCH] rpc: Fix name of member in remote_protocol-structs

2012-09-18 Thread Peter Krempa
Commit 7a99b0abafb69e1686198ac3473892a9aaeb8255 adds a new RPC struct but one of the members has different names in remote_protocol.x and remote_protocol-struct breaking make check. --- Pushing under build-breaker rule. src/remote_protocol-structs | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [libvirt] [PATCH 3/3] Add a ./run script for running programs from the local directory.

2012-09-18 Thread Daniel P. Berrange
On Tue, Sep 18, 2012 at 10:26:07AM +0100, Richard W.M. Jones wrote: > On Tue, Sep 18, 2012 at 10:12:39AM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 14, 2012 at 11:09:28AM +0100, Richard W.M. Jones wrote: > > > +# Do we have libtool? If we have it then we can use it to make > > > +# running v

Re: [libvirt] [PATCH] virBitmap: fix build without HAVE_NUMACTL

2012-09-18 Thread Osier Yang
On 2012年09月18日 17:13, Ján Tomko wrote: Commit 75b198b3e7b2c8b4106afbd42f8bb795c4773511 forgot to change arguments of dummy qemuProcessInitNumaMemoryPolicy from char* to virBitmapPtr. --- src/qemu/qemu_process.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/

Re: [libvirt] [PATCH] qemuhelptest: convert runaway tab to spaces

2012-09-18 Thread Peter Krempa
On 09/18/12 11:17, Ján Tomko wrote: Make syntax-check happy and smiling again. --- tests/qemuhelptest.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK and will be pushed soon. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo

Re: [libvirt] [PATCH] virBitmap: fix build without HAVE_NUMACTL

2012-09-18 Thread Peter Krempa
On 09/18/12 11:13, Ján Tomko wrote: Commit 75b198b3e7b2c8b4106afbd42f8bb795c4773511 forgot to change arguments of dummy qemuProcessInitNumaMemoryPolicy from char* to virBitmapPtr. --- src/qemu/qemu_process.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK and will be pushed

Re: [libvirt] [PATCH 3/3] Add a ./run script for running programs from the local directory.

2012-09-18 Thread Richard W.M. Jones
On Tue, Sep 18, 2012 at 10:12:39AM +0100, Daniel P. Berrange wrote: > On Fri, Sep 14, 2012 at 11:09:28AM +0100, Richard W.M. Jones wrote: > > +# Do we have libtool? If we have it then we can use it to make > > +# running valgrind simpler. However don't depend on it. > > +if libtool --help >/dev/n

[libvirt] [PATCH] qemuhelptest: convert runaway tab to spaces

2012-09-18 Thread Ján Tomko
Make syntax-check happy and smiling again. --- tests/qemuhelptest.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index 5c6ecd5..a3d9656 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -845,7 +845,7 @@ mymain(v

Re: [libvirt] [PATCH 3/3] Add a ./run script for running programs from the local directory.

2012-09-18 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 11:09:28AM +0100, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > With this script you can run libvirt programs without needing to > install them first. You just have to do for example: > > ./run ./tools/virsh [args ...] > > If you are already in the tools/

[libvirt] [PATCH] virBitmap: fix build without HAVE_NUMACTL

2012-09-18 Thread Ján Tomko
Commit 75b198b3e7b2c8b4106afbd42f8bb795c4773511 forgot to change arguments of dummy qemuProcessInitNumaMemoryPolicy from char* to virBitmapPtr. --- src/qemu/qemu_process.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c in

Re: [libvirt] [PATCH 1/3] gitignore: Ignore .gdb_history file.

2012-09-18 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 11:09:26AM +0100, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > --- > .gitignore |1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index d998f0e..56d4742 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -18,6 +18,7 @@ >

Re: [libvirt] [PATCH 2/3] daemon: Fix error message when libvirtd is missing.

2012-09-18 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 11:09:27AM +0100, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > Currently we search along the hard-coded names: > SBINDIR "/libvirtd" > SBINDIR "/libvirtd_dbg" > but if the environment variable $LIBVIRTD_PATH is set to the > name of the libvirtd binary, th

Re: [libvirt] [PATCH v8] support offline migration

2012-09-18 Thread liguang
Hi, All this patch need to be reviewed, I've re-sent it several days ago, but no reviewer, so it may be forgot. 在 2012-09-17一的 15:10 +0800,liguang写道: > Hi, Daniel & Eric > > can you help to review this patch again? > > Thanks! > > 在 2012-09-17一的 08:45 +0800,liguang写道: > > original migration di

Re: [libvirt] [PATCHv2 0/9] new virNetworkUpdate API

2012-09-18 Thread Laine Stump
On 09/18/2012 03:38 AM, Laine Stump wrote: > = > > Changes from V1: > > 1) implemented Eric's suggested change to make "command" >a separate arg rather than squeezing it into the flags > > 2) already pushed the first two ACKed patches (not directly related to >new API > > 3) added new p

Re: [libvirt] [PATCHv2 9/9] network: implement backend of virNetworkUpdate(IP_DHCP_HOST)

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 03:39:05AM -0400, Laine Stump wrote: > This patch fills in the first implementation for one of the > virNetworkUpdate sections. With this code, you can now add/delete/edit > entries in a network's address element (by > specifying a section of VIR_NETWORK_SECTION_IP_DHCP_H

Re: [libvirt] [PATCHv2 8/9] network: restart radvd/dnsmasq if needed when libvirtd is restarted

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 03:39:04AM -0400, Laine Stump wrote: > A user on IRC had accidentally killed all of his libvirt-started > dnsmasq instances (due to a buggy dnsmasq service script in Fedora > 16), and had hoped that libvirtd would notice this on restart and > reload all the dnsmasq daemons (

Re: [libvirt] [PATCHv2 6/9] network: implement virNetworkUpdate for bridge_driver

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 03:39:02AM -0400, Laine Stump wrote: > Call the network_conf function that modifies the live/persistent/both > config, then refresh/restart dnsmasq/radvd if necessary, and finally > save the config in the proper place(s). > > This patch also needed to uncomment a few utilit

Re: [libvirt] [PATCHv2 7/9] network: implement virNetworkUpdate for test_driver

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 03:39:03AM -0400, Laine Stump wrote: > The test driver does nothing outside of keeping track of each > network's config/state in the in-memory database maintained by > network_conf functions, so all we have to do is call the function that > updates the network's entry in the

Re: [libvirt] [PATCHv2 5/9] network: reorganize dnsmasq and radvd config file / startup

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 03:39:01AM -0400, Laine Stump wrote: > This patch splits the starting of dnsmasq and radvd into multiple > files, and adds new networkRefreshXX() and networkRestartXX() > functions for each. These new functions are currently commented out > because they won't be used until t

Re: [libvirt] [PATCHv2 4/9] conf: implement NetworkObj backend of virNetworkUpdate API

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 03:39:00AM -0400, Laine Stump wrote: > virNetworkObjUpdate takes care of all virNetworkUpdate-related changes > to the data stored in the in-memory virNetworkObj list. It should be > called by network drivers that use this in-memory list. > > virNetworkObjUpdate *does not*

Re: [libvirt] [PATCHv2 3/9] network: utility functions for updating network config

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 03:38:59AM -0400, Laine Stump wrote: > These new functions are highly inspired by those in domain_conf.c (but > not identical), and are intended to make it simpler to update the > various combinations of live/persistent network configs. > > The network driver wasn't previou

Re: [libvirt] [PATCHv2 1/9] network: define new API virNetworkUpdate

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 03:38:57AM -0400, Laine Stump wrote: > This patch adds a new public API virNetworkUpdate that will permit > updating an existing network configuration without requiring that the > network be destroyed/restarted for the changes to take effect. > --- > include/libvirt/libvirt

Re: [libvirt] [PATCHv2 2/9] network: implement RPC calls for virNetworkUpdate

2012-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2012 at 03:38:58AM -0400, Laine Stump wrote: > This is very short, because almost everything is autogenerated. All > that's needed are: > > * src/remote/remote_driver.c: add pointer to autogenerated > remoteNetworkUpdate to the function table for the remote > network driver

Re: [libvirt] [PATCHv3 0/4] qemu: Add seccomp sandbox support

2012-09-18 Thread Daniel Veillard
On Mon, Sep 17, 2012 at 09:59:51AM +0200, Ján Tomko wrote: > This series adds support to run QEMU with seccomp sandbox enabled. It can be > configured in qemu.conf to on, off, or the QEMU default, which is off in 1.2. > Default value is the QEMU default. > > V1 of the patches supports tri-state co

[libvirt] [PATCHv2 0/9] new virNetworkUpdate API

2012-09-18 Thread Laine Stump
= Changes from V1: 1) implemented Eric's suggested change to make "command" a separate arg rather than squeezing it into the flags 2) already pushed the first two ACKed patches (not directly related to new API 3) added new patch at the end implementing updates of dhcp host entries.

[libvirt] [PATCHv2 9/9] network: implement backend of virNetworkUpdate(IP_DHCP_HOST)

2012-09-18 Thread Laine Stump
This patch fills in the first implementation for one of the virNetworkUpdate sections. With this code, you can now add/delete/edit entries in a network's address element (by specifying a section of VIR_NETWORK_SECTION_IP_DHCP_HOST). If you pass in a parentIndex of -1, the code will automaticall

[libvirt] [PATCHv2 3/9] network: utility functions for updating network config

2012-09-18 Thread Laine Stump
These new functions are highly inspired by those in domain_conf.c (but not identical), and are intended to make it simpler to update the various combinations of live/persistent network configs. The network driver wasn't previously as careful about the separation between the live "status" in networ

  1   2   >