The testcase is for testing non-fixed PCI address for primary
video device and using video args to -deivce qemu option.
---
.../qemuxml2argv-video-device-pciaddr-default.args | 9 +
.../qemuxml2argv-video-device-pciaddr-default.xml | 44 ++
tests/qemuxml2argvtest.c
QEMU_CAPS_DEVICE_QXL -device qxl
QEMU_CAPS_DEVICE_VGA -device VGA
QEMU_CAPS_DEVICE_CIRRUS_VGA -device cirrus-vga
QEMU_CAPS_DEVICE_VMWARE_SVGA -device vmware-svga
QEMU_CAPS_1DOT20_PLUS/* safe to use -device XXX
for primary video device
(I'm sending this v0.10.2-maint backport of the upstream patch to
the list because the code in question was completely replaced, so it
required a new patch rather than a backport. The backport for
0.9.11-maint is nearly identical to this, so I won't be sending that
one)
This patch resolves the
If there are multiple video devices
primary = 'yes' marks this video device as the primary one.
The rest are secondary video devices. No more than one could be
mark as primary. If none of them has primary attribute, the first
one will be the primary by default like what it was.
The reason of this
v2: Check qemu version, it has to be qemu = 1.2 for using
new video device with -device qemu option
v3: Add a new caps bit QEMU_CAPS_1DOT20_PLUS to mark qemu = 1.2
Add a new testcase for improved qemu commandline
Fixed all placed pointed out in v2
This patch set aims to use qemu VGA
'-device VGA' maps to '-vga std'
'-device cirrus-vga' maps to '-vga cirrus'
'-device qxl-vga' maps to '-vga qxl'
(there is also '-device qxl' for secondary devices)
'-device vmware-svga' maps to '-vga vmware'
For qemu(=1.2), we can use -device to replace -vga for video
device. For
On 2012年12月13日 15:01, Hu Tao wrote:
Add a flag VIR_CGROUP_DISABLE_CPUSET to disable cgroup cpuset.
This flag inhibits making of directory under cpuset.
---
src/util/cgroup.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/util/cgroup.c b/src/util/cgroup.c
index f867fb7..e955a22
On 2012年12月13日 14:59, Hu Tao wrote:
On Thu, Dec 13, 2012 at 12:21:29PM +0800, Osier Yang wrote:
On 2012年11月07日 18:38, Hu Tao wrote:
The reason to disable cgroup cpuset by default is: currently,
sub-directories of cgroup cpuset won't be auto-updated if
cpu hot-plug happens. For example, if we
On 12/13/12 08:34, Laine Stump wrote:
This patch resolves the problem reported in:
https://bugzilla.redhat.com/show_bug.cgi?id=886663
The source of the problem was the fix for CVE 2011-3411:
https://bugzilla.redhat.com/show_bug.cgi?id=833033
which was originally committed upstream in
On 12/13/12 10:00, Laine Stump wrote:
(I'm sending this v0.10.2-maint backport of the upstream patch to
the list because the code in question was completely replaced, so it
required a new patch rather than a backport. The backport for
0.9.11-maint is nearly identical to this, so I won't be
On 12/13/12 08:01, Hu Tao wrote:
This is merely a rebased version, so still tagged with v1.
The reason to disable cgroup cpuset by default is: currently,
sub-directories of cgroup cpuset won't be auto-updated if
cpu hot-plug happens. For example, if we now have 0-3,5-7 pcpus
online, the value
On Thu, Dec 13, 2012 at 05:10:47PM +0800, Osier Yang wrote:
On 2012年12月13日 15:01, Hu Tao wrote:
Add a flag VIR_CGROUP_DISABLE_CPUSET to disable cgroup cpuset.
This flag inhibits making of directory under cpuset.
---
src/util/cgroup.c | 7 +++
1 file changed, 7 insertions(+)
diff
On Thu, Dec 13, 2012 at 05:10:47PM +0800, Osier Yang wrote:
On 2012年12月13日 15:01, Hu Tao wrote:
Add a flag VIR_CGROUP_DISABLE_CPUSET to disable cgroup cpuset.
This flag inhibits making of directory under cpuset.
---
src/util/cgroup.c | 7 +++
1 file changed, 7 insertions(+)
diff
From: Daniel P. Berrange berra...@redhat.com
The current virStorageFileGet{LVM,SCSI}Key methods return
the key as the return value. Unfortunately it is desirable
for NULL to be a valid return value, as well as an error
indicator. Thus the returned key must instead be provided
as an
On Thu, Dec 13, 2012 at 11:44:37AM +0100, Ján Tomko wrote:
In the case of an OOM error in virDomainDefGetSecurityLabelDef, secdef
is set to NULL, then dereferenced while printing the debug message.
---
src/security/security_selinux.c |3 ++-
1 files changed, 2 insertions(+), 1
On Tue, Dec 11, 2012 at 21:37:18 +0800, Osier Yang wrote:
This introduces a hash table for qemu driver, to store the shared
disk's info as (@disk_path, {@ref_count, @orig_cdbfilter}). @ref_count
is the number of domains which shares the disk. @orig_cdbfilter is
the original cdbfilter setting
On 2012年12月13日 19:05, Jiri Denemark wrote:
On Tue, Dec 11, 2012 at 21:37:18 +0800, Osier Yang wrote:
This introduces a hash table for qemu driver, to store the shared
disk's info as (@disk_path, {@ref_count, @orig_cdbfilter}). @ref_count
is the number of domains which shares the disk.
On Tue, Dec 11, 2012 at 08:41:34PM +, Daniel P. Berrange wrote:
While we're past the freeze date, I'd like to request an
exception, for all except the 14th patch. Without the
14th patch, this series has minimal impact on existing code
that is used in libvirt so little regression
I know we are in the freeze so I will push this after upstream is thaw.
Michal Privoznik (2):
qemu: Relax locking in DomainHasManagedSaveImage and
DomainMonitorCommand
qemu: Convert some APIs to use qemuDomObjFromDomain
src/qemu/qemu_driver.c | 478
There is no need to hold qemu lock during the whole execution
of these two APIs.
---
src/qemu/qemu_driver.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2fda44e..74e442b 100644
---
Many internal qemu APIs must find domain object from passed
virDomainPtr. And with function Peter's introduced, we can use it
instead of copying multiple lines among code.
---
src/qemu/qemu_driver.c | 470 +---
1 files changed, 47 insertions(+), 423
On Tue, Dec 11, 2012 at 02:57:10PM -0700, Eric Blake wrote:
On 12/11/2012 01:41 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Refactor virLockManagerPluginNew() so that the caller does
not need to pass in the config file path itself - just the
config
On Wed, Dec 12, 2012 at 07:14:20PM +0100, Michal Privoznik wrote:
On 11.12.2012 21:41, Daniel P. Berrange wrote:
+static int
+virLockDaemonForkIntoBackground(const char *argv0)
+{
+int statuspipe[2];
+if (pipe(statuspipe) 0)
+return -1;
+
+pid_t pid =
On Wed, Dec 12, 2012 at 11:32:18AM -0700, Eric Blake wrote:
On 12/12/2012 11:14 AM, Michal Privoznik wrote:
On 11.12.2012 21:41, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The virtlockd daemon will be responsible for managing locks
on virtual machines.
On Wed, Dec 12, 2012 at 07:14:15PM +0100, Michal Privoznik wrote:
On 11.12.2012 21:41, Daniel P. Berrange wrote:
+
+static int
+virLockSpaceProtocolDispatchAcquireResource(virNetServerPtr server
ATTRIBUTE_UNUSED,
+virNetServerClientPtr
On 12/13/2012 04:26 AM, Daniel P. Berrange wrote:
On Tue, Dec 11, 2012 at 08:41:34PM +, Daniel P. Berrange wrote:
While we're past the freeze date, I'd like to request an
exception, for all except the 14th patch. Without the
14th patch, this series has minimal impact on existing code
that
On 12/13/12 12:40, Michal Privoznik wrote:
There is no need to hold qemu lock during the whole execution
of these two APIs.
---
src/qemu/qemu_driver.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
On 12/13/12 13:50, Peter Krempa wrote:
On 12/13/12 12:40, Michal Privoznik wrote:
There is no need to hold qemu lock during the whole execution
of these two APIs.
---
src/qemu/qemu_driver.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git
Right now virsh says 'Failed to reconnect to the hypervisor' even for the
first connection to the default URI and it fails to catch disconnections for
connections to the non-default URI.
Ján Tomko (2):
virsh: don't lie about reconnection in vshReconnect
virsh: use vshReconnect for non-default
Since we (ab)use vshReconnect for the default URI connection, if it
fails it might print 'Failed to reconnect to the hypervisor' even if we
were never connected before.
This changes it to only mention reconnection on the first try after
getting disconnected.
---
tools/virsh.c |5 -
1
For non-default connections (specified by the environment variable or
the command line option) we call virConnectOpenAuth without registering
the vshCatchDisconnect callback.
This calls vshReconnect instead which takes care of it.
---
tools/virsh.c |6 +-
1 files changed, 1
From: Daniel P. Berrange berra...@redhat.com
Fully stub out the virCgroupGetAppRoot method as done with other
methods in the file, rather than just the body. This lets us
annotate the unused parameter to avoid a warning
Pushed as a Win32 build breaker fix
---
src/util/cgroup.c | 7 +--
1
On 12/13/12 12:40, Michal Privoznik wrote:
Many internal qemu APIs must find domain object from passed
virDomainPtr. And with function Peter's introduced, we can use it
instead of copying multiple lines among code.
---
src/qemu/qemu_driver.c | 470
On Thu, Dec 13, 2012 at 14:07:59 +0100, Ján Tomko wrote:
Right now virsh says 'Failed to reconnect to the hypervisor' even for the
first connection to the default URI and it fails to catch disconnections for
connections to the non-default URI.
Ján Tomko (2):
virsh: don't lie about
On 13.12.2012 14:23, Peter Krempa wrote:
On 12/13/12 12:40, Michal Privoznik wrote:
Many internal qemu APIs must find domain object from passed
virDomainPtr. And with function Peter's introduced, we can use it
instead of copying multiple lines among code.
---
src/qemu/qemu_driver.c | 470
Libvirt mis-detected the QED file format as raw
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: Daniel P. Berrange berra...@redhat.com
To help us detect when new storage file versions come into
existance log a warning if the storage file magic matches,
but the version does not
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/storage_file.c | 14 --
1
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/storage_file.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/util/storage_file.c b/src/util/storage_file.c
index 4281d90..69a66ff 100644
---
From: Daniel P. Berrange berra...@redhat.com
The QED file format is non-versioned, so although the magic
value matched, libvirt rejected it due to lack of a version
number to compare against. We need to distinguish this case
by allowing a value of '-2' to indicate a non-versioned file
where only
On 12/13/12 15:26, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
To help us detect when new storage file versions come into
existance log a warning if the storage file magic matches,
but the version does not
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On Thu, Dec 13, 2012 at 03:49:00PM +0100, Peter Krempa wrote:
On 12/13/12 15:26, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The QED file format is non-versioned, so although the magic
value matched, libvirt rejected it due to lack of a version
number to compare
On 12/13/12 15:26, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The QED file format is non-versioned, so although the magic
value matched, libvirt rejected it due to lack of a version
number to compare against. We need to distinguish this case
by allowing a value of
On 12/13/12 15:51, Daniel P. Berrange wrote:
On Thu, Dec 13, 2012 at 03:49:00PM +0100, Peter Krempa wrote:
On 12/13/12 15:26, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The QED file format is non-versioned, so although the magic
value matched, libvirt rejected it
On 12/13/12 15:26, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/storage_file.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/util/storage_file.c b/src/util/storage_file.c
On Thu, Dec 13, 2012 at 05:46:56AM -0700, Eric Blake wrote:
On 12/13/2012 04:26 AM, Daniel P. Berrange wrote:
On Tue, Dec 11, 2012 at 08:41:34PM +, Daniel P. Berrange wrote:
While we're past the freeze date, I'd like to request an
exception, for all except the 14th patch. Without the
Eric Blake wrote:
On 12/12/2012 02:42 PM, Jim Fehlig wrote:
The libxl driver ignored boot devices in the domain config,
preventing PXE booting HVM domains. This patch accounts for
user-specified boot devices when building the libxl domain
configuration.
---
I'm inclined to call this a
---
src/Makefile.am | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 7c2d8ed..5a9fb84 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -149,19 +149,22 @@ LOCK_DRIVER_SANLOCK_HELPER_SOURCES = \
$(srcdir) is already part of $$file since commit f1f9a7ac7e.
---
Pushed as a build-breaker.
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index bb80992..7c2d8ed 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1451,7
On Thu, Dec 13, 2012 at 14:24:03 +0100, Jiri Denemark wrote:
On Thu, Dec 13, 2012 at 14:07:59 +0100, Ján Tomko wrote:
Right now virsh says 'Failed to reconnect to the hypervisor' even for the
first connection to the default URI and it fails to catch disconnections for
connections to the
---
src/qemu/qemu_driver.c | 73 ++
1 file changed, 73 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 441272d..bcd9c57 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -12907,6 +12907,78 @@
This also changes the function signature to take a
virDomainChrSourceDefPtr instead of just a path, since it needs to
differentiate behavior based on source-type.
---
src/conf/virchrdev.c | 38 +-
src/conf/virchrdev.h | 5 +++--
src/qemu/qemu_driver.c | 2
This is just code motion, in preparation to rename identifiers to be
less console-specific.
---
po/POTFILES.in | 2 +-
src/Makefile.am | 2 +-
src/conf/virchrdev.c | 414 +++
src/conf/virchrdev.h | 36 +
This patch adds a new API, virDomainOpenChannel, that uses streams to
connect to a virtio channel on a guest. This creates a secure
communication channel between a guest and a libvirt client.
This behaves the same as virDomainOpenConsole, except on channels
instead of console/serial/parallel
The functionality provided in virchrdev.c (previously virconsole.c) is
applicable to other types of character devices besides consoles, such
as channels. This patch is just code motion, renaming things such as
console or pty, instead using more general terms such as
character device or device
This series enables the qemu driver to tunnel a virtio channel. This
is useful for a remote session to communicate with a guest channel via
the streaming API.
This was originally fleshed out a while back in this thread:
https://www.redhat.com/archives/libvir-list/2011-September/msg01049.html
Somehow I managed to push the changes to this file with improper
indentation. This patch just re-indents, reformats the comment lines,
and re-groups a couple of multi-line strings so that they fit within
80 columns. The resulting binary should be identical.
I'm *not* pushing this as trivial,
On 12/11/2012 07:34 AM, Jiri Denemark wrote:
---
Pushed as trivial build-breaker.
src/conf/network_conf.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h
index 49fc0ca..8adc2a4 100644
--- a/src/conf/network_conf.h
+++
so we can build with older sanlock (like 2.2)
---
I've applied this to the current Debian builds since we're lagging a bit
regarding sanlock but it might make sense to also support this upstream.
Cheers,
-- Guido
src/locking/lock_driver_sanlock.c |3 +++
1 file changed, 3 insertions(+)
On Thu, Dec 13, 2012 at 05:06:04PM +0100, Jiri Denemark wrote:
---
src/Makefile.am | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 7c2d8ed..5a9fb84 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@
On Thu, Dec 13, 2012 at 11:24:15AM -0500, John Eckersberg wrote:
This series enables the qemu driver to tunnel a virtio channel. This
is useful for a remote session to communicate with a guest channel via
the streaming API.
This was originally fleshed out a while back in this thread:
On Thu, Dec 13, 2012 at 06:20:06PM +0100, Guido Günther wrote:
so we can build with older sanlock (like 2.2)
---
I've applied this to the current Debian builds since we're lagging a bit
regarding sanlock but it might make sense to also support this upstream.
Cheers,
-- Guido
On 12/13/2012 02:06 AM, Guannan Ren wrote:
v2: Check qemu version, it has to be qemu = 1.2 for using
new video device with -device qemu option
v3: Add a new caps bit QEMU_CAPS_1DOT20_PLUS to mark qemu = 1.2
Not quite what I had in mind. The bit should be named based on what
FEATURE we
On 12/13/2012 02:06 AM, Guannan Ren wrote:
QEMU_CAPS_DEVICE_QXL -device qxl
QEMU_CAPS_DEVICE_VGA -device VGA
QEMU_CAPS_DEVICE_CIRRUS_VGA -device cirrus-vga
QEMU_CAPS_DEVICE_VMWARE_SVGA -device vmware-svga
QEMU_CAPS_1DOT20_PLUS/* safe to use -device XXX
This prevents the domain starting if the shared disk's setting
conflicts with other active domain(s), E.g. A domain with
cdbfilter set as yes, however, another active domain is using
it set as no.
---
This assumes the lock manager will prevents one using same disk
mixed with non-shared and shared
Since rawio and cdbfilter are only valid for lun, this
groups them together; And since both of them intend to allow
the unprivledged user to use the SG_IO commands, they must be
exclusive.
---
docs/formatdomain.html.in | 13 +-
docs/schemas/domaincommon.rng | 52
As a result of RFC [1], this implements the unprivleged SG_IO
support.
v6 - v7:
* No restoring of unpriv_sgio per Daniel's thought.
* Use major:minor as the hash key per Jirka's suggestion.
Osier Yang (8):
util: Prepare helpers for unpriv_sgio setting
qemu: Add a hash table for the
Setting cdbfilter to no to enable the unprivleged SG_IO, I.e.
Disable the kernel CDB filtering. And yes to enable it. yes
is the kernel default behaviour. Later patch will do the actual
setting.
---
src/conf/domain_conf.c | 58 +++-
virGetDevice{Major,Minor} could be used across the sources,
but it doesn't relate with this series, and could be done later.
* src/util/util.h: (Declare virGetDevice{Major,Minor}, and
vir{Get,Set}DeviceUnprivSGIO)
* src/util/util.c: (New internal helper virCanonicalizeDiskPath
Just like for domain starting, this sets the disk's unpriv_sgio
if cdbfilter is specified when attaching disk.
---
src/qemu/qemu_driver.c | 23 +--
1 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
Note that cdbfilter is not exactly match unpriv_sgio's value.
VIR_DOMAIN_DISK_CDB_FILTER_YES mean the kernel will filter the
SCSI commands, which maps to 0 of unpriv_sgio;
VIR_DOMAIN_DISK_CDB_FILTER_NO maps to 1 of unpriv_sgio.
---
src/qemu/qemu_process.c | 11 ++-
1 files changed, 10
This introduces a hash table for qemu driver, to store the shared
disk's info as (@disk_path, @ref_count). @ref_count is the number
of domains which shares the disk.
Since we only care about the disk's cdbfilter (see later patch)
setting for shared disk currently, and cdbfilter is only valid for
Just like for domain starting, this checks if the shared disk's conf
conflicts with others.
---
src/qemu/qemu_driver.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 7239d71..eb0c921 100644
---
---
src/Makefile.am | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 2791cb6..33b4ab0 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -367,6 +367,7 @@ check-symfile:
endif
check-symsorting:
$(AM_V_GEN)$(PERL)
---
src/Makefile.am | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 2791cb6..33b4ab0 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -367,6 +367,7 @@ check-symfile:
endif
check-symsorting:
$(AM_V_GEN)$(PERL)
On 12/13/2012 03:37 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The current virStorageFileGet{LVM,SCSI}Key methods return
the key as the return value. Unfortunately it is desirable
for NULL to be a valid return value, as well as an error
indicator. Thus the
On Thu, Dec 13, 2012 at 23:17:57 +0100, Jiri Denemark wrote:
---
src/Makefile.am | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
Oops, I didn't want to send this patch twice. Please ignore this one.
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
On 12/13/2012 03:14 PM, Jiri Denemark wrote:
---
src/Makefile.am | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
On Thu, Dec 13, 2012 at 17:47:00 +, Daniel P. Berrange wrote:
On Thu, Dec 13, 2012 at 05:06:04PM +0100, Jiri Denemark wrote:
---
src/Makefile.am | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
ACK
Pushed, thanks.
Jirka
--
libvir-list mailing list
On Thu, Dec 13, 2012 at 15:17:58 -0700, Eric Blake wrote:
On 12/13/2012 03:14 PM, Jiri Denemark wrote:
---
src/Makefile.am | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
ACK.
Pushed, thanks.
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
On 12/13/2012 09:06 AM, Jiri Denemark wrote:
---
src/Makefile.am | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
ACK. I'm not sure if you want to squash your two EXTRA_DIST patches
into one, or keep them separate.
--
Eric Blake eblake redhat com
On 12/13/2012 09:46 AM, Laine Stump wrote:
Somehow I managed to push the changes to this file with improper
indentation. This patch just re-indents, reformats the comment lines,
and re-groups a couple of multi-line strings so that they fit within
80 columns. The resulting binary should be
On 12/13/2012 09:09 AM, Jiri Denemark wrote:
$(srcdir) is already part of $$file since commit f1f9a7ac7e.
---
Pushed as a build-breaker.
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index bb80992..7c2d8ed 100644
* src/Makefile.am (libvirt.syms): Let cat loop for us.
---
I'll wait for a review before pushing, rather than claiming it is trivial.
src/Makefile.am | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 33b4ab0..cf6096a 100644
---
since compilation breaks otherwise with older libsanlock.
---
Hi Daniel,
does this make more sense then?
Cheers,
-- Guido
configure.ac | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index bf32f95..1936982 100644
--- a/configure.ac
On 12/13/2012 03:53 AM, Daniel P. Berrange wrote:
On Thu, Dec 13, 2012 at 11:44:37AM +0100, Ján Tomko wrote:
In the case of an OOM error in virDomainDefGetSecurityLabelDef, secdef
is set to NULL, then dereferenced while printing the debug message.
---
src/security/security_selinux.c |3
On 12/13/2012 03:48 PM, Guido Günther wrote:
since compilation breaks otherwise with older libsanlock.
---
Hi Daniel,
does this make more sense then?
Cheers,
-- Guido
I'm not Daniel, but it looks right to me.
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
On 12/13/2012 03:14 PM, Jiri Denemark wrote:
---
src/Makefile.am | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
Even with this, I'm still seeing 'make distcheck' fail on RHEL 6.3:
ERROR: files left in build directory after distclean:
./src/virtlockd.init
make[1]: ***
On 12/13/2012 02:06 AM, Guannan Ren wrote:
If there are multiple video devices
primary = 'yes' marks this video device as the primary one.
The rest are secondary video devices. No more than one could be
mark as primary. If none of them has primary attribute, the first
one will be the primary
On 12/13/2012 02:06 AM, Guannan Ren wrote:
The testcase is for testing non-fixed PCI address for primary
video device and using video args to -deivce qemu option.
---
.../qemuxml2argv-video-device-pciaddr-default.args | 9 +
.../qemuxml2argv-video-device-pciaddr-default.xml | 44
On 12/13/2012 02:06 AM, Guannan Ren wrote:
'-device VGA' maps to '-vga std'
'-device cirrus-vga' maps to '-vga cirrus'
'-device qxl-vga' maps to '-vga qxl'
(there is also '-device qxl' for secondary devices)
'-device vmware-svga' maps to '-vga vmware'
For qemu(=1.2), we can
Hello,
I would like to enable vhost-net on an interface of ethernet type. However,
this doesn't work, probably due to the following code in libvirt.
if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK ||
actualType == VIR_DOMAIN_NET_TYPE_BRIDGE ||
The virtlockd daemon scripts were lousy, when compared to their
counterparts in daemon/Makefile.am. In particular, when init
scripts were selected, this resulted in 'make distcheck' failing
due to failure to clean up src/virtlockd.init.
* src/Makefile.am (install-systemd): Fix dependencies. Use
On 12/13/12 23:45, Eric Blake wrote:
* src/Makefile.am (libvirt.syms): Let cat loop for us.
---
I'll wait for a review before pushing, rather than claiming it is trivial.
src/Makefile.am | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
ACK
Peter
--
libvir-list mailing list
On 12/13/2012 05:12 PM, Peter Krempa wrote:
On 12/13/12 23:45, Eric Blake wrote:
* src/Makefile.am (libvirt.syms): Let cat loop for us.
---
I'll wait for a review before pushing, rather than claiming it is
trivial.
src/Makefile.am | 4 +---
1 file changed, 1 insertion(+), 3
When a network device's bridge connection is changed by
virDomainUpdateDevice, libvirt first removes the netdev's tap from its
old bridge, then adds it to the new bridge. Sometimes, due to a
network being destroyed while a guest device is still attached, the
tap may already be removed from the old
On 12/13/2012 05:40 PM, Laine Stump wrote:
When a network device's bridge connection is changed by
virDomainUpdateDevice, libvirt first removes the netdev's tap from its
old bridge, then adds it to the new bridge. Sometimes, due to a
network being destroyed while a guest device is still
On 12/13/2012 07:05 PM, Raja Sivaramakrishnan wrote:
Hello,
I would like to enable vhost-net on an interface of ethernet type.
However,
this doesn't work, probably due to the following code in libvirt.
if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK ||
On 12/13/2012 07:44 PM, Eric Blake wrote:
On 12/13/2012 05:40 PM, Laine Stump wrote:
When a network device's bridge connection is changed by
virDomainUpdateDevice, libvirt first removes the netdev's tap from its
old bridge, then adds it to the new bridge. Sometimes, due to a
network being
For a unprivileged user libvirt.conf and auth.conf are looked up in
$XDG_CONFIG_HOME but the docs incorrectly state that it's $XDG_CONFIG_DIR.
---
docs/auth.html.in |2 +-
docs/uri.html.in |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/auth.html.in
v1: add 2 vcpupin cases
* use pinVcpuFlags to pin domain vcpu to host cpu
* 2 cases cover config and live flags
* cpulist with '^', '-' and ',' is supported to give multiple
host cpus
* vcpus and vcpuPinInfo are used as part of the checking
* a sample conf is added
v2: move format cpulist
1 - 100 of 110 matches
Mail list logo
