Hi,
it seems one of these commits
5411e7e176dcbb65591cb97ec128b5fd0f365805
473011334ccd93e8efbb67f2561f1d4e54d212ae
392c192240566d9e167d2b5a1022092d8f7e045c
broke make check as seen on
http://honk.sigxcpu.org:8001/job/libvirt-check/417/console
output attached. I can't look into this in
On Wed, Dec 19, 2012 at 10:50:42AM +0100, Guido Günther wrote:
Hi,
it seems one of these commits
5411e7e176dcbb65591cb97ec128b5fd0f365805
473011334ccd93e8efbb67f2561f1d4e54d212ae
392c192240566d9e167d2b5a1022092d8f7e045c
broke make check as seen on
From: Daniel P. Berrange berra...@redhat.com
If securityselinuxtest was run on a system with newer SELinux
policy it would fail, due to using svirt_tcg_t instead of
svirt_t. Fixing the domain type to be KVM avoids this issue.
Pushed as a build fix
---
tests/securityselinuxtest.c | 1 +
1 file
On 12/18/2012 09:38 PM, Eric Blake wrote:
I know this is already pushed, but I think it would fit better under
m4/virt-compile-warnings.m4 rather than at the top-level configure.ac.
since it is early in the release it's not too late to change this,
although I think - if not in configure.ac -
On Wed, Dec 19, 2012 at 11:14:15AM +0100, Viktor Mihajlovski wrote:
On 12/18/2012 09:38 PM, Eric Blake wrote:
I know this is already pushed, but I think it would fit better under
m4/virt-compile-warnings.m4 rather than at the top-level configure.ac.
since it is early in the release it's
From: Daniel P. Berrange berra...@redhat.com
Prior to the virArch changes, the CPU baseline method would
free the arch string in the returned CPU. Fix the regression
by setting arch to VIR_ARCH_NONE at the end
Pushed as a test breaker fix from virArch fallout
Signed-off-by: Daniel P. Berrange
o
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: Daniel P. Berrange berra...@redhat.com
Historically there was an inconsistency in handling of the
itanium arch. The xen driver CPU model code treated it
as 'ia64' but the QEMU capabilities code used 'itanium'. On
the grounds that no one has ever seriously used itanium
with QEMU, while
On Wed, Dec 19, 2012 at 09:59:45AM +, Daniel P. Berrange wrote:
On Wed, Dec 19, 2012 at 10:50:42AM +0100, Guido Günther wrote:
Hi,
it seems one of these commits
5411e7e176dcbb65591cb97ec128b5fd0f365805
473011334ccd93e8efbb67f2561f1d4e54d212ae
From: Daniel P. Berrange berra...@redhat.com
When parsing the arch from domain XML, the result was only
saved to a local variable, not the virDomainDefPtr
Pushed as a test breaker fix from virArch fallout
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/conf/domain_conf.c | 4 ++--
On Tue, Dec 18, 2012 at 02:26:53PM +0100, al...@redhat.com wrote:
From: Alexander Larsson al...@redhat.com
diff --git
a/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host-certificates.h
b/libvirt-gconfig/libvirt-gconfig-domain-smartcard-host-certificates.h
new file mode 100644
index
On 12/16/12 23:21, Peter Krempa wrote:
On 12/16/12 15:47, Roman Bogorodskiy wrote:
---
src/util/processinfo.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/util/processinfo.c b/src/util/processinfo.c
index b1db049..4822bcc 100644
--- a/src/util/processinfo.c
From: Daniel P. Berrange berra...@redhat.com
When changing to virArch, the virt-aa-helper.c file was not
completely changed. The vahControl struct was left with a
char *arch field, instead of virArch arch field.
Pushed as a build breaker fix
---
src/security/virt-aa-helper.c | 3 +--
1 file
Currently the files in src/util are 50/50 split between those
having a 'vir' prefix and those which don't. Finish the job
by remaining all remaining files to have a 'vir' prefix too,
guaranteeing that they can't clash with system headers[1].
The only case which was not a plain rename, was merging
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/Makefile.am| 2 +-
src/conf/cpu_conf.h| 2 +-
src/conf/domain_conf.c | 3 +--
src/conf/domain_conf.h | 2 +-
From: Daniel P. Berrange berra...@redhat.com
To bring in line with new naming practice, rename the=
src/util/cgroup.{h,c} files to vircgroup.{h,c}
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in | 2 +-
src/Makefile.am| 2 +-
From: Daniel P. Berrange berra...@redhat.com
---
daemon/libvirtd-config.c | 2 +-
daemon/libvirtd.c | 2 +-
po/POTFILES.in| 2 +-
src/Makefile.am | 2 +-
src/libvirt.c | 2 +-
src/libxl/libxl_driver.c | 2
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/Makefile.am | 2 +-
src/conf/capabilities.c | 2 +-
src/conf/capabilities.h | 2 +-
src/conf/cpu_conf.c |
From: Daniel P. Berrange berra...@redhat.com
---
cfg.mk| 4 ++--
daemon/remote.c | 2 +-
po/POTFILES.in| 2 +-
src/Makefile.am | 2 +-
src/fdstream.h| 2
From: Daniel P. Berrange berra...@redhat.com
---
daemon/libvirtd.c | 2 +-
po/POTFILES.in | 2 +-
src/Makefile.am | 2 +-
src/lxc/lxc_driver.c| 2 +-
src/lxc/lxc_process.c | 2 +-
src/qemu/qemu_driver.c | 2 +-
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in | 2 +-
src/Makefile.am | 2 +-
src/network/bridge_driver.c | 2 +-
src/network/bridge_driver.h | 2 +-
src/util/{dnsmasq.c = virdnsmasq.c} | 2 +-
src/util/{dnsmasq.h =
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in | 2 +-
src/Makefile.am | 2 +-
src/lxc/lxc_cgroup.h | 2 +-
src/lxc/lxc_conf.h | 2 +-
src/lxc/lxc_container.c | 2 +-
src/qemu/qemu_cgroup.h | 2 +-
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in | 2 +-
src/Makefile.am| 2 +-
src/conf/node_device_conf.c| 2 +-
src/network/bridge_driver.c| 2 +-
src/node_device/node_device_hal.c | 2 +-
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in | 2 +-
src/Makefile.am| 2 +-
src/network/bridge_driver.c| 2 +-
src/util/{iptables.c = viriptables.c} | 2 +-
src/util/{iptables.h = viriptables.h} | 0
5 files changed,
From: Daniel P. Berrange berra...@redhat.com
---
src/Makefile.am| 2 +-
src/qemu/qemu_bridge_filter.c | 2 +-
src/qemu/qemu_conf.h | 2 +-
src/util/{ebtables.c = virebtables.c} | 2 +-
src/util/{ebtables.h = virebtables.h} | 0
5 files changed,
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in | 2 +-
src/Makefile.am | 2 +-
src/parallels/parallels_utils.c | 2 +-
src/parallels/parallels_utils.h | 2 +-
src/qemu/qemu_agent.c | 2 +-
src/qemu/qemu_monitor.h | 2 +-
From: Daniel P. Berrange berra...@redhat.com
Since the event APIs are now in the public header, no internal
code should include virevent.h
---
src/Makefile.am | 2 +-
src/rpc/virnetclientstream.c | 1 -
src/rpc/virnetserver.c | 1 -
src/rpc/virnetservermdns.c
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in| 2 +-
src/Makefile.am | 2 +-
src/rpc/virnetservermdns.c| 2 +-
src/util/virevent.c | 2 +-
src/util/{event_poll.c = vireventpoll.c} | 2 +-
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in | 1 -
src/Makefile.am | 1 -
src/libvirt_private.syms | 7 +-
src/lxc/lxc_controller.c | 3 +-
src/qemu/qemu_driver.c | 14 ++--
src/qemu/qemu_process.c | 9 +--
src/util/processinfo.c | 189
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in | 2 +-
src/Makefile.am | 2 +-
src/lxc/lxc_driver.c| 2 +-
src/openvz/openvz_driver.c | 2 +-
src/qemu/qemu_driver.c
From: Daniel P. Berrange berra...@redhat.com
---
cfg.mk | 2 +-
po/POTFILES.in | 2 +-
src/Makefile.am | 2 +-
src/util/{sexpr.c = virsexpr.c} | 2 +-
src/util/{sexpr.h = virsexpr.h} | 0
src/xen/xend_internal.c | 2 +-
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in| 2 +-
src/Makefile.am | 2 +-
src/conf/domain_conf.c| 2 +-
src/conf/domain_conf.h| 2 +-
src/conf/snapshot_conf.c
From: Daniel P. Berrange berra...@redhat.com
---
src/Makefile.am | 53 +++--
1 file changed, 27 insertions(+), 26 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 2713bf2..f7a9b91 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
From: Daniel P. Berrange berra...@redhat.com
---
cfg.mk | 2 +-
po/POTFILES.in | 2 +-
src/Makefile.am | 2 +-
src/conf/cpu_conf.h | 2 +-
src/conf/device_conf.c | 2 +-
src/conf/domain_conf.c
From: Daniel P. Berrange berra...@redhat.com
---
src/Makefile.am| 2 +-
src/nwfilter/nwfilter_dhcpsnoop.c | 2 +-
src/qemu/qemu_conf.h | 2 +-
src/qemu/qemu_driver.c | 2 +-
src/rpc/virnetserver.c
From: Daniel P. Berrange berra...@redhat.com
---
daemon/libvirtd.c | 1 -
daemon/libvirtd.h | 2 +-
src/Makefile.am| 8
src/conf/device_conf.h | 2 +-
From: Daniel P. Berrange berra...@redhat.com
---
daemon/libvirtd.c| 3 +--
daemon/remote.c | 2 +-
src/Makefile.am | 2 +-
src/conf/capabilities.c | 2 +-
src/conf/device_conf.c | 2 +-
From: Daniel P. Berrange berra...@redhat.com
---
po/POTFILES.in | 2 +-
src/Makefile.am | 2 +-
src/conf/domain_conf.h | 2 +-
src/qemu/qemu_driver.c | 2 +-
src/util/{sysinfo.c = virsysinfo.c} | 2 +-
src/util/{sysinfo.h =
On 12/19/2012 11:21 AM, Daniel P. Berrange wrote:
On Wed, Dec 19, 2012 at 11:14:15AM +0100, Viktor Mihajlovski wrote:
I think Eric means that on non-GCC this code:
# if BROKEN_GCC_WLOGICALOP
# pragma GCC diagnostic ignored -Wlogical-op
# endif
will cause the compiler to complain Unknown
On Wed, Dec 19, 2012 at 01:05:42PM +0100, Viktor Mihajlovski wrote:
On 12/19/2012 11:21 AM, Daniel P. Berrange wrote:
On Wed, Dec 19, 2012 at 11:14:15AM +0100, Viktor Mihajlovski wrote:
I think Eric means that on non-GCC this code:
# if BROKEN_GCC_WLOGICALOP
# pragma GCC diagnostic
Ping?
Christophe
On Fri, Dec 14, 2012 at 05:03:37PM +0100, Christophe Fergeau wrote:
This guarantees that the string will be nul-terminated. Coverity
warned about this issue.
---
libvirt-gobject/libvirt-gobject-connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
I've fixed the space-before-parens nit and pushed this, thanks for the
patch!
Christophe
On Wed, Dec 19, 2012 at 12:21:44PM +0100, Christophe Fergeau wrote:
On Tue, Dec 18, 2012 at 02:26:53PM +0100, al...@redhat.com wrote:
From: Alexander Larsson al...@redhat.com
diff --git
From: Roman Bogorodskiy bogorods...@gmail.com
---
This version incorporates DanPB's idea of checking if setting affinity for all
processors and failing otherwise.
---
src/util/processinfo.c | 28
1 file changed, 28 insertions(+)
diff --git a/src/util/processinfo.c
On Fri, Dec 14, 2012 at 05:46:44PM +0100, Peter Krempa wrote:
Commit 16c915ba42b45df7a64a6908287f03bfa3764bed in the qemu.git tree
introduced support for emulating a virtio-rng device used to pass-through
entropy to the guests.
Qemu provides two backends to gather entropy from:
1) Default
The check for a broken GCC -Wlogical-op implemententation
was written under the wrong assumption that unknown warning
options would be gracefully ignored.
Thanks to Eric Blake and Daniel Berrange for pointing that
out.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
On 12/19/2012 01:29 PM, Daniel P. Berrange wrote:
I think it depends on what the compiler does with unknown -W flags.
indeed ... I was lead to believe that unknown -W options would be
gracefully tolerated with a warning. But even for GCC this is only
the case for options like -Wno-clue, i.e.
Peter Krempa wrote:
From: Roman Bogorodskiy bogorods...@gmail.com
---
This version incorporates DanPB's idea of checking if setting affinity for all
processors and failing otherwise.
Thanks, this version looks good and works for me.
---
src/util/processinfo.c | 28
On 12/19/12 15:32, Roman Bogorodskiy wrote:
Peter Krempa wrote:
From: Roman Bogorodskiy bogorods...@gmail.com
---
This version incorporates DanPB's idea of checking if setting affinity for all
processors and failing otherwise.
Thanks, this version looks good and works for me.
Great. I
On Wed, Dec 19, 2012 at 11:55:20AM +, Daniel P. Berrange wrote:
Currently the files in src/util are 50/50 split between those
having a 'vir' prefix and those which don't. Finish the job
by remaining all remaining files to have a 'vir' prefix too,
guaranteeing that they can't clash with
On 12/16/12 23:24, Peter Krempa wrote:
On 12/16/12 15:47, Roman Bogorodskiy wrote:
With this set of changes it's now possible to connect
to libvirtd using virsh and start/shutdown domains with
the obvious limitation that networking is not supported at
this point.
CPU affinity most likely
hi every one when i am start windows os using virtual macine manager on redhat
6 os it showing this type of error-Error starting domain: unsupported
configuration: Only PCI device addresses with function=0 are supported with this
QEMU binary
--
libvir-list mailing list
libvir-list@redhat.com
On Wed, Dec 19, 2012 at 11:08:43PM +0800, Daniel Veillard wrote:
On Wed, Dec 19, 2012 at 11:55:20AM +, Daniel P. Berrange wrote:
Currently the files in src/util are 50/50 split between those
having a 'vir' prefix and those which don't. Finish the job
by remaining all remaining files to
On 12/19/2012 07:17 AM, Viktor Mihajlovski wrote:
The check for a broken GCC -Wlogical-op implemententation
was written under the wrong assumption that unknown warning
options would be gracefully ignored.
Thanks to Eric Blake and Daniel Berrange for pointing that
out.
Signed-off-by: Viktor
On 12/19/2012 03:07 AM, Gangadahr Jena wrote:
hi every one when i am start windows os using virtual macine manager on
redhat
Have you considered taking advantage of your Red Hat subscription and
opening a support ticket with them?
6 os it showing this type of error-Error starting domain:
Commit 8b8fcdea introduced a check for broken gcc -Wlogical-op,
but did not guard the check against non-gcc compilers, which might
lead to spurious failures when another compiler encounters an
unknown pragma. Additionally, all of our compiler warning logic
should belong in a single file, and use
Revert the complex workaround of commit 39d91e9, now that we have
a nicer framework for shutting up broken gcc.
* src/util/buf.c (virBufferEscape): Simplify.
---
src/util/buf.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/util/buf.c b/src/util/buf.c
On Wed, Dec 19, 2012 at 12:32:54PM -0700, Eric Blake wrote:
Revert the complex workaround of commit 39d91e9, now that we have
a nicer framework for shutting up broken gcc.
* src/util/buf.c (virBufferEscape): Simplify.
---
src/util/buf.c | 15 ++-
1 file changed, 10
On Wed, Dec 19, 2012 at 12:24:39PM -0700, Eric Blake wrote:
Commit 8b8fcdea introduced a check for broken gcc -Wlogical-op,
but did not guard the check against non-gcc compilers, which might
lead to spurious failures when another compiler encounters an
unknown pragma. Additionally, all of our
On Wed, Dec 19, 2012 at 11:04:38AM +, Daniel P. Berrange wrote:
On Wed, Dec 19, 2012 at 09:59:45AM +, Daniel P. Berrange wrote:
On Wed, Dec 19, 2012 at 10:50:42AM +0100, Guido Günther wrote:
Hi,
it seems one of these commits
5411e7e176dcbb65591cb97ec128b5fd0f365805
On 12/19/2012 12:35 PM, Daniel P. Berrange wrote:
On Wed, Dec 19, 2012 at 12:24:39PM -0700, Eric Blake wrote:
Commit 8b8fcdea introduced a check for broken gcc -Wlogical-op,
but did not guard the check against non-gcc compilers, which might
lead to spurious failures when another compiler
On 12/19/2012 01:43 PM, Guido Günther wrote:
With the fixes I just pushed, I hope this should be working now.
I tested with everything configure option except AppArmor enabled
now.
All back to green. Thanks a lot! I wonder if it would make sense to
automatically forward make and make check
On 12/19/2012 08:08 AM, Daniel Veillard wrote:
On Wed, Dec 19, 2012 at 11:55:20AM +, Daniel P. Berrange wrote:
Currently the files in src/util are 50/50 split between those
having a 'vir' prefix and those which don't. Finish the job
by remaining all remaining files to have a 'vir' prefix
* src/util/buf.c: Use consistent formatting.
---
Pushing under the trivial rule.
src/util/buf.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/util/buf.c b/src/util/buf.c
index e5a6ab7..e5406da 100644
--- a/src/util/buf.c
+++ b/src/util/buf.c
@@
On Wed, Dec 19, 2012 at 02:22:23PM -0700, Eric Blake wrote:
On 12/19/2012 01:43 PM, Guido Günther wrote:
With the fixes I just pushed, I hope this should be working now.
I tested with everything configure option except AppArmor enabled
now.
All back to green. Thanks a lot! I wonder if it
On Wed, Dec 19, 2012 at 09:43:52PM +0100, Guido Günther wrote:
On Wed, Dec 19, 2012 at 11:04:38AM +, Daniel P. Berrange wrote:
On Wed, Dec 19, 2012 at 09:59:45AM +, Daniel P. Berrange wrote:
On Wed, Dec 19, 2012 at 10:50:42AM +0100, Guido Günther wrote:
Hi,
it seems one of
On 12/18/2012 08:14 AM, Benjamin Wang (gendwang) wrote:
Now if the cable is unplugged and the application call virConnectClose to
release connection, the code will enter into the error procedure, the
connection
Can't be released. I have changed the following two parts to fix this issue.
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patch is to enable virSysinfoRead test case for POWER,
and provide sysinfo data on POWER.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
Reviewed-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
tests/sysinfodata/ppccpuinfo.data |
reviewed-by: liguang lig.f...@cn.fujitsu.com
在 2012-12-18二的 15:36 +0100，Michal Privoznik写道：
This just keeps track whether qemu knows nbd-server-* commands
so we can use it during migration or not.
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
2 files
reviewed-by: liguang lig.f...@cn.fujitsu.com
在 2012-12-18二的 15:36 +0100，Michal Privoznik写道：
This migration cookie is meant for two purposes. The first is to be sent
in begin phase from source to destination to let it know we support new
implementation of VIR_MIGRATE_NON_SHARED_{DISK,INC} so
reviewed-by: liguang lig.f...@cn.fujitsu.com
在 2012-12-18二的 15:36 +0100，Michal Privoznik写道：
This will be used with new migration scheme.
This patch creates basically just monitor stub
functions. Wiring them into something useful
is done in later patches.
---
src/qemu/qemu_monitor.c |
From: Li Zhang zhlci...@linux.vnet.ibm.com
On PPC64 platform, it sets USB option in -machine option. It is
set as the following:
-machine pseries,usb=off
This will disable USB, which avoids creating one USB controller
implicitly in the platform's initialization. Libvirt will add one
USB
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patch series is to fix bugs on PowerPC we found when testing
libvirt.
Li Zhang (6):
Set std VGA model as default model for ppc64.
Use -machine option for PPC64
Remove QEMU_CAPS_NO_ACPI capability for non-x86 platform
Support all backend
From: Li Zhang zhlci...@linux.vnet.ibm.com
Cirrus VGA model is not supported on ppc64 currently.
It needs to set std VGA model as the default model.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/conf/domain_conf.c |2 ++
1 file changed, 2 insertions(+)
diff --git
From: Li Zhang zhlci...@linux.vnet.ibm.com
Currently, it only considers PTY backend serial devices for pseries.
It need to support all kinds of serial devices.
This patch is to fix the problem which is that it doesn't work
when specifying source type as file.
Signed-off-by: Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com
ACPI is only supported on x86 platform, PPC can't support it.
So QEMU_CAPS_NO_ACPI shouldn't be set.
This patch is to remove QEMU_CAPS_NO_ACPI capability for
non-x86 platform.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
From: Li Zhang zhlci...@linux.vnet.ibm.com
pseries machine type is preferred for ppc64.
This patch is to set pseries as the default machine type.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/conf/capabilities.c |6 ++
1 file changed, 6 insertions(+)
diff --git
From: Li Zhang zhlci...@linux.vnet.ibm.com
QEMU of upstream and PPC64 can support -device driver,?,
But the help string is -device driver,help,
This patch is to replace -device driver,? with -device driver,.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
src/qemu/qemu_capabilities.c |
77 matches
Mail list logo
