On 01/04/13 18:29, Eric Blake wrote:
Based on a suggestion by John Ferlan:
https://www.redhat.com/archives/libvir-list/2013-January/msg00158.html
* docs/hacking.html.in: Add some commit message instructions.
Mention the ./run script.
* HACKING: Regenerate.
---
I don't know how to make docs/hack
On 01/10/2013 08:00 PM, Dan Kenigsberg wrote:
On Thu, Jan 10, 2013 at 10:45:42AM +0800, Mark Wu wrote:
On 01/08/2013 10:46 PM, Yaniv Kaul wrote:
On 08/01/13 15:04, Dan Kenigsberg wrote:
There's talk about this for ages, so it's time to have proper discussion
and a feature page about it: let us
On 01/11/13 01:40, Eric Blake wrote:
I've noticed a number of people sending patches with file
renames not compressed, so we might as well document how to
set this up. (Git won't do it by default, for back-compat
reasons)
* docs/hacking.html.in: Add git config tip.
* HACKING: Regenerate.
---
On 01/11/13 07:31, Chunyan Liu wrote:
This patch series is to add PCI passthrough support to libxenlight driver so
that
it can create VM with managed/non-managed host pci device defined.
Chunyan Liu (2):
libxl: add APIs to prepare/release host pci device
libxl: support pci passthrough
On 01/11/13 07:01, Parakkal, Navin S wrote:
Hi,
I’m using qemu+ssh://username@hostname/system as the remote URI. Libvirt
seems to be communicating fine until some 2 minutes (we poll every 5
seconds) and then it throws up RPC error and many counters are wrong.
But if I collect on localhost the co
This patch series is to add PCI passthrough support to libxenlight driver so
that
it can create VM with managed/non-managed host pci device defined.
Chunyan Liu (2):
libxl: add APIs to prepare/release host pci device
libxl: support pci passthrough
po/POTFILES.in|1 +
src/Mak
Support PCI passthrough in libxl driver.
Signed-off-by: Chunyan Liu
---
src/libxl/libxl_conf.c | 44
src/libxl/libxl_conf.h |5 -
src/libxl/libxl_driver.c | 16
3 files changed, 64 insertions(+), 1 deletions(-)
diff
Handle preparing and releasing host pci devices for PCI passthrough. Preparing
host pci devices will be used before vm is started, while releasing (or,
reattaching) will be used after vm is shut off.
Code refers to qemu driver, so add Red Hat copyright.
Signed-off-by: Chunyan Liu
---
po/POTFILE
Hi,
Does the transport have any configuration file to throttle the
connections through ssh made from a client ?
The logs are huge even after compressing(5MB). Is there a site
where I can upload this to ?
Regards,
Navin
-Original Message-
From: Pete
On Fri, Jan 11, 2013 at 08:36:46AM +0900, Kamezawa Hiroyuki wrote:
> (2013/01/09 23:16), Michal Privoznik wrote:
> >On 09.01.2013 12:01, Gao feng wrote:
> >>when we has no host's src mapped to container.
> >>there is no .oldroot dir,so libvirt lxc will fail
> >>to start when mouting meminfo.
> >>
>
On Thu, Jan 10, 2013 at 02:00:57PM +0200, Dan Kenigsberg wrote:
> vdsm-vdsm and libvirt-libvirt communication is authenticated, but I am
> not sure at all that qemu-qemu communication is.
>
> After qemu is sprung up on the destination with
> -incoming : , anything with access to that
> address
On 11.01.2013 09:34, Peter Krempa wrote:
> On 01/11/13 01:40, Eric Blake wrote:
>> I've noticed a number of people sending patches with file
>> renames not compressed, so we might as well document how to
>> set this up. (Git won't do it by default, for back-compat
>> reasons)
>>
>> * docs/hacking.
On Thu, Jan 10, 2013 at 03:20:27PM -0700, Eric Blake wrote:
> On 01/10/2013 01:18 PM, Daniel P. Berrange wrote:
> > +
> > + if test $fail = 1; then
> > +AC_MSG_ERROR([You must install the lib]library_name[ library & headers
> > to compile libvirt])
>
> It would be really nice if you could r
On Thu, Jan 10, 2013 at 12:41:50PM +0100, Jiri Denemark wrote:
> Hi all.
>
> Graphics relocation URI is currently transmitted within migration cookie
> in the form of graphics type, address, port, tlsPort, and certificate
> subject. The cookie is generated by target libvirtd and consumed by
> sour
This is a follow-on series from
https://www.redhat.com/archives/libvir-list/2013-January/msg00647.html
It converts all the remaining easy library/package checks to
use the new helper macros. What's let are some tricky cases
where we first check via pkg-config and then fallback to a
manual check
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 4 ++--
src/lxc/lxc_container.c | 2 +-
src/storage/storage_backend.c | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index f2b59ef..b50e
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 53 -
m4/virt-numactl.m4 | 26 ++
2 files changed, 30 insertions(+), 49 deletions(-)
create mode 100644 m4/virt-numactl.m4
diff --g
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac| 70 +++--
m4/virt-apparmor.m4 | 42
2 files changed, 46 insertions(+), 66 deletions(-)
create mode 100644 m4/virt-apparmor.m4
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 34 ++
m4/virt-avahi.m4 | 26 ++
2 files changed, 28 insertions(+), 32 deletions(-)
create mode 100644 m4/virt-avahi.m4
diff --git a/configure.ac b/confi
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 62 ++
m4/virt-selinux.m4 | 51
2 files changed, 53 insertions(+), 60 deletions(-)
create mode 100644 m4/virt-s
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 4 ++--
src/nwfilter/nwfilter_driver.c | 4 ++--
src/util/virdbus.c | 7 +++
src/util/virdbus.h | 2 +-
4 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/co
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac| 34 ++
m4/virt-dbus.m4 | 36
2 files changed, 38 insertions(+), 32 deletions(-)
create mode 100644 m4/virt-dbus.m4
diff --git a/configure.ac
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 4 ++--
src/lxc/lxc_container.c | 4 ++--
src/lxc/lxc_controller.c | 4 ++--
src/util/vircommand.c| 4 ++--
src/util/virutil.c | 2 +-
5 files changed, 9 insertions(+), 9 deletions(-)
diff --
From: "Daniel P. Berrange"
---
configure.ac | 4 ++--
src/libvirt.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index d7b6810..a1c80c1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1871,9 +1871,9 @@ if test "$with_esx" = "yes" || test
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 4 ++--
src/rpc/virnetservermdns.c | 12 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index 8a5a513..c88162e 100644
--- a/configure.ac
+++ b/
From: "Daniel P. Berrange"
---
configure.ac| 71 -
m4/virt-curl.m4 | 27 ++
2 files changed, 52 insertions(+), 46 deletions(-)
create mode 100644 m4/virt-curl.m4
diff --git a/configure.ac b/configure.ac
index a1c80
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 4 ++--
src/Makefile.am | 6 +++---
src/interface/interface_driver.c | 4 ++--
src/node_device/node_device_driver.c | 4 ++--
src/node_device/node_device_driver.h | 2
From: "Daniel P. Berrange"
This converts the libssh2 configure check to use LIBVIRT_CHECK_PKG.
Previously it would check version 1.0 and 1.3, but this simplifies
things to just require version 1.3
---
configure.ac| 70 +++--
libvirt.spec.in
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 8
src/Makefile.am | 6 +++---
src/lxc/lxc_container.c | 8
src/storage/storage_backend_fs.c | 8
4 files changed, 15 insertions(+), 15 deleti
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 57
m4/virt-pciaccess.m4 | 26
m4/virt-udev.m4 | 32 +
3 files changed, 62 insertions(+), 53 del
From: "Daniel P. Berrange"
---
configure.ac | 4 ++--
daemon/libvirtd.c | 14 +++---
daemon/remote.c | 2 +-
src/Makefile.am | 2 +-
src/libvirt.c | 8
src/locking/lock_daemon.c | 4 ++--
src/lxc/l
From: "Daniel P. Berrange"
---
configure.ac| 4 ++--
src/lxc/lxc_container.c | 2 +-
src/lxc/lxc_fuse.c | 2 +-
src/lxc/lxc_fuse.h | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index cd00899..313b6dc 100644
--- a/configur
From: "Daniel P. Berrange"
---
configure.ac| 33 ++---
m4/virt-fuse.m4 | 27 +++
2 files changed, 29 insertions(+), 31 deletions(-)
create mode 100644 m4/virt-fuse.m4
diff --git a/configure.ac b/configure.ac
index 313b6dc..d7b6810 100644
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 47 ++-
m4/virt-hal.m4 | 26 ++
2 files changed, 28 insertions(+), 45 deletions(-)
create mode 100644 m4/virt-hal.m4
diff --git a/configure.ac
From: "Daniel P. Berrange"
---
configure.ac | 31 +--
m4/virt-openwsman.m4 | 27 +++
2 files changed, 40 insertions(+), 18 deletions(-)
create mode 100644 m4/virt-openwsman.m4
diff --git a/configure.ac b/configure.ac
index e8ccdb5..9b
From: "Daniel P. Berrange"
---
configure.ac | 4 ++--
src/Makefile.am| 4 ++--
src/rpc/virnetsocket.c | 18 +-
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/configure.ac b/configure.ac
index 85444cf..6c413d8 100644
--- a/configure.ac
+++ b/c
This patchset fixes various non-related issues with libvirt networking:
Peter Krempa (3):
network: bridge: Fix regression when defining persistent networks
virsh: Reformat output of virsh net-list
network: Report real error if addition of firewall rules fails
src/network/bridge_driver.c |
Commit 0211fd6e04cdc402da20818df54299c6ded3d3cb introduced regression
where newly defined networks were not made persistent.
This patch makes the network persistent on each successful definition.
---
src/network/bridge_driver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/network/br
This patch changes whitespace and the length of the separation line from
this format:
$ virsh net-list --all
Name State Autostart Persistent
--
default inactive yes yes
to
$ virsh net-list --all
Na
If addition of rules in networkAddIptablesRules() failed the real error
was masked by error reported when trying to clean up the remaining
rules.
With this patch the original error message is saved and set back after
the removal is complete.
---
src/network/bridge_driver.c | 7 +++
1 file cha
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 4 ++--
docs/hacking.html.in | 2 +-
src/lxc/lxc_controller.c | 4 ++--
src/nodeinfo.c | 10 +-
src/qemu/qemu_process.c | 4 ++--
5 files changed, 12 insertions(+), 12 deletion
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 42 ++
m4/virt-netcf.m4 | 40
2 files changed, 42 insertions(+), 40 deletions(-)
create mode 100644 m4/virt-netcf.m4
diff --git
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 46 ++
m4/virt-capng.m4 | 26 ++
2 files changed, 28 insertions(+), 44 deletions(-)
create mode 100644 m4/virt-capng.m4
diff --git a/configur
From: "Daniel P. Berrange"
---
configure.ac | 1 -
1 file changed, 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 9b31ca8..a82c75d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -100,7 +100,6 @@ LIBXML_REQUIRED="2.6.0"
GNUTLS_REQUIRED="1.0.25"
POLKIT_REQUIRED="0.6"
PARTED_REQU
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 4 ++--
src/Makefile.am | 2 +-
src/node_device/node_device_driver.c | 6 +++---
src/node_device/node_device_driver.h | 2 +-
4 files changed, 7 insertions(+), 7 deletion
From: "Daniel P. Berrange"
Signed-off-by: Daniel P. Berrange
---
configure.ac | 22 ++
m4/virt-blkid.m4 | 26 ++
2 files changed, 28 insertions(+), 20 deletions(-)
create mode 100644 m4/virt-blkid.m4
diff --git a/configure.ac b/configure.ac
inde
From: "Daniel P. Berrange"
---
configure.ac | 14 +++---
daemon/Makefile.am | 6 +++---
daemon/libvirtd-config.c | 6 +++---
daemon/remote.c| 10 +-
src/remote/remote_driver.c | 16
5 files changed, 26 insertions(+), 26 delet
Hi.
Patch #1 just simplifies the code a bit. This requires python
2.2.3. Is that OK?
Patch #2 fixes an issue with parsing top level comments.
Looking at the libvirt HTML output, you can see that the license text
at the top of the file ends prematurely.
This happens because the "https://www.red
Signed-off-by: Claudio Bley
---
docs/apibuild.py | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/docs/apibuild.py b/docs/apibuild.py
index 7b336b3..63b21e1 100755
--- a/docs/apibuild.py
+++ b/docs/apibuild.py
@@ -654,17 +654,11 @@ class CParser:
lines =
When parsing the top level comment of a file, apibuild.py used
to split on any ':' character of a line regarding the first part
as a key for a setting, e.g. "Summary". The second part would then
be assigned as the value for that key.
This means you could not use a ':' character inside those commen
From: "Daniel P. Berrange"
Currently all classes must directly inherit from virObject.
This allows for arbitrarily deep hierarchy. There's not much
too this aside from chaining up the 'dispose' handlers from
each class & providing APIs to check types.
---
src/conf/domain_conf.c| 3 +-
s
From: "Daniel P. Berrange"
A great many virObject instances require a mutex, so introduce
a convenient class for this which provides a mutex. This avoids
repeating the tedious init/destroy code
---
src/libvirt_private.syms | 4 +++
src/util/virobject.c | 87 +
Both QEMU and libxl have the same code for tracking auto-allocated
VNC ports. Move this code out into src/util/virportallocator.[c,h].
While doing this turn it into a virObjectLockable so that it becomes
a ref-counted object with self-contained locking. This means it no
longer needs to be protected
From: "Daniel P. Berrange"
Introduce a virPortAllocator for managing TCP port allocations.
---
.gitignore | 1 +
src/Makefile.am | 1 +
src/libvirt_private.syms | 6 ++
src/util/virportallocator.c | 188 +
src/util
From: "Daniel P. Berrange"
Replace the current libxl driver code for managing port
reservations with the new virPortAllocator APIs.
---
src/libxl/libxl_conf.c | 62
src/libxl/libxl_conf.h | 4 ++--
src/libxl/libxl_driver.c | 13 +-
3
From: "Daniel P. Berrange"
Replace the current QEMU driver code for managing port
reservations with the new virPortAllocator APIs.
---
src/qemu/qemu_conf.h| 4 +-
src/qemu/qemu_driver.c | 9 ++--
src/qemu/qemu_process.c | 100
src
On 11.01.2013 12:09, Peter Krempa wrote:
> This patchset fixes various non-related issues with libvirt networking:
>
> Peter Krempa (3):
> network: bridge: Fix regression when defining persistent networks
> virsh: Reformat output of virsh net-list
> network: Report real error if addition of
On 01/11/13 13:49, Michal Privoznik wrote:
On 11.01.2013 12:09, Peter Krempa wrote:
This patchset fixes various non-related issues with libvirt networking:
Peter Krempa (3):
network: bridge: Fix regression when defining persistent networks
virsh: Reformat output of virsh net-list
netwo
The api builder always associates comments to the last member it read,
not to the current member even if there was a comment for the previous
member and a comma was already seen.
This has the effect that the comment for the previous member gets
overwritten and the current member has no comment at
Hi,
I just wanted to build the latest libvirt-java master on my Ubuntu 12.04
laptop and it failed due to this commit.
The commit message says: "Use JNA's Native.free() method to free memory.
This requires JNA version 3.3.0 or later."
Ubuntu 12.04 comes with JNA 3.2.7-4, so the build fails.
The way in that memory balloon suppression was handled for S390
is flawed for a number or reasons.
1. Just preventing the default balloon to be created in the case
of VIR_ARCH_S390[X] is not sufficient. An explicit memballoon
element in the guest definition will still be honored, resulting
Hi.
The following patch's intend is to get a discussion started first.
Rationale:
Many functions in libvirt return "1 for , 0 for and -1
on ".
When calling a function you need to read the documentation, skipping
to the "Returns:" text in order to determine what return values to
expect from the
Signed-off-by: Claudio Bley
---
include/libvirt/libvirt.h.in | 25 +
python/generator.py | 16
src/libvirt.c|8
3 files changed, 41 insertions(+), 8 deletions(-)
diff --git a/include/libvirt/libvirt.h.in b/includ
On 11 Jan 2013, at 12:00, Daniel P. Berrange wrote:
> On Thu, Jan 10, 2013 at 12:41:50PM +0100, Jiri Denemark wrote:
>> Hi all.
>>
>> Graphics relocation URI is currently transmitted within migration cookie
>> in the form of graphics type, address, port, tlsPort, and certificate
>> subject. The
On Fri, Jan 11, 2013 at 04:40:31PM +0100, Claudio Bley wrote:
> Hi.
>
> The following patch's intend is to get a discussion started first.
>
> Rationale:
>
> Many functions in libvirt return "1 for , 0 for and -1
> on ".
>
> When calling a function you need to read the documentation, skipping
On Thu, Jan 10, 2013 at 12:35 AM, Zeeshan Ali (Khattak)
wrote:
> From: "Zeeshan Ali (Khattak)"
>
> Also a utility method to check if connection is open in read-only mode.
> ---
Ping?
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
--
libvir-list mailing list
libvir-list@redhat.com
https://
On Thu, Jan 10, 2013 at 12:35:07AM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)"
>
> Also a utility method to check if connection is open in read-only mode.
> ---
> libvirt-gobject/libvirt-gobject-connection.c | 109
> ---
> libvirt-gobject/libvirt-
[raising this UI wart to the git list]
On 01/11/2013 01:42 AM, Peter Krempa wrote:
> On 01/11/13 07:31, Chunyan Liu wrote:
>> This patch series is to...
[snip]
>
> Please don't answer "y" when git send email shows the following prompt:
>
> "Message-ID to be used as In-Reply-To for the first ema
Commit f8d478b6dfc46a0ad2459844b96937599dec06e1 broke the grouping by
five items.
---
Pushed under the trivial rule.
---
src/qemu/qemu_capabilities.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 25e8951..b16
This patch set re-implements migration with storage for enough new qemu.
Currently, you can migrate a domain to a host without need for shared storage.
This is done by setting 'blk' or 'inc' attribute (representing
VIR_MIGRATE_NON_SHARED_DISK and VIR_MIGRATE_NON_SHARED_INC flags respectively)
of 'm
This will be used with new migration scheme.
This patch creates basically just monitor stub
functions. Wiring them into something useful
is done in later patches.
---
src/qemu/qemu_monitor.c | 22 ++
src/qemu/qemu_monitor.h | 3 +++
src/qemu/qemu_monitor_json.c | 25
We need to start NBD server and feed it with all non- disks.
However, after qemuDomainObjEnterMonitorAsync the domain object
is unlocked so we cannot touch its disk definitions. Therefore,
we must prepare the list of disk IDs prior entering monitor.
---
src/qemu/qemu_migration.c | 59 +
This just keeps track whether qemu knows nbd-server-* commands
so we can use it during migration or not.
---
src/qemu/qemu_capabilities.c | 4 +++-
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabil
This will be used after all migration work is done
to stop NBD server running on destination. It
doesn't take any arguments, just issues a command.
---
src/qemu/qemu_monitor.c | 19 +++
src/qemu/qemu_monitor.h | 1 +
src/qemu/qemu_monitor_json.c | 21 +++
This migration cookie is meant for two purposes. The first is to be sent
in begin phase from source to destination to let it know we support new
implementation of VIR_MIGRATE_NON_SHARED_{DISK,INC} so destination can
start NBD server. Then, the second purpose is, destination can let us
know, on whic
With new NBD storage migration approach there are several
requirements that need to be meet for successful use of
the feature. One of them is - the file representing a disk,
needs to have at least same size as on the source. Hence,
we must transfer a list of pairs [disk source, size] and
check on d
This is a stub internal API just for now. Its purpose
in life is to start NBD server and feed it with all
domain disks. When adding a disk to NBD server, it
is addressed via its alias (id= param on qemu command line).
---
src/qemu/qemu_migration.c | 46 +++--
There's a code snippet which allocates a port for incoming
migration. We will need this for allocating a port for
incoming disks as well. Hence, move this snippet into
a separate function called qemuMigrationNextPort().
---
src/qemu/qemu_migration.c | 19 +--
1 file changed, 13 ins
This function does the source part of NBD magic.
It invokes drive-mirror on each non shared disk
and wait till the mirroring process completes.
When it does we can proceed with migration.
Currently, an active waiting is done: every 50ms
libvirt asks qemu if block-job is finished or not.
However, o
At the end of migration, it is important to stop NBD
server and thus release all allocated resources.
---
src/qemu/qemu_migration.c | 28
1 file changed, 28 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 86eb4c8..a1372ed 100644
This will be used with new migration scheme.
This patch creates basically just monitor stub
functions. Wiring them into something useful
is done in later patches.
---
src/qemu/qemu_monitor.c | 22
src/qemu/qemu_monitor.h | 3 +++
src/qemu/qemu_monitor_json.c | 49 ++
With this change it's easy to spot a forgotten free if a new device
class is added.
---
src/conf/domain_conf.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6feded4..f4875f5 100644
--- a/src/conf/domain_conf.c
+++
This patch documments XML elements used for (basic) support of virtual
RNG devices.
In the devices section in the domain XML users may specify:
and the more useful variant:
/dev/urandom
---
docs/formatdomain.html.in | 54
This patch adds basic configuration support for the RNG device suporting
the virtio model with the "random" backend type.
---
src/conf/domain_conf.c | 148 ++-
src/conf/domain_conf.h | 36
src/libvirt_private.syms | 2 +
3 files chang
This patch implements support for the virtio-rng-pci device and the
rng-random backend in qemu.
Two capabilities bits are added to track support for those:
QEMU_CAPS_DEVICE_VIRTIO_RNG - for the device support and
QEMU_CAPS_OBJECT_RNG_RANDOM - for the backend support.
---
src/qemu/qemu_capabiliti
On 01/11/2013 03:37 AM, Daniel P. Berrange wrote:
> On Thu, Jan 10, 2013 at 03:20:27PM -0700, Eric Blake wrote:
>> On 01/10/2013 01:18 PM, Daniel P. Berrange wrote:
>
>>> +
>>> + if test $fail = 1; then
>>> +AC_MSG_ERROR([You must install the lib]library_name[ library & headers
>>> to compil
This patchset implements very basic functionality that will allow to use the
virtio-rng device. I will follow up later with more advanced sections of this
support as I have to figure out how hotplug of the qom backend device could
work in qemu.
I'm posting this so we can settle on the naming sche
On 01/11/2013 04:05 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Signed-off-by: Daniel P. Berrange
> ---
> configure.ac | 4 ++--
> src/lxc/lxc_container.c | 2 +-
> src/storage/storage_backend.c | 6 +++---
> 3 files changed, 6 insertions(+), 6 deletion
On Fri, Jan 11, 2013 at 10:01:45AM -0700, Eric Blake wrote:
> On 01/11/2013 03:37 AM, Daniel P. Berrange wrote:
> > On Thu, Jan 10, 2013 at 03:20:27PM -0700, Eric Blake wrote:
> >> On 01/10/2013 01:18 PM, Daniel P. Berrange wrote:
> >
> >>> +
> >>> + if test $fail = 1; then
> >>> +AC_MSG_ERRO
On 01/11/2013 04:20 AM, Claudio Bley wrote:
> Hi.
>
> Patch #1 just simplifies the code a bit. This requires python
> 2.2.3. Is that OK?
Our current requirement for how old we must support is that we must
still build on the latest RHEL 5 (or CentOS 5) environment (RHEL 5.9 was
released earlier th
Commit 321a7d53 missed a spot.
* src/rpc/virnetsocket.c (virNetSocketPreExecRestart): Use right
conditional.
---
Pushing under the build-breaker rule.
src/rpc/virnetsocket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
i
On 01/11/2013 01:31 AM, Peter Krempa wrote:
>> +There is also a ./run script at the top level,
>> + to make it easier to run uninstalled programs, as well as to
>
> "uninstalled" sounds to me as if I'd just remove them from my system.
> I'd change that to "programs that have not
On 01/11/2013 01:34 AM, Peter Krempa wrote:
>
> It might also be beneficial to instruct the users to use the patience
> algorithm for diffs (especially when moving chunks of code around).
Indeed.
>
> ACK as is.
I tweaked before pushing:
diff --git i/docs/hacking.html.in w/docs/hacking.html.in
On Fri, Jan 11, 2013 at 09:39:06AM -0700, Eric Blake wrote:
> > Please don't answer "y" when git send email shows the following prompt:
> >
> > "Message-ID to be used as In-Reply-To for the first email?"
> >
> > you should respond with a message ID there. Unfortunately we have a
> > growing thre
On 01/11/2013 09:47 AM, Jeff King wrote:
> On Fri, Jan 11, 2013 at 09:39:06AM -0700, Eric Blake wrote:
>
>>> Please don't answer "y" when git send email shows the following prompt:
>>>
>>
>> Anyone willing to patch upstream 'git send-email' to reject a simple 'y'
> What version of git? Commit 51
Instead of checking the limit before calling numa_add(), check the limit
only when we already know we're going to add a new node.
Signed-off-by: Eduardo Habkost
---
vl.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 94cc6fd..2c3bbb9 100644
--- a/v
This series contains the following:
* Patches 1-7 are multiple bug fixes to the current code
* Patch 8 introduce a feature that libvirt requires since a long time,
and even tries to use it today (in a way that doesn't work,
using the "-numa node,cpus=1,2,3,4" format): having non-contiguous
Instead of silently ignoring them, abort in case an invalid -numa option
is provided.
Signed-off-by: Eduardo Habkost
---
vl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/vl.c b/vl.c
index 93fde36..042cc7f 100644
--- a/vl.c
+++ b/vl.c
@@ -1101,6 +1101,9 @@ static void numa_add(const ch
Without this check, qemu-kvm will corrupt memory if a too-large nodeid
is provided in the command-line. e.g.:
-numa node,mem=...,cpus=...,nodeid=65
Signed-off-by: Eduardo Habkost
---
vl.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/vl.c b/vl.c
index 19010fa..31175f6 100644
--- a/
The numa_add() code was unconditionally adding 1 to the get_opt_name()
return value, making it point after the end of the string if no ','
separator is present.
Example of weird behavior caused by the bug:
$ qemu-img create -f qcow2
this-file-image-has,cpus=5,mem=1000,in-its-name.qcow2 5G
Fo
1 - 100 of 150 matches
Mail list logo
