Re: [libvirt] [rebased][PATCH 2/4] build command line for pci-bridge device of qemu

2013-02-14 Thread li guang
在 2013-02-05二的 17:53 +0100，Ján Tomko写道： > On 01/30/13 03:30, liguang wrote: > > @@ -974,8 +967,24 @@ static char > > *qemuPCIAddressAsString(virDomainDeviceInfoPtr dev) > > return addr; > > } > > > > +static int qemuPciBridgeSupport(virDomainDefPtr def) > > +{ > > +int i, c = 0; > > +

Re: [libvirt] [rebased][PATCH 1/4] add pci-bridge controller type

2013-02-14 Thread li guang
sorry for late reply. 在 2013-02-05二的 16:56 +，Daniel P. Berrange写道： > On Tue, Feb 05, 2013 at 05:53:30PM +0100, Ján Tomko wrote: > > On 01/30/13 03:30, liguang wrote: > > > @@ -4493,6 +4494,8 @@ virDomainControllerDefParseXML(xmlNodePtr node, > > > goto error; > > > > > > switch

Re: [libvirt] [rebased][PATCH 1/4] add pci-bridge controller type

2013-02-14 Thread li guang
sorry for late reply. 在 2013-02-05二的 17:53 +0100，Ján Tomko写道： > On 01/30/13 03:30, liguang wrote: > > @@ -4493,6 +4494,8 @@ virDomainControllerDefParseXML(xmlNodePtr node, > > goto error; > > > > switch (def->type) { > > +case VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE: > > +

Re: [libvirt] Support for Hyper-V

2013-02-14 Thread Ata Bohra
Hi Hassan, I'm too experimenting Libvirt management strenghts when it comes to HyperV server, my findings so far are:1. It uses openwsman library to issue WS-man calls to HyperV server. HYperV server accepts WMI calls generated by openwsman library to send request to server and decode the respo

Re: [libvirt] [PATCH] [nwfilter] Fix libvirt upgrade path when nwfilter is used

2013-02-14 Thread Laine Stump
On 02/14/2013 06:26 PM, Stefan Berger wrote: > Between revision 65fb9d49 and before this patch, an upgrade of libvirt > while > VMs are running and instantiating iptables filtering rules due to > nwfilter > rules, may leave stray iptables rules behind when shutting VMs down. > Left-over iptables ru

[libvirt] [PATCH] [nwfilter] Fix libvirt upgrade path when nwfilter is used

2013-02-14 Thread Stefan Berger
Between revision 65fb9d49 and before this patch, an upgrade of libvirt while VMs are running and instantiating iptables filtering rules due to nwfilter rules, may leave stray iptables rules behind when shutting VMs down. Left-over iptables rules may look like this: Chain FP-vnet0 (1 references) t

Re: [libvirt] [TCK] [PATCH] Add --physdev-is-bridged to test cases

2013-02-14 Thread Stefan Berger
On 02/14/2013 05:25 PM, Stefan Berger wrote: On 01/24/2013 12:48 PM, Laine Stump wrote: On 01/24/2013 11:34 AM, Stefan Berger wrote: Follow recent changes in libvirt and add --physdev-is-bridged to test cases where needed. ACK. (Does this mean that new libvirt-tck will fail when run against an

Re: [libvirt] [TCK] [PATCH] Add --physdev-is-bridged to test cases

2013-02-14 Thread Stefan Berger
On 01/24/2013 12:48 PM, Laine Stump wrote: On 01/24/2013 11:34 AM, Stefan Berger wrote: Follow recent changes in libvirt and add --physdev-is-bridged to test cases where needed. ACK. (Does this mean that new libvirt-tck will fail when run against an older libvirt, though?) I hadn't seen this

Re: [libvirt] [TCK] [PATCH] Add --physdev-is-bridged to test cases

2013-02-14 Thread Eric Blake
On 02/14/2013 03:04 PM, Stefan Berger wrote: > On 01/24/2013 11:34 AM, Stefan Berger wrote: >> Follow recent changes in libvirt and add --physdev-is-bridged to test >> cases where needed. > > This gets a lot of test cases passing again after the change in libvirt. > > Anyone got a spare ACK? Loo

Re: [libvirt] [TCK] [PATCH] Add --physdev-is-bridged to test cases

2013-02-14 Thread Stefan Berger
On 01/24/2013 11:34 AM, Stefan Berger wrote: Follow recent changes in libvirt and add --physdev-is-bridged to test cases where needed. This gets a lot of test cases passing again after the change in libvirt. Anyone got a spare ACK? Stefan -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v4 1/2] net: support set public ip range for forward mode nat

2013-02-14 Thread Laine Stump
On 02/11/2013 09:54 AM, Natanael Copa wrote: > Support setting which public ip to use for NAT via attribute > address in subelement in : > > ... > > > > ... > > This will construct an iptables line using: > > '-j SNAT --to-source -' > > instead of: > > '-j MASQUERADE' > > Signed-o

Re: [libvirt] [PATCH 2/5] commandtest: Resolve some coverity resource leaks

2013-02-14 Thread John Ferlan
On 02/14/2013 12:43 PM, Eric Blake wrote: > On 02/14/2013 10:15 AM, Peter Krempa wrote: >> On 02/14/13 17:42, John Ferlan wrote: >>> --- >>> tests/commandtest.c | 17 - >>> 1 file changed, 12 insertions(+), 5 deletions(-) >>> >>> diff --git a/tests/commandtest.c b/tests/commandte

Re: [libvirt] Out of Memory Error

2013-02-14 Thread varun bhatnagar
Thank you so much for the reply and for sharing the patch...I will try this tomorrow and then let you know whether it works or not.And i'll try removing the tag too. Thank you again for the help :) On Thu, Feb 14, 2013 at 2:11 PM, Jiri Denemark wrote: > On Thu, Feb 14, 2013 at 01:2

[libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-02-14 Thread Dusty Mabe
Hi, This is a follow up to a previous proposed patch that added NUMA memory and CPU thread siblings information to virsh capabilities outout (https://www.redhat.com/archives/libvir-list/2012-November/msg00449.html) Since in a recent commit the thread siblings information was added (http://libv

[libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-02-14 Thread Dusty Mabe
--- docs/schemas/capability.rng | 10 src/conf/capabilities.c | 8 +++ src/conf/capabilities.h | 2 + src/nodeinfo.c| 64 +- src/test/test_driver.c| 2 +- src/xen/xend_inte

Re: [libvirt] [PATCH 2/5] commandtest: Resolve some coverity resource leaks

2013-02-14 Thread Eric Blake
On 02/14/2013 10:15 AM, Peter Krempa wrote: > On 02/14/13 17:42, John Ferlan wrote: >> --- >> tests/commandtest.c | 17 - >> 1 file changed, 12 insertions(+), 5 deletions(-) >> >> diff --git a/tests/commandtest.c b/tests/commandtest.c >> index 93c6333..3bfc358 100644 >> --- a/tes

Re: [libvirt] [PATCH 2/5] commandtest: Resolve some coverity resource leaks

2013-02-14 Thread Eric Blake
On 02/14/2013 09:42 AM, John Ferlan wrote: > --- > tests/commandtest.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/tests/commandtest.c b/tests/commandtest.c > index 93c6333..3bfc358 100644 > --- a/tests/commandtest.c > +++ b/tests/commandtest.c > @@

Re: [libvirt] [PATCH 2/5] commandtest: Resolve some coverity resource leaks

2013-02-14 Thread Peter Krempa
On 02/14/13 17:42, John Ferlan wrote: --- tests/commandtest.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index 93c6333..3bfc358 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c ... @@ -963,16 +9

Re: [libvirt] [PATCH 1/5] drivermodule: Ignore coverity warning about leaked_storage

2013-02-14 Thread Peter Krempa
On 02/14/13 17:42, John Ferlan wrote: --- tests/virdrivermoduletest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/virdrivermoduletest.c b/tests/virdrivermoduletest.c index de8cf70..bbceb96 100644 --- a/tests/virdrivermoduletest.c +++ b/tests/virdrivermoduletest.c @@ -39,10 +39,

Re: [libvirt] [PATCH 5/5] security: Remove unnecessary checks for mgr == NULL

2013-02-14 Thread Peter Krempa
On 02/14/13 17:42, John Ferlan wrote: Coverity found the DACGenLabel was checking for mgr == NULL after a possible dereference; however, in order to get into the function the virSecurityManagerGenLabel would have already dereferenced sec_managers[i] so the check was unnecessary. Same check is mad

Re: [libvirt] [PATCH] Add support for qxl.revision in domain XML

2013-02-14 Thread Martin Kletzander
On 02/04/2013 04:16 PM, Christophe Fergeau wrote: > QXL devices have an associated 'revision' which is raised when > new features have been introduced which would break migration > to older versions. This commit makes it possible to set this > revision as QEMU sometimes support newer QXL revisions

Re: [libvirt] [PATCH 4/5] virsh: Resolve possible NULL dereference

2013-02-14 Thread Peter Krempa
On 02/14/13 17:42, John Ferlan wrote: Coverity found that commit '41b5e845' had a possible NULL dereference on arg->data processing --- tools/virsh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4f75e8e..f5a01b3 100644 --- a/tools/

Re: [libvirt] [PATCH 3/5] vircommand: Remove unnecessary sa_assert

2013-02-14 Thread Peter Krempa
On 02/14/13 17:42, John Ferlan wrote: Changes from commit '3178df9a' removed the need for the sa_assert(infd). --- src/util/vircommand.c | 3 --- 1 file changed, 3 deletions(-) ACK. I'm not able to verify if it's not needed anymore but it doesn't break the code. Peter -- libvir-list mai

[libvirt] [PATCH 3/5] vircommand: Remove unnecessary sa_assert

2013-02-14 Thread John Ferlan
Changes from commit '3178df9a' removed the need for the sa_assert(infd). --- src/util/vircommand.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 5837fee..aa3bce0 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -1853,9 +1

[libvirt] [PATCH 4/5] virsh: Resolve possible NULL dereference

2013-02-14 Thread John Ferlan
Coverity found that commit '41b5e845' had a possible NULL dereference on arg->data processing --- tools/virsh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4f75e8e..f5a01b3 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1,7 +1,7 @

[libvirt] [PATCH 5/5] security: Remove unnecessary checks for mgr == NULL

2013-02-14 Thread John Ferlan
Coverity found the DACGenLabel was checking for mgr == NULL after a possible dereference; however, in order to get into the function the virSecurityManagerGenLabel would have already dereferenced sec_managers[i] so the check was unnecessary. Same check is made in SELinuxGenSecurityLabel. --- src/s

[libvirt] [PATCH 0/5] Clean up after recent Coverity scan

2013-02-14 Thread John Ferlan
This is the last round of cleanup with a few Coverity errors from the tests trees and a couple that just showed up in my recent scans within security and virsh. The commandtest still has Valgrind errors, but errors are not new to this change. After this round of Coverity changes, the only remainin

[libvirt] [PATCH 2/5] commandtest: Resolve some coverity resource leaks

2013-02-14 Thread John Ferlan
--- tests/commandtest.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index 93c6333..3bfc358 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c @@ -680,7 +680,7 @@ static int test17(const void *unused ATTRIB

[libvirt] [PATCH 1/5] drivermodule: Ignore coverity warning about leaked_storage

2013-02-14 Thread John Ferlan
--- tests/virdrivermoduletest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/virdrivermoduletest.c b/tests/virdrivermoduletest.c index de8cf70..bbceb96 100644 --- a/tests/virdrivermoduletest.c +++ b/tests/virdrivermoduletest.c @@ -39,10 +39,12 @@ static int testDriverModule(const vo

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-02-14 Thread harryxiyou
On Thu, Feb 14, 2013 at 11:15 PM, Stefan Hajnoczi wrote: [...] > Hi Harry, Hi Stefan, > Thanks for your interest. You can begin thinking about ideas but > please keep in mind that we are still in the very early stages of GSoC > preparation. > > Google will publish the list of accepted organizati

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-02-14 Thread Stefan Hajnoczi
On Thu, Feb 14, 2013 at 11:39 AM, harryxiyou wrote: > On Tue, Feb 12, 2013 at 5:21 AM, Stefan Hajnoczi wrote: >> On Thu, Feb 7, 2013 at 4:19 PM, Stefan Hajnoczi wrote: >>> I believe Google will announce GSoC again this year (there is >>> no guarantee though) and I have created the wiki page so w

[libvirt] [PATCH V6 3/3] Add support for file descriptor sets

2013-02-14 Thread Stefan Berger
Add support for file descriptor sets by converting some of the command line parameters to use /dev/fdset/%d if -add-fd is found to be supported by QEMU. For those devices libvirt now open()s the device to obtain the file descriptor and 'transfers' the fd using virCommand. For the following fragm

[libvirt] [PATCH V6 0/3] Add support for QEMU file descriptor sets

2013-02-14 Thread Stefan Berger
The following patch series adds initial support for QEMU file descriptor sets implementing support for creating the proper command line. Some devices are using the sets now. Regards, Stefan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH V6 1/3] Add a class for file descriptor sets

2013-02-14 Thread Stefan Berger
Rather than passing the next-to-use file descriptor set Id and the hash table for rembering the mappings of aliases to file descriptor sets around, encapsulate the two in a class. Signed-off-by: Stefan Berger --- v5->v6: - following to changeset 2e5d7798df v4->v5: - followed Daniel Berran

[libvirt] [PATCH V6 2/3] Introduce file descriptor set for QEMU domains

2013-02-14 Thread Stefan Berger
Extend the QEMU private domain structure with virFdSet. Persist the virFdSet using XML and parse its XML. Reset the FdSet upon domain stop. Stefan Berger --- v5->v6: - change found in patch 3 moved to this patch --- src/qemu/qemu_domain.c | 13 + src/qemu/qemu_domain.h |

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-02-14 Thread harryxiyou
On Tue, Feb 12, 2013 at 5:21 AM, Stefan Hajnoczi wrote: > On Thu, Feb 7, 2013 at 4:19 PM, Stefan Hajnoczi wrote: >> I believe Google will announce GSoC again this year (there is >> no guarantee though) and I have created the wiki page so we can begin >> organizing project ideas that students can

Re: [libvirt] [PATCH] Add support for qxl.revision in domain XML

2013-02-14 Thread Christophe Fergeau
Ping? On Mon, Feb 04, 2013 at 04:16:36PM +0100, Christophe Fergeau wrote: > QXL devices have an associated 'revision' which is raised when > new features have been introduced which would break migration > to older versions. This commit makes it possible to set this > revision as QEMU sometimes sup

Re: [libvirt] Boot VM with HLFS driver for Libvirt network disk (Online storage management)

2013-02-14 Thread harryxiyou
On Thu, Feb 14, 2013 at 12:18 PM, harryxiyou wrote: [...] > I have some questions about up stuffs. > > 1, I wonder why first way (Only execute "virsh create hlfs_hdfs.xml") > do not call > qemuBuildCommandLine func, which may lead to fail to start VM with HLFS > volume, right? > This problem has

Re: [libvirt] Out of Memory Error

2013-02-14 Thread Jiri Denemark
On Thu, Feb 14, 2013 at 01:24:32 +0530, varun bhatnagar wrote: > Hi, > > Today I noticed one strange thing. I* *removed the contents of > *usbSharedFolder.xml > *and kept it blank. Then I again tried both ways i.e. calling attachDevice > method using code as well as virsh but again it gave libvir:

Re: [libvirt] [PATCH] vbox: Don't overwrite errors returned by virDomainDeviceDefParse

2013-02-14 Thread Jiri Denemark
On Thu, Feb 14, 2013 at 09:17:38 +0100, Michal Privoznik wrote: > On 14.02.2013 09:06, Jiri Denemark wrote: > > --- > > src/vbox/vbox_tmpl.c | 8 ++-- > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > ACK Thanks, pushed. Jirka -- libvir-list mailing list libvir-list@redhat.com h

Re: [libvirt] [PATCH] vbox: Don't overwrite errors returned by virDomainDeviceDefParse

2013-02-14 Thread Michal Privoznik
On 14.02.2013 09:06, Jiri Denemark wrote: > --- > src/vbox/vbox_tmpl.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > ACK Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 2/5] S390: domain_conf support for CCW

2013-02-14 Thread Viktor Mihajlovski
On 02/12/2013 12:28 AM, Eric Blake wrote: I've gone ahead and pushed patches 1 and 2, since v3 of the series did not repost them. Thanks :-) -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jet

[libvirt] [PATCH] vbox: Don't overwrite errors returned by virDomainDeviceDefParse

2013-02-14 Thread Jiri Denemark
--- src/vbox/vbox_tmpl.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 00b4d3d..cd88579 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -5388,10 +5388,8 @@ static int vboxDomainAttachDeviceImpl(virDomai

[libvirt] How to catch libvirtd logs

2013-02-14 Thread harryxiyou
Hi all, I start a VM with command "virsh create hlfs.xml", which fork a child process. But i am not sure how to catch this child process's logs? Could anyone give me some suggestions? Thanks in advance. -- Thanks Harry Wei -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.co