Re: [libvirt] [PATCH v2 1/8] hellolibvirt: Update hellolibvirt example

2013-02-24 Thread Laine Stump
On 02/22/2013 07:46 AM, John Ferlan wrote: On 02/20/2013 08:05 PM, Dave Allan wrote: On Wed, Feb 20, 2013 at 12:38:38PM -0500, John Ferlan wrote: Update the code to be more in line with how code looks elsewhere in libvirt. Allow listing of domains, networks, storage pools, and network

Re: [libvirt] [PATCH 5/5] storage: qemu-img: change INFO to DEBUG

2013-02-24 Thread Ján Tomko
On 02/22/13 14:28, John Ferlan wrote: On 02/18/2013 09:27 AM, Ján Tomko wrote: For really old qemu-img binaries which do not support specifying the format of the backing file, display a DEBUG message instead of INFO that this can't be done. --- src/storage/storage_backend.c | 4 ++-- 1

[libvirt] [PATCH] Hook log the exit status of the hook not 256

2013-02-24 Thread Guido Günther
Adjust the docs accordingly. See http://bugs.debian.org/701570. --- docs/hooks.html.in |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/hooks.html.in b/docs/hooks.html.in index 5f9963d..b75fbeb 100644 --- a/docs/hooks.html.in +++ b/docs/hooks.html.in @@ -239,13

Re: [libvirt] [PATCH v4 0/4] add pci-bridge support

2013-02-24 Thread li guang
ping ... 在 2013-02-19二的 10:25 +0800,liguang写道: Now, it's impossible to arrange devices into multi-pci-bus, for example: sound model='ac97' address type='pci' domain='0x' bus='0x00' slot='0x04' function='0x0'/ /sound video model type='cirrus' vram='9216'

Re: [libvirt] [PATCH 1/1] Add NVRAM device

2013-02-24 Thread Li Zhang
Hello, Does anyone have any comments? On 2013年02月22日 17:09, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. Users are allowed to specify spapr-vio devices'address. But NVRAM is not supported in libvirt. So this patch

Re: [libvirt] [PATCHv2 1/1] Optimize machine option to set more options with it.

2013-02-24 Thread Li Zhang
Ping ... On 2013年02月22日 17:09, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -machine option is used only when dump-guest-core is used. To use options defined in machine option for new version of QEMU, it needs to use -machine xxx, and to be compatible with older

[libvirt] [PATCH] interface: Fix udev backend bridge device display

2013-02-24 Thread Doug Goldstein
The bridge device was showing the vnet devices created for the domains as connected to the bridge. libvirt should only show host devices when trying to get the interface definition rather than the domain devices as well. --- Honestly this method sucks. But it makes the code path work and doesn't

[libvirt] [PATCH] virsh: add --start option to the define command

2013-02-24 Thread Doug Goldstein
Adds the --start option to the define command to simplify the often used case of virsh define dom.xml; start dom or virsh define dom.xml virsh start dom. This is just a rebased version of: https://www.redhat.com/archives/libvir-list/2013-January/msg00490.html There's a competing patchset

Re: [libvirt] git send-email should not allow 'y' for in-reply-to

2013-02-24 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Fri, Jan 11, 2013 at 10:43:39AM -0800, Hilco Wijbenga wrote: ... More seriously, I agree that re-wording the question is a reasonable thing to do. I do not use send-email, either, so I don't have a strong opinion on it. The suggestions you made: How about

[libvirt] [PATCH] docs: add forward mode='hostdev' example

2013-02-24 Thread Laine Stump
Also rearrange examples so that all managed networks (those with bridges created by libvirt) are together. --- docs/formatnetwork.html.in | 52 +- 1 file changed, 37 insertions(+), 15 deletions(-) diff --git a/docs/formatnetwork.html.in

[libvirt] [PATCH 1/2] conf: use VIR_EXPAND instead of VIR_REALLOC in virNetworkDHCPDefParseXML

2013-02-24 Thread Laine Stump
VIR_REALLOC_N doesn't initialize the newly allocated memory to 0, which can result in unpleasant surprises for those who have become accustomed to the 0-initializing behavior of most libvirt memory allocation functions, and add a new field to a struct thinking that it will default to 0. --- (in

[libvirt] [PATCH 0/2] network: add force attribute for dhcp options

2013-02-24 Thread Laine Stump
The firs patch just fixes unexpected behavior in virNetworkDHCPOptionDefParseXML found when testing the second patch. The second patch adds the force attribute I mentioned in the review of the patch that added support for specifying dhcp options in network config. While documenting this new

[libvirt] [PATCH 2/2] network: add force attribute for dhcp options

2013-02-24 Thread Laine Stump
If a dhcp option has force='yes', the dhcp server will send that option back to every client regardless of whether or not the client requests that option (without force='yes', an option will only be sent to those clients that ask for it in their request packet). For example: option number='40'

[libvirt] [PATCH v2 1/1] Add NVRAM device

2013-02-24 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. Users are allowed to specify spapr-vio devices'address. But NVRAM is not supported in libvirt. So this patch is to add NVRAM device to allow users to specify its address. In QEMU, NVRAM

Re: [libvirt] [PATCH] interface: Fix udev backend bridge device display

2013-02-24 Thread Laine Stump
On 02/24/2013 09:36 PM, Doug Goldstein wrote: The bridge device was showing the vnet devices created for the domains as connected to the bridge. libvirt should only show host devices when trying to get the interface definition rather than the domain devices as well. --- Honestly this method

Re: [libvirt] [PATCH 1/2] Trivial fix: in dhcp-host the name is optional

2013-02-24 Thread Laine Stump
On 02/19/2013 04:39 PM, Eric Blake wrote: On 02/15/2013 12:02 PM, Gene Czarcinski wrote: Although in IPv4 one must pick either mac or name, either can be omitted. Similarly, for IPv6, the name can be optionally omitted. Signed-off-by: Gene Czarcinski g...@czarc.net ---

Re: [libvirt] [PATCH 2/2] use client id for IPv6 DHCP host definition

2013-02-24 Thread Laine Stump
On 02/19/2013 04:44 PM, Eric Blake wrote: On 02/18/2013 07:38 PM, Laine Stump wrote: On 02/15/2013 02:02 PM, Gene Czarcinski wrote: Originally, only a host name was used to associate a DHCPv6 request with a specific IPv6 address. Further testing demonstrates that this is an unreliable method