[libvirt] [PATCH 1/2] cgroup: export virCgroupRemoveRecursively

2013-03-20 Thread Gao feng
We will use virCgroupRemoveRecursively to remove cgroup directories in the coming patch. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/libvirt_private.syms | 1 + src/util/vircgroup.c | 4 ++-- src/util/vircgroup.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff

[libvirt] [PATCH 2/2] LXC: rework mounting cgroupfs in container

2013-03-20 Thread Gao feng
There are 3 reason we need to rework the cgroupfs mounting in container. 1, Yin Olivia reported a failed to mount cgroup problem, now we given that the name of cgroup mount point is same with the subsystem type, Or libvirt_lxc will fail to start. 2, The cgroup configuration is leaked to

[libvirt] [libvirt-designer PATCHv2] Add GvirDesignerDomain::osinfo_db

2013-03-20 Thread Christophe Fergeau
virtxml was doing its own loading of the libosinfo database, and gvir_designer_init() was loading it a second time. By adding a GVirDesignerDomain::osinfo_db property, applications can share the same OsinfoDb as libvirt-designer. The association is made per libvirt-designer domain for more

Re: [libvirt] [PATCH v3 RESEND 3/4] NUMA: cleanup for numa related codes

2013-03-20 Thread Daniel P. Berrange
On Wed, Mar 20, 2013 at 09:26:36AM +0800, Gao feng wrote: 于 2013/03/19/ 17:59, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 09:59:37AM +0800, Gao feng wrote: Intend to reduce the redundant code,use virNumaSetupMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and

[libvirt] [PATCH] python: Fix emulatorpin API bindings

2013-03-20 Thread Peter Krempa
The addition of emulator pinning APIs didn't think of doing the right job with python APIs for them. The default generator produced unusable code for this. This patch switches to proper code as in the case of domain Vcpu pining. This change can be classified as a python API-breaker but in the

Re: [libvirt] [PATCH] qemu: add PCI-multibus support for ppc

2013-03-20 Thread Daniel P. Berrange
On Wed, Mar 20, 2013 at 02:11:51AM +, Yin Olivia-R63875 wrote: Hi Daniel, PPC also supports PCI multibus. Could you please help review this patch? IIUC, PPC did not support PCI multibus in the past, so when did this change ? Libvirt needs to only use this for versions where it is

Re: [libvirt] [PATCH] replace ppce500v2 with ppce500

2013-03-20 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 09:05:14PM -0600, Eric Blake wrote: On 03/19/2013 08:13 PM, Olivia Yin wrote: --- docs/schemas/domaincommon.rng| 2 +- Your commit message is sparse. This is a good place to explain WHY a maintainer should apply your patch. On my Fedora 18

Re: [libvirt] [libvirt-designer PATCHv2] Add GvirDesignerDomain::osinfo_db

2013-03-20 Thread Daniel P. Berrange
On Wed, Mar 20, 2013 at 11:10:50AM +0100, Christophe Fergeau wrote: virtxml was doing its own loading of the libosinfo database, and gvir_designer_init() was loading it a second time. By adding a GVirDesignerDomain::osinfo_db property, applications can share the same OsinfoDb as

Re: [libvirt] [PATCH RESEND 1/2] NUMA: cleanup for numa related codes

2013-03-20 Thread Osier Yang
On 2013年03月20日 11:35, Gao feng wrote: Intend to reduce the redundant code,use virNumaSetupMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. This patch also moves the numa related codes to the file virnuma.c and virnuma.h Signed-off-by: Gao

Re: [libvirt] [PATCH RESEND 2/2] LXC: add cpuset cgroup support for lxc

2013-03-20 Thread Osier Yang
On 2013年03月20日 11:35, Gao feng wrote: This patch adds cpuset cgroup support for LXC. Signed-off-by: Gao fenggaof...@cn.fujitsu.com Only rebasing, previous ACK still stands. Osier -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RESEND 1/2] NUMA: cleanup for numa related codes

2013-03-20 Thread Osier Yang
On 2013年03月20日 11:35, Gao feng wrote: Intend to reduce the redundant code,use virNumaSetupMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. This patch also moves the numa related codes to the file virnuma.c and virnuma.h Signed-off-by: Gao

[libvirt] [PATCH 2/4] doc/schema: Support iqn for storage pools

2013-03-20 Thread Philipp Hahn
iSCSO qualified names (iqn) from RFC3721 may contain colons (':'), which neither matches the absFilePath nor genericName: $ virsh pool-dumpxml myiscsipool pool type='iscsi' ... source ... device path='iqn.2003-01.org.linux-iscsi.phahn-sid93.x8664:sn.8a3daa0d4efd'/ /source ...

[libvirt] [PATCH 1/4] doc/schema: add ocfs2 to storage pool

2013-03-20 Thread Philipp Hahn
Add ocfs2 for disk pool. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/storagevol.rng |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/schemas/storagevol.rng b/docs/schemas/storagevol.rng index ba95c55..765c5a5 100644 ---

[libvirt] [PATCH 4/4] doc/schema: disk storage volume formats

2013-03-20 Thread Philipp Hahn
The storage volume formats supported by the disk storage pool are missing from the allowed values. Add partition types. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/storagevol.rng | 14 ++ 1 file changed, 14 insertions(+) diff --git

[libvirt] [PATCH 3/4] doc: storage: Fix grammar

2013-03-20 Thread Philipp Hahn
Remove 'are' before 'have'. Signed-off-by: Philipp Hahn h...@univention.de --- docs/storage.html.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index 7712c80..3777474 100644 --- a/docs/storage.html.in +++

[libvirt] [PATCH] Fix typos s/HAVE_SELINUX/WITH_SELINUX/

2013-03-20 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virNetSocket virIdentity classes accidentally got some conditionals using HAVE_SELINUX instead of WITH_SELINUX. Signed-off-by: Daniel P. Berrange berra...@redhat.com Pushed under trivial rule --- src/rpc/virnetsocket.c | 4 ++--

Re: [libvirt] [PATCH] python: Fix emulatorpin API bindings

2013-03-20 Thread Guannan Ren
On 03/20/2013 06:52 PM, Peter Krempa wrote: The addition of emulator pinning APIs didn't think of doing the right job with python APIs for them. The default generator produced unusable code for this. This patch switches to proper code as in the case of domain Vcpu pining. This change can be

Re: [libvirt] [PATCH 1/4] doc/schema: add ocfs2 to storage pool

2013-03-20 Thread Osier Yang
On 2013年02月26日 20:41, Philipp Hahn wrote: Add ocfs2 for disk pool. Actually it's for volume. Signed-off-by: Philipp Hahnh...@univention.de --- docs/schemas/storagevol.rng |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/schemas/storagevol.rng

Re: [libvirt] [PATCH 3/4] doc: storage: Fix grammar

2013-03-20 Thread Osier Yang
On 2013年03月20日 19:42, Philipp Hahn wrote: Remove 'are' before 'have'. Signed-off-by: Philipp Hahnh...@univention.de --- docs/storage.html.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index 7712c80..3777474 100644 ---

Re: [libvirt] [PATCH 2/4] doc/schema: Support iqn for storage pools

2013-03-20 Thread Osier Yang
On 2013年03月20日 18:45, Philipp Hahn wrote: iSCSO qualified names (iqn) from RFC3721 may contain colons (':'), which neither matches the absFilePath nor genericName: $ virsh pool-dumpxml myiscsipool pool type='iscsi' ... source ... device

Re: [libvirt] [PATCH 4/4] doc/schema: disk storage volume formats

2013-03-20 Thread Osier Yang
On 2013年03月20日 19:53, Philipp Hahn wrote: The storage volume formats supported by the disk storage pool are missing from the allowed values. Add partition types. Signed-off-by: Philipp Hahnh...@univention.de --- docs/schemas/storagevol.rng | 14 ++ 1 file changed, 14

Re: [libvirt] [PATCH 2/4] doc/schema: Support iqn for storage pools

2013-03-20 Thread Osier Yang
On 2013年03月20日 21:38, Osier Yang wrote: On 2013年03月20日 18:45, Philipp Hahn wrote: iSCSO qualified names (iqn) from RFC3721 may contain colons (':'), which With s/iSCSO/iSCSI/, neither matches the absFilePath nor genericName: $ virsh pool-dumpxml myiscsipool pool type='iscsi' ... source ...

Re: [libvirt] [PATCH 1/4] doc/schema: add ocfs2 to storage pool

2013-03-20 Thread Osier Yang
On 2013年03月20日 21:31, Osier Yang wrote: On 2013年02月26日 20:41, Philipp Hahn wrote: Add ocfs2 for disk pool. Actually it's for volume. Signed-off-by: Philipp Hahnh...@univention.de --- docs/schemas/storagevol.rng | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH 1/2] cgroup: export virCgroupRemoveRecursively

2013-03-20 Thread Osier Yang
On 2013年03月20日 16:14, Gao feng wrote: We will use virCgroupRemoveRecursively to remove cgroup directories in the coming patch. Signed-off-by: Gao fenggaof...@cn.fujitsu.com --- src/libvirt_private.syms | 1 + src/util/vircgroup.c | 4 ++-- src/util/vircgroup.h | 1 + 3 files

Re: [libvirt] libvirtd segfault

2013-03-20 Thread Jim Fehlig
AL13N wrote: Thread 1 (Thread 0x7fdef683b800 (LWP 20522)): #0 0x in ?? () #1 0x7fdee9a72dc7 in libxl_osevent_occurred_timeout (ctx=optimized out, for_libxl=0x7fdedc001608) at libxl_event.c:1039 #2 0x7fdee9c9ff87 in libxlTimerCallback (timer=optimized out,

[libvirt] [PATCHv2] python: Fix emulatorpin API bindings

2013-03-20 Thread Peter Krempa
The addition of emulator pinning APIs didn't think of doing the right job with python APIs for them. The default generator produced unusable code for this. This patch switches to proper code as in the case of domain Vcpu pining. This change can be classified as a python API-breaker but in the

[libvirt] [PATCH] libvirt-guests: newline between output sentences

2013-03-20 Thread Eric Blake
Right now, libvirt-guests gives awkward output. It's possible to force faster failure by setting /etc/sysconfig/libvirt-guests to use: ON_SHUTDOWN=shutdown PARALLEL_SHUTDOWN=0 SHUTDOWN_TIMEOUT=1 ON_BOOT=ignore at which point, we see: $ service libvirt-guests restart Running guests on default

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-03-20 Thread Gene Czarcinski
On 03/16/2013 09:32 AM, Gene Czarcinski wrote: On 03/15/2013 03:48 PM, Gene Czarcinski wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are

Re: [libvirt] [PATCH] clarify vmrsh net commands

2013-03-20 Thread Gene Czarcinski
On 03/16/2013 01:36 PM, Gene Czarcinski wrote: Clarify that net-create deals with a transient virtual network whereas net-define defines a persistent virtual network definition and will create the network (xml) definition file. Clarify that net-destroy works with both transient and persistent

[libvirt] [PATCH] Fix linkage of virt-aa-helper with numa library

2013-03-20 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The recent commit moved some of the use of libnuma out of the driver code, and into src/util/. It did not, however, update libvirt_util.la to link against libnuma. This caused linkage failure with virt-aa-helper, since nothing else caused libnuma to be

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-03-20 Thread Laine Stump
On 03/20/2013 10:57 AM, Gene Czarcinski wrote: On 03/16/2013 09:32 AM, Gene Czarcinski wrote: On 03/15/2013 03:48 PM, Gene Czarcinski wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP

[libvirt] [PATCH] qemu: Un-mark volume as mirrored/copied if blockjob copy fails

2013-03-20 Thread Peter Krempa
When the blockjob fails for some reason an event is emitted but the disk wasn't unmarked as being part of a active block copy operation. --- src/qemu/qemu_process.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 2465938..ada864b

[libvirt] [PATCH] qemu: s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_UNSUPPORTED

2013-03-20 Thread Michal Privoznik
The VIR_ERR_NO_SUPPORT error code is reserved for cases where an API is not implemented in a driver. It definitely should not be used when an API execution fails due to unsupported operation. --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 30

Re: [libvirt] [PATCH] Fix linkage of virt-aa-helper with numa library

2013-03-20 Thread Michal Privoznik
On 20.03.2013 16:02, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The recent commit moved some of the use of libnuma out of the driver code, and into src/util/. It did not, however, update libvirt_util.la to link against libnuma. This caused linkage failure with

Re: [libvirt] [PATCH] qemu: Un-mark volume as mirrored/copied if blockjob copy fails

2013-03-20 Thread Eric Blake
On 03/20/2013 09:53 AM, Peter Krempa wrote: When the blockjob fails for some reason an event is emitted but the disk wasn't unmarked as being part of a active block copy operation. --- src/qemu/qemu_process.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_process.c

Re: [libvirt] [PATCH] qemu: s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_UNSUPPORTED

2013-03-20 Thread Eric Blake
On 03/20/2013 09:59 AM, Michal Privoznik wrote: The VIR_ERR_NO_SUPPORT error code is reserved for cases where an API is not implemented in a driver. It definitely should not be used when an API execution fails due to unsupported operation. --- src/qemu/qemu_driver.c | 2 +-

Re: [libvirt] about Application_Development_Guide.pdf

2013-03-20 Thread Eric Blake
On 03/19/2013 09:30 PM, huyp1024 wrote: Daniel,thanks for replying ! i want to be involved with libvirt program, if I delicate myself to writing more content for the docs,what could i do ? I'm familiar with java and python,by the way ,i'm chinese,so there may be some risks that the docs i

[libvirt] [PATCH] Don't fail if SELinux is diabled

2013-03-20 Thread Guido Günther
but libvirt is built with --with-selinux. In this case getpeercon returns ENOPROTOOPT so dont' return an error in that case but simply don't set seccon. --- src/rpc/virnetsocket.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c

Re: [libvirt] [PATCH] Don't fail if SELinux is diabled

2013-03-20 Thread Eric Blake
On 03/20/2013 01:04 PM, Guido Günther wrote: s/diabled/disabled/ in the subject but libvirt is built with --with-selinux. In this case getpeercon returns ENOPROTOOPT so dont' return an error in that case but simply s/dont'/don't/ don't set seccon. --- src/rpc/virnetsocket.c |2 +- 1

[libvirt] libvirt-tck test failure with identity patches

2013-03-20 Thread Guido Günther
Hi, the qemu session libvirt-tck test currently fails with: [19:58:21] scripts/domain/050-transient-lifecycle.t ok59684 ms [19:59:20] scripts/domain/051-transient-autostart.t ok 2001 ms [19:59:22] scripts/domain/060-persistent-lifecycle.t ... ok 2943

Re: [libvirt] [PATCH] clarify vmrsh net commands

2013-03-20 Thread Eric Blake
On 03/16/2013 11:36 AM, Gene Czarcinski wrote: s/vmrsh/virsh/ in the subject Clarify that net-create deals with a transient virtual network whereas net-define defines a persistent virtual network definition and will create the network (xml) definition file. Clarify that net-destroy works

Re: [libvirt] [PATCH] Don't fail if SELinux is diabled

2013-03-20 Thread Guido Günther
On Wed, Mar 20, 2013 at 01:10:13PM -0600, Eric Blake wrote: On 03/20/2013 01:04 PM, Guido Günther wrote: s/diabled/disabled/ in the subject but libvirt is built with --with-selinux. In this case getpeercon returns ENOPROTOOPT so dont' return an error in that case but simply

Re: [libvirt] [PATCHv2] python: Fix emulatorpin API bindings

2013-03-20 Thread Eric Blake
On 03/20/2013 08:48 AM, Peter Krempa wrote: The addition of emulator pinning APIs didn't think of doing the right job with python APIs for them. The default generator produced unusable code for this. This patch switches to proper code as in the case of domain Vcpu pining. This change can be

Re: [libvirt] [PATCH 1/2] cgroup: export virCgroupRemoveRecursively

2013-03-20 Thread Eric Blake
On 03/20/2013 07:59 AM, Osier Yang wrote: On 2013年03月20日 16:14, Gao feng wrote: We will use virCgroupRemoveRecursively to remove cgroup directories in the coming patch. Signed-off-by: Gao fenggaof...@cn.fujitsu.com --- src/libvirt_private.syms | 1 + src/util/vircgroup.c | 4 ++--

Re: [libvirt] [PATCH] Don't fail if SELinux is diabled

2013-03-20 Thread Eric Blake
On 03/20/2013 02:06 PM, Guido Günther wrote: On Wed, Mar 20, 2013 at 01:10:13PM -0600, Eric Blake wrote: On 03/20/2013 01:04 PM, Guido Günther wrote: s/diabled/disabled/ in the subject ACK. Pushed. Thanks, Without the typo fix. Oh well. -- Eric Blake eblake redhat com

Re: [libvirt] [PATCH 4/7] Add a helper API for setting up a NBD device with qemu-nbd

2013-03-20 Thread Eric Blake
On 03/19/2013 07:39 AM, John Ferlan wrote: On 03/15/2013 12:32 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add a virFileNBDDeviceAssociate method, which given a filename will setup a NBD device, using qemu-nbd as the server. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 5/7] Add 'nbd' as a valid filesystem driver type

2013-03-20 Thread Eric Blake
On 03/15/2013 10:32 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The filesystem element can now accept a driver type='nbd'/ as an alternative to 'loop'. The benefit of NBD is support for non-raw disk image formats. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Don't fail if SELinux is diabled

2013-03-20 Thread Guido Günther
On Wed, Mar 20, 2013 at 02:20:52PM -0600, Eric Blake wrote: On 03/20/2013 02:06 PM, Guido Günther wrote: On Wed, Mar 20, 2013 at 01:10:13PM -0600, Eric Blake wrote: On 03/20/2013 01:04 PM, Guido Günther wrote: s/diabled/disabled/ in the subject ACK. Pushed. Thanks, Without

Re: [libvirt] [PATCH 0/7] Support NBD volumes with LXC containers

2013-03-20 Thread Eric Blake
On 03/19/2013 04:50 AM, Daniel P. Berrange wrote: Ping, any reviews welcome On Fri, Mar 15, 2013 at 04:32:37PM +, Daniel P. Berrange wrote: This series adds support for using non-raw disks with LXC containers by leverging NBD + qemu-nbd as an alternative to the loopback device. I also

Re: [libvirt] [PATCH 1/1] Clean redundant code about VCPU string checking

2013-03-20 Thread Eric Blake
On 03/18/2013 11:01 AM, John Ferlan wrote: On 03/18/2013 05:57 AM, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Now that VCPU number are removed from qemu_monitor_text.c. Mentioning commit cc78d7ba would have been helpful. VCPU string checking also should be removed.

Re: [libvirt] Consultation of the patch util: Prepare helpers for unpriv_sgio setting

2013-03-20 Thread Eric Blake
On 03/18/2013 08:13 AM, Osier Yang wrote: I added a disk to virtio-scsi bus through the VM's XML file like this: disk type='block' device='disk' driver name='qemu' type='raw' io='threads'/ source dev='/mnt/test.raw'/ target dev='sdb' bus='scsi'/ shareable/ /disk Then when I started the

Re: [libvirt] [PATCH] qemu: Add the new disk src into shared disk table when updating disk

2013-03-20 Thread Eric Blake
On 03/18/2013 07:52 AM, Osier Yang wrote: We should record the new disk src in the shared disk table for updating disk (CD-ROM or Floppy) API. Fortunately, we only allow to update the disk source now, otherwise we might also want to set the unpriv_sgio setting. --- src/qemu/qemu_driver.c |

Re: [libvirt] [PATCH] python: fix about some of python binding APIs don't raise and exception

2013-03-20 Thread Eric Blake
On 03/01/2013 03:03 AM, Guannan Ren wrote: The subject line is long, and has a typo. I'd suggest: python: fix bindings that don't raise an exception For example: dom.memoryStats() libvir: QEMU Driver error : Requested operation is not valid:\ domain is not running There are

Re: [libvirt] [PATCH 07/13] domain: add support for iscsi network disks

2013-03-20 Thread Eric Blake
On 03/11/2013 04:19 AM, Osier Yang wrote: On 2013年02月26日 01:44, Paolo Bonzini wrote: This plumbs in the XML description of iSCSI shares. The next patches will add support for the libiscsi userspace initiator. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- the protocol to

Re: [libvirt] [PATCH RESEND 1/2] NUMA: cleanup for numa related codes

2013-03-20 Thread Gao feng
On 2013/03/20 19:14, Osier Yang wrote: On 2013年03月20日 11:35, Gao feng wrote: Intend to reduce the redundant code,use virNumaSetupMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. This patch also moves the numa related codes to the file virnuma.c

[libvirt] libvirtd(0.9.10) crashed with Segmentation fault, Is someone ever come up against this problem , thanks

2013-03-20 Thread Caizhifeng
HI all, Libvirtd of version 0.9.10, when several VMs migrate intercurrently, there comes up with the follow problem. Has anyone come up against this problem? How can I fix it, Any suggestions appreciated. thank you very much. (gdb) c Continuing. Program received signal SIGSEGV, Segmentation

Re: [libvirt] libvirtd(0.9.10) crashed with Segmentation fault, Is someone ever come up against this problem , thanks

2013-03-20 Thread Eric Blake
On 03/20/2013 08:14 PM, Caizhifeng wrote: HI all, Libvirtd of version 0.9.10, when several VMs migrate intercurrently, there comes up with the follow problem. Has anyone come up against this problem? How can I fix it, Any suggestions appreciated. There have been several bug fixes in

Re: [libvirt] [PATCH 08/13] qemu: add support for libiscsi

2013-03-20 Thread Eric Blake
On 03/15/2013 08:39 AM, Daniel P. Berrange wrote: On Mon, Feb 25, 2013 at 06:44:27PM +0100, Paolo Bonzini wrote: libiscsi provides a userspace iSCSI initiator. The main advantage over the kernel initiator is that it is very easy to provide different initiator names for VMs on the same host.

Re: [libvirt] [PATCH 1/2] cgroup: export virCgroupRemoveRecursively

2013-03-20 Thread Gao feng
On 2013/03/21 04:19, Eric Blake wrote: On 03/20/2013 07:59 AM, Osier Yang wrote: On 2013年03月20日 16:14, Gao feng wrote: We will use virCgroupRemoveRecursively to remove cgroup directories in the coming patch. Signed-off-by: Gao fenggaof...@cn.fujitsu.com --- src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH RFC] virsh: Fix semantics of --config for update-device command

2013-03-20 Thread Eric Blake
On 03/15/2013 10:37 AM, Peter Krempa wrote: The man page states that with --config the next boot is affected. This can be understood as if _only_ the next bood was affected. This isn't s/bood/boot/ true if the machine is running. This patch adds the full --live, --config, --current

Re: [libvirt] [PATCH 1/8] virsh: Introduce macros to reject mutually exclusive arguments

2013-03-20 Thread Eric Blake
On 03/07/2013 05:53 AM, Peter Krempa wrote: This patch adds three macros to the virsh source tree that help to easily check for mutually exclusive parameters. VSH_EXCLUSIVE_OPTIONS_EXPR has four arguments, two expressions to check and two names of the parameters to print in the message.

Re: [libvirt] [PATCH 2/8] virsh-snapshot: Refactor virsh snapshot-list

2013-03-20 Thread Eric Blake
On 03/07/2013 05:53 AM, Peter Krempa wrote: Simplify error handling and mutually exlusive option checking. s/exlusive/exclusive/ --- tools/virsh-snapshot.c | 121 ++--- 1 file changed, 45 insertions(+), 76 deletions(-) ACK. It might have

Re: [libvirt] [PATCH] python: fix about some of python binding APIs don't raise and exception

2013-03-20 Thread Guannan Ren
On 03/21/2013 06:41 AM, Eric Blake wrote: On 03/01/2013 03:03 AM, Guannan Ren wrote: The subject line is long, and has a typo. I'd suggest: python: fix bindings that don't raise an exception For example: dom.memoryStats() libvir: QEMU Driver error : Requested operation is not valid:\

Re: [libvirt] [PATCH 3/8] virsh-host: Refactor cmdFreecell

2013-03-20 Thread Eric Blake
On 03/07/2013 05:53 AM, Peter Krempa wrote: Use the new helpers to determine mutually exclusive options and touch up some parts to simplify the code. --- tools/virsh-host.c | 55 +++--- 1 file changed, 23 insertions(+), 32 deletions(-) -

Re: [libvirt] [PATCH 4/8] virsh-domain: Fix flag name in error message to match the check

2013-03-20 Thread Eric Blake
On 03/07/2013 05:53 AM, Peter Krempa wrote: The check is done on the --paused flag by the error message stated s/by/but/ --started --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK. diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

Re: [libvirt] [PATCH 5/8] virsh-snapshot: Refactor cmdSnapshotCurrent

2013-03-20 Thread Eric Blake
On 03/07/2013 05:53 AM, Peter Krempa wrote: Use the exclusive parameter checker and touch up some parts to simplify code. --- tools/virsh-snapshot.c | 46 +- 1 file changed, 21 insertions(+), 25 deletions(-) ACK -- Eric Blake eblake redhat

Re: [libvirt] [PATCH 6/8] virsh-snapshot: Use the mutually exclusive params macro in cmdSnapshotEdit

2013-03-20 Thread Eric Blake
On 03/07/2013 05:53 AM, Peter Krempa wrote: --- tools/virsh-snapshot.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) ACK. diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 78db178..3add7fb 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c

Re: [libvirt] [PATCH 7/8] virsh-snapshot: Simplify cleanup path in cmdSnapshotEdit

2013-03-20 Thread Eric Blake
On 03/07/2013 05:53 AM, Peter Krempa wrote: --- tools/virsh-snapshot.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [libvirt] [PATCH 8/8] virsh-domain: Simplify usage of --current, --live and --config flags

2013-03-20 Thread Eric Blake
On 03/07/2013 05:53 AM, Peter Krempa wrote: This patch uses the new helper to avoid the more complex check for domain state modification flags. --- tools/virsh-domain.c | 260 ++- 1 file changed, 111 insertions(+), 149 deletions(-) diff

Re: [libvirt] libvirtd(0.9.10) crashed with Segmentation fault, Is someone ever come up against this problem , thanks

2013-03-20 Thread Osier Yang
On 2013年03月21日 10:14, Caizhifeng wrote: HI all, Libvirtd of version 0.9.10, when several VMs migrate intercurrently, there comes up with the follow problem. Has anyone come up against this problem? How can I fix it, Any suggestions appreciated. thank you very much. (gdb) c Continuing.

Re: [libvirt] [PATCH] libvirt-guests: newline between output sentences

2013-03-20 Thread Osier Yang
On 2013年03月20日 22:56, Eric Blake wrote: Right now, libvirt-guests gives awkward output. It's possible to force faster failure by setting /etc/sysconfig/libvirt-guests to use: ON_SHUTDOWN=shutdown PARALLEL_SHUTDOWN=0 SHUTDOWN_TIMEOUT=1 ON_BOOT=ignore at which point, we see: $ service

Re: [libvirt] [PATCH] qemu: Add the new disk src into shared disk table when updating disk

2013-03-20 Thread Osier Yang
On 2013年03月21日 06:16, Eric Blake wrote: On 03/18/2013 07:52 AM, Osier Yang wrote: We should record the new disk src in the shared disk table for updating disk (CD-ROM or Floppy) API. Fortunately, we only allow to update the disk source now, otherwise we might also want to set the unpriv_sgio