On 03/25/13 19:11, Eric Blake wrote:
On 03/25/2013 10:31 AM, Peter Krempa wrote:
On 03/25/13 17:21, Peter Krempa wrote:
Get rid of the default labels to do so.
---
tools/virsh.c | 4
1 file changed, 4 deletions(-)
case VSH_OT_ALIAS:
Please consider for 1.0.4 as this prevents a potential data
corruption or segfault. The race is caused by referencing a
disposed connection object in a callback.
In the first patch we make sure that the object reference count
is reflecting the callback registration. This prevents a premature
Check function pointer before calling.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
src/remote/remote_driver.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 3721af9..885120e 100644
---
By adjusting the reference count of the connection object we
prevent races between callback function and virConnectClose.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
src/libvirt.c |5 +
1 file changed, 5 insertions(+)
diff --git a/src/libvirt.c b/src/libvirt.c
Before closing the connection we unregister the close callback
to prevent a reference leak. We make sure that we only unregister
if we have previously registered a callback (not the case for
virsh connect!). Further, the messages on virConnectClose != 0
are a bit more specific now.
Signed-off-by:
On 25/03/13 14:51, Chunyan Liu wrote:
2013/3/22 Osier Yang jy...@redhat.com:
On 2013年03月22日 17:36, Chunyan Liu wrote:
Hi, List,
As the mail I've sent a week before:
https://www.redhat.com/archives/libvir-list/2013-March/msg00730.html
I'm willing to push this work forward so that the
The domain XML generator creates the mac addres strings with lowercase
strings with a separate piece of code. This patch changes the formating
helper to do the same stuff to allow using it to normalize a string
provided by the user. After this change some of the tests that are
outputing the mac
The domif-getlink command did not terminate successfully when the
interface state was found. As the code used old and too complex approach
to do the job, this patch refactors it and fixed the bug.
---
tools/virsh-domain-monitor.c | 100 ---
1 file changed,
This series refactors libvirt XML code generator to create uniform
mac addresses with lowercase hex characters and refactors the domif-getlink
command to avoid a bug and too complex code.
Peter Krempa (3):
util: Change virMacAddrFormat to lowercase hex characters
conf: Use virMacAddrFormat
Format the address using the helper to avoid code duplication.
---
src/conf/domain_conf.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4cae0d3..40dfc99 100644
--- a/src/conf/domain_conf.c
+++
On 03/22/2013 04:37 PM, Stefan Berger wrote:
Linux netfilter at some point inverted the meaning of the '--ctdir reply'
and newer netfilter implementations now expect '--ctdir original'
instead and vice-versa.
We probe for this netfilter change via a UDP message over loopback and 3
filtering
Hi all,
I'm a graduate student in Shanghai, and will do experiment about live migration
using KVM as hypervisor.
Due to my demand, I want to get each iteration time and downtime in migration.
I found there is no API to implement it, and how can I obtain data I want?
Thanks very much.
Best
On 21.03.2013 16:35, Michal Privoznik wrote:
Don't forget other seclabels when adding a seclabel type='none'/.
Michal Privoznik (2):
security_manager: Don't manipulate domain XML in
virDomainDefGetSecurityLabelDef
security: Don't add seclabel of type none if there's already a
On 03/26/2013 12:26 PM, Peter Krempa wrote:
The domain XML generator creates the mac addres strings with lowercase
strings with a separate piece of code. This patch changes the formating
helper to do the same stuff to allow using it to normalize a string
provided by the user. After this change
On 03/26/2013 12:26 PM, Peter Krempa wrote:
Format the address using the helper to avoid code duplication.
---
src/conf/domain_conf.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4cae0d3..40dfc99 100644
#virsh detach-device $guest usb.xml
error: Failed to detach device from usb2.xml
error: operation failed: host usb device vendor=0x0951 \
product=0x1625 not found
This regresstion is due to a typo in matching function. The first
argument is always the usb device that we are checking for. If
On 03/25/2013 05:08 PM, Martin Kletzander wrote:
On 03/25/2013 04:54 PM, Martin Kletzander wrote:
virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG
used NULLSTR() for the output) and by default, if name == NULL, the
default connection uri is used. This was not indicated in
On 03/26/2013 10:18 PM, Martin Kletzander wrote:
On 03/25/2013 05:08 PM, Martin Kletzander wrote:
On 03/25/2013 04:54 PM, Martin Kletzander wrote:
virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG
used NULLSTR() for the output) and by default, if name == NULL, the
default
On 03/26/2013 03:23 PM, Guannan Ren wrote:
On 03/26/2013 10:18 PM, Martin Kletzander wrote:
On 03/25/2013 05:08 PM, Martin Kletzander wrote:
On 03/25/2013 04:54 PM, Martin Kletzander wrote:
virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG
used NULLSTR() for the output) and
On 03/26/2013 12:26 PM, Peter Krempa wrote:
The domif-getlink command did not terminate successfully when the
interface state was found. As the code used old and too complex approach
to do the job, this patch refactors it and fixed the bug.
s/fixed/fixes/
ACK,
the only change this patch
Since we switched from direct host migration scheme to the one,
where we connect to the destination and then just pass a FD to a
qemu, we have uncovered a qemu bug. Qemu expects migration FD to
block. However, we are passing a nonblocking one which results in
cryptic error messages like:
qemu:
On 26.03.2013 15:17, Guannan Ren wrote:
#virsh detach-device $guest usb.xml
error: Failed to detach device from usb2.xml
error: operation failed: host usb device vendor=0x0951 \
product=0x1625 not found
This regresstion is due to a typo in matching function. The first
argument is
Some block commands and migrate ignored incorrect values.
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=927495
---
tools/virsh-domain.c | 48
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/tools/virsh-domain.c
Despite of the comment stating virNetClientIncomingEvent handler should
never be called with either client-haveTheBuck or client-wantClose
set, there is a sequence of events that may lead to both booleans being
true when virNetClientIncomingEvent is called. However, when that
happens, we must not
On 03/22/2013 06:52 PM, Guido Günther wrote:
f946462e14ac036357b7c11ce5c23f94a3ee4e49 changed behavior by settings
VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI upfront. If we do so before invoking
qemuDomainPCIAddressEnsureAddr we merely try to set the PCI slot via
qemuDomainPCIAddressReserveSlot
On 03/26/2013 09:52 AM, Jiri Denemark wrote:
Despite of the comment stating virNetClientIncomingEvent handler should
s/of //
never be called with either client-haveTheBuck or client-wantClose
set, there is a sequence of events that may lead to both booleans being
true when
On 03/26/2013 09:44 AM, Ján Tomko wrote:
Some block commands and migrate ignored incorrect values.
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=927495
---
tools/virsh-domain.c | 48
1 file changed, 24 insertions(+), 24 deletions(-)
ACK.
On 26.03.2013 17:08, Eric Blake wrote:
On 03/26/2013 08:55 AM, Michal Privoznik wrote:
Since we switched from direct host migration scheme to the one,
where we connect to the destination and then just pass a FD to a
qemu, we have uncovered a qemu bug. Qemu expects migration FD to
block.
On 03/26/2013 05:18 PM, Eric Blake wrote:
On 03/26/2013 09:44 AM, Ján Tomko wrote:
Some block commands and migrate ignored incorrect values.
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=927495
---
tools/virsh-domain.c | 48
1 file
On 03/26/2013 08:55 AM, Michal Privoznik wrote:
Since we switched from direct host migration scheme to the one,
where we connect to the destination and then just pass a FD to a
qemu, we have uncovered a qemu bug. Qemu expects migration FD to
block. However, we are passing a nonblocking one
On 03/25/13 21:34, Laine Stump wrote:
On 03/15/2013 11:26 AM, Peter Krempa wrote:
This patch implements the devices post parse cllback and uses it to fill
the default qemu network card model into the XML if none is specified.
Libvirt assumes that the network card model for qemu is the rtl8139.
On 03/26/13 17:46, Yanbing Du wrote:
Signed-off-by: Yanbing Du y...@redhat.com
---
tools/virsh-domain.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
ACK and I will push the patch soon.
Peter
--
libvir-list mailing list
libvir-list@redhat.com
Signed-off-by: Yanbing Du y...@redhat.com
---
tools/virsh-domain.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 592a6e8..fc5cb1e 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1603,7 +1603,7 @@ static
On 03/26/13 01:19, Laine Stump wrote:
On 03/15/2013 11:26 AM, Peter Krempa wrote:
The limits are documented at
http://libvirt.org/formatdomain.html#elementsCPUTuning . Enforce them
when going through XML parsing in addition to being enforced by the API.
What's the rationale for doing this
On Tue, Mar 26, 2013 at 11:20 AM, Michal Privoznik mpriv...@redhat.com wrote:
On 26.03.2013 17:08, Eric Blake wrote:
On 03/26/2013 08:55 AM, Michal Privoznik wrote:
Since we switched from direct host migration scheme to the one,
where we connect to the destination and then just pass a FD to a
Hello,
I've had some trouble starting a Linux Container with libvirt. Here's my setup:
1. I've downloaded libvirt-1.0.3.tar.gz from [1] and issued:
- ./configure --prefix=/usr
- make
- make install
- ldconfig
2. I've started the libvirtd service:
- sudo service libvirtd start
Starting libvirtd
On Tue, Mar 26, 2013 at 05:13:17PM +0100, Ján Tomko wrote:
On 03/22/2013 06:52 PM, Guido Günther wrote:
f946462e14ac036357b7c11ce5c23f94a3ee4e49 changed behavior by settings
VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI upfront. If we do so before invoking
qemuDomainPCIAddressEnsureAddr we merely try
On 03/26/2013 12:20 PM, Michal Privoznik wrote:
On 26.03.2013 17:08, Eric Blake wrote:
On 03/26/2013 08:55 AM, Michal Privoznik wrote:
Since we switched from direct host migration scheme to the one,
where we connect to the destination and then just pass a FD to a
qemu, we have uncovered a
On 03/26/2013 02:52 PM, Cole Robinson wrote:
src/qemu/qemu_migration.c | 7 +++
1 file changed, 7 insertions(+)
Thanks for figuring it all out! I definitely hit this one, while trying
to help someone on IRC.
ACK, and definitely 1.0.4 material.
Thanks, pushed to master. I wonder if
On 03/26/2013 05:04 PM, Eric Blake wrote:
On 03/26/2013 02:52 PM, Cole Robinson wrote:
src/qemu/qemu_migration.c | 7 +++
1 file changed, 7 insertions(+)
Thanks for figuring it all out! I definitely hit this one, while trying
to help someone on IRC.
ACK, and definitely 1.0.4
On 03/26/2013 11:04 PM, Michal Privoznik wrote:
On 26.03.2013 15:17, Guannan Ren wrote:
#virsh detach-device $guest usb.xml
error: Failed to detach device from usb2.xml
error: operation failed: host usb device vendor=0x0951 \
product=0x1625 not found
This regresstion is due to a typo
On 2013/03/27 01:12, Purcareata Bogdan-B43198 wrote:
Hello,
I've had some trouble starting a Linux Container with libvirt. Here's my
setup:
1. I've downloaded libvirt-1.0.3.tar.gz from [1] and issued:
- ./configure --prefix=/usr
- make
- make install
- ldconfig
2. I've started the
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patch is to add NVRAM docs in formatdomain.html.in
and domaincommon.rng
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
docs/formatdomain.html.in | 35 +++
docs/schemas/domaincommon.rng | 10
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patch is to add NVRAM test cases.
Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com
---
.../qemuxml2argv-pseries-nvram.args|1 +
.../qemuxml2argv-pseries-nvram.xml | 20
From: Li Zhang zhlci...@linux.vnet.ibm.com
For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device.
Users are allowed to specify spapr-vio devices'address.
But NVRAM is not supported in libvirt. So this patch is to
add NVRAM device to allow users to specify its address.
In QEMU, NVRAM
Any comment?
Thanks. :)
On 2013年03月15日 17:19, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
To avoid the collision for creating USB controllers in machine-init()
and -device xx command line, it needs to set usb=off to avoid one USB
controller created in machine-init(). So that
Any comment ?
Thanks. :)
On 2013年03月15日 17:19, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
Currently, -machine option is used only when dump-guest-core is set.
To use options defined in machine option for newer version of QEMU,
it needs to use -machine xxx, and to be
Hi all,
Any comment about this patch?
Thanks.:)
On 2013年03月14日 14:54, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
Currently, -device xxx still can't work well for ppc64 platform.
It's better use legacy USB option with default for ppc64.
This patch is to legacy USB option with
Hi,
Could anyone give more comment?
Thanks. :)
On 2013年03月14日 14:54, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
This patch adds a CPU feature powernv identifying IBM Power
processor that supports native hypervisor e.g. KVM. This can
be used by virtualization management
On 2013/03/20 16:14, Gao feng wrote:
There are 3 reason we need to rework the cgroupfs
mounting in container.
1, Yin Olivia reported a failed to mount cgroup
problem, now we given that the name of cgroup mount point
is same with the subsystem type, Or libvirt_lxc
will fail to
50 matches
Mail list logo
