Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-19 Thread harryxiyou
On Fri, Apr 19, 2013 at 1:42 PM, Osier Yang jy...@redhat.com wrote: [...] There is no new things in the wiki. Sorry, i have not put my new design plan for 'Rename volume name'. Before writing the code, I'd suggest going through the HACKING and the document for how to implement a new API for

Re: [libvirt] [PATCH 2/5] util: allow using virCommandAllowCap with setuid helpers

2013-04-19 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 27/03/2013 23:46, Eric Blake ha scritto: That seems like a kernel flaw - it makes sense that you can't _add_ capabilities without CAP_SETPCAP, but being unable to _drop_ capabilities without first acquiring a capability seems backwards. I

[libvirt] virCommandProcessIO: hangs on poll()

2013-04-19 Thread wangxiaojun
recent qemu (git resp) with param like: #qemu-kvm -S -no-user-config -nodefaults -nographic -M none -qmp monarg -pidfile pidfile will just hangs forever. no any output or errors . and when libvirt Try to get caps via QMP qemuCaps. it run above command. so virCommandProcessIO call

Re: [libvirt] [PATCH v2 10/11] qemu: auto-add bridges and allow using them

2013-04-19 Thread Ján Tomko
On 04/19/2013 01:02 AM, Eric Blake wrote: On 04/17/2013 01:00 PM, Ján Tomko wrote: @@ -1321,7 +1363,39 @@ qemuDomainAssignPCIAddresses(virDomainDefPtr def, qemuDomainObjPrivatePtr priv = NULL; if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) { -if (!(addrs =

Re: [libvirt] [PATCH v2 1/1] Set legacy USB option with default for ppc64.

2013-04-19 Thread Li Zhang
Hi, It still needs this patch to configure USB controller on PPC64. If any concern, please let me know. Thanks. :) On 2013年04月15日 21:12, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -device xxx still can't work well for ppc64 platform. It's better use legacy USB

Re: [libvirt] [libvirt-designer PATCHv2 1/9] Improve VM skeleton created by gvir_designer_domain_setup_guest()

2013-04-19 Thread Christophe Fergeau
On Thu, Apr 18, 2013 at 05:18:55PM +0100, Daniel P. Berrange wrote: On Thu, Apr 18, 2013 at 06:12:25PM +0200, Christophe Fergeau wrote: Add various devices/configuration to libvirt XML config when creating the VM. This configuration is generic enough that it should be useful on all created

Re: [libvirt] [PATCH] qemu: fix default spice password setting

2013-04-19 Thread Martin Kletzander
On 04/19/2013 07:09 AM, Ján Tomko wrote: Set spice password even if default VNC password hasn't been set. https://bugzilla.redhat.com/show_bug.cgi?id=953720 --- src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c

Re: [libvirt] [PATCH v2 11/11] qemu: auto-add pci-root controller for pc machine types

2013-04-19 Thread Ján Tomko
On 04/18/2013 04:38 PM, Laine Stump wrote: On 04/18/2013 08:09 AM, Ján Tomko wrote: On 04/18/2013 07:22 AM, Laine Stump wrote: On 04/17/2013 03:00 PM, Ján Tomko wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 68518a7..a2179aa 100644 --- a/src/conf/domain_conf.c +++

Re: [libvirt] [PATCH] qemu: fix default spice password setting

2013-04-19 Thread Ján Tomko
On 04/19/2013 10:52 AM, Martin Kletzander wrote: On 04/19/2013 07:09 AM, Ján Tomko wrote: Set spice password even if default VNC password hasn't been set. https://bugzilla.redhat.com/show_bug.cgi?id=953720 --- ... ACK, Martin Thanks, pushed now. Jan -- libvir-list mailing list

Re: [libvirt] [PATCH] rng: tighten up domain controller schema

2013-04-19 Thread Osier Yang
On 18/04/13 19:59, Laine Stump wrote: On 04/18/2013 07:27 AM, Osier Yang wrote: On 18/04/13 19:16, Laine Stump wrote: On 04/18/2013 05:41 AM, Martin Kletzander wrote: On 04/18/2013 11:05 AM, Osier Yang wrote: On 18/04/13 17:00, Martin Kletzander wrote: On 04/18/2013 10:54 AM, Osier Yang

[libvirt] [libvirt-php PATCH] Fixed the libvirt_domain_disk_add and libvirt_domain_disk_remove so that they can handle block devices, and can update a running domain

2013-04-19 Thread Martijn Otto
--- src/libvirt-php.c | 246 + 1 file changed, 114 insertions(+), 132 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 0b8345a..24e8606 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -4232,11 +4232,12 @@

Re: [libvirt] [PATCH] rng: tighten up domain controller schema

2013-04-19 Thread Osier Yang
On 18/04/13 19:59, Laine Stump wrote: On 04/18/2013 07:27 AM, Osier Yang wrote: On 18/04/13 19:16, Laine Stump wrote: On 04/18/2013 05:41 AM, Martin Kletzander wrote: On 04/18/2013 11:05 AM, Osier Yang wrote: On 18/04/13 17:00, Martin Kletzander wrote: On 04/18/2013 10:54 AM, Osier Yang

Re: [libvirt] [PATCH] rng: tighten up domain controller schema

2013-04-19 Thread Osier Yang
On 18/04/13 19:59, Laine Stump wrote: On 04/18/2013 07:27 AM, Osier Yang wrote: On 18/04/13 19:16, Laine Stump wrote: On 04/18/2013 05:41 AM, Martin Kletzander wrote: On 04/18/2013 11:05 AM, Osier Yang wrote: On 18/04/13 17:00, Martin Kletzander wrote: On 04/18/2013 10:54 AM, Osier Yang

[libvirt] [PATCH v5 2/2] qemu: Add command line builder and parser for NVRAM.

2013-04-19 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com This patch is to add command line builder and parser for NVRAM device, and add test cases. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- v5 - v4: * Fix one memory leakage suggested by Eric Blake * Fix several code style suggested by Eric

[libvirt] [PATCH v5 1/2] Add NVRAM device

2013-04-19 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. Users are allowed to specify spapr-vio devices'address. But NVRAM is not supported in libvirt. So this patch is to add NVRAM device to allow users to specify its address. In QEMU, NVRAM

[libvirt] [libvirt-designer][PATCH 1/2] cfg.mk: Update list of syntax-check exceptions

2013-04-19 Thread Michal Privoznik
The bindtextdomain syntax-check macro is doing some dumb checking: each file containing '\main *(' must call bindtextdomain. Even if it's mentioned inside a comment block, which we do as of e71ad8e13e7. --- Or shall we drop bindtextdomain rule instead? cfg.mk | 6 +++--- 1 file changed, 3

[libvirt] [libvirt-designer][PATCH 2/2] libvirt-designer-main.c: Re-indent function headers

2013-04-19 Thread Michal Privoznik
--- libvirt-designer/libvirt-designer-main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt-designer/libvirt-designer-main.c b/libvirt-designer/libvirt-designer-main.c index ce69024..07de8c1 100644 --- a/libvirt-designer/libvirt-designer-main.c +++

Re: [libvirt] [PATCH] rng: tighten up domain controller schema

2013-04-19 Thread Osier Yang
Ignore the other 2 copies, they are same. I was blocked by the mail system... On 19/04/13 16:32, Osier Yang wrote: On 18/04/13 19:59, Laine Stump wrote: On 04/18/2013 07:27 AM, Osier Yang wrote: On 18/04/13 19:16, Laine Stump wrote: On 04/18/2013 05:41 AM, Martin Kletzander wrote: On

Re: [libvirt] [PATCH v2 11/11] qemu: auto-add pci-root controller for pc machine types

2013-04-19 Thread Ján Tomko
On 04/18/2013 04:38 PM, Laine Stump wrote: On 04/18/2013 08:09 AM, Ján Tomko wrote: On 04/18/2013 07:22 AM, Laine Stump wrote: On 04/17/2013 03:00 PM, Ján Tomko wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 68518a7..a2179aa 100644 --- a/src/conf/domain_conf.c +++

Re: [libvirt] [PATCH 3/5] qemu_conf: add new configuration key bridge_helper

2013-04-19 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 01:35:51PM -0400, Laine Stump wrote: On 03/25/2013 10:25 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 8 src/qemu/qemu_conf.c |

Re: [libvirt] [libvirt-designer PATCHv2 1/3] Add driver handling methods to GVirDesignerDomain

2013-04-19 Thread Michal Privoznik
On 18.04.2013 18:08, Christophe Fergeau wrote: They are useful to tell libvirt-designer about which drivers are install/will be installed in the OS associated with the domain. This in turns allows libvirt-designer code to use these devices when it's making some guesses about what to enable/not

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-19 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 09:03:59AM -0600, Eric Blake wrote: On 04/18/2013 06:21 AM, harryxiyou wrote: On Thu, Apr 18, 2013 at 5:30 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxi...@gmail.com wrote: From: Harry Wei harryxi...@gmail.com

Re: [libvirt] [libvirt-designer PATCHv2 3/3] Rework disk bus type handling

2013-04-19 Thread Michal Privoznik
On 18.04.2013 18:08, Christophe Fergeau wrote: The current handling of bus types has some issues: - it assumes that if the design uses a disk controller hanging off a PCI bus, then it can use virtio, which is not true for Windows for example unless an additional driver is installed - it

Re: [libvirt] [libvirt-designer PATCHv2 2/3] Add gvir_designer_domain_get_supported_devices()

2013-04-19 Thread Michal Privoznik
On 18.04.2013 18:08, Christophe Fergeau wrote: This method gathers the list of devices supported by the hypervisor, and intersects this list with the list of devices supported by the OS, natively or using a driver (added with gvir_designer_domain_add_driver()). The lists can be filtered if

Re: [libvirt] [libvirt-designer PATCHv2 1/3] Add driver handling methods to GVirDesignerDomain

2013-04-19 Thread Daniel P. Berrange
On Fri, Apr 19, 2013 at 11:46:18AM +0200, Michal Privoznik wrote: On 18.04.2013 18:08, Christophe Fergeau wrote: They are useful to tell libvirt-designer about which drivers are install/will be installed in the OS associated with the domain. This in turns allows libvirt-designer code to use

[libvirt] [PATCH designer] Increment soname + symbol versions

2013-04-19 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The ABI of some methods was explicitly broken, so the soname and symbol versions must all be incremented to reflect the ABI incompatibility --- configure.ac | 2 +- libvirt-designer/libvirt-designer.sym | 2 +- 2 files

[libvirt] [PATCH designer] Adapt saner libtool versioning scheme from libvirt

2013-04-19 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The current way libtool versioning is calculated has a timebomb when the package version number changes to 1.0.0, which will cause the library soname to change. Adapt to the latest libvirt macros for libtool versioning, which use an explicit variable

Re: [libvirt] [sandbox PATCH 2/6] We should not turn on the sanbox shell by default.

2013-04-19 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 02:34:51PM -0400, dwa...@redhat.com wrote: From: Dan Walsh dwa...@redhat.com We want to limit the number of processes which run within a container, especially for openshift work loads. Eventually we could add an option if someone wanted to run this shell. ---

Re: [libvirt] Reworked patch set to add UID/GID support for containers

2013-04-19 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 02:34:49PM -0400, dwa...@redhat.com wrote: Combined all UID/GID patches, taken into account Dan Berrange feedback. Now UID will be based off the current UID. Sandbox Shell is no longer used when using LXC containers. Connect will now just execute a shell within the

[libvirt] [PATCH] qemu: Fix setting of memory tunables

2013-04-19 Thread Peter Krempa
Refactoring done in 19c6ad9ac7e7eb2fd3c8262bff5f087b508ad07f didn't correctly take into account the order cgroup limit modification needs to be done in. This resulted into errors when decreasing the limits. The operations need to take place in this order: decrease hard limit change swap hard

Re: [libvirt] [PATCH] qemu: Fix setting of memory tunables

2013-04-19 Thread Peter Krempa
On 04/19/13 12:01, Peter Krempa wrote: Refactoring done in 19c6ad9ac7e7eb2fd3c8262bff5f087b508ad07f didn't correctly take into account the order cgroup limit modification needs to be done in. This resulted into errors when decreasing the limits. The operations need to take place in this order:

[libvirt] [PATCH glib] Adopt saner libtool versioning scheme from libvirt

2013-04-19 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The current way libtool versioning is calculated has a timebomb when the package version number changes to 1.0.0, which will cause the library soname to change. Adapt to the latest libvirt macros for libtool versioning, which use an explicit variable

Re: [libvirt] [PATCH v2 1/1] Set legacy USB option with default for ppc64.

2013-04-19 Thread Daniel P. Berrange
On Mon, Apr 15, 2013 at 09:12:18PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -device xxx still can't work well for ppc64 platform. It's better use legacy USB option with default for ppc64. This patch is to legacy USB option with default for ppc64.

[libvirt] [libvirt-designer][PATCH] test: Add new SimpleDisk test

2013-04-19 Thread Michal Privoznik
This test is meant for adding CDROM, floppy and disk to a domain. For now, each method has _file and _device variant, which are tested for now. --- libvirt-designer/test-designer-domain.c | 101 1 file changed, 101 insertions(+) diff --git

Re: [libvirt] [Xen-devel] [PATCH RESENT 04/12] libxl: populate xenstore memory entries at startup

2013-04-19 Thread Stefano Stabellini
On Thu, 11 Apr 2013, Ian Campbell wrote: On Thu, 2013-04-11 at 05:09 +0100, Jim Fehlig wrote: +/* This will fill xenstore info about free and dom0 memory - if missing, + * should be called before starting first domain */ +if (libxl_get_free_memory(libxl_driver-ctx,

Re: [libvirt] [libvirt-designer][PATCH 2/2] libvirt-designer-main.c: Re-indent function headers

2013-04-19 Thread Christophe Fergeau
ACK On Fri, Apr 19, 2013 at 11:24:31AM +0200, Michal Privoznik wrote: --- libvirt-designer/libvirt-designer-main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt-designer/libvirt-designer-main.c b/libvirt-designer/libvirt-designer-main.c index

Re: [libvirt] [libvirt-designer][PATCH 1/2] cfg.mk: Update list of syntax-check exceptions

2013-04-19 Thread Christophe Fergeau
ACK Christophe On Fri, Apr 19, 2013 at 11:24:30AM +0200, Michal Privoznik wrote: The bindtextdomain syntax-check macro is doing some dumb checking: each file containing '\main *(' must call bindtextdomain. Even if it's mentioned inside a comment block, which we do as of e71ad8e13e7. ---

Re: [libvirt] [Xen-devel] [PATCH RESENT 04/12] libxl: populate xenstore memory entries at startup

2013-04-19 Thread Stefano Stabellini
On Thu, 11 Apr 2013, Marek Marczykowski wrote: On 11.04.2013 09:52, Ian Campbell wrote: On Thu, 2013-04-11 at 05:09 +0100, Jim Fehlig wrote: +/* This will fill xenstore info about free and dom0 memory - if missing, + * should be called before starting first domain */ +if

Re: [libvirt] [PATCH designer] Adapt saner libtool versioning scheme from libvirt

2013-04-19 Thread Christophe Fergeau
On Fri, Apr 19, 2013 at 10:56:05AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The current way libtool versioning is calculated has a timebomb when the package version number changes to 1.0.0, which will cause the library soname to change. Adapt to the

Re: [libvirt] [Xen-devel] [PATCH RESENT 04/12] libxl: populate xenstore memory entries at startup

2013-04-19 Thread Marek Marczykowski
On 19.04.2013 13:10, Stefano Stabellini wrote: On Thu, 11 Apr 2013, Marek Marczykowski wrote: On 11.04.2013 09:52, Ian Campbell wrote: On Thu, 2013-04-11 at 05:09 +0100, Jim Fehlig wrote: +/* This will fill xenstore info about free and dom0 memory - if missing, + * should be called

Re: [libvirt] [PATCH designer] Increment soname + symbol versions

2013-04-19 Thread Christophe Fergeau
ACK, I was delaying handling that until a release appears on the radar, but it's indeed better to do it before we forget ;) Christophe On Fri, Apr 19, 2013 at 10:56:15AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The ABI of some methods was explicitly

Re: [libvirt] [PATCH glib] Adopt saner libtool versioning scheme from libvirt

2013-04-19 Thread Christophe Fergeau
On Fri, Apr 19, 2013 at 11:09:07AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The current way libtool versioning is calculated has a timebomb when the package version number changes to 1.0.0, which will cause the library soname to change. Adapt to the

Re: [libvirt] [libvirt-designer][PATCH] test: Add new SimpleDisk test

2013-04-19 Thread Christophe Fergeau
On Fri, Apr 19, 2013 at 12:49:23PM +0200, Michal Privoznik wrote: This test is meant for adding CDROM, floppy and disk to a domain. For now, each method has _file and _device variant, which are tested for now. Oh, thanks for writing that testcase! ACK Christophe ---

Re: [libvirt] [Xen-devel] [PATCH RESENT 04/12] libxl: populate xenstore memory entries at startup

2013-04-19 Thread Stefano Stabellini
On Fri, 19 Apr 2013, Marek Marczykowski wrote: And to answer you question - libvirt rely on libxl autoballoon. Could we introduce something similar to autoballoon=auto to libvirt? Maybe we should push down the autoballoon option to libxl: we should probably rename autoballoon to

Re: [libvirt] Reworked patch set to add UID/GID support for containers

2013-04-19 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/19/2013 05:58 AM, Daniel P. Berrange wrote: On Thu, Apr 18, 2013 at 02:34:49PM -0400, dwa...@redhat.com wrote: Combined all UID/GID patches, taken into account Dan Berrange feedback. Now UID will be based off the current UID. Sandbox

Re: [libvirt] [PATCH designer] Adapt saner libtool versioning scheme from libvirt

2013-04-19 Thread Daniel P. Berrange
On Fri, Apr 19, 2013 at 01:22:43PM +0200, Christophe Fergeau wrote: On Fri, Apr 19, 2013 at 10:56:05AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The current way libtool versioning is calculated has a timebomb when the package version number changes to

Re: [libvirt] [PATCH v2 1/1] Set legacy USB option with default for ppc64.

2013-04-19 Thread Li Zhang
On 2013年04月19日 18:31, Daniel P. Berrange wrote: On Mon, Apr 15, 2013 at 09:12:18PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -device xxx still can't work well for ppc64 platform. It's better use legacy USB option with default for ppc64. This patch is to

Re: [libvirt] [PATCHv2 1/6] virsh-domain: Refactor cmdVcpucount and fix output on inactive domains

2013-04-19 Thread Peter Krempa
On 04/19/13 01:27, Eric Blake wrote: On 04/16/2013 08:00 AM, Peter Krempa wrote: This patch factors out the vCPU count retrieval including fallback means into vshCPUCountCollect() and removes the duplicated code to retrieve individual counts. +#define PRINT_COUNT(VAR, MAX, STATE) if (VAR

[libvirt] [PATCHv2] conf: Reword error message to be more universal

2013-04-19 Thread Peter Krempa
The error message that warns user when a request to chagne/get persistent configuration of a transient domain is requested suggests that changes are being made. Reword it to be more universal and allow it to be used for getter APIs too. Before: $ virsh vcpucount transient-domain --config error:

[libvirt] [PATCHv2] network: bridge_driver: don't lose transient networks on daemon restart

2013-04-19 Thread Peter Krempa
Until now tranisent networks weren't really useful as libvirtd wasn't able to remember them across restarts. This patch adds support for loading status files of transient networks (that already were generated) so that the status isn't lost. This patch chops up virNetworkObjUpdateParseFile and

Re: [libvirt] [PATCH 5/5] qemu: launch bridge helper from libvirtd

2013-04-19 Thread Corey Bryant
[snip] I still don't like using qemu-bridge-helper, but this is better than the alternative of having qemu call it (although, due to the way that process capabilities works, we are unable to prevent a rogue qemu started by unprivileged libvirtd from calling it :-( Maybe we can introduce a

Re: [libvirt] [PATCH 5/5] qemu: launch bridge helper from libvirtd

2013-04-19 Thread Daniel P. Berrange
On Fri, Apr 19, 2013 at 09:47:05AM -0400, Corey Bryant wrote: [snip] I still don't like using qemu-bridge-helper, but this is better than the alternative of having qemu call it (although, due to the way that process capabilities works, we are unable to prevent a rogue qemu started by

Re: [libvirt] [PATCHv2] network: bridge_driver: don't lose transient networks on daemon restart

2013-04-19 Thread Laine Stump
On 04/19/2013 09:30 AM, Peter Krempa wrote: Until now tranisent networks weren't really useful as libvirtd wasn't able to remember them across restarts. This patch adds support for loading status files of transient networks (that already were generated) so that the status isn't lost. This

Re: [libvirt] [PATCH 1/1][RESEND] ppc64 cpu features

2013-04-19 Thread Jiri Denemark
On Thu, Mar 14, 2013 at 14:54:21 +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com This patch adds a CPU feature powernv identifying IBM Power processor that supports native hypervisor e.g. KVM. This can be used by virtualization management software to determine the CPU

Re: [libvirt] [PATCH 5/5] qemu: launch bridge helper from libvirtd

2013-04-19 Thread Corey Bryant
On 04/19/2013 09:51 AM, Daniel P. Berrange wrote: On Fri, Apr 19, 2013 at 09:47:05AM -0400, Corey Bryant wrote: [snip] I still don't like using qemu-bridge-helper, but this is better than the alternative of having qemu call it (although, due to the way that process capabilities works, we

Re: [libvirt] [PATCH 5/5] qemu: launch bridge helper from libvirtd

2013-04-19 Thread Daniel P. Berrange
On Fri, Apr 19, 2013 at 10:05:33AM -0400, Corey Bryant wrote: On 04/19/2013 09:51 AM, Daniel P. Berrange wrote: On Fri, Apr 19, 2013 at 09:47:05AM -0400, Corey Bryant wrote: [snip] I still don't like using qemu-bridge-helper, but this is better than the alternative of having qemu call

Re: [libvirt] [PATCHv2] conf: Reword error message to be more universal

2013-04-19 Thread Osier Yang
On 19/04/13 20:25, Peter Krempa wrote: The error message that warns user when a request to chagne/get s/a request to chagne\/get/changing\/getting/, persistent configuration of a transient domain is requested suggests Otherwise, a request ... is requested looks a bit awkward. :-) that

Re: [libvirt] [PATCHv2] network: bridge_driver: don't lose transient networks on daemon restart

2013-04-19 Thread Peter Krempa
On 04/19/13 16:03, Laine Stump wrote: On 04/19/2013 09:30 AM, Peter Krempa wrote: Until now tranisent networks weren't really useful as libvirtd wasn't able to remember them across restarts. This patch adds support for loading status files of transient networks (that already were generated) so

[libvirt] [PATCH] qemu: Enable the capability bit for -no-kvm-pit-reinjection on x86 only

2013-04-19 Thread Viktor Mihajlovski
From: Boris Fiuczynski fiu...@linux.vnet.ibm.com On architectures not supporting the Intel specific programmable interval timer, like e.g. S390, starting a domain with a clock definition containing a pit timer results in the error Option no-kvm-pit-reinjection not supported for this target. By

Re: [libvirt] [PATCH] rng: tighten up domain controller schema

2013-04-19 Thread Laine Stump
On 04/19/2013 04:32 AM, Osier Yang wrote: On 18/04/13 19:59, Laine Stump wrote: On 04/18/2013 07:27 AM, Osier Yang wrote: On 18/04/13 19:16, Laine Stump wrote: On 04/18/2013 05:41 AM, Martin Kletzander wrote: On 04/18/2013 11:05 AM, Osier Yang wrote: On 18/04/13 17:00, Martin Kletzander

Re: [libvirt] [PATCH v2 00/11] qemu: add PCI bridge support

2013-04-19 Thread Ján Tomko
On 04/17/2013 09:00 PM, Ján Tomko wrote: Add new 'pci' controller type with two models: pci-root - auto-added to a pc* machine, providing pci bus 0 pci-bridge - auto-added if the devices would not leave at least one slot empty on bus 0 or bus 0 is specified Ján Tomko (10): I've pushed

[libvirt] [PATCH] audit: properly encode device path in cgroup audit

2013-04-19 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=922186 Commit d04916fa introduced a regression in audit quality - even though the code was computing the proper escaped name for a path, it wasn't feeding that escaped name on to the audit message. As a result, /var/log/audit/audit.log would mention a

Re: [libvirt] [PATCH] audit: properly encode device path in cgroup audit

2013-04-19 Thread Laine Stump
On 04/19/2013 01:36 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=922186 Commit d04916fa introduced a regression in audit quality - even though the code was computing the proper escaped name for a path, it wasn't feeding that escaped name on to the audit message. As a

Re: [libvirt] [PATCH] audit: properly encode device path in cgroup audit

2013-04-19 Thread Eric Blake
On 04/19/2013 12:02 PM, Laine Stump wrote: On 04/19/2013 01:36 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=922186 Commit d04916fa introduced a regression in audit quality - even though the code was computing the proper escaped name for a path, it wasn't feeding that

[libvirt] [PATCH] docs: fix usage of 'onto'

2013-04-19 Thread Eric Blake
http://www.uhv.edu/ac/newsletters/writing/grammartip2009.07.01.htm (and several other sites) give hints that 'onto' is best used if you can also add 'up' just before it and still make sense. In many cases in the code base, we really want the two-word form, or even a simplification to just 'on' or

Re: [libvirt] [PATCH 5/5] qemu: launch bridge helper from libvirtd

2013-04-19 Thread Paolo Bonzini
Il 18/04/2013 19:32, Laine Stump ha scritto: On 03/25/2013 10:25 AM, Paolo Bonzini wrote: source type='bridge' uses a helper application to do the necessary TUN/TAP setup to use an existing network bridge, thus letting unprivileged users use TUN/TAP interfaces. However, libvirt should be

Re: [libvirt] USB pass-through with XEN

2013-04-19 Thread Jim Fehlig
Carlos Rodrigues wrote: Hello everybody, I try to doing USB pass-through with XEN hypervisor using libvirt and i get the following error: # virsh attach-device c6test /tmp/usb_device.xml error: Failed to attach device from /tmp/usb_device.xml error: unsupported configuration: unsupported