The naming conventions used for APIs in both src/driver.h and
src/remote/remote_protocol.x should follow the public API
naming, but there are a great many violations of this. This
series fixes them all, and adds some tests which will help
prevent regressions.
--
libvir-list mailing list
From: Daniel P. Berrange berra...@redhat.com
Ensure that the virDrvXXX method names exactly match
the public APIs virYYY method names. ie XXX == YYY.
Add a test case to prevent any regressions.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
docs/hvsupport.pl | 2 +-
From: Daniel P. Berrange berra...@redhat.com
There are many declared options in gendispatch.pl that were
no longer used. Those which were used were obsecure '-b', '-k'
and '-d'. Switch to use --mode={debug|client|server}.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
From: Daniel P. Berrange berra...@redhat.com
The driver.h struct for node devices used an inconsistent
naming scheme 'DeviceMonitor' instead of the more usual
'NodeDeviceDriver'. Fix this everywhere it has leaked
out to.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On 04/22/2013 04:43 PM, Laine Stump wrote:
On 04/22/2013 10:13 AM, Laine Stump wrote:
Of course in this case, we *could* avoid the camelCase vs underscore
entirely by just naming the attribute queues instead of numQueues or
num_queues (the fact that the attribute is a number makes it pretty
Add a dry run address allocation to figure out how many bridges
will be needed for all the devices without explicit addresses.
Auto-add just enough bridges to put all the devices on, or up to the
bridge with the largest specified index.
---
v4:
Moved the check for duplicate controller indexes to
Reject multiple controllers with the same index,
except for USB controllers.
Multi-function USB controllers can have the same index.
---
src/conf/domain_conf.c | 64 ++
1 file changed, 64 insertions(+)
diff --git a/src/conf/domain_conf.c
On 04/23/2013 12:24 AM, Eric Blake wrote:
On 04/22/2013 12:43 PM, Ján Tomko wrote:
qemuDomainPCIAddressGetNextSlot(qemuDomainPCIAddressSetPtr addrs,
virDevicePCIAddressPtr next_addr)
{
-virDevicePCIAddress tmp_addr = addrs-lastaddr;
-int i;
-
We are getting quite close to the end of the month, if we want
to stick to the 'end of month release' I guess we need to enter the
freeze for 1.0.5 at the end of the week say Friday, and then push
the release, assuming there is no big problem on Thursday next week
(May 2, I could probably do it
On Tue, Apr 23, 2013 at 08:53:00PM +0800, Daniel Veillard wrote:
We are getting quite close to the end of the month, if we want
to stick to the 'end of month release' I guess we need to enter the
freeze for 1.0.5 at the end of the week say Friday, and then push
the release, assuming there is
On 23.04.2013 14:53, Daniel Veillard wrote:
We are getting quite close to the end of the month, if we want
to stick to the 'end of month release' I guess we need to enter the
freeze for 1.0.5 at the end of the week say Friday, and then push
the release, assuming there is no big problem on
This series improves handling of automatic port allocation for spice consoles.
Peter Krempa (7):
qemu: Split out code to generate SPICE command line
qemu: Split out code to generate VNC command line
qemu: Use switch instead of ifs in qemuBuildGraphicsCommandLine
qemu: Split out SPICE port
Decrease size of qemuBuildGraphicsCommandLine() by splitting out
spice-related code into qemuBuildGraphicsVNCCommandLine().
This patch also fixes 2 possible memory leaks on error path in the code
that was split-out. The buffer containing the already generated options
and a listen address string
Decrease size of qemuBuildGraphicsCommandLine() by splitting out
spice-related code into qemuBuildGraphicsSPICECommandLine().
This patch also fixes 2 possible memory leaks on error path in the code
that was split-out. The buffer containing the already generated options
and a listen address string
Later on this function will be used to do more sophisticated checks and
determination if port allocation is needed.
---
src/qemu/qemu_process.c | 79 ++---
1 file changed, 49 insertions(+), 30 deletions(-)
diff --git a/src/qemu/qemu_process.c
Switch the function from a bunch of ifs to a switch statement with
correct type and reflow some code.
Also fix comment in enum describing possible graphics types
---
src/conf/domain_conf.h | 2 +-
src/qemu/qemu_command.c | 37 ++---
2 files changed, 19
With this patch, if the autoport attribute is used, the code will
sensibly auto allocate the ports only if needed.
---
src/qemu/qemu_process.c | 66 ++---
1 file changed, 52 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_process.c
Improve error reporting and generating of SPICE command line arguments
according to the need to enable TLS. If TLS is disabled, there's no need
to pass the certificate dir to qemu.
This patch resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=953126
---
src/qemu/qemu_command.c
With autoport enabled, both ports were alocated. With enabling
defaultMode or setting separate channel modes one of the ports may not
be needed. This will allow later on doing this kind of change.
---
docs/formatdomain.html.in | 2 +-
src/conf/domain_conf.c| 5 -
2 files changed, 1
https://bugzilla.redhat.com/show_bug.cgi?id=949373
Print the whole incorrect argument as specified by the user
instead of the short option.
Before:
$ virsh --debu
error: option '-d' requires an argument
$ virsh ---debu
error: unsupported option '-
$ virsh --debu c
error: option -d takes a
Hi All,
We are using libvirt 0.10.2 with hypervisor QEMU 0.14.1
We see that our hardware doesnt report any disk errors ( virsh domblkstat)
CENTOS(Libvirt version 0.9.4)
virsh # domblkstat fp-cla0 hda
hda rd_req 59837
hda rd_bytes 477478400
hda wr_req 462795
hda wr_bytes 5631972352
*hda errs 0
*
On 23.04.2013 16:08, Ján Tomko wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=949373
Print the whole incorrect argument as specified by the user
instead of the short option.
Before:
$ virsh --debu
error: option '-d' requires an argument
$ virsh ---debu
error: unsupported option '-
Yesterday for the first time I consciously noticed the
virNodeDeviceDettach and virNodeDeviceReAttach APIs, and found that they
are hardcoded to bind to/unbind from the pci-stub driver for qemu, and
the pciback driver for Xen. If we want these APIs to be useful for
VFIO, they will need to bind to
On 04/23/2013 04:25 PM, Michal Privoznik wrote:
On 23.04.2013 16:08, Ján Tomko wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=949373
Print the whole incorrect argument as specified by the user
instead of the short option.
Before:
$ virsh --debu
error: option '-d' requires an argument
On 04/23/2013 08:52 AM, Laine Stump wrote:
Yesterday for the first time I consciously noticed the
virNodeDeviceDettach and virNodeDeviceReAttach APIs, and found that they
are hardcoded to bind to/unbind from the pci-stub driver for qemu, and
the pciback driver for Xen. If we want these APIs to
---
src/qemu/qemu_command.c| 18 +-
.../qemuxml2argv-cpu-host-kvmclock.args| 2 +-
tests/qemuxml2argvdata/qemuxml2argv-cpu-kvmclock.args | 2 +-
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git
Jiri Denemark (2):
qemu: Move -enable-kvm and friends earlier in the command line
qemu: Use -machine accel=tcg|kvm when available
src/qemu/qemu_command.c| 141 -
.../qemuxml2argv-cpu-host-kvmclock.args| 2 +-
This is a better interface to choose accelerator than guessing whether
we should enable or disable kvm to get the right one.
---
src/qemu/qemu_command.c| 141 -
tests/qemuxml2argvdata/qemuxml2argv-kvm.args | 4 +
On Tue, Apr 09, 2013 at 19:05:28 +0200, Michal Privoznik wrote:
It's not desired to force users imagine path for a socket they
are not even supposed to connect to. On the other hand, we
already have a release where the qemu agent socket path is
exposed to XML, so we cannot silently drop it
On Mon, 2013-04-22 at 17:08 -0400, Laine Stump wrote:
(I'm not sure what you did differently when you sent this mail, but
somehow your mailer botched the In-Reply-To: header, which broke the
threaded display in Thunderbird. No big deal, but I thought you might
want to know.)
I expect this was
On Tue, Apr 23, 2013 at 10:52:09AM -0400, Laine Stump wrote:
Yesterday for the first time I consciously noticed the
virNodeDeviceDettach and virNodeDeviceReAttach APIs, and found that they
are hardcoded to bind to/unbind from the pci-stub driver for qemu, and
the pciback driver for Xen. If we
On 23.04.2013 14:53, Daniel Veillard wrote:
We are getting quite close to the end of the month, if we want
to stick to the 'end of month release' I guess we need to enter the
freeze for 1.0.5 at the end of the week say Friday, and then push
the release, assuming there is no big problem on
On Thu, Apr 18, 2013 at 12:00:09PM +0200, Peter Krempa wrote:
Hmm, okay that seems fair enough. The virDomainSetvcpus api has the
ideal name for this but mixing the semantics of disabling CPUs with
the angent and ripping them out from the hypervisor might lead to
user confusion.
In this
From: Daniel P. Berrange berra...@redhat.com
It will simplify later work if the sub-drivers have dedicated
APIs / field names. ie virNetworkDriver should have
virDrvNetworkOpen and virDrvNetworkClose methods
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
docs/hvsupport.pl
On 04/23/2013 08:08 AM, Ján Tomko wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=949373
Print the whole incorrect argument as specified by the user
instead of the short option.
case 'd':
if (virStrToLong_i(optarg, NULL, 10, debug) 0) {
-
On Tue, Apr 23, 2013 at 05:11:55PM +0200, Jiri Denemark wrote:
This is a better interface to choose accelerator than guessing whether
we should enable or disable kvm to get the right one.
---
src/qemu/qemu_command.c| 141
-
On Tue, Apr 23, 2013 at 03:46:08PM +0200, Peter Krempa wrote:
Decrease size of qemuBuildGraphicsCommandLine() by splitting out
spice-related code into qemuBuildGraphicsSPICECommandLine().
This patch also fixes 2 possible memory leaks on error path in the code
that was split-out. The buffer
On Tue, Apr 23, 2013 at 03:46:10PM +0200, Peter Krempa wrote:
Switch the function from a bunch of ifs to a switch statement with
correct type and reflow some code.
Also fix comment in enum describing possible graphics types
---
src/conf/domain_conf.h | 2 +-
src/qemu/qemu_command.c | 37
On 04/23/2013 11:37 AM, james robson wrote:
On Mon, 2013-04-22 at 17:08 -0400, Laine Stump wrote:
(I'm not sure what you did differently when you sent this mail, but
somehow your mailer botched the In-Reply-To: header, which broke the
threaded display in Thunderbird. No big deal, but I thought
On Tue, Apr 23, 2013 at 03:46:09PM +0200, Peter Krempa wrote:
Decrease size of qemuBuildGraphicsCommandLine() by splitting out
spice-related code into qemuBuildGraphicsVNCCommandLine().
This patch also fixes 2 possible memory leaks on error path in the code
that was split-out. The buffer
On Tue, Apr 23, 2013 at 03:46:12PM +0200, Peter Krempa wrote:
With autoport enabled, both ports were alocated. With enabling
defaultMode or setting separate channel modes one of the ports may not
be needed. This will allow later on doing this kind of change.
---
docs/formatdomain.html.in | 2
On Tue, Apr 23, 2013 at 03:46:11PM +0200, Peter Krempa wrote:
Later on this function will be used to do more sophisticated checks and
determination if port allocation is needed.
---
src/qemu/qemu_process.c | 79
++---
1 file changed, 49
On 04/23/2013 07:46 AM, Peter Krempa wrote:
With autoport enabled, both ports were alocated. With enabling
s/alocated/allocated/
defaultMode or setting separate channel modes one of the ports may not
be needed. This will allow later on doing this kind of change.
---
On Tue, Apr 23, 2013 at 05:11:54PM +0200, Jiri Denemark wrote:
---
src/qemu/qemu_command.c| 18
+-
.../qemuxml2argv-cpu-host-kvmclock.args| 2 +-
tests/qemuxml2argvdata/qemuxml2argv-cpu-kvmclock.args | 2 +-
3 files
This work isn't finished, but since there's a freeze coming up in a
few days, I thought I should send these patches that *are* finished to
get them out of the way before the last minute rush.
Patch 1 is trivial.
Patch 2 is longer, but completely mechanical (NOTE: there may be some
uses of that
There will soon be other items related to pci hostdevs that need to be
in the same part of the hostdevsubsys union as the pci address (which
is currently a single member called pci. This patch replaces the
single member named pci with a struct named pci that contains a single
member named addr.
On 04/23/2013 09:52 AM, Daniel P. Berrange wrote:
Any other design or naming suggestions are welcome.
Since 'cpu_id' in this refers to the guest OS' notion of CPUs,
do we need some way to expose what the guest OS considers the
CPU IDs to be.
Qemu is still working on that point. For 1.5,
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index ef291c0..0a3fb06 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -220,6
A domain's interface or hostdev, as well as a network's
forward, can now have an optional driver name='kvm|vfio'/
element. As of this patch, there is no functionality behind this new
knob - this patch adds support to the domain and network
formatter/parser, and to the RNG and documentation.
When
On 04/23/2013 04:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
There are many declared options in gendispatch.pl that were
no longer used. Those which were used were obsecure '-b', '-k'
s/obsecure/obscure/
and '-d'. Switch to use
On 04/23/2013 11:46 AM, Daniel P. Berrange wrote:
On Tue, Apr 23, 2013 at 10:52:09AM -0400, Laine Stump wrote:
Yesterday for the first time I consciously noticed the
virNodeDeviceDettach and virNodeDeviceReAttach APIs, and found that they
are hardcoded to bind to/unbind from the pci-stub
On Tue, 2013-04-23 at 12:13 -0400, Laine Stump wrote:
Also, is it valid to have a native_mode/native_tag if trunk='no'? (right
now trunk is automatically set to 'yes' if there is more than one vlan
tag)
It isn't valid to have trunk='no' and the native settings. Therefore
vlan
On 04/23/13 18:21, Daniel P. Berrange wrote:
On Tue, Apr 23, 2013 at 03:46:12PM +0200, Peter Krempa wrote:
With autoport enabled, both ports were alocated. With enabling
defaultMode or setting separate channel modes one of the ports may not
be needed. This will allow later on doing this kind of
On Mon, Apr 22, 2013 at 02:37:06PM -0600, Eric Blake wrote:
On 04/22/2013 01:00 PM, Eduardo Habkost wrote:
This property will be useful for libvirt, as libvirt already has logic
based on low-level feature bits (not feature names), so it will be
really easy to convert the current libvirt
On 04/23/2013 04:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
A number of the remote procedure names did not match the
corresponding API names. For example, many lacked the
word 'CONNECT', others re-arranged the names. Update the
procedures so their names
On Tue, Apr 23, 2013 at 17:11:53 +0200, Jiri Denemark wrote:
Jiri Denemark (2):
qemu: Move -enable-kvm and friends earlier in the command line
qemu: Use -machine accel=tcg|kvm when available
src/qemu/qemu_command.c| 141
-
On 04/23/13 18:16, Daniel P. Berrange wrote:
On Tue, Apr 23, 2013 at 03:46:11PM +0200, Peter Krempa wrote:
Later on this function will be used to do more sophisticated checks and
determination if port allocation is needed.
---
src/qemu/qemu_process.c | 79
On 04/23/2013 04:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Ensure that the virDrvXXX method names exactly match
the public APIs virYYY method names. ie XXX == YYY.
Add a test case to prevent any regressions.
Signed-off-by: Daniel P. Berrange
[PATCH] Fuse file system mounted at /proc/meminfo needs correct
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: Dan Walsh dwa...@redhat.com
Currently the /proc/meminfo is labeled fusefs_t rather then proc_t.
SELinux blocks openshift instances from reading fusefs_t, this
patch sets the file to the default label of /proc/meminfo
---
.gnulib | 2 +-
src/lxc/lxc_container.c | 25
On 04/23/2013 04:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Ensure that the driver struct field names match the public
API names. For an API vir we must have a driver struct
field x. ie strip the leading 'vir' and lowercase any
leading uppercase
On 04/23/2013 09:57 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
It will simplify later work if the sub-drivers have dedicated
APIs / field names. ie virNetworkDriver should have
virDrvNetworkOpen and virDrvNetworkClose methods
Signed-off-by: Daniel P.
On 04/23/2013 09:57 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Ensure that all drivers implementing public APIs use a
naming convention for their implementation that matches
the public API name.
eg for the public API virDomainCreate make sure QEMU
uses
On 04/23/2013 04:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The driver.h file has no consistent indentation usage across
all the typedefs. Attempts to vertically align struct field
members have also been inconsistently applied. Sanitize the
whitespace used
On 04/23/2013 04:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The driver.h struct for node devices used an inconsistent
naming scheme 'DeviceMonitor' instead of the more usual
'NodeDeviceDriver'. Fix this everywhere it has leaked
out to.
Signed-off-by:
On 04/23/2013 02:22 PM, dwa...@redhat.com wrote:
From: Dan Walsh dwa...@redhat.com
Currently the /proc/meminfo is labeled fusefs_t rather then proc_t.
SELinux blocks openshift instances from reading fusefs_t, this
patch sets the file to the default label of /proc/meminfo
---
.gnulib
On 04/23/2013 05:32 AM, Martin Kletzander wrote:
On 04/22/2013 04:43 PM, Laine Stump wrote:
On 04/22/2013 10:13 AM, Laine Stump wrote:
Of course in this case, we *could* avoid the camelCase vs underscore
entirely by just naming the attribute queues instead of numQueues or
num_queues (the fact
On 04/23/2013 09:40 AM, Jiri Denemark wrote:
On Tue, Apr 09, 2013 at 19:05:28 +0200, Michal Privoznik wrote:
It's not desired to force users imagine path for a socket they
are not even supposed to connect to. On the other hand, we
already have a release where the qemu agent socket path is
On 04/23/2013 10:45 AM, Laine Stump wrote:
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 4 insertions(+)
ACK
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
On 04/23/2013 07:46 AM, Peter Krempa wrote:
With this patch, if the autoport attribute is used, the code will
sensibly auto allocate the ports only if needed.
---
src/qemu/qemu_process.c | 66
++---
1 file changed, 52 insertions(+), 14
On 04/23/2013 10:45 AM, Laine Stump wrote:
There will soon be other items related to pci hostdevs that need to be
in the same part of the hostdevsubsys union as the pci address (which
is currently a single member called pci. This patch replaces the
single member named pci with a struct named
On 04/22/2013 08:32 PM, yue wrote:
hi,all:
if xml configuration is not right?
cpu match=exact
modelNehalem/model
topology cores=1 sockets=1 threads=1/
/cpu
thanks
You didn't give enough details for us to answer your question. What
command are
On 04/23/2013 10:45 AM, Laine Stump wrote:
A domain's interface or hostdev, as well as a network's
forward, can now have an optional driver name='kvm|vfio'/
element. As of this patch, there is no functionality behind this new
knob - this patch adds support to the domain and network
On 04/23/2013 07:46 AM, Peter Krempa wrote:
Improve error reporting and generating of SPICE command line arguments
according to the need to enable TLS. If TLS is disabled, there's no need
to pass the certificate dir to qemu.
This patch resolves:
On 04/23/2013 07:44 PM, Eric Blake wrote:
On 04/23/2013 05:32 AM, Martin Kletzander wrote:
On 04/22/2013 04:43 PM, Laine Stump wrote:
On 04/22/2013 10:13 AM, Laine Stump wrote:
Of course in this case, we *could* avoid the camelCase vs underscore
entirely by just naming the attribute queues
On 04/23/2013 07:34 PM, Eric Blake wrote:
On 04/23/2013 10:45 AM, Laine Stump wrote:
A domain's interface or hostdev, as well as a network's
forward, can now have an optional driver name='kvm|vfio'/
element. As of this patch, there is no functionality behind this new
knob - this patch adds
Nearly a question for the users list, but I might be encountering a bug too.
I'm using virtlockd with 'auto_disk_leases = 0' and struggle with the
correct configuration for a lease in the domXML. Using
lease
lockspacetest-ls/lockspace
keytest-lock/key
target
On 24/04/13 11:25, Laine Stump wrote:
On 04/23/2013 07:44 PM, Eric Blake wrote:
On 04/23/2013 05:32 AM, Martin Kletzander wrote:
On 04/22/2013 04:43 PM, Laine Stump wrote:
On 04/22/2013 10:13 AM, Laine Stump wrote:
Of course in this case, we *could* avoid the camelCase vs underscore
entirely
78 matches
Mail list logo
