Re: [libvirt] [PATCH] util: Prevent libvirtd crash from virPCIDeviceAddressIsEqual()

2013-04-28 Thread Laine Stump
On 04/28/2013 06:12 AM, Alex Jia wrote: > GDB backtrace: > > Breakpoint 1, virPCIGetVirtualFunctionIndex > (pf_sysfs_device_link=0x7fc04400f470 "/sys/bus/pci/devices/:03:00.1", > vf_sysfs_device_link=, vf_index=vf_index@entry=0x7fc06897b8f4) > at util/virpci.c:2107 > 2107if (v

Re: [libvirt] [PATCH 4/4] qemu: query command line options in QMP

2013-04-28 Thread Paolo Bonzini
Il 26/04/2013 23:01, Eric Blake ha scritto: > (for example, -net uses > an old-style parser, so it shows up with no parameters) This is not really correct. -net (and in 1.6, -drive will too) uses the same parser, but is a "polymorphic" option so it uses a different kind of validation. This shoul

[libvirt] [PATCH] util: Prevent libvirtd crash from virPCIDeviceAddressIsEqual()

2013-04-28 Thread Alex Jia
GDB backtrace: Breakpoint 1, virPCIGetVirtualFunctionIndex (pf_sysfs_device_link=0x7fc04400f470 "/sys/bus/pci/devices/:03:00.1", vf_sysfs_device_link=, vf_index=vf_index@entry=0x7fc06897b8f4) at util/virpci.c:2107 2107if (virPCIDeviceAddressIsEqual(vf_bdf, virt_fns[i])) { (gd