[libvirt] Build failed in Jenkins: libvirt-syntax-check #944

See -- Started by upstream project "libvirt-build" build number 1052 Started by upstream project "libvirt-build" build number 1053 Building in workspace

Re: [libvirt] [PATCH] virInitctlRequest: Don't hardcode 384 bytes size

On Wed, May 01, 2013 at 02:48:35PM -0600, Eric Blake wrote: > On 05/01/2013 02:39 PM, Guido Günther wrote: > > When MAXHOSTNAMELEN is set we have to take it's value into account. > > Otherwise the build fails on kFreeBSD (FreeBSD kernel and GNU userland) > > --- > > src/util/virinitctl.c |6 ++

Re: [libvirt] [PATCH] util: Prevent libvirtd crash from virPCIDeviceAddressIsEqual()

On 04/29/2013 02:48 AM, Laine Stump wrote: On 04/28/2013 06:12 AM, Alex Jia wrote: GDB backtrace: Breakpoint 1, virPCIGetVirtualFunctionIndex (pf_sysfs_device_link=0x7fc04400f470 "/sys/bus/pci/devices/:03:00.1", vf_sysfs_device_link=, vf_index=vf_index@entry=0x7fc06897b8f4) at util/v

Re: [libvirt] License issues

On 05/01/2013 09:54 AM, Eric Blake wrote: > > Qemu has announced that they are delaying their release of 1.5 in part > because of a license problem [1]. I'm wondering if we need to follow > qemu's lead and possibly delay the release of libvirt 1.0.5 if we don't > have a fix in time (at any rate,

[libvirt] [PATCH 3/3] build: fall back to libedit if libvirt.so is crippled

Vbox source code used in libvirt.git is LGPLv2-only. If linked into libvirt.so, then we are legally forbidden from linking an app against both that libvirt.so and any GPLv3 code, such as libreadline. While we'd like to fix libvirt.so to be LGPLv2+ in the future, regardless of whether vbox support

[libvirt] [PATCH 0/3] Fix license violation of virsh when vbox is enabled

See the big hairy analysis here: https://www.redhat.com/archives/libvir-list/2013-May/msg00030.html I feel comfortable enough with these patches that I'm hoping to get them into libvirt 1.0.5, while saving the bigger task of refactoring vbox support into libvirtd out to libvirt 1.0.6. Eric Blake

[libvirt] [PATCH 1/3] build: move readline check into its own macro

Future patches will allow the use of editline in place of readline; doing this in an isolated file instead of configure.ac will make the task easier. We can't quite use LIBVIRT_CHECK_LIB, since we do a double probe based on what other libraries might be needed for successful linking; as such, I al

[libvirt] [PATCH 2/3] build: check for libedit

libedit is a BSD library that provides partial functionality of readline; useful if you can't use GPLv3 readline. The next patch will need to know if this library is present. * m4/virt-edit.m4: New file. * configure.ac: Use it. Signed-off-by: Eric Blake --- configure.ac| 2 ++ m4/virt-edi

Re: [libvirt] [PATCH] esx: Reduce code duplication in generator

On 05/01/2013 12:44 PM, Matthias Bolte wrote: > --- > src/esx/esx_vi_generator.py | 430 > --- > 1 file changed, 118 insertions(+), 312 deletions(-) My python is weak, so I reviewed this by comparing the generated files before and after this patch; added

Re: [libvirt] [PATCH] pci: autolearn name of stub driver, remove from arglist

On 05/01/2013 12:54 PM, Laine Stump wrote: > virPCIDeviceReattach and virPCIDeviceUnbindFromStub (called by > virPCIDeviceReattach) had previously required the name of the stub > driver as input. This is unnecessary, because the name of the driver > the device is currently bound to can be found by

Re: [libvirt] [PATCH 1/2] spec: collect all BuildRequires into one area

On 05/01/2013 03:22 PM, Laine Stump wrote: > On 05/01/2013 04:32 PM, Eric Blake wrote: >> Conditional BuildRequires: should be at the top level, rather >> than appearing in conditional sub-package sections. This >> appears to be the only offender. >> >> * libvirt.spec.in (BuildRequires): Move libb

Re: [libvirt] [Qemu-devel] [PATCH qom-cpu 4/9] target-i386: Replace cpuid_*features fields with a feature word array

Am 22.04.2013 21:00, schrieb Eduardo Habkost: > This replaces the feature-bit fields on both X86CPU and x86_def_t > structs with an array. > > With this, we will be able to simplify code that simply does the same > operation on all feature words (e.g. kvm_check_features_against_host(), > filter_fe

Re: [libvirt] [Qemu-devel] [PATCH qom-cpu 2/9] target-i386/kvm.c: Code formatting changes

Am 22.04.2013 21:00, schrieb Eduardo Habkost: > Add appropriate spaces around operators, and break line where it needs > to be broken to allow feature-words array to be introduced without > having too-long lines. > > Signed-off-by: Eduardo Habkost > Reviewed-By: Igor Mammedov > --- > Changes v9:

Re: [libvirt] [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

Am 22.04.2013 21:00, schrieb Eduardo Habkost: > This series includes the previous "replace cpuid_*features fields with a > feature > word array" series. > > The first 4 patches already have a Reviewed-by from Igor, they correspond to > v10 > plus a small indent fix requested by him. > > As the

Re: [libvirt] [PATCH 1/2] spec: collect all BuildRequires into one area

On 05/01/2013 04:32 PM, Eric Blake wrote: > Conditional BuildRequires: should be at the top level, rather > than appearing in conditional sub-package sections. This > appears to be the only offender. > > * libvirt.spec.in (BuildRequires): Move libblkid-devel into > correct area. > > Signed-off-by:

Re: [libvirt] [PATCH] virInitctlRequest: Don't hardcode 384 bytes size

On 05/01/2013 02:39 PM, Guido Günther wrote: > When MAXHOSTNAMELEN is set we have to take it's value into account. > Otherwise the build fails on kFreeBSD (FreeBSD kernel and GNU userland) > --- > src/util/virinitctl.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) ACK. Qualifie

[libvirt] [PATCH] virInitctlRequest: Don't hardcode 384 bytes size

When MAXHOSTNAMELEN is set we have to take it's value into account. Otherwise the build fails on kFreeBSD (FreeBSD kernel and GNU userland) --- src/util/virinitctl.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/util/virinitctl.c b/src/util/virinitctl.c index 1618

[libvirt] [PATCH 0/2] spec file fixups

Here's a couple of spec file cleanups that should go in prior to 1.0.5, particularly since the FPC recently changed packaging guidelines because of an issue highlighted in libvirt's spec file. Eric Blake (2): spec: collect all BuildRequires into one area spec: proper soft static allocation of

[libvirt] [PATCH 2/2] spec: proper soft static allocation of qemu uid

https://bugzilla.redhat.com/show_bug.cgi?id=924501 tracks a problem that occurs if uid 107 is already in use at the time libvirt is first installed. In response that problem, Fedora packaging guidelines were recently updated. This fixes the spec file to comply with the new guidelines: https://fed

[libvirt] [PATCH 1/2] spec: collect all BuildRequires into one area

Conditional BuildRequires: should be at the top level, rather than appearing in conditional sub-package sections. This appears to be the only offender. * libvirt.spec.in (BuildRequires): Move libblkid-devel into correct area. Signed-off-by: Eric Blake --- libvirt.spec.in | 6 -- 1 file cha

Re: [libvirt] [PATCH] pci: autolearn name of stub driver, remove from arglist

Oops. I had a leak in the patch as sent! I'll squash this in before I push: diff --git a/src/util/virpci.c b/src/util/virpci.c index 8d0dec8..5d7e19e 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -1028,6 +1028,7 @@ cleanup: VIR_FREE(drvdir); VIR_FREE(path); +VIR_FREE(

[libvirt] [PATCH] pci: autolearn name of stub driver, remove from arglist

virPCIDeviceReattach and virPCIDeviceUnbindFromStub (called by virPCIDeviceReattach) had previously required the name of the stub driver as input. This is unnecessary, because the name of the driver the device is currently bound to can be found by looking at the link: /sys/bus/pci/:bb:ss.ff/

Re: [libvirt] [libvirt-glib] Rename misnamed 'conn' variable everywhere

On Wed, May 01, 2013 at 07:56:54PM +0200, Christophe Fergeau wrote: > Through copy and paste from libvirt-gobject-connection.c, we end > up with an instance variable named 'conn' in most of our classes > even if we are not manipulating a connection object. This commit > renames it all 'conn' occurr

Re: [libvirt] [libvirt-glib] gconfig: Fix gvir_config_domain_graphics_new_from_tree

On Wed, May 01, 2013 at 07:56:35PM +0200, Christophe Fergeau wrote: > It does not handle the recently added > GVirConfigDomainGraphicsRdp and GVirConfigDomainGraphicsDesktop > classes. > --- > libvirt-gconfig/libvirt-gconfig-domain-graphics.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 dele

[libvirt] [PATCH] esx: Reduce code duplication in generator

--- src/esx/esx_vi_generator.py | 430 --- 1 file changed, 118 insertions(+), 312 deletions(-) diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py index 7130624..547eef6 100755 --- a/src/esx/esx_vi_generator.py +++ b/src/esx/esx_vi_gener

[libvirt] [libvirt-glib] Rename misnamed 'conn' variable everywhere

Through copy and paste from libvirt-gobject-connection.c, we end up with an instance variable named 'conn' in most of our classes even if we are not manipulating a connection object. This commit renames it all 'conn' occurrences in libvirt-gobject and libvirt-gconfig with a name more consistent wit

[libvirt] [libvirt-glib] gconfig: Fix gvir_config_domain_graphics_new_from_tree

It does not handle the recently added GVirConfigDomainGraphicsRdp and GVirConfigDomainGraphicsDesktop classes. --- libvirt-gconfig/libvirt-gconfig-domain-graphics.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics.c b/libv

[libvirt] [PATCH] docs: Fix closing tag in snapshot documentation

Commit cc6d19f3 added text containing "snapshot" to formatsnapshot.html.in. The closing tag is missing '/' which causes the documentation to misrender. --- Pushed under the trivial rule. docs/formatsnapshot.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatsn

Re: [libvirt] Entering freeze for libvirt-1.0.5

On Fri, Apr 26, 2013 at 04:09:59PM +0800, Daniel Veillard wrote: > So as discussed earlier this week, I have tagged the release candidate 1 > of libvirt-1.0.5 in git and pushed the tarball and associated rpms to > the FTP at: >ftp://libvirt.org/libvirt/ > > We may still push some of the patc

Re: [libvirt] Should we keep the original vnc behavior even if the underlying qemu changes?

On 05/01/2013 08:43 AM, Guan Nan Ren wrote: > Since qemu v1.1.0 upstream commit 8cf364, qemu implemented > shared-flag handling > the default qemu vnc server behavior from mode 'ignore' to > 'allow-exclusive'. > The direct effect is as follows for libvirt user: > v

Re: [libvirt] License issues

On Wed, May 01, 2013 at 06:24:00PM +0200, Matthias Bolte wrote: > 2013/5/1 Eric Blake : > > Implementation wise, this would mean that we compile the vbox driver as > > an independent module (much the same as we do for qemu or lxc), and link > > that module into libvirtd rather than into libvirt.so

Re: [libvirt] License issues

2013/5/1 Eric Blake : > Implementation wise, this would mean that we compile the vbox driver as > an independent module (much the same as we do for qemu or lxc), and link > that module into libvirtd rather than into libvirt.so directly. In > libvirt.so, attempts to use a vbox:// URI would then be

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

Ian Campbell wrote: > On Wed, 2013-05-01 at 15:31 +0100, Jim Fehlig wrote: > >> Ian Campbell wrote: >> >>> On Wed, 2013-05-01 at 04:42 +0100, Jim Fehlig wrote: >>> >>> David Scott wrote: > Hi, > > [added xen-devel: FYI this is about how to

[libvirt] [PATCH 1/2] lxc: Coverity false positive USE_AFTER_FREE

--- src/lxc/lxc_container.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index ac0f69c..d082a06 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -1772,6 +1772,11 @@ static int lxcContainerSetupPivotRoot(virDomainDef

[libvirt] License issues

tl:dr; summary: It was pointed out to me off-list that libvirt has a licensing issue depending on how it is configured, present since 0.6.3 (introduction of vbox:// URI in commit 10d16508 in April 2009), and which has caused at least libvirt itself to risk shipping non-compliant binaries (at least

[libvirt] [PATCH 0/2] Resolve Coverity issues

The following patches resolve a couple of Coverity issues. The 'lxc' change is merely a work-around by adding a Coverity tag to avoid what I consider to be a false positive. Another option to resolving is to change the code in lxcContainerPrepareRoot() to assign 'tmp = root->src' and then VIR_FRE

[libvirt] [PATCH 2/2] virsh: Resolve Coverity 'MISSING_BREAK'

Recent commit '53531e16' resulted in a new Coverity warning regarding a missing break in the ':' options processing. Adjust the commit to avoid the issue. --- tools/virsh.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index ac86608..6

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

On Wed, 2013-05-01 at 16:40 +0100, Jim Fehlig wrote: > > This is still all advanced usage, the majority of users should specify > > neither the version nor the path, libxl will just do the right thing for > > them. If the libvirt bindings is trying to insert a path in the "pick a > > sane default"

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

On Wed, 2013-05-01 at 15:31 +0100, Jim Fehlig wrote: > Ian Campbell wrote: > > On Wed, 2013-05-01 at 04:42 +0100, Jim Fehlig wrote: > > > >> David Scott wrote: > >> > >>> Hi, > >>> > >>> [added xen-devel: FYI this is about how to properly set the libxl > >>> device_model_version when the us

Re: [libvirt] Bug Reports

2013/4/23 Dennis Zou (yunzou) : > 1.Lost soapAction in http request header > > When I tried to retrieve the property of storage.perDatastoreUsage > under specify virtual machine and got a invalidProperty error but other > properties(e.g. summary.storage, guest) under the same virtual machin

[libvirt] Should we keep the original vnc behavior even if the underlying qemu changes?

Hi Everybody, Since qemu v1.1.0 upstream commit 8cf364, qemu implemented shared-flag handling the default qemu vnc server behavior from mode 'ignore' to 'allow-exclusive'. The direct effect is as follows for libvirt user: vncviwer client: before:

[libvirt] libvirt-snmp on Ubuntu

Hi, Are there packages of "libvirt-snmp" for Ubuntu? Or instructions to compile libvirt-snmp on Ubuntu? Looks like the instructions given at http://wiki.libvirt.org/page/Libvirt-snmp are for RedHat. Thank you, George -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mai

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

Ian Campbell wrote: > On Wed, 2013-05-01 at 04:42 +0100, Jim Fehlig wrote: > >> David Scott wrote: >> >>> Hi, >>> >>> [added xen-devel: FYI this is about how to properly set the libxl >>> device_model_version when the user has provided a manual device_model >>> override (aka a path to a qem

[libvirt] [sandbox PATCH v2] Add a option --package if rpm autodetection fail

https://bugzilla.redhat.com/show_bug.cgi?id=954187 If someone use a custom unit file for the sandbox, the rpm autodetection fail with a exception. Now, this will show a error message, asking to use --package and use this rpm if autodetection fail. --- bin/virt-sandbox-service| 46

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

On Wed, May 01, 2013 at 02:44:11PM +0100, David Scott wrote: > On 01/05/13 09:46, Ian Campbell wrote: > >I would suggest that libvirt+libxl expose the version as the "emulator" > >option and not the path. Just leave the path as the default in the > >normal case. You may also want to provide an extr

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

On 01/05/13 09:46, Ian Campbell wrote: I would suggest that libvirt+libxl expose the version as the "emulator" option and not the path. Just leave the path as the default in the normal case. You may also want to provide an extra emulator-path-override tag/attribute/XML for advanced users, but tha

[libvirt] [sandbox PATCH] Add a option --package if rpm autodetection fail

https://bugzilla.redhat.com/show_bug.cgi?id=954187 If someone use a custom unit file for the sandbox, the rpm autodetection fail with a exception. Now, this will show a error message, asking to use --package and use this rpm if autodetection fail. --- bin/virt-sandbox-service| 46

Re: [libvirt] [sandbox PATCH] Add a option --rpm if rpm autodetection fail

Le mercredi 01 mai 2013 à 13:20 +0100, Daniel P. Berrange a écrit : > On Wed, May 01, 2013 at 01:13:55PM +0200, Michael Scherer wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=954187 > > > > If someone use a custom unit file for the sandbox, the rpm > > autodetection fail with a exception.

Re: [libvirt] [PATCH] ESX: Fix DISPATCH_FREE generation code to free all extended objects

2013/1/2 Ata E Husain Bohra : > Python code generator "generate_source" section that handles > code generation to "free" inherited objects needs to generate > DISPATCH_FREE calls for all extended_by objects. > --- > src/esx/esx_vi_generator.py | 21 ++--- > 1 file changed, 18 ins

Re: [libvirt] [sandbox PATCH] Add a option --rpm if rpm autodetection fail

On Wed, May 01, 2013 at 01:13:55PM +0200, Michael Scherer wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=954187 > > If someone use a custom unit file for the sandbox, the rpm > autodetection fail with a exception. Now, this will show > a error message, asking to use --rpm and use this rpm if

[libvirt] [sandbox PATCH] Add a option --rpm if rpm autodetection fail

https://bugzilla.redhat.com/show_bug.cgi?id=954187 If someone use a custom unit file for the sandbox, the rpm autodetection fail with a exception. Now, this will show a error message, asking to use --rpm and use this rpm if autodetection fail. --- bin/virt-sandbox-service | 46 +++

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

On Wed, 2013-05-01 at 04:42 +0100, Jim Fehlig wrote: > David Scott wrote: > > Hi, > > > > [added xen-devel: FYI this is about how to properly set the libxl > > device_model_version when the user has provided a manual device_model > > override (aka a path to a qemu) in the libvirt domain XML.] > > >

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

On Tue, Apr 30, 2013 at 09:42:59PM -0600, Jim Fehlig wrote: > David Scott wrote: > > Hi, > > > > [added xen-devel: FYI this is about how to properly set the libxl > > device_model_version when the user has provided a manual device_model > > override (aka a path to a qemu) in the libvirt domain XML.

Re: [libvirt] [PATCHv2] rpc: message related sizes enlarged

On Tue, Apr 30, 2013 at 05:47:03PM -0600, Eric Blake wrote: > On 04/26/2013 05:59 AM, Viktor Mihajlovski wrote: > > From: Daniel Hansel > > > > We have seen an issue on s390x platform where domain XMLs larger than 1MB > > were used. The define command was finished successfully. The dumpxml comman

Re: [libvirt] [PATCH v2 3/5] Add a helper API for setting up a NBD device with qemu-nbd

On Tue, Apr 30, 2013 at 05:55:15PM -0600, Eric Blake wrote: > On 04/22/2013 08:06 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Add a virFileNBDDeviceAssociate method, which given a filename > > will setup a NBD device, using qemu-nbd as the server. > > > > Signed-off-by: