On Thu, May 09, 2013 at 06:22:17PM +0800, Osier Yang wrote:
When the numatune memory mode is not strict, the cpuset.mems
inherits the parent's setting, which causes problem like:
% virsh dumpxml rhel6_local | grep interleave -2
vcpu placement='static'2/vcpu
numatune
memory
On 04/30/2013 06:21 PM, Eric Blake wrote:
On 04/30/2013 09:18 AM, John Ferlan wrote:
On 04/30/2013 10:42 AM, Martin Kletzander wrote:
Adding support for new attribute 'websocket' in the 'graphics'
element, the attribute value is the port to listen on with '-1'
meaning auto-allocation, '0'
Hey,
This v2 has 3 more patches than the initial series, they were needed to address
various issues with the initial series. 3/6 is not strictly needed, I'm still
undecided
as to whether it makes things nicer or not, so it's open for discussion (the
deprecation
it introduces would be triggered
This is used to tell the compiler about printf-like format strings
used by some functions. Without this marking, gcc 4.8 is outputs
warnings to recommend using it.
---
libvirt-glib/libvirt-glib-error.c | 3 +++
libvirt-glib/libvirt-glib-error.h | 12 ++--
2 files changed, 9
---
libvirt-gconfig/Makefile.am| 3 +
.../libvirt-gconfig-domain-snapshot-disk.c | 88 ++
.../libvirt-gconfig-domain-snapshot-disk.h | 68 +
.../libvirt-gconfig-domain-snapshot-private.h | 38 ++
libvirt commit
http://libvirt.org/git/?p=libvirt.git;a=commit;h=e2c41e486018ee74f6a75c1f717622
strongly hints that driver type for a disk domain should be an
enum rather than a raw string. Since we already have setters/getters
for this attribute, the alternate versions have an _enum suffix.
I did
This will be useful when implementing gvir_domain_snapshot_get_parent()
as the child node 'parent' is not always present in the XML.
---
libvirt-gconfig/libvirt-gconfig-object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-object.c
---
libvirt-gconfig/libvirt-gconfig-domain-snapshot.c | 252 +-
libvirt-gconfig/libvirt-gconfig-domain-snapshot.h | 48 -
libvirt-gconfig/libvirt-gconfig.sym | 18 ++
3 files changed, 316 insertions(+), 2 deletions(-)
diff --git
automake outputs a warning about AM_CPPFLAGS being the recommended
name to use for INCLUDES
---
libvirt-gconfig/tests/Makefile.am | 2 +-
python/Makefile.am| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt-gconfig/tests/Makefile.am
---
libvirt-gconfig/libvirt-gconfig-domain-disk.h | 20
libvirt-gconfig/libvirt-gconfig.sym | 2 ++
2 files changed, 22 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-disk.h
b/libvirt-gconfig/libvirt-gconfig-domain-disk.h
index 7363d31..e80a2fc
---
.../libvirt-gconfig-domain-snapshot-disk.c | 85 ++
.../libvirt-gconfig-domain-snapshot-disk.h | 16
libvirt-gconfig/libvirt-gconfig.sym| 9 +++
3 files changed, 110 insertions(+)
diff --git
It was renamed to gvir_config_object_to_xml() a long while ago.
---
examples/conn-test.js | 2 +-
examples/conn-test.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/conn-test.js b/examples/conn-test.js
index 0225a95..7f9784b 100755
--- a/examples/conn-test.js
On 27/04/13 05:01, Eric Blake wrote:
In an upcoming patch, I need the way to safely transfer a nested
virJSON object out of its parent container for independent use,
even after the parent is freed.
* src/util/virjson.h (virJSONValueObjectRemoveKey): New function.
(_virJSONObject,
On 27/04/13 05:01, Eric Blake wrote:
Follows on the heels of other bool cleanups, such as commit 93002b98.
* src/qemu/qemu_monitor.h (qemuMonitorOpen, qemuMonitorOpenFD):
Update json parameter type.
* src/qemu/qemu_monitor.c (qemuMonitorOpen, qemuMonitorOpenFD):
Likewise.
(_qemuMonitor): Adjust
On 27/04/13 05:01, Eric Blake wrote:
No need to open code a string list cleanup, if we are nice
to the caller by guaranteeing a NULL-terminated result.
* src/qemu/qemu_monitor_json.c (qemuMonitorJSONGetCPUDefinitions)
(qemuMonitorJSONGetCommands, qemuMonitorJSONGetEvents)
On Fri, May 10, 2013 at 01:13:20PM -0600, Jim Fehlig wrote:
Daniel P. Berrange wrote:
On Fri, May 10, 2013 at 12:40:40PM -0600, Jim Fehlig wrote:
Found that I was unable to start existing domains after updating
to a kernel with no cgroups support
# zgrep CGROUP /proc/config.gz
On Fri, May 10, 2013 at 03:05:15PM -0400, dwa...@redhat.com wrote:
From: Dan Walsh dwa...@redhat.com
Add similar support to virt-sandbox-service that is in virt-sandbox
to add guest-bind, host-bind and host-image mount points on the command
line. Openshift needs feature.
---
On Sun, May 12, 2013 at 07:34:07PM +0200, Christophe Fergeau wrote:
The 3 patches fix various small warnings when building, and a misnamed
function call in some examples.
ACK to all 3
Daniel
--
|: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|
|:
On 27/04/13 05:01, Eric Blake wrote:
Ever since the conversion to using only QMP for probing features
of qemu 1.2 and newer, we have been unable to detect features
that are added only by additional command line options. For
example, we'd like to know if '-machine mem-merge=on' (added
in qemu
On Sun, May 12, 2013 at 11:52:22PM +0200, Christophe Fergeau wrote:
libvirt commit
http://libvirt.org/git/?p=libvirt.git;a=commit;h=e2c41e486018ee74f6a75c1f717622
strongly hints that driver type for a disk domain should be an
enum rather than a raw string. Since we already have setters/getters
On Mon, May 13, 2013 at 09:34:59AM +0100, Daniel P. Berrange wrote:
Rather than using an _enum suffix, how about just giving it a
different name. The word 'type' is really bogus in our XML
schema - it should have been 'format'. eg
gvir_config_domain_disk_[sg]et_driver_format
Oh sure, I'm
On 30/04/13 01:44, Eric Blake wrote:
* src/qemu/qemu_capabilities.h: New capability bit.
* src/qemu/qemu_capabilities.c (virQEMUCapsProbeQMPCommandLine): New
function; use it to set new capability bit.
(virQEMUCapsInitQMP): Use new function.
---
As promised, here is how I would set the new
libvirt commit
http://libvirt.org/git/?p=libvirt.git;a=commit;h=e2c41e486018ee74f6a75c1f717622
strongly hints that driver type for a disk domain should be an
enum rather than a raw string. Since we already have setters/getters
for this attribute, we can't use the same name as in the XML. However,
On 13/05/13 14:46, Hu Tao wrote:
On Thu, May 09, 2013 at 06:22:17PM +0800, Osier Yang wrote:
When the numatune memory mode is not strict, the cpuset.mems
inherits the parent's setting, which causes problem like:
% virsh dumpxml rhel6_local | grep interleave -2
vcpu placement='static'2/vcpu
On 08/05/13 23:03, Osier Yang wrote:
On 08/05/13 21:53, John Ferlan wrote:
On 05/06/2013 08:45 AM, Osier Yang wrote:
Since the NPIV machine is not easy to get, it's very likely to
introduce regressions when doing changes on the existing code.
This patch dumps part of the sysfs files (the
This patch introduces 'pre-start' signal and registers
nodedev checking handler to check duplicate USB devices.
If virt-manager can not identify unique usb device any more
before domain startup, it will throw a tip error to tell it
is time to reattach host USB devices to get updated bus/addr info.
On 05/13/2013 06:11 PM, Guannan Ren wrote:
This patch introduces 'pre-start' signal and registers
nodedev checking handler to check duplicate USB devices.
If virt-manager can not identify unique usb device any more
before domain startup, it will throw a tip error to tell it
is time to reattach
All of these macros are not used anymore, remove them.
---
src/node_device/node_device_driver.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/src/node_device/node_device_driver.h
b/src/node_device/node_device_driver.h
index 2dff70f..0f62c83 100644
---
On Mon, May 13, 2013 at 06:14:52PM +0800, Osier Yang wrote:
All of these macros are not used anymore, remove them.
s/are not used anymore, remove/are now unused, so remove/
---
src/node_device/node_device_driver.h | 9 -
1 file changed, 9 deletions(-)
diff --git
On 13/05/13 18:18, Daniel P. Berrange wrote:
On Mon, May 13, 2013 at 06:14:52PM +0800, Osier Yang wrote:
All of these macros are not used anymore, remove them.
s/are not used anymore, remove/are now unused, so remove/
---
src/node_device/node_device_driver.h | 9 -
1 file changed,
On 07/05/13 19:52, Ján Tomko wrote:
On 05/03/2013 08:07 PM, Osier Yang wrote:
From: Han Cheng hanc.f...@cn.fujitsu.com
Adding two cap flags for scsi-generic:
QEMU_CAPS_SCSI_GENERIC
QEMU_CAPS_SCSI_GENERIC_BOOTINDEX
Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com
Signed-off-by: Osier
On 07/05/13 18:38, Osier Yang wrote:
On 07/05/13 00:33, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
From: Han Cheng hanc.f...@cn.fujitsu.com
An example of the scsi hostdev XML:
hostdev mode='subsystem' type='scsi'
source
adapter name='scsi_host0'/
On Sat, May 11, 2013 at 07:30:48PM +0400, Roman Bogorodskiy wrote:
Appears that configure doesn't properly detect the case when clang is
used instead of gcc:
CC=clang ./configure runs fine, but produces a long list of warning
flags that clang doesn't support:
configure: Warning Flags:
On 07/05/13 19:09, Osier Yang wrote:
On 07/05/13 01:20, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
From: Han Cheng hanc.f...@cn.fujitsu.com
This patch adds util functions for scsi hostdev.
Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com
Signed-off-by: Osier Yang
On 13/05/13 18:42, Osier Yang wrote:
On 07/05/13 19:09, Osier Yang wrote:
On 07/05/13 01:20, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
From: Han Cheng hanc.f...@cn.fujitsu.com
This patch adds util functions for scsi hostdev.
Signed-off-by: Han Cheng
From: Daniel P. Berrange berra...@redhat.com
Escaping a leading '.' with '_' in the cgroup names
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/vircgroup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index
On 07/05/13 01:37, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
From: Han Cheng hanc.f...@cn.fujitsu.com
Except the scsi host device's controller is lsilogic, mapping
between the libvirt attributes and scsi-generic properties is:
libvirt qemu
On 07/05/13 01:53, Eric Blake wrote:
On 05/06/2013 11:47 AM, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
---
docs/schemas/domaincommon.rng | 42 ++
1 file changed, 22 insertions(+), 20 deletions(-)
Seems reasonable, not an expert
On 07/05/13 18:58, Osier Yang wrote:
On 07/05/13 02:01, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
Since it's generic enough to be used by other types in future, I
put it in hostdev as sub-element, though now it's only used by
scsi host device.
---
docs/formatdomain.html.in
On 07/05/13 02:24, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
---
src/qemu/qemu_command.c| 10 +++
.../qemuxml2argv-hostdev-scsi-boot.args| 9 ++
.../qemuxml2argv-hostdev-scsi-boot.xml | 34 ++
On 07/05/13 02:45, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
To not introduce more redundant code, helpers are added for
both selinux, dac, and apparmor backends.
Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com
Signed-off-by: Osier Yang jyang@redhat
v2.5 - v3:
*
On 07/05/13 02:28, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
From: Han Cheng hanc.f...@cn.fujitsu.com
This adds the scsi-generic device into the device controller's
whitelist, so that it's allowed to used by the qemu process.
Signed-off-by: Han Cheng
After introducing AppArmorSetSecuritySCSILabel() in 2691cd5f
we are using virSCSIDevicePtr type without proper include.
---
Pushed as build breaker.
src/security/security_apparmor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/security/security_apparmor.c
From: Daniel P. Berrange berra...@redhat.com
The virt-compile-warnings.m4 file would do an explicit
check for whether the compile could use the 'diagnostic'
pragma push/pop feature. The src/internal.h file would
then only enable it for GCC = 4.6
This breaks with clang which supports the pragma
From: Daniel P. Berrange berra...@redhat.com
The inotify Xen code causes a cast alignment warning, but this
is harmless since the kernel inotify interface will ensure
sufficient alignment of the inotify structs in the buffer being
read
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
From: Daniel P. Berrange berra...@redhat.com
Automake already passes all CFLAGS to the linker too, so it
is not neccesary to set WARN_LDFLAGS in addition to the
WARN_CFLAGS variable.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
daemon/Makefile.am | 1 -
From: Daniel P. Berrange berra...@redhat.com
Clang will happily claim to support any warning flags
unless the -Werror and -Wunknown-warning-option flags
are set. Thus we need to make sure these are set when
testing for clags.
We must also set the clang specific warning flags
From: Daniel P. Berrange berra...@redhat.com
Clang does not like the -export-dynamic flag. The compiler does
not need it in the first place, so we can avoid the problem by
only setting it for the linker
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
configure.ac| 4 ++--
From: Daniel P. Berrange berra...@redhat.com
Clang does not like it when you pass a static variable to an
inline function
vircgroupmock.c:462:22: error: static variable 'fakesysfsdir' is
used in an inline function with external linkage [-Werror,-Wstatic-in-inline]
Just make the var
From: Daniel P. Berrange berra...@redhat.com
There are various problems building libvirt with clang,
which mostly revolve around compiler warning handling.
This series fixes all the problems I see with clang
3.2 on a Fedora 19 x86_64 host.
Daniel P. Berrange (6):
Ensure consistent enablement
On Mon, May 13, 2013 at 02:30:41PM +0200, Claudio Bley wrote:
Hi.
Sometimes, it's a bit hard to determine when exactly a function, flag
or macro appeared in libvirt, ie. whether it will be supported on my
target machine having a specific version of libvirt or not.
So, I have created an
Hi.
Sometimes, it's a bit hard to determine when exactly a function, flag
or macro appeared in libvirt, ie. whether it will be supported on my
target machine having a specific version of libvirt or not.
So, I have created an enriched version of the API docs, using a XSL
stylesheet enumerating
On Mon, May 13, 2013 at 11:48:48AM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Escaping a leading '.' with '_' in the cgroup names
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/vircgroup.c | 3 ++-
1 file changed, 2 insertions(+), 1
From: Daniel P. Berrange berra...@redhat.com
The QEMU command line syntax for RBD disks is
file=rbd:pool/image:opt1=val1:opt2=val2...
There is no way to escape the ':' if it appears in the
pool or image name. Thus it must be explicitly forbidden
if it occurs in the libvirt XML. People are
At Mon, 13 May 2013 13:39:53 +0100,
Daniel P. Berrange wrote:
On Mon, May 13, 2013 at 02:30:41PM +0200, Claudio Bley wrote:
Hi.
Sometimes, it's a bit hard to determine when exactly a function, flag
or macro appeared in libvirt, ie. whether it will be supported on my
target machine
On Mon, May 13, 2013 at 03:04:40PM +0200, Claudio Bley wrote:
At Mon, 13 May 2013 13:39:53 +0100,
Daniel P. Berrange wrote:
On Mon, May 13, 2013 at 02:30:41PM +0200, Claudio Bley wrote:
Hi.
Sometimes, it's a bit hard to determine when exactly a function, flag
or macro appeared
Adding support for new attribute 'websocket' in the 'graphics'
element, the attribute value is the port to listen on with '-1'
meaning auto-allocation, '0' meaning no websockets.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 5 +
On Sun, May 12, 2013 at 09:15:33PM +0100, Richard W.M. Jones wrote:
On Sun, May 12, 2013 at 02:42:36PM -0400, Mike Kelly wrote:
On Thu, May 9, 2013 at 12:21 PM, Richard W.M. Jones rjo...@redhat.com
wrote:
On Thu, May 09, 2013 at 11:23:55AM -0400, Mike Kelly wrote:
On Wed, May 8, 2013
On 05/10/2013 03:19 PM, Martin Kletzander wrote:
On 04/30/2013 06:21 PM, Eric Blake wrote:
On 04/30/2013 09:18 AM, John Ferlan wrote:
On 04/30/2013 10:42 AM, Martin Kletzander wrote:
Adding support for new attribute 'websocket' in the 'graphics'
element, the attribute value is the port to
Adding a VNC WebSocket support for QEMU driver. This functionality is
in upstream qemu from commit described as v1.3.0-982-g7536ee4, so the
capability is being recognized based on QEMU version for now.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/libvirtd_qemu.aug
I'm re-sending this series even after previous ACK, because I've found
out there was missing virPortAllocatorRelease call when disposing of
domain. There were also many cleanups in the meantime and both John
and Eric found out some nits in the previous series. I also *somehow*
lost the tests
On Mon, May 13, 2013 at 02:30:41PM +0200, Claudio Bley wrote:
Hi.
Sometimes, it's a bit hard to determine when exactly a function, flag
or macro appeared in libvirt, ie. whether it will be supported on my
target machine having a specific version of libvirt or not.
So, I have created an
On Mon, May 13, 2013 at 02:00:31PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The QEMU command line syntax for RBD disks is
file=rbd:pool/image:opt1=val1:opt2=val2...
There is no way to escape the ':' if it appears in the
pool or image name. Thus it
On 05/10/2013 06:52 PM, John Ferlan wrote:
On 05/10/2013 10:57 AM, Eric Blake wrote:
On 05/10/2013 05:07 AM, Martin Kletzander wrote:
I must admit I have no idea why we allow spaces and hyphens everywhere
in the UUID string. Changing it to proper UUID parser is not just
fixing this issue,
From: Daniel P. Berrange berra...@redhat.com
Use of the select() system call is inherantly dangerous since
applications will hit a buffer overrun if any FD number exceeds
the size of the select set size (typically 1024). Replace the
two uses of select() with poll() and use cfg.mk to ban any
On 07/05/13 20:23, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
It's better to put the usb related codes into qemuDomainAttachHostUsbDevice
instead of qemuDomainAttachHostDevice.
And in the old qemuDomainAttachHostDevice, just stealing the usb from
driver-activeUsbHostdevs
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
There are various problems building libvirt with clang,
which mostly revolve around compiler warning handling.
This series fixes all the problems I see with clang
3.2 on a Fedora 19 x86_64 host.
Daniel P. Berrange
Hi,
I don't have time to look into these test failurs in detail atm:
but it seems that one of these commits broke qemuxml2argvtest:
qemu: New cap flags for scsi-generic
utils: util functions for scsi hostdev
qemu: Build qemu command line for scsi host device
rng: Interleave
At Mon, 13 May 2013 21:17:35 +0800,
Daniel Veillard wrote:
On Mon, May 13, 2013 at 02:30:41PM +0200, Claudio Bley wrote:
Hi.
Sometimes, it's a bit hard to determine when exactly a function, flag
or macro appeared in libvirt, ie. whether it will be supported on my
target machine
On Mon, May 13, 2013 at 04:44:00PM +0200, Claudio Bley wrote:
At Mon, 13 May 2013 21:17:35 +0800,
Daniel Veillard wrote:
On Mon, May 13, 2013 at 02:30:41PM +0200, Claudio Bley wrote:
Hi.
Sometimes, it's a bit hard to determine when exactly a function, flag
or macro appeared in
On 13/05/13 22:16, Guido Günther wrote:
Hi,
I don't have time to look into these test failurs in detail atm:
but it seems that one of these commits broke qemuxml2argvtest:
qemu: New cap flags for scsi-generic
utils: util functions for scsi hostdev
qemu: Build qemu command line
On Mon, May 13, 2013 at 04:16:53PM +0200, Guido Günther wrote:
Hi,
I don't have time to look into these test failurs in detail atm:
but it seems that one of these commits broke qemuxml2argvtest:
qemu: New cap flags for scsi-generic
utils: util functions for scsi hostdev
qemu:
---
Pushed under the trivial rule.
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index f181f89..3d874a9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -144,6 +144,7 @@
/tests/domainsnapshotxml2xmltest
/tests/esxutilstest
/tests/eventtest
On Mon, May 13, 2013 at 03:59:20PM +0100, Daniel P. Berrange wrote:
On Mon, May 13, 2013 at 04:16:53PM +0200, Guido Günther wrote:
Hi,
I don't have time to look into these test failurs in detail atm:
but it seems that one of these commits broke qemuxml2argvtest:
qemu: New cap
On Mon, May 13, 2013 at 05:25:16PM +0200, Guido Günther wrote:
On Mon, May 13, 2013 at 03:59:20PM +0100, Daniel P. Berrange wrote:
On Mon, May 13, 2013 at 04:16:53PM +0200, Guido Günther wrote:
Hi,
I don't have time to look into these test failurs in detail atm:
but it seems that
On 05/11/2013 07:41 AM, nishant burte wrote:
Hi,
I want to know following about LIFECYCLE events of libvirt.
1. about the the latency of these events happening and notification
generation.
e.g. suppose a VM goes down. How much time it takes to realize that the
particular VM has gone
On 13/05/13 23:25, Guido Günther wrote:
On Mon, May 13, 2013 at 03:59:20PM +0100, Daniel P. Berrange wrote:
On Mon, May 13, 2013 at 04:16:53PM +0200, Guido Günther wrote:
Hi,
I don't have time to look into these test failurs in detail atm:
but it seems that one of these commits broke
On 07/05/13 20:42, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
From: Han Cheng hanc.f...@cn.fujitsu.com
This adds both attachment and detachment support for scsi host
device.
Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com
Signed-off-by: Osier Yang jyang@redhat
---
On 05/11/2013 08:27 AM, Roman Bogorodskiy wrote:
The sad part is that we aren't even using the deprecated symbols - their
mere inclusion in the installed header is provoking the problems. It
looks like newer gcc is a bit more tolerant (that is, this is a
shortcoming of FreeBSD's use of an
On 05/11/2013 09:05 AM, Roman Bogorodskiy wrote:
Eric, thanks for fixing these stupid errors of mine.
Do you run 'syntax-check' on your FreeBSD vm?
So far, I've just been running it on Fedora. I suspect that it makes
some GNU assumptions (at least maint.mk comes from gnulib, and upstream
Daniel P. Berrange wrote:
On Fri, May 10, 2013 at 01:13:20PM -0600, Jim Fehlig wrote:
From 63e878b287b98e418b65db46888c1f5d1a01d805 Mon Sep 17 00:00:00 2001
From: Jim Fehlig jfeh...@suse.com
Date: Fri, 10 May 2013 12:05:00 -0600
Subject: [PATCH] Fix starting domains when kernel has no
On 05/13/2013 07:45 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Use of the select() system call is inherantly dangerous since
applications will hit a buffer overrun if any FD number exceeds
the size of the select set size (typically 1024). Replace the
two uses
On 05/13/2013 11:48 AM, Osier Yang wrote:
On 07/05/13 20:42, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
From: Han Cheng hanc.f...@cn.fujitsu.com
This adds both attachment and detachment support for scsi host
device.
Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com
On Mon, May 13, 2013 at 01:17:21PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
There are various problems building libvirt with clang,
which mostly revolve around compiler warning handling.
This series fixes all the problems I see with clang
3.2 on a Fedora
On Mon, May 13, 2013 at 09:44:35AM -0600, Eric Blake wrote:
On 05/11/2013 07:41 AM, nishant burte wrote:
Hi,
I want to know following about LIFECYCLE events of libvirt.
1. about the the latency of these events happening and notification
generation.
e.g. suppose a VM goes down.
On 14/05/13 00:08, John Ferlan wrote:
On 05/13/2013 11:48 AM, Osier Yang wrote:
On 07/05/13 20:42, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
From: Han Cheng hanc.f...@cn.fujitsu.com
This adds both attachment and detachment support for scsi host
device.
Signed-off-by: Han
From: Daniel P. Berrange berra...@redhat.com
Currently we report a bogus error message when macvlan
creation fails:
error: Failed to start domain migtest
error: operation failed: Unable to create macvlan device
With this removed, we see the real error:
error: Failed to start domain migtest
On Mon, May 13, 2013 at 17:34:18 +0100, Daniel Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Currently we report a bogus error message when macvlan
creation fails:
error: Failed to start domain migtest
error: operation failed: Unable to create macvlan device
With this
---
docs/formatdomain.html.in | 48 +++
1 file changed, 40 insertions(+), 8 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 825053c..abf14fa 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@
https://bugzilla.redhat.com/show_bug.cgi?id=890494
The sysinfo section needs an extra uuid validation check. The current
check compares the numerical sysinfo/system_uuid with the domain uuid;
however, it's possible that someone added extra hyphens into the sysinfo
uuid which results in the
---
docs/formatdomain.html.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 9ade507..825053c 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -308,7 +308,8 @@
lt;/biosgt;
If the sysinfo system table 'uuid' field is improperly formatted,
then qemu will fail to start the guest with the error:
virsh start dom
error: Failed to start domain dom
error: internal error process exited while connecting to monitor: Invalid
SMBIOS UUID string
This was because the parsing
Add incorrectly formatted bios_date validation test
---
src/conf/domain_conf.c | 24 ++
.../qemuxml2argvdata/qemuxml2argv-smbios-date.xml | 23 +
tests/qemuxml2argvtest.c | 1 +
3 files changed, 48
With multiqueue network feature, we are advised to pass multiple
vhost-net FDs as well. The ratio should be 1:1. Therefore we must
alter the qemuOpenVhostNet function to allow that.
---
src/qemu/qemu_command.c | 40 ++--
src/qemu/qemu_command.h | 3 ++-
Currently, we have one huge function to construct qemu command line.
This is very ineffective esp. if there's a fault somewhere.
---
src/qemu/qemu_command.c | 228 +---
1 file changed, 121 insertions(+), 107 deletions(-)
diff --git
Currently, only one tapfd and one vhostfd could be passed.
However, multiqueue network requires several FDs to be passed to
qemu so we must adapt out monitor handling functions to cope with
that.
---
src/qemu/qemu_hotplug.c | 7 +--
src/qemu/qemu_monitor.c | 39
---
src/qemu/qemu_hotplug.c | 96 -
1 file changed, 63 insertions(+), 33 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index e0d8a89..256c54f 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@
Currently, only one tapfd and one vhostfd could be passed.
However, multiqueue network requires several FDs to be passed to
qemu so we must adapt out monitor handling functions to cope with
that.
---
src/qemu/qemu_hotplug.c | 7 +--
src/qemu/qemu_monitor.c | 39
This attribute is going to represent number of queues for
multique vhost network interface. This commit implements XML
extension part of the feature and add one test as well. For now,
we can only do xml2xml test as qemu command line generation code
is not adapted yet.
---
For future work it's better, if tapfd is passed as pointer.
Moreover, we need to be able to return multiple values now.
---
src/qemu/qemu_command.c | 89 ++---
src/qemu/qemu_command.h | 4 ++-
src/qemu/qemu_hotplug.c | 4 +--
3 files changed, 53
1 - 100 of 131 matches
Mail list logo
