On 05/16/2013 09:48 PM, Eric Blake wrote:
On 05/16/2013 08:39 AM, Ján Tomko wrote:
We don't parse it anyway.
https://bugzilla.redhat.com/show_bug.cgi?id=893273
---
docs/schemas/storagevol.rng| 4 +++-
tests/Makefile.am | 3 ++-
2013/5/16 Osier Yang jy...@redhat.com
On 16/05/13 14:07, Chunyan Liu wrote:
Write separate module for hostdev passthrough so that it could be used by
all
hypervisor drivers and maintain a global hostdev state.
Signed-off-by: Chunyan Liucy...@suse.com
---
po/POTFILES.in |
On Thu, May 16, 2013 at 02:07:31PM -0600, Eric Blake wrote:
On 05/16/2013 10:02 AM, Stefan Berger wrote:
Linux netfilter at some point inverted the meaning of the '--ctdir reply'
and newer netfilter implementations now expect '--ctdir original'
instead and vice-versa.
We probe for this
On Thu, May 16, 2013 at 02:32:30PM -0600, Alex Williamson wrote:
We'd like to hold another virtualization microconference as part of this
year's Linux Plumbers Conference. To do so, we need to show that
there's enough interest, materials, and people willing to attend.
Convenience info:
On 17.05.2013 07:47, Li Wei wrote:
Hi Michal, Daniel
It seems there is something wrong with the 2/2 part of this patchset.
When I do an change-media command in virsh, it doesn't do any better
than before, but even worse(I must to wait 5 secs to see the error).
I'm not family with libvirt,
On 05/17/2013 04:07 PM, Michal Privoznik wrote:
On 17.05.2013 07:47, Li Wei wrote:
Hi Michal, Daniel
It seems there is something wrong with the 2/2 part of this patchset.
When I do an change-media command in virsh, it doesn't do any better
than before, but even worse(I must to wait 5 secs to
On 17.05.2013 10:16, Li Wei wrote:
On 05/17/2013 04:07 PM, Michal Privoznik wrote:
On 17.05.2013 07:47, Li Wei wrote:
Hi Michal, Daniel
It seems there is something wrong with the 2/2 part of this patchset.
When I do an change-media command in virsh, it doesn't do any better
than before, but
On Thu, May 16, 2013 at 01:57:41PM -0600, Eric Blake wrote:
On 05/16/2013 12:00 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The setfilecon method can return ENOTSUP when trying to set
the context of the /proc/meminfo FUSE filesystem. We must
ignore this
Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=927620
#kill -STOP `pidof qemu-kvm`
#virsh destroy $guest --graceful
error: Failed to destroy domain testVM
error: An error occurred, but the cause is unknown
With --graceful, SIGTERM always is emitted to kill driver
process, but it won't
On Wed, May 15, 2013 at 02:36:32PM -0400, dwa...@redhat.com wrote:
From: Dan Walsh dwa...@redhat.com
mcstransd is a translation tool that can translate MCS Labels into human
understandable code. I have patched it to watch for translation files in the
/run/setrans directory. This allows us
On 05/17/2013 04:52 PM, Michal Privoznik wrote:
On 17.05.2013 10:16, Li Wei wrote:
On 05/17/2013 04:07 PM, Michal Privoznik wrote:
On 17.05.2013 07:47, Li Wei wrote:
Hi Michal, Daniel
It seems there is something wrong with the 2/2 part of this patchset.
When I do an change-media command in
Ping?
since it's mainly for fixing the build failure, better to get it in
as soon as possible.
Osier
On 16/05/13 23:02, Osier Yang wrote:
Since 0d70656afded, it starts to access the sysfs files to build
the qemu command line (by virSCSIDeviceGetSgName, which is to find
out the scsi generic
On Thu, May 16, 2013 at 03:32:17PM -0600, Eric Blake wrote:
On 05/16/2013 03:02 PM, Jiri Denemark wrote:
Commit ba5f3c7c moved vbox driver into libvirtd but forgot to adapt
daemon's Makefile.am.
We have another problem, not fixed yet, in that the new vbox .so driver
module needs a
On Thu, May 16, 2013 at 11:02:00PM +0800, Osier Yang wrote:
Since 0d70656afded, it starts to access the sysfs files to build
the qemu command line (by virSCSIDeviceGetSgName, which is to find
out the scsi generic device name by adpater:bus:target:unit), there
is no way to work around, qemu
On Thu, May 16, 2013 at 17:49:59 +0200, Viktor Mihajlovski wrote:
Running make check in a VPATH configured build directory fails
in fchosttest as the test data files are searched for relative to
the current working directory.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
On Fri, May 17, 2013 at 05:32:06PM +0800, Guannan Ren wrote:
Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=927620
#kill -STOP `pidof qemu-kvm`
#virsh destroy $guest --graceful
error: Failed to destroy domain testVM
error: An error occurred, but the cause is unknown
With
On 17/05/13 18:12, Daniel P. Berrange wrote:
On Thu, May 16, 2013 at 11:02:00PM +0800, Osier Yang wrote:
Since 0d70656afded, it starts to access the sysfs files to build
the qemu command line (by virSCSIDeviceGetSgName, which is to find
out the scsi generic device name by
On Fri, May 17, 2013 at 06:17:07PM +0800, Osier Yang wrote:
On 17/05/13 18:12, Daniel P. Berrange wrote:
On Thu, May 16, 2013 at 11:02:00PM +0800, Osier Yang wrote:
Since 0d70656afded, it starts to access the sysfs files to build
the qemu command line (by virSCSIDeviceGetSgName, which is to
Since 0d70656afded, it starts to access the sysfs files to build
the qemu command line (by virSCSIDeviceGetSgName, which is to find
out the scsi generic device name by adpater:bus:target:unit), there
is no way to work around, qemu wants to see the scsi generic device
like /dev/sg6 anyway.
And
On 17.05.2013 11:37, Li Wei wrote:
On 05/17/2013 04:52 PM, Michal Privoznik wrote:
On 17.05.2013 10:16, Li Wei wrote:
On 05/17/2013 04:07 PM, Michal Privoznik wrote:
On 17.05.2013 07:47, Li Wei wrote:
Hi Michal, Daniel
It seems there is something wrong with the 2/2 part of this patchset.
…
Hello.
I would like to start a discussion about network SLA mechs in libvirt.
Right now, as I understand, libvirt is managing traffic controls, e.g.
bandwitdh limitation, calling external routines (ip/tc). This approach
has its own drawbacks, including the need to parse text output of
On 08/05/13 08:05, John Ferlan wrote:
On 05/03/2013 02:07 PM, Osier Yang wrote:
Just like previous patches, this changes qemuCheckSharedDisk
into qemuCheckSharedDevice, which takes a virDomainDeviceDefPtr
argument instead.
---
src/qemu/qemu_conf.c | 86
/8 ~ 5/8 are refactorings, real fixes are 6/8, 7/8.
v1 - v2:
* Only rebasing
Osier Yang (7):
qemu: Abstract the code for blkio controller setting into a helper
qemu: Abstract code for memory controller setting into a helper
qemu: Abstract code for devices controller setting into a helper
---
src/qemu/qemu_cgroup.c | 73 --
1 file changed, 47 insertions(+), 26 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 1e8afb1..8f84ef9 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -626,6
I don't see any reason to getting the numa parameters if mode is
not strict, as long as setNumaParameters doesn't allow to set
nodeset if the mode is not strict, and cpuset.mems only understand
strict mode.
Things could be changed if we support to get numa parameters with
libnuma one day, but
---
src/qemu/qemu_cgroup.c | 63 ++
1 file changed, 38 insertions(+), 25 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 8f84ef9..8a2cc9d 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -671,6
---
src/qemu/qemu_cgroup.c | 195 +++--
1 file changed, 107 insertions(+), 88 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 2751be0..1e8afb1 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -521,6
---
src/qemu/qemu_cgroup.c | 90 --
1 file changed, 50 insertions(+), 40 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 9784f31..0c4792e 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -407,6
When either cpuset of vcpu is specified, or the placement of
vcpu is auto, only setting the cpuset.mems might cause the guest
starting to fail. E.g. (placement of both vcpu and numatune is
auto):
1) Related XMLs
vcpu placement='auto'4/vcpu
numatune
memory mode='strict' placement='auto'/
---
src/qemu/qemu_cgroup.c | 120 -
1 file changed, 68 insertions(+), 52 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 0c4792e..2751be0 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -455,6
If a domain is configured to have all its memory locked, we need to
increase RLIMIT_MEMLOCK so that QEMU is actually allowed to lock the
memory.
---
src/qemu/qemu_command.c | 31 +--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git
On Fri, May 17, 2013 at 09:12:52AM -0400, Daniel J Walsh wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 05/17/2013 05:52 AM, Daniel P. Berrange wrote:
On Wed, May 15, 2013 at 02:36:32PM -0400, dwa...@redhat.com wrote:
From: Dan Walsh dwa...@redhat.com
mcstransd is a
From: Daniel P. Berrange berra...@redhat.com
Now the VirtualBox driver is a loadable module, it needs
to live in its own sub-RPM
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt.spec.in | 51 +++
1 file changed, 51 insertions(+)
From: Daniel P. Berrange berra...@redhat.com
The mkdtemp function is missing on mingw platforms. It is
used in various Linux specific places in libvirt, but
recently became used in fdstreamtest.c which is cross
platform. Thus the GNULIB mkdtemp module should be used
to proide mkdtemp.
From: Daniel P. Berrange berra...@redhat.com
If PKG_CONFIG_LIBDIR is not set when doing mingw32/64 builds,
then pkg-config may silently fallback to native versions of
libraries, with predictably bad results. Setting PKG_CONFIG_LIBDIR
forces it to only consider the mingw32/64 libraries.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 05/17/2013 05:52 AM, Daniel P. Berrange wrote:
On Wed, May 15, 2013 at 02:36:32PM -0400, dwa...@redhat.com wrote:
From: Dan Walsh dwa...@redhat.com
mcstransd is a translation tool that can translate MCS Labels into human
understandable code.
W dniu 01.08.2012 14:15, Eric Blake pisze:
On 08/01/2012 02:13 AM, Maciej Nabożny wrote:
On Mon, 30 Jul 2012 17:29:05 -0600, Eric Blake ebl...@redhat.com
wrote:
On 07/16/2012 12:57 PM, Eric Blake wrote:
On 07/16/2012 04:17 AM, Maciej Nabożny wrote:
Hello,
I'm developer of CC1 project in
From: Daniel P. Berrange berra...@redhat.com
The virfile.c file uses c_isalpha on Win32 platforms, so must
include c-ctype.h
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/virfile.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/util/virfile.c b/src/util/virfile.c
From: Daniel P. Berrange berra...@redhat.com
We can't use GNULIB's fprintf-posix due to licensing
incompatibilities. We do already have a portable
formatting via virAsprintf() which we got from GNULIB
though. We can use to create a virFilePrintf() function.
But really gnulib could just provide a
From: Daniel P. Berrange berra...@redhat.com
Latest mingw64 can provide *printf functions which
support GNU format specifiers. It won't do that unless
you have defined __USE_MINGW_ANSI_STDIO though.
GNULIB's 'asprintf' module detected that mingw had
the asprintf function, but didn't define the
On 05/17/2013 07:03 AM, Jiri Denemark wrote:
If a domain is configured to have all its memory locked, we need to
increase RLIMIT_MEMLOCK so that QEMU is actually allowed to lock the
memory.
---
src/qemu/qemu_command.c | 31 +--
1 file changed, 21 insertions(+),
On 05/17/2013 07:28 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If PKG_CONFIG_LIBDIR is not set when doing mingw32/64 builds,
then pkg-config may silently fallback to native versions of
libraries, with predictably bad results. Setting PKG_CONFIG_LIBDIR
forces
On 05/17/2013 07:29 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The mkdtemp function is missing on mingw platforms. It is
used in various Linux specific places in libvirt, but
recently became used in fdstreamtest.c which is cross
platform. Thus the GNULIB
On 05/17/2013 09:03 AM, Jiri Denemark wrote:
If a domain is configured to have all its memory locked, we need to
increase RLIMIT_MEMLOCK so that QEMU is actually allowed to lock the
memory.
---
src/qemu/qemu_command.c | 31 +--
1 file changed, 21 insertions(+),
On 05/17/2013 07:29 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Now the VirtualBox driver is a loadable module, it needs
to live in its own sub-RPM
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
libvirt.spec.in | 51
On 05/17/2013 07:29 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The virfile.c file uses c_isalpha on Win32 platforms, so must
include c-ctype.h
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/virfile.c | 2 ++
1 file changed, 2
Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=927620
#kill -STOP `pidof qemu-kvm`
#virsh destroy $guest --graceful
error: Failed to destroy domain testVM
error: An error occurred, but the cause is unknown
With --graceful, SIGTERM always is emitted to kill driver
process, but it won't
On 05/17/2013 08:11 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
We can't use GNULIB's fprintf-posix due to licensing
incompatibilities. We do already have a portable
formatting via virAsprintf() which we got from GNULIB
though. We can use to create a
Yes, it belongs to system related error rather than libvirt
operation related.
- Original Message -
From: Daniel P. Berrange berra...@redhat.com
To: Guannan Ren g...@redhat.com
Cc: libvir-list@redhat.com
Sent: Friday, May 17, 2013 6:14:56 PM
Subject: Re: [libvirt] [PATCH] qemu: report
[adding gnulib]
On 05/17/2013 08:14 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Latest mingw64 can provide *printf functions which
support GNU format specifiers. It won't do that unless
you have defined __USE_MINGW_ANSI_STDIO though.
GNULIB's 'asprintf'
On 05/17/2013 08:31 AM, Guannan Ren wrote:
Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=927620
#kill -STOP `pidof qemu-kvm`
#virsh destroy $guest --graceful
error: Failed to destroy domain testVM
error: An error occurred, but the cause is unknown
With --graceful, SIGTERM
On Fri, May 17, 2013 at 08:27:34AM -0600, Eric Blake wrote:
On 05/17/2013 07:29 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Now the VirtualBox driver is a loadable module, it needs
to live in its own sub-RPM
Signed-off-by: Daniel P. Berrange
On 05/17/2013 07:35 AM, Maciej Nabożny wrote:
Any objections to this patch?
We probably add it in September, when project will be more stable. At
this time it is in beta-phase. Also our website needs some enhancements
Fair enough. I'll shelve this patch for now, and come September when
you
On 05/16/2013 08:49 AM, Michal Privoznik wrote:
Currently, only one tapfd and one vhostfd could be passed.
However, multiqueue network requires several FDs to be passed to
qemu so we must adapt out monitor handling functions to cope with
that.
---
src/qemu/qemu_hotplug.c | 7 +--
On 05/16/2013 08:49 AM, Michal Privoznik wrote:
The qemuBuildHostNetStr() function which is responsible for
generating command line for a network interface needs to be aware
of multiqueue network interface as we are required to use:
- fd=%d in case of one FD
- fds=%d:%d:%d:...:%d in
From: Daniel P. Berrange berra...@redhat.com
The domain events example program uses asprintf() to avoid
portability problems with %llu in one place, but not in
another place. Make all places use asprintf() instead and
thus avoid need to use PRIuMAX
Signed-off-by: Daniel P. Berrange
On 05/16/2013 08:49 AM, Michal Privoznik wrote:
Currently, the function knows how to open a TAP device for a single
time. However, in case of multiqueue network we need to open it multiple
times. Moreover, when doing TUNSETIFF ioctl, the IFF_MULTI_QUEUE flag
shall be requested. This commit
On 05/17/2013 10:05 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The domain events example program uses asprintf() to avoid
portability problems with %llu in one place, but not in
another place. Make all places use asprintf() instead and
thus avoid need to use
On 17.05.2013 13:07, Peter V. Saveliev wrote:
…
Hello.
I would like to start a discussion about network SLA mechs in libvirt.
Right now, as I understand, libvirt is managing traffic controls, e.g.
bandwitdh limitation, calling external routines (ip/tc). This approach
has its own
On Fri, May 17, 2013 at 01:07:02PM +0200, Peter V. Saveliev wrote:
…
Hello.
I would like to start a discussion about network SLA mechs in libvirt.
Right now, as I understand, libvirt is managing traffic controls,
e.g. bandwitdh limitation, calling external routines (ip/tc). This
On 05/17/2013 07:06 PM, Daniel P. Berrange wrote:
skip /
The idea of handing off this to an external python daemon isn't
really very appealing to me, because I don't really like libvirt
core functionality depending on anything python related.
Really libvirt should just talk network directly
On 05/16/2013 08:49 AM, Michal Privoznik wrote:
With multiqueue network feature, we are advised to pass multiple
vhost-net FDs as well. The ratio should be 1:1. Therefore we must
alter the qemuOpenVhostNet function to allow that.
---
src/qemu/qemu_command.c | 60
2013/5/16 Eric Blake ebl...@redhat.com:
On 05/15/2013 03:44 PM, Matthias Bolte wrote:
As the name parameter can be NULL the error message can only contain it
conditionally.
---
src/esx/esx_vi.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
ACK
Thanks, pushed.
--
On 05/16/2013 01:56 PM, Eric Blake wrote:
On 05/16/2013 10:01 AM, Jim Fehlig wrote:
libxl expects the event handler to free the event passed to it. From
libxl_event.h:
event becomes owned by the application and must be freed, either
by event_occurs or later
---
On Fri, May 17, 2013 at 10:26:17 -0400, Laine Stump wrote:
On 05/17/2013 09:03 AM, Jiri Denemark wrote:
If a domain is configured to have all its memory locked, we need to
increase RLIMIT_MEMLOCK so that QEMU is actually allowed to lock the
memory.
---
src/qemu/qemu_command.c | 31
On 05/17, Michal Privoznik wrote:
On 17.05.2013 11:37, Li Wei wrote:
On 05/17/2013 04:52 PM, Michal Privoznik wrote:
On 17.05.2013 10:16, Li Wei wrote:
On 05/17/2013 04:07 PM, Michal Privoznik wrote:
On 17.05.2013 07:47, Li Wei wrote:
Hi Michal, Daniel
It seems there is something
Remove bash-ism from tests/schematestutils.sh
Fix a bash-ism in an sh script, introduced by commit a3f71eb
Signed-off-by: Chris Dunlop ch...@onthe.net.au
diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh
index e739b99..c34364f 100644
--- a/tests/schematestutils.sh
+++
On 05/17/2013 09:03 PM, Chris Dunlop wrote:
Remove bash-ism from tests/schematestutils.sh
Fix a bash-ism in an sh script, introduced by commit a3f71eb
NACK. a3f71eb is on the v1.0.5-maint branch; maint branches should only
use backports from the mainstream branch to avoid introducing
On 05/10/2013 06:10 PM, Seiji Aguchi wrote:
Any comments?
Apologies that no one has spoken up yet, but this is on my list of
things to review. I got waylaid by debugging two nasty races today, or
I would have had time to actually give comments; but come Monday, you
should have some better
I found root cause on two nasty races today, but ran out of time to
write the patches until next week.
1. We have a TOCTTOU race when moving processes between cgroups.
virCgroupMoveTask can fail if listing the threads in the parent group
picks up multiple threads, then one of those threads exits
On 05/17/2013 10:05 PM, Eric Blake wrote:
I found root cause on two nasty races today, but ran out of time to
write the patches until next week.
2. We have a (rare) deadlock due to the use of a non-async-signal-safe
getpwuid_r in between fork and exec.
I was also surprised to learn today
On 05/16/2013 08:49 AM, Michal Privoznik wrote:
For future work it's better, if tapfd is passed as pointer.
Moreover, we need to be able to return multiple values now.
---
src/qemu/qemu_command.c | 89
++---
src/qemu/qemu_command.h | 4 ++-
On 05/16/2013 08:49 AM, Michal Privoznik wrote:
With multiqueue network feature, we are advised to pass multiple
vhost-net FDs as well. The ratio should be 1:1. Therefore we must
alter the qemuOpenVhostNet function to allow that.
---
src/qemu/qemu_command.c | 60
73 matches
Mail list logo
