On 05/23/2013 01:56 PM, Richard RW. Weinberger wrote:
Hi!
- Ursprüngliche Mail -
This two files are created for container,
the owner should be the root user of container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 30
- Ursprüngliche Mail -
On 05/23/2013 01:52 PM, Richard RW. Weinberger wrote:
Hi!
- Ursprüngliche Mail -
Since these tty devices will be used by container,
the owner of them should be the root user of container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
On 05/23/2013 01:52 PM, Richard RW. Weinberger wrote:
Hi!
- Ursprüngliche Mail -
Since these tty devices will be used by container,
the owner of them should be the root user of container.
Signed-off-by: Gao feng gaof...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 43
On 23.05.2013 00:26, Eric Blake wrote:
On 05/20/2013 11:55 AM, Michal Privoznik wrote:
---
src/rpc/gendispatch.pl | 21
src/rpc/virnetclient.c | 16 -
src/rpc/virnetmessage.c | 27 +--
src/rpc/virnetsaslcontext.c | 6 ++--
On 23.05.2013 00:42, Eric Blake wrote:
On 05/20/2013 11:55 AM, Michal Privoznik wrote:
---
src/security/security_apparmor.c | 20 ++
src/security/security_dac.c | 21 +++
src/security/security_nop.c | 7 +---
src/security/security_selinux.c | 79
On 05/22/2013 05:34 PM, Wayne Sun wrote:
In this case, domain memory cgroup path is hardcoded and fail the
case after cgroup path changed recently. To avoid such failure, add
check function for lscgroup command before run this case, if check
fail then skip this case.
Signed-off-by: Wayne Sun
On 22.05.2013 21:59, Daniel Veillard wrote:
It seems that if we want to have the release at the end of the month
we ought to enter freeze next Monday the 27 for a release on the 3rd
(I may have a hard time making the release on Friday 31 or w.e.).
Is there any problem with freezing next
On 05/23/2013 04:20 PM, Guannan Ren wrote:
On 05/22/2013 05:34 PM, Wayne Sun wrote:
In this case, domain memory cgroup path is hardcoded and fail the
case after cgroup path changed recently. To avoid such failure, add
check function for lscgroup command before run this case, if check
fail then
Hi,
I think I've found a possible bug in the way OpenVZ is assigning the guest
interface names when network is bridged. It's manifested at least in 1.0.5
version and master branch.
As we can see in openvzDomainSetNetwork() function
(openvz/openvz_driver.c:822), the field data.ethernet.dev of
On 05/20/2013 07:55 PM, Michal Privoznik wrote:
---
src/xen/block_stats.c| 16 ++--
src/xen/xen_driver.c | 9 +++
src/xen/xen_hypervisor.c | 19 --
src/xen/xen_inotify.c| 15 +++
src/xen/xend_internal.c | 68
On 05/20/2013 07:55 PM, Michal Privoznik wrote:
---
src/xenapi/xenapi_driver.c | 59
--
src/xenapi/xenapi_utils.c | 39 +++---
2 files changed, 46 insertions(+), 52 deletions(-)
ACK
Jan
--
libvir-list mailing list
On 05/20/2013 07:55 PM, Michal Privoznik wrote:
---
src/xenxs/xen_sxpr.c | 200
++-
src/xenxs/xen_xm.c | 91 +++
2 files changed, 125 insertions(+), 166 deletions(-)
diff --git a/src/xenxs/xen_sxpr.c
---
v1 - v2:
* Keep the cleanup label of qemuSetupCgroup, as it could be
used in future.
---
src/qemu/qemu_cgroup.c | 55 +-
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index
On 20/05/13 19:18, Daniel P. Berrange wrote:
On Fri, May 17, 2013 at 07:59:36PM +0800, Osier Yang wrote:
When either cpuset of vcpu is specified, or the placement of
vcpu is auto, only setting the cpuset.mems might cause the guest
starting to fail. E.g. (placement of both vcpu and numatune is
On 23/05/13 03:59, Daniel Veillard wrote:
It seems that if we want to have the release at the end of the month
we ought to enter freeze next Monday the 27 for a release on the 3rd
(I may have a hard time making the release on Friday 31 or w.e.).
Is there any problem with freezing next Monday
Commit 16251193afdc forgot to include virstring.h. Pushed under
build-breaker rule.
---
src/rpc/virnetservermdns.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/rpc/virnetservermdns.c b/src/rpc/virnetservermdns.c
index 68d5e4e..4b3c19a 100644
--- a/src/rpc/virnetservermdns.c
+++
On 05/20/2013 01:55 PM, Michal Privoznik wrote:
---
src/rpc/gendispatch.pl | 21
src/rpc/virnetclient.c | 16 -
src/rpc/virnetmessage.c | 27 +--
src/rpc/virnetsaslcontext.c | 6 ++--
src/rpc/virnetserver.c | 6 ++--
Function qemuDomainSetBlockIoTune() was creating job and checking QEMU
capabilities even when !(flags VIR_DOMAIN_AFFECT_LIVE) and the
domain was shutoff. Fix this with a little cleanup.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=965016
Signed-off-by: Martin Kletzander
On 05/21/2013 10:18 AM, Michal Privoznik wrote:
In order to learn libvirt multiqueue several things must be done:
[...snip...]
diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c
index 52b705c..3fda7e4 100644
--- a/src/uml/uml_conf.c
+++ b/src/uml/uml_conf.c
@@ -109,6 +109,7 @@
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
Pushed as 'trivial'
tools/virsh-domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index bc42408..0402aef 100644
--- a/tools/virsh-domain.c
+++
On 05/09/2013 08:59 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
[...snip...]
diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
index 89b038c..8b7dec9 100644
--- a/src/xen/xen_driver.c
+++ b/src/xen/xen_driver.c
@@ -1294,18 +1294,31 @@ static char *
On 05/20/2013 01:55 PM, Michal Privoznik wrote:
---
[...snip...]
diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c
index 2509c0d..ac5f7ed 100644
--- a/src/conf/nwfilter_params.c
+++ b/src/conf/nwfilter_params.c
@@ -79,19 +79,15 @@ virNWFilterVarValueCopy(const
On 23.05.2013 02:01, Marek Marczykowski wrote:
The same issue as (already fixed) in virDomainCreate -
REMOTE_PROC_DOMAIN_CREATE_WITH_FLAGS doesn't return new domain ID, only
-1 on error or 0 on success.
Besides this one fix it is more general problem - local domain object
ID can
Currently, the controllers argument to virCgroupDetect acts both as
a result filter and a required controller specification, which is
a bit overloaded. If both functionalities are needed, it would be
better to have them seperated into a filter and a requirement mask.
The only situation where it is
On 23.05.2013 15:04, John Ferlan wrote:
On 05/20/2013 01:55 PM, Michal Privoznik wrote:
---
[...snip...]
diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c
index 2509c0d..ac5f7ed 100644
--- a/src/conf/nwfilter_params.c
+++ b/src/conf/nwfilter_params.c
@@ -79,19 +79,15
On 05/23/2013 09:44 AM, Michal Privoznik wrote:
On 23.05.2013 15:04, John Ferlan wrote:
On 05/20/2013 01:55 PM, Michal Privoznik wrote:
---
[...snip...]
diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c
index 2509c0d..ac5f7ed 100644
--- a/src/conf/nwfilter_params.c
+++
On 23.05.2013 15:56, John Ferlan wrote:
On 05/23/2013 09:44 AM, Michal Privoznik wrote:
On 23.05.2013 15:04, John Ferlan wrote:
On 05/20/2013 01:55 PM, Michal Privoznik wrote:
---
[...snip...]
diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c
index 2509c0d..ac5f7ed
In bf1fe848 I've introduced 'newName' variable to substitute the old
'const char *name' as previously we had an ugly code there:
name = strdup(name);
However, some parts of the function were not updated, so they were still
calling VIR_FREE(name) instead of VIR_FREE(newName).
---
There is possibility to jump to 'cleanup' label without tapfd variable
being initialized. In the label, VIR_FORCE_CLOSE(tapfd) is called which
can have fatal consequences.
---
src/uml/uml_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/uml/uml_conf.c
On 23/05/13 22:05, Michal Privoznik wrote:
In bf1fe848 I've introduced 'newName' variable to substitute the old
'const char *name' as previously we had an ugly code there:
name = strdup(name);
However, some parts of the function were not updated, so they were still
calling VIR_FREE(name)
On 23/05/13 22:05, Michal Privoznik wrote:
There is possibility to jump to 'cleanup' label without tapfd variable
being initialized. In the label, VIR_FORCE_CLOSE(tapfd) is called which
can have fatal consequences.
---
src/uml/uml_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Previously, we were freeing verr fields instead of rerr which we've
allocated just a line above.
---
src/rpc/virnetmessage.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/rpc/virnetmessage.c b/src/rpc/virnetmessage.c
index 4c6703d..f27a236 100644
---
Since f03dcc5 we use [::] as the listening address both on qemu
command line in -incoming and in nbd-server-start QMP command.
However the latter requires just :: without the braces.
---
src/qemu/qemu_migration.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
On 23/05/13 22:05, Michal Privoznik wrote:
Previously, we were freeing verr fields instead of rerr which we've
allocated just a line above.
---
src/rpc/virnetmessage.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/rpc/virnetmessage.c b/src/rpc/virnetmessage.c
On 23/05/13 22:23, Ján Tomko wrote:
Since f03dcc5 we use [::] as the listening address both on qemu
command line in -incoming and in nbd-server-start QMP command.
However the latter requires just :: without the braces.
---
src/qemu/qemu_migration.c | 8 +++-
1 file changed, 7
On 23.05.2013 13:28, Ján Tomko wrote:
On 05/20/2013 07:55 PM, Michal Privoznik wrote:
---
src/xen/block_stats.c| 16 ++--
src/xen/xen_driver.c | 9 +++
src/xen/xen_hypervisor.c | 19 --
src/xen/xen_inotify.c| 15 +++
src/xen/xend_internal.c |
On 05/22/2013 09:58 AM, Cole Robinson wrote:
On 05/22/2013 08:55 AM, Deepak C Shetty wrote:
Hi All,
I was looking at virsh attach-disk and i see the below
[snip]
DESCRIPTION
Attach new disk device.
OPTIONS
[--domain] string domain name, id or uuid
[--source] string
On 05/23/2013 05:07 PM, Michal Privoznik wrote:
On 23.05.2013 13:28, Ján Tomko wrote:
On 05/20/2013 07:55 PM, Michal Privoznik wrote:
---
src/xen/block_stats.c| 16 ++--
src/xen/xen_driver.c | 9 +++
src/xen/xen_hypervisor.c | 19 --
src/xen/xen_inotify.c
On 05/23/2013 06:25 AM, ALVARO POLO VALDENEBRO wrote:
Hi,
I think I've found a possible bug in the way OpenVZ is assigning the guest
interface names when network is bridged. It's manifested at least in 1.0.5
version and master branch.
As we can see in openvzDomainSetNetwork() function
On 05/22/2013 04:44 PM, Eric Blake wrote:
On 05/22/2013 05:37 AM, Ján Tomko wrote:
Don't free the stream on error if we've successfully added it
to the hash table, since it will be freed by virChrdevHashEntryFree
callback.
Preserve the error message before calling virStreamFree, since it
On 05/23/2013 04:32 PM, Osier Yang wrote:
On 23/05/13 22:23, Ján Tomko wrote:
Since f03dcc5 we use [::] as the listening address both on qemu
command line in -incoming and in nbd-server-start QMP command.
However the latter requires just :: without the braces.
---
src/qemu/qemu_migration.c
---
In case we want virsh included to these changes.
tools/virsh.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 6f0c1ef..26d37c6 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -122,9 +122,7 @@ _vshStrdup(vshControl *ctl, const
On 20.05.2013 19:55, Michal Privoznik wrote:
---
cfg.mk | 8
1 file changed, 8 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index bb93c6a..c714915 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -387,6 +387,11 @@ sc_prohibit_asprintf:
halt='use strdup instead of virAsprintf with %s'
With unknown good reasons, the attribute bus of scsi device
address is always set to 0, same for attribute target. (See
virDomainDiskDefAssignAddress).
Though we might need to change the algorithm to honor bus
and target too, that's a different issue. The address generator
for scsi host device
---
Pushed under the trivial rule.
src/conf/virchrdev.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c
index 17b1f05..36fbb97 100644
--- a/src/conf/virchrdev.c
+++ b/src/conf/virchrdev.c
@@ -89,8 +89,10 @@ static char
This patch adds functionality to allow libvirt to configure the
'native-tagged' and 'native-untagged' modes on openvswitch networks.
v2 changes:
Fix problems reported by Eric Blake
v3 changes:
Re work patch to address review comments
v4 changes:
Use enum for native modes
---
diff --git
Only /dev/random and /dev/hwrng are accepted, list them explicitly.
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 3a200aa..755d084 100644
--- a/docs/formatdomain.html.in
+++
On 05/23/2013 12:37 PM, Cole Robinson wrote:
Only /dev/random and /dev/hwrng are accepted, list them explicitly.
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index
On 05/23/2013 10:32 AM, Michal Privoznik wrote:
---
In case we want virsh included to these changes.
Yes, we do.
tools/virsh.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 6f0c1ef..26d37c6 100644
--- a/tools/virsh.c
+++
On 05/23/2013 03:21 PM, Eric Blake wrote:
On 05/23/2013 12:37 PM, Cole Robinson wrote:
Only /dev/random and /dev/hwrng are accepted, list them explicitly.
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
diff --git a/docs/formatdomain.html.in
On 05/20/2013 11:55 AM, Michal Privoznik wrote:
---
cfg.mk | 8
1 file changed, 8 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index bb93c6a..c714915 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -387,6 +387,11 @@ sc_prohibit_asprintf:
halt='use strdup instead of virAsprintf with
Commit '18b14012' refactored the Xen code resulting in a Coverity
warning about possible NULL reference if the path where the XM driver
takes puts the def on it's list. Moved/duplicated the virGetDomain()
call to pacify the possible NULL deref.
NOTE: I did ping Dan B, but he is away, so rather
On 05/20/2013 11:55 AM, Michal Privoznik wrote:
---
34 files changed, 357 insertions(+), 570 deletions(-)
I've got my work cut out for me!
@@ -226,8 +228,11 @@ char *virBitmapFormat(virBitmapPtr bitmap)
return NULL;
cur = virBitmapNextSetBit(bitmap, -1);
-if (cur 0)
On 05/23/2013 09:20 AM, John Ferlan wrote:
Commit '18b14012' refactored the Xen code resulting in a Coverity
warning about possible NULL reference if the path where the XM driver
takes puts the def on it's list. Moved/duplicated the virGetDomain()
call to pacify the possible NULL deref.
On 05/23/2013 09:07 AM, Michal Privoznik wrote:
Would it be possible to rather:
diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c
index 41eb928..7c05911 100644
--- a/src/xen/xm_internal.c
+++ b/src/xen/xm_internal.c
@@ -1171,8 +1171,6 @@ xenXMListDefinedDomains(virConnectPtr
On 05/22/2013 06:32 PM, Dominik Mostowiec wrote:
I tested on 1.0.5 patched version and vm with 2 vfs working fine.
I have another problem
When i set max_vfs=63:
internal error missing IFLA_VF_INFO in netlink response
Its working when max_vfs=31
What is the platform, kernel version, and
On 05/23/2013 05:22 PM, Eric Blake wrote:
On 05/23/2013 09:20 AM, John Ferlan wrote:
Commit '18b14012' refactored the Xen code resulting in a Coverity
warning about possible NULL reference if the path where the XM driver
takes puts the def on it's list. Moved/duplicated the virGetDomain()
Introduced by commit 1daa4ba33acf. vshCommandOptStringReq returns
0 on *success* or the option is not required not present, both
are right result. Error out when returning 0 is not correct.
---
tools/virsh-volume.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi List,
Facing issues trying to use virDomainAttachDevice API of libvirt
from python.
Here is what I am trying to do
1) Setup qemu-nbd to export a qcow2 disk image over unix socket on my
localhost
qemu-nbd -t -k /tmp/mysock2 /home/dpkshetty/work/img/iscsi_disk
The above blocks. and i
59 matches
Mail list logo
