Re: [libvirt] [PATCH v3] conf: Generate address for scsi host device automatically

2013-05-31 Thread Osier Yang
On 31/05/13 22:14, Osier Yang wrote: On 31/05/13 22:09, Eric Blake wrote: On 05/31/2013 04:09 AM, Osier Yang wrote: With unknown good reasons, the attribute "bus" of scsi device address is always set to 0, same for attribute "target". (See virDomainDiskDefAssignAddress). Though we might need t

Re: [libvirt] kFreeBSD pdwtags make check failure

2013-05-31 Thread Guido Günther
Hi Eric, On Fri, May 31, 2013 at 12:31:48PM -0600, Eric Blake wrote: > On 05/31/2013 12:16 PM, Guido Günther wrote: > > Hi, > > make check on kFreeBSD currently fails with: > > > > > -uint64_t cpu_time; > > +long unsigned int cpu_time; > > What version

Re: [libvirt] [PATCH] qemu: prevent termination of guests w/hostdev on driver reconnect

2013-05-31 Thread Laine Stump
On 05/31/2013 02:55 PM, Eric Blake wrote: > On 05/31/2013 12:53 PM, Laine Stump wrote: >> This should resolve: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=959191 >> >> The problem was that qemuUpdateActivePciHostdevs was returning 0 >> (success) when no hostdevs were present, but would othe

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-05-31 Thread Don Dugger
On Thu, May 30, 2013 at 01:48:32PM +0200, Jiri Denemark wrote: > On Tue, May 28, 2013 at 16:11:57 -0600, Don Dugger wrote: > > [V2 - Improve the error handling] > > > > I've opened BZ 697141 on this as I would consider it more > > I guess you meant BZ 967141. > > > a bug than a feature request.

Re: [libvirt] [PATCH] qemu: prevent termination of guests w/hostdev on driver reconnect

2013-05-31 Thread Eric Blake
On 05/31/2013 12:53 PM, Laine Stump wrote: > This should resolve: > > https://bugzilla.redhat.com/show_bug.cgi?id=959191 > > The problem was that qemuUpdateActivePciHostdevs was returning 0 > (success) when no hostdevs were present, but would otherwise return -1 > (failure) even when it complet

[libvirt] [PATCH] qemu: prevent termination of guests w/hostdev on driver reconnect

2013-05-31 Thread Laine Stump
This should resolve: https://bugzilla.redhat.com/show_bug.cgi?id=959191 The problem was that qemuUpdateActivePciHostdevs was returning 0 (success) when no hostdevs were present, but would otherwise return -1 (failure) even when it completed successfully. It is only called from qemuProcessReconn

Re: [libvirt] kFreeBSD pdwtags make check failure

2013-05-31 Thread Eric Blake
On 05/31/2013 12:16 PM, Guido Günther wrote: > Hi, > make check on kFreeBSD currently fails with: > > -uint64_t cpu_time; > +long unsigned int cpu_time; What version of pdwtags? Also, what version of rpcgen? We are definitely requesting a 64-bit type

[libvirt] kFreeBSD pdwtags make check failure

2013-05-31 Thread Guido Günther
Hi, make check on kFreeBSD currently fails with: make[3]: Entering directory `/data/home/jenkins/jobs/libvirt-build-debian-jessie-kfreebsd64/workspace/libvirt/src' GENremote_protocol-struct --- remote_protocol-structs 2013-05-03 17:48:29.0 +0200 +++ remote_protocol-struct-t3 2

[libvirt] [PATCH] maint: don't use config.h in .h files

2013-05-31 Thread Eric Blake
Enforce the rule that .h files don't need to (redundantly) include . * cfg.mk (sc_prohibit_config_h_in_headers): New rule. (_virsh_includes): Delete; instead, inline a smaller number of exclusions... (exclude_file_name_regexp--sc_require_config_h) (exclude_file_name_regexp--sc_require_config_h_fir

Re: [libvirt] [PATCH] vbox: define DYNLIB_NAME for kFreeBSD

2013-05-31 Thread Guido Günther
On Thu, May 30, 2013 at 02:59:56PM -0600, Eric Blake wrote: > On 05/30/2013 02:48 PM, Guido Günther wrote: > > Similar to what Eric did for Cygwin it helps at least to compile > > without --without-vbox > > Well, my patch for Cygwin was nak'd, so you probably ought to amend the > commit message. >

Re: [libvirt] [PATCH] build: skip qemu in tests when !WITH_QEMU

2013-05-31 Thread Eric Blake
On 05/31/2013 10:50 AM, Eric Blake wrote: > * tests/testutilsqemu.h: Make content conditional. > > Signed-off-by: Eric Blake > --- > > Pushing under the build-breaker rule. I'm getting closer to a > clean ./autobuild.sh run. > > tests/testutilsqemu.h | 9 ++--- > 1 file changed, 6 insert

[libvirt] [PATCH] build: skip qemu in tests when !WITH_QEMU

2013-05-31 Thread Eric Blake
A mingw build (where the qemu driver is not built, so WITH_QEMU is undefined) failed with: In file included from ../../src/qemu/qemu_command.h:30:0, from ../../tests/testutilsqemu.h:4, from ../../tests/networkxml2xmltest.c:14: ../../src/qemu/qemu_conf.h:53:4: erro

Re: [libvirt] [PATCH] Introduce virFilePrintf() as a portable fprintf()

2013-05-31 Thread Eric Blake
On 05/17/2013 08:34 AM, Eric Blake wrote: > On 05/17/2013 08:11 AM, Daniel P. Berrange wrote: >> From: "Daniel P. Berrange" >> >> We can't use GNULIB's fprintf-posix due to licensing >> incompatibilities. We do already have a portable >> formatting via virAsprintf() which we got from GNULIB >> tho

Re: [libvirt] [PATCH] Document that runtime changes may be lost after S4 suspend

2013-05-31 Thread Jiri Denemark
On Fri, May 31, 2013 at 10:07:22 -0600, Eric Blake wrote: > On 05/31/2013 10:03 AM, Jiri Denemark wrote: > > --- > > src/libvirt.c | 7 +++ > > tools/virsh.pod | 7 +++ > > 2 files changed, 14 insertions(+) > > ACK. Thanks, pushed. Jirka -- libvir-list mailing list libvir-list@redhat

Re: [libvirt] [PATCH] Document that runtime changes may be lost after S4 suspend

2013-05-31 Thread Eric Blake
On 05/31/2013 10:03 AM, Jiri Denemark wrote: > --- > src/libvirt.c | 7 +++ > tools/virsh.pod | 7 +++ > 2 files changed, 14 insertions(+) ACK. > > diff --git a/src/libvirt.c b/src/libvirt.c > index b129611..6967613 100644 > --- a/src/libvirt.c > +++ b/src/libvirt.c > @@ -2472,6 +2472

[libvirt] [PATCH] Document that runtime changes may be lost after S4 suspend

2013-05-31 Thread Jiri Denemark
--- src/libvirt.c | 7 +++ tools/virsh.pod | 7 +++ 2 files changed, 14 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index b129611..6967613 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -2472,6 +2472,13 @@ error: * Dependent on hypervisor used, this may require a * g

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

2013-05-31 Thread Jim Fehlig
Marek Marczykowski wrote: > On 31.05.2013 10:25, Ian Campbell wrote: > >> On Thu, 2013-05-30 at 11:53 -0600, Jim Fehlig wrote: >> >>> Marek Marczykowski wrote: >>> On 01.05.2013 16:11, Daniel P. Berrange wrote: > On Wed, May 01, 2013 at 02:44:11PM +0100

Re: [libvirt] [PATCH] qemu: escape literal IPv6 address in NBD migration

2013-05-31 Thread Ján Tomko
On 05/31/2013 04:03 PM, Eric Blake wrote: > On 05/31/2013 05:33 AM, Ján Tomko wrote: >> A literal IPv6 must be escaped, otherwise migration fails with: >> unable to execute QEMU command 'drive-mirror': address resolution failed >> for f0::0d:5901: Servname not supported for ai_socktype >> since QEM

Re: [libvirt] [PATCH] Check for existence of interface prior to setting terminate flag

2013-05-31 Thread John Ferlan
On 05/31/2013 09:59 AM, Eric Blake wrote: > On 05/31/2013 06:06 AM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=903480 >> >> During domain destruction it's possible that the learnIPAddressThread has >> already removed the interface prior to the teardown filter path being run.

Re: [libvirt] [PATCH v3] conf: Generate address for scsi host device automatically

2013-05-31 Thread Osier Yang
On 31/05/13 22:11, John Ferlan wrote: On 05/31/2013 06:09 AM, Osier Yang wrote: With unknown good reasons, the attribute "bus" of scsi device address is always set to 0, same for attribute "target". (See virDomainDiskDefAssignAddress). Though we might need to change the algorithm to honor "bus"

Re: [libvirt] Information needed about "virsh # cpu-stats test_vm"

2013-05-31 Thread Eric Blake
On 05/31/2013 01:48 AM, Anusha Rayani wrote: > Hi, > we are using currently libvirt-0.10.2. > And yes in our platform cpu contorller(cpuacct) is not mounted. > > Could you please let us know how we can mount more controllers through > libvirt. Libvirt won't mount cgroup controllers if they are no

Re: [libvirt] Information needed about "virsh # cpu-stats test_vm"

2013-05-31 Thread Anusha Rayani
Hi, We have tried with latest libvirt i.e, libvirt-1.0.5 also. Still i am facing the same error in executing the "cpu-stats" command : virsh # cpu-stats test error: Failed to retrieve CPU statistics for domain 'test' error: Requested operation is not valid: cgroup CPUACCT controller is not mounte

Re: [libvirt] [PATCH] Resolve memory leak found by valgrind

2013-05-31 Thread John Ferlan
On 05/31/2013 09:54 AM, John Ferlan wrote: > Commit '6afdfc8e' adjusted the exit and error paths to go through the error > and cleanup labels, but neglected to remove the return ret prior to cleanup. > Also noted the 'type' xml string fetch was never checked for NULL which > could lead to some inte

[libvirt] [PATCH 1/2] qemu: Add capability flag for usb-storage

2013-05-31 Thread Fred A. Kemp
From: "Fred A. Kemp" Allow use of the usb-storage device only if the new capability flag QEMU_CAPS_DEVICE_USB_STORAGE is set, which it is for qemu(-kvm) versions >= 0.12.1.2-rhel62-beta. --- src/qemu/qemu_capabilities.c |2 ++ src/qemu/qemu_capabilities.h |1 + src/qemu/qemu_command.c

[libvirt] [PATCH 0/2] Support setting the 'removable' flag for USB disks

2013-05-31 Thread Fred A. Kemp
From: "Fred A. Kemp" For reference, my first attempt at a patch for this feature was: <1363682454-32012-1-git-send-email-ano...@lavabit.com> I believe this patch fixes all previous concerns raised that thread. However, note that I've only added the new capability for usb-storage.removable to the

[libvirt] [PATCH 2/2] qemu: Support setting the 'removable' flag for USB disks

2013-05-31 Thread Fred A. Kemp
From: "Fred A. Kemp" Add an attribute named 'removable' to the 'target' element of disks, which controls the removable flag. For instance, on a Linux guest it controls the value of /sys/block/$dev/removable. This option is only valid for USB disks (i.e. bus='usb'), and its default value is 'off',

Re: [libvirt] [PATCH] qemu: snapshot: Don't kill access to disk if snapshot creation fails

2013-05-31 Thread Peter Krempa
On 05/31/13 16:01, Eric Blake wrote: On 05/31/2013 07:45 AM, Peter Krempa wrote: If snapshot creation failed for example due to invalid use of the "REUSE_EXTERNAL" flag, libvirt killed access to the original image file instead of the new image file. On machines with selinux this kills the whole

Re: [libvirt] [PATCH v3] conf: Generate address for scsi host device automatically

2013-05-31 Thread Osier Yang
On 31/05/13 22:09, Eric Blake wrote: On 05/31/2013 04:09 AM, Osier Yang wrote: With unknown good reasons, the attribute "bus" of scsi device address is always set to 0, same for attribute "target". (See virDomainDiskDefAssignAddress). Though we might need to change the algorithm to honor "bus"

Re: [libvirt] [PATCH] Resolve memory leak found by valgrind

2013-05-31 Thread Osier Yang
On 31/05/13 21:59, Osier Yang wrote: On 31/05/13 21:54, John Ferlan wrote: Commit '6afdfc8e' adjusted the exit and error paths to go through the error and cleanup labels, but neglected to remove the return ret prior to cleanup. Also noted the 'type' xml string fetch was never checked for NULL

Re: [libvirt] [PATCH v3] conf: Generate address for scsi host device automatically

2013-05-31 Thread John Ferlan
On 05/31/2013 06:09 AM, Osier Yang wrote: > With unknown good reasons, the attribute "bus" of scsi device > address is always set to 0, same for attribute "target". (See > virDomainDiskDefAssignAddress). > > Though we might need to change the algorithm to honor "bus" > and "target" too, that's a d

Re: [libvirt] [PATCH] Resolve memory leak found by valgrind

2013-05-31 Thread Osier Yang
On 31/05/13 21:54, John Ferlan wrote: Commit '6afdfc8e' adjusted the exit and error paths to go through the error and cleanup labels, but neglected to remove the return ret prior to cleanup. Also noted the 'type' xml string fetch was never checked for NULL which could lead to some interesting res

Re: [libvirt] [PATCH v3] conf: Generate address for scsi host device automatically

2013-05-31 Thread Eric Blake
On 05/31/2013 04:09 AM, Osier Yang wrote: > With unknown good reasons, the attribute "bus" of scsi device > address is always set to 0, same for attribute "target". (See > virDomainDiskDefAssignAddress). > > Though we might need to change the algorithm to honor "bus" > and "target" too, that's a d

Re: [libvirt] [PATCH] qemu: snapshot: Don't kill access to disk if snapshot creation fails

2013-05-31 Thread Eric Blake
On 05/31/2013 07:45 AM, Peter Krempa wrote: > If snapshot creation failed for example due to invalid use of the > "REUSE_EXTERNAL" flag, libvirt killed access to the original image file > instead of the new image file. On machines with selinux this kills the > whole VM as the selinux context is enf

Re: [libvirt] [PATCH] qemu: escape literal IPv6 address in NBD migration

2013-05-31 Thread Eric Blake
On 05/31/2013 05:33 AM, Ján Tomko wrote: > A literal IPv6 must be escaped, otherwise migration fails with: > unable to execute QEMU command 'drive-mirror': address resolution failed > for f0::0d:5901: Servname not supported for ai_socktype > since QEMU treats everything after the first ':' as the p

Re: [libvirt] [PATCH] Check for existence of interface prior to setting terminate flag

2013-05-31 Thread Eric Blake
On 05/31/2013 06:06 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=903480 > > During domain destruction it's possible that the learnIPAddressThread has > already removed the interface prior to the teardown filter path being run. > The teardown code would only be telling the t

[libvirt] [PATCH] Resolve memory leak found by valgrind

2013-05-31 Thread John Ferlan
Commit '6afdfc8e' adjusted the exit and error paths to go through the error and cleanup labels, but neglected to remove the return ret prior to cleanup. Also noted the 'type' xml string fetch was never checked for NULL which could lead to some interesting results. --- src/conf/storage_conf.c | 8 +

[libvirt] [PATCH] qemu: Fix damaged whitespace

2013-05-31 Thread Peter Krempa
After deleting "WithDriver" from the async job function the code was unaligned. --- Notes: Pushed as trivial. src/qemu/qemu_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d0dee14..e638e7c 100644 --- a/src/q

[libvirt] [PATCH] qemu: snapshot: Don't kill access to disk if snapshot creation fails

2013-05-31 Thread Peter Krempa
If snapshot creation failed for example due to invalid use of the "REUSE_EXTERNAL" flag, libvirt killed access to the original image file instead of the new image file. On machines with selinux this kills the whole VM as the selinux context is enforced immediately. * qemu_driver.c:qemuDomainSnapsh

[libvirt] [PATCH] Properly indent function's opening bracket

2013-05-31 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- Notes: Pushed as 'trivial' src/storage/storage_backend_fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 1379f17..1a85afc 100644 --- a/src/storage/storage

[libvirt] [PATCH] Check for existence of interface prior to setting terminate flag

2013-05-31 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=903480 During domain destruction it's possible that the learnIPAddressThread has already removed the interface prior to the teardown filter path being run. The teardown code would only be telling the thread to terminate. --- src/nwfilter/nwfilter_learni

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 13:14 +0200, Marek Marczykowski wrote: > >> Optional attribute for tag? Maybe sth like: > >> /usr/lib/xen/boot/ioemu-stubdom.gz > >> ? > > > > FWIW the path can be omitted and libxl will DTRT. > > Indeed. It looks like libxl even doesn't allow custom stubdom path - always >

[libvirt] NBD drives with literal IPv6 addresses or hostnames starting with a digit

2013-05-31 Thread Ján Tomko
Hello, since qemu's commit v1.4.0-736-gf17c90b [1]: nbd: Keep hostname and port separate * literal IPv6 addresses no longer work in nbd URIs, because getaddrinfo is called with the surrounding brackets: $ qemu-system-x86_64 -drive file=nbd://[::1]:1234/quack qemu-system-x86_64: -drive file=nb

[libvirt] [PATCH] qemu: escape literal IPv6 address in NBD migration

2013-05-31 Thread Ján Tomko
A literal IPv6 must be escaped, otherwise migration fails with: unable to execute QEMU command 'drive-mirror': address resolution failed for f0::0d:5901: Servname not supported for ai_socktype since QEMU treats everything after the first ':' as the port. --- src/qemu/qemu_migration.c | 14

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

2013-05-31 Thread Marek Marczykowski
On 31.05.2013 12:55, Ian Campbell wrote: > On Fri, 2013-05-31 at 12:46 +0200, Marek Marczykowski wrote: >> On 31.05.2013 10:25, Ian Campbell wrote: >>> On Thu, 2013-05-30 at 11:53 -0600, Jim Fehlig wrote: Marek Marczykowski wrote: > On 01.05.2013 16:11, Daniel P. Berrange wrote: > >

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 12:46 +0200, Marek Marczykowski wrote: > On 31.05.2013 10:25, Ian Campbell wrote: > > On Thu, 2013-05-30 at 11:53 -0600, Jim Fehlig wrote: > >> Marek Marczykowski wrote: > >>> On 01.05.2013 16:11, Daniel P. Berrange wrote: > >>> > On Wed, May 01, 2013 at 02:44:11PM +01

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

2013-05-31 Thread Marek Marczykowski
On 31.05.2013 10:25, Ian Campbell wrote: > On Thu, 2013-05-30 at 11:53 -0600, Jim Fehlig wrote: >> Marek Marczykowski wrote: >>> On 01.05.2013 16:11, Daniel P. Berrange wrote: >>> On Wed, May 01, 2013 at 02:44:11PM +0100, David Scott wrote: > On 01/05/13 09:46, Ian Campbell wr

[libvirt] [PATCH v3] conf: Generate address for scsi host device automatically

2013-05-31 Thread Osier Yang
With unknown good reasons, the attribute "bus" of scsi device address is always set to 0, same for attribute "target". (See virDomainDiskDefAssignAddress). Though we might need to change the algorithm to honor "bus" and "target" too, that's a different issue. The address generator for scsi host de

Re: [libvirt] [PATCH v2] conf: Generate address for scsi host device automatically

2013-05-31 Thread Osier Yang
On 28/05/13 23:59, Osier Yang wrote: On 28/05/13 23:09, John Ferlan wrote: On 05/23/2013 12:48 PM, Osier Yang wrote: With unknown good reasons, the attribute "bus" of scsi device address is always set to 0, same for attribute "target". (See virDomainDiskDefAssignAddress). Though we might need

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an to be selected in the domain config XML

2013-05-31 Thread Ian Campbell
On Thu, 2013-05-30 at 11:53 -0600, Jim Fehlig wrote: > Marek Marczykowski wrote: > > On 01.05.2013 16:11, Daniel P. Berrange wrote: > > > >> On Wed, May 01, 2013 at 02:44:11PM +0100, David Scott wrote: > >> > >>> On 01/05/13 09:46, Ian Campbell wrote: > >>> > I would suggest tha

Re: [libvirt] Information needed about "virsh # cpu-stats test_vm"

2013-05-31 Thread Anusha Rayani
Hi, we are using currently libvirt-0.10.2. And yes in our platform cpu contorller(cpuacct) is not mounted. Could you please let us know how we can mount more controllers through libvirt. It would be helpful for us. Regards, Anusha On Fri, May 31, 2013 at 3:27 AM, Eric Blake wrote: > On 05/30/2