[libvirt] [PATCH] virsh: Obey pool-or-uuid spec when creating volumes

2013-06-04 Thread Jiri Denemark
Our documentation says a pool may be referenced by its name or UUID anywhere if it makes sense (pool-name and pool-uuid are the only exceptions). However, vol-create and vol-create-as commands did not obey this. --- tools/virsh-volume.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

Re: [libvirt] [PATCH] virsh: Obey pool-or-uuid spec when creating volumes

2013-06-04 Thread Peter Krempa
On 06/04/13 10:27, Jiri Denemark wrote: Our documentation says a pool may be referenced by its name or UUID anywhere if it makes sense (pool-name and pool-uuid are the only exceptions). However, vol-create and vol-create-as commands did not obey this. --- tools/virsh-volume.c | 6 ++ 1

Re: [libvirt] [PATCH] virsh: Obey pool-or-uuid spec when creating volumes

2013-06-04 Thread Jiri Denemark
On Tue, Jun 04, 2013 at 10:41:35 +0200, Peter Krempa wrote: On 06/04/13 10:27, Jiri Denemark wrote: Our documentation says a pool may be referenced by its name or UUID anywhere if it makes sense (pool-name and pool-uuid are the only exceptions). However, vol-create and vol-create-as

[libvirt] [PATCH] snapshot: remove mutually exclusive memory and disk-only duplicate check

2013-06-04 Thread Guannan Ren
The work was done at the time of snapshot xmlstring parsing if (offline def-memory def-memory != VIR_DOMAIN_SNAPSHOT_LOCATION_NONE) { virReportError(...); } --- src/qemu/qemu_driver.c | 8 1 file changed, 8 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] virsh: Allow attach-disk to specify disk wwn

2013-06-04 Thread Guannan Ren
On 06/04/2013 11:27 AM, Osier Yang wrote: Commit 6e73850b01ee support to set wwn for disks, but it was not exposed to attach-disk. --- tools/virsh-domain.c | 14 +- tools/virsh.pod | 8 2 files changed, 17 insertions(+), 5 deletions(-) diff --git

[libvirt] [PATCH] Document security reporting handling process

2013-06-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Historically security issues in libvirt have been primarily triaged fixed by the Red Hat libvirt members Red Hat security team, who then usually notify other vendors via appropriate channels. There have been a number of times when vendors have not

[libvirt] [PATCH] selinux: fix segfault in virSecuritySELinuxMCSGetProcessRange

2013-06-04 Thread Ján Tomko
From: James Gilliland neclim...@gmail.com https://bugzilla.redhat.com/show_bug.cgi?id=969878 --- src/security/security_selinux.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index b862fbf..3d8195c

Re: [libvirt] [PATCH] selinux: fix segfault in virSecuritySELinuxMCSGetProcessRange

2013-06-04 Thread Daniel P. Berrange
On Tue, Jun 04, 2013 at 12:16:05PM +0200, Ján Tomko wrote: From: James Gilliland neclim...@gmail.com https://bugzilla.redhat.com/show_bug.cgi?id=969878 --- src/security/security_selinux.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH v3 00/12] Add user namespace support for libvirt lxc

2013-06-04 Thread richard -rw- weinberger
On Thu, May 23, 2013 at 6:06 AM, Gao feng gaof...@cn.fujitsu.com wrote: This patchset try to add userns support for libvirt lxc. Since userns is nearly completed in linux-3.9, the old kernel doesn't support userns, I add some New XML elements to let people decide if enable userns.The userns is

Re: [libvirt] [PATCH v3 00/12] Add user namespace support for libvirt lxc

2013-06-04 Thread Gao feng
On 06/04/2013 06:41 PM, richard -rw- weinberger wrote: On Thu, May 23, 2013 at 6:06 AM, Gao feng gaof...@cn.fujitsu.com wrote: This patchset try to add userns support for libvirt lxc. Since userns is nearly completed in linux-3.9, the old kernel doesn't support userns, I add some New XML

Re: [libvirt] [PATCH v3 00/12] Add user namespace support for libvirt lxc

2013-06-04 Thread Daniel P. Berrange
On Tue, Jun 04, 2013 at 06:54:10PM +0800, Gao feng wrote: On 06/04/2013 06:41 PM, richard -rw- weinberger wrote: On Thu, May 23, 2013 at 6:06 AM, Gao feng gaof...@cn.fujitsu.com wrote: This patchset try to add userns support for libvirt lxc. Since userns is nearly completed in linux-3.9,

[libvirt] [PATCH] tests: fix typo in securityselinuxtest

2013-06-04 Thread Ján Tomko
--- Pushed as trivial. tests/securityselinuxtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/securityselinuxtest.c b/tests/securityselinuxtest.c index f276e6d..bdf248b 100644 --- a/tests/securityselinuxtest.c +++ b/tests/securityselinuxtest.c @@ -231,7 +231,7 @@

[libvirt] [PATCHv2 1/2] selinux: fix segfault in virSecuritySELinuxMCSGetProcessRange

2013-06-04 Thread Ján Tomko
From: James Gilliland neclim...@gmail.com https://bugzilla.redhat.com/show_bug.cgi?id=969878 --- src/security/security_selinux.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index b862fbf..3c67f24

[libvirt] [PATCHv2 2/2] tests: add test for a selinux label without a range

2013-06-04 Thread Ján Tomko
--- tests/securityselinuxtest.c | 44 +--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/tests/securityselinuxtest.c b/tests/securityselinuxtest.c index bdf248b..a53b4ee 100644 --- a/tests/securityselinuxtest.c +++

[libvirt] [PATCHv2 0/2] fix segfault in virSecuritySELinuxMCSGetProcessRange

2013-06-04 Thread Ján Tomko
Diff to v2: Changed char * to const char * after actually compiling it with selinux. Added a test. James Gilliland (1): selinux: fix segfault in virSecuritySELinuxMCSGetProcessRange Ján Tomko (1): tests: add test for a selinux label without a range src/security/security_selinux.c | 9

[libvirt] [PATCH] virtlockd: fix socket path

2013-06-04 Thread Ján Tomko
Change the socket path to match the one used by lockd driver. https://bugzilla.redhat.com/show_bug.cgi?id=968128 --- src/locking/virtlockd.socket.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/locking/virtlockd.socket.in b/src/locking/virtlockd.socket.in index

[libvirt] Authoritative source for logging filters descriptions ?

2013-06-04 Thread Kashyap Chamarthy
Heya, So I usually use these two resources, when tracing/debugging: - https://www.berrange.com/posts/2011/10/03/troubleshooting-libvirt-with-the-kvm-and-lxc-drivers/ - http://libvirt.org/logging.html For instance, for filters to know what QMP commands libvirt is sending to QEMU: I use:

[libvirt] [PATCH] qemu: Report the offset from host UTC for RTC_CHANGE event

2013-06-04 Thread Osier Yang
https://bugzilla.redhat.com/show_bug.cgi?id=964177 Though both libvirt and QEMU's document say RTC_CHANGE returns the offset from the host UTC, qemu actually returns the offset from the specified date instead when specific date is privided (-rtc base=$date). It's not safe for qemu to fix it in

Re: [libvirt] Authoritative source for logging filters descriptions ?

2013-06-04 Thread Daniel P. Berrange
On Tue, Jun 04, 2013 at 05:15:26PM +0530, Kashyap Chamarthy wrote: Heya, So I usually use these two resources, when tracing/debugging: - https://www.berrange.com/posts/2011/10/03/troubleshooting-libvirt-with-the-kvm-and-lxc-drivers/ - http://libvirt.org/logging.html For instance,

Re: [libvirt] [PATCH] virsh: Allow attach-disk to specify disk wwn

2013-06-04 Thread Osier Yang
On 04/06/13 17:48, Guannan Ren wrote: On 06/04/2013 11:27 AM, Osier Yang wrote: Commit 6e73850b01ee support to set wwn for disks, but it was not exposed to attach-disk. --- tools/virsh-domain.c | 14 +- tools/virsh.pod | 8 2 files changed, 17 insertions(+), 5

Re: [libvirt] Authoritative source for logging filters descriptions ?

2013-06-04 Thread Kashyap Chamarthy
Furthermore, from /etc/libvirt/libvirtd.conf, I see: === [...] # Logging filters: # A filter allows to select a different logging level for a given category # of logs # The format for a filter is one of: #x:name #x:+name # where name

Re: [libvirt] [Qemu-devel] NBD drives with literal IPv6 addresses or hostnames starting with a digit

2013-06-04 Thread Stefan Hajnoczi
On Fri, May 31, 2013 at 01:38:51PM +0200, Ján Tomko wrote: Hello, since qemu's commit v1.4.0-736-gf17c90b [1]: nbd: Keep hostname and port separate * literal IPv6 addresses no longer work in nbd URIs, because getaddrinfo is called with the surrounding brackets: $ qemu-system-x86_64

[libvirt] [PATCH] Fix a invalid usage of virDomainNetDef in OpenVZ driver

2013-06-04 Thread Alvaro Polo
OpenVZ was accessing ethernet data to obtain the guest iface name regardless the domain is configured to use ethernet or bridged networking. This prevented the guest network interface to be rightly named for bridged networking. --- src/openvz/openvz_driver.c | 20 +--- 1 file

Re: [libvirt] [Qemu-devel] NBD drives with literal IPv6 addresses or hostnames starting with a digit

2013-06-04 Thread Ján Tomko
On 06/04/2013 02:19 PM, Stefan Hajnoczi wrote: CCing Kevin who authored v1.4.0-736-gf17c90b. Stefan I've already posted patches for both issues: http://lists.nongnu.org/archive/html/qemu-devel/2013-06/msg00227.html Jan -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCHv2 1/2] selinux: fix segfault in virSecuritySELinuxMCSGetProcessRange

2013-06-04 Thread Daniel P. Berrange
On Tue, Jun 04, 2013 at 01:23:59PM +0200, Ján Tomko wrote: From: James Gilliland neclim...@gmail.com https://bugzilla.redhat.com/show_bug.cgi?id=969878 --- src/security/security_selinux.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] ARM libvirt compiling error

2013-06-04 Thread Daniel P. Berrange
On Mon, Jun 03, 2013 at 11:27:41AM +0200, Michele Paolino wrote: Hello, I'm trying to set up a development environment on an Arndale (ARM Samsung Exynos 5250) board to work on sVirt. I'm using Debian 7.0, I've downloaded the source code from GIT and than: ./autogen.sh --prefix=$HOME/usr

Re: [libvirt] ARM libvirt compiling error

2013-06-04 Thread Eric Blake
On 06/04/2013 06:47 AM, Daniel P. Berrange wrote: conf/domain_conf.c: In function 'virDomainHostdevDefParseXML': conf/domain_conf.c:3915:36: error: 'next_unit' may be used uninitialized in this function [-Werror=uninitialized] Is it worth to submit a new bug report/patch the source? We'd

Re: [libvirt] [PATCH] qemu: Report the offset from host UTC for RTC_CHANGE event

2013-06-04 Thread Eric Blake
On 06/04/2013 05:49 AM, Osier Yang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964177 Though both libvirt and QEMU's document say RTC_CHANGE returns the offset from the host UTC, qemu actually returns the offset from the specified date instead when specific date is privided

Re: [libvirt] [PATCH] qemu: Report the offset from host UTC for RTC_CHANGE event

2013-06-04 Thread Osier Yang
On 04/06/13 20:59, Eric Blake wrote: On 06/04/2013 05:49 AM, Osier Yang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964177 Though both libvirt and QEMU's document say RTC_CHANGE returns the offset from the host UTC, qemu actually returns the offset from the specified date instead when

Re: [libvirt] [PATCH] qemu: Report the offset from host UTC for RTC_CHANGE event

2013-06-04 Thread Daniel P. Berrange
On Tue, Jun 04, 2013 at 06:59:02AM -0600, Eric Blake wrote: On 06/04/2013 05:49 AM, Osier Yang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964177 Though both libvirt and QEMU's document say RTC_CHANGE returns the offset from the host UTC, qemu actually returns the offset from

Re: [libvirt] [PATCH v3 01/12] LXC: Introduce New XML element for user namespace

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:45PM +0800, Gao feng wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ad5550c..a3c5c84 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10057,6 +10060,40 @@ cleanup: return ret; } + +/* Parse the XML

Re: [libvirt] [PATCH v3 02/12] LXC: enable user namespace only when user set the uidmap

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:46PM +0800, Gao feng wrote: User namespace will be enabled only when the idmap exist in configuration. If you want disable user namespace,just remove these elements from XML. If kernel doesn't support user namespace and idmap exist in configuration file,

Re: [libvirt] [PATCH v3 03/12] LXC: sort the uidmap/gidmap of domain

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:47PM +0800, Gao feng wrote: Make sure the mapping line contains the root user of container is the first element of idmap array. So we can get the real user id on host for the container easily. This patch also check the map information, User must map the root

Re: [libvirt] [PATCH v3 04/12] LXC: introduce virLXCControllerSetupUserns and lxcContainerSetID

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:48PM +0800, Gao feng wrote: This patch introduces new helper function virLXCControllerSetupUserns, in this function, we set the files uid_map and gid_map of the init task of container. lxcContainerSetID is used for creating cred for tasks running in container.

Re: [libvirt] [PATCH v3 06/12] LXC: Move creating /dev/ptmx to virLXCControllerSetupDevPTS

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:50PM +0800, Gao feng wrote: Make codes clearer and reduce some virAsprintf. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 44 +++- 1 file changed, 19 insertions(+), 25 deletions(-) This

[libvirt] [PATCH] Remove legacy code for single-instance devpts filesystem

2013-06-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com An earlier commit dropped support for using LXC with kernels having single-instance devpts filesystem from the LXC controller. It forgot to remove the same code from the LXC container setup. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH v3 09/12] LXC: controller: change the owner of /dev to the root user of container

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:53PM +0800, Gao feng wrote: container will create /dev/pts directory in /dev. the owner of /dev should be the root user of container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 14 ++ 1 file changed, 14

Re: [libvirt] [PATCH v3 07/12] LXC: fuse: Change files owner to the root user of container

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:51PM +0800, Gao feng wrote: Otherwise we will fail to mount the meminfo file. This patch also allows any users to access the fuse mount point. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_fuse.c | 6 ++ 1 file changed, 6 insertions(+)

Re: [libvirt] [PATCH v3 08/12] LXC: controller: change the owner of tty devices to the root user of container

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:52PM +0800, Gao feng wrote: Since these tty devices will be used by container, the owner of them should be the root user of container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 43 +--

Re: [libvirt] [PATCH v3 11/12] LXC: controller: change the owner of /dev/pts and ptmx to the root of container

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:55PM +0800, Gao feng wrote: This two files are created for container, the owner should be the root user of container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 30 ++ 1 file changed, 30

Re: [libvirt] [PATCH v3 10/12] LXC: controller: change the owner of devices created on host

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:54PM +0800, Gao feng wrote: Since these devices are created for the container. the owner should be the root user of the container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 14 ++ 1 file changed, 14

Re: [libvirt] [PATCH v3 12/12] LXC: introduce virLXCControllerChown

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:56PM +0800, Gao feng wrote: use virLXCControllerChown to make codes clearer. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 81 ++-- 1 file changed, 31 insertions(+), 50 deletions(-)

Re: [libvirt] [PATCH] Remove legacy code for single-instance devpts filesystem

2013-06-04 Thread Osier Yang
On 04/06/13 21:42, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com An earlier commit dropped support for using LXC with kernels having single-instance devpts filesystem from the LXC controller. It forgot to remove the same code from the LXC container setup. By commit

Re: [libvirt] [PATCH] qemu: Report the offset from host UTC for RTC_CHANGE event

2013-06-04 Thread Daniel P. Berrange
On Tue, Jun 04, 2013 at 09:46:14PM +0800, Osier Yang wrote: On 04/06/13 21:13, Daniel P. Berrange wrote: On Tue, Jun 04, 2013 at 06:59:02AM -0600, Eric Blake wrote: On 06/04/2013 05:49 AM, Osier Yang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964177 Though both libvirt and QEMU's

Re: [libvirt] [PATCH v3 05/12] LXC: Creating devices for container on host side

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:49PM +0800, Gao feng wrote: user namespace doesn't allow to create devices in uninit userns. We should create devices on host side. We first mount tmpfs on dev directroy under state dir of container. then create devices under this dev dir. Finally in

[libvirt] [PATCH] docs: add spaces to formatstorage.html

2013-06-04 Thread Ján Tomko
Let the pool types breathe. --- Trivial. docs/formatstorage.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index 9c3be67..1a45915 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@

Re: [libvirt] [PATCH] qemu: Report the offset from host UTC for RTC_CHANGE event

2013-06-04 Thread Osier Yang
On 04/06/13 21:13, Daniel P. Berrange wrote: On Tue, Jun 04, 2013 at 06:59:02AM -0600, Eric Blake wrote: On 06/04/2013 05:49 AM, Osier Yang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964177 Though both libvirt and QEMU's document say RTC_CHANGE returns the offset from the host UTC,

Re: [libvirt] [PATCH 1/3] qemu: Abstract code for the cpu controller setting into a helper

2013-06-04 Thread Martin Kletzander
On 05/24/2013 11:08 AM, Osier Yang wrote: --- src/qemu/qemu_cgroup.c | 55 +- 1 file changed, 36 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index bb1b235..cf46993 100644 ---

[libvirt] [libvirt-designer PATCHv3 6/9] Check for vioserial availability before adding a SPICE agent

2013-06-04 Thread Christophe Fergeau
This makes use of the new gvir_designer_domain_get_supported_devices() method. --- libvirt-designer/libvirt-designer-domain.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/libvirt-designer/libvirt-designer-domain.c

[libvirt] [libvirt-designer PATCHv3 9/9] Implement gvir_designer_domain_add_video()

2013-06-04 Thread Christophe Fergeau
This takes into account the devices specified by the deployment, if this fails, consider the intersection of devices supported by the OS and by the platform, and if this still fails, falls back to a hardcoded hypervisor type - video model mapping. --- examples/virtxml.c |

[libvirt] [libvirt-designer PATCHv3 4/9] Implement gvir_designer_domain_add_graphics()

2013-06-04 Thread Christophe Fergeau
This allows to choose between SPICE, VNC or a local display, which will go through SDL or 'desktop' depending on the hypervisor. --- configure.ac | 2 +- examples/virtxml.c | 4 ++ libvirt-designer/libvirt-designer-domain.c | 111

[libvirt] [libvirt-designer PATCHv3 8/9] Implement gvir_designer_domain_add_smartcard()

2013-06-04 Thread Christophe Fergeau
This setups smartcard redirection to the guest. I'm not yet fully sure what users could want to tweak there (there are various ways of setting up the smartcard redirection), so this code may need to be made more flexible. The current code is also not checking whether the hypervisor supports this

[libvirt] [libvirt-designer PATCHv3] Handle more devices in GVirDesignerDomain

2013-06-04 Thread Christophe Fergeau
Hi, Resending once more, only change since v2 is a small fix in 1/9 to avoid calling g_str_has_suffix on a NULL string when no short_id is available. Christophe -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-designer PATCHv3 5/9] Automatically add SPICE channel with SPICE graphics

2013-06-04 Thread Christophe Fergeau
When the user sets up the graphical framebuffer to use SPICE, we now add automatically the SPICE agent channel if it's not present already. --- libvirt-designer/libvirt-designer-domain.c | 85 ++ 1 file changed, 85 insertions(+) diff --git

[libvirt] [libvirt-designer PATCHv3 7/9] Implement gvir_designer_domain_add_usb_redir()

2013-06-04 Thread Christophe Fergeau
This will add an USB redirection channel to the VM. This can be called multiple times to redirect several USB devices at once. This will also adds the needed controllers if they are not already present in the VM. The current code has 2 shortcomings: - USB redirection is only supported with SPICE,

[libvirt] [libvirt-designer PATCHv3 1/9] Improve VM skeleton created by gvir_designer_domain_setup_guest()

2013-06-04 Thread Christophe Fergeau
Add various devices/configuration to libvirt XML config when creating the VM. This configuration is generic enough that it should be useful on all created VMs, that's why no public API is added to set them up. However, they are split in several helpers that can easily be exported if needed. What

[libvirt] [libvirt-designer PATCHv3 2/9] Implement gvir_designer_domain_add_sound()

2013-06-04 Thread Christophe Fergeau
--- examples/virtxml.c | 3 + libvirt-designer/libvirt-designer-domain.c | 131 + libvirt-designer/libvirt-designer-domain.h | 2 + libvirt-designer/libvirt-designer.sym | 1 + 4 files changed, 137 insertions(+) diff --git

Re: [libvirt] [PATCH] virtlockd: fix socket path

2013-06-04 Thread Eric Blake
On 06/04/2013 05:40 AM, Ján Tomko wrote: Change the socket path to match the one used by lockd driver. https://bugzilla.redhat.com/show_bug.cgi?id=968128 --- src/locking/virtlockd.socket.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [libvirt-designer PATCHv3 3/9] Update copyright notice

2013-06-04 Thread Christophe Fergeau
--- libvirt-designer/libvirt-designer-domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/libvirt-designer-domain.c index 684c458..36fc8ed 100644 --- a/libvirt-designer/libvirt-designer-domain.c +++

Re: [libvirt] [PATCH] build: only install examples when nwfilter is defined

2013-06-04 Thread Eric Blake
On 06/04/2013 08:43 AM, Jim Fehlig wrote: Only install nwfilter example XML files when WITH_NWFILTER is defined. Does this require any corresponding libvirt.spec.in file changes? --- examples/xml/nwfilter/Makefile.am | 5 + 1 file changed, 5 insertions(+) Looks reasonable, but I'd

Re: [libvirt] [PATCH] snapshot: remove mutually exclusive memory and disk-only duplicate check

2013-06-04 Thread Eric Blake
On 06/04/2013 02:55 AM, Guannan Ren wrote: The work was done at the time of snapshot xmlstring parsing if (offline def-memory def-memory != VIR_DOMAIN_SNAPSHOT_LOCATION_NONE) { virReportError(...); } --- src/qemu/qemu_driver.c | 8 1 file changed, 8 deletions(-)

Re: [libvirt] [PATCH 2/3] storage: Forbid to shrink the vol's capacity if no --shrink is specified

2013-06-04 Thread Michal Privoznik
On 31.05.2013 07:16, Osier Yang wrote: As the document for virsh-resize says: ... Attempts to shrink the volume will fail unless I--shrink is present; /... This makes sense as it at least prevent the user shrinking the important data of volume without a notice. ---

Re: [libvirt] [PATCH 1/3] storage: Support preallocate the new capacity for vol-resize

2013-06-04 Thread Michal Privoznik
On 31.05.2013 07:16, Osier Yang wrote: The document for vol-resize says the new capacity will be sparse unless --allocate is specified, however, the --allocate flag is never implemented. This implements the --allocate flag for fs backend's raw type volume, based on posix_fallocate and the

Re: [libvirt] [PATCH 3/3] storage: Allow --shrink for raw type volume of fs pool

2013-06-04 Thread Michal Privoznik
On 31.05.2013 07:16, Osier Yang wrote: There is no need to use posix_fallocate or SYS_fallocate to shrink the volume, ftruncate can do the work. qemu-img/kvm-img supports to shrink the volume itself. --- src/storage/storage_backend_fs.c | 7 +-- src/util/virstoragefile.c| 5

Re: [libvirt] [PATCH] Document security reporting handling process

2013-06-04 Thread Eric Blake
On 06/04/2013 04:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Historically security issues in libvirt have been primarily triaged fixed by the Red Hat libvirt members Red Hat security team, who then usually notify other vendors via appropriate channels.

Re: [libvirt] [PATCH] Fix a invalid usage of virDomainNetDef in OpenVZ driver

2013-06-04 Thread Daniel P. Berrange
On Tue, Jun 04, 2013 at 09:44:32AM +0200, Alvaro Polo wrote: OpenVZ was accessing ethernet data to obtain the guest iface name regardless the domain is configured to use ethernet or bridged networking. This prevented the guest network interface to be rightly named for bridged networking. Ooh,

Re: [libvirt] [PATCH] Fix a invalid usage of virDomainNetDef in OpenVZ driver

2013-06-04 Thread Eric Blake
On 06/04/2013 01:44 AM, Alvaro Polo wrote: OpenVZ was accessing ethernet data to obtain the guest iface name regardless the domain is configured to use ethernet or bridged networking. This prevented the guest network interface to be rightly named for bridged networking. ---

Re: [libvirt] [PATCH] Document security reporting handling process

2013-06-04 Thread Daniel P. Berrange
On Tue, Jun 04, 2013 at 09:33:15AM -0600, Eric Blake wrote: On 06/04/2013 04:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Historically security issues in libvirt have been primarily triaged fixed by the Red Hat libvirt members Red Hat security team,

Re: [libvirt] [PATCH] Document security reporting handling process

2013-06-04 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Tue, Jun 04, 2013 at 09:33:15AM -0600, Eric Blake wrote: On 06/04/2013 04:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Historically security issues in libvirt have been primarily triaged fixed by the Red Hat libvirt

[libvirt] [libvirt-glib 3/6] gconfig: Add gvir_config_domain_disk_[gs]et_driver_format

2013-06-04 Thread Christophe Fergeau
libvirt commit http://libvirt.org/git/?p=libvirt.git;a=commit;h=e2c41e486018ee74f6a75c1f717622 strongly hints that driver type for a disk domain should be an enum rather than a raw string. Since we already have setters/getters for this attribute, we can't use the same name as in the XML. However,

[libvirt] [libvirt-glib 1/6] gconfig: Allow not found child in gvir_config_object_get_child_with_type

2013-06-04 Thread Christophe Fergeau
This will be useful when implementing gvir_domain_snapshot_get_parent() as the child node 'parent' is not always present in the XML. --- libvirt-gconfig/libvirt-gconfig-object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig-object.c

[libvirt] [libvirt-glib 6/6] gconfig: Add GVirConfigDomainSnapshot getters/setters

2013-06-04 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-snapshot.c | 252 +- libvirt-gconfig/libvirt-gconfig-domain-snapshot.h | 48 - libvirt-gconfig/libvirt-gconfig.sym | 18 ++ 3 files changed, 316 insertions(+), 2 deletions(-) diff --git

[libvirt] [libvirt-glib 4/6] gconfig: Add GVirConfigDomainSnapshotDisk skeleton

2013-06-04 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am| 3 + .../libvirt-gconfig-domain-snapshot-disk.c | 88 ++ .../libvirt-gconfig-domain-snapshot-disk.h | 68 + .../libvirt-gconfig-domain-snapshot-private.h | 38 ++

[libvirt] [libvirt-glib 2/6] gconfig: Add GVirConfigDomainDiskFormat enum

2013-06-04 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-disk.h | 20 libvirt-gconfig/libvirt-gconfig.sym | 2 ++ 2 files changed, 22 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-disk.h b/libvirt-gconfig/libvirt-gconfig-domain-disk.h index 7363d31..e80a2fc

[libvirt] [libvirt-glib PATCHv3 0/6] gconfig: Add classes/methods for snapshot configuration

2013-06-04 Thread Christophe Fergeau
Hi, This is a resend of this patch series, the only changes since v2 is the rename of gvir_config_domain_disk_[gs]et_driver_type_enum to gvir_config_domain_disk_[gs]et_driver_format and the rename of gvir_config_domain_snapshot_disk_set_driver_type to

[libvirt] [libvirt-glib 5/6] gconfig: Add GVirConfigDomainSnapshotDisk getters/setters

2013-06-04 Thread Christophe Fergeau
--- .../libvirt-gconfig-domain-snapshot-disk.c | 85 ++ .../libvirt-gconfig-domain-snapshot-disk.h | 16 libvirt-gconfig/libvirt-gconfig.sym| 9 +++ 3 files changed, 110 insertions(+) diff --git

Re: [libvirt] [PATCH v3 07/12] LXC: fuse: Change files owner to the root user of container

2013-06-04 Thread Daniel P. Berrange
On Thu, May 23, 2013 at 12:06:51PM +0800, Gao feng wrote: Otherwise we will fail to mount the meminfo file. This patch also allows any users to access the fuse mount point. Signed-off-by: Gao feng gaof...@cn.fujitsu.com We actually need the following fix even without userns work: @@

Re: [libvirt] [libvirt-designer PATCHv3 6/9] Check for vioserial availability before adding a SPICE agent

2013-06-04 Thread Michal Privoznik
On 04.06.2013 16:33, Christophe Fergeau wrote: This makes use of the new gvir_designer_domain_get_supported_devices() method. --- libvirt-designer/libvirt-designer-domain.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git

Re: [libvirt] [libvirt-designer PATCHv3] Handle more devices in GVirDesignerDomain

2013-06-04 Thread Michal Privoznik
On 04.06.2013 16:33, Christophe Fergeau wrote: Hi, Resending once more, only change since v2 is a small fix in 1/9 to avoid calling g_str_has_suffix on a NULL string when no short_id is available. Christophe I think these patches are good. I feel comfortable giving my ACK. However,

Re: [libvirt] [libvirt-designer PATCHv3 5/9] Automatically add SPICE channel with SPICE graphics

2013-06-04 Thread Michal Privoznik
On 04.06.2013 16:33, Christophe Fergeau wrote: When the user sets up the graphical framebuffer to use SPICE, we now add automatically the SPICE agent channel if it's not present already. --- libvirt-designer/libvirt-designer-domain.c | 85 ++ 1 file changed, 85

Re: [libvirt] [libvirt-designer PATCHv3 8/9] Implement gvir_designer_domain_add_smartcard()

2013-06-04 Thread Michal Privoznik
On 04.06.2013 16:33, Christophe Fergeau wrote: This setups smartcard redirection to the guest. I'm not yet fully sure what users could want to tweak there (there are various ways of setting up the smartcard redirection), so this code may need to be made more flexible. The current code is also

Re: [libvirt] [libvirt-designer PATCHv3 4/9] Implement gvir_designer_domain_add_graphics()

2013-06-04 Thread Michal Privoznik
On 04.06.2013 16:33, Christophe Fergeau wrote: This allows to choose between SPICE, VNC or a local display, which will go through SDL or 'desktop' depending on the hypervisor. --- configure.ac | 2 +- examples/virtxml.c | 4 ++

Re: [libvirt] [libvirt-designer PATCHv3 2/9] Implement gvir_designer_domain_add_sound()

2013-06-04 Thread Michal Privoznik
On 04.06.2013 16:33, Christophe Fergeau wrote: --- examples/virtxml.c | 3 + libvirt-designer/libvirt-designer-domain.c | 131 + libvirt-designer/libvirt-designer-domain.h | 2 + libvirt-designer/libvirt-designer.sym | 1 + 4

Re: [libvirt] [libvirt-designer PATCHv3 7/9] Implement gvir_designer_domain_add_usb_redir()

2013-06-04 Thread Michal Privoznik
On 04.06.2013 16:33, Christophe Fergeau wrote: This will add an USB redirection channel to the VM. This can be called multiple times to redirect several USB devices at once. This will also adds the needed controllers if they are not already s/adds/add/ present in the VM. The current code

Re: [libvirt] [libvirt-designer PATCHv3 1/9] Improve VM skeleton created by gvir_designer_domain_setup_guest()

2013-06-04 Thread Michal Privoznik
On 04.06.2013 16:33, Christophe Fergeau wrote: Add various devices/configuration to libvirt XML config when creating the VM. This configuration is generic enough that it should be useful on all created VMs, that's why no public API is added to set them up. However, they are split in several

Re: [libvirt] [PATCH] Ensure non-root can read /proc/meminfo file in LXC containers

2013-06-04 Thread Eric Blake
On 06/04/2013 11:10 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com By default files in a FUSE mount can only be accessed by the user which created them, even if the file permissions would otherwise allow it. To allow other users to access the FUSE mount the

[libvirt] [PATCH] Ensure non-root can read /proc/meminfo file in LXC containers

2013-06-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com By default files in a FUSE mount can only be accessed by the user which created them, even if the file permissions would otherwise allow it. To allow other users to access the FUSE mount the 'allow_other' mount option must be used. This bug prevented

[libvirt] [PATCH] Ensure non-root can read /proc/meminfo file in LXC containers

2013-06-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com By default files in a FUSE mount can only be accessed by the user which created them, even if the file permissions would otherwise allow it. To allow other users to access the FUSE mount the 'allow_other' mount option must be used. This bug prevented

Re: [libvirt] [PATCH] build: only install examples when nwfilter is defined

2013-06-04 Thread Jim Fehlig
Eric Blake wrote: On 06/04/2013 08:43 AM, Jim Fehlig wrote: Only install nwfilter example XML files when WITH_NWFILTER is defined. Does this require any corresponding libvirt.spec.in file changes? I don't think so. I stumbled across this issue doing a client-only package

Re: [libvirt] [libvirt-glib 1/6] gconfig: Allow not found child in gvir_config_object_get_child_with_type

2013-06-04 Thread Michal Privoznik
On 04.06.2013 18:50, Christophe Fergeau wrote: This will be useful when implementing gvir_domain_snapshot_get_parent() as the child node 'parent' is not always present in the XML. --- libvirt-gconfig/libvirt-gconfig-object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [libvirt] [libvirt-glib 2/6] gconfig: Add GVirConfigDomainDiskFormat enum

2013-06-04 Thread Michal Privoznik
On 04.06.2013 18:50, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-domain-disk.h | 20 libvirt-gconfig/libvirt-gconfig.sym | 2 ++ 2 files changed, 22 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-disk.h

Re: [libvirt] [libvirt-glib PATCHv3 0/6] gconfig: Add classes/methods for snapshot configuration

2013-06-04 Thread Michal Privoznik
On 04.06.2013 18:50, Christophe Fergeau wrote: Hi, This is a resend of this patch series, the only changes since v2 is the rename of gvir_config_domain_disk_[gs]et_driver_type_enum to gvir_config_domain_disk_[gs]et_driver_format and the rename of

Re: [libvirt] [PATCH v2] nwfilter: grab driver lock earlier during init (bz96649)

2013-06-04 Thread Laine Stump
On 06/03/2013 06:39 PM, Stefan Berger wrote: This patch is in _relation_ to Bug 966449: https://bugzilla.redhat.com/show_bug.cgi?id=966449 Below is a possible patch addressing the coredump. Thread 1 must be calling nwfilterDriverRemoveDBusMatches(). It does so with nwfilterDriverLock

Re: [libvirt] [PATCH] build: only install examples when nwfilter is defined

2013-06-04 Thread Eric Blake
On 06/04/2013 11:32 AM, Jim Fehlig wrote: Eric Blake wrote: On 06/04/2013 08:43 AM, Jim Fehlig wrote: Only install nwfilter example XML files when WITH_NWFILTER is defined. Does this require any corresponding libvirt.spec.in file changes? I don't think so. I stumbled across

Re: [libvirt] [PATCH] Ensure non-root can read /proc/meminfo file in LXC containers

2013-06-04 Thread Gao feng
On 06/05/2013 01:10 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com By default files in a FUSE mount can only be accessed by the user which created them, even if the file permissions would otherwise allow it. To allow other users to access the FUSE mount the

Re: [libvirt] [PATCH] snapshot: remove mutually exclusive memory and disk-only duplicate check

2013-06-04 Thread Guannan Ren
On 06/04/2013 11:13 PM, Eric Blake wrote: On 06/04/2013 02:55 AM, Guannan Ren wrote: The work was done at the time of snapshot xmlstring parsing if (offline def-memory def-memory != VIR_DOMAIN_SNAPSHOT_LOCATION_NONE) { virReportError(...); } --- src/qemu/qemu_driver.c | 8

Re: [libvirt] [PATCH] maint: don't use config.h in .h files

2013-06-04 Thread Eric Blake
On 05/31/2013 11:54 AM, Eric Blake wrote: Enforce the rule that .h files don't need to (redundantly) include config.h. * cfg.mk (sc_prohibit_config_h_in_headers): New rule. (_virsh_includes): Delete; instead, inline a smaller number of exclusions...

Re: [libvirt] [PATCH v4 1/5] libvirt: Define domain crash event types

2013-06-04 Thread Eric Blake
On 06/02/2013 09:58 PM, Chen Fan wrote: This patch introduces domain crashed types and crashed reasons which will be used while guest panicked. --- examples/domain-events/events-c/event-test.c | 10 ++ include/libvirt/libvirt.h.in | 16

Re: [libvirt] [PATCH] maint: don't use config.h in .h files

2013-06-04 Thread Guannan Ren
On 06/05/2013 10:54 AM, Eric Blake wrote: On 05/31/2013 11:54 AM, Eric Blake wrote: Enforce the rule that .h files don't need to (redundantly) include config.h. * cfg.mk (sc_prohibit_config_h_in_headers): New rule. (_virsh_includes): Delete; instead, inline a smaller number of exclusions...